GitLab

We had a leftover call to InPlaceMenuDestroy without creating a menu in the first place.
This caused us to delete IE's menu and fail the first check inside ieframe!CDocObjectHost::OnInitMenuPopup.
It took a while to figure this out and even longer to figure out why our menu was NULL in this case and not mshtml's.

I don't think that there are any bad side effects with this change but I ask the reviewer to check.

The visible change is that the Print menu item will become enabled and visible whereas Page Setup will be disabled and Print Preview will (correctly atm) not be visible for GCF documents.

BUG=24034, 47074
TEST=See description above and bug report.

Review URL: http://codereview.chromium.org/3034033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53786 0039d316-1c4b-4281-b951-d872f2087c98

encoding menu on those pages.

BUG=48157
TEST=On the NTP, Wrench menu --> Tools --> Encoding is disabled. On normal web pages, it isn't.

Review URL: http://codereview.chromium.org/3027023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53785 0039d316-1c4b-4281-b951-d872f2087c98

BUG=49683
TEST=None

Review URL: http://codereview.chromium.org/3035015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53784 0039d316-1c4b-4281-b951-d872f2087c98

Add "MainMessageLoopStart()" and related platform methods to handle tasks
directly tied to the start of the main message loop.

BUG=none
TEST=everything still works

Review URL: http://codereview.chromium.org/2931007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53783 0039d316-1c4b-4281-b951-d872f2087c98

I was previously sloppy with DNSDomainFromDot. Really it should have
included a terminating NUL in the result string to represent the root
label, but it actually omitted it because it was more convenient to
test that way. This CL fixes that.

BUG=none
TEST=net_unittests

http://codereview.chromium.org/3070002/show

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53782 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3044022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53781 0039d316-1c4b-4281-b951-d872f2087c98

As of r2200 (in Chromium SVN now), the default value is "no".
As of r2344 (planned to check-in soon), the default value is "yes" but some false positive reports are not yet eliminated for this mode.
BUG=http://code.google.com/p/data-race-test/issues/detail?id=40
Review URL: http://codereview.chromium.org/3041024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53780 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3043020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53779 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/2870071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53778 0039d316-1c4b-4281-b951-d872f2087c98

Original CL http://codereview.chromium.org/3026006

Fixed problems with initial locale change freezing Chrome OS on the device.
Added creation of /home/chronos/.oobe_completed flag file.
Removed command line switches for testing customization manifests.
Added StringFetcher class implementation - URL fetcher that downloads content into std::string.
Refactored services customization integration.
Removed sample manifests from Chrome repository. They are submitted into Chromium OS repository at chromeos/src/platform/assets/oem_customization.

BUG=http://crosbug.com/1888
TEST=Manual. Changes to OEM customization manifests on partner partition, namely the initial locale, time zone, and startup page attributes should change OOBE UX accordingly.

Review URL: http://codereview.chromium.org/3064002

TBR= nkostylev@chromium.org

Review URL: http://codereview.chromium.org/2878056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53775 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/buildbot/memory/builders/Chromium%20OS%20UI%20(valgrind)(4)/builds/4053/steps/memory%20test:%20ui/logs/stdio
Example of the report:
Leak_DefinitelyLost
90 (24 direct, 66 indirect) bytes in 1 blocks are definitely lost in loss record 7,592 of 9,109
  operator new(unsigned int) (sr/local/google/valgrind-for-chromium-client/valgrind/scripts/valgrind-memcheck/coregrind/m_replacemalloc/vg_replace_malloc.c:262)
    (anonymous namespace)::IdMaps::IdMaps() (chrome/browser/chromeos/input_method/input_method_util.cc:51)
    DefaultSingletonTraits<(anonymous namespace)::IdMaps>::New() (./base/singleton.h:23)
    Singleton<(anonymous namespace)::IdMaps, DefaultSingletonTraits<(anonymous namespace)::IdMaps>, (anonymous namespace)::IdMaps>::get() (./base/singleton.h:198)
    chromeos::input_method::GetInputMethodDisplayNameFromId(std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (chrome/browser/chromeos/input_method/input_method_util.cc:487)
    LanguageOptionsHandler::GetInputMethodList() (chrome/browser/chromeos/dom_ui/language_options_handler.cc:73)
    LanguageOptionsHandler::GetLocalizedValues(DictionaryValue*) (chrome/browser/chromeos/dom_ui/language_options_handler.cc:57)
    OptionsUI::AddOptionsPageUIHandler(DictionaryValue*, OptionsPageUIHandler*) (chrome/browser/dom_ui/options_ui.cc:175)
    OptionsUI::OptionsUI(TabContents*) (chrome/browser/dom_ui/options_ui.cc:138)
    DOMUI* NewDOMUI<OptionsUI>(TabContents*, GURL const&) (chrome/browser/dom_ui/dom_ui_factory.cc:48)
    DOMUIFactory::CreateDOMUIForURL(TabContents*, GURL const&) (chrome/browser/dom_ui/dom_ui_factory.cc:174)
    TabContents::CreateDOMUIForRenderManager(GURL const&) (chrome/browser/tab_contents/tab_contents.cc:2964)
    RenderViewHostManager::UpdateRendererStateForNavigate(NavigationEntry const&) (chrome/browser/tab_contents/render_view_host_manager.cc:570)
    RenderViewHostManager::Navigate(NavigationEntry const&) (chrome/browser/tab_contents/render_view_host_manager.cc:76)
    TabContents::NavigateToPendingEntry(NavigationController::ReloadType) (chrome/browser/tab_contents/tab_contents.cc:782)
    NavigationController::NavigateToPendingEntry(NavigationController::ReloadType) (chrome/browser/tab_contents/navigation_controller.cc:1048)
    NavigationController::LoadEntry(NavigationEntry*) (chrome/browser/tab_contents/navigation_controller.cc:292)
    NavigationController::LoadURL(GURL const&, GURL const&, unsigned int) (chrome/browser/tab_contents/navigation_controller.cc:497)
    Browser::CreateTabContentsForURL(GURL const&, GURL const&, Profile*, unsigned int, bool, SiteInstance*) const (chrome/browser/browser.cc:2226)
    Browser::AddTabWithURL(GURL const&, GURL const&, unsigned int, int, int, SiteInstance*, std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) (chrome/browser/browser.cc:882)
    Browser::ShowSingletonTab(GURL const&) (chrome/browser/browser.cc:1030)
    Browser::ShowOptionsTab() (chrome/browser/browser.cc:1770)
    Browser::OpenOptionsDialog() (chrome/browser/browser.cc:1782)
    Browser::ExecuteCommandWithDisposition(int, WindowOpenDisposition) (chrome/browser/browser.cc:2100)
    Browser::ExecuteCommand(int) (chrome/browser/browser.cc:2154)
    AutomationProvider::ExecuteBrowserCommand(int, int, IPC::Message*) (chrome/browser/automation/automation_provider.cc:959)
    void DispatchToMethod<AutomationProvider, void (AutomationProvider::*)(int, int, IPC::Message*), int, int, IPC::Message&>(AutomationProvider*, void (AutomationProvider::*)(int, int, IPC::Message*), Tuple2<int, int> const&, Tuple1<IPC::Message&>*) (./base/tuple.h:684)
    bool IPC::MessageWithReply<Tuple2<int, int>, Tuple1<bool&> >::DispatchDelayReply<AutomationProvider, void (AutomationProvider::*)(int, int, IPC::Message*)>(IPC::Message const*, AutomationProvider*, void (AutomationProvider::*)(int, int, IPC::Message*)) (./ipc/ipc_message_utils.h:1269)
    AutomationProvider::OnMessageReceived(IPC::Message const&) (chrome/browser/automation/automation_provider.cc:371)
    IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const&) (ipc/ipc_channel_proxy.cc:206)

BUG=48130
TBR=glider,oshima
Review URL: http://codereview.chromium.org/3068006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53774 0039d316-1c4b-4281-b951-d872f2087c98

Port magic from GTMFadeTruncatingTextFieldCell to Chrome's GradientButtonCell, used by buttons in the bookmark bar.  Any button that inherits from this class will now get overflowing titles truncated with a nice gradient (same as tab titles), rather than the default ellipsis.

Using GTMFadeTruncatingTextFieldCell in this case wasn't feasible because bookmark buttons are subclasses of NSButtonCell and already use a bunch of specialized behavior provided by it.

BUG=45104
TEST=Add a bookmark to the bookmark bar and increase the length of it's title.  Once you get past a certain length, rather than truncate the title should fade out nicely.  Exactly in the same way long tab titles do.  Bookmark buttons with titles that aren't truncated should look exactly the same. Also test with Dolce & Gabbana theme which has inverted contrast.

Review URL: http://codereview.chromium.org/2806066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53773 0039d316-1c4b-4281-b951-d872f2087c98

TBR=timurrrr
BUG=50347,50348,50349,50345,50335,50334,50336

Review URL: http://codereview.chromium.org/3044027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53772 0039d316-1c4b-4281-b951-d872f2087c98

TBR=glider
Review URL: http://codereview.chromium.org/3064010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53771 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Tests that use a regular PrefService are green.

Review URL: http://codereview.chromium.org/3046023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53770 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50346
TBR=glider
Review URL: http://codereview.chromium.org/2847077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53769 0039d316-1c4b-4281-b951-d872f2087c98

Add test register form page.
Added extra debug logging.

Full cycle:
1. Register screen navigates to chrome://register (host page).
2. host page requests DOMUI for register form URL: getRegistrationUrl msg on DOM load event.
3. Once URL is received it is loaded in an iframe.
4. When register form is loaded it sends get_user_info msg via postMessage to host page.
5. host page requests DOMUI for system/user info: getUserInfo msg.
6. Once info is received host page sends that to an iframe with set_user_info msg.
7. Register form notifies host page on registration success/skip status with complete_registration msg.
8. Based on registration result host page navigates to cros://register/[success|skipped] so that Out of box wizard is notified.

BUG= http://crosbug.com/4813
TEST=manual

Review URL: http://codereview.chromium.org/3058006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53768 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53766 0039d316-1c4b-4281-b951-d872f2087c98

Implement the "Configure modifier keys" drop-down which enables users to swap Alt/Ctrl keys and Search/Ctrl keys.

BUG=chromium-os:2636
TEST=manually on eeepc

Review URL: http://codereview.chromium.org/3038025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53764 0039d316-1c4b-4281-b951-d872f2087c98

TBR=timurrrr

Review URL: http://codereview.chromium.org/3061020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53763 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3035026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53762 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50334,50335,50336
TEST=Linux Memcheck bot (3) should become green
Review URL: http://codereview.chromium.org/2856064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53761 0039d316-1c4b-4281-b951-d872f2087c98

* Removing library name from stack.
* Relaxing suppresion for 19775.
* Removing anonymous name part from 22450
* new suppressino for 46570. Chould have been merged to _b, but i wasn't sure if it's safe.
* 50304 relaxing suppression

TBR=glider@chromium.org
BUG=50304, 46570, 22450, 19775
TEST=chromeos valgrind should cycle green (crossing finger)

Review URL: http://codereview.chromium.org/3041023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53760 0039d316-1c4b-4281-b951-d872f2087c98

Several integration tests use the wrong method to wait for sync to complete, as a result of which they fail during verification.

Also making the condition for the detection of sync completion more robust.

BUG=50114
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/3037019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53759 0039d316-1c4b-4281-b951-d872f2087c98

TEST=confirmed that the layout names added in generated_resource.grd appear in the languages and input dialog. also confirmed that error messages are gone from logs.
BUG=chromium-os:3440

Review URL: http://codereview.chromium.org/3063007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53758 0039d316-1c4b-4281-b951-d872f2087c98

ChromeFrame cookie requests would incorrectly get routed to the first host browser connected to the renderer. This basically
meant that if the browser process exited then other popups could not query cookies from the host.

Part of the fix for http://b/issue?id=2277519

Bug=2277519

Review URL: http://codereview.chromium.org/3066004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53757 0039d316-1c4b-4281-b951-d872f2087c98

BUG=21276

Review URL: http://codereview.chromium.org/3028027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53755 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bulach
TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53754 0039d316-1c4b-4281-b951-d872f2087c98

Move utility functions into a header file (currently chewing and pinyin
are the customers).

TEST=manually check on the netbook by uncommenting TODO lines.
BUG=chromium-os:4808

Review URL: http://codereview.chromium.org/3015028
Patch from Takayoshi Kochi <kochi@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53753 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:2636
TEST=manually on eeepc, ran the browser_tests

Review URL: http://codereview.chromium.org/2806077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53752 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50300
TEST=mac intl2 tests are green
TBR=nsylvain@chromium.org

Review URL: http://codereview.chromium.org/3027028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53748 0039d316-1c4b-4281-b951-d872f2087c98

BUG=49997
TEST=ftp_directory_listing_parser_windows_unittest.cc

Review URL: http://codereview.chromium.org/3013029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53747 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bulach
TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53746 0039d316-1c4b-4281-b951-d872f2087c98

called after AtExitManager initialization, and call InitLogging() only
if !unit_test_mode.

InitLogging() needs AtExitManager because it uses PathService.

TEST=This is a part of test code.
BUG=none
Review URL: http://codereview.chromium.org/3030018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53743 0039d316-1c4b-4281-b951-d872f2087c98

Use EncoderZlib / DecoderZlib as default encoder and decoder.

BUG=50246

Review URL: http://codereview.chromium.org/3034035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53742 0039d316-1c4b-4281-b951-d872f2087c98

Cleanup: Rename gtk button state names to (a) match other platforms and (b) not be misleading (e.g. "depressed" where it should be "disabled").  Better indenting.  Inline a function that has only one caller for simplicity.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3029032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53741 0039d316-1c4b-4281-b951-d872f2087c98

Make the throbber and tab close button correctly respond to theme changes.  This is partly using GetThemeProvider() instead of ResourceBundle::GetSharedInstance(), and partly not caching SkBitmaps (which we used to do long ago but stopped because it's pointless).

BUG=50107
TEST=Throbber responds to theme changes
Review URL: http://codereview.chromium.org/3064006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53740 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53739 0039d316-1c4b-4281-b951-d872f2087c98

Encoder and decoder using zlib for chromoting. This implementation has zero
copy out of the decoder and encoder. The consequence is that we have to break
out the zlib stream into rect boundaries which requires the synchronication
flush feature in zlib. This feature will hurt compression ratio but the effect
still need to be measured.

This patch also provides tests for testing the Encoder and Decoder pair with
zlib.

TEST=remoting_unittests

Review URL: http://codereview.chromium.org/2868062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53738 0039d316-1c4b-4281-b951-d872f2087c98

Before this change, the language name and the input method list were
hard-coded in the HTML file. With this change, these values will be
displayed based on the underlying data from C++ world.

TEST=manually
BUG=chromium-os:4573

Review URL: http://codereview.chromium.org/3008016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53737 0039d316-1c4b-4281-b951-d872f2087c98