GitLab

BUG=627109

Review-Url: https://codereview.chromium.org/2126203002
Cr-Commit-Position: refs/heads/master@{#405972}

Revert of Credit card editor for PaymentRequest UI. (patchset #5 id:490001 of https://codereview.chromium.org/2116583002/ )

Reason for revert:
Broke Android Tests (dbg).

BUG=629011,624924

Original issue's description:
> Credit card editor for PaymentRequest UI.
>
> When user taps on an incomplete autofill credit card or [+ ADD CARD]
> button, the card editor launches.
>
> For server cards, the editor shows uneditable card information and lets
> the user set the billing address.
>
> For local cards, the editor shows the following fields.
>
> 1) A list of icons for supported card types.
>
> 2) The card number input with Luhn validation and formatting. Required
>    field.
>
> 3) The name on card input. Required field.
>
> 4) The month and year dropdowns. January of this year by default for new
>    cards.
>
> 5) The billing address dropdown with only complete addresses on disk and
>    an option to add a new address. Required field.
>
> 6) A checkbox for saving the new card on disk. Checked by default,
>    so it behaves similar to autofill settings.
>
> BUG=624924
>
> Committed: https://crrev.com/6c0897f84b3907e48ea75c1a8df6558134f28bea
> Cr-Commit-Position: refs/heads/master@{#405876}

TBR=mathp@chromium.org,dfalcantara@chromium.org,estade@chromium.org,rouslan@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

Review-Url: https://codereview.chromium.org/2158783002
Cr-Commit-Position: refs/heads/master@{#405971}

It is technically possible to build a fat binary that works on both
simulator and device, thus the use_ios_simulator value depends on
the cpu from the current toolchain (aka current_cpu) and not the
cpu from the default toolchain (aka target_cpu).

BUG=625875

Review-Url: https://codereview.chromium.org/2150433003
Cr-Commit-Position: refs/heads/master@{#405970}

For a fat build, the "ios_framework_bundle" and "framework_bundle"
are a bit different for the non-default toolchain. The main target
is a shared library (instead of a bundle) and the "+link" target
depends on the "+link" target of the default toolchain (because it
is a fat binary framework so it make sense to link against that one).

The fat shared library is created using "lipo" to concatenate all
the thin shared libraries together.

BUG=603180

Review-Url: https://codereview.chromium.org/2135323002
Cr-Commit-Position: refs/heads/master@{#405969}

Revert of [Payments] Add ability to bold parts of addresses (patchset #4 id:60001 of https://codereview.chromium.org/2135573004/ )

Reason for revert:
Android Test builder is failing since https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/35304

see https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/35304/steps/chrome_public_test_apk/logs/stdio

This may be one of two CLs that could have caused this (the other is https://codereview.chromium.org/2116583002). Since the two CLs have some files in common I'll start reverting this one first.

Original issue's description:
> [Payments] Add ability to bold parts of addresses
>
> * Add the ability to bold parts of a label.
>
> * Add the ability to show a tertiary label in the PaymentOption, which
>   will later be used for phone number display.
>
> * The phone number is passed in to the PaymentOption using the new constructor
>   via the AutofillAddress class.
>
> See crbug.com/626833 for screenshots.
>
> BUG=603635,626833
>
> Committed: https://crrev.com/92f4c6ac21b2578ab3938c5bd3eb0f793621164f
> Cr-Commit-Position: refs/heads/master@{#405900}

TBR=rouslan@chromium.org,mathp@chromium.org,dfalcantara@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=603635,626833

Review-Url: https://codereview.chromium.org/2158763002
Cr-Commit-Position: refs/heads/master@{#405968}

This ensures that either an exception is thrown, or a promise is
rejected, never both.

BUG=628526

Review-Url: https://codereview.chromium.org/2156583002
Cr-Commit-Position: refs/heads/master@{#405967}

Made StylePropertySet::getPropertyCSSValue return a const CSSValue*,
which is more semantically correct and safe. This also forces callers
to make copies of any CSSValues they want to edit before saving them
back to the style, making it clearer and more explicit when changes to
the style are made.

BUG=526586

Review-Url: https://codereview.chromium.org/2035373002
Cr-Commit-Position: refs/heads/master@{#405966}

1) Hide the menu if focus moves outside of the menu
2) Don't /always/ restore focus to the <paper-menu-button>

R=tsergeant@chromium.org
BUG=621842
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2153323002
Cr-Commit-Position: refs/heads/master@{#405965}

BUG=623871
TESTCASE=conformance2/query/occlusion-query.html
         conformance2/query/query.html
         deqp/functional/gles3/lifetime.html
         deqp/functional/gles3/negativefragmentapi.html
         deqp/functional/gles3/negativestateapi.html
         deqp/functional/gles3/occlusionquery_conservative.html
         deqp/functional/gles3/occlusionquery_strict.html
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2145363002
Cr-Commit-Position: refs/heads/master@{#405964}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4ae9f4a1..946f9cc0

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2155993002
Cr-Commit-Position: refs/heads/master@{#405963}

When ash-md is set to MATERIAL_EXPERIMENTAL by default, shelf has a
visible height of 0 whereas the visible height is 3 for non-MD.
Updated test cases GestureDrag, SetAlignment and AutoHide to match
the new value.

BUG=623432, 623430, 623429

Review-Url: https://codereview.chromium.org/2143033003
Cr-Commit-Position: refs/heads/master@{#405962}

Make CSSPropertyParser::parseSingleValue return a const CSSValue*
instead of a regular CSSValue*. This is an entirely mechanical change
that is more semantically correct and safe.

R=timloh@chromium.org
BUG=526586

Review-Url: https://codereview.chromium.org/2038363002
Cr-Commit-Position: refs/heads/master@{#405961}

Building w/ clang on CrOS detected an unused private member in
a CrOS-specific file in a particular combination of GN args :).

R=posciak@chromium.org, llozano@chromium.org
BUG=626240

Review-Url: https://codereview.chromium.org/2151653004
Cr-Commit-Position: refs/heads/master@{#405960}

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/4951bdd..c403207

BUG=
TEST=bots
TBR=kbr@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2153383002
Cr-Commit-Position: refs/heads/master@{#405959}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/24cc22cf..4ae9f4a1

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2159643003
Cr-Commit-Position: refs/heads/master@{#405958}

Cleaning up video-played* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Review-Url: https://codereview.chromium.org/2133223004
Cr-Commit-Position: refs/heads/master@{#405957}

If SharedBuffer is rarely lock()ed successfully after its unlock(), we can
remove SharedBuffer::unlock() without significant performance regressions.
To evaluate this assumption, this CL adds UMAs for SharedBuffer::lock() and
unlock() counts.

This CL also fixes ResourceType enum names in histograms.xml.
ResourceType enum is introduced in 2013 and left unmodified since then, but
it is now inconsistent with C++'s Resource::Type values.
Because ResourceType enum has been unused recently (it is referenced in
histograms.xml only from WebCore.ResourceFetcher.ResourceTypeUponCacheHit,
which doesn't have C++ counterpart nor UMA reports at least since 2016/01),
updating the ResourceType enum values in histograms.xml looks safe.

BUG=603791

Review-Url: https://codereview.chromium.org/2140513002
Cr-Commit-Position: refs/heads/master@{#405956}

Intent to deprecate and remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/EHy8zm0eVy0

BUG=586924

Review-Url: https://codereview.chromium.org/2140133005
Cr-Commit-Position: refs/heads/master@{#405955}

https://chromium.googlesource.com/skia.git/+log/cea22ae23495..eaf6d4102258

$ git log cea22ae23..eaf6d4102 --date=short --no-merges --format='%ad %ae %s'
2016-07-17 update-skps Update SKP version

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review-Url: https://codereview.chromium.org/2161483002
Cr-Commit-Position: refs/heads/master@{#405954}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5ab932bf..24cc22cf

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2156863002
Cr-Commit-Position: refs/heads/master@{#405953}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/7de849b81d47..8ae70d714551

$ git log 7de849b81..8ae70d714 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2153363002
Cr-Commit-Position: refs/heads/master@{#405952}

Cr-Commit-Position: refs/heads/master@{#405951}

Instead of starting up the backend, we now don't even start it up if the first
setup completed flag is false, unless a setup is in progress. On auto start
platforms, first setup completed is manually set to true as part of init.

BUG=624915

Review-Url: https://codereview.chromium.org/2159453002
Cr-Commit-Position: refs/heads/master@{#405950}

https://chromium.googlesource.com/skia.git/+log/280d537e2893..cea22ae23495

$ git log 280d537e2..cea22ae23 --date=short --no-merges --format='%ad %ae %s'
2016-07-16 kolczyk Guard SkMatrix::get*Scale[s]() against negative nearly-zero values.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2156843002
Cr-Commit-Position: refs/heads/master@{#405949}

After the redirect, we shouldn't attempt to load the previous child
items in the new page.

BUG=585194
TBR=clamy
TEST=http/tests/navigation/back-to-redirect-with-frame.php
     in --isolate-sites-for-testing=*.is mode.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2136873002
Cr-Commit-Position: refs/heads/master@{#405948}

This links the router element to the new-style route list.

BUG=608115
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2153113003
Cr-Commit-Position: refs/heads/master@{#405947}

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/1eb6562..4951bdd

BUG=
TEST=bots
TBR=qiankun.miao@intel.com
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2158693002
Cr-Commit-Position: refs/heads/master@{#405946}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e7331d48..5ab932bf

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2147153008
Cr-Commit-Position: refs/heads/master@{#405945}

Revert of Launch CFI for virtual calls on Linux x86-64. (patchset #2 id:20001 of https://codereview.chromium.org/2140373002/ )

Reason for revert:
Too many blink_perf.layout benchmarks regressed by ~3.5%. While the regressions are within predicted upper bound, there're too many of them to ignore:

https://chromeperf.appspot.com/report?sid=ebf0165d8c96c7a70c790d179a9bdc1f9e58e616182522fd961d17ad648fc28f&start_rev=404312&end_rev=405943

We will need to reevaluate the reason for such consistent slowdown and will make another attempt after it's cleared.

Original issue's description:
> Launch CFI for virtual calls on Linux x86-64.
>
> This is the second incremental step towards the full CFI launch.
> In the first step, we enabled LinkTimeOptimization (LTO) for the
> official Chrome builds. In this step we add Control Flow Integrity
> checks for all virtual calls.
>
> The remaining part is to add bad-cast checks to ensure the forward-edge
> Control Flow Integrity works as planned. That remaining part will
> require more work on reducing the overhead for size and speed by these
> CFI checks, so we don't enable them right away.
>
> The expected Perf impact by this CL:
>
> - Chrome binary size is increased by 5%,
> - Some of the benchmarks are slowed down by up to 3.5%.
>
> Note that before making it slower, we made it faster by implementing
> virtual const propagation and a number of heuristics for automatic
> devirtualization in LLVM which sped up some layout benchmarks by up to 7%
> (see https://crbug.com/580389 and https://crbug.com/617283)
>
> If there's a higher (negative) impact, we'll be willing to roll this
> feature back, but please allow the Perf bots to work for a day or two
> to collect more detailed statistics on the regressions, as it will help
> us to identify ways to speed it up (most likely, by inventing new ways
> for automatic devirtualization).
>
> BUG=464797
>
> Committed: https://crrev.com/01f474c48200a1e556a4cf668e2b5dbda0f38a6f
> Cr-Commit-Position: refs/heads/master@{#405894}

TBR=thakis@chromium.org,esprehn@chromium.org,krasin@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=464797

Review-Url: https://codereview.chromium.org/2154993002
Cr-Commit-Position: refs/heads/master@{#405944}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/82a881ed..e7331d48

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2161473002
Cr-Commit-Position: refs/heads/master@{#405943}

Store a map of link enabled states so that we can use it to enable next
visibile view on hidding active view. Map is ordered so it works to iterate it.

BUG=616382
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2121763002
Cr-Commit-Position: refs/heads/master@{#405942}

In Chrome terminology, a Display corresponds to a single physical output
CRT or LCD. However, Display represents a connection to the compositor
in Wayland so we need to rename WaylandDisplay to WaylandConnection in
order to avoid terminology confusion.

See discussion here:
https://codereview.chromium.org/2042503002/#msg21

BUG=none

Review-Url: https://codereview.chromium.org/2147523003
Cr-Commit-Position: refs/heads/master@{#405941}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/81943068..82a881ed

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2157473003
Cr-Commit-Position: refs/heads/master@{#405940}

Cr-Commit-Position: refs/heads/master@{#405939}

BUG=602538
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2146553005
Cr-Commit-Position: refs/heads/master@{#405938}

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/ce8f6bb..1eb6562

BUG=
TEST=bots
TBR=kbr@chromium.org,cwallez@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2158663002
Cr-Commit-Position: refs/heads/master@{#405937}

https://chromium.googlesource.com/skia.git/+log/f0c30f55665e..280d537e2893

$ git log f0c30f556..280d537e2 --date=short --no-merges --format='%ad %ae %s'
2016-07-15 bungeman Revert of Rotate emoji with FreeType. (patchset #5 id:80001 of https://codereview.chromium.org/2139703002/ )
2016-07-15 abarth Add support for Fuchsia GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2152273002
2016-07-15 bungeman Rotate bitmap strikes with FreeType.
2016-07-15 reed move responsibility for creating raster-device into pdf
2016-07-15 msarett Speculatively fix Android automerger
2016-07-15 msarett Add capability for SkColorXform to output half floats
2016-07-15 egdaniel Dont allocate a new image which already has mip levels, when regenerating vulkan mipmaps
2016-07-15 halcanary SkPdf: smaller color serialization

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2154063002
Cr-Commit-Position: refs/heads/master@{#405936}

This resolves build failures using gcc under "cros chrome-sdk" due to
-Werror=conversion-null. See bug for full build error log.

BUG=628667
TEST=ash_unittests builds under "cros chrome-sdk"

Review-Url: https://codereview.chromium.org/2155693003
Cr-Commit-Position: refs/heads/master@{#405935}

Currently, the selectors in styles sidebar pane are rendered each in a
separate span, which makes them ctrl-clickable.

This is needed to help in SourceMap debugging, as different selectors
might be coming from different places in sources. (see crbug.com/266416)

However, as it generates a lot of DOM nodes, this patch stitches unmatched
selectors together in a single element. The selectors, however,
are rendered separately as the user hits Ctrl and hovers over the section.

BUG=628409
R=pfeldman, dgozman

Review-Url: https://codereview.chromium.org/2146233003
Cr-Commit-Position: refs/heads/master@{#405934}

This finishes the work in bug 625353 to make
v8_target_cpu/v8_current_cpu work correctly across multiple
toolchains, by deleting the workaround that was needed to
get the changes to land across repos.

TBR=machenbach@chromium.org
BUG=625353

Review-Url: https://codereview.chromium.org/2157733002
Cr-Commit-Position: refs/heads/master@{#405933}