- 11 Nov, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605052680-a273e99b05826791587df478a7f9bb5649ddafe2.profdata to chrome-win64-master-1605063577-aa3ba3d5531ffbb5406af499dbbeda6119384c8a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id32952fdd21846dc93cc469cf4e97ee1bd3401cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532113Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826269}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605074376-17305034aff73b05198b9237e079057ca0c6d5db.profdata to chrome-linux-master-1605095997-0fa3ee75d8821b5496131dad83892a7849a68c0e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1c94e7fd5561ef45a1e59f2dc6f5071403b4cb97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532635Reviewed-by:
-
Morten Stenshorne authored
This reverts commit d4fbfee2. Reason for revert: Reverting because it's on top of https://chromium-review.googlesource.com/c/chromium/src/+/2518774 , which needs to be reverted, because of crbug.com/1147311 Original change's description: > Read later: Add a method to notify update for reading list backend. > > Adds an observer method to notify update for reading list backend. > > Bug: 1139133 > Change-Id: Ic5483e075086d48334a9e347125048b5699c2560 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519151 > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Brandon Wylie <wylieb@chromium.org> > Commit-Queue: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825086} TBR=dtrainor@chromium.org,twellington@chromium.org,wylieb@chromium.org,xingliu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1139133 Change-Id: I89026b82f1760fbb83e80b8723a9329d323211b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532074Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#826267}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/72d9975b027f..3630044b6610 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mstensho@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mstensho@google.com Change-Id: I9e5dc2d6c4c175200f8967f06af25b1e09acb08a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532617Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826266}
-
Christian Dullweber authored
This reverts commit cdf050f6. Reason for revert: The transition doesn't yet look right and is causing some crashes (crbug.com/1147794) Original change's description: > Animate PageInfo height changes > > Create a transition to animate changes in height when switching between > PageInfo subpages. > > Video: https://crbug.com/1077766#c92 > Bug: 1077766 > Change-Id: I5fb7392db017951e80cce162d11e17240b3eacd0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517454 > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Reviewed-by: Ehimare Okoyomon <eokoyomon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825285} TBR=dullweber@chromium.org,eokoyomon@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1077766, 1147794 Change-Id: Ie5b554f3ff3bcc6a728cda79a4ca1728e2bc9b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531784Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#826265}
-
Ossama Mahmoud authored
Bug: 1143300 Change-Id: If08a81832077820d7950f72982e5d704b21193b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507470 Commit-Queue: Ossama Mahmoud <osamafathy@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#826264}
-
Peter E Conn authored
This CL changes the keys for Purchase fields in the ListPurchases result to be preceded by "purchaseDetails" instead of "listPurchases". Since we're still in development, there are no users of the old values. It also changes a key name to spell out MICROSECONDS since MS is misleading. Change-Id: I4a29cf367e20469dab9d69ea38215361ea69b84f Bug: 1139795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529550 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#826263}
-
Jan Wilken Dörrie authored
This change modifies HttpAuthManagerImpl to not invoke ProvisionallySaveForm in case the submitted HTTP auth dialog contains an empty password. Fixed: 1147249 Change-Id: I74305bc30285fd87c56f6ff9babd28edfb0b897d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532215Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#826262}
-
Morten Stenshorne authored
This reverts commit 12e1e936. Reason for revert: Still flaky. https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42775 Original change's description: > Re-enable some oobe configuration tests > > Tests are not flaky (tested with setting affinity + running stress > in parallel). > > Fixed: 997685 > Change-Id: I565c0753a5e2841794b8873de4e22b19dfd79f05 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529353 > Reviewed-by: Renato Silva <rrsilva@google.com> > Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826244} TBR=antrim@chromium.org,rrsilva@google.com Change-Id: I242fe22b863af581e4b35d0cc1b92e2aaaf7ff68 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532575Reviewed-by:
-
Clemens Arbesser authored
This CL adds a basic integration framework to allow writing integration tests for trigger scripts. This is done analogous to the existing way for regular scripts. However, the new way of injecting the request sender directly (rather than a test service) is much more generic and should in the mid-term replace the older way. This CL also fixes several small issues that surfaced during testing: - Fixed issue where an empty callout message would be shown. - Fixed issue where the first time user flag was set too early. - Fixed issue where the Facade would not correctly trigger the new trigger scripts. Bug: b/171776026 Change-Id: I7c5a77cd317996d58db57026e322fd982dfacdf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524530 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#826260}
-
sandromaggi authored
mocks: https://www.figma.com/file/b1CT6jM3mj0MdBvgQicy4b dd: https://docs.google.com/document/d/1ZnmJUYFBEiIx8TjQPxD18e7NAeJa6yIBamAJyR-ggOk TBR=wylieb@chromium.org Bug: 1117271 Change-Id: I618b07e4698721443df44b08a4f080bd7b8d76b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520172Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Auto-Submit: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#826259}
-
Clemens Arbesser authored
This CL splits the ServiceRequestSender into interface and implementation. The immediate use case is to allow integration tests to create their own java-driven instance. Bug: b/171776026 Change-Id: I32b914afc2807949354727c5741d0bbc8b184cbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524529 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
-
Felipe Andrade authored
Move Kerberos settings functionalities from PeopleSection into KerberosAccountsHandler. This includes updating search tags, adding load time strings and registering section hierarchy. These methods will be called from PeopleSection if KerberosSettingsSection flag is disabled. Otherwise, these methods will be called from the new KerberosSection (to be created). Bug: 983041 Change-Id: Ida54d5fb9979e9c784def21146e1e474175490dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465917 Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#826257}
-
Clemens Arbesser authored
This CL plumbs the necessary JNI calls to set trigger script UI via native protos. Bug: b/171776026 Change-Id: I0786aca9a88389f09b38552f7d9612943c15f40b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524528 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6835e1ab1918..0d4297e6b205 2020-11-11 hjd@google.com Merge "trace_processor: Output dpu and g2d events as systrace" 2020-11-11 treehugger-gerrit@google.com Merge "Early return if there is no active client." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id4489eb87baf9f4623f742bf9bd99ac324ecc7a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531903Reviewed-by:
-
Danil Chapovalov authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/e9e9b9fc74..a4798817e8 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/e9e9b9fc74..a4798817e8 Bug: None Change-Id: Ic3de112f7c9f241984b6d8e9fdce79c0b043469b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532257 Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Auto-Submit: Danil Chapovalov <danilchap@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#826254}
-
Patrick Brosset authored
The approach taken here is one where we attempt to determine the flex lines without making changes to the flex implementation. The information about flex lines is not kept by the implementation, and one way would be to keep it when devtools need it. However, it seems feasible to determine this from devtools code directly, so this is what we're trying here. The way this works is: - iterate through items in the main direction - if an item's margin box starts before the previous item's margin box ends, then it belongs to a new flex line - we build lines in a way that they are always as big as necessary to contain all of their items in the cross direction, and we make them as big as the container in the main direction. Front-end CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2507790 Bug: 1139949 Change-Id: I6a385124f35d503ebae7f31cf36ebbf42beede20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514073Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Cr-Commit-Position: refs/heads/master@{#826253}
-
Mark Mentovai authored
This deprecates the xcode_12_beta mac_xcode_version .gclient custom_vars setting. “xcode_12_beta” now points to the same hermetic toolchain package as “default”. “xcode_12_beta” is also deprecated in favor of “default”. A few easy users of xcode_12_beta have been transitioned to default, but most (including arm64 bot recipes) remain. A future follow-up will switch them back to default. Developers targeting arm64 will also need to remove this setting. In switching to the 11.0 SDK, it’s possible to remove a few hacks, mostly related to the operating system version number lies that the system would tell when built against the 10.15 SDK (and earlier). These hacks are removed. Bug: 1108831, 1108832, 1115294, 1146078 CQ-Include-Trybots: luci.chromium.try:mac-arm64-rel Change-Id: I86c7a698c7d68f3d42f93cf2410a7c540a66a82b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530914 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#826252}
-
Shakti Sahu authored
This CL : 1 - Connects context menu read later item to downloads backend. 2 - Adds reading list item when context menu is clicked Bug: 1145825 Change-Id: Id8225bcdf74373ad2a1165698420195863e22d58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520085 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#826251}
-
Mohamed Amir Yosef authored
... in the password autofill dropdown. If the user opted to never save passwords for a specific website, it might be confusing to see a dropdown menu item with a promo for account storage. This CL add a feature to suppress that. Bug: 1144755 Change-Id: I149b2630587f1afefebbb7a673b3c07d9593c97f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531774Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#826250}
-
Roman Sorokin authored
It eliminates <Screen>::Get functions. Bug: none Change-Id: I179ed400fee945c0008ddbc960fcd51161d303fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523180Reviewed-by:
-
Mark Brand authored
Bug: 1133812 Change-Id: I32e8fafc3c4a190a5b1f6be905bf2f1f829b473f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503556Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Mark Brand <markbrand@google.com> Cr-Commit-Position: refs/heads/master@{#826248}
-
Jan Wilken Dörrie authored
This change adds a new base::Feature to control processing of additional server predictions during the form parsing stage. Populating these additional fields is a recent server side change (http://cl/340884706) only taking effect in Chrome M88+. This feature allows measuring the impact of these new suggestions as part of a A/B experiment. Bug: 1140493 Change-Id: I3741368e301c58c5adf7be21ac2947bf0d792e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529552 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3c2e89501c78..184f98a6b7b4 2020-11-11 jacktfranklin@chromium.org Allow DataGrid to take custom cell renderers 2020-11-11 aerotwist@chromium.org [Web Vitals] Lock the panel height to 120px 2020-11-11 aerotwist@chromium.org [unit test] Add AnimationModel instantiation test 2020-11-11 pfaffe@chromium.org Get rid of a timeout in a test 2020-11-11 szuend@chromium.org [issues] Move first batch of SameSite issue descriptions to Markdown 2020-11-11 szuend@chromium.org TypeScript-ify NetworkPersistenceManager.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1112692,chromium:1125465 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I02588107e5fb3416516a6d3d2fc72628b1b6e56d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531860Reviewed-by:
-
Clemens Arbesser authored
This will allow classes other than UiControllerAndroid to use these methods. It would probably be a good idea to move all similar JNI calls each into their own classes, but that's beyond the scope of this CL. Bug: b/171776026 Change-Id: If0825557d23150d5ca94fec6dec208074abb6895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524527 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#826245}
-
Denis Kuznetsov authored
Tests are not flaky (tested with setting affinity + running stress in parallel). Fixed: 997685 Change-Id: I565c0753a5e2841794b8873de4e22b19dfd79f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529353Reviewed-by:
Renato Silva <rrsilva@google.com> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#826244}
-
Jan Wilken Dörrie authored
This change exposes TrackAutofilledElement in the public interface of PasswordAutofillAgent, allowing its use for tracking fields that the user triggered password generation on. Bug: 1140497 Change-Id: Iad42fb4d23bf98d72904b9cbf2e08689cd4d3070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527026Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#826243}
-
Morten Stenshorne authored
Full test name: WebBluetoothTestWithNewPermissionsBackendEnabled.WebBluetoothIdsUsedInWebBluetoothScanning TBR=msw@chromium.org Bug: 1147582 Change-Id: I03680033d9768aba32e6c3037b6b981b2bd4ed77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531779Reviewed-by:
-
Morten Stenshorne authored
This reverts commit c0d846b5. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/110118 Original change's description: > input[type=file]: Ignore the 'overflow' property > > For a historical reason, some form controls always clip the content, > and should ignore the 'overflow' property. File upload control NG had > a regression that it accepts overflow:visible. This CL disables it > again. The new behavior is compatible with Safari and Firefox. > > Bug: 1139629 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng_disabled > Change-Id: I6b0b5a715a2c859f195bbf2473ead67cd22bd14d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528812 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825813} TBR=yosin@chromium.org,tkent@chromium.org,kojii@chromium.org Change-Id: I805124707d070cb15348453107884d58ca5998a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1139629 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng_disabled Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531998Reviewed-by:
-
Morten Stenshorne authored
Full test name: DownloadExtensionTest.DownloadExtensionTest_OnDeterminingFilename_EmptyBasenameInvalid TBR=qinmin@chromium.org Bug: 1147804 Change-Id: I42d8fd39e2d2181045c7343c872c9d2f4665f729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532573Reviewed-by:
-
Makoto Shimazu authored
Currently SharedWorkerServiceImpl::CreateWorker creates a worker in the same process as the creator. When the surrounding agent cluster of the creator and the surrounding agent cluster of the shared worker have different cross-origin isolated value to each other, they need to be hosted by different renderer processes. This CL creates another SiteInstance for a shared worker so that it can live in another process. This CL is based on https://crrev.com/c/2469421. Tbr: fdoray@chromium.org Bug: 1131403 Change-Id: I1e0edfe6b8b8891823a8cb473e5755bf087084b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486903 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#826239}
-
Jan Wilken Dörrie authored
This change removes the term blacklist from components/password_manager/content and migrates legacy MOCK_METHODn macros to MOCK_METHOD. This allows ensuring at compile time that these functions actually override methods from the parent class. Bug: 1147799 Change-Id: Ia62b402acb7b347f52a4d67050edf759f9938e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532457Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#826238}
-
Morten Stenshorne authored
TBR=ricea@chromium.org Bug: 1140193 Change-Id: I307538b3ea10421e5c925e45bd639d0b47021455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532454Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/72c6320cdd88..72d9975b027f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mstensho@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mstensho@google.com Change-Id: I0d9c83408aaa11deaa949bf7164f8dea2b511529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532115Reviewed-by:
-
Maksim Sisov authored
On CQ, we have some browser and views tests disabled. Apply this config for CI as well. TBR=dpranke@google.com Bug: 1147798 Change-Id: I0b03b2f3991b02a9bf9f11fe1a6f765cabcd99e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532455Reviewed-by:
Maksim Sisov (GMT+2) <msisov@igalia.com> Commit-Queue: Maksim Sisov (GMT+2) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#826235}
-
Finnur Thorarinsson authored
New fields: 'description', 'categories' and 'screenshots'. Bug: 1146450 Change-Id: I8d104ed2ccc38e67cc84c873026b6f24a82a75b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523178 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#826234}
-
Morten Stenshorne authored
Someone on the Fuchsia team should investigate this. Looks like many tests are flaky here. TBR=ddorwin@chromium.org Bug: 1146486 Change-Id: I8a744d8b8dc7581c661c95ae8cda1fd87aa70a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532456Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ibf8c4dc903c2866664ff9f8a1708d69b6cb62aba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531857Reviewed-by:
-
Felipe Andrade authored
Add a translatable string for the title of the new Kerberos OS settings section. This section will be added in the future, but a screenshot of the modified page is already been uploaded with this CL. Bug: 983041 Change-Id: Ib2c1c71451d6ff30869f1d10e64e0d28718765a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485491 Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
This reverts commit ac21d86a. Reason for revert: Still doesn't compile. https://ci.chromium.org/p/chrome/builders/ci/win64-chrome/9935 Original change's description: > Reland "Deprecate uninstall_metrics." > > This is a reland of e15311e1 > > Original change's description: > > Deprecate uninstall_metrics. > > > > Remove the tracking/persisting of these metrics in prefs. Removed > > uploading in uninstaller. > > > > Bug: 1107516 > > Change-Id: I84499820cea86b5f785949d9274e8b2205714aae > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308133 > > Reviewed-by: Tommy Li <tommycli@chromium.org> > > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > > Reviewed-by: Greg Thompson <grt@chromium.org> > > Commit-Queue: Robert Kaplow <rkaplow@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#825461} > > Bug: 1107516 > Change-Id: Id7a71c3b8d64dbe9984b2f7f33808207071550f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528581 > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826222} TBR=antrim@chromium.org,rkaplow@chromium.org,ntfschr@chromium.org,grt@chromium.org Change-Id: I22b186a34338818e820cac434cf826ba88aa6cb3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1107516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532574Reviewed-by:
-
