GitLab

Ordering guarantees required here are very weak, as it merely gathers aggregate
stats about hash table use and external synchronization is expected if precise
results are required.

Did a quick local test to confirm that it still works correctly.

Bug: 736037
Change-Id: Icc780ad38cd62474f2c21a973dfc393d5aa1ab75
Reviewed-on: https://chromium-review.googlesource.com/c/1352577
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612059}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/44d4b29082f0..9af233a50848


git log 44d4b29082f0..9af233a50848 --date=short --no-merges --format='%ad %ae %s'
2018-11-29 tikuta@chromium.org introduce ninjalog_uploader to autoninja


Created with:
  gclient setdep -r src/third_party/depot_tools@9af233a50848

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:900161
TBR=agable@chromium.org

Change-Id: I3e394b0369d5f83fe779729468d458c89b0602c5
Reviewed-on: https://chromium-review.googlesource.com/c/1354626Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612058}

Following bot results are included.
12104 12107 12114 12120 12125 12137 12141 12149 12155 12158
12165 12173 12175 12179 12183 12191 12199 12202 12209 12215
12216 12221 12231 12240 12244

2 lines were removed and 2 lines were deflaked by consecutive
results since 12179.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Change-Id: I156fb782a414ab84dba53cb72620aa0cae03dca0
Reviewed-on: https://chromium-review.googlesource.com/c/1350438
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612057}

In Notification Center, a notification slides out of the screen when
it's removed. When a notification is removed by touch gesture, it's
natural to respect the direction the user swiped.

See the #6 of the bug for detail.

TEST=manual
BUG=882522

Change-Id: I89389a9e9c0297db855227eece2fe42369d2f96e
Reviewed-on: https://chromium-review.googlesource.com/c/1353057Reviewed-by: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612056}

ArcAppListPref's browser-side cache of ARC apps may become out of date
with the ARC container, as the async IPC communication pipe between
container and browser may be flaky, or be established after the
container has processed some package installations/removals. This means
observer classes which follow the OnPackageAdded or OnPackageRemoved
calls may miss installations/uninstallations.

This CL augments ArcAppListPrefs::OnPackageListRefreshed to additionally
call observers if it detects packages which have been installed or
uninstalled which it has not yet seen.

BUG=893927

Change-Id: Icd069fdc89e348918f1185102e566bfc772087e3
Reviewed-on: https://chromium-review.googlesource.com/c/1345705Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612055}

This CL has no user-visible behavior changes.

Bug: 768828
Change-Id: Ia6d694fdc2a82f098a6ac915ad90127fc4bc3c4c
Reviewed-on: https://chromium-review.googlesource.com/c/1354722Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612054}

Convert X*, cssvalue::* allocations from new to MakeGarbageCollected

Bug: 757708
Change-Id: I105688f79bde5a58fe13f00e68b064264789bf81
Reviewed-on: https://chromium-review.googlesource.com/c/1353064
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612053}

This reverts commit 07ee5f0f.

Reason for revert: StartTestServer(SpawnedTestServer::SSLOptions())
started failing after this CL

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/17143

[ RUN      ] SSLClientSocketReadTest.Read_WithSynchronousError/0
[56283:775:1128/182253.758810:39802574526192:ERROR:local_test_server_posix.cc(79)] poll() timed out; bytes_read=0
[56283:775:1128/182253.758860:39802574568901:ERROR:local_test_server_posix.cc(167)] Could not read server_data_len
[56283:775:1128/182253.760826:39802576544202:ERROR:ssl_client_socket_unittest.cc(830)] Could not start SpawnedTestServer
../../net/socket/ssl_client_socket_unittest.cc:1532: Failure
Value of: StartTestServer(SpawnedTestServer::SSLOptions())
  Actual: false
Expected: true
Stack trace:
0   net_unittests                       0x000000010f41750b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91
1   net_unittests                       0x000000010f416ec9 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89
2   net_unittests                       0x000000010e7d9239 net::SSLClientSocketReadTest_Read_WithSynchronousError_Test::TestBody() + 585

[  FAILED  ] SSLClientSocketReadTest.Read_WithSynchronousError/0, where GetParam() = false (10083 ms)

Original change's description:
> Generalize for non-address results in HostResolverImpl
> 
> Now extensively using HostCache::Entry internally (but only internally
> to preserve flexibility of HostCache) as a generalized results
> container within HostResolverImpl. Added some needed setter/merge
> functionality to Entry for that purpose.  Many methods within the
> resolver changed to use Entry for consistency even if they only ever
> deal with address results, eg ResolveAsIP().
> 
> Slightly modified results port-setting functionality to only set port
> to an input port (from |host.port()|) if the port in the results is 0
> (where before it would set it whenever it wasn't equal to the input
> port).  This will be necessary eg for SRV support where DNS provides a
> specific port that needs to be maintained in the results. Also cleaned
> up the port setting to consistently only ever happen just before
> setting results on the RequestImpl and having 0 or a DNS-provided port
> until then.
> 
> Bug: 846423
> Change-Id: I679c0ac915e0f81b49adb5ee769f250be49c9c90
> Reviewed-on: https://chromium-review.googlesource.com/c/1340835
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Commit-Queue: Eric Orth <ericorth@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611963}

TBR=mmenke@chromium.org,ericorth@chromium.org

Change-Id: Icc3121b6f6de985fb64ed9b2bee4951faf5378a3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 846423
Reviewed-on: https://chromium-review.googlesource.com/c/1354746Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612052}

Currently, the Windows allocator shims do not hook _msize() causing
sporadic crashes when GWP-ASan is enabled. This occurs because sqlite3
uses _msize() and the native implementation does not properly handle
allocations not returned by the native allocator.

Furthermore, the current (unused) implementation of
WinHeapGetSizeEstimate() seems to be an artifact of the original
implementation from crrev.com/2163783003. It incorrectly increases the
size estimate returned by the native allocator, which can cause
exceptions in sqlite3 (there are routines that will read the _msize of
an allocation and assume the returned size forms a safe bound.) I
changed this routine to just return the allocation size returned by the
native allocator.

Bug: 909720
Change-Id: Ie8975053992161cdc3e447f75733345f0a142978
Reviewed-on: https://chromium-review.googlesource.com/c/1354219
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612051}

ElementRareDate::TraceAfterDispatch did not trace the part_ field. The fix is to
make it trace it.

Bug: 909609
Change-Id: I8fd00e7613af69272ff12298b0ea33d6494f80e5
Reviewed-on: https://chromium-review.googlesource.com/c/1354740Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612050}

Zero'ed timestamps means the build output is the same for each run,
which is generally desireable.

I checked that these two files were the same before/after:
 * cronet_api-src.jar
 * cronet_impl_common_java-src.jar

Where "the same" means they no longer contain directory entries
and also no "META-INF/MANIFEST.MF" file.

Bug: 383340
Change-Id: I4f644378dc3c33e429010509202011dd7b7f9f95
Reviewed-on: https://chromium-review.googlesource.com/c/1351425
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612049}

Drive-by: Fix an exception when a selected node is panned offscreen.

BUG=901165

Change-Id: I26ae15f3506f89a93e3f91f5aa6715c3f0033b1a
Reviewed-on: https://chromium-review.googlesource.com/c/1352627
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612048}

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests/74067

TBR=alph@chromium.org

Bug: 905772
Change-Id: Ibd7635ff2a66eb387443775210439c167a8aa14f
Reviewed-on: https://chromium-review.googlesource.com/c/1354743Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612047}

This updates web test expectation for following files for Mac bots:
 - fast/forms/color/color-suggestion-picker-appearance-zoom200.html
 - fast/forms/select/select-popup-pagekeys.html
 - fast/forms/textarea/textarea-metrics.html
 - svg/zoom/page/zoom-zoom-coords.xhtml
 - virtual/mouseevent_fractional/fast/events/hit-test-clip-path-reference.html
 - virtual/user-activation-v2/fast/events/hit-test-clip-path-reference.html

This patch is a follow-up the CL[1] which missed to update this expectation.

[1] http://crrev.com/c/1350443 Utilize NGInlineNode::GetOffsetMapping() in Element#innerText

TBR=tschumann@google.com

Bug: 909694
Change-Id: Id77b295033998c31243301cc93930613136b35c8
Reviewed-on: https://chromium-review.googlesource.com/c/1354742Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612046}

Currently call sites use both ContentSecurityPolicy::ShouldBypassMainWorld and
ScriptController::ShouldBypassMainWorldCSP to check if they should bypass the
main world CSP. This CL removes ScriptController::ShouldBypassMainWorldCSP and
consolidates all the call sites to use
ContentSecurityPolicy::ShouldBypassMainWorld.

BUG=896041

Change-Id: If8f5dda84da5ffcabb94b075173614cc5136f35b
Reviewed-on: https://chromium-review.googlesource.com/c/1331029Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612045}

This reverts commit 1b420fdb.

Reason for revert: Makes PreviewsNoScriptBrowserTest and 
ResourceLoadingHintsBrowserTest flaky

https://crbug.com/909998
https://crbug.com/909999


Original change's description:
> Eliminate unnecessary proto::Configuration copies
> 
> The previous logic in OptimizationGuideService created an
> optimization_guide::proto::Configuration object on a background thread
> and then used task posting to send it on to
> PreviewsHints::CreateFromConfig(), where it was used to create a
> PreviewsHints object on another background thread. In all, there were
> two tasks posted that included the config object as a parameter, one on
> the background thread and one on the UI thread. Including it as a
> parameter in a task requires a full copy of the protobuffer. This means
> that a full copy of the config protobuf, which can be as large as 1.8MB
> (the size of the current Brazil one on Canary), was occurring on the UI
> thread.
> 
> In local performance measurements, making a single copy of a 600KB
> version of the protobuf took several milliseconds (it amounted to
> roughly 60% of the time taken by the initial component string parsing
> and 60% of the time taken by PreviewHints::CreateFromConfig()). Given
> that we were incurring the cost of two copies, one of which was on an
> extremely high priority thread, it makes sense to change the logic to
> eliminate the need for the copies.
> 
> The logic has been altered so that OptimizationGuideService no longer
> immediately processes the component, but instead notifies the
> observers that it is available and allows them to trigger the
> processing. This eliminates both copies of the configuration protobuf,
> as it is now created where it is used.
> 
> Additionally, OptimizationGuideServiceObservers are now immediately
> notified of the hints component when they register if one is already
> available. This will enable the PreviewsOptimizationGuide to wait until
> the HintCacheLevelDBStore is fully initialized before registering for
> the component, and in the future will potentially allow it to avoid
> processing the configuration altogether when the store already has the
> latest version cached.
> 
> New unittests have been added and older ones have been updated to
> accommodate the new logic.
> 
> The related browser tests have also been modified to be more robust,
> where they now wait for a signal from a local histogram indicating
> that hint processing is complete.
> 
> Bug: 908985
> 
> Change-Id: I330fcc35f14388b8a704d3180bd758e7327e9892
> Reviewed-on: https://chromium-review.googlesource.com/c/1351719
> Commit-Queue: Jered Gray <jegray@chromium.org>
> Reviewed-by: Doug Arnett <dougarnett@chromium.org>
> Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611982}

TBR=waffles@chromium.org,tbansal@chromium.org,dougarnett@chromium.org,ryansturm@chromium.org,jegray@chromium.org

Change-Id: I65e2ffff8737cc89bcc0726b4c3e67271e654c2d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 908985
Reviewed-on: https://chromium-review.googlesource.com/c/1354745Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612044}

Adds two new fuzzers: one to fuzz deserialization of port events in
general, and one to fuzz user message events specifically, which have
an additional layer of parsing beyond the port event header.

A successfully parsed user message event is ultimately how we carry
application payloads end-to-end across message pipes via the public
message pipe API. With these fuzzers in addition to the Channel and
NodeChannel fuzzers, we have fuzz coverage of every part of the stack
between the OS and the generated bindings.

This CL fixes some low-hanging fruit where we (a) weren't properly
handling certain deserialization failure cases, leading to nullptr
deref; and (b) weren't properly rejecting messages with far too
many handles (ostensibly) attached.

Finally this also ensures that Mojo core is initialized in the
other existing fuzzers, since they may also end up deserializing
handles and thus require the global handle table to be set up.

Bug: 897743
Change-Id: Ie5d5f8025728f6e57b2ce46d3c41532bf134eb45
Reviewed-on: https://chromium-review.googlesource.com/c/1352976
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612043}

Enables WebKit based side swipe, and only enables Chrome side swipe when the
page swiped page is to or from an NTP.

Change-Id: I892f7074252ee04b2d0b337ebd744f3ba9388e27
Reviewed-on: https://chromium-review.googlesource.com/c/1350192
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612042}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/172196a4380a..fe3edef96c84


Created with:
  gclient setdep -r src-internal@fe3edef96c84

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Icec0781309037014f546b0a9db36f0ccacd34b0a
Reviewed-on: https://chromium-review.googlesource.com/c/1354628Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612041}

BUG=826982

Change-Id: I91dde844b443343a63ac099eece6e15e0b8b90fd
Reviewed-on: https://chromium-review.googlesource.com/c/1352128
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612040}

This updates web test expectation for "svg-fonts-in-text-controls.html" for
Windows platform, chromium.win/WebKit Win10 bot.

This patch is a follow-up the CL[1] which missed to update this expectation.

[1] http://crrev.com/c/1350443 Utilize NGInlineNode::GetOffsetMapping() in Element#innerText

TBR=rockot@google.com

Bug: 909871
Change-Id: I509a305e7f17bbb07c9a72ce32f1edc281a2eb85
Reviewed-on: https://chromium-review.googlesource.com/c/1354719Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612039}

We are using Chromium style, but IDL compiler still generates
code with WebKit name styles.
This CL makes variables names in generated code to snake_case
which meets Chromium style guide.

Here are some changes visible to public;
scriptState -> script_state
wrapperTypeInfo -> wrapper_type_info
exceptionState -> exception_state

This CL has no behavior change.


Bug: 761242
Change-Id: Ic53869763665c9b3959cd64de31825248ef28af5
Reviewed-on: https://chromium-review.googlesource.com/c/1351330
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612038}

When mirroring I think of the source as the source of the
mirror, and the target where the mirror is being displayed.
That isn't the case here.

BUG=none
TEST=none

Change-Id: Id55075cee0f96871bb6d8b6f47257a4cafad2d09
Reviewed-on: https://chromium-review.googlesource.com/c/1354576Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612037}

BUG=907572

Change-Id: Iad549397cbf3e6391d3d92dccb492ef73e1cb65d
Reviewed-on: https://chromium-review.googlesource.com/c/1354443Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612036}

This reverts commit eacb6ed3.

Reason for revert: Makes ChromeVoxLiveRegionsUnitTests flaky:

https://crbug.com/909973
https://crbug.com/909984

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/16620

[ RUN      ] ChromeVoxLiveRegionsUnitTest.AddToLiveRegion
[23526:23526:1128/180604.087820:WARNING:chrome_browser_main_chromeos.cc(544)] Running as stub user with profile dir: test-user
[23526:23526:1128/180604.176618:WARNING:easy_unlock_service_regular.cc(523)] EasyUnlockServiceRegular::IsInLegacyHostMode: DeviceSyncClient not ready. Returning false.
[23526:23526:1128/180604.197349:INFO:remote_commands_service.cc(38)] Fetching remote commands.
[23526:23526:1128/180604.222292:WARNING:remote_commands_service.cc(40)] Client is not registered.
[23526:23526:1128/180604.222531:INFO:remote_commands_invalidator.cc(32)] Initialize RemoteCommandsInvalidator.
[23526:23526:1128/180604.222602:INFO:remote_commands_invalidator.cc(57)] Starting RemoteCommandsInvalidator.
[23526:23526:1128/180604.222654:INFO:remote_commands_invalidator.cc(123)] RemoteCommandsInvalidator ReloadPolicyData.
[23526:23526:1128/180604.222699:INFO:remote_commands_invalidator.cc(167)] Unregister RemoteCommandsInvalidator.
[23526:23526:1128/180604.245434:WARNING:wallpaper_controller_client.cc(358)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances.
[23526:23526:1128/180604.326719:ERROR:gpu_interface_provider.cc(87)] Not implemented reached in virtual void content::GpuInterfaceProvider::RegisterOzoneGpuInterfaces(service_manager::BinderRegistry *)
[23526:23526:1128/180604.607132:INFO:CONSOLE(1281)] "Running TestCase ChromeVoxLiveRegionsUnitTest.AddToLiveRegion", source: file:///b/s/w/ir/chrome/test/data/webui/test_api.js (1281)
[23526:23526:1128/180604.617409:INFO:CONSOLE(53)] "done setup", source: file:///b/s/w/ir/chrome/browser/resources/chromeos/chromevox/testing/tester.js (53)
[23526:23526:1128/180604.636340:ERROR:web_ui_test_handler.cc(100)] Failed: RUN_TEST_F("ChromeVoxLiveRegionsUnitTest","AddToLiveRegion")
AssertionError: expected undefined to equal 'Eric'
    at Function.assert.strictEqual (file:///b/s/w/ir/third_party/chaijs/chai.js:2277:32)
    at assertEquals (file:///b/s/w/ir/chrome/test/data/webui/test_api.js:923:15)
    at ChromeVoxLiveRegionsUnitTest.<anonymous> (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions_test.unitjs:157:7)
    at ChromeVoxLiveRegionsUnitTest.<anonymous> (file:///b/s/w/ir/chrome/browser/resources/chromeos/chromevox/testing/chromevox_unittest_base.js:123:12)
    at CallbackHelper.<anonymous> (file:///b/s/w/ir/chrome/browser/resources/chromeos/chromevox/testing/callback_helper.js:32:16)
    at CallFunctionAction.invoke (file:///b/s/w/ir/chrome/test/data/webui/test_api.js:1430:22)
    at RunAllAction.invoke (file:///b/s/w/ir/chrome/test/data/webui/test_api.js:1591:35)
    at file:///b/s/w/ir/chrome/browser/resources/chromeos/chromevox/testing/callback_helper.js:42:14
    at file:///b/s/w/ir/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js:319:59
gen/chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions_test-gen.cc:1442: Failure
Value of: RunJavascriptTestF( true, "ChromeVoxLiveRegionsUnitTest", "AddToLiveRegion")
  Actual: false
Expected: true

Original change's description:
> Reland "Start gpu channel and compositor mojo pipe collection eagerly"
> 
> This is a reland of 66794d00
> 
> In this reland we revert changes to RenderThreadImpl and mus to make
> LayerTreeFrameSink creation asynchronous again.
> 
> Then in RenderWidget we must remember that a warmup is underway, we do
> so with a bool and a WeakPtrFactory. If it is aborted, we reset the bool
> and invalidate the WeakPtrFactory.
> 
> If a request for a frame sink beats the warmup completing, we save
> the callback and run that instead of saving the frame sink on
> RenderWidget when the warmup completes.
> 
> This ignores some weird weird corner cases like where warmup is
> aborted then we start another warmup or unfreeze the widget or something
> and will just make redundant requests. Since these are so rare they
> are not worth adding complexity for.
> 
> Original change's description:
> > Start gpu channel and compositor mojo pipe collection eagerly
> >
> > When a RenderWidget is frozen, its compositor is stopped. However when
> > the main frame is being navigated, we want to start requesting mojo
> > pipes for the gpu and display compositor immediately so that it can
> > happen in parallel with the navigation loading.
> >
> > Previously, we just always did this when creating a RenderWidget, and
> > left them active when freezing the RenderWidget. After 678f025f
> > however, we don't, and this causes time-to-first-pixels regressions
> > on navigation.
> >
> > So we add a WarmupCompositor() method to RenderWidget, and call this
> > from RenderFrameImpl::CreateFrame() when it makes the provisional
> > frame, and the WebFrameWidget, since we expect to make use of the
> > main frame RenderWidget shortly.
> >
> > Then, if RenderFrameImpl::FrameDetached() occurs, due to the
> > navigation failing, we will AbortWarmupCompositor() to drop the
> > mojo pipes instead of holding onto them indefinitely.
> >
> > This recovers the loading regressions introduced, while also not
> > allocating mojo channels for frozen RenderWidgets indefinitely.
> >
> > In order to do this reasonably, we drop the "callback" from the
> > request to RenderThreadImpl::RequestNewLayerTreeFrameSink so that
> > it always returns something immediately. This way RenderWidget
> > does not need to worry about having a task run to collect the
> > new frame sink, and ordering with tasks from the compositor to
> > collect it.
> >
> > R=piman@chromium.org
> >
> > Change-Id: I6007e26e1622006652ce3619cdd080539d11e7b0
> > Bug: 905191
> > Reviewed-on: https://chromium-review.googlesource.com/c/1341073
> > Commit-Queue: danakj <danakj@chromium.org>
> > Reviewed-by: danakj <danakj@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: Antoine Labour <piman@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#610909}
> 
> Bug: 905191
> Change-Id: I6cb65e08a832a969156b96bece0f2e12eccd5b60
> Reviewed-on: https://chromium-review.googlesource.com/c/1351938
> Commit-Queue: danakj <danakj@chromium.org>
> Reviewed-by: danakj <danakj@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611838}

TBR=danakj@chromium.org,dcheng@chromium.org,sergeyu@chromium.org,piman@chromium.org

Change-Id: I68e348f7fac337580bf3f79a29f618ac3ce3c6d6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 905191
Reviewed-on: https://chromium-review.googlesource.com/c/1354725Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612035}

In debug mode, Windows WebAuthn requests would previously crash because the
WinWebAuthnApiAuthenticator destructor invoked the destructor of its
base::Thread member, which is blocking, on a task runner that was non-blocking.

This works around the issue by moving the thread for doing the blocking Windows
API calls into the WinWebAuthnApi wrapper class. Unfortunately, this moves the
inputs to the API call out of scope with the actual blocking call, which is a
problem since they get passed as pointers. Therefore we now have to stash all
of this data temporarily in the FidoAuthenticator instance while the API call
is pending.

Bug: 898718
Change-Id: Ic36c4f9119e1fcc452cc789182f98c3c59f51610
Reviewed-on: https://chromium-review.googlesource.com/c/1354559
Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612034}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=govind@chromium.org

Change-Id: Ife2e72a5e39aa5453143b2ff589039dcb3d310b0
Reviewed-on: https://chromium-review.googlesource.com/c/1354408Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612033}

Move 'disabled' state handling code from HTMLFormControlElement to
ListedElement. This is a preparation to support 'disabledStateChangedCallback'
of form-associated custom elmeents.

This CL has no behavior changes.

Bug: 905922
Bug: https://github.com/w3c/webcomponents/issues/187
Change-Id: I34703dd7b167be13e4b19324b5e931bda224a866
Reviewed-on: https://chromium-review.googlesource.com/c/1353039
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612032}

Prevents stack overflow when copying/moving large files caused by continually
wrapping the callback with base::AdaptCallbackForRepeating.

Bug: 905798
Change-Id: I5bd6c923a27d626cd2c2b157c301c7e43de923ce
Reviewed-on: https://chromium-review.googlesource.com/c/1353042Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612031}

Bug: 726066, 909750
Change-Id: I12242ad3facdc7e8877833d2c436e383f2c9530f
Reviewed-on: https://chromium-review.googlesource.com/c/1352322
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612030}

Add a histogram to record when we close an audible
tab whether it was the newest.

BUG=907671

Change-Id: Ie607223ee94b011389c1c7e3146c779f9cfce47c
Reviewed-on: https://chromium-review.googlesource.com/c/1347492Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612029}

These bindings are needed to implement GL_WEBGL_multi_draw and
GL_WEBGL_multi_draw_instanced in the passthrough cmd decoder

Bug: chromium:890539
Change-Id: I5fb9398ff258387261af5306c8e94ef6192107c6
Reviewed-on: https://chromium-review.googlesource.com/c/1343099Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612028}

"Invalid Application ID" crashes have surfaced now that the new
RemotePlayback pipeline is turned on by default in M72. The custom app
ID fetched from the AndroidManifest should never be empty in theory, but
in practice it seems like it can be.

This CL fixes the issue by adding an empty check, and falling back to
the default media receiver if ever we aren't able to fetch a valid
app ID.

Bug: 902871
Change-Id: I573f9a11433c1394cee99459a3154539be8d7081
Reviewed-on: https://chromium-review.googlesource.com/c/1354570Reviewed-by: Zhiqiang Zhang <zqzhang@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612027}

This reverts commit 514c49d4.

Reason for revert: Breaks test on Mac10.12 Tests

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/17139

[ RUN      ] WebMediaPlayerMSTest.RotationChange/3
../../content/renderer/media/stream/webmediaplayer_ms_unittest.cc:1136: Failure
Expected equality of these values:
  kStandardHeight
    Which is: 240
  natural_size.height
    Which is: 320
Stack trace:
0   content_unittests                   0x00000001030aac4b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91
1   content_unittests                   0x00000001030aa609 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89
2   content_unittests                   0x0000000102314244 content::WebMediaPlayerMSTest_RotationChange_Test::TestBody() + 3492


Original change's description:
> Use the SequenceManager in ScopedTaskEnvironment
> 
> This is necessary because we want content::TestBrowserThreadBundle to
> own a BrowserUIThreadScheduler, but that also owns a ScopedTaskEnvironment
> and you can't have two SequenceManagers on the same thread.
> 
> This patch allows ScopedTaskEnvironment to optionally work with an
> externally owned SequenceManager solving the problem.
> 
> This implements https://docs.google.com/document/d/1y08C6JQ9Yta3EQXzwIqqIIKHq9500WV6CWFZzZfDx7I/edit?usp=drivesdk,
> 
> We now have the ability to mock time on the UI thread.
> 
> TBR=asvitkine@chromium.org,miu@chromium.org
> 
> Bug: 863341, 891670, 708584
> Change-Id: I96aa34c5cc8832c263621c2d9c228a8da4372c68
> Reviewed-on: https://chromium-review.googlesource.com/c/1324391
> Commit-Queue: Alex Clarke <alexclarke@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611895}

TBR=gab@chromium.org,fdoray@chromium.org,alexclarke@chromium.org

Change-Id: I4b4922b5f393bcb9aace5f28b09a61fbdf2bfa04
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 863341, 891670, 708584
Reviewed-on: https://chromium-review.googlesource.com/c/1354723Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612026}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/cdbaaa244432..0eed05c79fc2


git log cdbaaa244432..0eed05c79fc2 --date=short --no-merges --format='%ad %ae %s'
2018-11-28 dgarrett@chromium.org Revert "Reland generic_stage.GetRepoRepository: Make arguments flexible."


Created with:
  gclient setdep -r src/third_party/chromite@0eed05c79fc2

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ib3ccbc7854cacedfe9617742b4fab6c1ea3c5f51
Reviewed-on: https://chromium-review.googlesource.com/c/1354335Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612025}

The Material Design style introduced in M69 is now default.

Bug: 893362
Change-Id: I17049cfb6b1c2b61aef2edd221645d77b5297fca
Reviewed-on: https://chromium-review.googlesource.com/c/1313868
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612024}

Otherwise we could read out-of-bounds even if an invalid |buffer| is passed
in and in theory we should not read the buffer at all.

BUG=908749
TEST=gl_tests in ASAN build
R=piman@chromium.org

Change-Id: I94b69b56ce3358ff9bfc0e21f0618aec4371d1ec
Reviewed-on: https://chromium-review.googlesource.com/c/1354571Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612023}

Conversions performed with a tool
./node_modules/lebab/bin/index.js --replace ui/webui/resources/cr_elements --transform let

Also adding .eslintrc.js file to prevent future additions of 'var' in that folder.

Bug: 792774
Change-Id: Ia7de669ffa717bc898fdc2989b9820a156ac1b1a
Reviewed-on: https://chromium-review.googlesource.com/c/1354565Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612022}

https://chromium.googlesource.com/angle/angle.git/+log/5829c03d383e..2c0d6a9404cd


git log 5829c03d383e..2c0d6a9404cd --date=short --no-merges --format='%ad %ae %s'
2018-11-29 jmadill@chromium.org WebGL: Fix DrawElements test and remove size check.


Created with:
  gclient setdep -r src/third_party/angle@2c0d6a9404cd

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: I1dadc9a160917ab030dc01c69e9d07a4ba9fafce
Reviewed-on: https://chromium-review.googlesource.com/c/1354622Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612021}

The HTML5 spec recently refactored WindowBase64 into
WindowOrWorkerGlobalScope, removing the need to reflect this in our IDL.
{btoa,atob} implementations have been merged into
window_or_worker_global_scope.{cc,h}.

This CL has no behavior changes.

Bug: 701498
Change-Id: Ib40b30e166ef3e4c0c92791f3ffecbb7bd1bed0b
Reviewed-on: https://chromium-review.googlesource.com/c/1351141Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Andrew Comminos <acomminos@fb.com>
Cr-Commit-Position: refs/heads/master@{#612020}