- 09 Sep, 2020 40 commits
-
-
Raymond Toy authored
Move the date out by 6 months. Bug: 1125837 Change-Id: Ia9569408d28fa5f05b04e9e76e9fe015c277fa2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399004Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#805442}
-
Nico Weber authored
- Mention more platforms at the top - Be better about escaping underscores - Remove some old gyp references - Remove some no-longer-needed explicit clang opt-ins Change-Id: I0e604a12ef67f3ae4d40cb06eac713305bdaf726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401806Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#805441}
-
Maggie Chen authored
In the function of CopyQuadsToPass(). Bug: 1117235 Change-Id: I437d09841adf1517f0ab05d626fcf1ab4b42fd26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393239Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#805440}
-
Prakhar authored
Pending build time looks within limits as of now: http://shortn/_knva2rUxM9 Bug: 1024915 Change-Id: Id56079aea1dc93e62d5089641ac58cfc79c2400a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400585Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Commit-Queue: Prakhar Asthana <pasthana@google.com> Auto-Submit: Prakhar Asthana <pasthana@google.com> Cr-Commit-Position: refs/heads/master@{#805439}
-
phillis authored
App could be a null pointer if registry profile is being deleted. In this case, we will not attempt to get shortcut info. Bug: 1113276 Change-Id: I0ff77b56d701e54350763c1fbabd4f43a0c85f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388892Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#805438}
-
Avery Musbach authored
The present CL addresses system instability after a display is added (or you end mirror mode) while in tablet split view with empty overview. OverviewSession::OnDisplayAdded calls OverviewController::EndOverview which fails in case of tablet split view with empty overview. Thus, overview stays active, but there is no overview grid for the added display. Then you certainly can get a crash, because a lot of code assumes that when overview is active, there is an overview grid for each display. The present CL ensures that overview will actually end when a display is added. Test: All/SplitViewOverviewSessionTest.ExitAndReenterMirrorModeWithEmptyOverview/? Change-Id: Ib9e359e2b231db0f531f7f1de4af9c5af0b2d408 Fixed: 1124481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390964Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#805437}
-
Xianzhu Wang authored
Bug: 1101002 Change-Id: Iaa8538423acb119501092e098a7800ba690c0b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399822Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#805436}
-
Jimmy Gong authored
There are several observers that have "OnStatusChanged" as a function name. This change updates them to be more specific so that potential listeners can implement the observers without any name conflicts. Bug: 1106937 Change-Id: I111828f2d402b11daf2dca2b27df8f6a59786109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399130Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#805435}
-
Torne (Richard Coles) authored
Re-enable these to see what errors they report via the newly added logging, since this failure doesn't seem to be reproducible. Bug: 1106472 Bug: 1117289 Change-Id: I70c7341a53a0c79a3edf29588ece4fe7d1a06220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399523 Auto-Submit: Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#805434}
-
Ahmed Mehfooz authored
Bug: 1110760 Change-Id: I1d1274b724d1c6a7f2e265754d85d7abd11f3116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399829Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#805433}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202009090800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/mluAO-o7A3mN4nCwt4x0R0SnXS6cuF3Fo--glimMpfkC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: If0d13db4cdb52addab3604fe84dcedf135384388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401601Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805432}
-
Andre Le authored
BUG=1106937,1126208 Change-Id: I7d54f5c4aeb9c6aa3243567e83dbd022e651c4ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388168 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
-
Adithya Srinivasan authored
Bug: 1120501 Change-Id: Ica8546b86353d86a5001b3d7bad161d8ee0e68f5 Tbr: calamity@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401850Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#805430}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/dc9083e4831f..6acdaf066c12 2020-09-09 mheikal@chromium.org Improve AdbWrapper#is_emulator to use device codename vs serial If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:11249650 Tbr: rmhasan@google.com Change-Id: Ib5d527ddf3bb1c29201d05410e5247a9d6369c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401859Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805429}
-
Mehran Mahmoudi authored
On Android M and prior versions, a white rect appears on the bottom of the player. This is seemingly caused by using the canvas#setMatrix method. This CL removes this call for identity matrix which fixes this problem for the default scale factor. However, for non-identity matrices, the white rect will still appear. Fixing that requires further investigation. Bug: 1126541 Change-Id: I9c48b3dc90e6fecf450f99059ff8cdf788d94420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401840Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#805428}
-
ckitagawa authored
This CL fixes a low-volume crash in paint preview code. Where the tab might be null when checking if shown and needs badge. This CL was uploaded by git cl split. Change-Id: I69c03fb298c1d70b13368d6f9056d744231caee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401321 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#805427}
-
Nate Fischer authored
This renames "repack_whitelist" to "repack_allowlist" and swaps out related code (ex. variables in chrome/ layer). The new term is consistent with "enable_resource_allowlist_generation" and avoids non-inclusive terminology. Bug: 1097644 Test: autoninja -C out/Official monochrome_public_apk (official build) Change-Id: I3e319c8b8bec9ab9df081b0b61ec02683d665af6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399453Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#805426}
-
Saurabh Nijhara authored
The browser tests only require a single requirement in the policy value and the code to create such policy value is getting repeated in all tests. Now, extracting the code to create policy value into a function. Bug: 1126163 Change-Id: I3e7c35ffc629e2b85ef5cf8bd19f6a429382cbd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401619 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#805425}
-
Marijn Kruisselbrink authored
Change-Id: I9d6a18bf62aa8ba445dba472d068a7d748bf7e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401500 Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805424}
-
David Black authored
Previously thumbnails were fetched at a constant size and exhibited heavy pixelation when rendering in holding space UI. Now, we'll request the appropriate thumbnail size for each holding space type which will ensure consistency with what we intend to render. Known issue: The image loader we use to fetch thumbnails only supports cropping of square images. To prevent image distortion for non-square image requests, we'll ensure that we always request square images and perform an additional crop on our end. Bug: 1113772 Change-Id: I43e86b37e31d1dc94fd737bc29021dc68658c8b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399438 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#805423}
-
Josip Sokcevic authored
code.google.com redirects no longer work. This CL replaces links in /headless to source.chromium.org equivalent. This CL was uploaded by git cl split. R=eseckler@chromium.org Change-Id: I27b31f841ee3bd0b5b06f950a56707c92aca4414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392707 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805422}
-
Josh Nohle authored
Enforce that each ListPublicCertificates RPC call takes no longer than 30s to complete. If this limit is exceeded, fail the task and rely on the scheduler to retry the attempt later. Fixed: b/166114040, 1116910 Change-Id: I9904a1d8c9da2d9a921f528dfbaf432213717d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401498 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#805421}
-
Yuke Liao authored
Ash-chrome occasionally fail to start even after 20s, which causes infrastructure failures on linux-lacros-rel. This CL mitigates the issue by adding a retry logic so that the test runner script attempts to start ash-chrome up to 3 times. Bug: 1126185 Change-Id: Ibf80b6dbee51645db600e2804a53ca4d5320ca0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399618 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#805420}
-
Alexander Surkov authored
ax_dump_tree tool sets siltently include-all filter if the filter file path is relative or mistyped, and ignores silently unrecognized filters, which makes harder to figure out why your filters don't work Bug: None Change-Id: I871350d67c9dc945ef4543eb11bb51c680aa025f AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399123 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#805419}
-
Marc Treib authored
...and wire them into the respective SyncClient implementations. The feature flag for this service is still disabled, so this causes no behavior change yet. Bug: 1102314 Change-Id: I3a06470b2faf0cc9941e90024cf7ba672a70a99f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397736 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#805418}
-
Mark Mentovai authored
Update Crashpad to fc97e5cbb21dc7f4d4679b86792dd2717818bd80 7547d0aa874f android: Remove orderfile configs from handler trampoline b4724081350e fuchsia: Remove run_tests.py functionality ebab28f30d33 Remove a variable-length array* to enable compiling with -Wvla 1509aadd6364 Remove a variable-length array to enable compiling with -Wvla 45ca490687af Build with -Wvla, forbidding stack-allocated variable- length arrays 59e8120e7ada [Wconversion] Suppress warnings on Fuchsia 71695216f9bb ios: Fix Xcode project buildgen dc9f3a58aabb fuchsia: Fix Wconversion on Mac/iOS builds 364fdd65a01e fuchsia: Fix Wconversion on Mac/iOS builds (take two) bdf94713241b mac: Switch from <AvailabilityMacros.h> to <Availability.h> 56937e1df569 mac: 11.0 SDK support b3d84e0d0571 mac: System libraries are no longer found on disk on macOS 11 df3bc64246ab mac: Be more positive c4acae9f961a fuchsia: fix configs clobbering in GN template 3965bc7d7894 Refactor OS_LINUX usage for coming LaCrOs update 5412beb63386 mac: Replace MacOSXMinorVersion with MacOSVersionNumber e0d8a0aa01ac mac-arm64: Cope with signal handling quirks abfc89bb9b70 mac-arm64: Set expectations for tests that crash via __builtin_trap ca83774eea9c mac-arm64: Make MacModelAndBoard use target-type instead of board-id f8563cb8626a mac-arm64: Omit the cl_kernels workaround on this platform 0bc3826129d5 mac-arm64: Allow target_cpu = "mac_universal" to create universal builds df12d57e97b4 mac: Don’t build 32-bit ProcessReaderMac support where it’s unusable ca88ff1edb8e mac-arm64: Don’t attempt to determine the CPU frequency fc97e5cbb21d mac: Work around broken {CTL_KERN, KERN_PROCARGS2} sysctl in 11.0db6 Bug: crashpad:345,crashpad:347,crashpad:352,crashpad:355,chromium:1103944 Change-Id: I3c1f59d3c5bd2886916ea80228be765aafb4f63d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399518 Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Mark Mentovai <mark@chromium.org> Reviewed-by:Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#805417}
-
Lin XInan authored
Bug:1056387 TEST=main.star Change-Id: Ia6b598fc8f906fcea73cb36b5c03f22fbb7be053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401940 Commit-Queue: Xinan Lin <linxinan@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#805416}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/21bebc68fda6..215d2b0fa42d 2020-09-09 mtklein@google.com impl SkMulDiv255Round with SkMul16ShiftRound 2020-09-09 bsalomon@google.com Revert "Perf bot experiment, disable GLSL integers on ANGLE ES3" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: I45d336ed69a11c8f2306a0b7e5c4a5dece6a34a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401858Reviewed-by:
-
Etienne Bergeron authored
This CL is making const the function that are not modifying the state of the resource bundle. This step is required to make the transition to a Reader/Writer lock. Bug: 1123115 Change-Id: I764a8657fe358ce8cc5097d7ca7140a48682afd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401324Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#805414}
-
Mark Pearson authored
Largely the change is to make it more acceptable to emit impressions and other events that are not user triggered if it's useful/necessary for analysis. Change-Id: Ic9215981dd71846c3eb3db4ef3af87f40d1ca1b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392712 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#805413}
-
Ahmed Mehfooz authored
Bug: 1110760 Change-Id: I713b6810aa6d6f21da35e01bf12513df44a3ce8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398988Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#805412}
-
Palak Agarwal authored
Bug: 1117534 Change-Id: I34823045b6e3364edbab94fd3eb74b8b1ef02d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397619Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Palak Agarwal <agpalak@chromium.org> Cr-Commit-Position: refs/heads/master@{#805411}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b8b9262d7426..9b74c18d1728 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC davidvc@google.com,adithyas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099917 Tbr: davidvc@google.com,adithyas@google.com Change-Id: I89b86a9d4b1e89bf30305960800f6e8bbaab5af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401613Reviewed-by:
-
Ryan Hansberry authored
The prior implementation of this function assumed that the provided |size| would match the number of bytes read. In reality, |size| is generally a very large value and number of bytes read may be smaller than it. Manually verified by successfully sending a 7KB file from Chrome OS to Android. Bug: 1124992 Change-Id: I781a2c1f69aee374a18c10641ed14f31eb7348f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393616Reviewed-by:
-
Daniel Rubery authored
This is a reland of a4418459. The original CL was causing crashes due to UaF on the Scorer object. This CL fixes that issue by performing the thread hop within Scorer. Since the returning callback on the PhishingClassifier is guarded by a WeakPtr, this should be more safe. Original change's description: > Move visual feature scoring to helper thread > > This CL calls the GetMatchingVisualTargets in a worker thread, since > the process of scoring visual features takes longer than expected > and was blocking interaction. > > Fixed: 1121375 > Change-Id: I8f3e33d20f812645a72adfc16fe33241b49a6ff4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372869 > Commit-Queue: Daniel Rubery <drubery@chromium.org> > Reviewed-by: Bettina Dea <bdea@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801907} BUG=1121375,1122534 Change-Id: Ifedb94ad8b613a2ba7377bb5bc7795e657a94512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386380Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#805408}
-
David Black authored
New HoldingSpaceClient APIs will be accessed from //ash to: - Copy an item to clipboard (stubbed) - Open an item in its folder (implemented) - Pin an item (stubbed) - Unpin an item (stubbed) Stubbed APIs will be implemented in a follow up CL. Bug: 1126274 Change-Id: Ie6790e935272d90064f278d8d916fd3b33445752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399764Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/214971471446..5fc363ed10fc 2020-09-09 chrche@microsoft.com [Loc] Presubmit#3: LocV2 Checking the shape of localization API calls 2020-09-09 aerotwist@chromium.org Migrates theme patching to top-level ThemeSupport 2020-09-09 chrche@microsoft.com [Loc] Presubmit#2: prevent using of LocV1 APIs in migrated files 2020-09-09 jacktfranklin@chromium.org Persist the network filter text input. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:941561 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I043e8f75d9b1f4e0beece1876c8a8b604adaa3d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401615Reviewed-by:
-
Joanmarie Diggs authored
This is a follow-up change to http://crrev.com/c/2346329 to address a missed comment. AXPosition::IsValid will check if the positions are valid, so update AXSelection to account for any triggered DOM mutations, and then call AXSelection::IsValid, which will check the validity of the AXPosition instances associated with the selection. Bug: 1113650 AX-Relnotes: N/A Change-Id: Ic7d72111b2172784bbd199b6fe7767b5badefa43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396156 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#805405}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599630228-06e78b920e92149bcb86488690cdbb2bed08546f.profdata to chrome-win64-master-1599651808-28c874736fb144e9b48a72308f081ee03ad277c7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Icab2c0aaab9ac3ced0a254eff33e62f3e84284c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401603Reviewed-by:
-
Ian Struiksma authored
Add win-1909 to os enum, update mb config. Bug: 990885,1125612 Change-Id: I419a4ebf018d70841ec62b8bdf2e9dfd26e21cfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399721Reviewed-by:
-
