- 26 Sep, 2020 40 commits
-
-
Haiyang Pan authored
This reverts commit 8c7e525a. Reason for revert: (Copied from crrev.com/c/2433419) Findit (https://goo.gl/kROfz5) identified CL at revision 810966 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzhjN2U1MjVhODhiNmI5OGQzYmJmM2UyZmQ1NzUyNmM5ZGMwZWUyMmQM Sample Failed Build: https://ci.chromium.org/b/8868097753228061152 Sample Failed Step: compile Original change's description: > Roll ANGLE from fc4e3cf24f9b to ae24f28a0ba6 (8 revisions) > > https://chromium.googlesource.com/angle/angle.git/+log/fc4e3cf24f9b..ae24f28a0ba6 > > 2020-09-26 cclao@google.com Vulkan: Move mReadOnlyDepth out of FramebufferDesc > 2020-09-26 cclao@google.com Vulkan: Use DepthStencilReadOnly when it is read only. > 2020-09-26 jmadill@chromium.org Add a small unit test that dumps system info. > 2020-09-25 syoussefi@chromium.org Vulkan: Workaround vkCmdClearAttachment bug on Pixel > 2020-09-25 jmadill@chromium.org Enable Vulkan SystemInfo on more platforms. > 2020-09-25 syoussefi@chromium.org Vulkan: Make UtilsVk not contribute to occlusion queries > 2020-09-25 ynovikov@chromium.org Skip BootAnimationTest.DefaultBootAnimation on Win NVIDIA Vulkan > 2020-09-25 timvp@google.com Vulkan: Link PPO during draw validation > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/angle-chromium-autoroll > Please CC syoussefi@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 > Bug: None > Tbr: syoussefi@google.com > Test: Test: ContextNoErrorTest31.DrawWithPPOTest: Test: ProgramPipelineTest31.VerifyPpoLinkErrorSignalledCorrectlyTest: Test: dEQP.GLES31/functional_separate_shader_validation_es31_* > Change-Id: I293417fd73361302fccf41d3e56e807395025e7d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432960 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#810966} TBR=syoussefi@google.com,chromium-autoroll@skia-public.iam.gserviceaccount.com Change-Id: Id831c460fccb6dc2a6cab84e7e577a110f0b6960 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433059Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#810983}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ied5e91efba88265bc12e2213f62b5b48ae75f678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432772Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810982}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ae24f28a0ba6..dff9331631e4 2020-09-26 jmadill@chromium.org Add Skia Gold CIPD package to DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I785c86ba9f27525e715edbee587dfb1308b624df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433394Reviewed-by:
-
DongJun Kim authored
This patch uses WeakPtr instead of raw pointers of PaymentRequestState,PaymentRequestSpec, PaymentRequestDialogView and PaymentRequest. Bug: 1086284 Change-Id: I8307a81e6fc633ed5fda8f848eba261378f98a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400547 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#810980}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fe9da604c428..dc972dc72cd9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ife3fa63beb619cf2627a1fb47a2cc36e542f7d8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433393Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810979}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I4c9c15c156284df3eedeb8f3de964df24c10aca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431667Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#810978}
-
Benoit Lize authored
Bug: 998048 Change-Id: I9c8cdbec7b7748d6d4f9b473affb6d3948a374ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428896 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#810977}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I276ce29d1c2aaeddd06c4c4d16fd601ab0aac606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432953Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d08de1904727..5b4d110a2b90 2020-09-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-09-25 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: Iadc7f8e4446cbe04398bbe5e9427558dc9183bc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433385Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/68861e391313..5e1545fa00c8 2020-09-26 csmartdalton@google.com Finish recording tessellation pipelines 2020-09-25 ethannicholas@google.com moved SkSL BoolLiteral data into IRNode If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: csmartdalton@google.com Change-Id: I27e4fad5f0377252c7a9b7af724b37fdd1f20780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432951Reviewed-by:
-
Rachel Wong authored
This CL enables ChromeVox to activate the link in the privacy view. This is done by: 1) Making the outer text view non-focusable, so that ChromeVox traverses its descendants instead. 2) Override the a11y action handler for the link, as the default handler does not behave as expected. Bug: 1112714 Change-Id: Ic1ab13e4dae6328bdcbf8fd2d4d658a90bb89523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409735 Commit-Queue: Rachel Wong <wrong@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#810973}
-
Jana Grill authored
Bug: 1106337 Change-Id: I1138299867e74da6fa2b9ad0ee8166c83d44af33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431085Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jana Grill <janagrill@chromium.org> Cr-Commit-Position: refs/heads/master@{#810972}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/76b5fbb58db7..fe9da604c428 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099917 Tbr: Change-Id: Idb5db9dcdb042c56f37b384d3a2479bd4e9071aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433261Reviewed-by:
-
Daniel Cheng authored
Android WebView and Instant NTP both attempt to suppress failed navigations. Currently, this is done on the renderer side, but this makes it harder for the browser to reason about the state of a pending commit, since the renderer may choose to ignore it. For Android WebView, expose a new helper on NavigationHandle to allow WebView embedders to optionally suppress errors if desired. For Chrome NTP, it turns out this is unnecessary. The renderer-side suppression was added to prevent an error page from flashing before falling back to the local NTP. However, the fallback is handled by NewTabPageNavigationThrottle, which initiates the fallback navigation in its `WillFailRequest()` handler. Initiating this fallback navigation will cancel the failing navigation, so the renderer-side suppression will never be used anyway. Bug: 1117282 Change-Id: I125d46436fb6ebca57b64f308cade5249ea03658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401323 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#810970}
-
Lei Zhang authored
Change a couple callers in Uri::Pim to use Uri::GetDefaultPort() to avoid repeating the same logic. After this, Uri::Pim no longer calls Uri::Pim::GetDefaultPorts() directly, and all the direct usage is in uri.cc. So move Uri::Pim::GetDefaultPorts() into an anonymous namespace in uri.cc. Change-Id: I87bd0d882775fd31b3d20524b53d63c7483b42f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427624 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#810969}
-
Hiroki Nakagawa authored
For code simplification, this CL merges mojom::PrerenderHandle into mojom::PrerenerProcessor. These interfaces were very similar: These were materialized per <link rel=prerender> element, and used for sending messages from a renderer process to the browser process. To merge them, this CL... - assigns unique identifier per LinkPreload instance. This is used for canceling or abandoning prerendering from PrerenderProcessorImpl. - removes PrerenderHandleProxy that implemented mojom::PrerenderHandle. Bonus: This cleanup will make it easier to reuse the mojom interfaces for the prerender V2 implementation we are now planning (see the issue). Change-Id: If731c50408c4e125b3e71a70bef9bbf680eb073f Bug: 1126305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413830Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#810968}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I0597e4aeb620ae56258b88c06d8f426bdfc4029f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433307Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810967}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fc4e3cf24f9b..ae24f28a0ba6 2020-09-26 cclao@google.com Vulkan: Move mReadOnlyDepth out of FramebufferDesc 2020-09-26 cclao@google.com Vulkan: Use DepthStencilReadOnly when it is read only. 2020-09-26 jmadill@chromium.org Add a small unit test that dumps system info. 2020-09-25 syoussefi@chromium.org Vulkan: Workaround vkCmdClearAttachment bug on Pixel 2020-09-25 jmadill@chromium.org Enable Vulkan SystemInfo on more platforms. 2020-09-25 syoussefi@chromium.org Vulkan: Make UtilsVk not contribute to occlusion queries 2020-09-25 ynovikov@chromium.org Skip BootAnimationTest.DefaultBootAnimation on Win NVIDIA Vulkan 2020-09-25 timvp@google.com Vulkan: Link PPO during draw validation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Test: Test: ContextNoErrorTest31.DrawWithPPOTest: Test: ProgramPipelineTest31.VerifyPpoLinkErrorSignalledCorrectlyTest: Test: dEQP.GLES31/functional_separate_shader_validation_es31_* Change-Id: I293417fd73361302fccf41d3e56e807395025e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432960Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2841e0538b44..a8e978ac76a8 2020-09-26 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia67f3888f428bb7ba282921b02b15d6162be9b8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433074Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601078369-ffc6308083b80c42d5e1d99c83f54bc820d7ceab.profdata to chrome-mac-master-1601098956-7b62f3c084a877589de82f5f57c5b346e35e22e9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand@chromium.org Change-Id: I6b43cccdd75775f67e5ffc08328b97c9f464875f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432962Reviewed-by:
-
Bo Majewski authored
Bug: 1111229 Change-Id: I6eeca66765f0b4d9f08f756a4e8e6a56bc07df48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425684 Commit-Queue: Bo Majewski <majewski@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#810963}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 244613d0. With Chromium commits locally applied on WPT: 74e4b2fc "[COOP] access reporting: Use infinite timeout for receive." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I5356af3f030537701786ff72491cdece2c79c2f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431613Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810962}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601078369-72819caf89b317b2996377bd72281bf52f735fa7.profdata to chrome-linux-master-1601098956-8dc5f241a60ad3bbaa0b96777ed5d4c55f872428.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org,jeffyoon@google.com Change-Id: I60af90729667d85f8594433a3d3655e6b022d577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433075Reviewed-by:
-
Daniel Classon authored
On the text-to-speech subpage, fix the search tag "TTS voice" appearing with no voices loaded and the search tag "TTS engines" appearing with no TTS engines loaded. On the switch access subpage, fix the "switch access keyboard auto-scan" search tag appearing when that feature is disabled. Fixed: 1116553 Change-Id: I6a3c53f3a4eab3a5f28dfcf3bd852b65ab829b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429470 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
-
Lukasz Anforowicz authored
Bug: 1128008 Change-Id: Ifd84c8ce4533526a52050b3a91341e4ea628bb57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431728Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#810959}
-
Brandon Jones authored
This value is not used by Blink, and does not need to be communicated over the mojo interface. The XRDeviceId enum should not be removed because it is used for usage stats. Bug: 1017477 Change-Id: I5e8cfff00c374f48495290c5dfb8911a1824a2de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424684Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Auto-Submit: Brandon Jones <bajones@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#810958}
-
Yao Xiao authored
Implement the API to get the floc (i.e. interestCohort) that represents the cohort of the user's browsing interest. The floc is currently a per-profile value, but it should only be allowed to query if the cookies permission allows, therefore it's designed/defined to be an async API on "document". Explainer: https://github.com/jkarlin/floc Bug: 1062736 Change-Id: I088ef38038a4e27a5c40ba730a5dc37baa3cb12a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389221 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Min Qin authored
This allows us to update tile order based on user input. Bug: 1096224 Change-Id: I137ddb2e74048c0ba214b560b986e216a77abff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423057Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#810956}
-
Lei Zhang authored
Initialize |g_clock| on first use instead of at runtime. Bug: 537099 Change-Id: Id6cbd61f05649029f7c9281b0efbf5595bc23077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429262 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#810955}
-
Olga Sharonova authored
Bug: 1132225 Change-Id: I85fe9a1b402fba7fbc29d54d877a61bb2f1b1350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431029Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Auto-Submit: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#810954}
-
Guido Urdaneta authored
Media Device ID salts should be reset for every new document, but navigations within the same document should not reset the salt since it causes problems for some applications. Bug: 1127548 Change-Id: I88e6af831fd8e5b02136d415e371b01d4dfd512e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432028 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#810953}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I75117bb455869c950071365b222fd4f75e8baaf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433244Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810952}
-
Sammie Quon authored
Logs presentation time while updating the UI. Adds a new smoothness for when animation which happens when lifting fingers off the touchpad. For chained animations, the logic from before is unchanged, so there will be one smoothness number in "Ash.Desks...DeskActivation" for a chain of animations. Test: manual Bug: 1111445 Change-Id: I9a1e76aa0f81edbe871601de78abc936536e4c6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414553 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#810951}
-
Michael Spang authored
The definitions in ozone.gni were intended to be private to //ui/ozone, but there's no visibility checking for gni files so there's we've grown a number of these imports. Remove them where we can easily do so. Change-Id: Id7e9f924ef3bd7a37f446708e00aac21f51e8f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429865Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#810950}
-
Darwin Huang authored
The constructor's argument order was flipped. Please see the "fill(6)" constructor for more info: http://www.cplusplus.com/reference/string/string/string/ Previously, this would cast 'X' to a size_t, and buf_len to a char. Tbr: fukino Change-Id: I69b71753338cde2810b6ed0b940650d683f0c20c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432748 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#810949}
-
Thomas Lukaszewicz authored
This CL sets TabStripRegionView to inherit from AccessiblePaneView rather than View. This is a necessary change to allow the TabSearchButton to be accessible via keyboard navigation when focus enters the tab strip region (entered via f6 on windows). In doing so, the TabStrip itself no longer needs to inherit from AccessiblePaneView and now inherits from View. This change should have no functional effect on how focus is handled in the tab strip (absent Tab Search). This also advances the goal of moving the NTB out of the TabStrip and into the TabStripRegionView as this will ensure the NTB remains keyboard accessible when moved to the tab strip region. Bug: 1131689 Change-Id: I5f1ab031116724341009d10469e6d7479cf05883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427876 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#810948}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f7a0128b9441..cb9160484da5 2020-09-25 tsepez@chromium.org Use Optional<> return from CXFA_LocaleMgr::GetConfigLocaleName(). 2020-09-25 tsepez@chromium.org Introduce common superclass GCedLocaleIface 2020-09-25 tsepez@chromium.org Garbage collect CXFA_LocaleMgr. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I1b468e9fbcbb3e5d0fde4fd25b9bf8e453fea3ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433072Reviewed-by:
-
Frank Liberato authored
Also modifies callback to take a `Measurement` struct, since the number of reported values was getting large. Last, adds explicit calls to the roughness reporter from the submitter when we stop rendering, so that it knows to stop the window. Change-Id: Idb00046511c5cee0c351172ec6e786d35e870457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410963Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#810946}
-
Matthew Mourgos authored
This CL changes how the notification indicator in the app list is painted. The circle border has been removed, and now a drop shadow has been added. Before this change, the notification indicator was drawn with a fixed size, which was not correct when the app list icons scaled to different sizes. Now, the notification indicator's size is determined as a ratio of the icon's total size, this ensures the indicator is always drawn to the correct size and position. Bug: 1131074, 1131072 Change-Id: I63e9f12845230579abe4703a60f4b08f6bf431c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429980 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#810945}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/236c96a322d8..2841e0538b44 2020-09-26 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iea2f6adc4696cacdfcd3b0bdc5905ce3b9bcbd7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432957Reviewed-by:
-
