- 06 Jan, 2020 6 commits
-
-
Matt Menke authored
It wasn't being used meaningfully, and we want to remove the class. Bug: 651119 Change-Id: Id479b735d1ef677d7eb55faf5e44ab2de859cd2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971755Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#728426}
-
Peter Kasting authored
Specifically, the caption colors need to update. On Ash this was happening indirectly already, since BrowserNonClientFrameViewAsh::OnThemeChanged() was calling UpdateFrameColor(). But on other platforms, it was not. Handling this eliminates the need to set these colors at construction or in BrowserNonClientFrameViewAsh::Init(), since OnThemeChanged() will always be called when the frame is added to a widget, which happens after both those. This also eliminates the need to null-check the frame view in WebAppFrameToolbarView::UpdateCaptionColors(), since by OnThemeChanged() that will always be set. Finally, this eliminates the need for BrowserNonClientFrameViewAsh::OnThemeChanged() to indirectly call WebAppFrameToolbarView::UpdateCaptionColors(), since that is now called locally. Also, the BrowserNonClientFrameView need not explicitly SchedulePaint(), since if any children of the web app frame actually change color, they will invalidate themselves as necessary. Bug: none Change-Id: If0a24ccebcf8ce105dc3662ee6468d6b9b36d419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980166Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#728425}
-
Hiroki Sato authored
Bug: b:129680977 Test: manual. (ChromeVox and HighlightInputFocus on eve and laser14) Change-Id: Ifb14d413e1135d4acd8bbc8f24631df6862bc3db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978202Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#728424}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f4ee9eec3ea5..9e850d191a29 Created with: gclient setdep -r src-internal@9e850d191a29 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iefad82a80e304c9e09ff06d7fede3b15c2f0409d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987850Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728423}
-
nancy authored
The reason is CL:1981526 removes default iconn loading, so ARC icon loading could take some time. When FetchImage, icon is set as null: gfx::ImageSkia() So UpdateImage could load null image, which causes DCHECK error: Check failed: InitializedWithRecordingBounds() Add checking for null image, and if image is null, don't call delegate to update image. BUG=1038602 Change-Id: I15515d318b8601aaf456ea499c3f9d82fff0a437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985628 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#728422}
-
Rob Schonberger authored
Bug: 1009290 Change-Id: I416da812513b27e80c0150ad76028e6dab20c596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984798 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#728421}
-
- 05 Jan, 2020 28 commits
-
-
chromium-autoroll authored
Roll ChromeOS orderfile from 81-3987.18-1577705382-benchmark-81.0.4012.0-r1 to 81-3987.18-1577705382-benchmark-81.0.4013.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If76e2a04cee27853256f2a35eee28ecf232f169a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987848Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728420}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bdb4f178f67f..f4ee9eec3ea5 Created with: gclient setdep -r src-internal@f4ee9eec3ea5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I5e6e93887c57da3fcbf5f22acc88e5eeed7d39d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987847Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728419}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3940172c..7c5025db Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1d3652798e820b97756e600fbca659ccd045a29c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986142Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728418}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bfa2664cb4ce..bdb4f178f67f Created with: gclient setdep -r src-internal@bdb4f178f67f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I7441ee7612027aeb6b0ca6e538269f3f1f73916d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987890Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728417}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6655f1a07a50..bfa2664cb4ce Created with: gclient setdep -r src-internal@bfa2664cb4ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I705ef5046d6227b54bb464b1953f7a58c35074a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987885Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728416}
-
Yuki Shiino authored
CodeGenContext.template_bindings() may be bound multiple times in a chain of parent-child code nodes. This patch supports such shadowing of template variables only for CodeGenContext. Bug: 839389 Change-Id: I0d3c83c05e5e807bcc5f11ca9839380b972e3526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982575 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#728415}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I7b8166d27a8e74c3cff1741ab0e5e78044e93124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983685 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#728414}
-
Yuki Shiino authored
web_idl.file_io reads/writes in binary mode so that it produces the same result on Windows. Also makes intermediate directories if necessary. Bug: 839389 Change-Id: I9743af13acfaa0cefaed6f4b76d6fac28ae3e608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980606Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#728413}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2de68515..3940172c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1f5c7508f66c54e03fb06ba8cb979129b969374c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984508Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728412}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I9d5d9238d48516d3d32e971510a3ca506a16c12c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980605Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#728411}
-
Chromium WPT Sync authored
Using wpt-import in Chromium eedc81a7. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I18b59d46f2f81d816d815ad83abc081978f1e83a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986141Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728410}
-
Koji Ishii authored
Following bot results are included. 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 76 lines were removed and 18 lines were deflaked by consecutive results since 822. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Ic2bafcc371c6a37dd82781f808e38475524180c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982572Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#728409}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2de044fed052..6655f1a07a50 Created with: gclient setdep -r src-internal@6655f1a07a50 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I625368cef243bd26cd426c03ba6a8abdb8fb5076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987713Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728408}
-
Monica Basta authored
Change-Id: I280a9af2368e7edad77f7e6104acae9cdabd2463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985845Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#728407}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0a272f3acd2c..2de044fed052 Created with: gclient setdep -r src-internal@2de044fed052 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I81f56fb6f134ab236781855a0041d37d008b1098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987711Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728406}
-
Md. Hasanur Rashid authored
The conditions have been phrased positively to understand better in future. Bug: 919870 Change-Id: Ib76393bf7dff667bcdca9abc50d5f2b26ddf5569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985638Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Md. Hasanur Rashid <hasanur.r@samsung.com> Cr-Commit-Position: refs/heads/master@{#728405}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I583f47fc7f065489fb4f5a2473898fb95c9c7bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980604 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#728404}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/41a13c41448b..0a272f3acd2c Created with: gclient setdep -r src-internal@0a272f3acd2c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I50d32ae222e25875126fef4695169c8e711282d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987577Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728403}
-
Navid Zolghadr authored
Change-Id: I2ed7bec198b96a5533770da9987176205478bd69 Bug: 1030176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980521Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#728402}
-
Morten Stenshorne authored
This was broken both in legacy multicol and with LayoutNGBlockFragmentation. Legacy: We stored the intrinsic size in the column sets, in addition to in the flow thread. There was no good reason for this, and it caused trouble once something caused the intrinsic size of the multicol container to change, since the column sets would never be marked dirty again. Just set the intrinsic size of column sets to 0 to fix this. LayoutNGBlockFragmentation: The flow thread is still created even if NG block fragmentation is enabled, but the flow thread is invisible to NG, so when calculating the intrinsic size of nodes in a subtree, we'll skip the flow thread - which means that it will never be marked clean. Skip to the containing block of the flow thread when marking preferred logical widths dirty. This fixes the remaining part of the demo in bug 1037790 - when trying to reduce column-count to 1. Without this fix, the multicol container would remain too wide. Bug: 1037790 Change-Id: I89c7cbeb3132162b6c52ae30e98a0da21cd34ef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985770Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#728401}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6791ee2f8059..d445e2b6fcf1 git log 6791ee2f8059..d445e2b6fcf1 --date=short --first-parent --format='%ad %ae %s' 2020-01-05 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@d445e2b6fcf1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jvanverth@google.com Change-Id: I6333b1db6f6847fdbe1e12839611494136bb9735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987373Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728400}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d6a7998fa3bf..41a13c41448b Created with: gclient setdep -r src-internal@41a13c41448b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ic119e960a078db013a8525b7182313f1a1493721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987745Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728399}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I59864691ec5a118f4a43b8a24249d9f8bcd5f57c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982570Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#728398}
-
Alexander Alekseev authored
This Cl extends expiration time of a few histograms till 2020-12-01: CrosFirstRun.DialogShown CrosFirstRun.FurthestStep CrosFirstRun.TutorialCompletion CrosFirstRun.TimeSpentOnStepTray CrosFirstRun.TimeSpentOnStepHelp CrosFirstRun.TimeSpentOnStep CrosFirstRun.TimeSpentOnStepAppList CrosFirstRun.TimeSpent CrosFirstRun.TutorialLaunched Login.UsersActiveWeekly Login.UsersActiveWeekly.Percent Bug: 1037144,1037007 Change-Id: I9e726a9fc72214d463d2c6624bea14b1492b8b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980861Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#728397}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I6ce4ce77e7fe3d4547f97aa8e70bbc82d4fc6bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986435Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728396}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2ac2bc7d39ac..d6a7998fa3bf Created with: gclient setdep -r src-internal@d6a7998fa3bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I8479f7a33ae3e503dc5ca04b7d5e946f5e803680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987686Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728395}
-
chromium-autoroll authored
Roll airmont AFDO profile from 81-3987.18-1577702544-benchmark-81.0.4013.0-r1 to 81-3987.18-1577702544-benchmark-81.0.4016.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I1b69ad7c8d931ff39ea15295f78e5c96faba1f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987685Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728394}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d2c3a0710e5c..2ac2bc7d39ac Created with: gclient setdep -r src-internal@2ac2bc7d39ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iad15e2f521aab28a6120401b5b4866bdb5eece04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987403Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728393}
-
- 04 Jan, 2020 6 commits
-
-
chromium-autoroll authored
Roll silvermont AFDO profile from 81-3987.18-1577705382-benchmark-81.0.4013.0-r1 to 81-3987.18-1577705382-benchmark-81.0.4016.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I060406c789ff4732607439b82ef605526442f947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987404Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728392}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 81-3987.18-1577704324-benchmark-81.0.4013.0-r1 to 81-3987.18-1577704324-benchmark-81.0.4016.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Id6db71eb9da64b7df6c8e31682ed7b4d6a678f85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987402Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728391}
-
Morten Stenshorne authored
If the multicol container gets marked for intrinsic size recalculation, its flow thread child might need to recalculate its intrinsic size as well (the intrinsic inner size of a multicol container is stored in the flow thread), although it may not have been marked as such. This situation occurs when column-count changes. Re-use the NeedsPreferredWidthsRecalculation() mechanism to fix this, instead of inventing something new. This fixes most of the demo in bug 1037790, except when attempting to reduce column-count to 1. https://chromium-review.googlesource.com/c/chromium/src/+/1985770/1 will fix that. Bug: 1037790 Change-Id: I9d42448f8cc7a5b170c98a59bcde7a916cea22db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985769 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#728390}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/190db8abc68d..d2c3a0710e5c Created with: gclient setdep -r src-internal@d2c3a0710e5c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I272599b451e7adb6e01c94947dd11cce22c4ac0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987398Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728389}
-
Anton Bikineev authored
Bug: 1029379 Change-Id: Icbdee80dddcd55920680c23a5f6aaa814ac11093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985841 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#728388}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c7797980325f..190db8abc68d Created with: gclient setdep -r src-internal@190db8abc68d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I64a9d997d6584ec0e4fbf6d4b13f20879503fb78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987141Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728387}
-