- 12 Dec, 2017 40 commits
-
-
Stuart Langley authored
This changes is for files in the path //t_p/WebKit/Source/modules/accessibility. Added the include for base/macros.h where needed and moved the macro to the end of the class as per the code guidelines enforced by lint. Also take the chance to change ctor/dtor to use '= default' where possible. This CL introduces no logic changes. Bug: 565932 Change-Id: I5b03045c5e880d7a97aa9006e055ea4a065301c3 Reviewed-on: https://chromium-review.googlesource.com/822011Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#523370}
-
Daniel Bratell authored
There are two types named FrameMap, one in render_frame_impl.cc and one in render_frame_proxy.cc. As long as the type isn't exported that works, but in jumbo builds the cc files are compiled in the same translation unit which causes collisions. Bug: 746953 Change-Id: I582d7f032caba1a201ac72c8181eb4c2432cc5bf Reviewed-on: https://chromium-review.googlesource.com/819636Reviewed-by:
-
DongJun Kim authored
This patch changes function names for readability in AXObject as below. - Supports*** / CanSupportARIA*** -> SupportsARIA*** Bug: none Change-Id: I77e9f717ce5ba1bfcb53c6152f57ce99fdda943a Reviewed-on: https://chromium-review.googlesource.com/821792Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#523368}
-
Owen Lin authored
We need larger output buffers when using high bitrates. Bug: b/69381380 Test: Pass the CTS "android.media.cts.VideoEncoderTest" Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I775da1f332de3448cb383fed618a140cf950913d Reviewed-on: https://chromium-review.googlesource.com/816375 Commit-Queue: Owen Lin <owenlin@chromium.org> Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#523367}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e57da29c. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/7486 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Icd9b2cb4ef260dc0a016c450572fc37d0ffc106e Reviewed-on: https://chromium-review.googlesource.com/821432 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523366}
-
Dominic Mazzoni authored
In Windows accessibility code we had a special case that suppressed accessibility events after a page is being navigated away from, to prevent overlapping events from the old page and new page. This caused a major problem if you cancel the beforeunload dialog, because BrowserAccessibilityManager still thought the page was being reloaded. The key fix is for WebContentsImpl to notify BrowserAccessibilityManager on DidStopLoading, since that's called when canceling a reload. In other cases when it's called, it will be harmless as BrowserAccessibilityManager will already be in the right state. The rest of the changes are some refactoring to make it possible to simulate canceling the beforeunload dialog in a test. Bug: 787126 Change-Id: I6356d827223aac559778fa96d9a7198916fe10f9 Reviewed-on: https://chromium-review.googlesource.com/809491 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#523365}
-
Pavel Feldman authored
In case subresource request's site needs to have its document protected, don't send raw headers and cookies into the frame's renderer. Bug: 793692 Change-Id: I9f41adfe35717eec284130f89ac92ecc78089969 Reviewed-on: https://chromium-review.googlesource.com/821410Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523364}
-
Dominic Mazzoni authored
To post an accessibility event on a NativeViewAccessibilityWin, we call NotifyWinEvent on the owning HWND, and pass it the negation of its unique ID as the child ID argument. The assistive technology then fetches the IAccessible by calling get_accChild on the HWND's IAccessible and passing it that child ID. In AXPlatformNodeWin::get_accChild, we do a sanity check that the child found is a descendant of the HWND, so we don't return a View from a different window by mistake. We do this by walking up from the descendant using GetParent() to make sure we reach the root. This is failing for bubbles on Windows 7 because they're implemented as transient windows (windows with a parent window set, but with child=false), and NativeViewAccessibilityWin::GetParent wasn't correctly walking up from a child widget to its transient parent. Fix this by taking transient windows into account, and update an existing unit test that wasn't fully testing this case correctly, to make it correct and have it test both cases (child = false and child = true). Bug: 785628 Change-Id: I17ea2f5b24c75a9aae7e93a669ac84db8e8feb90 Reviewed-on: https://chromium-review.googlesource.com/818390 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#523363}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/5e99d62f4d92..909fa2daa49e $ git log 5e99d62f4..909fa2daa --date=short --no-merges --format='%ad %ae %s' 2017-12-12 dsinclair [js] Convert to using size instead of sentinels Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I04ec4c8e3d28c20cb32a9c81c51bc2946e1b7220 Reviewed-on: https://chromium-review.googlesource.com/821598 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523362}
-
Xianzhu Wang authored
This reduces one level of indirection at callsites, and encapsulate rare details in FragmentData. Fix a bug in the original RarePaintData::ContentsProperties(): it returned Transform instead of Perspective as the transform node when both existed. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I7cc0702fe5cd43758ee1ff0622523dcd6e75e249 Reviewed-on: https://chromium-review.googlesource.com/816114 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#523361}
-
Gregory Chatzinoff authored
Make the name for the field trial created by ScopedFeatureList unique so that different ScopedFeatureLists do not collide when the field trial is stored globally. Bug: none Change-Id: Ibe0ebc6747868fd468e0c9455f21e990635aa1c4 Reviewed-on: https://chromium-review.googlesource.com/813102Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#523360}
-
Yutaka Hirano authored
This change removes the feature as we've launched it. Bug: 788241,603396 Change-Id: If651428dd301b4393570a05e7a20499e95f7ed7b Reviewed-on: https://chromium-review.googlesource.com/818597 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
-
Raymes Khoury authored
This reverts commit 0d7cc8b3. Reason for revert: Should be fixed by https://chromium-review.googlesource.com/c/chromium/src/+/735686 Original change's description: > Add a temporary hack to fix a race condition with FP layout tests > > A race condition means that navigation may not reach the browser process > before a permission request does. This adds a hack to ensure that > navigation has reached the browser by waiting for a cross-origin iframe > to load. > > BUG=689802,769189 > > Change-Id: I26dba360e322cf31c0ec200985a6908de9a82c35 > Reviewed-on: https://chromium-review.googlesource.com/688382 > Reviewed-by: Ian Clelland <iclelland@chromium.org> > Commit-Queue: Raymes Khoury <raymes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506221} TBR=raymes@chromium.org,qyearsley@chromium.org,iclelland@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 689802, 769189 Change-Id: I36cd26c2d2683e020237e038f658fb30fe55354d Reviewed-on: https://chromium-review.googlesource.com/821952Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#523358}
-
k2.nagaraju authored
updated parsing logic updated test cases and expected results Bug: 755487 Change-Id: Ia5d55a117f5f5fa7217e7671337fa4bc7fafbf41 Reviewed-on: https://chromium-review.googlesource.com/787071Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
srirama chandra sekhar <srirama.m@samsung.com> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#523357}
-
Lei Zhang authored
Unlike the current checks for the debug dump path, HasDebugDumpPath() is truly read only and won't create the base::FilePath when accessing the |g_debug_dump_info| base::LazyInstance. Update code to use HasDebugDumpPath() instead of accessing |g_debug_dump_info| directly, and only do that when getting / setting the path value. Change-Id: I200664a9cb70289883627c8dc7f85c6f02edd45b Reviewed-on: https://chromium-review.googlesource.com/821370Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#523356}
-
Timothy Loh authored
Change-Id: I219a0dfc48e834e55b35e376378fd3775fff6ee0 Reviewed-on: https://chromium-review.googlesource.com/821331Reviewed-by:
-
Tom Anderson authored
BUG=789405 R=erg@chromium.org,sky@chromium.org Change-Id: I9b313c1027cd5ac69ed1b3545f909b60a648b148 Reviewed-on: https://chromium-review.googlesource.com/803666 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#523354}
-
Giovanni Ortuño Urquidi authored
Add checks to current tests to make sure that BookmarkAppNavigationThrottle records the correct values for each case. Bug: 785661 Change-Id: Ic975722978309eb87acafa3b071693f0bc52f964 Reviewed-on: https://chromium-review.googlesource.com/813355 Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#523353}
-
Yoichi Osato authored
This patch is a part of crrev.com/c/813336 ([LayoutNG] Paint text selection on load.) This patch depends on crrev.com/c/818864 (Implement NG offset conversion and LayoutSelectionStartEndForNG()) ng_text_fragment_painter.cc: - This paints selection background and selected text. - PaintSelection() paints selection background. This is copied from InlineTextBoxPainter::PaintSelection() w/o ltr, expanding new line wrap,,, which uses InlineTextBox functions. - NGTextFragmentPainter::Paint paints text partially: Suppose we have "b[a]r" (selected only 'a'), -- 1. Paint 'b' -- 2. Paint white 'a' -- 3. Paint 'r' Bug: 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id9001b6fdadda084dae5531a5dfd0725bae293f8 Reviewed-on: https://chromium-review.googlesource.com/818884 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#523352}
-
rhalavati@google.com authored
The default network traffic annotation value is removed from the Write function of the following classes: - HttpProxyClientSocket - HttpProxyClientSocketWrapper Bug: 656607 Change-Id: Iae5bb59c2391504e457a323fa178673d70676696 Reviewed-on: https://chromium-review.googlesource.com/817416Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#523351}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/c00226132679..5e99d62f4d92 $ git log c00226132..5e99d62f4 --date=short --no-merges --format='%ad %ae %s' 2017-12-12 thestig Roll DEPS for zlib to 91155b5d. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id258dff9dd474f41a0e57f9a1ae6de3b11887bf6 Reviewed-on: https://chromium-review.googlesource.com/821597 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523350}
-
Hidehiko Abe authored
BUG=234463 TEST=Ran bots. Change-Id: I17099f919e60e83f8add28b5ce1158e0ac9b98ba Reviewed-on: https://chromium-review.googlesource.com/819191Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#523349}
-
Koji Ishii authored
Following bot results are included. 2452 2453 2454 2455 2456 2457 2460 2462 2464 2469 2470 Deflake is not included. TBR=eae@chromium.org NOTRY=true Bug: 591099 Change-Id: I2646bdf894234e14ef24236b581f19281f9f7b7d Reviewed-on: https://chromium-review.googlesource.com/821810 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Eve Martin-Jones authored
This change is for files in the path //third_party/WebKit/Source/core/layout/. Added the include for base/macros.h where needed and moved the macro to the end of the class as per the code guidelines enforced by lint. This CL introduces no logic changes. Bug: 565932 Change-Id: I65d0e5c366a510f573659cfdbedeb0eb8e2f6c9e Reviewed-on: https://chromium-review.googlesource.com/816174Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Chris Watkins <watk@chromium.org> Commit-Queue: Eve Martin-Jones <evem@chromium.org> Cr-Commit-Position: refs/heads/master@{#523347}
-
Avi Drissman authored
This is intended to help diagnose crashes and find repro steps. While in some cases a full URL is available (and is added), in the case of a render process that may be out-of-process, full URLs may not be available. This adds as much info as is available (full URL if possible, just an origin if not). BUG=793067 TEST=none Change-Id: I11134cc5a5238839236b05717db1afe30d19328d Reviewed-on: https://chromium-review.googlesource.com/818389Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Eve Martin-Jones authored
This change is for files in the path //third_party/WebKit/Source/core/svg/. Added the include for base/macros.h where needed and moved the macro to the end of the class as per the code guidelines enforced by lint. This CL introduces no logic changes. Bug: 565932 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I675071e07aaf9d5f6ad5ef06e1def1a4b796e6bb Reviewed-on: https://chromium-review.googlesource.com/816234Reviewed-by:
-
Eve Martin-Jones authored
This change is for files in the path //third_party/WebKit/Source/core/page/. Added the include for base/macros.h where needed and moved the macro to the end of the class as per the code guidelines enforced by lint. This CL introduces no logic changes. Bug: 565932 Change-Id: I82b2af55d42f44324e4ce4406efa0068f315a778 Reviewed-on: https://chromium-review.googlesource.com/816274Reviewed-by:
-
yoshiki iguchi authored
Bug: 726250 Change-Id: I421927a350dc769cfe46644845a582cea75baaca Reviewed-on: https://chromium-review.googlesource.com/811124Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#523343}
-
Xiaocheng Hu authored
The above function assumes the existence of LocalFrame client, which is not true when the frame is already detached. This patch adds a nullptr check to prevent crashes. Bug: 793358 Change-Id: I1fe6c4c2f4cef8c7709b5e76c95e3d896ce6e506 Reviewed-on: https://chromium-review.googlesource.com/821556Reviewed-by:
Ryan Landay <rlanday@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#523342}
-
Eve Martin-Jones authored
Bug: 565932 Change-Id: I98a8766fd355146f8709b4057c9c6b96f9f5eb57 Reviewed-on: https://chromium-review.googlesource.com/816494Reviewed-by:
-
rbpotter authored
Use initial settings to populate some fields. Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I817c34fabf416b7a935633bdc1830d3e69fc4086 Reviewed-on: https://chromium-review.googlesource.com/809708 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#523340}
-
Hidehiko Abe authored
BUG=234463 TEST=Ran bots. Change-Id: Ic2a6ec2ba1846a1cd3fdac983134a0c6032ebbbc Reviewed-on: https://chromium-review.googlesource.com/807971Reviewed-by:
-
Peng Huang authored
With recent changes, --mus has a separate viz process wich is launched by browser process via GpuPorcessHost. So we should use GpuProcessHost to request ARC related interfaces in Viz. Bug: 793901 Change-Id: Idd27f95fcf962b54634876024d0da4600da3f3aa Reviewed-on: https://chromium-review.googlesource.com/820151Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#523338}
-
Artur Khachatryan authored
Bug: Change-Id: Iaa3396d6e2c0dbd91b5d4aaf4fa0fbb49f617fac Reviewed-on: https://chromium-review.googlesource.com/820561Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#523337}
-
Peter Collingbourne authored
Bug: 607968 Change-Id: I039b18cfdecca6b9ce2d223f7ef226376b2830ef Reviewed-on: https://chromium-review.googlesource.com/821591Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#523336}
-
Sergey Ulanov authored
All current implementations of AudioOutputStream allow Stop() to be called in any state (e.g. before Start() or after Stop()). Updated comments for Stop() and added unittests to verify that behavior. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8480d2faeb1090483619cab26baf23b4a39e1829 Reviewed-on: https://chromium-review.googlesource.com/818305Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#523335}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/cb82b102c366..e188f9648ada $ git log cb82b102c..e188f9648 --date=short --no-merges --format='%ad %ae %s' 2017-12-11 nednguyen Make sure cloud_storage.GetIfHashChanged also save the binary's hash upon first time fetching it Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I2d1e95abc4e4846ca0b7e24e08f5168d380d20ea Reviewed-on: https://chromium-review.googlesource.com/821412 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523334}
-
Darren Shen authored
Currently we are not updating counter values correctly when we change or add counter-resets. For example, if we have something like: <div style="counter-reset: c"> <p style="counter-increment: c">First</p> <p style="counter-increment: c">Second</p> </div> we would construct the following counter tree (approximately): reset increment // first increment // second When we insert a new reset node after the first item, we would get something like: reset increment // first increment // second reset The correct behaviour would be to move every (non-reset) counter node after the first node to be a child of the new node: reset increment // first reset increment // second Bug: 463513, 599359, 591267 Change-Id: I28cbf3c13c86336ad3f6f44bf865c59d9f82d98a Reviewed-on: https://chromium-review.googlesource.com/809984Reviewed-by:
-
Nektarios Paisios authored
R=dmazzoni@chromium.org Bug: 785100, 761882 Change-Id: Iab2181a6208b116eb2043446eb8edb4061a59d76 Tested: Manually with Jaws and NVDA on crbug.com and freedomscientific.com, unit test Reviewed-on: https://chromium-review.googlesource.com/820107 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
-
Tatsuhisa Yamaguchi authored
This will also affect other UI elements derived from cr.ui.MenuButton like: - Combo Button - Context Menu Button The UI elements are also referred in other places than the Files app. - "Apps" menu in login screen - media control UI in the video player - Bookmark Manager The button is made not to steal the focus when clicking it to open menu, https://cs.chromium.org/chromium/src/ui/webui/resources/js/cr/ui/menu_button.js?q=file:menu_button.js+stealing+focus&sq=package:chromium&dr&l=139 however, it had taken focus when the menu item is activated by a click. It made the focus left on the button after finishing operation on a button using either mouse or touchscreen, requiring MenuButton class to hide that focus highlight by attaching "using-mouse" class attribute. Test: browser_tests --gtest_filter=WebUIResourceBrowserTest.MenuButtonTest* Bug: 771024,769593 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I23fb1b0ce907a21407ffca514032bfdc083e36de Reviewed-on: https://chromium-review.googlesource.com/816376 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#523331}
-
