GitLab

BUG=401569
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/456243002

Cr-Commit-Position: refs/heads/master@{#289061}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289061 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Video capture should set visible size and coded size separately. (https://codereview.chromium.org/457823003/)

Reason for revert:
Broke 1080p and 480p tab capture on desktop.


Original issue's description:
> Video capture should set visible size and coded size separately.
> 
> The coded size should always be rounded up to multiples of 16 pixels to accomodate
> alignment requirements of HW encoders, while the visible size reflects the actual
> content size.
>     
> BUG=402151
> TEST=verify that non-multiple-of-16-pixel capture works and no black border is shown
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288565

TBR=sergeyu@chromium.org,posciak@chromium.org,hshi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=402151

Review URL: https://codereview.chromium.org/460283003

Cr-Commit-Position: refs/heads/master@{#289059}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289059 0039d316-1c4b-4281-b951-d872f2087c98

BUG=403013
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/465013002

Cr-Commit-Position: refs/heads/master@{#289058}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289058 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Speculative revert, attempting to diagnose timing out Blink layout tests on Windows.

Original issue's description:
> Adds some CHECKs to MessagePumpMojo
> 
> The thread watcher appears to be kicking on when we're trying to
> remove a handle. Not sure why. This converts some DCHECKs to CHECKs
> and fixes handling of the deadline. I suspect none of this will help,
> but it's worth a shot.
> 
> BUG=399769
> TEST=none
> R=darin@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288949

TBR=darin@chromium.org,sky@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=399769

Review URL: https://codereview.chromium.org/461133002

Cr-Commit-Position: refs/heads/master@{#289057}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289057 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289055}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289055 0039d316-1c4b-4281-b951-d872f2087c98

WorkerDevToolsSanityTest.InspectSharedWorker times out a lot on Windows. Disable
it.

BUG=403007
TEST=Bots green more often
NOTRY=true
TBR=dgozman

Review URL: https://codereview.chromium.org/459103006

Cr-Commit-Position: refs/heads/master@{#289054}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289054 0039d316-1c4b-4281-b951-d872f2087c98

Currently chrome://flags only exposes #enable-avfoundation as an enable
link. This CL exposes instead a tristate compose of Default/Enable/Disable.



BUG=356106, 396764

Review URL: https://codereview.chromium.org/460113006

Cr-Commit-Position: refs/heads/master@{#289053}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289053 0039d316-1c4b-4281-b951-d872f2087c98

Small followup from https://codereview.chromium.org/423333002

This allows the test to compile on a greater range of toolchains (some
of which break when using types defined in a function with arraysize).

Review URL: https://codereview.chromium.org/456403002

Cr-Commit-Position: refs/heads/master@{#289051}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289051 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [site isolation] cross-site transfers should track the RenderFrameHost, not the View (https://codereview.chromium.org/457003002/)

Reason for revert:
Speculatively reverting CL in case it is causing WebNavigationApiTest.OpenTab to fail http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Chromium&testType=browser_tests&tests=WebNavigationApiTest.OpenTab

Original issue's description:
> site isolation: cross-site transfers should track the RenderFrameHost, not the View
> 
> This fixes some issues that came up while debugging bug 400850, which inadvertently caused OOPIF-like view reuse in RenderFrameHostManagerTest.AllowTargetedNavigationsAfterSwap.
> 
> 1. Make navigation_suspended state be per-RenderFrameHost. What was happening, was that we'd suspend navigations on the non-main frame of the view, and upon resume, we'd switch frames.
> 
> 2. Make the map of pending cross site requests be a map of RenderFrameHost IDs instead of RenderViewHost IDs, instead of just assuming that it's the main frame of the view that's navigating.
> 
> 3. Add a pending_main_rfh() to the test apparatus, for use by unittests that query the navigation_suspended state.
> 
> BUG=304341, 400850
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288867

TBR=creis@chromium.org,nick@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=304341, 400850

Review URL: https://codereview.chromium.org/462083003

Cr-Commit-Position: refs/heads/master@{#289049}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289049 0039d316-1c4b-4281-b951-d872f2087c98

Preference can be deleted during sync rollback if the preference was not set before
first signin. Clear the preference if that happens.

BUG=362679

Review URL: https://codereview.chromium.org/444763005

Cr-Commit-Position: refs/heads/master@{#289048}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289048 0039d316-1c4b-4281-b951-d872f2087c98

BUG=388517
NOTRY=true

Review URL: https://codereview.chromium.org/465643003

Cr-Commit-Position: refs/heads/master@{#289047}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289047 0039d316-1c4b-4281-b951-d872f2087c98

Remove |kAltInstantURLPath| from search.cc and retain the default Instant search base url path when the |kUseAltInstantURL| flag is enabled. 

BUG=382694
TEST=Run chrome with the following field trial flag and observe the Instant search base page url.
     --force-fieldtrials="EmbeddedSearch/Group1 use_alternate_instant_url:1 /"

Review URL: https://codereview.chromium.org/453573002

Cr-Commit-Position: refs/heads/master@{#289046}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289046 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds the ExternalPopupMenu content browser 
tests for the changes in https://codereview.chromium.org/415343003/. This 
will be applicable on Mac port, as it uses 
ExternalPopupMenu to show dropdown menu.

BUG=398051
R=keishi@chromium.org

Review URL: https://codereview.chromium.org/447503002

Cr-Commit-Position: refs/heads/master@{#289045}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289045 0039d316-1c4b-4281-b951-d872f2087c98

TBR=alecflett@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/469463002

Cr-Commit-Position: refs/heads/master@{#289044}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289044 0039d316-1c4b-4281-b951-d872f2087c98

https://github.com/timothycrosley/isort

I ran isort -sl on files that does not contain util.AddDirToPythonPath.

BUG=

Review URL: https://codereview.chromium.org/445793004

Cr-Commit-Position: refs/heads/master@{#289043}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289043 0039d316-1c4b-4281-b951-d872f2087c98

Many slaves are shared between rel/dbg builders with the same build directory names. This makes sure we are testing what we intend to test.
BUG=401781
R=navabi@chromium.org, luqui@chromium.org

Review URL: https://codereview.chromium.org/452263002

Cr-Commit-Position: refs/heads/master@{#289042}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289042 0039d316-1c4b-4281-b951-d872f2087c98

This is an optimization for systems where there is more than one
physical pixel per logical pixel (e.g., Chromebook Pixel, Mac Retina).
On these systems, the render widget should be "preferably" sized such
that its physical size will match that of the tab capture frame size.

Because the entire graphics pipeline is handling N^2 less data, and also
will no longer need to down-scale images, users should see huge tab
capture performance improvements (e.g., higher frame rates, lower CPU
utilization and fan noise).

Expected side effect: Fullscreen-Within-Tab widgets will appear shrunk.
However, since content renderers are still DIP-aware, any UI controls
within the widget will appear right-sized.  In other words, user
interaction will not be diminished by this change.

Testing: Confirmed Fullscreen-Within-Tab and tab capture output is
correct by varying --force-device-scale-factor=X.

Review URL: https://codereview.chromium.org/461443003

Cr-Commit-Position: refs/heads/master@{#289040}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289040 0039d316-1c4b-4281-b951-d872f2087c98

This is to make the pre-new-avatar-menu world consistent with the
post-new-avatar-menu world.

BUG=NONE

Review URL: https://codereview.chromium.org/466733003

Cr-Commit-Position: refs/heads/master@{#289037}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289037 0039d316-1c4b-4281-b951-d872f2087c98

Also do a bit of renaming from Stores -> Cache while we're at it.

BUG=392621

Review URL: https://codereview.chromium.org/411973004

Cr-Commit-Position: refs/heads/master@{#289036}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289036 0039d316-1c4b-4281-b951-d872f2087c98

If spoken feedback is reading and a user performs a two 
finger tap anywhere on the screen, it will silence spoken feedback.

BUG= 399380

Review URL: https://codereview.chromium.org/420073003

Cr-Commit-Position: refs/heads/master@{#289035}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289035 0039d316-1c4b-4281-b951-d872f2087c98

This was omitted from the XML file but emitted by the code.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/461103002

Cr-Commit-Position: refs/heads/master@{#289034}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289034 0039d316-1c4b-4281-b951-d872f2087c98

There should be a separator in folder popup button to differenciate "Choose another folder"
button from already available bookmark folders.

BUG=237697

R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/463093002

Cr-Commit-Position: refs/heads/master@{#289033}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289033 0039d316-1c4b-4281-b951-d872f2087c98

DecodeTimestamp is a thin wrapper around base::TimeDelta that makes it
possible to easily differentiate decode timestamps from presentation
timestamps. Using a separate type also forces conversions between these
two domains to be done explicitly through conversion functions. This
change introduces the class and updates all the variables that contain
decode timestamps. It also puts in place the necessary conversion calls
for converting between timestamp types. There should be no functional
change as a result of this patch. This class is mainly to allow the
compiler to highlight where conversions between timestamp types occur.

Having DecodeTimestamp will make it much easier to rework
SourceBufferStream so that it properly handles B-frame content and
reports buffered ranges in terms of presentation time instead of
decode time.

BUG=398130
TEST=All existing tests still pass.

Review URL: https://codereview.chromium.org/447963003

Cr-Commit-Position: refs/heads/master@{#289031}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289031 0039d316-1c4b-4281-b951-d872f2087c98

1. Update guest_view_manager_unittest.cc.
2. Move guest_view code to extensions.
3. Add namespace extensions for classes within guest_view/web_view/app_view.

BUG=352290

Review URL: https://codereview.chromium.org/464533002

Cr-Commit-Position: refs/heads/master@{#289030}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289030 0039d316-1c4b-4281-b951-d872f2087c98

Add Cast.Sender.VideoEncodeAcceleratorInitializeSuccess indicating
whether we were successful in initializing an external video encode
accelerator for cast sender.

BUG=397038
TEST=Cast, check histograms

Review URL: https://codereview.chromium.org/458693004

Cr-Commit-Position: refs/heads/master@{#289029}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289029 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/315393004

Cr-Commit-Position: refs/heads/master@{#289028}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289028 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
Test=None

Review URL: https://codereview.chromium.org/452413002

Cr-Commit-Position: refs/heads/master@{#289026}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289026 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289024}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289024 0039d316-1c4b-4281-b951-d872f2087c98

BUG=libyuv:346
TESTED=set GYP_DEFINES=target_arch=ia32 libyuv_disable_jpeg=1
R=mcasas@chromium.org

Review URL: https://codereview.chromium.org/428533009

Cr-Commit-Position: refs/heads/master@{#289023}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289023 0039d316-1c4b-4281-b951-d872f2087c98

Discoverd that we never got LibraryLoader.NativeLibraryHack in UMA
histograms server. Found that's because UMA session was not started
yet right after native libraries are loaded.

By delaying recording until UMA session is started, these stats
shown up in chrome://histograms.

BUG=311644

Review URL: https://codereview.chromium.org/452923004

Cr-Commit-Position: refs/heads/master@{#289022}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289022 0039d316-1c4b-4281-b951-d872f2087c98

BUG=399149

Review URL: https://codereview.chromium.org/436563005

Cr-Commit-Position: refs/heads/master@{#289021}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289021 0039d316-1c4b-4281-b951-d872f2087c98

This removes the need for a lot of additional boilerplate in proxying capturer implementations, and makes it possible to implement DesktopEnvironment using any kind of DesktopCapturer, e.g. ScreenCapturer or WindowCapturer, for example.

Review URL: https://codereview.chromium.org/455073004

Cr-Commit-Position: refs/heads/master@{#289020}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289020 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395733
TEST=https://simpl.info/getusermedia/sources/

Review URL: https://codereview.chromium.org/459363003

Cr-Commit-Position: refs/heads/master@{#289019}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289019 0039d316-1c4b-4281-b951-d872f2087c98

BUG=388893

Review URL: https://codereview.chromium.org/456863003

Cr-Commit-Position: refs/heads/master@{#289018}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289018 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [Mac, Win] Only show the user manager tutorial if "See what's new" is clicked. (https://codereview.chromium.org/454153002/)

Reason for revert:
Breaks ProfileChooserControllerTest.InitialLayoutWithFastUserSwitcher,ProfileChooserControllerTest.InitialLayoutWithNewMenu,ProfileChooserControllerTest.OtherProfilesSortedAlphabetically on the waterfall.

Original issue's description:
> [Mac, Win] Only show the user manager tutorial if "See what's new" is clicked.
> 
> - remove the profile preference that used to keep track of showing the
> tutorial any time the user manager was shown for a particular profile.
> 
> - show the upgrade bubble for local profiles as well (so that local profiles
> have a chance to see the tutorial)
> 
> - for the local profiles upgrade bubble, don't show the "Not you?" link as
> it doesn't really make sense.
> 
> BUG=399679
> TBR=rpetterson@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288817
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289005

TBR=guohui@chromium.org,rlp@chromium.org,sky@chromium.org,asvitkine@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=399679

Review URL: https://codereview.chromium.org/461093002

Cr-Commit-Position: refs/heads/master@{#289017}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289017 0039d316-1c4b-4281-b951-d872f2087c98

Also sets myself as the owner for these. 

BUG=223859
NOTRY=true

Review URL: https://codereview.chromium.org/456003002

Cr-Commit-Position: refs/heads/master@{#289016}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289016 0039d316-1c4b-4281-b951-d872f2087c98

(I still have to write tests and convert some uses. I also want to add
more logic to the async destruction, so that the |Channel| knows that
it's about to be torn down.)

R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/466563002

Cr-Commit-Position: refs/heads/master@{#289015}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289015 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#289014}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289014 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jkummerow@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/465903003

Cr-Commit-Position: refs/heads/master@{#289013}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289013 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393486
TEST=Tree is open more of the time
TBR=horo
NOTRY=TRUE

Review URL: https://codereview.chromium.org/463143002

Cr-Commit-Position: refs/heads/master@{#289012}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289012 0039d316-1c4b-4281-b951-d872f2087c98