- 29 Sep, 2018 5 commits
-
-
Jian Li authored
Bug: 885144,890091 Change-Id: Idbf08df67e8783ef305e273680cc12287ac1d53d Reviewed-on: https://chromium-review.googlesource.com/1250169Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#595264}
-
Siddhartha authored
This reverts commit 6275b810. Reason for revert: Fixes the crash due to accessing TLS after thread is destroyed. Original change's description: > Revert "memlog: Add task contexts from allocation context to native mode" > > This reverts commit 3e6c0cd8. > > Reason for revert: Causes crashes on Mac while accessing TLS. > > Original change's description: > > memlog: Add task contexts from allocation context to native mode > > > > The task context is useful to debug mojo memory leaks since IPC messages > > are tagged with contexts > > > > BUG=874530 > > > > Change-Id: Id59d016f963f41fdeda6af69b3c470f0101dbfe7 > > Reviewed-on: https://chromium-review.googlesource.com/1232683 > > Reviewed-by: Erik Chen <erikchen@chromium.org> > > Commit-Queue: Siddhartha S <ssid@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#593458} > > TBR=erikchen@chromium.org,ssid@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 874530, 888899 > Change-Id: I70e2dc4a91f8512dc98a68d5dd0736f5e511da54 > Reviewed-on: https://chromium-review.googlesource.com/1244829 > Reviewed-by: Siddhartha S <ssid@chromium.org> > Commit-Queue: Siddhartha S <ssid@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594158} Bug: 874530, 888899 Change-Id: I3710b3d50f50a2bfa69b964e336b4f6e691f641b Reviewed-on: https://chromium-review.googlesource.com/1252521 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#595263}
-
Peter Kvitek authored
DevTools performance metrics now allows collection and reporting of duration related metrics using monotonically increasing abstract time and thread running time. Change-Id: Ica54cc291ba456c8dcc6a47a962e99a87cb8a475 Reviewed-on: https://chromium-review.googlesource.com/1247528Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#595262}
-
Jordy Greenblatt authored
Bug: 890425 Change-Id: Id1150f263c6cd1fded5422b395ac94f0166687e2 Reviewed-on: https://chromium-review.googlesource.com/1252915Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#595261}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/72f78323a89f..cd9671dd3ecf Created with: gclient setdep -r src-internal@cd9671dd3ecf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4b618f506a3f4590c2b5e68ed5ec36864dc00f7d Reviewed-on: https://chromium-review.googlesource.com/1252375Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595260}
-
- 28 Sep, 2018 35 commits
-
-
Lukasz Anforowicz authored
Returning true for WebUI pages in DoesSiteRequireDedicatedProcess helps to keep enforcing a SiteInstance swap during chrome://foo -> chrome://bar navigation, even after relaxing BrowsingInstance::GetSiteInstanceForURL to consider RPH::IsSuitableHost (see https://crrev.com/c/783470 for that fixes process sharing in isolated(b(c),d(c)) scenario). I've manually tested this CL by visiting the following URLs: - chrome://welcome/ - chrome://settings - chrome://extensions - chrome://history - chrome://help and chrome://chrome (both redirect to chrome://settings/help) Bug: 510588, 847127 Change-Id: I55073bce00f32cb8bc5c1c91034438ff9a3f8971 Reviewed-on: https://chromium-review.googlesource.com/1237392 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#595259}
-
Kyle Horimoto authored
Before this CL, the <multidevice-setup> element was told what "UI mode" (i.e., OOBE vs. post-OOBE) and behaved differently depending on what mode was active. This abstraction was leaky, since it caused the element to change its logic based on what its client at a higher level was. This CL adds a MultiDeviceSetupDelegate interface and injects this interface into the <multidevice-setup> element, which uses it to perform tasks such as setting the host device. One concrete implementation of this interface is provided for the post-OOBE case; a future CL will add an implementation for OOBE. This CL also removes multidevice_setup_dialog.js in favor of adding a new <multidevice-setup-post-oobe> element. Bug: 884058 Change-Id: I76b6553928e706da4870339d306bc32bea7ac3e6 Reviewed-on: https://chromium-review.googlesource.com/1247525Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#595258}
-
Zhenyao Mo authored
BUG=838970 TEST=GPU FYI waterfall R=kbr@chromium.org Change-Id: Idf1b701539c427a63ed5648396a3c6588d305733 Reviewed-on: https://chromium-review.googlesource.com/1252630Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#595257}
-
Peter Kasting authored
This is dead in Refresh. The only exception is in CrOS, where we can still have such an icon for teleported windows. Bug: none Change-Id: Ibfadbc3a463d689db5203ff5a74157e8b75c2aef Reviewed-on: https://chromium-review.googlesource.com/1244882 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#595256}
-
Ben Pastene authored
TBR=jbudorick Bug: 876587 Change-Id: Ic121bccd2343fe48eefbbaf2ccf60d2d01969ca2 Reviewed-on: https://chromium-review.googlesource.com/1252911Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#595255}
-
Dominic Mazzoni authored
Currently it's just a mojo struct containing a string, but it should be relatively easy to turn it into a different type now. Follow-up to http://crrev.com/c/1212484 - eventually we may want this to be a base::UnguessableToken. This change should completely eliminate any assumption that ui::AXTreeID is a particular type, only that it's possible to serialize and unserialize it as a string (which is necessary because we need this to be passed through JavaScript APIs). Bug: 881986 Change-Id: Ifb53e4ca2ea56c53488c89d6df188a1f131197ae Reviewed-on: https://chromium-review.googlesource.com/1246297 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#595254}
-
Nico Weber authored
While here, also remove unused GetAllowOtherViews() / SetAllowOtherViews() from WebContents and WebContentsView. Bug: 832676 Change-Id: I18e6385b08599e12e0a8f2d85c06d429e92396c7 Reviewed-on: https://chromium-review.googlesource.com/1251323Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#595253}
-
Scott Violet authored
This is necessary when running ash_unittests in chromeos vm as we hit some DCHECKs otherwise (the real StatisticsProvider DCHECKs that it was initialized). BUG=866114 TEST=test only change Change-Id: I0ad82f28f266460a6c9dccc23e86566750aed8f4 Reviewed-on: https://chromium-review.googlesource.com/1252853Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#595252}
-
Devlin Cronin authored
Add metrics to record the number of extensions that have withheld host permissions, and, if host permissions are withheld, the number of explicitly granted hosts. Only record these metrics if the RuntimeHostPermissions feature is enabled. Add unittests for the same. Bug: 889659 Change-Id: Ia2ae175ad7116d1aa6665514055a42efeb39f0da Reviewed-on: https://chromium-review.googlesource.com/1249529 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#595251}
-
Jeremy Klein authored
This is a reland of 3e67df64 Fixed the ASAN test by actually just removing some unnecessary code. Original change's description: > Install Messages PWA when host is set or verified. > > This change moves the logic for installing the Android Messages PWA into > a helper class which is a HostStatusProvider::Observer. This allows it > to install the PWA when a host is set and also when signing into a new > Chromebook if the account already has a valid host. > > Bug: 887775 > Change-Id: I1a1433b03010d391f9b8256754fc578dfb8a140b > Reviewed-on: https://chromium-review.googlesource.com/1248130 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Jeremy Klein <jlklein@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594943} Bug: 887775 Change-Id: I1941c20d7c31f8424f3d080db8e3580be01cd41f Reviewed-on: https://chromium-review.googlesource.com/1252626Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#595250}
-
Matt Falkenhagen authored
Reland of r592363, which was reverted due to timeouts. The timeout issue should be fixed by r594723, which changed the mechanism of sending the "last url" message from the navigated frame. Other revisions from the original patch: - Removed the unused expected_tags parameter from the default variant test function. - Removed the dummy message resolver for "last url" from client_variant_test, which is no longer needed after the change mentioned above. - Fixed a bug in redirect-worker.js's getClients(), where we returned instead of continued to the next iteration. Original commit description: > This adds a ?client variant to navigation-redirect.https.html, which > does a lot of redirect tests. This tests the following: > - resultingClientId is the id of the client, if one was created via > that request. > - get(resultingClientId) for requests that did not create a client > resolves with undefined. > - resultingClientId is reset on cross-origin redirects. > - Client.url is the creation URL. > > Bug: 778497 > Change-Id: I08387e96a97df4656d800637862b67b7c8466e14 > Reviewed-on: https://chromium-review.googlesource.com/1206054 > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592363} Bug: 778497 Change-Id: I770f98cef7618c89c1b54245bc89a9c53a19bd5c Reviewed-on: https://chromium-review.googlesource.com/1250306Reviewed-by:
Ben Kelly <wanderview@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#595249}
-
Joey Arhar authored
The request queued time was not converted from seconds to milliseconds before being exoprted to HAR, which is in milliseconds. Added test coverage by adding more timing information to a HAR export test. Bug: 841613 Change-Id: Iea119b16f67a29b2984a7bcca6cf53bd7313723b Reviewed-on: https://chromium-review.googlesource.com/1252881Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#595248}
-
Tarun Bansal authored
Add an API that exposes typical network quality for a given effective connection type. This API would be used to set RTT and throughput values when effective connection type value is overridden due to holdback experiment, or otherwise. Bug: 880545 Change-Id: If83593e31e44e2e0e9ab8357a673300e032cea9e Reviewed-on: https://chromium-review.googlesource.com/1249962Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#595247}
-
Scott Chen authored
Bug: 874122 Change-Id: I99b1feb5cdbd6e7aa5b3ad640567cc54b93c66b3 Reviewed-on: https://chromium-review.googlesource.com/1232879Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#595246}
-
David Tseng authored
Bug: 876571 Change-Id: I18523d2928c203026761b8eefdc2bcd2f939f4f1 Reviewed-on: https://chromium-review.googlesource.com/1251468Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#595245}
-
Scott Violet authored
Otherwise we hit DCHECKs, and likely leave the remote side in a bad state. BUG=890370 TEST=covered by tests Change-Id: Ibb903bf6fe6c67081e18459a142c7c67da0b2ac5 Reviewed-on: https://chromium-review.googlesource.com/1252639Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#595244}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/82b404766db2..42db84264880 git log 82b404766db2..42db84264880 --date=short --no-merges --format='%ad %ae %s' 2018-09-28 bhthompson@google.com Enable Grunt PFQs with HWTests Created with: gclient setdep -r src/third_party/chromite@42db84264880 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ica9776846ceb8bd80ee6d4e49bf6ad7edcafab72 Reviewed-on: https://chromium-review.googlesource.com/1252372Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595243}
-
BUG=762641 TBR=minch@google.com Change-Id: I97cd0ec969f3cdd38a50f52e924b849e24a491a1 Reviewed-on: https://chromium-review.googlesource.com/1252842Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595242}
-
Ryan Hansberry authored
Though UnlockManager listens to Bluetooth power events, it previously did not communicate those events to lower objects, such as RemoteDeviceLifeCycle. This caused crbug.com/889641: RemoteDeviceLifeCycle attempted to begin a connection to the host device without first checking if Bluetooth was present or powered, and because Bluetooth is briefly not present on wake after the laptop lid is closed, RemoteDeviceLifeCycle would always fail. An alternate approach to this issue might have been to place Bluetooth listening logic inside RemoteDeviceLifeCycle, but UnlockManager is already a complex state machine that handles several events including Bluetooth power -- it's cleaner and easier to follow if state changes remain in this one class. Bug: 889641 Change-Id: I2c80da4c4e965b6fc11a0c70230705824dc34dbe Reviewed-on: https://chromium-review.googlesource.com/1252369Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#595241}
-
David Tseng authored
This aligns us with Jaws behavior. The underlying data for table row/column count, and cell row/column index are noteably missing for these layout table nodes, so ChromeVox cannot provide very good feedback for them. Sometimes, there are no cells at all under these layout tables. In terms of the cell navigation, it is typically useful to allow for navigation of these structures using cell navigation commands, but that may need to be handled elsewhere separately from the current set of table commands since not all of the same data is available. Change-Id: Ie04e28eee2c416668a516e0accf49bd9517556fb Reviewed-on: https://chromium-review.googlesource.com/1251456Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#595240}
-
David Tseng authored
- reuse ws::mojom::EventInjector - follow up change will add a binding to chrome.accessibilityPrivate to send a synthesized mouse event (required for ChromeVox + VK support) - removed last bits of ash deps from the file Bug: 594887 Test: chromevox_tests (which makes extensive use of the chrome.accessibilityPrivate apis to send synthetic key events). Change-Id: I1d4ce0703af526a747dd3b9db4422acb6b302307 Reviewed-on: https://chromium-review.googlesource.com/1250126Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#595239}
-
Charlie Harrison authored
See intent to remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/WsnBm53M4Pc Even though speech API does not work properly on content shell, this change can be tested in layout tests because it fails immediately without calling into any synthesis code. To force autoplay, tests need to use the new unified autoplay flag: --autoplay-policy=document-user-activation-required Bug: 812767 Change-Id: I41bee6e37ab46ff2013d096c714b5124bd0ccc2c Reviewed-on: https://chromium-review.googlesource.com/1225650 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#595238}
-
Peter Kasting authored
Per UX leads, this is dead. Bug: 752226 Change-Id: Ie5a353ca973d75b06436a9fef3ac2534bd2b6a3d Reviewed-on: https://chromium-review.googlesource.com/1241813Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#595237}
-
Adam Langley authored
Although these are related, it's a little confusing to users since we otherwise use the origin as the “identity” of a web site. Change-Id: Ic2e5fc09c67094d0a6bbd14910714b56b19e7e97 Reviewed-on: https://chromium-review.googlesource.com/1246300Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#595236}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6956b3094ad4..72f78323a89f Created with: gclient setdep -r src-internal@72f78323a89f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3f7e819d93e90078138ed95b8a272e2a003e9219 Reviewed-on: https://chromium-review.googlesource.com/1252371Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595235}
-
Joanmarie Diggs authored
Step 2E of the Accessible Name and Description Computation spec states: "If the embedded control has role combobox or listbox, return the text alternative of the chosen option." This part of the accessible name calculation had not been implemented in AXNodeObject::TextAlternative. Bug: 890066 Change-Id: I3829d8229b816fe69e939307aa6c44563a757eef Reviewed-on: https://chromium-review.googlesource.com/1249887Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Joanmarie Diggs <joanmarie.diggs@gmail.com> Cr-Commit-Position: refs/heads/master@{#595234}
-
Tommy C. Li authored
Split the Steady State Elisions flags into two: - One for hiding scheme. - One for hiding trivial subdomains. Because of architectural reasons, this also necessitated moving these flags to the toolbar component, which is probably where it should have lived in the first place. This CL also makes ToolbarModelImpl the "flag-checker" instead of OmniboxEditModel. This makes more sense to me in general. This also means some unit test logic is moving to test the logic in ToolbarModelImpl rather than OmniboxEditModel. Bug: NONE Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I17531dc5bc88a5c739c1d2219777805e3374e42b Reviewed-on: https://chromium-review.googlesource.com/1238998 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#595233}
-
Brandon Wylie authored
Bug: 872342 Change-Id: Iaa017e045effcac0f593f79b304f1413350c494c Reviewed-on: https://chromium-review.googlesource.com/1243829Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#595232}
-
siyua authored
1) Associate card network and card number to checkbox. 2) Add accessible text for Google Pay logo and tooltip text for all credit card images. 3) Make migration bubble sticky when first shown. !!!: The problem that checkbox reads "unchecked" even if it is actually checked has not been fixed yet. Has filed bug 889602. Would like to submit this CL first to unblock the browser-tests CL. Bug: 852904 Change-Id: I48ea4a92e7d95327be432bb10126e8338496be97 Reviewed-on: https://chromium-review.googlesource.com/1244888Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#595231}
-
John Abd-El-Malek authored
Bug: 890104 Change-Id: Id2f726cf4a2052080c1f984cb5844f1d084bf1b0 Reviewed-on: https://chromium-review.googlesource.com/1249732 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#595230}
-
Mike Klein authored
We're doing some clean up and would like to retract SkColorSpaceXform from Skia's public API. It's obsolete now that you can either, 1) just use Skia's drawing pipeline or readPixels()/writePixels() for most of its functionality; or 2) use the much more flexible skcms interface for fancy features. In this case, SkPixmap::readPixels() works just fine. Change-Id: I7195eecae4ca71d408a9641c4be8d247d877ac50 Reviewed-on: https://chromium-review.googlesource.com/1203996Reviewed-by:Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#595229}
-
Esmael El-Moslimany authored
- Remove paper-slider dependency. - Differentiate active/inactive markers based on knob position. - Add label support from display-size-slider. - Replace display-size-slider with settings-slider. Bug: 881290, 858882 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ib0863f37f5484f146d7cd944af4fe9a13a35ea0a Reviewed-on: https://chromium-review.googlesource.com/1211805 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#595228}
-
Raymond Toy authored
Implement a few optimizations for AudioParams o Preallocate summing_bus instead of creating a new summing bus each time the final values need to be computed. And only use the bus if needed. o Use vectorized Vclip to clamp the values to the nominal range. Roughly the CPU usage (according to top) goes from 120% to 90% on my machine. The bug contains pprof dot files that show all of the profiling results. Bug: 878301 Change-Id: I99670a8397f5344e9a3ad88fe4d748f7e0486895 Reviewed-on: https://chromium-review.googlesource.com/1249583Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#595227}
-
Charlie Harrison authored
Bug: 820612 Change-Id: If4d415afbbdeef41ad2a0a2d5df27f3a9ebde9e7 Reviewed-on: https://chromium-review.googlesource.com/1227251 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595226}
-
Christian Biesinger authored
To avoid the previous regression (see analysis in bug), we force layout in the case where we otherwise would get an outdated result. This relands https://chromium-review.googlesource.com/c/chromium/src/+/1246730 with an additional fix for the Chrome UI CSS. I also split out the test change into its own patch. IF THIS BREAKS ANY FURTHER CHROME UI: Please don't revert this patch; instead, add min-height: 0 to any inner nested flexboxes that may be affected by this patch. This is an important change for web interop with the other browsers. Bug: 596743,890100 Change-Id: Ice629c2a7823ef07d075fa23b99022b4012c6200 Reviewed-on: https://chromium-review.googlesource.com/1252682Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#595225}
-