- 21 Nov, 2018 40 commits
-
-
Nate Chapin authored
1. When selecting a thread for a task, consider which thread all prerequisites were assigned, not just the ones still pending. 2. Store the v8::Value for completed tasks. 3. If a task will run on the same thread as a completed prerequisite, hop to the worker thread and pass the prerequisite's result directly without a deserialization. (2) enables this, and (1) increases the frequency in which this optimization can be used. 4. Given that it is no longer guaranteed that the serialized result will be needed (i.e., if all dependents run on the same thread and task.result is never requested on the main thread, only the v8::Value will be used), move to a lazy serialization model, where the result is only serialized when it is promised via task.result or when a dependent is assigned to a different thread. Bug: 879306 Change-Id: I22fe5f201f22b376861a5fb6d6e881ce0d5785cc Reviewed-on: https://chromium-review.googlesource.com/c/1311498 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#610136}
-
Peter Kasting authored
This also tries to get closer/improve debuggability for RenderTextTest.MoveLeftRightByWordInBidiText, which remains disabled. Bug: 196326, 906308 Change-Id: I1e9c1217d5ef2e05aa49315de5138c5ad8de0f99 Reviewed-on: https://chromium-review.googlesource.com/c/1343564 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#610135}
-
jdoerrie authored
This change modifies HttpPasswordStoreMigrator to not replace the signon_realm if the previous signon_realm did not have a HTTP scheme. While rare, this scenario can happen for federated credentials that have been saved on a secure HTTP origin, such as http://localhost. Bug: 687968 Change-Id: Ib777aac0aadd1ca39723de40b40fd75193954f7e Reviewed-on: https://chromium-review.googlesource.com/c/1346458 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#610134}
-
Ryan Meier authored
Change-Id: I6d2fcdf455cb65faa67450754b8fea4084783afb Reviewed-on: https://chromium-review.googlesource.com/c/1340957 Commit-Queue: Ryan Meier <rameier@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#610133}
-
Ryan Meier authored
Change-Id: Idc5ad051bdbe1699ddcf018e33f9f09e8de54f48 Reviewed-on: https://chromium-review.googlesource.com/c/1345413 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#610132}
-
Clemens Arbesser authored
This overlay also blocks users from interacting with the website until the onboarding screen is closed. Before: https://screenshot.googleplex.com/Xx1bJCk0YBp.png After: https://screenshot.googleplex.com/zBX6vYLym2c.png Bug: 806868 Change-Id: Id4cbb9c19ef561c5e61d70891830541e4dcfadbb Reviewed-on: https://chromium-review.googlesource.com/c/1346302 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#610131}
-
Benjamin Wright authored
CryptoOptions recently was promoted to the api directory and the semantics were changed such that it should be set per PeerConnection. This aligns with its extended scope as a general place for all crypto related options in WebRTC. This change removes setting these options on the Factory itself which is deprecated in favor of explicitly setting them per PeerConnection. This will eventually be expanded to other options such as disable encryption which are still in the process of being merged into webrtc::CryptoOptions. Bug: webrtc:10020 Change-Id: I8ea7198ca12ecf5a663bc87dbe3d122f3feebf71 Reviewed-on: https://chromium-review.googlesource.com/c/1344827Reviewed-by:
Steve Anton <steveanton@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Ben Wright <benwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#610130}
-
Victor Vasiliev authored
This platformizes absl::CHexEscape, absl::Hex, ABSL_FALLTHROUGH_INTENDED and UNREACHED(), EstimateMemoryUsage. All uses are fixed, as well as some of the other minor changes. Merge internal change: 222281858 R=bnc@chromium.org Change-Id: I905726a43e8a97b8258fb5c689871a5df511815e Reviewed-on: https://chromium-review.googlesource.com/c/1344951 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#610129}
-
Alex Newcomer authored
Do not SEND_GESTURE_EVENTS_TO_OWNER unless the icon is in a drag. Example: We used to send this runtype for all gesture events. This does not work as expected for two finger taps. Bug: 906692 Change-Id: Ie1c5f16f2d0552df6147b9abf3b495c63b69ce93 Reviewed-on: https://chromium-review.googlesource.com/c/1346953Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#610128}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bbe98fbac5e1..a285cdeb4d1a Created with: gclient setdep -r src-internal@a285cdeb4d1a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I53b58d75faaef00c737a8fe22670379a9fef9474 Reviewed-on: https://chromium-review.googlesource.com/c/1346790Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610127}
-
Scott Violet authored
This patch makes showing/hiding the WindowTreeHost's window behave the same as if Widget Show/Hide was called. This is necessary for transient windows to work. In particular it's expected that hiding the transient parent hides transient children. TransientWindowManager does that by way of calling show/hide directly on the aura window. I could have added the ability to inject function to accomplish that, but I know I've run into other code expecting show/hide on the aura window to map to showing/hiding the widget. BUG=883371 TEST=covered by tests Change-Id: I6ee9009732ba1b5f47e888a1a841f462a1f5a851 Reviewed-on: https://chromium-review.googlesource.com/c/1340964 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#610126}
-
Ryan Tseng authored
Bug: 889221 Change-Id: Ie26aca388f600ee6a0983ee378c9b5b70e5efba6 Reviewed-on: https://chromium-review.googlesource.com/c/1342400Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#610125}
-
Roger Tawa authored
with no internet. Bug: 906767 Change-Id: Ib98660b4a27f6d0f5f1d5b5706813307b06bc80b Reviewed-on: https://chromium-review.googlesource.com/c/1343286 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#610124}
-
Robert Kroeger authored
WebglConformance_conformance_textures_video_tex_2d_rgba_rgba_unsigned_short_5_5_5_1 is flaky on Android Android Release (Nexus 5X). Add a suppression. BUG=907512 TBR=kbr@chromium.org Change-Id: I13c43db1d7f9ee216e250e861d16c1a4879dbe5e Reviewed-on: https://chromium-review.googlesource.com/c/1346870Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#610123}
-
Hao Zhang authored
Bug: 899057 Change-Id: Id1a0c15bfb3dbe8c0f1f967b25ce6dd7f2bd240e Reviewed-on: https://chromium-review.googlesource.com/c/1334928 Commit-Queue: Hao Zhang <hozhng@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#610122}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6aab06e0e5d4..9f379f493cd7 git log 6aab06e0e5d4..9f379f493cd7 --date=short --no-merges --format='%ad %ae %s' 2018-11-21 courtneygo@google.com Revert "Fix AndroidManifest package name" Created with: gclient setdep -r src/third_party/angle@9f379f493cd7 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ie64341555da3e24a466fec4f9fbeab6227c10e47 Reviewed-on: https://chromium-review.googlesource.com/c/1347070Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610121}
-
jdoerrie authored
This change fixes a DCHECK in GetSignonRealmWithProtocolExcluded triggered when operating on credentials where the form's origin contained a port, but the signon_realm did not. For example. this can happen for federated credentials. Furthermore, this change improves the robustness of InvalidRealmCredentialCleaner and HttpCredentialCleaner by performing the HTTP / HTTPS check on the form's signon_realm instead of the origin. Bug: 871140 Change-Id: If4c531e0c8741db05f5e1b7565c5fd6026836ae6 Reviewed-on: https://chromium-review.googlesource.com/c/1345512 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#610120}
-
Saman Sami authored
WebglConformance_conformance_uniforms_uniform_default_values is flaking on Win10 FYI Release (NVIDIA). TBR=kbr@chromium.org Bug: 907544 Change-Id: Ib41ff367449b0fd3c424d95fdf39f4fdcf7e4633 Reviewed-on: https://chromium-review.googlesource.com/c/1346673Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#610119}
-
Ben Pastene authored
The luci version is currently broken. Will switch it back when bug 790372 is fixed. Bug: 907542, 790372 Change-Id: Ic51139317f7a330ee9bd719b97cfb111154b7da2 Reviewed-on: https://chromium-review.googlesource.com/c/1347056Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#610118}
-
Morten Stenshorne authored
The extrinsic constraint space was used to calculate the intrinsic min/max sizes of orthogonal roots. However, now that our orthogonal flow fallback available inline size calculation is good enough, we no longer need the concept of "extrinsic constraint space". Instead create one with infinite sizes, but with correct fallback inline size. One change is required, though: We need to honor fixed block-size (and not just block-max-size and block-min-size) when calculating the fallback size. During layout, that size is already taken care of and put in the constraint space, but during intrinsic sizing, that isn't the case. Create the infinite constraint space in ComputeMinAndMaxContentContribution(), rather than at all call sites. Make the NGConstraintSpace parameter non-optional, and make it clear that it's the parent constraint space we take as input; previously it was sometimes the child's and sometimes the parent's. Change-Id: I7c884e383266c67bfa9438e98ad1312b39ea9372 Reviewed-on: https://chromium-review.googlesource.com/c/1341513 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#610117}
-
Jonathan Backer authored
With the transition to SharedImage, many of the RasterInterface methods are not longer used. This will make it easier to support RasterDecoder with passthrough textures. Change-Id: Ie62c4ecfa978a85a6f74a996c0e75ce9dcc38315 Reviewed-on: https://chromium-review.googlesource.com/c/1327607 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#610116}
-
Peter Kasting authored
The tests currently assume that the normal and CJK fonts have different metrics. On Android, this is not true for all platforms we support. The tests still have some value when run with fonts with identical metrics, so modify the test expectations slightly to work in that case and enable these tests. Bug: 865540 Change-Id: I6cd98a254f9ae0e6c6a9818e37c9ae69ca954f13 Reviewed-on: https://chromium-review.googlesource.com/c/1343531 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#610115}
-
Stephane Zermatten authored
With this patch, scripts can use a 'prompt' action to ask questions instead of ending the script. The UI of 'prompt' looks just like the UI that appears between scripts, so the choice between a prompt and multiple scripts should be a scripter implementation decision. The prompt action, can: - allow a subset of the page to be touchable, as controlled by the focus action, like what happens between scripts - propose suggestions to be displayed in chips, to simulate script execution - react to element existence, to simulate preconditions Limitation: Prompt does not allow navigation outside of the current page, nor page reloads. Bug: 1340309 Change-Id: I033399621e5afa0d02021cac6cab6765c913970c Reviewed-on: https://chromium-review.googlesource.com/c/1343266 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#610114}
-
Alex Newcomer authored
During long press, we request menu options twice. Avoid making this expensive call twice. Before, we returned early on the callback. Keep that incase race conditions, but also return early before the request if a menu already exists. Bug: 907556 Change-Id: Ie7798e25faea5128651f4a06415d978a5a6cbe35 Reviewed-on: https://chromium-review.googlesource.com/c/1347090Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#610113}
-
Nico Weber authored
luci-milo.cfg linter: Lint bot category, and check that each toplevel category on the main waterfall has a subwaterfall. Also tweak a few categories to make main and subwaterfalls match. Bug: none Change-Id: I15ac12e6854be01af39da8869b87102ec17f305a Reviewed-on: https://chromium-review.googlesource.com/c/1346731Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#610112}
-
Gayane Petrosyan authored
This reverts commit c03fc8e7. Reason for revert: <INSERT REASONING HERE> Original change's description: > Roll clang 346388-1:346388-4. > > Ran `tools/clang/scripts/upload_revision.py 346388 4`. > > Bug: 870331 > Change-Id: Ie2ebb3aa52bc757f4a0680cdbf8f060a030ce9a6 > Reviewed-on: https://chromium-review.googlesource.com/c/1344209 > Reviewed-by: Hans Wennborg <hans@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Hans Wennborg <hans@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610096} TBR=thakis@chromium.org,hans@chromium.org,rnk@chromium.org,mmoroz@chromium.org Change-Id: Ica508f221abd3f53dee66eb3f1937773c8947d27 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870331 Reviewed-on: https://chromium-review.googlesource.com/c/1347104Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#610111}
-
Mike Reed authored
Bug: skia:2664 Change-Id: Icf69c8361ae1ff939d95ba3ac74d080ea9027525 Reviewed-on: https://chromium-review.googlesource.com/c/1343658Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#610110}
-
Egor Pasko authored
TBR=yusufo@chromium.org NOTRY=true NOTREECHECKS=true Bug: 907548 Change-Id: Iff9b41e03778f21a0a81584b70d55fdfdeb9fdd8 Reviewed-on: https://chromium-review.googlesource.com/c/1346952Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#610109}
-
Guido Urdaneta authored
Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V2srjdzRCXE Bug: 854980 Change-Id: Ie49e3d2f9b8afe1abc552172d78dd86088b6ce41 Reviewed-on: https://chromium-review.googlesource.com/c/1310714 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#610108}
-
Leszek Swirski authored
This reverts commit 1ed3b3c2. Reason for revert: Re-enabling the trial now that 874080 is being field tested. Original change's description: > [config] Disable scheduled script streaming field trial > > Measure the impact of the current trial by seeing what regressed, and > disable while waiting for Bug:874080 to be resolved, since there are > currently some loading regressions. > > Bug: 715309 > Bug: 885053 > Bug: 886668 > Change-Id: I4497e11373ffa92d3e5f5844fa9fbe73fef6bf4b > Reviewed-on: https://chromium-review.googlesource.com/c/1255946 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596175} TBR=rmcilroy@chromium.org,holte@chromium.org,leszeks@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 715309, 885053, 886668 Change-Id: I59f9e0d1f5b97a75d7d81e98471cd21a3a68888b Reviewed-on: https://chromium-review.googlesource.com/c/1296502Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#610107}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/76499cd866b6..2da0d123402a git log 76499cd866b6..2da0d123402a --date=short --no-merges --format='%ad %ae %s' 2018-11-21 hjd@google.com Merge "perfetto-ui: Use table name in cpu track" Created with: gclient setdep -r src/third_party/perfetto@2da0d123402a The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I6b2eb0dc703d116d661ebf022b545cedf4e20046 Reviewed-on: https://chromium-review.googlesource.com/c/1346789Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610106}
-
Antoine Labour authored
We need to make sure we consistently pick the texture target, because native GMBs may not be available for all usages. Bug: 905569 Change-Id: Ibc325a23494597fefab3e62da71656bae30a42df Reviewed-on: https://chromium-review.googlesource.com/c/1345074Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#610105}
-
Tim Volodine authored
Enable the Speech recognition part of the Web Speech API in Android WebView. Speech synthesis API remains disabled for now, see crbug.com/487255. BUG=487255 TEST=https://www.google.com/intl/en/chrome/demos/speech.html Change-Id: Id2c2654c34f63a5ba2ac883614a24b18ab419015 Reviewed-on: https://chromium-review.googlesource.com/c/1340318 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#610104}
-
Anthony Vallee-Dubois authored
This is simply a follow-up on https://chromium-review.googlesource.com/c/1315949 that handles links being opened in a different tab. Bug: 900586,872777 Change-Id: I212e1d787db30da988dddaff0fc9e29978d7222e Reviewed-on: https://chromium-review.googlesource.com/c/1331667Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#610103}
-
Moe Ahmadi authored
Bug: 892376 Change-Id: I6f3a802cb11eb18f6470b35d70f683a7b0c9abaa Reviewed-on: https://chromium-review.googlesource.com/c/1335879Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#610102}
-
Abhishek Arya authored
R=glider@chromium.org Change-Id: Ia8a300ba5f993862502017d4e164388bd6e0206d Reviewed-on: https://chromium-review.googlesource.com/c/1346466Reviewed-by:
Alexander Potapenko <glider@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#610101}
-
Robert Kaplow authored
This changed the datatype checks from GetPreferredDataTypes to GetActiveDataTypes and adds IsSyncFeatureActive() check instead of connection_status. Tested end-to-end verified against the butter experiment. Bug: 906609 Change-Id: I23c0f80cf707a1e8cca5b3f2aa99a3aebc6eec94 Reviewed-on: https://chromium-review.googlesource.com/c/1343369 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#610100}
-
Martijn Croonen authored
This updates from revision 6f2b9e75eaf65bb75da83677655a59110088ebc5 (2018-10-03) to revision 5af964eadf5b6baaf5f612746837cb154e1f73b1 (2018-11-08) Bug: 904963 Change-Id: I7a7caf8e98b35791ccb95e6f0d5ce48647d237cc Reviewed-on: https://chromium-review.googlesource.com/c/1343098Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Martijn Croonen <martijnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#610099}
-
Kevin McNee authored
cross-process-guests sets the value for the GuestViewCrossProcessFrames feature. The feature itself has been enabled by default since M63 (see issue 655753), however we've been keeping it around for testing purposes. It's no longer useful to have this exposed via about:flags, so we'll remove it there, but keep the feature so we can still test with --disable-features=GuestViewCrossProcessFrames Bug: 533069, 665722 Change-Id: I1dcb84e0facf288059bc1cad555108f543847ae1 Reviewed-on: https://chromium-review.googlesource.com/c/1340916Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#610098}
-
Alexei Svitkine authored
- Makes the "retry shortly" logic on first failed request takes precedence over HTTP fallback. This way, when this happens users won't immediately try HTTP if the first request fails (which can be frequent per comment). - Makes it so if there's a restrict parameter, the HTTP fallback is disabled. This should prevent users with a restrict parameter toggling their state (since that can have surprising and undesirable effects such as UI features toggling on and off.) Bug: 902489 Change-Id: I2cd7d24258acb7363287086a63fb94a93de8cd89 Reviewed-on: https://chromium-review.googlesource.com/c/1340823 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#610097}
-