- 23 Jun, 2020 40 commits
-
-
Fan Yang authored
https://quiche.googlesource.com/quiche.git/+log/d7afab2f4566..bd7ad68ab12b14 $ git log d7afab2f4..bd7ad68ab --date=short --no-merges --format='%ad %ae %s' 2020-06-23 fayang Fixes to make chromium merge happy. No functional change. 2020-06-23 haoyuewang Use writevarint62 instead of writeuint8 to write the frame type in ietf quic as the ietf draft specifies that the frame_type uses variable length integer encoding. no behavior change. 2020-06-23 dschinazi Remove QUIC draft-28 2020-06-22 nharper Remove unused server designated connection ID from QUIC 2020-06-22 fayang In quic, include minplaintextpacketsize when deterine whether removing soft limit for crypto frames. protected by enabled gfe2_reloadable_flag_quic_fix_min_crypto_frame_size. 2020-06-22 wub For quic loss detection, replace quicconnectionstats.total_loss_detection_time by quicconnectionstats. total_loss_detection_response_time to improve the accuracy of detection speed. protected by existing --gfe2_reloadable_flag_quic_enable_loss_detection_experiment_at_gfe. 2020-06-22 dschinazi Avoid crash in QuicDispatcher 2020-06-22 dschinazi Allow setting connection options from command line in QuicToyClient 2020-06-22 wub Deprecate --gfe2_reloadable_flag_quic_bbr_default_exit_startup_on_loss. 2020-06-22 fayang In quic, let client bundle handshake data (containing client finished) with handshake ack. protected by existing gfe2_reloadable_flag_quic_bundle_crypto_data_with_initial_ack. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=dschinazi@chromium.org Change-Id: I3984c4289194ff0e6f5c509dc958fed9d4551d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261357 Commit-Queue: Fan Yang <fayang@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Auto-Submit: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#781531}
-
Arnaud Mandy authored
Split setIds(internalId, primaryId) into 2 distinct methods, setInternalId(id) and setPrimaryId(id). Bug: 1075656 Change-Id: I312950db43d0044cbaf923e458912816a06834e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245616 Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#781530}
-
Richard Knoll authored
ScopedObserver makes sure that the observers are always removed on destruction. Found while running tests and adding a CHECK to the destructor to see if it is still inany observer list. Bug: 1055483 Change-Id: Ia230170ac17a558ec9257df15fa115b2e83d6dcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257423Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#781529}
-
Dominik Röttsches authored
On each decoration level, a thickness can be specified that is individual to the decoration specified at this decorating box / level. Carry those in AppliedTextDecorations to ensure that ancestral decorations do not get incorrectly painted using the stroke thickness that is specified on the current element. A previous attempt had been made to carry the resolved thickness (e.g. a percentage resolved against a font size but that won't work due to the AppliedTextDecoration vector being const in ComputedStyle and ComputedStyle generally kept const). Also, computing the resolved thickness in ComputeDecorationInfo fits the current conventions better. Thus, instead of carrying a single thickness in DecorationInfo, which overrides all thicknesses of previous AppliedTextDecorations' carry a parallel array with as many entries as there are AppliedTextDecorations and store the resolved thicknesses in those. Bug: 1096038 Change-Id: Ifdaf6dd167024a919fafae297e5a01a226b9cda1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252081 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#781528}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592924274-08d5db635b74d1eb292c1b13837063587fddd457.profdata to chrome-win64-master-1592927234-93fd17f09f62ae1a92f26a9127978b7f390ce8f1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Iadd7df5276ccda216aefa676d6fa72691a17d43d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261057Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781527}
-
Scott Little authored
This CL adds a new string that will be used for the in-product help that will direct the user to Downloads Home when the offline indicator appears. Screenshot: https://crbug.com/1068700#c6 Bug: 1068700 Change-Id: Ia6ca521f5818427423db22f9143c290cf9738bc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261240Reviewed-by:
Sinan Sahin <sinansahin@google.com> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#781526}
-
Chris Sharp authored
TBR=takumif@chromium.org Bug: 1095068 Change-Id: I60ea6b482f0436b0113b33d8a50e2530829e6658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260431Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#781525}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic5e8f6e32c62bd98b042c0401a93090038b87b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261397Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781524}
-
James Long authored
Two inputs were added controlling the inbound/outbound node display. The visualization now does a BFS outwards from the filtered node set to find more nodes to show, specific details on this logic can be found in Graph.getDataForD3. The inbound/outbound nodes are color coded with the closer ones being darker. Bug: 1093962 Change-Id: I56ee9c9401a46bc0a45ca9274954429155a3b27d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258253 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#781523}
-
Lei Zhang authored
On Windows, print drivers can only be safely accessed on the UI thread, but the UI thread disallows blocking by default. Make an exception for PrintJobWorker::UseDefaultSettings() for the same reason as PrintJobWorker::UpdatePrintSettings(). Bug: 1098434 Change-Id: Ic589a07faa7865e25b1007c8103662e006f7de5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261144Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#781522}
-
Yuheng Huang authored
TabSearchUI is used for serving webui resources for tab search feature, which will be checked in later. TabSearchPageHandler implements the tab_search.mojom interface. The logic of this CL is mostly mimicking TabStripUIHandler. Some code is moved from TabStripUIHandler to chrome/browser/ui/webui/util/image_util.h to be able to used in TabSearchPageHandler as well. Bug: 1096120 Change-Id: I4668ad18ebb84282dc44d2dfb78916f54cd55abc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242215 Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#781521}
-
Jeff Yoon authored
ios14-beta-sim to compile with xcode 11e146, and run tests on xcode 12a6159 and sims version 14.0. ios14-sdk-sim to compile with xcode 12a6159 and run tests on 12a6159 with sims 12.4, 13.6 and 14.0. Change-Id: Ibb26eeba9e393437e45ba2b81f423e4ade220870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259516 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#781520}
-
Mohamed Amir Yosef authored
Before this CL, the code was mistakenly adding internal padding to the menu position. But both the combobox and the dropdown draw their borders similarly and hence they should use the same bounds. Screenshots: Before: https://screenshot.googleplex.com/DrCgx0mp5Th.png After: https://screenshot.googleplex.com/0EEH40BOw1p.png Bug: 1044038 Change-Id: I275b3ae320d44e93357364a64a9f37a607445d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261273 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#781519}
-
Michael Li authored
Adds SequenceChecker to UpgradeDetector so that all accesses take place on the same thread, and moves ServiceProcessControl's calls to the UpgradeDetector to functions that happen on the browser/UI thread. Bug: 1096318 Change-Id: I5bf92ff4011c314c44b6e6e40f77ebec81bf9f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244127Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Michael Li <michli@microsoft.com> Cr-Commit-Position: refs/heads/master@{#781518}
-
Stephen Roe authored
fuchsia runner. This enables fuchsia test runner scripts to write auxiliary log files to a logs directory using runner_logs.RunnerLogManager. Bug: 1067356 Change-Id: I3fd98b23c62c5d452ff29fa1208fbfa9bc6c21e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249040Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#781517}
-
Anastasia Helfinstein authored
AX-Relnotes: n/a. Bug: None Change-Id: I7b808caae181c14bf47ba69f6b24f18aed755c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256851Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#781516}
-
Brian Sheedy authored
This reverts commit 7c9e1f12. Reason for revert: Test failures were due to untriaged images, fixed now. No change from original CL. Original change's description: > Revert "Switch RenderTests to use SkiaGold" > > This reverts commit 3ed31ecf. > > Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%2064%20bit%20Tester/32796 > > Bug:1098417 > Original change's description: > > Switch RenderTests to use SkiaGold > > > > Switches all uses of RenderTestRule to use the SkiaGoldBuilder method > > of constructing it, which results in all Android RenderTests being > > backed by Skia Gold. > > > > Bug: 1057851 > > Change-Id: I63d40faef7863dddb5edaa93aef8559eb4d3696d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248742 > > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > > Reviewed-by: Theresa <twellington@chromium.org> > > Reviewed-by: Bo <boliu@chromium.org> > > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > > Reviewed-by: Peter Conn <peconn@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#780931} > > TBR=boliu@chromium.org,twellington@chromium.org,wychen@chromium.org,peconn@chromium.org,bsheedy@chromium.org,tiborg@chromium.org > > Change-Id: I58bd6a0289cb496c62ae4b5556374ffcbfa333ce > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1057851 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261178 > Reviewed-by: Gang Wu <gangwu@chromium.org> > Commit-Queue: Gang Wu <gangwu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781429} TBR=boliu@chromium.org,twellington@chromium.org,gangwu@chromium.org,wychen@chromium.org,peconn@chromium.org,bsheedy@chromium.org,tiborg@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1098417, 1057851 Change-Id: I4762d97220b6b0745c462d220e90ffd8ed1043ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261257Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#781515}
-
Hesen Zhang authored
Part I to setup logger for TileService. Logger: The public interface to the log code. Can be queried for state and returns base::Value objects. Logger::Observer: Used to notify external components (e.g. WebUI) about internal state changes. LogSink: The internal interface that should be notified by internal components about potential log-worthy changes. LogSource: The internal interface that Logger will request state from. Also Add BlackHoleLogSink and EmptyLogger for test purpose. Bug: 1066556 Change-Id: Ib8ee202c650cf72de20ab5cb6b9038ea51d5f651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250891Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Auto-Submit: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#781514}
-
Adam Ettenberger authored
Adding template specialized class VariantUtil which adds Get and Set methods for the underlying data in a VARIANT specific to a VARTYPE. This is useful for template methods, since it makes it easier to templatize VARIANT logic, avoiding macros like V_BOOL, V_UNKNOWN, etc. The VariantUtil class also has a typedef |type| for the underlying type associated with a specific VARTYPE. e.g. VT_BOOL => VARIANT_BOOL, VT_UNKNOWN => IUnknown*. Moving IsLeakableVarType out of ScopedVariant and into variant_util.h. Split out from : https://chromium-review.googlesource.com/c/chromium/src/+/2188057 Bug: 928948 Change-Id: I8f8e4bcbf7620122ec361c4947175271ee5e6be6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244454 Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#781513}
-
Mohamed Amir Yosef authored
Before this CL, the code was mistakenly adding internal padding to the menu position. But both the EditableCombobox and the dropdown draw their borders similarly and hence they should use the same bounds. Screenshots: Before: https://screenshot.googleplex.com/RBcFKJ0WqBC.png After: https://screenshot.googleplex.com/HfCZTOgE8dv.png Bug: 1044038 Change-Id: Ib6595b9165518886a88e5513653d22f197534545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260879 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#781512}
-
Makoto Shimazu authored
Let's keep monitoring it for health check. Bug: 1089488 Change-Id: Ieacbd68692b0176bf5500f11b3b76984f24325c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259754 Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#781511}
-
Anqing Zhao authored
Some cases in the KioskAppManagerBrowsertest are flaky because SimpleURLLoaderImpl::OnReceiveResponse may get non-500 failure response code. I suspect they are actually 400 error, but don't have enough evidence. Add some additional logic to log this information to figure out the root cause. Bug: 1090937 Change-Id: Ia343519dbd06311dfde2bccd25d9ebf86bb72566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257857Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Anqing Zhao <anqing@chromium.org> Cr-Commit-Position: refs/heads/master@{#781510}
-
Kushagra Sinha authored
If |chromeos::AccountManager::Initialize| is called twice, it may happen that the second call may complete before |AccountManager|'s initialization is actually complete. Fix this by keeping duplicate initialization callbacks in a queue until initialization is complete. Change-Id: Ib44ffaed733fd3a567bdd8d256d04b182b1dbff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255458 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#781509}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/30a3e787948d..24762f207fa1 2020-06-23 mbonadei@webrtc.org Fix missing dependencies. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If9c3e551678e369a14fa57aadc4b92ea32579a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261055Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781508}
-
Adam Langley authored
This one case didn't use |InvokeCallbackAndCleanup| and thus didn't call |Cleanup|. Change-Id: I6a0dcdb237efe4c1e9be5782151e1295977c1fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255212 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#781507}
-
Elly Fong-Jones authored
This change also removes some now-unneeded instance vars. Bug: 1075649 Change-Id: Ibac05c4b28f6f89f40bb153ba63bd3f46d075b00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252920 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#781506}
-
Sebastien Marchand authored
This also emits a tracing event before calling each listener. TBRing per https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#mechanical-changes TBR: fdoray@chromium.org Change-Id: I6d73a0f1796dcb06a01cbf9201116639eab37bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244692 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#781505}
-
Evan Liu authored
Patchset 1 contains the reland without any changes. This CL adds a callback to the speech recognition client that is called when all of the mojo pipes are bound, indicating that the speech recognition service is available. Bug: 1096632 Change-Id: I0006298c3d3191c84c80d920031abfcbf10e5cf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260935Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#781504}
-
Pete Williamson authored
Route feedback from the interest feed to the discover team instead of the Chrome mobile team for processing. Bug: 1091058 Change-Id: I186ff9e2078f5f0dea71e3417c5b8186530f7368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261253Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#781503}
-
Nicolás Peña Moreno authored
This bug fixes a problem that may arise when the largest image is loading and then removed. Before, we'd continue to wait for the paint time of such image, and hence would only correctly update the experimental LCP value if we ever painted something at least as large as that removed image. Bug: 1045640 Change-Id: I356a58215003871cc15e3bee3ed86423ac612934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255498 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#781502}
-
Charlene Yan authored
Also found a bug while writing tests... The shift tab code doesn't take into account collapsed groups :X Bug: 1018230 Change-Id: I04fd40de6b24ec892170a9a92a1d4cae51bc444e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261215Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#781501}
-
Eugene But authored
This change is required for persistent breadcrumbs to identify sessions boundaries. It would be better to log different events based on launch type, but this CL is a good tradeoff between complexity and usefulness. Implementation fully mirrors how "Shutdown" event is logged. Bug: 1082892 Change-Id: I28e92353567be0079ab16c6eb73f39230f117e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253219 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#781500}
-
Christopher Cameron authored
Sampling out YUV 420 (biplanar) textures will give RGB pixel values. This is present (e.g, in ResourceFormatToClosestSkColorType). This case is needed to not crash SkiaRenderer when drawing video on macOS. Bug: 894929 Change-Id: I8d83b90c0efa8b6400f119492caaa5fe7d136d9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261393Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#781499}
-
Gabriel Charette authored
::PeekMessage can process sent-messages and internal events. It seems the kernel also uses it as a heuristic to deschedule the main thread when it thinks it's out of messages. In MessagePumpForUI's design, it's possible to have application tasks without pending native tasks (kMsgHaveWork is dropped when running out of native tasks). This CL uses ::GetQueueStatus() to probe the presence of messages before invoking ::PeekMessage(). Bug: 1075960 Change-Id: I4a93b22adf225ae2d62aabeb1a7a734232cf7fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258456 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#781498}
-
Morten Stenshorne authored
Remove some code (that had no test coverage), that I initially thought we'd need, but it's actually incompatible with how an upcoming CL will deal with float fragmentation. Bug: 1043787 Change-Id: I9a5cb7c2334c8c17360b6c20e2fb4de078072b79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260612Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#781497}
-
Adam Langley authored
(Test-only change.) There are a few cases where a test wants to parse the response to an assertion, and I'll shortly be adding some more. Pull out some common code for this into a function. Change-Id: I9a2b53c58d5fe58565e3bc111b67ece28994c3ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255211 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#781496}
-
Mila Green authored
Bug: 1076543 Change-Id: I1286243c1e85a9c7409c5f1f9e326e9ecc337422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250161 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#781495}
-
Julian Pastarmov authored
Used to be a single zip file of all languages which is more inconvenient format for the further steps of the pipeline that copy this files over to the public documentation page. BUG=1082694 Change-Id: I89faec3b5262e443cf768341172b1091bc15596f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256206 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#781494}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592917001-0fc7f1d9ca8aa2b3be882f696f21c14836e980c4.profdata to chrome-win32-master-1592920709-d1856a35d8275495ca631105d3b73ea9c8fbb208.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I1c0c0e2e81a8b4d7b93c9cb6b9b8b086ef65ce56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260921Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781493}
-
Ryan Sleevi authored
Add guidance and documentation regarding upcoming certificate lifetime changes. Bug: 1097982 Change-Id: If6073b63774b80e8a01a6940d7c262b603c1ff70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258690Reviewed-by:
Andrew Whalley <awhalley@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#781492}
-