GitLab

This CL extracts the core stack copying parts of
tracing::StackUnwinderAndroid into the dedicated base::StackCopierSignal
class, and adapts it for direct use by the sampling profiler stack
unwinding implementation. This drops some unneeded code; updates the code
to run on 32-bit Android, 64-bit Android, and 64-bit Linux platforms;
and converts the code to use C++ atomics.

The StackUnwinderAndroid implementation will eventually be replaced
wholesale by the sampling profiler implementation for Android. This CL
does not attempt to reuse the extracted stack copying implementation on
its own, in order to avoid introducing bugs in StackUnwinderAndroid due
to the differing implementations.

The reland enables the StackCopierSignalTest.CopyStackFromOtherThread
test on 32-bit Android only.

TBR=gab@chromium.org

Bug: 988579, 1018615
Change-Id: I96704fe4843994721a0eb37896e11bea99be3fda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884376
Commit-Queue: Mike Wittman <wittman@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710415}

This CL fixes a race where the toolbar icon could be stuck in a
disabled state. The issue was that we didn't "unbind" the
MediaNotificationItem if we were already frozen and bound, causing the
MediaNotificationItem to get out of sync with the
MediaToolbarButtonController.

Bug: 1015903
Change-Id: I67df3365ecedf019f8edb621b660c9cc97a3bf38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886294Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710414}

This adds an error message to ProcessInitException, and in the process converts
the error class to @IntDef.

Bug: 979638
Change-Id: I1b1c531b0fdb212b70a977e7c84bde3043a00aa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876329
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710413}

This is a late follow-up to
https://chromium-review.googlesource.com/c/chromium/src/+/1287850 --
since GetChannelName() now depends on GetChannel() being called
previously, call it instead of relying on something else having
called it.

Probably a no-op in practice, but it makes the code more reliable
and look less surprising.

Bug: none
Change-Id: Ie4e2c791db52f590d44d906fb5b0a42f521d427e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887270
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710412}

Bug: 996858
Test: manually tested on arm device
Change-Id: If24a863284a8f34704137eaef304822dc43bc181
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797653Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710411}

Currently in ChromeVox, we ignore events that come as a result of
ChromeVox actions. However, this is causing us to ignore focus
events that fire due to click actions. We do, in fact, want to
process these events.

This patch changes how events triggered by clicks are populated
so that we respond to them on the ChromeVox side.

Bug: 955129
Change-Id: Id0e6c0cb8899fef44721b4272eb9a48cb51e0443
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872570Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710410}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b6a2156a1346..8f67b33f0e7b


Created with:
  gclient setdep -r src-internal@8f67b33f0e7b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I7762f9d5d3c272153360fd262b2e316090ef8d61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887670Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710409}

Moving documention about Chromium-specific build flags from the main repo.

TBR=takumif@chromium.org

Change-Id: I65b78cad32762bc882f13b1b5ecb7a2432da08c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872723Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710408}

This function will shortly need to be reused in WebLayer's initial
implementation of interstitials. To accomodate this, this CL
componentizes this function into a new ssl_error_options_mask.* that
also now includes the SSLErrorOptionsMask enum.

Code authored by blundell@chromium.org

TBR=eugenebut@chromium.org

Change-Id: I6fbfce25b705c0a6018fe42c516c6a554b4fc757
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879256Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710407}

 - Renamed graph_tab.js to graph_tab_template.js, otherwise GN
   complains that two different rules (polymer_modulizer, generate_graph_tab)
   declare the same output file.
 - generate_graph_tab now depends on polymer_modulizer, and processes
   the JS file that holds the HTML contents (in Polymer3 all HTML is hosted in JS
   files)
 - Changed substitute() to safe_substitute() in generate_graph_tab, otherwise Python
   trips over occurrences of "$" in the same file which don't correspond to
   template strings.
 - Extracted tests to a separate file so that they can be loaded in a JS module
   context.
 - Added missing js_library() dependency for ui/webui/resources/cr:icon.m, to fix a
   type checking failure.

Bug: 1017874
Test: Page still works, no more HTML imports warnings in DevTools
Change-Id: I77b9d7e8cb75cf8f9edc0ff91ad9eeb31118e704
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879782Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710406}

The tests which require configuring fine-grained test server behavior
or, worse, bugs will be harder to resolve (maybe it's time to implement
a barebones MockSSLServer in BoringSSL), but a lot of them can use
EmbeddedTestServer easily.

Since EmbeddedTestServer now pulls in TLS 1.3 which is vastly different
from TLS 1.2, I've made most tests parameterized by version just to be a
bit more thorough in testing.

Bug: 492672
Change-Id: I87232d82d1c3a6f70099976fe4629457856b9f37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874247Reviewed-by: Steven Valdez <svaldez@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710405}

In changes pdfium:60110, pdfium:60410 and pdfium:59670, we exposed new
APIs for text style: fill/stroke color, rendering mode and weight.
This change forwards these new available text properties(+ font-family,
which was already exposed) to the
ppapi::PrivateAccessibilityTextRunInfo struct. We use an object of
this type in PdfAccessibilityTree to create the AXNode.

The next step is to populate this information on AXNode.

Bug: 985604
Change-Id: Ia2e41c5427cfb972c071c2a3608631a4f23e6ff8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752165
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ian Prest <iapres@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#710404}

Make GetChannelSuffixForDataDir() exist always on linux, to make
it independent of GOOGLE_CHROME_BRANDING. On Linux, disentangle
the logic in that function from GetChannelImpl() and instead
make it call GetChannel(). This makes it automatically do the
right thing in unbranded builds (returning an empty suffix).

This should be behavior-preserving, but if we ever wanted to do
release channels for unbranded builds, this is a tad easier
to do now -- and we have less mode-dependent code.

Bug: 961769
Change-Id: Id9aec641c3468033f8d676c14874a68016493fea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887152
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710403}

Many of the portal browser tests have the same steps to run at the
beginning of the test: inject script to create a portal and to navigate
it to a given URL, and then wait for the navigation to finish. We factor
this out into a common function.

We also perform a few small cleanups. We rename the test
ReactivatePredecessor to AdoptPredecessor, since it doesn't actually
reactivate. We increase usage of JsReplace instead of StringPrintf.

Bug: None
Change-Id: Ia1ef41b8138df0189ad3291b76c34be53c291403
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885171Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710402}

This reverts commit 667d336e.

Reason for revert: Breaks downstream Android builds.
https://ci.chromium.org/p/chrome/g/internal.client.clank/console

Original change's description:
> Rename gl_test to gpu_tests
> 
> This is to make the name reflect that there aren't just OpenGL tests in
> this executable now, there are WebGPU / Dawn tests too.
> 
> Bug: 1017035
> Change-Id: Id685700c01dfe754fc23220c34d49c96f835cc5a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885470
> Reviewed-by: Zhenyao Mo <zmo@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710382}

TBR=zmo@chromium.org,cwallez@chromium.org,jbudorick@chromium.org

Change-Id: I7e1ae7d108568a704f4900261b1f4b318d58b26c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1017035
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887665Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710401}

These are not needed on the client and depend on extra chromium generated
classes. This causes an error when trying to build when using the AAR
with blaze.

Change-Id: I36e081039b05023113cfd4f576ede8c8963042d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887233
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710400}

This bug only occurs on iOS 12. The root cause is that, on iOS 13 we
use the dark mode apis to color things in incognito. This means all
colors can be set once and incognito can be changed afterwards and the
colors will update. For iOS 12, the colors are static, so they must be
set after the incognito status is known.

Bug: 1017138
Change-Id: I8084646b07d2bcbf8b48d91b0d7d341a8fb9bece
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886684Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#710399}

R=ericrk@chromium.org

Bug: 757605
Change-Id: I8ab28e93a6f7457a66e35399d5ab487f3af22178
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885095
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710398}

Since https://crrev.com/701411, restoring a window that was "last active"
and "minimized" when it was closed opens a window that is completely
white. This is because the window is activated but never shown.

This CL ensures that the window that gets activated when restoring a
session is also shown.

Bug: 1018885
Change-Id: I9d01bfb2cafa83df9744bf5c598570ff55252de0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884952Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710397}

This patch adds UMA metric with a final number of print servers to
query.

BUG=chromium:1018591
TEST=none

Change-Id: I19f1608b9b60e869c461c1c8a1ffde59c9446ee7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882811
Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Luum Habtemariam <luum@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710396}

Also fixed test that was exiting early because of no expiration date
instead of getting to the part that crashed.

Bug: 1018744
Change-Id: Id9df8a144f0274e83589bacdb42cb08dc4dbcea1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884650Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710395}

Convert the remaining bits in both the browser process and the video_capture
service for the SharedMemoryVirtualDevice and TextureVirtualDevice mojo
interfaces to the new mojo types.

Bug: 955171
Change-Id: Ifdc0071fd9759bad87582aa744aa2b629f61fdf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883512Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#710394}

Adding hnakashima@ and myself to OWNERS as we've worked with and
reviewed a lot of util code.

Bug: 995916
Change-Id: Ie6a68d4a883ccea46016617a61ae4de791087dae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884518
Auto-Submit: Peter Wen <wnwen@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710393}

Bug: 914501
Change-Id: Iab146b0f40918ca7f91c9927c9922695050c53f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859678Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710392}

Update policy names from DomainsTo* to URLsTo* to better describe their current functionnality.

Bug: 1017153
Change-Id: Iad038ce5a3c5dc5943a9c5094420e957847662ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884659Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710391}

This is a precursor to adding a new scoped_refptr(std::nullptr_t)
constructor. The implicit conversion from NULL to scoped_refptr<T>
causes a compilation error with the new constructor. Replace NULL with
nullptr in any files where this is a problem.

This CL was uploaded by git cl split.

R=sadrul@chromium.org

Bug: 1018887
Change-Id: I76a50bc2619e1a76b8d0901efa1ccc24bf204c3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885014
Auto-Submit: kylechar <kylechar@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710390}

Bug: 995916
Change-Id: I131f26a52f4cbb7e598e56ba356e847456ae8be4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884355Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710389}

Bug: 792504
Change-Id: I05922e5d4eee25da7273bd329cd0c88a729c4a74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878068
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710388}

https://boringssl.googlesource.com/boringssl/+log/76918d016414bf1d71a86d28239566fbcf8aacf0..fe37af11a69c88ae5c63c5eb846552237a4fc8e9

Bug: none
Change-Id: I21392e0adddab21b0afa5ea9b278fe4f39205b08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876761
Auto-Submit: David Benjamin <davidben@chromium.org>
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710387}

https://skia.googlesource.com/skia.git/+log/ee08d523f60a..15b40236bd8b

git log ee08d523f60a..15b40236bd8b --date=short --no-merges --format='%ad %ae %s'
2019-10-29 kjlubick@google.com [canvaskit] Add various ImageFilters
2019-10-29 egdaniel@google.com Some cleanup of unneeded code/objects in GrVkPipelineState.
2019-10-29 bsalomon@google.com Reland "Make GrFillInData use SkRasterPipeline"

Created with:
  gclient setdep -r src/third_party/skia@15b40236bd8b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@google.com

Bug: None
Change-Id: Ia1eda585e3071cdedeb9d30d4372ef4f230f275c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887491Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710386}

Bug: 1017685, 1016367
Change-Id: I355cc71be2fcacd3f2a08124d2ba7ba1af5c61ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886336Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710385}

In case no window is provided

Bug: 1017659
Change-Id: I8184f0c86a6e31711b09e53867d8f015e308117d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883650
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710384}

It was added several years ago but hasn't been used after its first use.
Remove to simplify code.

Change-Id: I9d7a18758b720ebad90624353da83659e68f0112
Bug: 1014162
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881983
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710383}

This is to make the name reflect that there aren't just OpenGL tests in
this executable now, there are WebGPU / Dawn tests too.

Bug: 1017035
Change-Id: Id685700c01dfe754fc23220c34d49c96f835cc5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885470Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710382}

In r686771, we converted a base::Callback used by printing::PrintManager
for Android printing to a base::OnceCallback. This was incorrect, as
the PrintManager's lifetime is tied to the tab's lifetime. Now printing
for a given PrintManager works the first time, but never again after the
OnceCallback has been called. The callback needs to remain valid for the
duration of the PrintManager's lifetime, so make it a RepeatingCallback.

TBR=vkuzkokov@chromium.org

Bug: 1018377
Change-Id: I367ea2e1850ee67a30ef024da2b93d4cef701f62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885001
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710381}

https://chromium.googlesource.com/angle/angle.git/+log/dc883a948e71..287b0a670fbf

git log dc883a948e71..287b0a670fbf --date=short --no-merges --format='%ad %ae %s'
2019-10-29 timvp@google.com Vulkan: Enable forceOldRewriteStructSamplers for all Android ICDs

Created with:
  gclient setdep -r src/third_party/angle@287b0a670fbf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@google.com

Bug: None
Change-Id: I02df77e279f19891fcef0ccfee2b6710e2bd8cbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887492Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710380}

This rolls chromite to crrev.com/c/1863321. That picks up a change to how
artifacts in the Simple Chrome SDK cache are stored. Since we add some of
those artifacts to a test target's data deps, we also need to tweak them
a little to conform to the new cache layout.

Bug: 1012981
Change-Id: I5510be69ec38de31b6cedec2b45a182b91275589
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884279Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710379}

After crrev.com/c/1866513, sync_startup_tracker_ was never actually set.
Removing it also lets us remove some more dead code.

Bug: 1015805
Change-Id: I4fb4d6b696ba3241d66ca6fd16cfd6d5abfc68e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886892Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710378}

There may be a one-pixel gap between the gradient zone and the arrow
button (not always). It is caused by the rounding error during painting.
The easiest way to fix this is to enlarge the gradient zone by one
pixel. It does not introduce other visual side effects.

Bug: 1018965
Change-Id: Ifceb1310adee0e907ec3fc1ed7e88ea50af2b7fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885092
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710377}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=cmasso@chromium.org

Change-Id: I13101a52bff081033dde355763396152208d0a30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887833Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710376}