- 11 Feb, 2020 40 commits
-
-
Karan Bhatia authored
Currently, in each AhoCorasickNode we store the ids of all patterns which are a suffix of the current node. Change this to store an output link at each node. The output link would point to the longest proper suffix of the current node which is also a leaf node (represents a patterns). This should improve the memory usage from SubstringSetMatcher. Additionally, disallow duplicate patterns as inputs. This should have no behavior change since all SubstringSetMatcher clients already don't provide duplicate strings as inputs. Also, add some comments regarding the complexity of various operations. This CL should have no behavior change. It reduces the memory consumption in the corresponding SubstringSetMatcher perftest on my machine from ~55 Mb to ~50 Mb. BUG=974391 Change-Id: Ib7923842b2963187346d8902ba1244ca906a0443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042327 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#740179}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I549df10109b220e1c3c6a92353ffdec5c6ec3452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049305Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740178}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f83d0346c06a..88c3793a4eaa git log f83d0346c06a..88c3793a4eaa --date=short --first-parent --format='%ad %ae %s' 2020-02-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@88c3793a4eaa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: stani@google.com Change-Id: Iec68ea92c3625690bc35675183a1905a48c1ba6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048928Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740177}
-
Xianzhu Wang authored
This reverts commit ef2cc102. Reason for revert: The failing tests just need rebaselines. Original change's description: > Reland "Fix 0,0-0x0 turning into PaintOp::kUnsetRect." > > This reverts commit 0fde9a92. > > Reason for revert: Test breakage in > * virtual/scalefactor200withzoom/fast/hidpi/static/validation-bubble-appearance-hidpi.html > * virtual/scalefactor150/fast/hidpi/static/validation-bubble-appearance-hidpi.html > > at https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29 > > Original change's description: > > Revert "Fix 0,0-0x0 turning into PaintOp::kUnsetRect." > > > > This reverts commit 0156c949. > > > > Reason for revert: series of review fixes resulted in a no-op code. The completely different approach should be used to fix the bug correctly. > > > > Original change's description: > > > Fix 0,0-0x0 turning into PaintOp::kUnsetRect. > > > > > > When a paint chunk having 0,0-0x0 rect is processed inside an effect, an early > > > return prevents the effect_bounds_stack_.back() update in a > > > ConversionContext::UpdateEffectBounds call. This results in keeping default > > > PaintOp::kUnsetRect in SaveLayerOp::bounds instead of 0,0-0x0 rect. > > > > > > This is probably a reason for a related bug 918240 (see bug thread Comment 4 for > > > details). Application of this patch fixes the lagging print preview. > > > > > > R=fmalita@chromium.org, samans@chromium.org > > > > > > Bug: 918240 > > > Change-Id: I022ae01418e83184421cff7e22566228a2f7c6d3 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1396958 > > > Commit-Queue: Denis Bessonov <dbessonov@yandex-team.ru> > > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#714293} > > > > Bug: 918240 > > Change-Id: I89a55d39a53559b37168b91adf3f331dbbf8b106 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007409 > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Auto-Submit: Denis Bessonov <dbessonov@yandex-team.ru> > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#733491} > > TBR=wangxianzhu@chromium.org,pdr@chromium.org,dbessonov@yandex-team.ru > > Change-Id: If99b75af33c3a00f64eec91b4c711879f3665ce0 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 918240 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011843 > Reviewed-by: Thiemo Nagel <tnagel@chromium.org> > Commit-Queue: Thiemo Nagel <tnagel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733558} TBR=wangxianzhu@chromium.org,pdr@chromium.org,tnagel@chromium.org,dbessonov@yandex-team.ru # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 918240 Change-Id: I886c70eec38907fd51c0f3a00ba50ba7c3acdfe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047766Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#740176}
-
Ian Kilpatrick authored
TBR=dgrogan@chromium.org Bug: 762679, 1050316 Change-Id: Iac2e5e32fa9dfe730676adf2818e869364d6b2b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049127Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#740175}
-
David Tseng authored
TBR=dtseng@chromium.org Bug: 1026473 Change-Id: I9bf41eeaf3e69f762a4e15cf9ef99f04f508f9fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049304Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#740174}
-
David Tseng authored
Change-Id: If174973efea6cac89917b57ee6df27a6e81dd345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044146 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#740173}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/64c5af3a715f..4fad85878aa6 git log 64c5af3a715f..4fad85878aa6 --date=short --first-parent --format='%ad %ae %s' 2020-02-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@4fad85878aa6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I4744637036a7bef041ffa4f4018bfa478a824097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048927Reviewed-by:
-
Xiao Yang authored
Bug: b/149057484 Change-Id: I65a5c3a7050bbf977559c98d7f652f2bfec1d043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042147 Commit-Queue: Xiao Yang <yanxiao@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#740171}
-
Henrique Nakashima authored
This code does not belong in CachedFeatureFlags, which deals with feature flags. Bug: 1012975 Change-Id: I91fb933219c294a31350e9a62cc5c3b27c8ed89a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042109 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#740170}
-
Tommy Steimel authored
This CL moves the Kaleidoscope feature into the media switches in the public repo. Bug: 1044741 Change-Id: I6afd24d3398be9439a77f8df28b348153926134a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048042Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#740169}
-
chrome://media-appZain Afzal authored
This CL defines a mojom file for the mojo interface between the Browser and the chrome://media-app page and implements the relevant CPP (Page Handler) and JS (mojo_api_bootstrap.js) interfaces. This interface is leveraged to expose the native browser open feedback dialog functionality to the page via a MediaAppUIDelegate. This Cl also adds the kFeedbackSourceMediaApp constant to the chrome::FeedbackSource enum to allow feedback dialogs opened by the media app to be correctly logged. Bug: 996088,1045222 Change-Id: Ia6f28c2330cfb592f9440778b94ebf45da89dbc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015874 Commit-Queue: Zain Afzal <zafzal@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#740168}
-
Brian Sheedy authored
Updates several VR goldens that changed slightly on O due to an AA difference. TBR=alcooper@chromium.org Change-Id: I95317237698d516eda4fc69855168f60fe8d2d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049283Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#740167}
-
Isabella Scalzi authored
Bug: 803259 Change-Id: Idff2d428b298e8953e3e5712851195590e151cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049148 Commit-Queue: Isabella Scalzi <isabellascalzi@google.com> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#740166}
-
Zhenyao Mo authored
We disabled dynamic textures for a few integrated GPUs, but it turns out for discrete GPUs we also need to disable them. Otherwise videos fail to display when HW overlays are enabled. This has been confirmed locally by xose@google and also AMD that it is the right fix for the issue. BUG=1050666 TEST=manual R=sunnyps@chromium.org Change-Id: I03fd2bd78db2eb5cebb9fa7465aec1f217fd0172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049026 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#740165}
-
Harry Cutts authored
This is a reland of 3b95e462 Original change's description: > libgestures_glue: send wheel resolution flag to gestures library > > If the wheel is high resolution, the gestures library can use that to > provide more accurate (and, in the future, responsive) scrolling. See > https://crrev.com/c/2037035 for the gestures library implementation. > > TEST=With https://crrev.com/c/2037035 patched, connect a suitable mouse > (such as a Logitech Anywhere MX) and enable the "Mouse High > Resolution Scrolling" gesture property. Check that moving the wheel > by fractions of a notch scrolls the page slightly. > BUG=chromium:888172 > > Change-Id: I6e2b0484e5a5b5aa3422a6bb7a4c5fe2dc3ef61e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037055 > Reviewed-by: Michael Spang <spang@chromium.org> > Commit-Queue: Harry Cutts <hcutts@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739537} Bug: chromium:888172 Change-Id: I10318774164d9bec0893aa1a207f951d3d511158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049123Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Harry Cutts <hcutts@chromium.org> Cr-Commit-Position: refs/heads/master@{#740164}
-
Karan Bhatia authored
The existing perf test ends up generating only 32 distinct string patterns. Correct this by using a random string generation strategy. BUG=974391 Change-Id: I1d3dd54a46255c7e78dfc90006a83cd2ddf7eb8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045046 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Yulun Wu authored
Bug: 1049290 Change-Id: I03ebd008362b5829f4df4f9efc822f33070b8450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043080 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#740162}
-
matterchen authored
This CL covers the tracking of port forwarding settings in the user's profile preferences. The port rule settings are all contained in a flat list where each rule is a dictionary object like so: { port_number: 5000, protocol_type: 0, (TCP) input_ifname: "all", label: "some-label", active: true, container_name: "penguin", vm_name: "termina", } The preferences are only modified by add / remove operations currently and activate / deactivate will come in a later CL. Involves changes in the completion of callbacks as well as lots of new unit tests. Additionally, the new profile preference is registered in crostini_pref_names*. Bug: 848127 Test: crostini_port_forward_unittest.cc (+ASAN) Change-Id: I65df2f5a9297fc45051adc8c219ede1318861eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037300Reviewed-by:Fergus Dall <sidereal@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
David Munro <davidmunro@google.com> Commit-Queue: Matthew Chen <matterchen@google.com> Cr-Commit-Position: refs/heads/master@{#740161}
-
Avery Musbach authored
If you enter clamshell split view by long pressing the overview button tray (in tablet position with an external pointing device), the wallpaper shall be blurred/darkened consistent with the usual appearance of clamshell overview. Test: manual Bug: 1045990 Change-Id: I034ca4a4d5122b045d549e87312184a6e076b365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048983 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#740160}
-
Glen Robertson authored
Bug: 1046866 Change-Id: I612e26f1bcd32354948058a47de2b92f87263f2b Fixed: 1046866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049403 Commit-Queue: Glen Robertson <glenrob@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#740159}
-
nancy authored
BUG=1016159 Change-Id: I764118763c7471cd31b43c14a490a2e1d89b544d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045690 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
nancy authored
AppServiceAppItem is used to load the item for app list. arc_app_item is not used, so it can be removed. BUG=1016159 Change-Id: I353fbb37486d79fd5078efb468e6a445a595c266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047203 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
Donn Denman authored
This reverts commit 928037da. Reason for revert: Speculative fix for a mysterious crash in Contextual Search when animating the Overlay. Issue 1050431. BUG=1050431 Original change's description: > Android: Remove OverlayPanel-based Preview Tab code > > Now that Preview Tab is working on top of ThinWebView and BottomSheet, > this CL deletes the old implementation that based it on OverlayPanel. > > Bug: 1043677 > Change-Id: Icccc93cca3f09e9ae122b1e0dcb7537331136ac0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032466 > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Donn Denman <donnd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739094} TBR=dtrainor@chromium.org,donnd@chromium.org,yusufo@chromium.org,jinsukkim@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1043677 Change-Id: I7c9fa71c3aba77e3e1c8938db8f1b9f7f28a2b22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049206Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#740156}
-
Hitoshi Yoshida authored
If a dictionary has no own members, some of its functions defines variables unused. This CL fixes it. Bug: 839389 Change-Id: Ie0b8c515e8e09bc900879ff4563d51abe20331f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046425 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#740155}
-
Sadrul Habib Chowdhury authored
Do not report throughput metrics for threads/interactions that do not make sense (e.g. main-thread throughput for compositor-driven animations etc.). BUG=1048154 Change-Id: I8d86edd428b282aff4d3664f45b538e700b5f1c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037614 Commit-Queue: Xida Chen <xidachen@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#740154}
-
Jun Mukai authored
I've noticed that on a rare occasion, the window is in the ARC_APP type but it does not have the package name yet. If getAppWindowList is invoked at this state, it will end up with crash for nullptr dereference. Bug: 1050245 Test: checking with tast Change-Id: I9ce1aea051dec26c9f1924e9169bae55f2b0af9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044529 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Ricardo Quesada <ricardoq@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#740153}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fc1e8503d88b..b40d48a67c93 git log fc1e8503d88b..b40d48a67c93 --date=short --first-parent --format='%ad %ae %s' 2020-02-10 jmadill@chromium.org Vulkan: Remove ensure init from updateActiveImages. 2020-02-10 jmadill@chromium.org Vulkan: Fix EGLBlobCacheTest. 2020-02-10 jmadill@chromium.org Vulkan: Command graph linearization (Step 4). 2020-02-10 jmadill@chromium.org Speed up InstancingTest.LineLoop. 2020-02-10 jmadill@chromium.org Vulkan: Defer RenderPass image barriers. 2020-02-10 jmadill@chromium.org Suppress two failing NVIDIA D3D11 tests. 2020-02-10 cnorthrop@google.com Capture/Replay: Avoid null pointer dereference in MEC Created with: gclient setdep -r src/third_party/angle@b40d48a67c93 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I7a389d8f9e64b9e6d727163e3a0ec9bab4f2c29c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047978Reviewed-by:
-
Aaron Krajeski authored
What they really are are getters for the cc::PaintCanvas, rename them as such. GetOrCreatePaintCanvas (the old DrawingCanvas) has side-effects and should not be labelled as const. An attempt has been made to replace GetOrCreatePaintCanvas with just GetPaintCanvas whenever possible. I'd also be willing to rename cc::PaintCanvas* c as cc::PaintCanvas* paint_canvas, but that would make this CL huge. Bug: 1046091 Change-Id: I8d4a2af238e141774fb856470f72f1580cbb976a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023927 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#740151}
-
Eugene But authored
Notable changes: - Generate source code with not_user_triggered User Actions array - Use binary search to filter out the action is a part of that array This creates a mechanism to remove noisy actions, which are not useful for finding steps to repro in Breadscrumbs. Bug: 1046231 Change-Id: I74e8d5f28f67c56ae49322fa4cba448142881abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034066 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#740150}
-
Daniel Cheng authored
Blink allows use of the //base histogram helpers, so switch away from the Blink-specific histogram helpers and standardize on //base. The long-term goal is to remove the Blink helpers, which differ from the //base ones in some interesting and surprising ways. Miscellaneous cleanup: - use the histogram functions where appropriate (i.e. for metrics that aren't recorded on performance-critical paths) - simplify enum histogram recording by changing the enum metric to be an enum class and defining kMaxValue where needed. - remove the expired Parser.DiscardedTokenCount metric Bug: 742517, 1047547 Fixed: 871484 Change-Id: Ifeb80bb4fef6463ffa7ebfb47018a59e963c875c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040027Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#740149}
-
Nasko Oskov authored
Adding traces to cases where FilterURL rewrites the URL due to security checks failing. This allows us to understand better what is happening while looking at a navigation trace. Bug: None Change-Id: I50d5980d3bf84bc1b962a85f7183c9d68011a598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044542Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#740148}
-
Alison Maher authored
Legends were getting painted atomically via NGFieldsetPainter::PaintLegend(). This is not according to the spec: https://html.spec.whatwg.org/#the-fieldset-and-legend-elements. Removing the atomic painting of legends also fixes crashing issues in which floating children of legends were getting painted twice. This change adds several test failures to the TestExpectations file. These failures, however, are temporary and will be fixed in a soon-to-follow CL: https://chromium-review.googlesource.com/c/chromium/src/+/2042146 Bug: 875235 Change-Id: I2b9dbc438ba241bcf72eca316ec65aa2f1edc635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045194 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#740147}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ea794b87a8c5..df7f6a4d2256 git log ea794b87a8c5..df7f6a4d2256 --date=short --first-parent --format='%ad %ae %s' 2020-02-10 sadrul@chromium.org windows: Allow taking screenshots. Created with: gclient setdep -r src/third_party/catapult@df7f6a4d2256 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:369490 Tbr: nuskos@google.com Change-Id: I289c0bf586e04a2d6b3729496235b9d538437498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048684Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4aa8a8e1eb69..8ebf72467db7 Created with: gclient setdep -r src-internal@8ebf72467db7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1041701 Tbr: jbudorick@google.com Change-Id: I320c751ab60df516219036a5032656e5d133f9a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048923Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#740145}
-
Caleb Rouleau authored
Bug: 1047125 Change-Id: I2d74d17321611e3f1e810e891652578d098d2d49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048505 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
-
Sean Topping authored
CastWebView forces too much indirection from the underlying page/window functionality, so some forwarding methods have been removed in favor of calling the members directly. This is presently not ideal, but will be a great improvement once the CastWebContents and CastContentWindow are surfaced as mojo interfaces via CastWebService and their lifetimes can be tracked independently. The CastWebService API has been simplified so that clients no longer need to provide a SiteInstance when creating CastWebViews. The renderer preloading logic, which was previously disjoint from CastWebView, has now been incorporated. Merge-With: eureka-internal/331288 Bug: internal 77879457 Test: CQ, manually verify on display assistant device. Change-Id: I72fc57f0669783f61076626962d47b72d93463f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968257Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#740143}
-
Dale Curtis authored
Destruction is no longer synchronous so it's not possible for this comment to be true. TBR=sandersd Fixed: 1047661 Change-Id: I275b85b238da5a7c539d2654fa26f06fcc167b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048823Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#740142}
-
Sean Kau authored
5.0 contains the fix for monochrome printing when combined with updated PPDs. PPDs will be launched when this change makes it to stable. Bug: 916227 Change-Id: Ia26b809bdcd4f20ca4f8457e0b0ad7a90378da79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042229 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#740141}
-
Lijin Shen authored
Remove hard-coded Color.WHITE. Bug: 1046067 Change-Id: Iac390557de5e1700234205f72c9e0616ebdb241e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048410 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#740140}
-
