GitLab

BUG=435757, 455391
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Review URL: https://codereview.chromium.org/1142453002

Cr-Commit-Position: refs/heads/master@{#329862}

Currently, various methods related to marking proxies as bad in the ProxyList
and ProxyService classes take a single ProxyServer for optionally marking an
additional proxy as bad (i.e. ProxyList::UpdateRetryInfoOnFallback and
ProxyService::MarkProxiesAsBadUntil). This is linked to fundamental assumptions
in the Data Reduction Proxy that only two proxy servers are being used.

As part of moving to a dynamic configuration, it is possible that more than 2
proxy servers could be used for the Data Reduction Proxy, so using a vector
of ProxyServer objects makes more sense in the interface.

BUG=470587

Review URL: https://codereview.chromium.org/1128823005

Cr-Commit-Position: refs/heads/master@{#329861}

-0 is treated as double 0.0f in V8. This makes GetAsInteger()
return -0 is not an integer type. Extension APIs with integer parameters
will fail to get the value using GetAsInteger(). This CL convert integer
-0 to integer 0.

BUG=471011

Review URL: https://codereview.chromium.org/1126983009

Cr-Commit-Position: refs/heads/master@{#329860}

Created an ETC1 encoder that uses SSE2 to improve compression speed.
The SSE encoder extends TextureCompressor and uses the same algorithm as TextureCompressorETC1.

Added unittest for TextureCompressorETC1.

Moved shared code into a etc1 header.

Added new performance test scenarios.

Reland necessary for 32-bit GN issues.

Performance difference on Ubuntu x64, Haswell Processor:
Without SSE:
*RESULT Compress256x256BlackAndWhiteGradientImage: ETC1 Low= 1.966321587562561 us
*RESULT Compress256x256SolidBlackImage: ETC1 Low= .0956009104847908 us
*RESULT Compress256x256SolidColorImage: ETC1 Low= .4367307722568512 us
*RESULT Compress256x256RandomColorImage: ETC1 Low= 5.948055744171143 us

With SSE:
*RESULT Compress256x256BlackAndWhiteGradientImage: ETC1 Low= 1.0316201448440552 us
*RESULT Compress256x256SolidBlackImage: ETC1 Low= .25716209411621094 us
*RESULT Compress256x256SolidColorImage: ETC1 Low= .2768038809299469 us
*RESULT Compress256x256RandomColorImage: ETC1 Low= 1.834145426750183 us

BUG=434699
TEST=newly added unittest TextureCompressorETC1Test::Compress256x256CreateETC1, TextureCompressorETC1Test::Compress256x256RatioETC1

Committed: https://crrev.com/5f3849aa8307399b7e6dfe5665ed149594244077
Cr-Commit-Position: refs/heads/master@{#329840}

Review URL: https://codereview.chromium.org/1096703002

Cr-Commit-Position: refs/heads/master@{#329859}

This is only done for main frame loads (so that it matches the behavior
of Net.ErrorCodesForMainFrame3), and is done for the dominant errors
seen in the wild.  It also includes successful loads (for comparison) and all
non-dominant errors in a final bucket (for completeness).

BUG= 487663
R=mmenke@chromium.org
R=jkarlin@chromium.org

Review URL: https://codereview.chromium.org/1127383009

Cr-Commit-Position: refs/heads/master@{#329858}

BUG=487749

Review URL: https://codereview.chromium.org/1134353003

Cr-Commit-Position: refs/heads/master@{#329857}

A number of browser and unit tests use mocks of the UsbService,
UsbDevice and UsbDeviceHandle classes. This change de-duplicates them.

Review URL: https://codereview.chromium.org/1144493003

Cr-Commit-Position: refs/heads/master@{#329856}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9299220..6505e22

TBR=jsbell@chromium.org

Review URL: https://codereview.chromium.org/1132453004

Cr-Commit-Position: refs/heads/master@{#329855}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/eea2ff7..7ae68a8

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/1145483002

Cr-Commit-Position: refs/heads/master@{#329854}

The sequence leading to the crash is:
. Enable sorting.
. Have more than one selected row.
. Remove one of the selected rows. The removed row must also contain
  the anchor.
. Focus the table.

The crash happened because we tried to get the view index for -1.

In general the anchor shouldn't be -1 if there is at least one item in
the selection. The only place anchor could be -1 and there is a
selection is during removal. This patch fixes that.

BUG=480296
TEST=covered by test now.
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/1129233006

Cr-Commit-Position: refs/heads/master@{#329853}

In order to enable renderer processes to create SurfaceSequences, they
have to receive Surface ID namespaces from the browser process so that
they can avoid collisions.

BUG=478802

Committed: https://crrev.com/c7a5afd66499fc8442e1b3146f55b227638934d8
Cr-Commit-Position: refs/heads/master@{#329708}

Review URL: https://codereview.chromium.org/1129883003

Cr-Commit-Position: refs/heads/master@{#329852}

PushMessagingAppIdentifier currently generates app_id strings of the form:
"wp:9CC55CCE-B8F9-4092-A364-3B0F73A3AB5F".

This patch changes it to generate app_id strings of the form:
"wp:https://foo.example.com:8443/#9CC55CCE-B8F9-4092-A364-3B0F73A3AB5F"

BUG=458592,461867

Review URL: https://codereview.chromium.org/1141613003

Cr-Commit-Position: refs/heads/master@{#329851}

Build rule is not hooked up to any targets yet, but will be used in a
future commit to create split APKs.

.gypi also forthcoming.

BUG=447152

Review URL: https://codereview.chromium.org/1118403004

Cr-Commit-Position: refs/heads/master@{#329850}

Revert of Ensure the new navigation classifier works in the real world. (patchset #1 id:1 of https://codereview.chromium.org/1136663004/)

Reason for revert:
Occasional crashes.

Original issue's description:
> Ensure the new navigation classifier works in the real world.
>
> BUG=369661
> TEST=No whammies!
>
> Committed: https://crrev.com/f97970c11c08a18e9ecea0b1b4c77122371a0e4f
> Cr-Commit-Position: refs/heads/master@{#329497}

TBR=creis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=369661

Review URL: https://codereview.chromium.org/1140123002

Cr-Commit-Position: refs/heads/master@{#329849}

This is the experimental IDBObjectStore.getAll implementation for
retrieving multiple values in a single request as proposed in
https://www.w3.org/2008/webapps/wiki/IndexedDatabaseFeatures

In order to use run Chrome with: --enable-experimental-web-platform-features

BUG=457450

Review URL: https://codereview.chromium.org/1074493002

Cr-Commit-Position: refs/heads/master@{#329848}

BUG=487997
TBR=samuong@chromium.org

Review URL: https://codereview.chromium.org/1137583003

Cr-Commit-Position: refs/heads/master@{#329847}

This patch was mostly autogenerated with https://codereview.chromium.org/1010073002/.

BUG=465354

Committed: https://crrev.com/adc9b4ed3d797c2990d682a3784d2e892198ce00
Cr-Commit-Position: refs/heads/master@{#329696}

Review URL: https://codereview.chromium.org/1134113002

Cr-Commit-Position: refs/heads/master@{#329846}

Revert of Add ETC1 powered SSE encoder for tile texture compression (patchset #23 id:440001 of https://codereview.chromium.org/1096703002/)

Reason for revert:
Speculative revert. Looks like this change breaks compilation on win8 GN:
http://build.chromium.org/p/chromium.win/builders/Win8%20GN

Failure Example:
http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/7283

Original issue's description:
> Add ETC1 powered SSE encoder for tile texture compression
>
> Created an ETC1 encoder that uses SSE2 to improve compression speed.
> The SSE encoder extends TextureCompressor and uses the same algorithm as TextureCompressorETC1.
>
> Added unittest for TextureCompressorETC1.
>
> Moved shared code into a etc1 header.
>
> Added new performance test scenarios.
>
> Performance difference on Ubuntu x64, Haswell Processor:
> Without SSE:
> *RESULT Compress256x256BlackAndWhiteGradientImage: ETC1 Low= 1.966321587562561 us
> *RESULT Compress256x256SolidBlackImage: ETC1 Low= .0956009104847908 us
> *RESULT Compress256x256SolidColorImage: ETC1 Low= .4367307722568512 us
> *RESULT Compress256x256RandomColorImage: ETC1 Low= 5.948055744171143 us
>
> With SSE:
> *RESULT Compress256x256BlackAndWhiteGradientImage: ETC1 Low= 1.0316201448440552 us
> *RESULT Compress256x256SolidBlackImage: ETC1 Low= .25716209411621094 us
> *RESULT Compress256x256SolidColorImage: ETC1 Low= .2768038809299469 us
> *RESULT Compress256x256RandomColorImage: ETC1 Low= 1.834145426750183 us
>
> BUG=434699
> TEST=newly added unittest TextureCompressorETC1Test::Compress256x256CreateETC1, TextureCompressorETC1Test::Compress256x256RatioETC1
>
> Committed: https://crrev.com/5f3849aa8307399b7e6dfe5665ed149594244077
> Cr-Commit-Position: refs/heads/master@{#329840}

TBR=reveman@chromium.org,christiank@opera.com,jie.a.chen@intel.com,robert.bradford@intel.com,radu.velea@intel.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=434699

Review URL: https://codereview.chromium.org/1136083003

Cr-Commit-Position: refs/heads/master@{#329845}

There's a TODO for using split-select, but it won't be necessary until
we have resource splits being generated.

BUG=447152

Review URL: https://codereview.chromium.org/1134353002

Cr-Commit-Position: refs/heads/master@{#329844}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/c30806f..eea2ff7

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/1136393004

Cr-Commit-Position: refs/heads/master@{#329843}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/33861c9..9299220

TBR=jsbell@chromium.org

Review URL: https://codereview.chromium.org/1141823002

Cr-Commit-Position: refs/heads/master@{#329842}

see https://codereview.chromium.org/1140943004/

BUG=
NOTRY=True
just adds a new flag for future cls

Review URL: https://codereview.chromium.org/1133403003

Cr-Commit-Position: refs/heads/master@{#329841}

Created an ETC1 encoder that uses SSE2 to improve compression speed.
The SSE encoder extends TextureCompressor and uses the same algorithm as TextureCompressorETC1.

Added unittest for TextureCompressorETC1.

Moved shared code into a etc1 header.

Added new performance test scenarios.

Performance difference on Ubuntu x64, Haswell Processor:
Without SSE:
*RESULT Compress256x256BlackAndWhiteGradientImage: ETC1 Low= 1.966321587562561 us
*RESULT Compress256x256SolidBlackImage: ETC1 Low= .0956009104847908 us
*RESULT Compress256x256SolidColorImage: ETC1 Low= .4367307722568512 us
*RESULT Compress256x256RandomColorImage: ETC1 Low= 5.948055744171143 us

With SSE:
*RESULT Compress256x256BlackAndWhiteGradientImage: ETC1 Low= 1.0316201448440552 us
*RESULT Compress256x256SolidBlackImage: ETC1 Low= .25716209411621094 us
*RESULT Compress256x256SolidColorImage: ETC1 Low= .2768038809299469 us
*RESULT Compress256x256RandomColorImage: ETC1 Low= 1.834145426750183 us

BUG=434699
TEST=newly added unittest TextureCompressorETC1Test::Compress256x256CreateETC1, TextureCompressorETC1Test::Compress256x256RatioETC1

Review URL: https://codereview.chromium.org/1096703002

Cr-Commit-Position: refs/heads/master@{#329840}

WebRTC 9187:9189
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/65d8695..872cf25

TBR=sergeyu@chromium.org

Review URL: https://codereview.chromium.org/1136483003

Cr-Commit-Position: refs/heads/master@{#329839}

Calculates per-frame encode latency, which is basically the time delay from
input of each VideoFrame (VEA::Encode()) to output of the corresponding
BitstreamBuffer (VEA::Client::BitstreamBufferReady()).

It calculates encode latency values at the 50th(median), 75th, and 95th percentiles.

Also fix a wrong comment.

BUG=345181
TEST=Check "Encode latency for the 50%/75%/95%" in output logs.

Committed: https://crrev.com/b21ffeee2aff4da8edb9808b2227165c37e5ce86
Cr-Commit-Position: refs/heads/master@{#329819}

Review URL: https://codereview.chromium.org/1117853002

Cr-Commit-Position: refs/heads/master@{#329838}

The current version does not handle messages larger than a single characteristic size (around 150 bytes). Message receiving functionality is not implemented yet.

BUG=485123

Review URL: https://codereview.chromium.org/1116963002

Cr-Commit-Position: refs/heads/master@{#329837}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/dabd83a..33861c9

TBR=jsbell@chromium.org

Review URL: https://codereview.chromium.org/1142483002

Cr-Commit-Position: refs/heads/master@{#329836}

BUG=487989

Review URL: https://codereview.chromium.org/1135073003

Cr-Commit-Position: refs/heads/master@{#329835}

Revert of Revert of Use |IsOriginSecure| for mark-HTTP-nonsecure field trial (patchset #1 id:1 of https://codereview.chromium.org/1130843005/)

Reason for revert:
The initial patch was relanded: https://codereview.chromium.org/1124383007/

Original issue's description:
> Revert of Use |IsOriginSecure| for mark-HTTP-nonsecure field trial (patchset #1 id:1 of https://codereview.chromium.org/1143503003/)
>
> Reason for revert:
> Android Tests dbg bot is failing:
> http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20(dbg)
>
> The reason of this failure is following patch: https://codereview.chromium.org/1123943002/
>
> I had to revert this patch because it is a follow up.
>
> Original issue's description:
> > Use |IsOriginSecure| for mark-HTTP-nonsecure field trial
> >
> > When the flag or field trial is set such that non-secure origins will be
> > marked as dubious/non-secure, use |IsOriginSecure| to determine whether
> > an origin is non-secure, instead of simply treating http:// and ftp://
> > as non-secure. This means that http://nytimes.com will be marked as
> > dubious/non-secure, but not http://localhost (for example).
> >
> > BUG=487499
> > TEST=Enable the "Mark non-secure as non-secure" flag in
> > chrome://flags. Visit http://nytimes.com and observe that the lock icon
> > is red and crossed out. Visit an http:// URL on localhost and observe
> > that the lock icon is neutral.
> >
> > Committed: https://crrev.com/5f99677ac4f9b8180ee7fd2f0d5c85e91828a951
> > Cr-Commit-Position: refs/heads/master@{#329774}
>
> TBR=meacer@chromium.org,estark@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=487499
>
> Committed: https://crrev.com/236d015aa9bf3f61ece3e32c8af40fc1b9153727
> Cr-Commit-Position: refs/heads/master@{#329826}

TBR=meacer@chromium.org,estark@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=487499

Review URL: https://codereview.chromium.org/1144513003

Cr-Commit-Position: refs/heads/master@{#329834}

- Skip button aligned to Next button.
- Added Optional to step message.

BUG=487353

Review URL: https://codereview.chromium.org/1131073004

Cr-Commit-Position: refs/heads/master@{#329833}

Revert of Revert of Move SecurityLevel into a class of its own (patchset #1 id:1 of https://codereview.chromium.org/1135373003/)

Reason for revert:
Reland initial patch. There is a fix for SecurityLevelTest:

https://codereview.chromium.org/1135073003

Original issue's description:
> Revert of Move SecurityLevel into a class of its own (patchset #19 id:420001 of https://codereview.chromium.org/1123943002/)
>
> Reason for revert:
> Android Tests dbg bot is failing:
> http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20(dbg)
>
> Failure example: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/27901
>
> Original issue's description:
> > Move SecurityLevel into a class of its own
> >
> > This CL moves |GetSecurityLevelForWebContents| and the |SecurityLevel|
> > enum into a class of their own: |ConnectionSecurityHelper| in
> > //chrome/browser/ssl (since it is applying Chrome-specific security
> > policy to determine the security level of a page).
> >
> > Later, we will use the new |ConnectionSecurityHelper| class to compute a
> > security level for a page to send to the DevTools Security
> > panel. Specifically, we need to be able to calculate the security level
> > for a given page, not just the WebContents for the active tab.
> >
> > BUG=484392
> >
> > Committed: https://crrev.com/ca7c0a3374c21ab10c821f4f3a890afc79182acf
> > Cr-Commit-Position: refs/heads/master@{#329591}
> >
> > Committed: https://crrev.com/f50c9b4834e151aa6b5538545a503614cb74f5f9
> > Cr-Commit-Position: refs/heads/master@{#329724}
>
> TBR=felt@chromium.org,pkasting@chromium.org,rsleevi@chromium.org,bauerb@chromium.org,sky@chromium.org,tedchoc@chromium.org,estark@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=484392
>
> Committed: https://crrev.com/39722bb693112be3d91c729246c0ade351e7e900
> Cr-Commit-Position: refs/heads/master@{#329827}

TBR=felt@chromium.org,pkasting@chromium.org,rsleevi@chromium.org,bauerb@chromium.org,sky@chromium.org,tedchoc@chromium.org,estark@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=484392

Review URL: https://codereview.chromium.org/1124383007

Cr-Commit-Position: refs/heads/master@{#329832}

Favicon is resolved as data URL to avoid discrepancies if favicon depends on environment (e.g. user-agent).

BUG=461581

Review URL: https://codereview.chromium.org/1124023004

Cr-Commit-Position: refs/heads/master@{#329831}

In preparation for reusing touch transformations for transforming on
screen stylus events into display co-ordinates this CL does a simple
refactor of TouchTransformerController.

This change will be followed up by a subsequent CL that enables support
for having multiple touchscreens per display with the per-device looping
happening in the new methods: UpdateTouchRadius() and
UpdateTouchTransform().

TEST=ash_unittests passes, interactive testing on link_freon in mirrored
and non-mirrored mode.
BUG=448467

Review URL: https://codereview.chromium.org/1130983005

Cr-Commit-Position: refs/heads/master@{#329830}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5f528ff..dabd83a

TBR=jsbell@chromium.org

Review URL: https://codereview.chromium.org/1141453004

Cr-Commit-Position: refs/heads/master@{#329829}

BUG=484690
R=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/1138883003

Cr-Commit-Position: refs/heads/master@{#329828}

Revert of Move SecurityLevel into a class of its own (patchset #19 id:420001 of https://codereview.chromium.org/1123943002/)

Reason for revert:
Android Tests dbg bot is failing:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20(dbg)

Failure example: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/27901

Original issue's description:
> Move SecurityLevel into a class of its own
>
> This CL moves |GetSecurityLevelForWebContents| and the |SecurityLevel|
> enum into a class of their own: |ConnectionSecurityHelper| in
> //chrome/browser/ssl (since it is applying Chrome-specific security
> policy to determine the security level of a page).
>
> Later, we will use the new |ConnectionSecurityHelper| class to compute a
> security level for a page to send to the DevTools Security
> panel. Specifically, we need to be able to calculate the security level
> for a given page, not just the WebContents for the active tab.
>
> BUG=484392
>
> Committed: https://crrev.com/ca7c0a3374c21ab10c821f4f3a890afc79182acf
> Cr-Commit-Position: refs/heads/master@{#329591}
>
> Committed: https://crrev.com/f50c9b4834e151aa6b5538545a503614cb74f5f9
> Cr-Commit-Position: refs/heads/master@{#329724}

TBR=felt@chromium.org,pkasting@chromium.org,rsleevi@chromium.org,bauerb@chromium.org,sky@chromium.org,tedchoc@chromium.org,estark@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=484392

Review URL: https://codereview.chromium.org/1135373003

Cr-Commit-Position: refs/heads/master@{#329827}

Revert of Use |IsOriginSecure| for mark-HTTP-nonsecure field trial (patchset #1 id:1 of https://codereview.chromium.org/1143503003/)

Reason for revert:
Android Tests dbg bot is failing:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20(dbg)

The reason of this failure is following patch: https://codereview.chromium.org/1123943002/

I had to revert this patch because it is a follow up.

Original issue's description:
> Use |IsOriginSecure| for mark-HTTP-nonsecure field trial
>
> When the flag or field trial is set such that non-secure origins will be
> marked as dubious/non-secure, use |IsOriginSecure| to determine whether
> an origin is non-secure, instead of simply treating http:// and ftp://
> as non-secure. This means that http://nytimes.com will be marked as
> dubious/non-secure, but not http://localhost (for example).
>
> BUG=487499
> TEST=Enable the "Mark non-secure as non-secure" flag in
> chrome://flags. Visit http://nytimes.com and observe that the lock icon
> is red and crossed out. Visit an http:// URL on localhost and observe
> that the lock icon is neutral.
>
> Committed: https://crrev.com/5f99677ac4f9b8180ee7fd2f0d5c85e91828a951
> Cr-Commit-Position: refs/heads/master@{#329774}

TBR=meacer@chromium.org,estark@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=487499

Review URL: https://codereview.chromium.org/1130843005

Cr-Commit-Position: refs/heads/master@{#329826}

Revert of vea_unittest: Calculate per-frame encode latency (patchset #15 id:280001 of https://codereview.chromium.org/1117853002/)

Reason for revert:
Fail to compile on x86 Chrome OS.

Original issue's description:
> vea_unittest: Calculate per-frame encode latency
>
> Calculates per-frame encode latency, which is basically the time delay from
> input of each VideoFrame (VEA::Encode()) to output of the corresponding
> BitstreamBuffer (VEA::Client::BitstreamBufferReady()).
>
> It calculates encode latency values at the 50th(median), 75th, and 95th percentiles.
>
> Also fix a wrong comment.
>
> BUG=345181
> TEST=Check "Encode latency for the 50%/75%/95%" in output logs.
>
> Committed: https://crrev.com/b21ffeee2aff4da8edb9808b2227165c37e5ce86
> Cr-Commit-Position: refs/heads/master@{#329819}

TBR=owenlin@chromium.org,posciak@chromium.org,wuchengli@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=345181

Review URL: https://codereview.chromium.org/1137643003

Cr-Commit-Position: refs/heads/master@{#329825}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/62b675e..5f528ff

TBR=jsbell@chromium.org

Review URL: https://codereview.chromium.org/1138503004

Cr-Commit-Position: refs/heads/master@{#329824}

BUG=478250
R=mkwst@chromium.org

Review URL: https://codereview.chromium.org/1145463002

Cr-Commit-Position: refs/heads/master@{#329823}