GitLab

BUG=442555

Review URL: https://codereview.chromium.org/1297433004

git-svn-id: svn://svn.chromium.org/blink/trunk@200824 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces enum class |TextAffinity| as replacement of enum
|EAffinity| and rename |DOWNSTREAM| and |UPSTREAM| members to capitalized name
|Downstream| and |Upstream| to follow Blink coding style for improving code
health.

BUG=522038
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1293593004

git-svn-id: svn://svn.chromium.org/blink/trunk@200823 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |nodeIsUserSelectNone()| out from |PositionAlgorithm| template
class to "EditingUtilities.{cpp,h}" to simplify |PositionAlgorithm| class for
improving code health, since |nodeIsUserSelectNone()| doesn't depend on
|Strategy| template parameter.

BUG=518738
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1301933002

git-svn-id: svn://svn.chromium.org/blink/trunk@200822 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also make it impossible to access WorkerThread::workerGlobalScope
on a wrong thread at least from outside the class

BUG=520012,460445

Review URL: https://codereview.chromium.org/1305453003

git-svn-id: svn://svn.chromium.org/blink/trunk@200821 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As part of detaching a LocalFrame, its subframes are also detached. Should the
detachment of those subframes trigger a nested detach of the LocalFrame that
initiated their detachment, the LocalFrame being returned to after having
detached the subframes could well be in a detached state. The detach steps that
followed (FrameLoader operations) weren't prepared for being in a detached state
(following r199143) and failed.

And the FrameLoader shouldn't have to gracefully handle being used in a detached
state, so add an is-detached check to the LocalFrame's detach steps before continuing.
Leaving early if so.

R=dcheng,japhet
BUG=520014

Review URL: https://codereview.chromium.org/1290053003

git-svn-id: svn://svn.chromium.org/blink/trunk@200820 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As per the specification, https://html.spec.whatwg.org/#the-htmloptionscollection-interface,
there is no exception throwing mechanism defined when negative values are passed. In such case
we should just ignore the values and avoid using the custom binding for such usage.

Trying to set any value greater than 10000 will be ignored with the existing
length unchanged.

BUG=345519

R=haraken@chromium.org

Review URL: https://codereview.chromium.org/1292653003

git-svn-id: svn://svn.chromium.org/blink/trunk@200819 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL is split out from [1] where we support multiple author origins in
terms of shadow dom scopes. The vector of MatchedProperties contains
matched declarations from all origins in the order in which they should
be applied. For !important declarations, they are applied in the same
order within the same origin, but the order of the origins are different
as the cascading order is:

  - UA important
  - Author important
  - Author
  - UA

We used to have two ranges, one for UA and one for author to accomplish
this. However, with the normal/!important cascading order for
declarations from different shadow doms, we need multiple author ranges:

  - UA important
  - Author important scope n
  ...
  - Author important scope 1
  - Author scope 1
  ...
  - Author scope n
  - UA

We introduce an ImportantAuthorRangeIterator to iterate through the
author ranges and add iterator-style iteration for each range through the
MatchedPropertiesRange class.

As the applyMatchedProperties code is hot, I've run the blink_perf.css
tests locally. Some improved by 2-4%, some became worse by similar
percentages.

[1] https://codereview.chromium.org/1224673002/

BUG=487125
TEST=fast/css

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200697

Review URL: https://codereview.chromium.org/1282243002

git-svn-id: svn://svn.chromium.org/blink/trunk@200818 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TEST=n/a, since no behavior changes.

BUG=393155

Review URL: https://codereview.chromium.org/1299463004

git-svn-id: svn://svn.chromium.org/blink/trunk@200817 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=520849

Review URL: https://codereview.chromium.org/1292503003

git-svn-id: svn://svn.chromium.org/blink/trunk@200816 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://crbug.com/510650#c4 describes the details of the data flow.

1/3 blink: https://codereview.chromium.org/1265133002/
2/3 chromium: https://codereview.chromium.org/1271733002/
3/3 blink: This

BUG=510650,517837

Review URL: https://codereview.chromium.org/1280733002

git-svn-id: svn://svn.chromium.org/blink/trunk@200815 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves a member function |atEditingBoundary()| in
|PositionAlgorithm<Strategy>| template class as static function inside
"Position.cpp" to simplify |PositionAlgorithm| class for improving code halth.

BUG=518738
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1288553007

git-svn-id: svn://svn.chromium.org/blink/trunk@200814 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The test expectations changed slightly due to slight changes in
V8's implementation of stack overflow error message.

R=hablich@chromium.org
BUG=chromium:522399

Review URL: https://codereview.chromium.org/1289673010

git-svn-id: svn://svn.chromium.org/blink/trunk@200813 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL fixes bufferedAmount-after-send.html and removes it from the flaky
tests list.

BUG=520615

Review URL: https://codereview.chromium.org/1295723003

git-svn-id: svn://svn.chromium.org/blink/trunk@200812 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=522399
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/1291313005 .

git-svn-id: svn://svn.chromium.org/blink/trunk@200811 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=522376
TBR=enne@chromium.org

Review URL: https://codereview.chromium.org/1294243003 .

git-svn-id: svn://svn.chromium.org/blink/trunk@200810 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |computeInlineBoxPosition()| out from |VisiblePosition| for
a preparation of moving |computeInlineBoxPosition()| out from |Position|
to make |Position| class simpler for improving code health.

BUG=518738
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1302713002

git-svn-id: svn://svn.chromium.org/blink/trunk@200809 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch gets rid of a redundant argument DOWNSTREAM from
|PositionWithAffinity| constructor call sites to simplify source code for
improving code health, since default value of affinity is |DOWNSTREAM| in
a constructor declarations.

This patch is a preparation of introducing |TextAffinity| enum class as
replacement of |EAffinity|, http://crbug.com/522038.

BUG=522038
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1300493003

git-svn-id: svn://svn.chromium.org/blink/trunk@200808 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=522274

Review URL: https://codereview.chromium.org/1291543005

git-svn-id: svn://svn.chromium.org/blink/trunk@200807 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=521927

Review URL: https://codereview.chromium.org/1294313002

git-svn-id: svn://svn.chromium.org/blink/trunk@200806 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Get rid of unused member function rootEditableElement() in PositionAlgorithm<Strategy> template class

This patch gets rid of unused member function |rootEditableElement()| in
|PositionAlgorithm<Strategy>| template class to simplify source code for
improving code health.

BUG=518738
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1303673002

git-svn-id: svn://svn.chromium.org/blink/trunk@200805 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/1302463002

git-svn-id: svn://svn.chromium.org/blink/trunk@200804 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch checks the version of harfbuzz on the compile time to
enable the use hb_ot_font_set_funcs. With this change, the #if in the
source file no longer depends on which configurations have up-to-date
harfbuzz in the build scripts.

This gives more stable build environment, and gives the full control of
Unicode Variation Selector support to the build scripts.

[1] https://codereview.chromium.org/1283923002/

BUG=383580

Review URL: https://codereview.chromium.org/1294303002

git-svn-id: svn://svn.chromium.org/blink/trunk@200803 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces |LayoutObject::createPositionWithAffinity()| which
takes |int offset| and pass |DOWNSTREAM| to two parameters version to simplify
call sites like like |PositionWithAffinity| constructor which defaults to
|DOWNSTREAM|, for improving code health

This patch is a preparation of introducing enum class |TextAffinity| as
replacement of |EAffinity| for reducing usage of |EAffinity::DOWNSTREAM|.

BUG=522038
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1303653002

git-svn-id: svn://svn.chromium.org/blink/trunk@200802 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces |isRenderedCharacter(Position)()| as replacement of
|PositionAlgorithm<Strategy>::isRenderedCharacter()| to simplify source code
for improving code health, since |isRenderedCharacter()| is used only for
positions in DOM tree, thus we don't need to have composed tree version.

This patch is a part of |Position| class cleanup to reduce |LayoutObject|
dependency.


BUG=518738
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1286993006

git-svn-id: svn://svn.chromium.org/blink/trunk@200801 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The allocation and deallocation scheme of this class' instance is a bit
unusual, because these instances are passed to the Chromium side. The contract
between Chromium and us is basically: "call close() when you finish using it".
WebFrameWidgetImpl::create() calls leakRef() to keep the object alive, and
WebFrameWidgetImpl::close() does deref() to free up the object.

To mimic this keep-alive semantics in the Oilpan world, SelfKeepAlive<> is
used.

This patch fixes a raw pointer in WebFrameWidgetImpl.

BUG=509911
R=haraken@chromium.org, oilpan-reviews@chromium.org, sigbjornf@opera.com

Review URL: https://codereview.chromium.org/1294293004

git-svn-id: svn://svn.chromium.org/blink/trunk@200800 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=522274

Review URL: https://codereview.chromium.org/1289203009

git-svn-id: svn://svn.chromium.org/blink/trunk@200799 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The test timed out in the following case:

1. document.location.search = "?n=v" requests a navigation.
2. Before the navigation happens, onload handler runTest() is executed.
3. document.forms.f.submit() navigates to
    ".../submit-change-fragment.html?n=v#firstaction"
4. Because the original document was ".../submit-change-fragment.html",
   onhashchange handler is NOT called.
5. No one calls testRunner.notifyDone().

This CL moves "?n=v" setting code to runTest(), and do early return to avoid the
form submission without "?n=v".

BUG=521860

Review URL: https://codereview.chromium.org/1302703002

git-svn-id: svn://svn.chromium.org/blink/trunk@200798 bbb929c8-8fbe-4397-9dbb-9b2b20218538

 - Remove unflaky test
 - Update bug numbers for web-platform-tests/html/.

BUG=520176,490511
TBR=keishi@chromium.org

Review URL: https://codereview.chromium.org/1297853005 .

git-svn-id: svn://svn.chromium.org/blink/trunk@200797 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch gets rid of a redundant argument DOWNSTREAM from |VisiblePosition|
constructor call sites to simplify source code for improving code health,
since default value of affinity is |DOWNSTREAM| in each constructor
declarations.

This patch is a preparation of introducing |TextAffinity| enum class as
replacement of |EAffinity|, http://crbug.com/522038.

BUG=522038
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1285233004

git-svn-id: svn://svn.chromium.org/blink/trunk@200796 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instead of returning a permission string, requestPersistent() was
recently changed to return a boolean representing the value of the default
box.

This is an experimental API only exposed behind a flag. The spec is at
https://storage.spec.whatwg.org/

BUG=482814

Review URL: https://codereview.chromium.org/1302643002

git-svn-id: svn://svn.chromium.org/blink/trunk@200795 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Option and control keys are explicit instead of using the symbols. Command appears first always.

BUG=521207

Review URL: https://codereview.chromium.org/1293793004

git-svn-id: svn://svn.chromium.org/blink/trunk@200794 bbb929c8-8fbe-4397-9dbb-9b2b20218538

LayoutObject::hitTest() calls into nodeAtPoint() 4 times
with different HitTestAction options: HitTestForeground, HitTestFloat,
HitTestChildBlockBackgrounds, HitTestBlockBackground.

LayoutPart::nodeAtPoint() descends into iframe hit-test
disregard of HitTestAction options. For rect-based hit-test,
if the test rect is not totally within the iframe bounds,
the iframe hit test will return false for the rect-based
hit test search to continue, which means we will call into
iframe hit test 4 times unnecessarily.

Lets make the change that LayoutPart::nodeAtPoint() descends
into iframe only in the HitTestForeground phase. If we do
hit the iframe, LayoutObject::hitTest() will terminate at
the HitTestForeground phase, If iframe does not hit, we
only descend into it once and would have collected enough
information (e.g. pushing overlapping nodes into hit list).

BUG=520730

Review URL: https://codereview.chromium.org/1302583002

git-svn-id: svn://svn.chromium.org/blink/trunk@200793 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=463547
R=caseq,paulirish

Review URL: https://codereview.chromium.org/1303633002

git-svn-id: svn://svn.chromium.org/blink/trunk@200792 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch changes |ContainerNode::willRemoveChild()| not to call
|Document::nodeWillRemoved()| for a node in different document since we
assume |Document::nodeWillRemoved()| will be called for owner document.

This situation can be happened when DOM mutation event handler moves
a removing node to another document via |dispatchChildRemovalEvents()| call in
|ContainerNode::willRemoveChild()| at L439.

BUG=477584
TEST=LayoutTests/fast/dom/Range/range-dom-node-removed-assert.html

Review URL: https://codereview.chromium.org/1297593004

git-svn-id: svn://svn.chromium.org/blink/trunk@200791 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Integrate samplerParameter[if] functions and validate the pname in blink.

BUG=295792

Review URL: https://codereview.chromium.org/1300583002

git-svn-id: svn://svn.chromium.org/blink/trunk@200790 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Added ability to reveal a setting in settings screen for "Edit" option.

BUG=520239

Review URL: https://codereview.chromium.org/1292673002

git-svn-id: svn://svn.chromium.org/blink/trunk@200789 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch gets rid of a redundant argument DOWNSTREAM from |VisbileSelection|
constructor call sites to simplify source code for improving code health,
since default value of affinity is |DOWNSTREAM| in each constructor
declarations.

This patch is a preparation of introducing |TextAffinity| enum class as
replacement of |EAffinity|, http://crbug.com/522038.

BUG=522038
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1289673008

git-svn-id: svn://svn.chromium.org/blink/trunk@200788 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In light of marking passive mixed content as neutral, "neutral" is by far a better name.

BUG=522274

Review URL: https://codereview.chromium.org/1301823003

git-svn-id: svn://svn.chromium.org/blink/trunk@200787 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=473258

Message ports were using the source frame's execution context
rather than the targets when ports were transferred from a frame
to another. This seems to be leaky and also creates difficulties
when implementing message port support for android webview
and OOPIF. Use the target instead.

This is patch 3 of 3 and removes the deprecated API.

Review URL: https://codereview.chromium.org/1304553002

git-svn-id: svn://svn.chromium.org/blink/trunk@200786 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instead of having many callbacks that implicitly have conditions for when the
blink frame pipeline should run, have a function on Document that checks them
explicitly and make WebViewImpl call it.

This will allow checking if iframes are ready to begin running their lifecycle
phases when iterating the frame tree in ::beginFrame and ::layout().

BUG=521692

Review URL: https://codereview.chromium.org/1300043003

git-svn-id: svn://svn.chromium.org/blink/trunk@200783 bbb929c8-8fbe-4397-9dbb-9b2b20218538