- 13 Aug, 2020 40 commits
-
-
Jao-ke Chin-Lee authored
Add utilities to help handle initialization and teardown of VA objects. Users of VaapiDevice may still manipulate the VA objects directly with libva calls. BUG=crbug:1062407 Change-Id: Id5f5233d1476f1abe006f04e3ad54fc6fb9b2486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296871 Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#797848}
-
Mohamed Heikal authored
If the update_android_aar_prebuilts gn arg is set, all info files are updated. However, some info files could actually not be part of the repo but instead be pulled in via cipd along with the aar itself. This cl adds a gn template flag to disable updating info files for android_aar_prebuilt targets that specify it. Change-Id: I5b82b8e614ab989936834a1b270c0d97bba2da3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353355 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#797847}
-
Eric Orth authored
Use the tracking in DnsUdpTracker to detect situations of DNS ID mismatches or port reuse. Bug: 1093361 Change-Id: I67a339a8ea6f6c34d5626f5587324f9dfb6cbc4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340677 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#797846}
-
Chong Gu authored
Bug: 1105308,1096746 Change-Id: Ie02e83fea75a075441b66cd3c6ac7f2f812e74e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354420Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#797845}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4183.48-1597052523-benchmark-86.0.4229.0-r1 to 86-4183.48-1597052523-benchmark-86.0.4231.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I764a3a194d8d0782833c2e74083ee9827aec5b15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354895Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797844}
-
Chong Gu authored
Add instructions for when access to kvm is denied. Change-Id: Ie3d4b5f8a172212bdda1177b04ea80076cbe5588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347165 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#797843}
-
Jonah Chin authored
ClusterFuzz found an issue in RasterDecoderImpl::DoReadbackImagePixelsINTERNAL. When |row_bytes| is very large, SkImageInfo::computeByteSize() can return a 64bit integer larger than UINT32_MAX. Since GetSharedMemoryAs() takes a 32bit integer for |size|, the int is truncated, resulting in an incorrect value. This change ensures that the result of computeByteSize() is < UINT32_MAX. This change also addresses the same potential case in RasterDecoderImpl::DoWritePixelsINTERNAL. Bug: 1114500 Change-Id: I5cd3acfaac788e97353e0da866b63f694e326e2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353402Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#797842}
-
Sunny Sachanandani authored
SharedImageBacking attributes its allocation to the MemoryTypeTracker of its first SharedImageRepresentation which is considered its owning ref. When the owning ref changes, the backing will switch the allocation to the new owning ref's tracker. This can happen on a different thread than the one the representation was created on, and in general calling the underlying MemoryTracker is not thread safe e.g. dereferencing the peak memory monitor's WeakPtr on a different thread. This issue was discovered while testing the DrDC prototype which makes the display's gpu work run on the viz thread instead of the gpu main thread. This CL fixes the above problem by making MemoryTypeTracker forward its calls to its original sequence (and thus thread). If a sequenced task runner isn't set e.g. on the render thread on Android Webview, then the calls are made synchronously. Bug: 1114888 Change-Id: I6833139c96de3824f450b09333f755560dff62c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350398 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#797841}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e1360ddcec9e..78d7b4b8250e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I542a2ead0b348d8beb9a6667bf0d20bbb92cddb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354606Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ib80e49108602c8bbfd4683a709cc1f80273f46d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354482Reviewed-by:
-
Brian Sheedy authored
Fixes run_performance_tests.py causing the merge script to blow up in cases where a gtest-based perf test is run on multiple shards. This was caused by the script outputting a summary to JSON instead of per-test results, which caused the merge script to try to merge the identically named tests. This is worked around by appending the shard number to the end of the name, but a proper fix where all test results are reported should still be implemented. Bug: 1115658 Change-Id: I55aa3d6c2ce2a4ae681fdcc2338e5016ec478866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351386 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#797838}
-
Numfor Mbiziwo-Tiapo authored
Implements putAllValues where any errors cause the whole request to fail, instead of just the value/s that failed. Explainer: https://github.com/nums11/idb-putall/blob/master/Explainer.md Design Doc: https://docs.google.com/document/d/1wawQ8Pl-Vi6GQN5-y2UVkcghipcOGg0WRAC0ZyBkezg/edit I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/TPd_rtgO3_k/m/qZmPy1dfAgAJ Change-Id: I976db2fe4c441f0ae288e63deb4c69c148721a18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324146Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#797837}
-
David Tseng authored
When SA calls someAutomationNode.focus(), it may generate focus events on someAutomationNode later. This isn't always desirable, e.g. when the node is a text field and SA wants to remain on the VK. Correct this by ignoring focus events of this type i.e. these events have eventFrom 'action'. R=anastasi@google.com Fixed: 1113669 AX-Relnotes: n/a Change-Id: I2266f0aced57db1949dfad2793cc58ac2be923eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352613 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#797836}
-
Jordan Taylor authored
Prior to this change, effects are always given the current phase of the timeline associated with them. This fails in certain situations such as pausing and then scrolling, setting current time with an inactive timeline, and many other scenarios where hold_time is set. In order to fix this, we have introduced hold_phase. Anytime hold_time is updated, hold_phase will also be updated with the appropriate phase. Sometimes the phase is set explicitly and other times we pull from the timeline current time. Animation effects will be given the animation hold_phase if it is populated, otherwise it will calculate its current phase (similar to how current time is calculated). The WebAnimations spec is being updated to reflect this change. Bug: 1046833 Change-Id: I4bf1e42eaab684c18829a79acc1ab8911ec893af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135336 Commit-Queue: Jordan Taylor <jortaylo@microsoft.com> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#797835}
-
Nate Fischer authored
No change to logic. This exposes cc/base/switches.cc to Java with java_cpp_strings. Fixed: 1114378 Test: autoninja -C out/Default system_webview_apk Change-Id: Ie0ffebbaff78e2ee657b1518d8cab15c79760478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343850Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#797834}
-
Klaus Weidner authored
Propagate the actual fullscreen request type to OOPIF fullscreen ancestors so that they fire matching prefixed or unprefixed fullscreen events. (Previously, it was always using "unprefixed" for OOPIF.) Change-Id: I04000d2190e06127329db1d91565914227aa9480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351000 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#797833}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.57-1597053344-benchmark-86.0.4229.0-r1 to 86-4183.57-1597053344-benchmark-86.0.4231.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I5c889ab859f04f507be20a0e1798f7a5a368d949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354483Reviewed-by:
-
Victor-Gabriel Savu authored
Add the DeviceReleaseLtsTag policy to allow devices to keep receiving updates from the LTS branch. Design doc: https://docs.google.com/document/d/1gPf9MyncHTRoB9xhq6dL8ngeKenq2Xe4dxg1z26GpdE Bug: chromium:1114784 Change-Id: I8d48994a0ad69a7f06989efded9f9ff70c9af7cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341128 Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#797831}
-
Takumi Fujimoto authored
Disabled for being flaky TBR=collinbaker@chromium.org Bug: 1116108 Change-Id: I66af00be5f80cbb78a77b73f108ef762f9528126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354540Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#797830}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a22614c51d49..c71a9c2930fa 2020-08-13 changhaohan@chromium.org Enable real-time grid adorner 2020-08-13 alexrudenko@chromium.org Support enum members as types 2020-08-13 brgoddar@microsoft.com Add Presubmit for Devtools Experiment Telemetry If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1047356,chromium:1066772,chromium:1107636 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I157f34e90b32018ab8cab8ff231ea70528e380e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354481Reviewed-by:
-
Eric Orth authored
Essentially a copy of the HttpAuthHandlerDigestFuzzer with a bit of extra logic to exercise the retrieval of specific scheme factories and then remove the bit of input massaging to make it specific to digest. Fixed: 599584 Change-Id: Iceb4d9985b02e0d6de7edd7de3059a90a7050ba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349980 Commit-Queue: Eric Orth <ericorth@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#797828}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b330be01. With Chromium commits locally applied on WPT: b002f0c2 "Add paint timing support for webgl2 canvas." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools npm@chromium.org: external/wpt/event-timing NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ica03f8ec763f3d8d5dec5c887e53a2cd640c7190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353291Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797827}
-
Robbie McElrath authored
This CL adds an "animate" flag to Browser.setTopView that allows the embedder to tell WebLayer to animate the top view off the screen when setting it to null, or to animate it down from the top when setting it to a non-null value. The animation off the screen is achieved by removing the View from the view tree, but keeping the bitmap layer in place, hiding the top controls, and then deleting the layer after the animation is complete. Bug: 1108956 Change-Id: Idb9bce6c2633ef6d1d369ccb2741ae6fd1fe43a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335800Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#797826}
-
Ben Joyce authored
Adds option to choose to use device or host files. The combined reports functionality has been moved to code_coverage generation in the tools/build repo. Won't land until after verifying the bot script is working as expected in: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2348094 Bug: 1107004 Change-Id: I628217c9249a0d69c3ec7d82c63aefd59087d6ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353367Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#797825}
-
Daniel Hosseinian authored
Add a deprecation warning message and icon for the "Save to Drive" destination in the destinations dialog. Add a pref, "cloudPrintDeprecationWarningSuppressed", to suppress all Cloud Print deprecation warnings. Screenshot of change: https://imgur.com/xBfCyGY Bug: 1112581 Change-Id: If6ee65f5178d41a0455bef0ddcabe63a55d1bb1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348414 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#797824}
-
Steven Bingler authored
Modify --enable-experimental-cookie-features to also enable kSameSiteByDefaultCookies. Bug: 1030938 Change-Id: I31a533009d28b79dddd2c7e3cee238e76ccb995d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342209Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#797823}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dbee93ac203d..e1360ddcec9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id012de73a8fffbc4b4d77b89e03164d43f2ef6d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354510Reviewed-by:
-
Sasha McIntosh authored
Both empty and absent EDID blobs result in edid_blob==NULL. This change removes the unnecessary UMA DrmUtil.CreateDisplaySnapshot.EdidBlobIsEmpty and adds a DCHECK instead. TBR=bcwhite@chromium.org,dcastagna@chromium.org,sashamcintosh@chromium.org Change-Id: I5223aef1b39dc309f931e8fc244045d51fa87681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352525Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#797821}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/df9ed89229db..326b98981e78 2020-08-13 scroggo@google.com Add platform image encoder for using NDK APIs 2020-08-13 reed@google.com audio player (for mac) 2020-08-13 mtklein@google.com deserialize SkCanvas::SrcRectConstraint safely 2020-08-13 scroggo@google.com Remove unnecessary pointer increment 2020-08-13 johnstiles@google.com Move `onDumpInfo` calls in gencode to the private section. 2020-08-13 johnstiles@google.com Update GrOp subclasses to use `onDumpInfo` for info dumping. 2020-08-13 johnstiles@google.com Remove more dump-info utility methods when GR_TEST_UTILS is off. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: Ic4bb0267f8666e7cc68da1f9f3d0de80424dc94c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354472Reviewed-by:
-
Evan Stade authored
The term whitelist was a bit of a misnomer to begin with as there was no functionality being allowed for these users. It's simply a list. The term is replaced with "UserList" or dropped completely, based on context. Fixed: 1114930 Change-Id: I2f650283d76f871c9a3c77c8894eb19cc58a20dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348191Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#797819}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ib31b198afaf6738cf90a544d524ad1f67e5ebad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354573Reviewed-by:
-
Daniel Hosseinian authored
In preparation for adding cloud print deprecation warnings with icons that can be suppressed with a pref, move some test code to a helper function to avoid duplication. Additionally, manually call the creation of recent destinations, as they will need to be created after a certain pref is set. Bug: 1112581 Change-Id: I5886f5357c95e95ed50cfe57fa8e2cb6892090a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352516 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/00fcb720bc39..6f04e4b8b57c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC takumif@google.com,lanwei@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1098864,chromium:1099917,chromium:1110940,chromium:1112941,chromium:1114836,chromium:810097 Tbr: takumif@google.com,lanwei@google.com Change-Id: I82f0952f7eadca3632dd43f3c412c8a623ec794f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354479Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797816}
-
Chong Gu authored
Adds ~10 minutes of bot time and run time for the x64 FYI Fuchsia bot. Filters flaky tests. Bug: 1058255 Change-Id: Iede9c43a1de1639b0de1b32ea72d6509c686edc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209291Reviewed-by:
-
Kartik Hegde authored
In order for cros_healthd to invoke network diagnostics routines in the browser, it needs a remote sent to it by Chrome. BUG=chromium:956783 TEST=1) chromeos_unittests --gtest_filter=CrosHealthdServiceConnectionTest.* 2) Applied the LanConnectivity related changes on top of this, and executed the following: "cros-health-tool diag --action=run_routine --routine=lan_connectivity" (no problems - expected resulted) Change-Id: Ifa15c19c7cb61305ff4ca1f76d8c6350d0ccd5ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321004 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Brandon Goddard authored
This CL adds backend support for new devtools user action for activating the source order viewer. Frontend CL: https://crrev.com/c/2353377 Bug: 1094406 Change-Id: I49ee7e3d724ff67f131c9e1098d098830847722b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351391Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#797813}
-
Alexander Cooper authored
Currently the inline rAF loop gets restarted before the page is notified that the immersive session has ended. This causes some flaky test cases where the inline callback is serviced before the page knows that it's okay, since the immersive session has ended. This change splits the FrameProvider's OnSessionEnded logic such that it can be notified of the fact that there is no longer an immersive session before the page is (so that the page is not blocked from requesting a new immersive session), while only re-starting the inline rAF loops after the page has been notified. Fixed: 1062195 Change-Id: I2ccf63d476b7f857bc53e9c15bedc07a13fdfed6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354537Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#797812}
-
Brian Sheedy authored
Runs the Telemetry minidump symbolization tests on several Windows builders and their CQ counterparts. We previously did not have any Windows coverage of minidump symbolization functionality on the CQ, which made it possible for Windows-specific minidump issues to land. This adds ~2.5 minutes of bot time per build. Bug: 1115295 Change-Id: Iee6e145e74cad6ab93840840c4d5601d9bf57a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350497Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#797811}
-
Chris Lu authored
Each InfobarType needs its own InteractionHandler to properly register the UI handlers for each Infobar type. Bug: 1071914 Change-Id: I784ce1045200bb6012ce569a4ee39e3a4619c0f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354595Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#797810}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.57-1597055597-benchmark-86.0.4229.0-r1 to 86-4183.57-1597055597-benchmark-86.0.4231.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I031ed2bfa49b5fa2846a7c4f5f603a980a9d8361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354579Reviewed-by:
-
