GitLab

NOTRY=true

Review URL: https://codereview.chromium.org/301223010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274910 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380828
R=robertshield@chromium.org

Review URL: https://codereview.chromium.org/316103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274909 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380371

Review URL: https://codereview.chromium.org/316753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274907 0039d316-1c4b-4281-b951-d872f2087c98

This CL was originally intended to be a reland of
https://codereview.chromium.org/227043012/. There have been sufficient changes
that this CL should be given a full review.

In the previous behavior, the history swiper tried to be very conservative
about the gestures it recognized as a history swipe. Once a gesture was
recognized, events would be consumed and not sent to the renderer. This has two
fundamental flaws.
 1. It is difficult to tell whether a gesture is going to be a history swipe
 from the initial events. Waiting for longer introduces lag in the appearance
 of the history swipe UI, which is janky.
 2. NSEvents with phase NSEventPhaseChanged are coalesced before they are sent
 to the renderer. This loss of information makes it more difficult to determine
 which of the uncoalesced events the renderer would have handled, which adds to
 the difficulty of determining whether a gesture should be recognized as a
 history swipe.

In the new behavior, the history swiper (in conjunction with the logic in
ScrollElasticityController in Blink) aggressively attempts to recognize the
initial events of every gesture as the beginning events of a history swipe.
The recognition process is primarily gated by whether the renderer consumes the
NSEvent with phase NSEventPhaseBegan. Once a gesture has been recognized as a
potential history swipe, the history swipe UI is shown, and the history swiper
will process new events to update its internal state, but the events will
continue to be forwarded to the renderer.

While the history swiper is determining whether the gesture was actually
intended as a horizontal, history swipe, both itself and the renderer will get
to process events and update their respective UIs.

To combat the ease with which history swiping was entered, the history swiper
aggressively attempts to cancel out of history swiping. If the gesture
progresses sufficiently such that it appears to be intended for a history
swipe, then the events will be consumed and no longer forwarded to the
renderer.

As an aside: the renderer callbacks for scrollOffsetPinnedToLeft and
setHasHorizontalScrollbar are no longer useful. The former was not accurate to
begin with, since the callback only occured when the content scrolled, but not
after a history navigation. They should be removed at a convenient time.

BUG=321437

Review URL: https://codereview.chromium.org/300863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274906 0039d316-1c4b-4281-b951-d872f2087c98

ClearBrowserDataBrowserTest.CommitButtonDisabledWhileDeletionInProgress is still extremely flaky on all bots, so disabling again.

http://chromium-build-logs.appspot.com/gtest_query?gtest_query=ClearBrowserDataBrowserTest.CommitButtonDisabledWhileDeletionInProgress

BUG=379574
TBR=engedy@chromium.org
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/316053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274904 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378785

Review URL: https://codereview.chromium.org/301973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274901 0039d316-1c4b-4281-b951-d872f2087c98

This removes some more unnecessary methods and moves some more UMA reporting
out of the trusted plugin, reducing the total line count.

It's a little awkward that we have to pass the max value of NaClErrorCode to
the new reporting method, but it keeps that enum out of the public NaCl
interface.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/315753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274898 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/317783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274897 0039d316-1c4b-4281-b951-d872f2087c98

This class lists bootstrapping WiFi devices and provides the necessary information to display/connect to them.

Depends on:
https://codereview.chromium.org/294173002/ [build variable for WiFi bootstrapping]
https://codereview.chromium.org/226883002/ [WiFi library for cloud devices]

BUG=370071

Review URL: https://codereview.chromium.org/288043004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274896 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274895 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=175413:175426&mode=html

TBR=peter@chromium.org

Review URL: https://codereview.chromium.org/315043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274894 0039d316-1c4b-4281-b951-d872f2087c98

This doesn't seem to be needed and makes it
impossible to build gmock for client projects
that doesn't have Chromium base.

BUG=webrtc:3441
R=brettw@chromium.org,tfarina@chromium.org

Review URL: https://codereview.chromium.org/311833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274893 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369973

Review URL: https://codereview.chromium.org/301353009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274892 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Led to increased crashiness: https://code.google.com/p/chromium/issues/detail?id=368809

Original issue's description:
> Resubmit: Refactor external_install_ui
> 
> Original CL: https://codereview.chromium.org/300853008/
> Original Description:
> Refactors ExternalInstallUI to have determinate lifetimes.
> This is likely the first of multiple patches targeting this area of code; the
> next one will concentrate on pulling the related logic out of ExtensionService.
> 
> ----------------------------------------------------
> 
> The original patch contained a cycle in that when an external install warning
> was clicked, it would accept or remove the extension, and then remove the error.
> Since the manager listened for the extension to be loaded or unloaded, this
> resulted in a double-removal.  Fix is straightforward.
> 
> We also didn't have tests for actually interacting with the dialog, so two have
> been added.
> 
> TBR=yoz@chromium.org
> BUG=378042
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274325

TBR=yoz@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=378042

Review URL: https://codereview.chromium.org/313173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274890 0039d316-1c4b-4281-b951-d872f2087c98

Its only case has been disabled for a couple years, and blink has  since removed
the feature it was testing (multipart main reosurces).

BUG=136310

Review URL: https://codereview.chromium.org/316663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274889 0039d316-1c4b-4281-b951-d872f2087c98

Move chrome/browser/network_time to components/network_time
network_time.h is removed as it's unused.

BUG=371470
TEST=git cl try

Review URL: https://codereview.chromium.org/296453005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274887 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349475
R=isherman@chromium.org

Review URL: https://codereview.chromium.org/311963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274884 0039d316-1c4b-4281-b951-d872f2087c98

Adding a helper class for partial reconstruction of SyncFS system.

BUG=380615

Review URL: https://codereview.chromium.org/310383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274883 0039d316-1c4b-4281-b951-d872f2087c98

This aligns ChromeVox's supported languages with those of Chromium, adding
at least one new language that was missed before.

BUG=366197
R=dtseng@chromium.org
Tested=Tried chromevox in US English, Swedish, Norwegian and German, including navigating, options page and plural handling of characters.

Review URL: https://codereview.chromium.org/317613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274882 0039d316-1c4b-4281-b951-d872f2087c98

BUG=313751
R=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/315563005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274881 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380666

> Lobotomize the GPU memory manager
> 
> On desktop, always set the memory limit to 256MB, and ask that the renderer
> only use that memory to draw content that is near the viewport. The effective
> limit prior to this patch was 384MB, but would quickly get cut down as multiple
> windows are opened, but would not fall too much lower than 256MB (e.g, 128
> on Mac).
> 
> On mobile, use all available memory for the current, only, renderer.
> 
> Do not take into account unmanaged (e.g, WebGL) memory usage.
> 
> BUG=377065
> 
> Review URL: https://codereview.chromium.org/308743005

TBR=ccameron@chromium.org

Review URL: https://codereview.chromium.org/313163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274879 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379996
TEST=manual as descirbed in the bug.

Review URL: https://codereview.chromium.org/315703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274872 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274871 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/abc073376091e66f705674b825b1247148cb9c24..9b14f26d0f3a974f3dd626c8354e1db1cfcd322f
TBR=jvanverth@google.com
BUG=

Review URL: https://codereview.chromium.org/318653004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274870 0039d316-1c4b-4281-b951-d872f2087c98

Has been flaking out a few times a day on Linux ChromiumOS Tests for
awhile.  The standard MAYBE_ #ifdef didn't work for me for uncertain
reasons.

BUG=374871
NOTRY=True
TBR=rtenneti@chromium.org

Review URL: https://codereview.chromium.org/316043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274869 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/311603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274865 0039d316-1c4b-4281-b951-d872f2087c98

BUG=376565
for c/b/sync/test:

R=tapted@chromium.org, xiyuan@chromium.org
TBR=zea@chromium.org

Review URL: https://codereview.chromium.org/305013014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274864 0039d316-1c4b-4281-b951-d872f2087c98

I'd like to break out OpenManifestEntry and some other functions out of
ppb_nacl_private_impl.cc so they're easier to reuse and less tightly-bound to
the PPB_NaCl_Private interface.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/310113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274860 0039d316-1c4b-4281-b951-d872f2087c98

The CL to enable all touch editing tests for Aura got reverted due to
failure in browser tests. Now, landing innocent views tests separately,
until issues with browser tests are fixed.

Original CL: https://codereview.chromium.org/304883002/

BUG=377561
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/315753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274859 0039d316-1c4b-4281-b951-d872f2087c98

This change was introduced for the sake of merging it back to M36. All
relevant changes that make this CL obsolete are already part of M37 and
the presence of this CL makes it impossible to test these.

> Remove the option to skip auto-update checks on OOBE.
> 
> This is the simpler version of actually making sure that even if it
> skipped it will not allow forced reenrollment to be circumvented.
> 
> This option will be reintroduced in the first stable version to contain
> all other safeguards in place.
> 
BUG=378953
> 
> Review URL: https://codereview.chromium.org/306993004

TBR=pastarmovj@chromium.org

Review URL: https://codereview.chromium.org/313923005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274858 0039d316-1c4b-4281-b951-d872f2087c98

Chrome shell is still being referred as ChromiumTestShell in
some places, especially in the telemetry scripts. This
cleanup has dependency on changes in the buildbot
scripts as well where we are invoking the telemetry scripts
as ChromiumTestShell. The buildbot changes are uploaded as
part of https://crrev.com/302743002 to correct invocation as
ChromeShell instead ChromiumTestShell.

BUG=355730

Review URL: https://codereview.chromium.org/302653004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274857 0039d316-1c4b-4281-b951-d872f2087c98

Changing the type of Text in title_button_menu_item.xml from Button to TextView
to remove additional pressed state background that comes with the Button.

BUG=369680
R=dtrainor@chromium.org

Review URL: https://codereview.chromium.org/315663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274856 0039d316-1c4b-4281-b951-d872f2087c98

Validation errors are written to stderr and also used in validation tests.
This CL also changes MessageHeaderValidator to use the same struct header
validation code as other structs.

BUG=None
TEST=validation_unittest.cc
R=darin@chromium.org

Review URL: https://codereview.chromium.org/307353009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274855 0039d316-1c4b-4281-b951-d872f2087c98

> Reset scoped_ptr to make plugin crash before entering engine_->HandleDocumentLoad, if called for deleted "Instance".
> Suspecting method call for deleted instance.
> 
> Example to explain why reset() makes difference:
> 
> scoped_ptr<int>* pt = NULL;
> {
>   scoped_ptr<int> t(new int);
>   pt = &t;
> }
> DCHECK(!(*pt));  // Fail
> {
>   scoped_ptr<int> t(new int);
>   pt = &t;
>   t.reset();
> }
> DCHECK(!(*pt)); // OK
> 
> BUG=372095,372548
> 
> Review URL: https://codereview.chromium.org/300403002

TBR=vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/318743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274854 0039d316-1c4b-4281-b951-d872f2087c98

This makes us get XP/Server 2003 compatible metrics for window
sizes and so indirectly fixes pixels being cut off at the top
of the window.

(Server 2003 compatible metrics make us match x86 behaviour, and
since we need to maintain XP subsystem there indefinitely, I can
sort of rationalize it on that basis.)

R=jschuh@chromium.org, wfh@chromium.org
BUG=361720

Review URL: https://codereview.chromium.org/311953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274853 0039d316-1c4b-4281-b951-d872f2087c98

Add DCHECK_EQ(view, masked_view()) to the overrides of
MaskedViewTargeter::GetHitTestMask(). This is to ensure
the function is only called with |view| corresponding
to the view on which the targeter is installed.

This is nice to have because GetHitTestMask()
is called directly from a few places such as
overrides of View::GetHitTestMask() and (soon)
from within TabCloseButtonTargeter; see issue
377557.

BUG=377527
TEST=none

Review URL: https://codereview.chromium.org/308003019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274852 0039d316-1c4b-4281-b951-d872f2087c98

A request for the "TARGETS" target of the clipboard selection via
XConvertSelection(display, selection, target, property, requestor, time)
should set |property| to a property of type XA_ATOM. Mono apps set |property| to a property of type "TARGETS" instead.

This CL treats a property of type "TARGETS" the same as a property of type XA_ATOM.

BUG=377893
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/314943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274851 0039d316-1c4b-4281-b951-d872f2087c98

Clean up gin run all unittests file. I noticed some extra includes while searching for some code to copy.

BUG=
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/318543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274850 0039d316-1c4b-4281-b951-d872f2087c98

This patch enables audio / video thumbnail extraction. A lot of supporting code has already gone in. This is the last piece in the actual extension API that enables this.

BUG=304290

Review URL: https://codereview.chromium.org/250143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274849 0039d316-1c4b-4281-b951-d872f2087c98

Needed for converting some TextButtons to LabelButtons.
(eg. new avatar button, bookmark buttons on drag)

BUG=155363
TEST=Label example shows a halo'ed label.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/308083011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274848 0039d316-1c4b-4281-b951-d872f2087c98