- 05 Oct, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1601866325-a85f6ecffc151934e2e0b93e1917188663da3160.profdata to chrome-win32-master-1601877511-e7db431e3df4886bdee72d3fd137fde2437674f5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand@chromium.org Change-Id: I480da53d1a6fb95e195ea4289e98970ad2d61a37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449117Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813677}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: Ie95a1489a1754c83dbe709e5f2c2b8dbfd00114f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445931Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813676}
-
Yuki Shiino authored
Error messages of generate_bindings.py are often hard to read due to multiprocessing. Supports --single_process flag for debugging purpose. Bug: 839389 Change-Id: Ibe0d55716cdc9d5db77b0714dd96c11832ab0143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447529Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#813675}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6b0afc48ae3d..935a915963e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I651b929f9ad460c62640a50ce2bb6f949a43b060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448659Reviewed-by:
-
Christian Dullweber authored
This reverts commit 55f91b14. Reason for revert: This seems to introduce a different kind of issue due to highlights. Needs more investigation. Original change's description: > Use TouchCommon instead of Espresso's click > > Espresso is occasionally failing to click() with a INJECT_EVENTS > permission error. Try to use TouchCommon, which is supposed to not have > this issue. > > Bug: 1133770 > Change-Id: Iaa7084e095e01c75dc8c0b973a99c991f81b3a01 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445493 > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> > Auto-Submit: Christian Dullweber <dullweber@chromium.org> > Reviewed-by: Ehimare Okoyomon <eokoyomon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813201} TBR=dullweber@chromium.org,eokoyomon@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1133770, 1134780 Change-Id: I3e0f813e1da1bbd8b670efdc85738efacc1aa54f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449370Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#813673}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I2d85cb187c955f47715ca3214ccb47db74f98941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445479Reviewed-by:
Guillaume Jenkins <gujen@google.com> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813672}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/500704812409..e56466d4848c 2020-10-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 7b91afe9 to 78d150eb (541 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I9679bda3f72a3c9e74ad13dfcd8d77e782b53dee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449116Reviewed-by:
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I24a36ed818f27686c8f05c795b8e2072facc6049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445495Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813670}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/771de5b81a2b..64b018448b3e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC koerber@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: koerber@google.com Change-Id: I27ca632e2646da3f9416eab5680d62a5231c2b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449123Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813669}
-
Matthias Körber authored
Test cause consistent failures on multiple builders. TBR=alexmos@chromium.org Bug: 1135072 Change-Id: I43e121120d0a3be030839727f109f9220b3b2b58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449469Reviewed-by:
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: Ib4a41b401603cd96852136f038cbb358cf4605a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445616Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813667}
-
Yuki Shiino authored
Checks consistency between non-partial and partial definitions. Bug: 839389 Change-Id: Id5643b3f7eb93227d8f8b1c182da9d52e781fffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446311 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d91afd8de27a..f15133788010 2020-10-02 afdx@google.com spirv-fuzz: Avoid using block-decorated structs in transformations (#3877) 2020-10-02 afdx@google.com spirv-fuzz: Use overflow ids when inlining functions (#3880) 2020-10-02 jaebaek@google.com Debug info preservation in convert-local-access-chains pass (#3835) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC timvp@google.com,radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: timvp@google.com,radial-bots+chrome-roll@google.com Change-Id: I1675caafa153d32cb460b80dc6b2b742e5127253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449115 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Aaron Leventhal authored
Bug: 1132674 Change-Id: Ifdd4e607626b87c122ffc0b32a05b45ced7d8b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434736 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#813664}
-
Jit Yao Yap authored
Sync server-side changes from cl/333594358. Change-Id: I705eccefefc281280efe45594dc7aed530591a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449069 Auto-Submit: Jit Yao Yap <jityao@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#813663}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I4532b48bf0c141e578e4a81210134862db7e343a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445496Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813662}
-
Yunke Zhou authored
Bug: 1113149 Change-Id: Id2b6b3128cd116536f2621c327f91aa71f6348f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404853 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#813661}
-
Viktor Semeniuk authored
This is a reland of 7b693e30 Fixed failing tests: testStoredEntriesAlwaysShown testCancelDeletionInDetailView testSearchPasswords Original change's description: > [iOS][Password Check] Rewriting Passwords test with new details screen > > This change rewrites Passwords tests with new Password Details screen. > Obsolete tests are deleted. Fixed flakiness for > testSearchAndDeleteAllPasswords. > > Bug: 1075494, 1129441 > Change-Id: Id6d44a2f77c20edb1788f1d3dcaa04e9e645cdb5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418853 > Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811668} Bug: 1075494 Bug: 1129441 Change-Id: Ibfe28ea3ee68f9fb69fcb50085da9c1c558f86d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438380 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#813660}
-
Roberto Moura authored
When the Tab Grid is visible, set |scrollEnabled| to YES to allow the user to switch between recent tabs, incognito, and regular browser, and set to NO otherwise (when the Thumb Strip or Tab Strip are visible). Change-Id: I61bd079d50c9ab27b7970dcacaf149438595a269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445881 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I6c3fe6e56e5ad85ffe02efe806f4a087079f31a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445778Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813658}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I42b7d21fa7952ffd68333222dc5371d42e0d2ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445613Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813657}
-
Nohemi Fernandez authored
Currently it is difficult to understand that the GAIA refresh logic only triggers for the google.com domain. This patch adds a comment to this effect and ensures that only Google domain URLs are processed when executing a navigation. Bug: 1131027 Change-Id: Iebdbd804ef378ce48dda95be98de3ed76c9642d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435184Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#813656}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1f8d793e3bb0..af6c5c622733 2020-10-05 treehugger-gerrit@google.com Merge "[trace processor] Add RAIL Mode power metrics" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia290a191936b6a069bc3ca058e0abaea5bc61cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449120Reviewed-by:
-
Kent Tamura authored
This CL makes ScrollbarThickness() and HasValidAvgCharWidth() of LayoutTextControl static and public in order to share them with LayoutNG. - ScrollbarThickness(): It takes a LayoutBox argument - HasValidAvgCharWidth(): Pass only Font to it because both of SimpleFontData and the family name can be obtained through the Font. This CL has no behavior changes. Bug: 1040826 Change-Id: Ie7000ef7cca04284b2b1a6ff934809560d37a2da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449094 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#813654}
-
Roberto Moura authored
Set the zPosition of each cell to its index so that they don't overlap during a transition from thumb strip to tab grid. Bug: 1127604 Change-Id: I9763cc2c716e1db17c51affe6c335d422280501d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445782 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: Icb49329e594d7ea9cf3dd3f467cb1fb58d7911c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445480Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#813652}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601853620-58f3e166d029ce41b2a670400388c632a12e05f3.profdata to chrome-linux-master-1601877511-28b93e09fa0b9618306e073ac2e467bbc2486723.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: Iec101d136e024eeaed890695b3f8035c11fb32f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449114 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Kuo Jen Wei authored
This CL fix the UI looks of CCA under RTL language in following aspect: 1. Use flex-start on setting menu. 2. Mirror the directional icon. 3. Substitute padding/margin-left/right with start/end. 4. Have extra rtl rule flipping css left/right attribute. Bug: 1133093 Test: Manually on LTR/RTL languages. Change-Id: I684ac98903be3338e15aea28005e92aa57d4b5de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437318Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#813650}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ia1ac6d3542d75306aa3f8fae5d2177c1e9ef4b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448681Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813649}
-
arthursonzogni authored
The DomSerializerTest are executing browser-side and renderer-side code in the same process. This was written 10 years ago. The renderer is no more expected to load new documents without requesting navigations from the browser process. This patch updates the DomSerializerTest. Now the browser process is free to kill more renderer when they try to commit unexpected navigation. This patch looks big, but it isn't. This patch consists of: 1. Update LoadContent to use regular navigations. It is now called from the browser process instead of the renderer. 2. For every test: Replace the callback (executed by the renderer process) by a lambda expression. Split the lambda around every call to LoadContent. It is now executed from the browser process. 3. Update GetRenderView(). The navigation can now happens in a different RenderView[Host], this wasn't the case previously. The value returned can now change. Bug: 1133115 Change-Id: I683149fbe353cf19fe1db96cda803eab079d8f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435350Reviewed-by:Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#813648}
-
Tymofii Chudakov authored
Add feature flag for Privacy Advisor. Bug: 1083878 Change-Id: I577cc36c7255a7d304c610ce6943931c7a2daf66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416452 Commit-Queue: Tymofii Chudakov <tchudakov@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#813647}
-
sauski authored
To reduce the number of records pending update in the access context audit database, an in memory set of previously seen cookie accesses is added. This set is consulted before attempting database insertion and is cleared on navigation. Bug: 1132947 Change-Id: I87f1b2e1283c8c9a1ee76dc3649ce2f2f598f82b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438391 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#813646}
-
Henrique Ferreiro authored
When porting StartDragging to Mojo in https://crrev.com/c/2320268, the image contents weren't being set in the drop data. This resulted in a link being saved on Windows and an error shown on Linux. Bug: 1039255, 1132953 Change-Id: I2d21e0424c89306d5df8caf940e93999d16f78f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444996Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#813645}
-
Colin Blundell authored
This CL moves the C++ AdsBlockedInfoBar class away from being a ChromeConfirmBar to directly subclassing the //components-level ConfirmInfoBar. This change is necessary to support componentization of the infobar and reuse in WebLayer. There is no behavioral change intended. Bug: 1116095 Change-Id: I289bd30d1a956e2db41744a007247c2893410213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442829 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#813644}
-
Alessio Bazzica authored
No-Try: True Bug: webrtc:7494 Change-Id: I590ec5371db86b66e7523209d3131b065a2463ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449369Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Ale Bzk <alessiob@chromium.org> Cr-Commit-Position: refs/heads/master@{#813643}
-
Kent Tamura authored
InnerEditor's paddings are always zero. Web authors can't customize InnerEditor's style. This CL has no behavior changes. Change-Id: Ida6e95a07c3c7c2f2d6700a54c5c40cf06835e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449095 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Maksim Sadym authored
rebase CL 2044170 part 2. part 1 was merged in CL 2431864. DevTools uses `ExecuteJavaScriptMethod` instead of `ExecuteJavaScript`, which should reduce serialisation/deserialisation overhead. Loading Chrome DevTools on the page https://www.facebook.com/Shakira: Before: V8.CompileCode, 130.326 ms, 2227 times V8.ParseProgram, 49.329 ms, 1878 times After: V8.CompileCode, 18.571 ms, 343 times V8.ParseProgram, 0.053ms, 2 times Loading Chrome DevTools on Chrome DevTools on the page https://www.facebook.com/Shakira: DevTools on DevTools Before: V8.CompileCode, 180.928 ms, 3708 V8.ParseProgram, 59.535 ms, 3700 After: V8.CompileCode, 4.956 ms, 92 V8.ParseFunction, 1.945 ms, 92 Bug: chromium:1029427 Change-Id: I78011c8f80a99c85d65354fb4a8a776491ac4f3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442012 Commit-Queue: Maksim Sadym <sadym@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#813641}
-
Maksim Sisov authored
All the tests from the filter pass now. Enable them back. Bug: 1040382 Change-Id: I3e7b2d926fabc3f8e0028a2668fc2c5667c5ea5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444315Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#813640}
-
Yunke Zhou authored
Bug: 1134074 Change-Id: I14494519a53375d61d6c106c5529727af00d67f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440512 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/99fa0ad98a95..7028f1d3895f 2020-10-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib5931b119d8a2bd60a1f9feb0e62197366e280ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449111Reviewed-by:
-
