- 21 Aug, 2018 40 commits
-
-
sczs authored
Bug: 876119 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icf8628ea868bb76b27477022ee4068ed971a32ce Reviewed-on: https://chromium-review.googlesource.com/1182509 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#584897}
-
Martin Kreichgauer authored
This relaxes the access control restriction for keychain items created by the Touch ID authenticator to require biometric authentication *or* password entry. The effect is that the native Touch ID dialog will show a "use password" button next to the cancel button. Not that despite the name of the kSecAccessControlUserPresence attribute, the TouchIdAuthenticator is still user-*verifying* (passcode entry is a valid user verification method in the WebAuthN spec). Related Apple Developer documentation can be found here: https://developer.apple.com/documentation/security/secaccesscontrolcreateflags/ksecaccesscontroluserpresence?language=objc This change is somewhat backwards-incompatible: If a user tries to authenticate using a credential created *before* this change *and* actually chooses the "Use Password" fallback, they will afterwards be prompted with a second Touch ID dialog that does not have the password fallback button. This is acceptable since the feature hasn't launched yet. Bug: 678128 Change-Id: If4e3461ccd378bac286dbba68c3011fee2eb0fa3 Reviewed-on: https://chromium-review.googlesource.com/1183636 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#584896}
-
Philip Rogers authored
This reverts commit 7834ee21. Reason for revert: Suspected as causing failing tests in 874162 Original change's description: > Fix background painting on scrolling contents layer with foregrounds > > This patch removes a negative z-index children check from > PaintLayer::GetBackgroundPaintLocation. This lets backgrounds paint in > the scrolling contents layer in the presence of negative z-index > children, fixing the painting of background-attachment: local. This > patch also removes a DCHECK that was hit when a foreground layer and > kBackgroundPaintInScrollingContents coexisted. This DCHECK[1] could be > hit for root layers without the functional change in this patch. As the > test in this patch shows, kBackgroundPaintInScrollingContents and > foreground layers work together, so this patch makes non-root-layers use > both, and removes the DCHECK. > > What are foreground layers? A foreground layer is created if a stacked > PaintLayer has composited negative z-index children that should wedge > between the layer's background and the layer's contents. The foreground > layer will have the normal-flow contents in this case. See the comment > above foreground_layer_ in composited_layer_mapping.h. > > [1] DCHECK originally added in: https://crrev.com/9a2cdc8d96d. Reading > the comments, I think the DCHECK was intended to ensure the background > would not be painted into the foreground layer. > > Bug: 861948 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I7409cbe9ac61fed444856df342d0707d6babab09 > Reviewed-on: https://chromium-review.googlesource.com/1173532 > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Commit-Queue: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584802} TBR=pdr@chromium.org,chrishtr@chromium.org Change-Id: Ifd22a963dbd5ce288dfb31ab1e8ac41ebe63062d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 861948 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1184109Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#584895}
-
Gayane Petrosyan authored
These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: I437ea5c000a3a4fe3a065dd51641de44a27a6fa9 Reviewed-on: https://chromium-review.googlesource.com/1126321 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584894}
-
Lei Zhang authored
Change-Id: I2ddcf856255fd4790ac0e810f41ddb44e0c7aaff Reviewed-on: https://chromium-review.googlesource.com/1182958Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#584893}
-
Chris Harrelson authored
In particular, for cases when the PaintLayer direct compositing update fast-path applies. Bug: 872172 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If059f2f76d9973c2a19d2f326f495e4891813d6e Reviewed-on: https://chromium-review.googlesource.com/1171797Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#584892}
-
Tim Zheng authored
This change add 3 histograms for measuring crosvm resource usage, namely CPU percentage, resident memory percentage, and number of crosvm processes. BUG=chromium:855762 TEST=manually tested on an eve device; unit tests included. Change-Id: I55f442505a340813db4eb6047844288e4801f325 Reviewed-on: https://chromium-review.googlesource.com/1175410 Commit-Queue: Tim Zheng <timzheng@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#584891}
-
Eugene But authored
-[CRWWebController setDocumentURL:] will have a DCHECK when new document URL does not match last committed URL in WKBasedNavigationManager. This DCHECK will help to diagnoze possible URL spoofing bugs in Slim Navigation feature. Deferring setDocumentURL: call to the point when the navigation is committed will make sure that WKBasedNavigationManager is in correct state and it is safe to compare these URLs. Without this change WKBasedNavigationManagerImpl::GetLastCommittedItemIndex will return last_committed_item_index_ ivar, which is not correct and URLs will not match. WebStateImpl::OnNavigationFinished is still called after setDocumentURL: to make sure that WebStateObserver callback is called after all WC internals were updated. Bug: 1182320 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2e4067fc6220c3af5a28881cdca8f36f948c503e Reviewed-on: https://chromium-review.googlesource.com/1182414Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#584890}
-
Will Harris authored
https://helpx.adobe.com/security/products/flash-player/apsb18-25.html BUG=412078 TBR=jschuh@chromium.org Change-Id: I7e9dc9f7ee7b8e99cb524c9dd40ed5e4a8a28634 Reviewed-on: https://chromium-review.googlesource.com/1184027 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#584889}
-
Fredrik Söderquist authored
In preparation for making base-val <-> attribute synchronization, refactor the SVG*TearOff hierarchy so that "mutation notifications" are funneled through the SVGAnimatedProperty(Base) if the tear-off is associated with an attribute. Rather than storing a SVGElement* and QualifiedName, store a reference to the underlying SVGAnimatedProperty(Base) instead of the latter. This is then used to send notification through. BUG=873470 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib6e5c25cf97b806ff613a39478dc4f10f85dcaf5 Reviewed-on: https://chromium-review.googlesource.com/1181342Reviewed-by:
-
Sky Malice authored
This reverts commit 66ce35f8. Reason for revert: Speculative revert to fix MainIntentBehaviorMetricsIntegrationTest#testLaunch_From_InAppActivities, see https://crbug.com/876463 Bug: 876463 Original change's description: > Remove data use updates from page load metrics > > Now that per-resource updates are sent to page load metrics, we no > longer need to send totals from the renderer process. Remove all > piping/callbacks and convert existing consumers to > OnResourceDataUseObserved. > > Per-resource updates: > https://chromium-review.googlesource.com/c/chromium/src/+/1164222 > > Change-Id: I1cb03df5e6579fc0ff767900336308a6bbad244a > Reviewed-on: https://chromium-review.googlesource.com/1178324 > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: John Delaney <johnidel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584744} TBR=kinuko@chromium.org,csharrison@chromium.org,rajendrant@chromium.org,johnidel@chromium.org Change-Id: I4b750a31c1f0a99b5edd18d7104d1b948913e1c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1184062Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#584887}
-
Mohsen Izadi authored
The connection error handler set on the GpuService in GpuProcessHost might arrive either before or after GpuProcessHost::OnProcessCrashed(). If it arrives before, it might end up running a new GPU process before OnProcessCrashed() has a chance to fallback to the appropriate GpuMode. This CL essentially reverts the use of connection error handler introduced in r584455 so that we ensure that the new GPU process is not launched before the fallback GPU mode is determined. BUG=876336 Change-Id: Ie83b0824b45b25c46c2baad3aa55e7f30c8a9113 Reviewed-on: https://chromium-review.googlesource.com/1183696Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584886}
-
Alexander Timin authored
R=rkaplow@chromium.org BUG=853771 Change-Id: I9f569103758c4f174b921925f1f0f2f2d7503553 Reviewed-on: https://chromium-review.googlesource.com/1183677Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584885}
-
Yi Gu authored
Upon calculating the relative position between a composited sticky element and its scroll container, we use EnclosingIntRect instead of RoundedIntRect which causes a scroll offset mismatch between main and cc if the relative position is non integer, e.g. float prepadding. Bug: 693412 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ideab875d2d087b8fe97264d0bddbd7e2393f8e7f Reviewed-on: https://chromium-review.googlesource.com/1183622Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#584884}
-
Gayane Petrosyan authored
These are histograms that have not been viewed in the last 6 months, but still report data on the Stable channel. Set these histograms to stop being recorded for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug) reminding owners about the approaching histogram expiry – initially 30 days prior to expiry, and also with follow-up alerts. The metrics dashboards will also display a warning for anyone viewing a soon-to-expire histogram. Owners and/or users of these histograms: Please comment on this CL if you think that any affected histogram should not have an expiry date set! This should be uncommon. Otherwise, there are a few options going forward: * If the histogram is no longer needed, please send a follow-up CL to delete the recording code and to mark the histogram as <obsolete>. (You can also remove the expiry date in the same CL.) * If you want to set a different expiry date, please send a follow-up CL to do so. * If neither of the above apply, then keep an eye out for Monorail bugs as the histogram expiry date approaches. For more info on how unused histograms are identified, see https://goto.google.com/uma-unused-histograms-cleanup Bug: 850539 Change-Id: Ia7d065d7786ece8cdb0dbad78de13c0f9a699290 Reviewed-on: https://chromium-review.googlesource.com/1111473Reviewed-by: -
Mike Wasserman authored
Bug: 613657, 622480 Change-Id: Ief1471c2f5830a99f9e650d7447b821c155e4a49 Reviewed-on: https://chromium-review.googlesource.com/1183900Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#584882}
-
Tommy Steimel authored
This CL adds a check in IsMouseEventOnInternalButton to make sure there is a layout view before using it. This prevents a crash in MediaControlOverlayPlayButtonElement. Bug: 870490 Change-Id: I085333c8ed6704d22b2fe8d33ef9a6e45332288e Reviewed-on: https://chromium-review.googlesource.com/1182788 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#584881}
-
Kenneth Russell authored
Neglected to use --additional-driver-flag command line arg. Bug: 875172 Change-Id: I3603e0b3659a2e6309673aad66b76a3dcb01fcc0 Reviewed-on: https://chromium-review.googlesource.com/1183884Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#584880}
-
Sky Malice authored
This reverts commit c0af3bf1. Reason for revert: Suspected cause of ios_chrome_ui_egtests failures, see https://crbug.com/876425. Original change's description: > Replace polling with callbacks in translate_ios.js. > > This should alleviate flaky errors when translating on iOS. > > When translate is tapped, translate_ios.js polls translate.js to wait > for translate element ready and then later polls again to wait for the > translation result. Polling can often time out due to network slowness. > > Bug: 869729 > Change-Id: I7e0e46fe279571f21b3aa0dd18f241dc83afee90 > Reviewed-on: https://chromium-review.googlesource.com/1178691 > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: John Wu <jzw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584549} TBR=droger@chromium.org,eugenebut@chromium.org,jzw@chromium.org,ichikawa@chromium.org Change-Id: Id0903e753c70dd43db8d4b84ba0e3bb868a65518 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 869729 Reviewed-on: https://chromium-review.googlesource.com/1183826Reviewed-by:
-
Mohsen Izadi authored
During shut down, HostGpuMemoryBufferManager singleton instance in content is destroyed before winding down the IO thread. Probably after that and before IO thread is shut down completely, there are GPU clients that might try to create GPU memory buffers. Ignore those requests. BUG=876327 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I53854f451129693a5167fe0bb21cd9d72925b585 Reviewed-on: https://chromium-review.googlesource.com/1182282 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#584878}
-
Sergio Villar Senin authored
Both are currently using URLFetcher for timezone and geolocation requests. They should use SimpleURLLoader instead to make them eventually work with the network service. Instead of having different CLs for them, we're migrating them at the same time as they're entangled, there is a dependency of geolocation in the timezone code. Bug: 872890 Change-Id: I8180a774f9fd8eaca8406328f404fb216b13180e Reviewed-on: https://chromium-review.googlesource.com/1177399Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#584877}
-
Lei Zhang authored
The WebContents for the Print Preview dialog does not perform PDF compositing. Only web pages renderers do. Also clean up print_manager_utils.h. Change-Id: I2875858d6c9513a6d920ab8ad9b603e06751ea77 Reviewed-on: https://chromium-review.googlesource.com/1182864 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Li Lin authored
Bug: b:110107505 Change-Id: I8d392135d05864eefef230ce388bcf2a1e2aefd1 Reviewed-on: https://chromium-review.googlesource.com/1182619Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584875}
-
Jérôme Lebel authored
Issue introduced with crrev.com/c/1174543 The table view now contains only one section. So the "Add Account…" cell is now part of the first section. The difference between the "Add Account…" cell and the identity cells should be make with item class. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3fabec71aa2caadc29c16bde819df712da56f0b1 Reviewed-on: https://chromium-review.googlesource.com/1183498Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#584874}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4bcaf9987acf..de8d4cb0d496 git log 4bcaf9987acf..de8d4cb0d496 --date=short --no-merges --format='%ad %ae %s' 2018-08-21 jmadill@chromium.org Optimize BindingsBenchmark::drawBenchmark. 2018-08-21 tobine@google.com Expect pass on pointcoord test on Pixel 2 Created with: gclient setdep -r src/third_party/angle@de8d4cb0d496 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I1705b2f61d163ae8aeac52ea82516d1407c283d1 Reviewed-on: https://chromium-review.googlesource.com/1183764Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584873}
-
Erik Chen authored
Iteration through observer list has been observed to add significant overhead to task processing. See https://bugs.chromium.org/p/chromium/issues/detail?id=859155#c12 for more details. Switching to a std::vector should minimize this overhead. Bug: 859155 Change-Id: I8c8851bfbb404afb948072984d399ea22882f125 Reviewed-on: https://chromium-review.googlesource.com/1182298Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584872}
-
Xiangjun Zhang authored
Add an interface to allow the Cast Media Router Provider to connect to the Mirroring Service to start a mirroring session. The extension change will be submit separately. Before then, there is no behavior change. Bug: 734672 Change-Id: I41a865313be0a96c684e519bb25d665e197e9ebe Reviewed-on: https://chromium-review.googlesource.com/1171786 Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#584871}
-
Mike Wasserman authored
Using ConvertRectToPixel yields unexpected enclosing rect bounds. (changes in dip locations can alter pixel bounds unintentionally) Instead, convert the rect origin and size pixel values separately. Bug: 871582 Test: No KSV (Ctrl-Alt-/) DCHECKs with non-1 ui/dsf scale [tablet mode]. Change-Id: Ia22ea75bb34382e323753bb173ce81b2c4b143b9 Reviewed-on: https://chromium-review.googlesource.com/1180265Reviewed-by:
-
Dale Curtis authored
Discard padding of ~166 microseconds shows up in some opus test files, which results in a print out of discard padding=(0,0) when printing in milliseconds. BUG=none TEST=none Change-Id: Ibfceddfe531e903c184c96ffa70dc2fde3e7d522 Reviewed-on: https://chromium-review.googlesource.com/1182663Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#584869}
-
Victor Costan authored
Bug: 875538 Change-Id: Ic0e1f11eb0d0dfcadd6e75ebfad5ffa60d778e2c Reviewed-on: https://chromium-review.googlesource.com/1183786Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#584868}
-
Sergey Volk authored
We support only a limited subset of a/v codecs in mpeg2ts container: H264, AAC, MP3 (see Mp2tStreamParser::RegisterPes). So adjust the mime_util codec set accordingly. Bug: internal b/110705267 Test: check isTypeSupported('video/mp2t; codecs=ac-3') on Chromecast Change-Id: Ib9bcd0e2fb06603a5a15927f6bcaf4e721a063d4 Reviewed-on: https://chromium-review.googlesource.com/1183698Reviewed-by:Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#584867}
-
Rune Lillesveen authored
If we have a white-space node before the text node with the first letter, we would try to re-attach the white-space node with an incorrect previous in-flow LayoutObject because we attach the ::first-letter after all children have been attached, not where the ::first-letter would end up in the layout tree. We don't need to re-attach whitespace after ::first-letter because: * We always create a remaining LayoutTextFragment for the text node which contains the first formatted letter. Wether the remaining text consists of white-space or is even empty. * If the LayoutObject sibling following first-letter+remaining-text consists of white-space, it would have gotten a LayoutObject when attaching the LayoutText for the text node where the first-letter comes from. That is, we will always have a LayoutObject for a white-space LayoutText sibling of a first-letter LayoutObject. Split out a separate method for ::first-letter for less complexity and cost with which WhitespaceAttacher to use. Bug: 876150 Change-Id: Ib1f34f0ba596d5fa5f1c7fcbd7c75550dd4f9d12 Reviewed-on: https://chromium-review.googlesource.com/1183231Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#584866}
-
akaba authored
LocalSurfaceId::ToString should us %u to print parent/child sequence numbers since they are unsigned integers. Bug: 876347 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Icac3ff853e97b9d8951490fdf7509dfad7449cf7 Reviewed-on: https://chromium-review.googlesource.com/1183785 Commit-Queue: Andre Kaba <akaba@google.com> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#584865}
-
Scott Violet authored
It's no longer used. BUG=837684 TEST=none Change-Id: Ia480a2594828d1e6c3a40bce7de149b9db5cd3ba Reviewed-on: https://chromium-review.googlesource.com/1183784Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#584864}
-
Xida Chen authored
In this CL, we add two test cases for the touch action rects computation, one for list without translate and the other one with it. The result shows that with PaintTouchActionRects flag, the result for these two tests are current while they are wrong without this flag. Bug: 876305 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6831496f20bb0651a0be1a7fb081067774b606ec Reviewed-on: https://chromium-review.googlesource.com/1181768 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
-
Alex Kalugin authored
In V4LocalDatabaseManager::DatabaseReadyForChecks method v4_database_ property is assigned to a new V4Database instance. >> v4_database_ = std::move(v4_database); If v4_database_ property refered to another previously asigned instance of V4Database, then it would be improperly deleted on current thread (IO), but V4Database should be destroyed with separate V4Database::Destroy(...) call. Add V4Database::Destroy(std::move(v4_database_)); call before assignemnt statement to guarantee v4_database_ property is empty when assigned. Change-Id: I0ed33bac3bbc544788ff034cfcabef8ec72b09cf Reviewed-on: https://chromium-review.googlesource.com/1182802 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#584862}
-
Jandro Alderman authored
R=pfeldman@chromium.org Change-Id: Ib16d60ee5ec23b7e6ac1e7b5f657651beeeb7168 Reviewed-on: https://chromium-review.googlesource.com/1142520 Commit-Queue: Jandro Alderman <aalderman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#584861}
-
Kyle Qian authored
Changed CrOS Nearby unit test filename suffixes from _unittests.cc to _unittest.cc for consistency. Change-Id: Ief87d0a024d7f0f482738bb46b53d7f1cdff5cbd Reviewed-on: https://chromium-review.googlesource.com/1182605Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Qian <kyleqian@google.com> Cr-Commit-Position: refs/heads/master@{#584860}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c3da6716d42d..4d95f1eb9beb git log c3da6716d42d..4d95f1eb9beb --date=short --no-merges --format='%ad %ae %s' 2018-08-21 buildbot@webrtc.org Roll chromium_revision e247d795..3e0dea7b (584490:584728) 2018-08-21 mbonadei@webrtc.org Introduce rtc_exclude_field_trial_default GN argument. Created with: gclient setdep -r src/third_party/webrtc@4d95f1eb9beb The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I673b9477ca773234c0fe61b117170a53b85db3d9 Reviewed-on: https://chromium-review.googlesource.com/1183841Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584859}
-
Takumi Fujimoto authored
The Cast icon should not be created if the Media Router feature is disabled. The enabled state should not change during runtime. Bug: 875868 Change-Id: I74c60e6549292d0ec139cfb9e29bf88de8fc66b1 Reviewed-on: https://chromium-review.googlesource.com/1181934Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#584858}
-
