- 03 May, 2018 40 commits
-
-
Paul Jensen authored
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I264fd1b0fd9275ed36a960dad24ccc048501c4e9 Reviewed-on: https://chromium-review.googlesource.com/1042929 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org> Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#555906}
-
Daniel Blakemore authored
Bug: 839445 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5193b544cc3e6db8d03b40d807c7d7f93dea94a5 Reviewed-on: https://chromium-review.googlesource.com/1043267Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Daniel Blakemore <danblakemore@google.com> Cr-Commit-Position: refs/heads/master@{#555905}
-
chaopeng authored
Currently, we only set WindowEventTarget to DirectManipulationHelper when receive DM_POINTERHITTEST. But the crash shows OnContentUpdate may come before DM_POINTERHITTEST. To prevent the crash we set the WindowEventTarget when DirectManipulationHelper create. Bug: 839338 Change-Id: I2921277178771f9124a37325a8dff47196500322 Reviewed-on: https://chromium-review.googlesource.com/1042381Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#555904}
-
Patrick Noland authored
Bug:833964 Change-Id: Ia365a3fa7aba1bedd57d38ff392a5663cd0d15c7 Reviewed-on: https://chromium-review.googlesource.com/1043086Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#555903}
-
Stephen McGruer authored
It appears like calling ResetTimeForTesting is not actually needed for this test to pass. Since it is causing flake due to the double/TimeTick round-trips (see bug), just remove it. Bug: 838676 Change-Id: Ice3e2c88e3afbdf07c52abfb8bffc9d8e0d0c8b1 Reviewed-on: https://chromium-review.googlesource.com/1042380Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#555902}
-
Sebastien Marchand authored
This class will be used to forward feature usage events to the site characteristics database. Bug: 773382 Change-Id: Ibe7197a44c68f231c7aea61c85fe2ba77c3d5076 Reviewed-on: https://chromium-review.googlesource.com/1042906 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#555901}
-
Noel Gordon authored
These commands create then mount fake USB and MTP volumes for testing. Add ASSERTs that Mount() calls on these fake volumes succeeds in test. No change in behavior, no new tests. Bug: 833834 Change-Id: I49c9a21b629cdb6285982d622e1020b6c16dee73 Reviewed-on: https://chromium-review.googlesource.com/1042005Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#555900}
-
Noel Gordon authored
Bring the FakeTestVolume comments up-to-date. Add a private helper for getting the external mount points to make Mount() simpler. FakeTestVolume could be used for testing read-only volumes, but is not currently used for that: make read-only as const bool member for now. Bug: 833834 Change-Id: I4da213998e224d3b469c8221f6902fb3f8221e25 Reviewed-on: https://chromium-review.googlesource.com/1042425Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#555899}
-
Xida Chen authored
The spec is here: https://drafts.csswg.org/css-animations/#interface-animationevent A layout test is changed to test this API. Bug: 437132 Change-Id: Ic463b19488271e1caeb78afa6120bb53f7d5e94d Reviewed-on: https://chromium-review.googlesource.com/1019383Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#555898}
-
Zach Helfinstein authored
Now Search+D, as approved by Chrome UI Review Bug: 837819 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If0c9343d95fd8da342df41a7530260455020e4e3 Reviewed-on: https://chromium-review.googlesource.com/1033928Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Cr-Commit-Position: refs/heads/master@{#555897}
-
Noel Gordon authored
Minor: the code is similar but was not formatted the same way. Make it formatted the same way for the reader's sake. Bug: 833834 Change-Id: I68f8b3b46f7d02c988e59887d1dc30f1284cbb34 Reviewed-on: https://chromium-review.googlesource.com/1042325Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#555896}
-
James Hawkins authored
For compiler protection in switch statements, etc. R=khorimoto@chromium.org Bug: none Test: none Change-Id: Icf86013c87d89b233d6bc27646bad8f79830af6e Reviewed-on: https://chromium-review.googlesource.com/1043098 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#555895}
-
Jonathan Backer authored
This CL turns removes --enable-raster-decoder and turns on RasterDecoder whenever --enable-oop-rasterization is passed from the command line when starting chrome. This is not yet true for tests. We will still use RasterImplementationGLES and GLES2Decoder if attribs.enable_oop_rasterization and attribs.enable_gles2_interface. This was done to maintain coverage of both RasterImplementationGLES and RasterImplementation. I will clean this up in separate CLs as I rip out OOP-R code from GLES2{Impl,Decoder}. TBR: achuith@chromium.org, sadrul@chromium.org Bug: 789238 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3e0bd4606c70f4bb9c52117c5aa0baa6ded37665 Reviewed-on: https://chromium-review.googlesource.com/1031012 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:Tom Sepez <tsepez@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#555894}
-
Noel Gordon authored
Minor clickNotificationButton re-org while I was running my ruler over this code. No change in behavior, no new tests. Tbr: slangley Bug: 833834 Change-Id: Ic23e13e89ab0d3a30d17d456c6c12c781fbc02f4 Reviewed-on: https://chromium-review.googlesource.com/1041368 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#555893}
-
Rohit Rao authored
Initially appbar support was added to SettingsRootTableViewController, as that was the only view controller which needed it. But now, we expect to support MDCAppBar in bookmarks screens as well, so this CL moves it to a common base class. We follow the pattern set by CollectionViewController and include an appBarStyle parameter which determines whether or not an MDCAppBar is created. BUG=839439,839450,839460 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I057b15113987d91451ca3a104aba95dd17667cda Reviewed-on: https://chromium-review.googlesource.com/1043006 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#555892}
-
Patrick Monette authored
Tbr: chrisha@chromium.org Bug: 839572 Change-Id: Iaf2a127be786efa2ce195f5b952aaecd0f1a9e74 Reviewed-on: https://chromium-review.googlesource.com/1043155 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#555891}
-
Dave Schuyler authored
This CL removes an extra application of GetBorderThicknessDip(). It was being added in GetIconAlignmentOffset() and again outside of that call. Also cleans up a todo for the same topic. Bug: 839120 Change-Id: I7687903a879dd0f2e29dc7b9090052dc7ff57442 Reviewed-on: https://chromium-review.googlesource.com/1041208 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#555890}
-
Xianzhu Wang authored
The code disabled in this CL had some side effects, e.g. left PartialInvalidationRect not cleared after PrePaintClean, and the next document lifecycle might do unexpected rect mapping while no NeedsVisualRect flag set. Bug: 836097 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib05ccfd439be78666771f8483a0b462128848c08 Reviewed-on: https://chromium-review.googlesource.com/1041570Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#555889}
-
Sergey Berezin authored
Also use iOS 10 simulator provided by the appropriate Xcode, and do not rely on legacy simulators installed on the bot. R=justincohen@chromium.org Bug: 835036 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I933dc552a030d9410550df5ac1cd0090b6508a47 Reviewed-on: https://chromium-review.googlesource.com/1028666Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555888}
-
Kevin Marshall authored
Generating a depfile from the manifest building step gives Ninja the information it needs to trigger incremental rebuilds when static assets or shared libraries have been modified. Bug: 839496 Change-Id: I15aee25e8684f9d1fd6a8ad63318cc74639237f0 Reviewed-on: https://chromium-review.googlesource.com/1043047 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#555887}
-
Pavel Feldman authored
Change-Id: I7008b98fbf392801b796517a9a442c34815b13c4 Reviewed-on: https://chromium-review.googlesource.com/1040988Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#555886}
-
Allen Bauer authored
Bug: 839534 Change-Id: I7242753e5777b15168ba8a0ff91a000a8a16c980 Reviewed-on: https://chromium-review.googlesource.com/1042624Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#555885}
-
CJ DiMeglio authored
This reverts commit 1536dfa3. Reason for revert: Causes data race in DownloadContentTest.ForceDownloadMessageRfc822Page test https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20TSan%20Tests/21108 Original change's description: > Reland "Move zygote code to service_manager" > > Relanding the move zygote to the service manager. It was breaking the > non NaCl build. > > Original description: > > "This CL moves the zygote code from content/ to > services/service_manager/zygote. This involves moving some switches from > content_switches.h to services/service_manager/embedder/switches.h and > moving some codes from content/public/common/result_codes.h to the new > services/service_manager/embedder/result_codes.h." > > Tbr: avi@chromium.org > Tbr: sky@chromium.org > Tbr: scottmg@chromium.org > Tbr: rockot@chromium.org > Tbr: slan@chromium.org > Tbr: eseckler@chromium.org > Tbr: rsesek@chromium.org > Bug: 831846 > Change-Id: I8a4ceb2fe6b402d512a2f45b7fab0735b891c578 > Reviewed-on: https://chromium-review.googlesource.com/1037633 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Scott Graham <scottmg@chromium.org> > Reviewed-by: Luke Halliwell <halliwell@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Reviewed-by: Jay Civelli <jcivelli@chromium.org> > Commit-Queue: Jay Civelli <jcivelli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555851} TBR=avi@chromium.org,sky@chromium.org,jcivelli@chromium.org,rockot@chromium.org,tsepez@chromium.org,slan@chromium.org,halliwell@chromium.org,scottmg@chromium.org,rsesek@chromium.org,eseckler@chromium.org Change-Id: If3e2d0985960aaafec57f0a6db26e6f078dd7ad9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 831846 Reviewed-on: https://chromium-review.googlesource.com/1043185Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#555884}
-
Lei Zhang authored
Change-Id: I6cf1b34580fcd29954d15c729c4f290117d9bdeb Reviewed-on: https://chromium-review.googlesource.com/1039064 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#555883}
-
Raymond Toy authored
These tests either pass on Firefox or are bugs in Firefox. Bug: 745778 Change-Id: I0a2997d5c3602f026e5cf9132a68a833c975d32d Reviewed-on: https://chromium-review.googlesource.com/1042801Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#555882}
-
Eric Orth authored
Bug: 824967 Change-Id: I4eb57d85bb057061bf12848f39127a6542ebe886 Reviewed-on: https://chromium-review.googlesource.com/1037523 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#555881}
-
Joe Downing authored
Now that all desktop platforms have a browser-level implementation for keyboard lock, it is time to remove the platform restriction for the keyboard lock BrowserTests. BUG=680809 Change-Id: Iad4ddea988069a73dd6cb31683a3a2086c753c47 Reviewed-on: https://chromium-review.googlesource.com/1042542Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#555880}
-
Yuwei Huang authored
This CL adds two UI tests: * Testing interaction with touches. * Verify touch and mouse events don't interfere with each other. Bug: 829606 Change-Id: Iaea466d8746e69ce3e2081a64b9f915440a9ef8f Reviewed-on: https://chromium-review.googlesource.com/1040775Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#555879}
-
Devlin Cronin authored
Update PermissionsData::AccessType to an enum class, and rename it to PermissionsData::PageAccess. This will help prevent accidental misuse of the enum (e.g., implicit conversion to bool, etc). Bug: None Change-Id: Ic81bf8cbcfd53e0700258413ef56d8150b23a046 Reviewed-on: https://chromium-review.googlesource.com/1042486 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#555878}
-
Pedro Amaral authored
Doing |getHeight() - getHeightMinusBrowserControls()| for the top toolbar height does not work when the bottom toolbar is present since |getHeightMinusBrowserControls()| takes into account the bottom toolbar. The correct way to get the top toolbar height is through |getTopBrowserControlsHeight()|. Change-Id: I93ec1e43b8246c4babfa8a427bd9122c0a8fb39f Reviewed-on: https://chromium-review.googlesource.com/1041218Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#555877}
-
Xi Cheng authored
This covers the code added in crrev/c/1031010. Bug: 833663, 734095 Change-Id: Iea3502b3543d076d6dc3285bea6e229320a2b980 Reviewed-on: https://chromium-review.googlesource.com/1040739Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#555876}
-
James Hawkins authored
* Added string converters for ScreenlockState and RemoteDeviceLifeCycleState * Removed 'generating EIDs' log * Removed duplicate life cycle log R=khorimoto@chromium.org Bug: none Test: none Change-Id: I40e8b5e43b1e2dc29d6542aae33b6af8b78ca722 Reviewed-on: https://chromium-review.googlesource.com/1042962Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#555875}
-
David Tseng authored
Bug: 839154 Change-Id: Iebceacd23dde5275c72d4fb6afecedb3dab75396 Reviewed-on: https://chromium-review.googlesource.com/1035207 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#555874}
-
Matthew Jones authored
This patch adds an explicit function to the SwipeableBottomSheet that determines if a touch event is inside of the sheet's toolbar. This eliminates the hack that existed previously that made too many assumptions about the height of the toolbar. Bug: 834795 Change-Id: Id195e72718ff2d37deb2891fd6264300d517352a Reviewed-on: https://chromium-review.googlesource.com/1036224 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#555873}
-
Xi Cheng authored
These tests can run on Win7 machines so enable them. Bug: 734095 Change-Id: Idcd8e426feaf1202e544db2793a50f3574bdaaed Reviewed-on: https://chromium-review.googlesource.com/1041154Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#555872}
-
Kenneth Russell authored
It's convenient to be able to specify this for both bots and in individual test suite exceptions, where it's desired to turn on a particular feature for all tests that are run on a particular bot. Detect this situation and merge them into proper comma-sorted lists. Bug: 826341 Tbr: jbudorick@chromium.org Change-Id: I11ff1c498182625dae3cfc5c2f0e5e0b4cc4bc5c Reviewed-on: https://chromium-review.googlesource.com/1042960Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#555871}
-
Maks Orlovich authored
Change for reland: The debug bot failure was because tests passed an invalid base::File to a method with a mojo_base.mojom.File --- as opposed to mojo_base.mojom.File? --- parameter type. This commits to not accepting those files, by adding an additional DCHECK on it and adjusting tests to not do that. Rationale: passing in a broken file is ultimately doing an RPC to do a lot of work that accomplishes nothing, so it's silly to support it, even if a 1-character fix CL would be easier. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1030033 Original description: S13n: Add APIs for implementing net-export in Network Service (But don't use them yet). This takes care of managing the FileNetLogObserver with a passed-in destination file, and also of all aspects of pulling state from URLRequestContexts, which browser-end NetExportFileExporter presently does but won't be able to with network service. There is one behavior difference in that respect: the in-progress entries for things that are in flight when the export is started now included all URLRequestContexts known, rather than just the main + media + system for whever the export UI is running. Given that events collected when export is active included everything already, this seemed rational as consistent, and avoiding complexity of finding the particular contexts, including the going-away media one. Bug: 767450 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ifd7f8fbcd60ec2dadf7a8b31c6b0ec67d27b9b7b Reviewed-on: https://chromium-review.googlesource.com/1037243 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#555870}
-
Dave Schuyler authored
This Cl changes spellings. There are no logic changes. (code health) Bug: None Change-Id: I28192930065af7a92fd3b4b4a47edc1eee84e989 Reviewed-on: https://chromium-review.googlesource.com/1042822 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#555869}
-
Devlin Cronin authored
If an API is called without a callback, that API may still result in an error. For instance: chrome.foo.doBar(); // May fail asynchronously! In this case, we should log the error to the console, in the same way we would for an unchecked error in the callback. This implements this for APIs invoked and resolved through the APIRequestHandler, and adds a ReportUncheckedError() to the APILastError object. This requires adding a pending request for all requests through APIRequestHandler, instead of just those with an associated callback. Also add unittests for both the new APILastError method and the full flow of logging the last error from the APIRequestHandler when a callback isn't provided. Bug: 839528 Change-Id: I42418bb968e06d27e34e3f8981468229343dc5c9 Reviewed-on: https://chromium-review.googlesource.com/1028357 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#555868}
-
Mike Wasserman authored
Move the rewriter files to ash, keep the delegate impl in chrome. Add a mojo interface for the delegate to receive and return events. Ash's controller creates the rewriter, Chrome sets the delegate. Move, expand, and refine the existing unit tests. Add TODOs to refine the rewriter/delegate/ChromeVox pattern. (the rewriter shouldn't pass events that will need to be reposted) This should allow Mash to support this rewriter in the future. (for now, Ash doesn't get Window Service events sent to Chrome) Bug: 647781 Test: No regressions with ChromeVox spoken feedback on Chrome OS. Change-Id: I4f7805298156ab9463ca3110a1e957f922c6d82b Reviewed-on: https://chromium-review.googlesource.com/1038819 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#555867}
-