GitLab

While there, remove some error messages because of incomplete test setup or incorrect fake behavior.

BUG=425049

Review URL: https://codereview.chromium.org/648623004

Cr-Commit-Position: refs/heads/master@{#300284}

This shrinks the android ChromeShell APK by 600 bytes, and improves
performance on compositor benchmarks.

Numbers can be found here https://crbug.com/407444#c15 but the summary
is this saves about 0.1ms cpu time on the JS_FULL_SCREEN_INVALIDATION
test in the thread_times.tough_compositor_cases test suite.

This also makes it easier to read and find functions in the Point and
PointF classes for developers.

R=sky
BUG=407444

Review URL: https://codereview.chromium.org/642343003

Cr-Commit-Position: refs/heads/master@{#300283}

Clicking anywhere in an entry already toggles the checkbox and this was
just messing up VoiceOver spoken feedback.

Also add aria-label to satisfy a11y audit and make voice feedback better.

R=dmazzoni@chromium.org
BUG=385344

Review URL: https://codereview.chromium.org/661043006

Cr-Commit-Position: refs/heads/master@{#300282}

The reverse writer for viewsource had an incorrect assumption about the path component of URL which was causing a duplication of query and fragment parameters. This change is to unit test the fix that  went in
https://codereview.chromium.org/655023002/

BUG=336846

Review URL: https://codereview.chromium.org/659153003

Cr-Commit-Position: refs/heads/master@{#300281}

Revert of Requiring confidence in initial regression range before bisecting. (patchset #4 id:110001 of https://codereview.chromium.org/644323002/)

Reason for revert:
Bisect is broken because the ConfidenceScore expects list of list, but here only list is passed.
http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/693/steps/Running%20Bisection/logs/stdio

Original issue's description:
> Requiring confidence in initial regression range before bisecting.
>
> BUG=422727
>
> Committed: https://crrev.com/4436048a948a2010062d3c6a171775d9389fd732
> Cr-Commit-Position: refs/heads/master@{#300196}

TBR=qyearsley@chromium.org,chrisphan@chromium.org,tonyg@chromium.org,robertocn@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=422727

Review URL: https://codereview.chromium.org/661393003

Cr-Commit-Position: refs/heads/master@{#300280}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6220dd2..7541f2d

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/646643004

Cr-Commit-Position: refs/heads/master@{#300279}

This message filter is only being used when running layout tests.

BUG=420994
R=mkwst@chromium.org

Review URL: https://codereview.chromium.org/659073004

Cr-Commit-Position: refs/heads/master@{#300278}

This deletes code that froze the animation clock when we skipped
frames because of checkerboarding. This logic was only enabled
for non-impl-side painting (to handle the case of animating very large
layers, where failing to freeze the clock would cause rasterization to
constantly lag behind, resulting in checkerboarding whenever a draw was
forced). Since all shipping renderers use impl-side painting now, this
logic is no longer needed.

BUG=None

Review URL: https://codereview.chromium.org/654203007

Cr-Commit-Position: refs/heads/master@{#300277}

This is the second step to update the Blink APIs.
To remove old Blink APIs that do not have isActive flag,
update all callers to specify the isActive flag.

The first change to add the new Blink APIs is
https://codereview.chromium.org/649683006/

BUG=279097
TBR=scherkus@chromium.org

Review URL: https://codereview.chromium.org/661323002

Cr-Commit-Position: refs/heads/master@{#300276}

This is not the right layer to do this, since it forces all test suites to have
an initialized Cocoa NSApp. Instead, only do it for test suites that require it.

BUG=71686

Review URL: https://codereview.chromium.org/656293003

Cr-Commit-Position: refs/heads/master@{#300275}

When the microphone volume is low, the pre-processed audio data contains energy, while the post-processed audio data has only 0, we report 0 as energy before this patch, which is wrong since the audio flow contains energy.

This patch fix the problem by checking the energy of pre-processed data before reporting 0 as energy.

BUG=424149
TEST=1, use a USB headset.
2, set the microphone volume low, like below 50%.
3, join a hangout call.
4, open chrome://webrtc-internals, and look at the energy of input stream, constantly it is 0 there.

Review URL: https://codereview.chromium.org/661693003

Cr-Commit-Position: refs/heads/master@{#300274}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/a71aee6..958e962

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/663133002

Cr-Commit-Position: refs/heads/master@{#300273}

    - Russian phonetic (YaZHert) keyboard
    - Russian phonetic (AATSEEL) keyboard
    - Maltese keyboard

Also support Irish keyboard as login keyboard.

BUG=173149
TEST=Verified on linux_chromeos.

Review URL: https://codereview.chromium.org/643853002

Cr-Commit-Position: refs/heads/master@{#300272}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c66ab0f..6220dd2

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/664603003

Cr-Commit-Position: refs/heads/master@{#300271}

This object is responsible for combining all attached keyboards into one
logical keyboard, applying modifiers & implementing key repeat. Key
repeat is not done yet.

We need this so we can also dispatch keypresses from gestures devices
(e.g. Logitech K400).

BUG=412996
TEST=events_unittests, link_freon

Review URL: https://codereview.chromium.org/641113004

Cr-Commit-Position: refs/heads/master@{#300270}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/93b255b..a71aee6

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/663093002

Cr-Commit-Position: refs/heads/master@{#300269}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/643373004

Cr-Commit-Position: refs/heads/master@{#300268}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ccbca44..c66ab0f

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/664103002

Cr-Commit-Position: refs/heads/master@{#300267}

The spec added 'open' and removed 'get/create'.  Delete get and create.

CLs in this three-legged-patch:

1. Add open to browser - https://codereview.chromium.org/664433003/
2. Add open (remove get/create) to Blink - https://codereview.chromium.org/638023003
*3. Remove get/create from browser - https://codereview.chromium.org/663503002/

BUG=423942

Review URL: https://codereview.chromium.org/663503002

Cr-Commit-Position: refs/heads/master@{#300266}

Also add a stub for an identity-related API as an example.

BUG=424651
TEST=app_shell_unittests

Review URL: https://codereview.chromium.org/660333003

Cr-Commit-Position: refs/heads/master@{#300265}

Use the properly-named "WebRuntimeFeatures::enableCSSViewport" method
to enable the CSS viewport feature instead of wrongly-named "setCSSViewportEnabled".

BUG=424459

Review URL: https://codereview.chromium.org/669673003

Cr-Commit-Position: refs/heads/master@{#300264}

BUG=

Review URL: https://codereview.chromium.org/655253003

Cr-Commit-Position: refs/heads/master@{#300263}

BUG=425097
TBR=zhaoqin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/668703002

Cr-Commit-Position: refs/heads/master@{#300262}

Here is the OWP tracking bug: https://code.google.com/p/chromium/issues/detail?id=422984
Here is the link to the entry on the feature dashboard: https://www.chromestatus.com/features/4871530282483712

Currently canvas clips are not antialiased which differs what what other
browsers are doing and what the users expect. This CL starts surfacing
the desired antialiased clipping behavior behind a flag
so developers can start assessing the capability.

This needs to land after the Blink CL: Plumb in flag to enable antialiased clipping in HTML 5 Canvas - https://codereview.chromium.org/652483003/

BUG=crbug.com/424291
BUG=crbug.com/422984

Review URL: https://codereview.chromium.org/650143002

Cr-Commit-Position: refs/heads/master@{#300261}

Prefix CheckLibraryLoadFromApkSupport()'s result log line with
__FUNCTION__, for logging clarity.

Remove stray empty line.

BUG=390618

Review URL: https://codereview.chromium.org/659313005

Cr-Commit-Position: refs/heads/master@{#300260}

BUG=

Review URL: https://codereview.chromium.org/661183003

Cr-Commit-Position: refs/heads/master@{#300259}

Revert of New run shell implementation for DeviceUtils (patchset #8 id:140001 of https://codereview.chromium.org/659533002/)

Reason for revert:
Broke some telemetry telemetry unittests and perf unittests

Original issue's description:
> New run shell implementation for DeviceUtils
>
> The main differences are:
> - it uses AdbWrapper.Shell to actually execute the command.
> - when the cmd is supplied as a list of a command and its arguments,
>   the arguments are quoted to prevent them from being (mis)interpreted
>   by the shell.
> - a new single_line option to check that the output produces contains a single line, and return the value of that line.
>
> BUG=267773
>
> Committed: https://crrev.com/ab18bcca0cc1475cf381211e595e75c1146c9115
> Cr-Commit-Position: refs/heads/master@{#300237}

TBR=jbudorick@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=267773

Review URL: https://codereview.chromium.org/666943002

Cr-Commit-Position: refs/heads/master@{#300258}

Cr-Commit-Position: refs/heads/master@{#300257}

When checking a class if it or its part objects don't define GC roots,
avoid looping on part objects that are cyclic. i.e., the part object
containing a collection that refers back to itself.

R=haraken
BUG=424962

Review URL: https://codereview.chromium.org/666473003

Cr-Commit-Position: refs/heads/master@{#300256}

The Web IDL spec specifies Promise<T> syntax. This CL makes the IDL parser
recognize the syntax.

BUG=421539

Review URL: https://codereview.chromium.org/653343002

Cr-Commit-Position: refs/heads/master@{#300255}

Origin database of FileSystem API performs special handling for Apps V2.
This CL updates dump_file_system to support it.

BUG=421330
NOTRY=True

Review URL: https://codereview.chromium.org/636093002

Cr-Commit-Position: refs/heads/master@{#300254}

Port all client of the NOTIFICATION_HISTORY_URL_VISITED to instead be
HistoryServiceObserver or HistoryBackendObserver depending on the thread
they want the notification to be delivered.

Delete the notification and the notification details types.

BUG=373326
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/651193002

Cr-Commit-Position: refs/heads/master@{#300253}

In particular LLVM_SYMBOLIZER_PATH is needed by asan_symbolize.py.

Also explicitly wait for test launcher to finish running and use its return
code as an overall exit code of the test. asan_symbolize.py always returns
0 (if it doesn't crash), not very useful.

BUG=424280
R=earthdok@chromium.org

Review URL: https://codereview.chromium.org/639713009

Cr-Commit-Position: refs/heads/master@{#300252}

Revert of Added quota client for serviceworker. Enables 'clear past <time> data'. (patchset #7 id:300001 of https://codereview.chromium.org/633273002/)

Reason for revert:
causing crashes https://code.google.com/p/chromium/issues/detail?id=424831

Original issue's description:
> Added quota client for serviceworker. Enables 'clear past <time> data'.
>
> BUG=419287
>
> Committed: https://crrev.com/f6916df879bf23bacf994880359c980f4249e324
> Cr-Commit-Position: refs/heads/master@{#299918}

TBR=michaeln@chromium.org,jsbell@chromium.org,sky@chromium.org,dmurph@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=419287

Review URL: https://codereview.chromium.org/654323003

Cr-Commit-Position: refs/heads/master@{#300251}

Remove unnecessary includes for forward-declared classes in both
refcounted_browser_context_keyed_service_factory.h and
browser_context_keyed_service_factory.h.

Fix other header files broken by this cleanup by addding the
missing include.

BUG=419366
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/662803002

Cr-Commit-Position: refs/heads/master@{#300250}

The telemetry test for WebRTC has so far been measuring CPU and memory.
Since there's a stats API for WebRTC (see http://goo.gl/lfQKzE), we try
to use that do extract interesting properties about the call. The
properties we look at are such that we expect them to remain stable, so
a sudden change in any of them will warrant investigation.

This implementation is based on a trick where we instrument the
constructor for webkitRTCPeerConnection. Whenever a peer connection is
constructed, we attach a polling function which periodically polls the
connection for new stats (that's how the stats API works). Then we
make it easy for a measurement to extract this data, aggregate it into
time series and report it through Telemetry.

BUG=412787

Review URL: https://codereview.chromium.org/561803002

Cr-Commit-Position: refs/heads/master@{#300249}

The comment for IPC_ENUM_TRAITS_MAX_VALUE says you should pass the largest
possible value, inclusive. But NTP_NUM_EVENT_TYPES is one larger than the
largest possible NTPLoggingEventType.

Review URL: https://codereview.chromium.org/662823002

Cr-Commit-Position: refs/heads/master@{#300248}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/468b181..93b255b

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/662373002

Cr-Commit-Position: refs/heads/master@{#300247}

BUG=425057
TBR=mflodman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/660473004

Cr-Commit-Position: refs/heads/master@{#300246}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/833fa84..ccbca44

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/666893002

Cr-Commit-Position: refs/heads/master@{#300245}