- 15 Jan, 2020 40 commits
-
-
Toon Verwaest authored
Temporary disable to be able to drop the stack trace from the SyntaxError. Other SyntaxErrors already don't have such stack trace. Bug: chromium:1042162 Change-Id: I1159d534cd7248abe658fceeb71ca9d6c1e17b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000823 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#731888}
-
Dominic Battre authored
Bug: 961334 Change-Id: I658d75079bcfa6063373d2369dec936144346a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991494 Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#731887}
-
Marina Ciocea authored
This reverts commit 9612f58a. Reason for revert: breaking linux-trusty-rel bot. Sample failure: https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/6828 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8891225736395206976/+/steps/content_browsertests_on_Ubuntu-14.04/0/logs/Deterministic_failure:_All__x2f_DumpAccessibilityTreeTest.AccessibilityInputRadioCheckboxLabel__x2f_linux__status_FAILURE_/0 [18791:18791:0114/205350.062302:INFO:dump_accessibility_test_helper.cc(98)] Expected output: /b/s/w/ir/content/test/data/accessibility/html/input-radio-checkbox-label-expected-auralinux.txt [18791:18791:0114/205350.062327:ERROR:dump_accessibility_test_helper.cc(126)] Diff: * Line Expected - ---- -------- 1 [document web] 2 ++[section] * 3 ++++[radio button] name='label ignored for radio button' checkable checkable:true * 4 ++++[check box] name='label ignored for checkbox' checkable checkable:true 5 ++++[label] name='label exposed for radio button ' label-for 6 ++++++[static] name='label exposed for radio button ' * 7 ++++++[radio button] name='label exposed for radio button' checkable labelled-by checkable:true 8 ++++++[static] name=' ' 9 ++++[label] name='label exposed for checkbox ' label-for 10 ++++++[static] name='label exposed for checkbox ' * 11 ++++++[check box] name='label exposed for checkbox' checkable labelled-by checkable:true 12 ++++++[static] name=' ' 13 <-- End-of-file --> Actual ------ [document web] ++[section] ++++[radio button] name='label ignored for radio button' checkable:true ++++[check box] name='label ignored for checkbox' checkable:true ++++[label] name='label exposed for radio button ' label-for ++++++[static] name='label exposed for radio button ' ++++++[radio button] name='label exposed for radio button' labelled-by checkable:true ++++++[static] name=' ' ++++[label] name='label exposed for checkbox ' label-for ++++++[static] name='label exposed for checkbox ' ++++++[check box] name='label exposed for checkbox' labelled-by checkable:true ++++++[static] name=' ' <-- End-of-file --> ../../content/browser/accessibility/dump_accessibility_browsertest_base.cc:442: Failure Value of: matches_expectation Actual: false Expected: true Original change's description: > A11y:Expose labels of radio & checkbox when focused. > > Currently, when a label is referenced by a control of type radio or > checkbox, we set the label as ignored in the AXTree thereby excluding > it from being perceived by ATs. > However, for the case when the control (radio/checkbox) is a > descendant of the label and label is focusable (tabindex="0") but > control is to be omitted from focus (tabindex="-1"), ATs perceive > neither the label nor the control when tabbing through the content: > > <label style="display:block" tabindex="0"> > radio button 1 > <input type="radio" id="radio1" tabindex="-1"> > </label> > > <label style="display:block" for="radio2" tabindex="0"> > radio button 2 > <input type="radio" id="radio2" tabindex="-1"> > </label> > > <label style="display:block" for="checkbox1" tabindex="0"> > checkbox 1 > <input type="checkbox" id="checkbox1" tabindex="-1"> > </label> > > <label style="display:block" for="checkbox2" tabindex="0"> > checkbox 2 > <input type="checkbox" id="checkbox2" tabindex="-1"> > </label> > > This change fixes the above scenario by exposing labels (referenced by > radio or checkbox) when they are focusable. For all other cases when > labels are referenced by radio or checkbox, we keep the existing > behavior of ignoring the label. > > Note: Neither Firefox nor Edge legacy hides a label from AT when the > label is referenced by a control. On Firefox and Edge legacy, label > content will be read twice (focus on label and focus on control > respectively). > WAI-ARIA spec does not specify label should be ignored when associated > with a radio/checkbox control. > > Bug: 1040210 > Change-Id: Ie7df5144dd2f0d285d97e6556adb46dcf2338f25 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992017 > Commit-Queue: Victor Fei <vicfei@microsoft.com> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#731820} TBR=dmazzoni@chromium.org,chrishall@chromium.org,meredithl@chromium.org,kschmi@microsoft.com,iapres@microsoft.com,vicfei@microsoft.com Change-Id: I288116c0ed48350e8a7104c8fb698b4f3214e97b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1040210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000728Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#731886}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d3e59119bcf5..0a486a62378b git log d3e59119bcf5..0a486a62378b --date=short --first-parent --format='%ad %ae %s' 2020-01-15 eseckler@google.com Merge "processor: Support TrackDescriptor's parent_uuid + pid/tid reuse" Created with: gclient setdep -r src/third_party/perfetto@0a486a62378b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3418ee6b8e872c07d2890bcb191c51ad6602b0a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002211Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#731885}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9d91492203f0..7655168e6865 git log 9d91492203f0..7655168e6865 --date=short --first-parent --format='%ad %ae %s' 2020-01-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 8b3a0fa81050..86f730971751 (12 commits) 2020-01-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src e2015449..b83f9414 (758 commits) 2020-01-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader f6d3cbb28303..146e16f68fdc (18 commits) Created with: gclient setdep -r src/third_party/skia@7655168e6865 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: mtklein@google.com Change-Id: I113b4d9c775bf2012bc82d4b8a24ac3db0ff2601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001569Reviewed-by:
-
Matt Falkenhagen authored
These are still useful. Extend by a year plus some more to reduce alerts over the new years holidays. Bug: 1039316, 1037268 Change-Id: I38af06211e4125e74b1d63a98e0104bc43fcf859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994036Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#731883}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=toyoshim@chromium.org Bug: 1041419 Change-Id: I8172a49c60fb4fe4787d8fb96a611d8f410e6280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997959 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#731882}
-
Isabella Scalzi authored
It would be good if Quick View supported multi-select (aka file-list check-select mode) reading the bug. Let's fix that. Add multi-selection support to Quick View. Also remove the now irrelevant test "cantOpenQuickViewWithMultipleFiles". Testing of this feature will be the subject of future patches. Bug: 1038799 Change-Id: If64871517bb95a7b403df98560d41c27bccf7748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994548Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#731881}
-
Hiroshige Hayashizaki authored
This CL updates generated files, reflecting changes in https://chromium-review.googlesource.com/c/chromium/src/+/1989718. This CL doesn't change test results. Bug: 906850 Change-Id: I62688ebce77a34169c661e423e3cc77285536510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992955 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#731880}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=toyoshim@chromium.org Bug: 1041419 Change-Id: If270ddb77a27dfc85b07a11b185e3f7c1e00f305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997906 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
nancy authored
This is the first CL for integrating context menus to App Service. There will be follow up for this CL to add more menus to App Service: 1. Add Radio menu items 2. Add sub menu. 3. Add menu items for Crostini. 4. Add menu items for ARC apps. 5. Add menu items for Chrome apps/extension apps. 6. Add menu items for Web apps. BUG=1038487 Change-Id: I933bb680f0f5356eb4675f648664b6280f340c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999895 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#731878}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a7d8cc39254e..997e797922ae git log a7d8cc39254e..997e797922ae --date=short --first-parent --format='%ad %ae %s' 2020-01-15 thestig@chromium.org Merge CPDF_TransferFuncDIB::LoadSrc() into the ctor. 2020-01-15 thestig@chromium.org Add a GetAlphaWithSrc() helper function. 2020-01-15 thestig@chromium.org Clean up some CPDF_TransferFuncDIB methods. 2020-01-15 thestig@chromium.org Remove some repeated checks in CFX_DIBitmap(). 2020-01-15 thestig@chromium.org Use GetAlpha() in more places inside CFX_ScanlineCompositor. 2020-01-15 thestig@chromium.org Rename CPDF_DIBTransferFunc to CPDF_TransferFuncDIB. Created with: gclient setdep -r src/third_party/pdfium@997e797922ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I4d4234e53120f0b93ce2de30237a445d9e2d7444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001566Reviewed-by:
-
Matt Falkenhagen authored
It's flaky on Windows on regular browser_tests and heavily flaky on Mojo Linux's network_service_in_process_browser_tests. We plan to make network_service_in_process_browser_tests part of the main waterfall (crbug.com/1040384), so disable it until it's fixed. Bug: 1032668 Change-Id: I5af450c5f85cfb237fa8670ca185d973e78429b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999885Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#731876}
-
Rune Lillesveen authored
Change-Id: I2fb663fb98e1d69cfd1f2eece5d4ea36a9ddd26b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998403Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#731875}
-
Istiaque Ahmed authored
Content verification currently always performs case-insensitive searches (by using lower case keys in VerifiedContents::root_hashes_, or by searching using CompareEqualsIgnoreCase in ComputedHashes) to support case-insensitive systems (win/mac). However, currently this applies to case-sensitive systems (linux/cros) as well. The effect is that a request to manifesT.json for example would return the hash of manifest.json but file read of manifesT.json would not be found. Therefore, the hashes would mismatch, incorrectly disabling the extension due to content-verification failure. This CL changes case-insensitive logic to only apply for case-insensitive systems (win/mac) and not case-sensitive ones (linux/cros). This CL also moves case-sensitivity and dot-space logic to central location under content_verifier_utils. This CL also updates test expectations for existing tests and adds a regression test for the fix. Bug: 1033294 Change-Id: Ied57039e316ce7c5e5a57fcec96f28ddeac305dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993940 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#731874}
-
Keishi Hattori authored
This reverts commit a4168673. Reason for revert: Instrumentation no longer needed. It was meant only for 1 milestone. Original change's description: > Start calling v8 API SetDetachedWindowReason > > This enables v8-side tracking of JS function calls made within a context > of a detached window. > > Such calls should be rare, but if our predictions are incorrect, the > tracking code may impact performance of function calls. Therefore, > this is implemented behind finch experiments SetDetachedWindowReasonBy* > (enabled by default, but it'll give as an opportunity to disable > tracking or limit % of participating users, if needed). > > Bug: 1018156 > Change-Id: I878e6f1fabdeb229531af688fea0a5bc7412a145 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895017 > Commit-Queue: Bartek Nowierski <bartekn@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712517} TBR=yukishiino@chromium.org,rkaplow@chromium.org,tasak@google.com,haraken@chromium.org,keishi@chromium.org,bartekn@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1018156 Change-Id: I35c58011a6ff0984c339393b083a48d13b6b3f12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000404Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#731873}
-
Eriko Kurimoto authored
In this CL, existing argument |name| is replaced by WorkerOptions#name. Other fields in WorkerOptions (#type and #credentials) are not used yet. It doesn't change any behavior. Bug: 824646 Change-Id: Iabdf68cbbd5d64389d85cef3c692d68d8134091f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990883 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#731872}
-
Eugene But authored
Bug: 921177,708795 Change-Id: Ieb7db1da861faf9cd6bf21f81df96e1a9bcfb990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999299 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#731871}
-
Sarthak Shah authored
In current case, if the view is destroyed and fling controller is trying to generate fling curve, it crashes when it calls RenderWidgetHostImpl::GetRootWidgetViewportSize to get the size of the root view. This CL fixes the issue by performing a null check for the view. If destroyed, it will not generate fling curve. Bug: 1030354 Change-Id: I81f7e7170691cbe9c8cd274d71a4825e046b78a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972609 Commit-Queue: Sarthak Shah <sarsha@microsoft.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#731870}
-
Hitoshi Yoshida authored
Added support of FrozenArray type and buffer source type. Bug: 839389 Change-Id: Iaf46dc899684ce312641dd730163af2e9b6f423b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999980Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#731869}
-
Rachel Sugrono authored
Add a test that tab-index key focus works correctly (the tab-indexable elements are cycled through in order) when Quick View is displaying a text file in its content area. Tab past the content panel to skip over checking the focus on the content webview. Bug: 907380 Change-Id: Ia800bf7a04633376d7c355e0947d2fcaa9bf72f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000281 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
This is a follow-up CL for https://crrev.com/c/1994549 Bug: 839389 Change-Id: Ifdbe8cb1a0a5cfcd3a27fc486499e2c92c1c18d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999826Reviewed-by:
-
Thanh Nguyen authored
This CL enables smart charging logging code to be used. Bug: 1028853 Change-Id: I4622a65c4520c2461df2d6e439137945a14d4d89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996120Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#731866}
-
Matthew Mourgos authored
This change adds padding to the ink drop for the first and last app buttons in the scrollable shelf. This padding is added so that when the ink drop is shown for the left-most or right-most app, the ink drop appears to cover from the behind the app to the left/right edges of the hotseat. This means that a "one app hotseat" will be completely filled by the app's inkdrop. Bug: 1035263 Change-Id: I91383bf73865f6807d878bde3afeb904ddacb3f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999767 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#731865}
-
Eric Willigers authored
The minimal-ui buttons' preferred insets and sizes were being cached before the kInternalPaddingKey property was set. This led to the Back button being too small during the initial layout if a web app initially opened maximized. We now set the kInternalPaddingKey property first, before setting layout insets. Bug: 1040792 Change-Id: I09ff4383124d304bf71ec0d3ff6e5fc9ccb6c9ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000444Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#731864}
-
Takashi Sakamoto authored
Change-Id: I5a96979b123311ed5aa4dda35c39d1eaa7bc98da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975377 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#731863}
-
Thanh Nguyen authored
Adds code to collect last charge related features. Bug: 1028853 Change-Id: I2b152139db0777acbd40534128ed8c92004799b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994035 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#731862}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a0840e9a2f6a..9b547ca554d8 git log a0840e9a2f6a..9b547ca554d8 --date=short --first-parent --format='%ad %ae %s' 2020-01-15 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-01-15 tmathmeyer@chromium.org Rolled MediaTable into EventDisplayTable 2020-01-14 anubmat@microsoft.com DevTools: Fix a zooming issue in timeline panel details view Created with: gclient setdep -r src/third_party/devtools-frontend/src@9b547ca554d8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:794255,chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie045c54d34fb92990d3804a26cf7dd1493bacf73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001567Reviewed-by:
-
Koji Ishii authored
This patch fixes bidi-reordering to compute children of inline boxes correctly. r728439 <crrev.com/c/1980663> broke the computation when two inline boxes are adjacent without any text/spaces between them, Bug: 1040884 Change-Id: I0368a94b3b2d4cabd62bd82e1114fcadabf81acc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000399 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#731860}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0c469d4541c3..d37f03fd9529 Created with: gclient setdep -r src-internal@d37f03fd9529 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iada5a81a6684c6e61351110a213661adb89c9db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001571Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#731859}
-
Hiroshige Hayashizaki authored
[1] will enable sub projects inheriting parent's `spec.src.json`, in order to generate similar but subtlely different tests. As a preparation for [1], this CL centralizes per-project configs into `spec.src.json`, by moving config values from per-project `generate.py` into `spec.src.json`. - `spec_directory` is now the current directory, or specified by the `--spec` command line option, while previously it is calculated based on the per-project `generate.py`'s path. - Script paths (`helper_js`, `sanity_checker_js`, `spec_json_js`) are now hard-coded (using `spec_directory`) in `common/security-features/tools/generate.py`. - Other config values are moved into `spec.src.json`. - `spec_json.js` is moved under `generic/`, to a little centralize generator-related files into `generic/`. Generated files are affected because: - Scripts (like `test-case.sub.js`) are now referenced as relative paths from generated test HTMLs. - `disclaimer.template` is updated. Generated files will be updated in a separate CL [2]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1991066/ [2] https://chromium-review.googlesource.com/c/chromium/src/+/1992955/ Bug: 906850 Change-Id: Id3b2a26b67296a1de2b682e07bdcf473f666cd25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989718 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Kent Tamura authored
This CL should have no behavior changes. Bug: 1040826 Change-Id: Ib240a84ea0eb1beed19e61acf4a3ce5dfa7e44db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002037Reviewed-by:
-
Xinghui Lu authored
Bug: 1037225 Change-Id: I0b3d1ed7782227a36321df0c77315f8a4e73719c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992816 Auto-Submit: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
-
En-Shuo Hsu authored
We used to treat the HOTWORD as a flag to enable DSP hardware hotwording for Google Assistant. For scenario that we pin capture stream on internal mic for board without usable DSP hotwording, we used not to enable it. With this CL, we'll always enable the flag and rely on the passed in device_id to determine if it is a DSP hotwording or not. It also sets the stream type to SpeechRecognition to enable use case specific tuning on CRAS. This change will depend on CRAS to also treat the mask flag as general HOTWORD. Corresponding change is chromium:1994813 which needs to be fixed before this. BUG=chromium:1020969 TEST=Build, deploy and check if CRAS creates the corresponding stream. Change-Id: I4faeeeccfa11c409a7bfcc177d31c7223837b4b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997003 Commit-Queue: En-Shuo Hsu <enshuo@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#731855}
-
Yutaka Hirano authored
Simplify ScrimptPromiseProperty by taking advantage of the unified heap and correctly traced ScriptPromise. With this CL, - There are nothing special for the lifetime of the promises and resolvers held by ScriptPromiseProperty. - The "holder" concept is completely gone. - The "name" concept is completely gone. - We don't need to call a V8 function in the destructor. Bug: 918913 Change-Id: Ic8631129c82da24a1ea65121707018d9ffa63521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000254 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Robert Ogden authored
This got missed in the original cleanup. Change-Id: Iaa48d54b78c18648c8a24d79cb9b3679a4e573fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988722Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=pmarko@chromium.org Bug: 1041419 Change-Id: I1be9952d103e6f1fbecb58fb15048942dd55c710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997554 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#731852}
-
Kent Tamura authored
blink::BaseCheckableInputType is the super class of blink::CheckboxInputType and blink::RadioInputType, and it has no other subclasses. This CL should have no behavior changes. Bug: 1040826 Change-Id: I706672c9ff34544adbe068f7bd16d143c98c7d05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000397 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#731851}
-
David Munro authored
Bug: None Test: CQ Change-Id: I0b1ef13b013673712abfe69f25fe2ef1dc22d3fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000438 Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#731850}
-
Kunihiko Sakamoto authored
After this patch, Web Bundles response from network without "X-Content-Type-Options: nosniff" header will cause net::ERR_INVALID_WEB_BUNDLE error. Spec: https://wicg.github.io/webpackage/draft-yasskin-wpack-bundled-exchanges.html#name-serving-constraints Bug: 1018640 Change-Id: I32632ee547ab32ea6646d0150dcc9493c374c263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992944Reviewed-by:
-
