- 17 Oct, 2018 40 commits
-
-
Daniel Bratell authored
In February a number of obsolete header files were deleted but some of them were still listed in sources lists. That might have caused isolate step errors in trybots. Bug: 778580 Change-Id: Ica026a5d157c64f07465f520a15ed2ffab92c234 Reviewed-on: https://chromium-review.googlesource.com/c/1286428Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#600492}
-
Ken Rockot authored
The CL https://chromium-review.googlesource.com/c/chromium/src/+/1145692 changes Mojo dispatch behavior and ends up breaking this test. The test is making invalid assumptions about when an InterfacePtr can expect encountered_error() to return true. This CL fixes the test be ensuring that it explicitly waits for an error to be raised on the clipboard interface before continuing. Bug: 895693 Change-Id: I17ea7f994ea9c7d672d0f200aeeaa2c404e04f3f Reviewed-on: https://chromium-review.googlesource.com/c/1286203Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#600491}
-
Jared Saul authored
(When a card accrues 3 strikes, future offers to save for that card should show the omnibox save icon, but NOT pop up the bubble. On Android, no offer to save is shown at all.) Bug: 884817 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I0d6ad27a4e03d0128970af6e22d2a40a62d0601b Reviewed-on: https://chromium-review.googlesource.com/c/1269524 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#600490}
-
Jamie Madill authored
GpuCrash_GPUProcessCrashesExactlyOncePerVisitToAboutGpuCrash This test was so flaky it was failing on the ANGLE CQ. Also affects Intel and possibly AMD. Tbr: kbr@chromium.org Bug: 878258 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I74685596e4162d1d8244ac48f60fcbd12319159d Reviewed-on: https://chromium-review.googlesource.com/c/1286892Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#600489}
-
Becca Hughes authored
If the "MediaSessionAccelerators" feature is enabled then media keys should behave as system keys. This means they will be handled in ash unless a Chrome app is overridding the behaviour. BUG=894255 Change-Id: I00d8c5a0d8e2c9f73531408f30ddeb56424ad03e Reviewed-on: https://chromium-review.googlesource.com/c/1274885 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#600488}
-
David Trainor authored
In order to properly test download home V2 from a Coordinator standpoint, we need to support building/passing in the following parameters: - Whether or not to use the legacy download path (which queries DownloadManagerService/native code that we don't want). - Whether or not to use the legacy download thumbnail path (which queries disk/native code that we don't want). - Letting tests mock out the OfflineContentProvider for a Profile. Getting rid of the legacy code path for these tests is okay because production code will soon do the same once the old code path is fully deprecated. Change-Id: I59784bc53c76b22a81fe6c4f7d43ec43ff7da298 Reviewed-on: https://chromium-review.googlesource.com/c/1277915Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#600487}
-
Philip Rogers authored
This patch makes the renderer's compositor use blink runtime feature flags to initialize the layer list setting. With this change we no longer need to separately plumb both a blink feature (i.e., BGPT or SPV2) and a layer list setting. This prevents the confusion situation of having the blink feature flags not match the compositor's layer list setting. This also simplifies the release of Blink Generated Property Trees because we can use the existing processes for transitioning a blink feature from test to experimental to stable. The primary code change is to remove the --enable-layer-lists flag and instead have render_widget.cc initialize the use_layer_lists setting from blink feature flags. This patch also cleans up some plumbing for the --enable-slimming-paint-v2 flag and adds TODOs to remove both --enable-slimming-paint-v2 and --enable-blink-gen-property-trees. Bug: 836884 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iffdefc896abb00e6692a0d77b4fde5f628cb8ff5 Reviewed-on: https://chromium-review.googlesource.com/c/1278988Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#600486}
-
Clark DuVall authored
This is in preparation for running Network Service out of process. The Network Service process will initially run as a privileged process, so we need to make sure there are enough services to handle the extra process. Bug: 872343 Change-Id: I208c9385a9d48471b2b4ae0b0b23764c18388abc Merge-With: eureka-internal/210477 Reviewed-on: https://chromium-review.googlesource.com/c/1282122Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#600485}
-
Hans Wennborg authored
And update references to FileIOClient::Status, because it's now an enum class. Bug: 895475 Change-Id: I1e0e9646416a969e87a9d34dd24b31dc0017889e Reviewed-on: https://chromium-review.googlesource.com/c/1283370Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#600484}
-
Jonathan Backer authored
This will make it easy to create a viz::RasterContextProvider from a viz::ContextProvider. TBR=sadrul@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I98255264d2a8f5d81d2fae78e7202914fd0428a3 Reviewed-on: https://chromium-review.googlesource.com/c/1286769 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#600483}
-
Sébastien Séguin-Gagnon authored
Has been disabled by default since M67. This was intended as this was a temporary fix to mitigate a bug. Bug: 851295 Change-Id: I7d7200deed7a54fdb61c4d62a683d5f4a98b2164 Reviewed-on: https://chromium-review.googlesource.com/c/1285752Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Clark DuVall authored
These were causing the bot to fail: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20Android/9538 TBR=jam@chromium.org Bug: 893570 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I342e931d51a2cc3b81224055f4b1eaafd7141f8c Reviewed-on: https://chromium-review.googlesource.com/c/1286938Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#600481}
-
Johannes Henkel authored
This adds support for protocol::Binary to the headless client API generator, so that the headless shell may take advantage of fields in the protocol that are marked binary. My overall WIP change is in here, and happy to explain more: https://chromium-review.googlesource.com/c/chromium/src/+/1244719 Bug: chromium:891377 Change-Id: I4e46d4b94ad019be62a9a31867d956b00d718adf Reviewed-on: https://chromium-review.googlesource.com/c/1285356Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#600480}
-
Fredrik Söderquist authored
We can only ever hit the same Node in this loop, so even if the query is penetrating/list-based we won't add more to the result if we would happen to hit multiple fragments. It's also easier to read and maybe slightly faster in some cases. Change-Id: I3ce41ce58ef4a188d948690b1840d66e20ac0631 Reviewed-on: https://chromium-review.googlesource.com/c/1277792Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#600479}
-
Shakti Sahu authored
This CL adds a max width for image and videos to handle screens that are too wide such as phone in landscape and tablets. Bug: 890526 Change-Id: Icd8acbe0177761c2fd684d2ab2421419857e7be9 Reviewed-on: https://chromium-review.googlesource.com/c/1282203Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#600478}
-
Josh Karlin authored
The test was supposed to verify that, when AdTagging is disabled, frames with ad urls aren't tagged as ads. This wasn't working as intended. It passed regardless of whether or not ad tagging was disabled. What the test wanted to do isn't really possible when an AdTracker isn't present, and it's not when AdTagging is disabled. Changed the test to verify that the AdTracker is not present when AdTagging is disabled. Bug: 856273 Change-Id: I6e31444774ed5c1d1a9156a2a16e92896909d8fa Reviewed-on: https://chromium-review.googlesource.com/c/1273816Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#600477}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1d8a783c9db2..78bcd2bec371 git log 1d8a783c9db2..78bcd2bec371 --date=short --no-merges --format='%ad %ae %s' 2018-10-17 jmadill@chromium.org Vulkan: Fix deleting in-use descriptor sets. Created with: gclient setdep -r src/third_party/angle@78bcd2bec371 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I4aefff962f4a6083f576903d4b22b873a842e643 Reviewed-on: https://chromium-review.googlesource.com/c/1286693Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600476}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/db22e96f..23e331fe Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3e6035923788c550e8f69f30cfcab62a81e8ed26 Reviewed-on: https://chromium-review.googlesource.com/c/1286882Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600475}
-
Asa Karlsson authored
Added for code cleanup purposes Change-Id: I55463c1c8cadc1eeac810ad25fc3892813d63d19 Reviewed-on: https://chromium-review.googlesource.com/c/1286461Reviewed-by:
-
Alexander Alekseev authored
This disables Discover App. Bug: 894095 Change-Id: I34dda9c73210f1e56aca9a9ab2ad30e5878a89bd Reviewed-on: https://chromium-review.googlesource.com/c/1286462Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#600473}
-
Christian Biesinger authored
clear() also frees the backing store of the vector. This patch replaces it with resize(0), which doesn't do that, in cases where that seems unnecessary/undesirable. R=eae@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I2e4360756d2c1a4b0adca18e3f490c46165e73cb Reviewed-on: https://chromium-review.googlesource.com/c/1286884 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#600472}
-
Elly Fong-Jones authored
This change: 1) Adds an inner WidgetObserver subclass to Button to allow Button to observe its Widget's activation state changing; 2) Introduces a notion of "visual state" to buttons, as distinct from their existing state; the visual state governs how a button is drawn. 3) Has LabelButton use the visual state to decide which image to use instead of the raw state. The end result is that when a LabelButton's Widget deactivates, that LabelButton will take on a disabled appearance. Bug: 848593 Change-Id: If5bd135c254fd36669e76fd39338dc24387602aa Reviewed-on: https://chromium-review.googlesource.com/c/1251330 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#600471}
-
Qiyu Hu authored
LEListen is not called by Android anymore BUG=b:111367421 TEST=build Change-Id: Id1fecf57810dbb75b34862ac240b8cca8a38c570 Reviewed-on: https://chromium-review.googlesource.com/c/1281684 Commit-Queue: Qiyu Hu <qiyuh@google.com> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#600470}
-
Lukasz Anforowicz authored
Setting a new window's opener to null and navigating it cross-site used to be a hint to Chrome that it was safe to open the link in a new process. Now that Site Isolation is enabled by default on desktop, cross-site links will always open in a new process, making this unnecessary there. For cases where Site Isolation is not enabled, it is better to use target=_blank rel=noreferrer (or rel=noopener) than this old, non-standard heuristic. See: https://blog.chromium.org/2009/12/links-that-open-in-new-processes.html Bug: 892212, 892375, 884383 Change-Id: I50422cb6bd97f8e0f1d4ef082551ecb355ae104b Reviewed-on: https://chromium-review.googlesource.com/c/1262089Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#600469}
-
Adrienne Walker authored
This is according to the gpu spec, and should fix a crash during context lost. Bug: 878258 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Icabb95055de11c7a743144288898428ecd36bc90 Reviewed-on: https://chromium-review.googlesource.com/c/1285317Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#600468}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b01628451a54..a358d622339d git log b01628451a54..a358d622339d --date=short --no-merges --format='%ad %ae %s' 2018-10-17 tikuta@google.com Remove unused lambda capture Created with: gclient setdep -r src/third_party/pdfium@a358d622339d The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:681136 TBR=dsinclair@chromium.org Change-Id: Ic8928806baf7dfcb8666a43877fb30e91c488540 Reviewed-on: https://chromium-review.googlesource.com/c/1286698Reviewed-by:
-
Ben Wagner authored
If a user has an args.gn which specifies an argument which isn't actually used in the build, gn will output a warning on stdout (instead of stderr) but otherwise continue as normal. Then gen_fuzzer_owners.py in GetSourcesFromDeps will add a number of 'sources' which are actually lines from the warning message. This leads to difficult to diagnose errors later on. Since there is no means to suppress this warning nor move it to stderr, this change adds '--fail-on-unused-args' to the gn command so that the owner finding will fail earlier and and more obviously. Change-Id: I617fe3b500ada13323b77bb18c8e40b256144833 Reviewed-on: https://chromium-review.googlesource.com/c/1286731Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#600466}
-
Philip Rogers authored
In https://crrev.com/600111 we added logic to automatically stop truncation when logging on android. This patch removes a workaround that avoided truncation in LayerTreeHostImpl. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3f9547a5d9efb5a3f9c0123019d2eb8307daa6a6 Reviewed-on: https://chromium-review.googlesource.com/c/1286353Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Lei Zhang authored
It fuzzes PDFium's core/fxcrt/xml code, which is in non-XFA builds. Change-Id: I95e53ca24f4a6e298d88315dbb8e013cf6d7e06f Reviewed-on: https://chromium-review.googlesource.com/c/1286429Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#600464}
-
Joe Downing authored
In order to invoke common platform tasks (send attention sequence and lock workstation), CRD currently relies on injecting key events on the client and picking them up on the host. There is a listener which tracks the current key events and then calls the platform API once it sees the trigger. The problem with this approach is if there is a stuck key (i.e. we fail to send a key up event) then this functionality is broken. While we should fix bugs which cause lost key events, we should also look for ways to prevent issues like that from affecting other features. My change allows the client to send a single message to invoke an action like LockWorkstation() or SendSAS() which will then be executed in the user's session. The change is targeted at the Windows multi-process architecture but I've used interfaces to allow for other platforms to use it (similar to how InputInjection and the other event protos are used) if we decide to implement it in the future. This CL sets up the plumbing to get the request from the network process to the desktop process on Windows. There will be a follow-up CL which adds the WebRTC data channel and ClientSession integration. Bug: 892434 Change-Id: Iedfe8c4778fbaacacc68754c6d24e7fd485b0407 Reviewed-on: https://chromium-review.googlesource.com/c/1266100Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#600463}
-
Jun Mukai authored
It seems this is stable recently with the current filter. Let's run under the main waterfall. BUG=883523 TEST=none Change-Id: Ia14281c1e5a276c5057ae7653547086347c3ee0c Reviewed-on: https://chromium-review.googlesource.com/c/1285055Reviewed-by:
-
Brian Osman authored
Change-Id: Ibcdfdca10c62b1d7327526483582a6022d57bd11 Reviewed-on: https://chromium-review.googlesource.com/c/1286734Reviewed-by:
Mike Klein <mtklein@chromium.org> Reviewed-by:
-
Eugene But authored
This CL fixes NavigationContext::IsRendererInitiated for reloads and WebStatePolicyDecider::RequestInfo::transition_type for browser-initiated navigation. Bug: 676129, 725239 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I608b208d204bc055fcfd6c34dd7bd2a04b9c232a Reviewed-on: https://chromium-review.googlesource.com/c/1282448 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#600460}
-
Marcin Wiacek authored
Fix for error during creating chrome_public_apk: In file included from gen/chrome/browser/browser_jumbo_17.cc:42: ./../../chrome/browser/android/explore_sites/image_helper.cc:22:11: error: redefinition of 'kFaviconsPerCategoryImage' const int kFaviconsPerCategoryImage = 4; ^ ./../../chrome/browser/android/explore_sites/explore_sites_service_impl.cc:27:11: note: previous definition is here const int kFaviconsPerCategoryImage = 4; ^ 1 error generated. Example compilation settings: target_os="android" target_cpu="arm" enable_nacl=false symbol_level=0 remove_webcore_debug_symbols=true is_debug=false dcheck_always_on=false is_component_build=false use_jumbo_build=true BUG=895593 Change-Id: Ic9eaae0239fd4ab53a357df7dff2143b0cc921c4 Reviewed-on: https://chromium-review.googlesource.com/c/1285056Reviewed-by:Cathy Li <chili@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#600459}
-
Peter E Conn authored
Bug: 873178 Change-Id: I03f3a4dcc4798e8d1c1705c65cc4c7efde37a00b Reviewed-on: https://chromium-review.googlesource.com/c/1278845 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#600458}
-
Kevin McNee authored
We have touchpad pinch on Windows and CrOS in addition to Mac (and Linux shares all the necessary code to run the test). So we no longer restrict this test to running on Mac. Bug: None Change-Id: Iaa3715b2a5de9c5264b22b282e1a9bca48ea4385 Reviewed-on: https://chromium-review.googlesource.com/c/1286871Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#600457}
-
Eric Stevenson authored
Fix suggested by Tiger in crrev.com/c/1240503. Change-Id: Id7881a60bcc62bf0526c82e80b469db03e350044 Reviewed-on: https://chromium-review.googlesource.com/c/1286929Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#600456}
-
Daniel Bratell authored
scheduler/util/thread_type.h was deleted in January but the reference to it in BUILD.gn remained. Now that seems to make the isolate step in trybots sad. Bug: 776416 Change-Id: Iff685c54def879a8c5a53c9893f1c7eef4c9c13c Reviewed-on: https://chromium-review.googlesource.com/c/1286851 Commit-Queue: Daniel Bratell <bratell@opera.com> Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#600455}
-
Clark DuVall authored
Blob URLs are ephemeral, so it doesn't make much sense to allow redirecting to them. See comments on crrev.com/c/1277785 for more info. Change-Id: Iae31dc04f1ad4042d2b6861e05ca53699a3a31a6 Reviewed-on: https://chromium-review.googlesource.com/c/1278132Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#600454}
-
Min Chen authored
We should drop the drag window into overview if it has been dragged further than half from the top of the work area to the top of the drop target. The old logic consider the drag distance based on the top of the display is not correct. Since the top of the display is not always equals to the top of the work area. e.g, enable dock magnifier will put a magnifier window in the top area of the display which will change the work area. Bug: 866680 Change-Id: I8b31c68501a36ed7fd82650a93145475f8c84e5c Reviewed-on: https://chromium-review.googlesource.com/c/1285353 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
-
