GitLab

The approach taken here is identical to IOThreadRun() in
browser_process_sub_thread.cc

R=fdoray@chromium.org

Bug: 839525
Test: Locally inspect stack in debugger in a Release build.
Change-Id: I409623f98dacef908cc6c1685fa2508041c78042
Reviewed-on: https://chromium-review.googlesource.com/1044496
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556139}

Change-Id: Ida3dfde73bcf3196b91c1f68ceca31a12da0273b
Reviewed-on: https://chromium-review.googlesource.com/1044530Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#556138}

Bug: 830949
Change-Id: I28e7a998ad712181b358cfc121517e5b43b384ce
Reviewed-on: https://chromium-review.googlesource.com/1044525
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556137}

The original tests pass non-thread-safe objects across threads which
could easily break.

This CL:
1. Adds 'storage_partition_test_utils.h/cc'.
2. Adds |IOThreadSharedURLLoaderFactoryOwner| which lives on UI thread
   and owns a |SharedURLLoaderFactory| on IO thread.
3. Moves related tests into 'storage_partition_impl_browsertest.cc' to
   make sure they run w/ and w/o Network Service.

This patch doesn't have behavior change.

Bug: 826869
Change-Id: I23d636b079d72627f8944dd61892d72f175e0c7d
Reviewed-on: https://chromium-review.googlesource.com/1033806
Commit-Queue: Chong Zhang <chongz@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556136}

Currently, the androidUseRunningapp flag only works on Android WebView
apps. This commit fixes it to work on Chrome as well.

Bug: chromedriver:2369
Change-Id: I4c53f65d84e930ed5eac86396a8aa60ae4f2e200
Reviewed-on: https://chromium-review.googlesource.com/1043062
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556135}

ElementVisibilityObserverTest was using PageTestBase and would
have been tricky to fix properly; instead just migrate it over
to use FrameTestHelpers::WebViewHelper.

PresentationAvailabilityTest is left as a V8TestingScope for
now but should ultimately be converted as well.

Bug: 700783, 734748
Change-Id: Ic73f187a2a1082891168143e37675a763f80db2c
Reviewed-on: https://chromium-review.googlesource.com/1038142Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556134}

There are two platform-specific implementations that share common code
at the beginning and the end. Also fix some nits in the file.

Change-Id: Ibbb18aac8e08f6c9dbaac3c4c4d95369f0dcdbf4
Reviewed-on: https://chromium-review.googlesource.com/1043280Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556133}

Bug: 838756, 838822, 837092
Change-Id: I9f7fcb79a8305632ca264324f69aee1ae7d2ac71
Reviewed-on: https://chromium-review.googlesource.com/1042868Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556132}

Right now TestOptionsProvider tries to intercept transfer cache usage
for images, which invalidates a lot of the assumptions made by the
calling code. Instead change this to create and store transfer cache
entries similar to production behaviour.

Also remove some asserts from TransferCacheTestHelper. Since this is
used by fuzzers, it should behave more like production code.

R=enne@chromium.org
BUG=839304

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ifd0f25dd4ef13872245717b85ef8b9bd5df3c1d0
Reviewed-on: https://chromium-review.googlesource.com/1043526Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556131}

This reverts commit 5f1039f1.

Reason for revert: multiple tests on Chrome OS became flaky because of disk I/O errors.

Original change's description:
> predictors: Enable the new preconnect predictor by default
> 
> The old predictor is automatically disabled when the new one is enabled.
> 
> Change-Id: Ia5c1a79dbeb0e096720fc3d50da3dc707b3761a6
> Reviewed-on: https://chromium-review.googlesource.com/1042388
> Reviewed-by: Egor Pasko <pasko@chromium.org>
> Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#555766}

TBR=pasko@chromium.org,alexilin@chromium.org
Bug: 839886

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I8c286f29cee249990c57486851842e4d9dd900ac
Reviewed-on: https://chromium-review.googlesource.com/1044326Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556130}

Change-Id: I75500b5732b6d7d4bd7bd8aad4de12646ea789c5
Reviewed-on: https://chromium-review.googlesource.com/1043253Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556129}

https://chromium.googlesource.com/catapult.git/+log/f0ae6bb58a45..53d9b3ced389

$ git log f0ae6bb58..53d9b3ced --date=short --no-merges --format='%ad %ae %s'
2018-05-04 bpastene telemetry: Increase default ssh connection timeout on CrOS.

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:839187


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: If84e0cb1aab60edcb0122f2ab550741a3e01e7ea
Reviewed-on: https://chromium-review.googlesource.com/1044645
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556128}

This CL:
1. Fixes |AudioOutputAuthorizationHandlerTest| by using
   |net::TestURLRequestContextGetter| (The original code has an
   use-after-release issue, see bug for logs).
2. Fixes |RenderProcessHostUnitTest| by returning a valid pointer in
   |TestBrowserContext::CreateRequestContextForStoragePartition()|.

This patch doesn't have behavior change.

Bug: 826869
Change-Id: I05982ce49a9d42029cc3278fa248587820790d74
Reviewed-on: https://chromium-review.googlesource.com/1026986
Commit-Queue: Chong Zhang <chongz@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556127}

This is a reland of 6f0b5d97

A baseline is added for a test that no longer (always) times out because
of this fix. The test has a few failing subtests so a baseline is needed.

Original change's description:
> [blinkpy] Find manifest items for tests by URL
>
> When running WPT in web_tests, test names are more like URLs instead of
> file paths (to be precise, the part of a test name after external/wpt is
> a WPT URL), because WPT can generate multiple tests (variations) for a
> single test file (e.g. .any.js, ?run_type).
>
> Therefore, when asking questions like "is a test slow?", we need to find
> the manifest item for that test by URL instead of by file path; whereas
> if we want to know if a file in external/wpt is a test file, we find
> the manifest item(s) for that file by file path.
>
> This CL separates the two types of manifest queries, and chooses the
> correct one for each call site. Besides, unit tests are improved to
> cover the WPT variations (.any.js & ?run_type).
>
> Bug: 831975, 800570
> Change-Id: I230d5ec7df06b7df1387da1b93788d6cae55d153
> Reviewed-on: https://chromium-review.googlesource.com/1043160
> Commit-Queue: Robert Ma <robertma@chromium.org>
> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556043}

Bug: 831975, 800570
Change-Id: I65e818473153b134af8dc78677b1b678d196aada
Reviewed-on: https://chromium-review.googlesource.com/1044586Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556126}

ChromeLauncherControllerWithArcTest.ArcAppPinPolicy is flaking currently.
Disabling as the team who owns the root cause is OOO.

TEST=ChromeLauncherControllerWithArcTest.ArcAppPinPolicy
TBR=skuhne@chromium.org

Bug: 839916
Change-Id: I86209df361ab53cb84225363c39b1c83db197a2f
Reviewed-on: https://chromium-review.googlesource.com/1044655Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556125}

This CL also adds support in MediaStreamTrack.applyConstraints().

Drive-by: Minor lint fixes.

Bug: 833333
Change-Id: I8636def42d9ed64c6f58777d44343e569e541bfb
Reviewed-on: https://chromium-review.googlesource.com/1021570Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556124}

https://skia.googlesource.com/skia.git/+log/4824ed05ac12..05cfcff70ced

$ git log 4824ed05a..05cfcff70 --date=short --no-merges --format='%ad %ae %s'
2018-05-04 caryclark Reland "remove obsolete color defines"
2018-05-03 bsalomon Make the src rects of truths in SkLatticeIter be integral.
2018-05-04 halcanary SkExecutor: use SkLeanWindows.h
2018-05-04 borenet [infra] Remove PDFium bot and associated recipe code

Created with:
  roll-dep src/third_party/skia
BUG=chromium:b/77917978


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: I1981e0b753e8046f7646b3d0c4bf1fdce1085310
Reviewed-on: https://chromium-review.googlesource.com/1044526
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556123}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7c592e6301d6..6cee97214012

$ git log 7c592e630..6cee97214 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src-internal
BUG=chromium:838156


The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: If8450122e9a166a0587e8fc219b6d89bfb2a2a77
Reviewed-on: https://chromium-review.googlesource.com/1044280
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556122}

startProfiling and stopProfiling allow a developer to generate a cpu profile
of the renderer process over an arbitrary time slice.  For example, to profile
scrolling performance from devtools:

> chrome.gpuBenchmarking.startProfiling("scrolling-profile.pb")
> chrome.gpuBenchmarking.smoothScrollBy(
    (document.scrollingElement.scrollHeight
     - document.scrollingElement.clientHeight),
    () => { chrome.gpuBenchmarking.stopProfiling() })

R=dtapuska@chromium.org,bokan@chromium.org

Change-Id: I70a00f91a6b8f0241be4426bec167cfbc3fc5ec2
Reviewed-on: https://chromium-review.googlesource.com/1042871
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556121}

Bug: 832961
Change-Id: I9fbd8813dabbc18a44335e20f4b52194e9c685a1
Reviewed-on: https://chromium-review.googlesource.com/1041163Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Nik Bhagat <nikunjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556120}

When the SD card is full, we show an error notification as well as an
location dialog. This CL adds the string resources used in error
notification for M68, also adds the new download header string for
disk space info.

TBR=wnwen@chromium.org

Bug: 792775
Change-Id: Ide2ee1a0be020942ad940df05940c98d2231da6e
Reviewed-on: https://chromium-review.googlesource.com/1040245
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556119}

TBR=ellyjones@chromium.org

Bug: 828031
Change-Id: Ie739ea45ac1f9088a52ead63c2f805eb88dec5fe
Reviewed-on: https://chromium-review.googlesource.com/1044649Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556118}

This change makes the icon.. less overwhelming. It will be smaller than
the minimum window size. Also, as many screen sizes are not very large
(e.g. 13-15'' laptops or 24'' monitors), and the non-scaled control
appears much more prominent than needed.

We've received some initial feedback that the icon appears very
in-your-face.

BUG: 836389
Change-Id: I593cecf2bfe167765319ee2c35920d7f224fafe6
Reviewed-on: https://chromium-review.googlesource.com/1043650
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556117}

This patch increases the minimum width of the tab from 68px to 160 px.

Bug: 826380
Change-Id: I3aa3e96b09784bec3ed4e6b647f57785e7bac128
Component: Tabs, layout constant
Reviewed-on: https://chromium-review.googlesource.com/1044495
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556116}

Crash was cauded by a null experiment, which is something we handled
elsewhere but not in this particular code. Also adds a unit test is
able to trigger the crash before the fix, although I'm not very
convinced this is the exact edge case from the wild (but either
way the fix should apply to both).

Also adds some comments about some code that was a bit confusing.
One is about using the previous group for kill switch type and
another about the threading when simulation.

Bug: 837540
Change-Id: If93f4658cd18019f3f40c82ec3172d10f61356f3
Reviewed-on: https://chromium-review.googlesource.com/1036104Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556115}

The icon displayed next to the 'Emoji & Symbols' item in context
menus for text-editable fields is removed. Also updates the
enable-emoji-context-menu flag to indicate availability for Mac.

Bug: 839900
Change-Id: Iee6a6f583d66eb17a5d6cd1062d5b61a12f63d12
Reviewed-on: https://chromium-review.googlesource.com/1041221Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556114}

This CL improves the after-Cut text processing to reliably handle the
Cut case when Steady State Elisions is on.

Previously, the logic relied on IsSelectAll, which doesn't work
correctly in the Cut case. Now it just compares the contents of the
paste buffer vs. the current page's display URL.

This also has the side benefit of simplifying the API.

It also updates a test to explicitly check a Steady State Elisions
case.

Bug: 838159, 797354
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iae3ee431051e2f7bbbf63a0b87e82b7f363213aa
Reviewed-on: https://chromium-review.googlesource.com/1040912Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556113}

ForegroundedOrClosedTest.SingleTab has started to flake on ChromeOS. This
disables the test until the cause can be found.

TEST=ForegroundedOrClosedTest.SingleTab
TBR=fdoray@chromium.org

Bug: 839886
Change-Id: I650bc975a9e4795218eb205a628d3c604f7fcdcf
Reviewed-on: https://chromium-review.googlesource.com/1044533Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556112}

Wrap up the checkerimaging finch trial and make checkerimaging an opt-in
only feature used if an image has async=true specified.

R=chrishtr@chromium.org, piman@chromium.org

Bug: 728273
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I4d452ddce51e063f8769523694236b9e20632b4b
Reviewed-on: https://chromium-review.googlesource.com/1041147Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556111}

Bug: 826341
Change-Id: Ifd2630580efceffab3b73e617e031c32a3a1be13
Reviewed-on: https://chromium-review.googlesource.com/1040947
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556110}

This refactor was done to allow for greater granularity for internal LifecycleUnit state representation.

Change-Id: I27c20eec8e5fe7f1365b64fe87b32cfdf124fbb8
Reviewed-on: https://chromium-review.googlesource.com/1041010
Commit-Queue: Varun Mohan <varunmohan@google.com>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556109}

Change-Id: I042880a6b33e52f88f31f2b4c1dce44ad71677f1
Reviewed-on: https://chromium-review.googlesource.com/1043653Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556108}

This is the One-BuildBot-Step version of this change:
https://chromium-review.googlesource.com/c/chromium/tools/build/+/1038751

It will be safe to land once
https://chromium-review.googlesource.com/c/catapult/+/1029170 rolls into
Chromium.

Bug: catapult:#4397
Change-Id: I2358970703782a2d09940e580d7e8b06ea910726
Reviewed-on: https://chromium-review.googlesource.com/1038783Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Ethan Kuefner <eakuefner@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556107}

Changes:
Design doc: go/arc-app-shortcuts

Launch app shortcut has to be called by Android's LauncherApps'
startShortcut API. Thus provide a mojo API to do the work.

Bug: 803291
Test: tested on device with ag/3997639
Change-Id: Idece1c44836a9e43932b700b81d128883c15666d
Reviewed-on: https://chromium-review.googlesource.com/1041574
Commit-Queue: Qiang Xu <warx@google.com>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556106}

It always returns true.

Change-Id: I25fee275c7c970dceb00dc13bd74abf1e72cea26
Reviewed-on: https://chromium-review.googlesource.com/1043053Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556105}

Simplify some code too.

Change-Id: I94dbf05f1090ee7d3ecd88e8e6ef7edd778494c2
Reviewed-on: https://chromium-review.googlesource.com/1043361Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556104}

Follow-up to v8 CLs:
 - https://chromium-review.googlesource.com/c/v8/v8/+/941946
 - https://chromium-review.googlesource.com/c/v8/v8/+/941442
 - https://chromium-review.googlesource.com/c/v8/v8/+/941944
 - https://chromium-review.googlesource.com/c/v8/v8/+/1033584
 - https://chromium-review.googlesource.com/c/v8/v8/+/978443

This will make Platform::CallBlockingTaskOnWorkerThread() actually
result in a high-priority task which is expected to help blocking
parallel GC tasks get ahead of other async work.

And allow removal of deprecated "background threads" APIs in
v8::Platform.

Bug: 817421
Change-Id: Idb7f369538c23c9b065d90cc5ed48300a5c9724c
Reviewed-on: https://chromium-review.googlesource.com/957761Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556103}

In future, SkiaRenderer will only use SkDDL to draw frame, and the
SkiaOutputSurfaceImpl will handle vulkan related stuff. So the
SkiaRenderer doesn't need to know vulkan anymore.

Bug: 838899
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Id611e02b4e20c318e202927fa6de8f9e548f4b81
Reviewed-on: https://chromium-review.googlesource.com/1039685Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556102}

If the bookmarks UI was displayed before the BookmarkModel was done
loading, we would incorrectly cache a pointer to a BookmarkNode that had
been destroyed.  Instead, do not set the root node of the
BookmarkHomeViewController until after the model has finished loading.

BUG=839883
TEST=See repro steps in bug. Displaying the Bookmarks UI immediately upon startup should not crash.

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I062171c6d588da6be666b92e0c961abb90f1af17
Reviewed-on: https://chromium-review.googlesource.com/1044353Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556101}

This will permit a later cl to remove this flag and update the
cc_unittests LayerTreeHostFiltersPixelTest.BackgroundFilterBlurOutsets
at the same time.

Bug: skia:7765
Change-Id: Ibd631f0d2fa503f452d799a59d75bbcbb79268a4
Reviewed-on: https://chromium-review.googlesource.com/1044113Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Robert Phillips <robertphillips@google.com>
Cr-Commit-Position: refs/heads/master@{#556100}