- 09 Apr, 2019 40 commits
-
-
David Benjamin authored
These are, in various error conditions, surfaced to users so they should be HTTPS. Remove the URL for the mobile-web-app-capable console warning as that URL is dead. (See review discussion.) Bug: none Change-Id: I9387d0c37a787c24215ef7e9677323a770dbde31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549748Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#649201}
-
Andrew Xu authored
The reason of being reverted: AppListControllerImpl::profile_id_ is expected to be initialized by Chrome process through mojo. However, SpokenFeedbackAppListTest is not end to end. As a result, that attribute is left without initialization and it always crashes during memory test.The updated CL assigns the initial value to |profile_id_|. The following contents are the original description: In multi-profile mode, each profile has its own ChromeAppListModel- Updater instance. However, the mojo callings from Ash side to access the app list item in Chrome side do not specify the target model updater instance. Instead it assumes that the target instance is always associated with the current profile. This assumption proves false in some edge cases. This CL does a quick fixing: use the additional parameter in mojo callings to specify the target. See the doc below for more details. Test: browser_tests Bug: 939755 Change-Id: Ia7e99d0d0261a4dc6bcd13fbf06732d98c674e62 Doc: https://docs.google.com/document/d/1MiTiaebjAviMav8CUs5XWbEnVOhJDpPo0iBU8YbdHkA/edit?usp=sharing Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559117Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#649200}
-
Yuwei Huang authored
This CL is to allow the SSO authenticator to cache the auth token and invalidate it. It: * Adds -(void)invalidateCache to RemotingAuthentication for invalidating cache. * Hooks IosOauthTokenGetter::InvalidateCache() to [RemotingService.instance.authentication invalidateCache] * Implements invalidateCache in RemotingOauthAuthentication, which is used by the Chromium build. Note that this CL must be checked in AFTER the internal CL: https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/1159191 Bug: 950228 Change-Id: Ibf6f46e116266a16100dc4034783324fbac4ba3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558718Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#649199}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/072a6f14b64c..3d77140b9d58 git log 072a6f14b64c..3d77140b9d58 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 aluo@chromium.org Uninstall system packages even if their installed status is false. Created with: gclient setdep -r src/third_party/catapult@3d77140b9d58 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:949448 TBR=skyostil@chromium.org Change-Id: I067294d8f1a122429aa1e90e8017b353ee29ce62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559847Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649198}
-
Devlin Cronin authored
Remove the webstore.json file. Inline installation is no more (and has been gone for quite some time). Bug=882045 Change-Id: I9eef84ff49bd2ea3c0c1df7772cc90416fd699c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559231 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#649197}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3ef631ecd110..69a3f230f57f git log 3ef631ecd110..69a3f230f57f --date=short --no-merges --format='%ad %ae %s' 2019-04-09 shapiroc@chromium.org chromite: Don't test bvt-arc on non-arc 2019-04-09 shapiroc@chromium.org chromite: Fix invalid key-id path Created with: gclient setdep -r src/third_party/chromite@69a3f230f57f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: If562bc91cd9e15c65afa8735018138430491e565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560062Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649196}
-
Tanja Gornak authored
BUG=801985 Change-Id: I9fe5891fb8d30f869e2e53f6c915c89ee109d50a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547848 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#649195}
-
Sinan Sahin authored
Bug: 947749 Change-Id: If0703ff3f92bac66fde57c6a81e725e47d0f903a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554180 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#649194}
-
Camille Lamy authored
Original commit message: This is a preparatory CL for enforcing having a valid NavigationRequest at commit time. It makes clearer when NavigationRequests are deemed non-valid, and when a new NavigationRequest must be created at commit time. Bug: 943610, 942515 Change-Id: Idde1784bdcd55a782c74636d610b4c0da00d5286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530866 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Auto-Submit: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#649193}
-
Ayu Ishii authored
IdleDetection allows sites to observe user idle status. Before launching this feature, we want to add a kill switch that can be set from server side that lets us turn off the feature in case where there is a security or privacy problem. Bug: 947707 Change-Id: Ic44fcaf6ed2ce5f5ae5026fc8040be1b51dac26f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548035Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#649192}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6cdf3dcae851..cce609cb3785 Created with: gclient setdep -r src-internal@cce609cb3785 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: If6251a793fbfdff1998b0c1068b70ee72fb42540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558761Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649191}
-
Olivier Robin authored
This is needed by internal classes. Bug: 950898 Change-Id: I50f784c8656b3e330f412c741acfc3625cc8590b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559957 Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#649190}
-
Yann Dago authored
The management page should feel like a subpage of the settings page even if it is not embedded in the settings page. This feel is made by modifying the title and subtitles, but also adding a navigation back to the settings page. Bug: 948256 Change-Id: I04e10a31a6da0066e4d94f67fecc8ea6346d364c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548136 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#649189}
-
Ben Pastene authored
Its machines were upgraded to 10.13 a while ago, so it's been unable to target any of them since. R=jbudorick, martiniss Bug: 945337 Change-Id: I9e85241384f9c2b0121a4570364888ba776c0808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559886Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#649188}
-
Mikel Astiz authored
The function parses a proto that can grow large (depending on the number of bookmarks), so we should understand better whether this causes jank due to blocking the UI thread. Bug: 950869 Change-Id: I9eb5283f24a0487b55ca89bb8f78e5561d386f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559135Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#649187}
-
Charlene Yan authored
Bug: 912970 Change-Id: Iee4fedf8ef8de9691cb7d4a5156f4bacf473c864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558726Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#649186}
-
Kush Sinha authored
Chrome OS Account Manager's account addition dialog allows users to open an incognito window, if they do not want to add a Secondary Account. This is initiated by Gaia by sending a 'showIncognito' message. Please check the comments around https://issuetracker.google.com/114214633#comment29 for context. Bug: b/114214633 Change-Id: Ida1f6093b2a141eccf6aff2b20bfc74fe7fe296c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556835 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#649185}
-
Will Harris authored
https://helpx.adobe.com/security/products/flash-player/apsb19-19.html BUG=412078 TBR=jschuh@chromium.org Change-Id: Ic6abbb6934b3d7d566559c42135a234f6ab3b79c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559881Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#649184}
-
Miguel Casas authored
Smart rebase-reland of crrev.com/c/1554298: some presubmit was upset because the same OWNERS Component mapped to several Teams. This CL rewrites the ShapeDetection-related OWNERs to point to TEAM:device-dev@ and Component:Blink>ShapeDetection Also mcasas@chromium.org is marked as legacy owner. Bonus: The component Blink>Location is corrected to Geolocation. Bug: 950949 Change-Id: Id90a4245cd7ba55b73301be894a62c16246c7c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559895Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#649183}
-
Collin Baker authored
This test is timing out on the Linux CFI bot. TBR=wychen@chromium.org Bug: 950643 Change-Id: Id26c9c881dc410c20161452cdfe6d54cefe86cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559882Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#649182}
-
Collin Baker authored
Bug: 950995 Change-Id: I633c478c097f5a34edd586abf7ee0135ef04d89c TBR=pmarko@chromium.org Change-Id: I633c478c097f5a34edd586abf7ee0135ef04d89c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560136 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#649181}
-
Sinan Sahin authored
Bug: 944632 Change-Id: I766d30e56d8a663acfccde9f42e905413f6ffb11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559169Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#649180}
-
Elly Fong-Jones authored
Bug: None Change-Id: I9b1b20766f9b9f3899269090a26e8bc63e6353b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560134 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#649179}
-
Sinan Sahin authored
Bug: 935773 Change-Id: I291481ce839123e749d5959d413f41ac3560168c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554291Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#649178}
-
Dan Beam authored
* Alpabetize variables and mixins * Remove ; after mixins (unneeded) * --scroll-border: none; is more correcter (applied in border: rule) R=rdevlin.cronin@chromium.org BUG=none Change-Id: I8007b227a759e517faf0113f3d6fa3a5e2b2ceff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559654 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#649177}
-
Alexander Hendrich authored
Sync server-side changes from https://critique.corp.google.com/#review/241808688 to client. Bug: 941489 Change-Id: I9df671bd6e28a0fdf5b1f32178b40037052eb391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559087 Auto-Submit: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649176}
-
Sinan Sahin authored
This CL updates the padding of RadioButtonWithDescription and the color of the radio button control. It also fixes a string. Bug: 942771 Change-Id: I4cd20543e1121235a2fd99cf745d58fc2bf9d9f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553313Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#649175}
-
Orin Jaworski authored
This CL adds the answer_calculator.icon vector file and removes the raster calculator_round_24.png because it is no longer used. The second line of suggestion text started with "= " was redundant with the new vector icon (an equals sign) so the "= " text is erased. Bug: 887690 Change-Id: I4d6e35861397d24ceea028e7d84c36d3777b1f69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557416 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#649174}
-
Raul Tambre authored
The scripts still work with Python 2. There are no intended behaviour changes. Bug: 941669 Change-Id: I219d20cc10e081a23db66515fe576a80e63df3f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556793 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649173}
-
Elly Fong-Jones authored
This change removes the enable-pinch flag and one of its switches (kEnablePinch). The kDisablePinch switch is still used by Cast. The kEnablePinch switch has no effect since pinch is default- enabled. Bug: None Change-Id: I6006dd9766e9c6acc99cf47e2f18939b159fc399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559385 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#649172}
-
Michael Wasserman authored
This reverts commit 67167003. Reason for revert: http://crbug.com/950211 Original change's description: > [Mojo-IMF] Defines/implements mojo interface - ImeEngineClient. > > - Makes InputMethodChromeOS as an ImeEngineClient. > - Hooks up WindowTreeHostMus/WindowTreeClient to connect to ImeEngine. > - Makes calls from ImeEngine to ImeEngineClient. > > Bug: 937167 > Change-Id: I0d27ce6e9bc547f4d269cdfe0ef38e8e83673267 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546795 > Commit-Queue: Shu Chen <shuchen@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648188} TBR=sky@chromium.org,shuchen@chromium.org,dominickn@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 937167 Change-Id: Iedc3a4e21c4236ee7a3529977fe74ba9f3a74c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559846Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#649171}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/42761d27612b..3ed8ba0c5a4b git log 42761d27612b..3ed8ba0c5a4b --date=short --no-merges --format='%ad %ae %s' 2019-04-09 bclayton@google.com Reactor: Support printing pointers Created with: gclient setdep -r src/third_party/swiftshader@3ed8ba0c5a4b The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I15e59542e7b7fe06f3391ce2a0720d649bb18dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559844Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649170}
-
Hui(Andy) Wu authored
Instead of using texts baked in client side for the image clickthrough dialog, read the texts from server response if they present, and only use client strings as fallbacks. Change-Id: Ib80bf91c8271e1f3559bca745c33535054bef535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557081 Commit-Queue: Hui Wu <wuandy@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#649169}
-
Tony de Luna authored
Coverage stats show these lines are never called in tests. https://findit-for-me.appspot.com/p/chromium/coverage/file?host=chromium.googlesource.com&project=chromium/src&ref=refs/heads/master&revision=a5fa529d062c224c8659e2fc6dacb737709c50ca&path=//chrome/browser/ui/webui/chromeos/login/l10n_util_test_util.cc&platform=linux-chromeos Change-Id: I9b72a978898e390f56daff71ec663c00a02cbbf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558622 Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#649168}
-
Tanja Gornak authored
This CL changes the expiration time of the FCM->Tango migration related metrics. It either prolongates expiration_date or removes it completelly, for the metrics we're planning to use in order to inspect health of the FCM invalidations Bug: 801985, 945553, 945539 Change-Id: Iffe973f6a2c6eaeebf306a01fef5bcac1c018b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549415Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#649167}
-
Denis Kuznetsov authored
Bug: 950471 Change-Id: I4c4a00f4ce0ff13fc0fa13a3312f31511cf4f3e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559956 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649166}
-
Will Cassella authored
Since GVR doesn't like inverted selection indices (it silently uninverts them here: go/cassew-gvrkeyboard-indices-invert), uninvert the indices before sending them to Gvr. Bug: 819754 Change-Id: Ic6ef2a0f031af988d81579fd56de0cac2fd03c93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551861 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#649165}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d9b8eed84814..4ffbfe61777f git log d9b8eed84814..4ffbfe61777f --date=short --no-merges --format='%ad %ae %s' 2019-04-09 bsalomon@google.com Add support for importing GL_R16F for YUVA promise images 2019-04-09 martin@mainframe.co.uk add missing shared lib visibility macros 2019-04-09 herb@google.com Revert "Handle translating blob to origin in bulk" 2019-04-09 herb@google.com Revert "Reland "Do not use sub-pixel positioning for source space"" 2019-04-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 36eeb1311a72..0da672fc2c69 (1 commits) 2019-04-09 herb@google.com Reland "Add maxDimension() to glyph" 2019-04-09 herb@google.com Reland "Do not use sub-pixel positioning for source space" 2019-04-09 brianosman@google.com Shader serialization experiment (with Mali Offline Compiler analysis) Created with: gclient setdep -r src/third_party/skia@4ffbfe61777f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I338e8fa2c68835c26410ece788d3000b3bc9a111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559843Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649164}
-
Becca Hughes authored
Disables media key handling when locked on CrOS because of privacy issues. BUG=926019 Change-Id: Ib0e5fcc5f9d20b60fdc0c607d276ffddc7a846b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554795Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#649163}
-
Scott Violet authored
As part of https://chromium-review.googlesource.com/c/chromium/src/+/1547051 InvalidateLayout() was changed to result in a Layout() at a later date. This broke top-chrome sliding. The reason for that, is that if Layout() happens to be called during top-chrome-slide, the NativeViewHost positions the WebContents at an unexpected location. The reason for that is NativeViewHost calculates the position using the transforms that are installed by TopControlsSlideControllerChromeOS, which is unexpected. The fix is to have TopControlsSlideControllerChromeOS calls LayoutRootViewIfNecessary() before setting the transforms. This clears the pending Layout(). BUG=949393 TEST=see bug for repro steps Change-Id: I98ed95f301286e0e490f543800d20d2db3b0faec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559878Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#649162}
-