- 29 Oct, 2018 40 commits
-
-
Stephen Martinis authored
This bot is totally broken at the moment. Remove it so it doesn't block CQ. TBR=jbudorick NOTRY=true Bug: 899908 Change-Id: Ie6eca4c1bf8a67821e5a6570a59255fc6a87f54d Reviewed-on: https://chromium-review.googlesource.com/c/1306396 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#603611}
-
Quan Nguyen authored
Bug: 890912 Change-Id: I4e58b038a6ff288d47e9c37c6b733e6586d48773 Reviewed-on: https://chromium-review.googlesource.com/c/1300097 Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#603610}
-
rbpotter authored
Previously, it was not possible to refresh Print Preview using dev tools. However, it is now possible to do so, and as a result renderer/compositor messages can return to a refreshed Print Preview page that is not expecting any messages, leading to a renderer kill. Since the preview ui id is used only for routing messages from the PrintPreviewMessageHandler back to the appropriate PrintPreviewUI instance, which then forwards them to the PrintPreviewHandler that ultimately sends them to the Print Preview Web UI, it should not be initialized until the web UI is ready to receive messages. It should also be reset whenever the web UI is reloaded. This can be accomplished by setting the preview ui id in OnJavascriptAllowed() and clearing it in OnJavascriptDisallowed() or the PrintPreviewUI destructor, whichever occurs first. Refreshed Preview UIs will then have a different unique identifier after each refresh, which ensures renderer messages intended for previous instances of the web UI page will be dropped instead of being received by the handler and causing a renderer kill. Bug: 874744 Change-Id: Ia43aa9abb97e7952ec3761e5fb016f6513c1c982 Reviewed-on: https://chromium-review.googlesource.com/c/1302676Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#603609}
-
Dominic Mazzoni authored
This reverts commit 9a0f2af8. Reason for revert: Chrome OS compile failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/8596 Original change's description: > Create TouchSelectionMenuViews to separate Menu > > views::TouchSelectionMenuRunnerViews::Menu should be better by > separating it on their own class, this CL introduces > TouchSelectionMenuViews. > > Bug: None > Test: Build. > Change-Id: I6e23c379abc7eb746713dde1b9224389a98014e6 > Reviewed-on: https://chromium-review.googlesource.com/c/1300054 > Commit-Queue: David Jacobo <djacobo@chromium.org> > Reviewed-by: Mohsen Izadi <mohsen@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603576} TBR=sky@chromium.org,mohsen@chromium.org,djacobo@chromium.org Change-Id: I8891d3b3c2df888e8de21ddc391b01871ecd33d3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/1306393Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#603608}
-
James Hawkins authored
There is no longer a trial run in the new setup flow. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: Ic466140fbe18890e707f3338a38b58f385af0f2f Reviewed-on: https://chromium-review.googlesource.com/c/1302704 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#603607}
-
Andrey Kosyakov authored
Bug: 899303 Change-Id: Ibefd04bab772724105d64b9d83a2fafddd1c85a5 Reviewed-on: https://chromium-review.googlesource.com/c/1305494 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#603606}
-
Kevin Strohbehn authored
This is a reland of 0b107635 Includes changes to fix MSAN issues Bug: 898712, 899158 Original change's description: > Makes wallpaper dim in tablet mode, without relying on app_list_shield > > Bug: 898712 > Change-Id: I96ba08fec3f7df8547d753ff4d31366345be0ac8 > Reviewed-on: https://chromium-review.googlesource.com/c/1298507 > Reviewed-by: Weidong Guo <weidongg@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Kevin Strohbehn <ginko@google.com> > Cr-Commit-Position: refs/heads/master@{#602938} Bug: 898712 Change-Id: Ief534b6dc58b5d36b3f96952141a51312c50a79f Reviewed-on: https://chromium-review.googlesource.com/c/1303233 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#603605}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/625dca84765d..25da2e8be18d git log 625dca84765d..25da2e8be18d --date=short --no-merges --format='%ad %ae %s' 2018-10-29 dtu@chromium.org [pinpoint] Temporarily remove auth from gerrit_service.GetChange(). 2018-10-29 erikchen@chromium.org Reduce verbosity of logging for ADB commands. Created with: gclient setdep -r src/third_party/catapult@25da2e8be18d The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:899427,chromium:891898 TBR=sullivan@chromium.org Change-Id: I78a868219581286ce001a19c20005054e6a50c64 Reviewed-on: https://chromium-review.googlesource.com/c/1305893Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603604}
-
David Bokan authored
Bug: 861618 Change-Id: If5f91df67aa66a1292073f051fb551b9193b7078 Reviewed-on: https://chromium-review.googlesource.com/c/1305297Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#603603}
-
Wez authored
--brave-new-test-launcher was used to opt-in to TestLauncher batching and parallelization of tests. Suites using TestLauncher now default to that mode, with --single-process-tests used to opt-out runs where necessary, so remove mentions of the old opt-in command-line parameter. Change-Id: I1b0536d707676cd227dc9a03daeecbefb5e709ad Reviewed-on: https://chromium-review.googlesource.com/c/1303861Reviewed-by:
-
Collin Baker authored
Currently, keyboard focus disappears if the DownloadShelfView is closed while it is focused. This change moves focus to the web contents when it is closing. Bug: 846466 Change-Id: I2fd24d5e918a6be7ce46299b31b53d5fa92aaa97 Reviewed-on: https://chromium-review.googlesource.com/c/1302871 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#603601}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/68825776f4b4..c09dc8ac723f git log 68825776f4b4..c09dc8ac723f --date=short --no-merges --format='%ad %ae %s' 2018-10-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 50b105973431..3957b7f8bd86 (1 commits) 2018-10-29 herb@google.com Move files in GN 2018-10-29 benjaminwagner@google.com Update Win10 GTX660/GTX960 drivers. 2018-10-29 mtklein@google.com also catch 1^y == 1 as a special case 2018-10-29 michaelludwig@google.com Reland "Extract per-edge quad vertex tesselation code into reusable interface" 2018-10-29 caryclark@skia.org sync bookmaker docs with canvas 2018-10-29 reed@google.com expose SkFont as public way to use TextBlobBuilder 2018-10-29 halcanary@google.com run infra/skqp/build_apk.sh from any directory 2018-10-29 bsalomon@google.com Remove SrcRectConstraint from drawImageRect overloads with no src rect 2018-10-29 brianosman@google.com Add GrColor4h (half-float), for use in Ops and (eventually) vertices 2018-10-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 df73a8e5ffdb..4a22f4b04619 (1 commits) 2018-10-29 reed@google.com add helpers to SkFont (and SkTypeface) Created with: gclient setdep -r src/third_party/skia@c09dc8ac723f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: If6bcb4c4c3d5176badc81587f329cf82fcdd378f Reviewed-on: https://chromium-review.googlesource.com/c/1305854Reviewed-by:
-
erikchen authored
Previously, Android test results were propagated after all tests finished running. In the event of an Exception, none of the test results would be written to file. This CL slightly changes the control flow of TestRun.RunTests(). Instead of returning a results array, it now receives a results array as input and modifies the array as it receives test results. This allows the json_writer context TearDown() to serialize the partial test results. This CL updates local_device_test_run.py to have the correct flow. The flow of local_device_perf_test_run.py and local_machine_junit_test_run.py are left untouched -- they can be modified in the future if it's deemed necessary. This minimizes the size of this CL. Bug: 895027 Change-Id: I60fe78da993de366d678252b84a91aaff044c10b Reviewed-on: https://chromium-review.googlesource.com/c/1305396 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
-
Andrey Kosyakov authored
Bug: 899303 Change-Id: If13f08e4e45e4f4f4cfc16bd4f2921cab22ecc07 Reviewed-on: https://chromium-review.googlesource.com/c/1303181 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
-
Antonio Gomes authored
BUG=889883 Change-Id: Ia37ffc9bc4dfb0247137b6bfa8cf272332efb1e6 Reviewed-on: https://chromium-review.googlesource.com/c/1304573Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#603597}
-
Nate Chapin authored
Previously task.result sometimes returned the result value directly. Making it always return a promise makes it easily to handle in JS. Bug: 879306 Change-Id: I6c0168d828d8234875a20e1128b14f1ab6603d4f Reviewed-on: https://chromium-review.googlesource.com/c/1303100Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#603596}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9201a4e1a936..9ab423a548ac git log 9201a4e1a936..9ab423a548ac --date=short --no-merges --format='%ad %ae %s' 2018-10-29 chrome-bot@chromium.org Update config settings by config-updater. 2018-10-29 hungte@chromium.org Remove amd64-generic-goofy build target. 2018-10-29 martinroth@chromium.org chromeos_config: disable grunt firmware branch configs Created with: gclient setdep -r src/third_party/chromite@9ab423a548ac The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6a3493cb5bf51996ec2b12f09638cdb8ac40fb04 Reviewed-on: https://chromium-review.googlesource.com/c/1305853Reviewed-by:
-
bsheedy authored
Re-enables all the VR tests that were marked as flaky now that the root cause has been reverted. TBR=mthiesse@chromium.org Bug: 894796 Change-Id: I34c4b8e10edec2e682c450b1b18c2428f3e29473 Reviewed-on: https://chromium-review.googlesource.com/c/1305211Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#603594}
-
Chase Phillips authored
This reverts commit e76b26c9. Reason for revert: Reverting the "move content/renderer/indexed_db/ to Blink" CL. This commit touches a file that was created by that CL, so reverting it. See these bugs for more info: https://crbug.com/899446 https://crbug.com/717812 Original change's description: > [jumbo] Remove 'using' declaration for mojom::blink::IDBCursor > > The lone 'IDBCursor' can collide with the blink::IDBCursor. Remove the > 'using' and specify the namespace instead. > > TBR=pwnall@chromium.org > > Bug: 717812 > Change-Id: I092b6d3c30931f45d13fd5c35af24539884fa686 > Reviewed-on: https://chromium-review.googlesource.com/c/1301434 > Commit-Queue: Fredrik Söderquist <fs@opera.com> > Reviewed-by: Daniel Bratell <bratell@opera.com> > Cr-Commit-Position: refs/heads/master@{#603039} TBR=cmp@chromium.org,bratell@opera.com,fs@opera.com,pwnall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 717812 Change-Id: I29d7de9ef16258d9cc2c6b68d5fb4ac2ad449cca Reviewed-on: https://chromium-review.googlesource.com/c/1305245 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#603593}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a56061dd6c20..acda68b0292e git log a56061dd6c20..acda68b0292e --date=short --no-merges --format='%ad %ae %s' 2018-10-29 lalitm@google.com trace_processor: overhaul filter and sort system for storage backed tables 2018-10-29 lalitm@google.com Merge "trace_processor: refactor span table to be a bit cleaner" 2018-10-29 ilkos@google.com Merge "Expose a stable TraceProcessor API in include/" 2018-10-29 lalitm@google.com trace_processor: make span joins much more efficient 2018-10-29 taylori@google.com Add support for more events Created with: gclient setdep -r src/third_party/perfetto@acda68b0292e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:117588397 TBR=perfetto-bugs@google.com Change-Id: I305ab82ce5116e00107f7e7ca9937ecc654f6646 Reviewed-on: https://chromium-review.googlesource.com/c/1305294Reviewed-by:
-
Evan Stade authored
test is ExtensionDisabledGlobalErrorTest.UninstallWhilePromptBeingShown Bug: 883371 Change-Id: I1ce860a5c25e9b6b791be681e98907aed9ffb9bc Reviewed-on: https://chromium-review.googlesource.com/c/1305873Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#603591}
-
Chase Phillips authored
This reverts commit 5ac9ece1. Reason for revert: Reverting the "move content/renderer/indexed_db/ to Blink" CL. This commit touches a file that was created by that CL, so reverting it. See these bugs for more info: https://crbug.com/899446 https://crbug.com/717812 Original change's description: > Remove 'using' directives in web_idb_cursor_impl_unittest.cc > > All of the 'blink::*' directives should be unnecessary (now that the code > is within Blink.) Remove the testing::StrictMock 'using' too, and just > "expand" it at its single usage point. > > Change-Id: I3171d05f41364fa134c2ee781e93178d831d4eab > Reviewed-on: https://chromium-review.googlesource.com/c/1301458 > Commit-Queue: Victor Costan <pwnall@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603049} TBR=fs@opera.com,pwnall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I10c3fe89cdb7708d8e66978474f6a0299b775af7 Reviewed-on: https://chromium-review.googlesource.com/c/1305395 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
-
Weidong Guo authored
Changes: Only reset views::FocusManager::arrow_key_traversal_enabled_ when power button menu is shown before. Bug: 898716 Change-Id: I01de4fe8b9438e75d1104997aa0e90c61ae52dd2 Reviewed-on: https://chromium-review.googlesource.com/c/1300685 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#603589}
-
Clark DuVall authored
Creating an incognito window was crashing when DRP was enabled with network service. Bug: 721403 Change-Id: I7c97fec3e6dd4b15358c73eb442f441caa45f5af Reviewed-on: https://chromium-review.googlesource.com/c/1305515Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#603588}
-
sebsg authored
Change-Id: Ic290185b178ce9944b471d3cfa404684c3ce8aaa Reviewed-on: https://chromium-review.googlesource.com/c/1303881 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#603587}
-
James Hawkins authored
This was only used for the EasyUnlock trial which is currently unused and about to be removed. R=hansberry@chromium.org Bug: 899324 Test: none Change-Id: Ic3b7271a386d26728e7af4e4ea56dfdd6b19c675 Reviewed-on: https://chromium-review.googlesource.com/c/1302696Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Patrick Noland authored
When saved scroll state is changed, any saved scroll anchor is now stale. This usually doesn't matter, but can bite us in the case of same document loads, where we can mistakenly restore a saved scroll anchor even after scrolling the page manually. To fix this, we clear the stale anchor. It will still get saved before navigating away from the page. Bug: 898142 Change-Id: Ia3a10e54f732d97bd9ebf2162c0f30c9e079280f Reviewed-on: https://chromium-review.googlesource.com/c/1298476Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#603585}
-
Tommy C. Li authored
After this CL, a single Ctrl+L will reveal the full URL. This applies to beth Query in Omnibox and Steady State Elisions. This CL also adds a unit test, as well as an internal-only killswitch in case we need to remotely disable this feature. Bug: 874592, 882348 Change-Id: I6bce176e613b46bfc9b6ce524ddf855bdb14f399 Reviewed-on: https://chromium-review.googlesource.com/c/1285511 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#603584}
-
Adam Langley authored
CBOR{Reader|Writer|Value} were renamed in b4f12f9a to remove the “CBOR” prefix. This change reflects that in the filenames. (TBR for webpackage code since this is just renaming headers of an underlying library.) TBR=kinuko@chromium.org Change-Id: I0262c827181fe8ab51cd08ad41fce14aa1aed331 Reviewed-on: https://chromium-review.googlesource.com/c/1303177 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#603583}
-
Nicolas Ouellet-Payeur authored
Adds the "browser_switcher.use_ie_sitelist" boolean pref. When set to true, BrowserSwitcherService will download IE's sitelist after 60s. Once the sitelist XML is downloaded, the rules are parsed and applied. Bug: 884837 Change-Id: Ib7a6c374526c56c42265187667ea2d6febc3628b Reviewed-on: https://chromium-review.googlesource.com/c/1286288 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#603582}
-
Jonathan Metzman authored
Get it building and enable it on Windows to increase our coverage of skia on Windows. Change-Id: If88d332d8dcc2fb39e80850a654682fc92530aed Reviewed-on: https://chromium-review.googlesource.com/c/1305208Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#603581}
-
Boris Sazonov authored
This test was added by https://crrev.com/c/1293171 and it is failing on KitKat Phone Tester (dbg) builder: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/KitKat%20Phone%20Tester%20%28dbg%29/10119 TBR=bokan@chromium.org Bug: 898987 Change-Id: I82fe04a5d11cbe09a2794fc6daadb33ce5b1463e Reviewed-on: https://chromium-review.googlesource.com/c/1305316Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#603580}
-
Toni Barzic authored
Updates crostini installer browser test setup to use fake cros component manager implementation. BUG=None TEST=cq passes Change-Id: I85e19ffeade2a932678ddaee92db8329b0bde426 Reviewed-on: https://chromium-review.googlesource.com/c/1303036Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#603579}
-
Aleks Totic authored
Bug: 898212 Change-Id: I83a8f9e355f2b527db8eabfba40625f60a78822f Reviewed-on: https://chromium-review.googlesource.com/c/1303949 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#603578}
-
liberato@chromium.org authored
This fixes SurfaceLayer kOnDemand mode to work with webmediaplayer_ms when the player starts in PIP. Previously, the player wouldn't use SurfaceLayer, since it would wait to enter PIP. Now, it checks if the client is already in PIP, and switches to SurfaceLayer immediately in kOnDemand mode. Bug: 891619 Change-Id: I669003b512152cc22c3e0d1f7d69133304669108 Reviewed-on: https://chromium-review.googlesource.com/c/1301958Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#603577}
-
David Jacobo authored
views::TouchSelectionMenuRunnerViews::Menu should be better by separating it on their own class, this CL introduces TouchSelectionMenuViews. Bug: None Test: Build. Change-Id: I6e23c379abc7eb746713dde1b9224389a98014e6 Reviewed-on: https://chromium-review.googlesource.com/c/1300054 Commit-Queue: David Jacobo <djacobo@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#603576}
-
Yuly Novikov authored
conformance2/vertex_arrays/vertex-array-object-and-disabled-attributes.html on Linux AMD conformance/attribs/gl-disabled-vertex-attrib-update.html on Nexus 5 conformance/reading/fbo-remains-unchanged-after-read-pixels.html conformance/reading/read-pixels-pack-alignment.html conformance/reading/read-pixels-test.html on Nexus 6 TBR=kbr@chromium.org Bug: 899754 Change-Id: Icb1db2a029fa20897baf925609a2ed4dd00cf132 Reviewed-on: https://chromium-review.googlesource.com/c/1305206Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#603575}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b7c4a0243e82..ea08d171755b git log b7c4a0243e82..ea08d171755b --date=short --no-merges --format='%ad %ae %s' 2018-10-29 tsepez@chromium.org Fold virtual CPWL_Wnd::OnCreate into subclass constructors. Created with: gclient setdep -r src/third_party/pdfium@ea08d171755b The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I30edbacb27ea609d7357f68f0ce62e43b1f55316 Reviewed-on: https://chromium-review.googlesource.com/c/1305295Reviewed-by:
-
Yuly Novikov authored
This reverts commit 10a10dd9. Reason for revert: Suspected for flaky crashes affecting Chromium CQ. Original change's description: > Oilpan: Enable HeapCompaction for incremental marking > > Enables HeapCompaction for kIncrementalIdleGC and kIncrementalV8FollowupGC. > > Bug: 864425 > > Change-Id: I1fb04d7c501a8519e106237946f86f52eb7ce8f8 > Reviewed-on: https://chromium-review.googlesource.com/c/1297782 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603477} TBR=haraken@chromium.org,keishi@chromium.org,mlippautz@chromium.org Change-Id: Ie72a2eb04571945b3515ee7374a75a1ab87275c2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 864425, 899809 Reviewed-on: https://chromium-review.googlesource.com/c/1305833Reviewed-by:
-
David Tseng authored
ChromeVox has "force flush" behavior when it receives user input via qwerty keys, braille keys, and touch (explore/gestures). It also has programmatic queue behaviors via Output.withQueueMode. By default, ChromeVox is ready to queue all other output. This will help ChromeVox be flexible when receiving events and not dropping output. For example, when pressing Ctrl+l, we receive focus on the omnibox and quickly after, a selection event on the listbox option auto completion. This is a separate change to ensure we don't miss any corner cases and have to revert. Test: existing tests/manually on omnibox. Change-Id: Iba069c5794fe8cc2b3318c64a87dbd4cc7df6385 Reviewed-on: https://chromium-review.googlesource.com/c/1302414 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
-
