GitLab

There are two problems here:

1) The GuestViewBase received a FindReply while its WebContents was in the process of being destroyed. This patch adds a check in WebContentsImpl::NotifyFindReply to prevent this.

2) During destruction of GuestViewBase, there is a period of time when there is no owner WebContents, but attached() still returns true. This patch ensures that that attached() will return false as soon as |owner_web_contents_| is cleared.

BUG=642733

Review-Url: https://codereview.chromium.org/2300663002
Cr-Commit-Position: refs/heads/master@{#415697}

BUG=634156

Review-Url: https://codereview.chromium.org/2282673003
Cr-Commit-Position: refs/heads/master@{#415696}

This bot is currently FYI-only, and adding the test
will allow us to add the correct suppresions in ANGLE.

BUG=641080
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2273393002
Cr-Commit-Position: refs/heads/master@{#415695}

When the viewport has fixed background, we may create a dedicated
GraphicsLayer (CompositedLayerMapping::m_backgroundLayer) for the
root background. Previously we used PaintLayerPaintingRootBackgroundOnly
and PaintLayerPaintingCompositingForegroundPhase flags when painting
the layer. The second flag was necessary before we refactored viewport
background painting into ViewPainter, because we needed the layout
objects of the document element or the body element to paint the
viewport background.

Now we need only the root layer to paint root background.

BUG=595839
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2294313002
Cr-Commit-Position: refs/heads/master@{#415694}

MessagingBindings contains the custom bindings for extension messaging,
but most of the implementation is buried in an "ExtensionImpl" class
in an anonymous namespace. Apart from being a misleading name (I think
this dates back to the chrome.extension API), this makes the code hard
to read. Since I'm making changes here for crbug.com/642380, clean up
the code here with no behavior changes.

Make MessagingBindings (which previously just had static methods)
encompass ExtensionImpl, and remove some unneeded includes.

BUG=642380

Review-Url: https://codereview.chromium.org/2295753003
Cr-Commit-Position: refs/heads/master@{#415693}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/be52565c2553c03b801f4bfc080c7ebc63b550fa Skia recipe: Use [depot_tools]/gsutil.py instead of [depot_tools]/third_party/gsutil/gsutil (hinoka@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2299543006
Cr-Commit-Position: refs/heads/master@{#415692}

Disable Download button if current tab is showing offline page already, or an error or interstitial.

BUG=641391,641393

Review-Url: https://codereview.chromium.org/2296603004
Cr-Commit-Position: refs/heads/master@{#415691}

This small refactoring removes device scale factor from AwContents
cache and uses the value from ContentViewCore.
The device scale factor in ContentViewCore is defined after
ContentViewCore native initialization, therefore this CL also
moves the device scale propagation until after that.

This is a prerequisite for https://codereview.chromium.org/2300463002

BUG=620929

> Committed: https://crrev.com/8d849fd2d39c9db747f4e8d89dcedfebb0273a97
> Cr-Commit-Position: refs/heads/master@{#415546}

Reland after fix related to PopupTouchHandleDrawable.

Review-Url: https://codereview.chromium.org/2288273003
Cr-Commit-Position: refs/heads/master@{#415690}

Add an uma counter to log how often dtls handshake fails because of incompatible cipher suites.
Related CL: https://codereview.webrtc.org/2167363002/

BUG=webrtc:5959

Review-Url: https://codereview.chromium.org/2292253002
Cr-Commit-Position: refs/heads/master@{#415689}

Previously, clicking the close all button shouldn't close pinned notifications, but closed them actually. This patch fixes this bug.

BUG=b/31022395
BUG=642827

Review-Url: https://codereview.chromium.org/2295923004
Cr-Commit-Position: refs/heads/master@{#415688}

Add command line flag to allow testing clients not connected to localhost. Otherwise, restrict connections to localhost

BUG=582102
TEST=Run the engine without the "listen-outside" flag and make sure incoming connections are limited to localhost. Run with --listen-outside=1 and make sure it allows incomiong connections from outside localhost

Review-Url: https://codereview.chromium.org/2292563003
Cr-Commit-Position: refs/heads/master@{#415687}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3e5d344f..a7db6458

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2296233002
Cr-Commit-Position: refs/heads/master@{#415686}

BUG=626752
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2295533002
Cr-Commit-Position: refs/heads/master@{#415685}

Fix the problems that on some models of phones such as Sony Xperia Z3 & Z5, Chrome widget blocks in showing the bookmark information.

It comes with two problems and both happens when there are thousands of
bookmark to display:
1. If Chrome is not initialized, GC might recycle the BookmarkLoader
before BookmarkModel is loaded which blocks retrieving bookmark info.
2. Even Chrome is already intialized, fetching meta data is not always
guaranteed to wait until onDataChanged is finished(even though Android doc
claims it is). So need to manually check if bookmark info is loaded and
keep refreshing if not.

BUG=621643

Review-Url: https://codereview.chromium.org/2258113003
Cr-Commit-Position: refs/heads/master@{#415684}

This field trial has expired.

BUG=557984

Review-Url: https://codereview.chromium.org/2286903002
Cr-Commit-Position: refs/heads/master@{#415683}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/aa7c58eb0459..08327b978d86

$ git log aa7c58eb0..08327b978 --date=short --no-merges --format='%ad %ae %s'
2016-08-31 eakuefner [Catapult] Add common/node_runner

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2298803002
Cr-Commit-Position: refs/heads/master@{#415682}

For now, let's just add metrics from parse start -> first meaningful paint.

TBR=jochen@chromium.org

BUG=596676

Review-Url: https://codereview.chromium.org/2281943002
Cr-Commit-Position: refs/heads/master@{#415681}

BUG=642534

Review-Url: https://codereview.chromium.org/2291193004
Cr-Commit-Position: refs/heads/master@{#415680}

This is unused and no longer needed. We can revive it from git history if
we need it again.

BUG=641996
TEST=compiles

Review-Url: https://codereview.chromium.org/2298603002
Cr-Commit-Position: refs/heads/master@{#415679}

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/BkPSl0Oey8k/BqJ3_ck0BAAJ

BUG=569690

Review-Url: https://codereview.chromium.org/2217763003
Cr-Commit-Position: refs/heads/master@{#415678}

BUG=3333

Review-Url: https://codereview.chromium.org/2298023002
Cr-Commit-Position: refs/heads/master@{#415677}

This CL implements the new <fit-content> track size which is defined as
follows: "Represents the formula min(max-content, max(auto, argument)),
which is calculated similar to auto (i.e. minmax(auto, max-content)), except
that the track size is clamped at argument if it is greater than the auto
minimum."

From the parsing POV fit-content was implemented as a new type of function
which only takes one argument. That forced us to refactor some code because
minmax() was the only allowed function for <track-size>s so far.

The implementation key is a new attribute in GridTrack called growthLimitCap
which is precisely the attribute of fit-content(). Some parts of the track sizing
algorithm were adapted to this change like for example the sorting of tracks by
growth potential (we need to consider the caps).

BUG=618972

Review-Url: https://codereview.chromium.org/2287113004
Cr-Commit-Position: refs/heads/master@{#415676}

removeChildNode() does not notify willBeRemovedFromTree() when
!notifyLayoutObject. This can leave orthogonal writing mode roots
marked after the removal of the child.

This patch unmarks them even when !notifyLayoutObject.

This fixes annonymous boxes left marked in fullscreen. It is still
correct for LayoutFullscreen to have the same writing-mode as parent,
but DCHECK was removed because it doesn't leave boxes unmarked any
longer, and ensuring that against dynamic changes requires more work.

BUG=642028

Review-Url: https://codereview.chromium.org/2296973003
Cr-Commit-Position: refs/heads/master@{#415675}

BUG=621773

Review-Url: https://codereview.chromium.org/2293203002
Cr-Commit-Position: refs/heads/master@{#415674}

Losing network connection while prerendering can show up as an Unsupported Scheme failure
currently as it sees a special data URL in path toward rendering an error page. We don't want
a flakey network connection fail a background load request on just a single try, so for now,
we will treat this specific error type as a cancel rather than a failure so that it is subject
some limited retrying. The down side, is that for some page that has a repeatable redirect
to an unsupported scheme, we will waste some retries on it that we otherwise could skip.

Ideally, we could get a different final status code from the prerenderer if it could clearly distinguish a network failure condition but it does not currently have such knowledge.

BUG=642025

Review-Url: https://codereview.chromium.org/2294933003
Cr-Commit-Position: refs/heads/master@{#415673}

https://chromium.googlesource.com/skia.git/+log/4bcd62e3313d..982e7c502f44

$ git log 4bcd62e33..982e7c502 --date=short --no-merges --format='%ad %ae %s'
2016-08-31 mtklein switch CQ over to GN_Android compile bots
2016-08-31 senorblanco Screenspace AA tessellated GPU path rendering.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=bsalomon@google.com

Review-Url: https://codereview.chromium.org/2296223002
Cr-Commit-Position: refs/heads/master@{#415672}

https://chromium.googlesource.com/angle/angle.git/+log/d5da505..ad10a4a

BUG=

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2298593003
Cr-Commit-Position: refs/heads/master@{#415671}

with a number of needed utility functions.

Apologies for the size of this CL; some of the utility implementations ended up being
fairly involved.

This CL:

(1) moves ExecuteJavascript out of web_view_matchers to be a public utility function
in web_view_interaction_test_util.

(2) Add web_view_actions and shell_actions for new action providers.

(3) Adds ios/testing/earl_grey/matchers for non-web-specific matchers.

(4) Adds a "verified action" wrapper that will inject a mousedown event handler and
a script callback handler to watch for it, so that UIKit actions that ought to trigger DOM
events can be verified.

(5) Adds a BoundingRectOfElementWithId() utility to find where (in webview bounds
coordinates) an element is.

(6) Adds a method that long-presses a webview element to trigger (or not) a context
menu.

(7) Adds matchers for finding elements in context menus, and finding an element to
tap that will dismiss the context menu. The latter encapsulates the differences between
iPad and iPhone.

(8) Adds header guards to shell_matchers.h and web_view_matchers.h (!)

(9) Changes a bunch of std::string params for utility methods to be references.

(10) (finally) Implements the upstreamable context menu tests, adding a test for simply
triggering the context menu.

BUG=

Review-Url: https://codereview.chromium.org/2275303004
Cr-Commit-Position: refs/heads/master@{#415670}

The range, when navigating to dynamic widgets, sometimes detaches entirely from the document and only re-appears as a result of future events. Since we're observing children changed for active descendant changed, filter out events that result in a range pointing to a null node.

BUG=641213
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2296013002
Cr-Commit-Position: refs/heads/master@{#415669}

The CL broke some websocket layout tests, will reland once that's
worked out.

This reverts commit 398c105e.

Also add a group policy to allow HTTP/0.9 support on other
ports, which I plan to remove in a couple revisions.

BUG=624462, 637017
Committed: https://crrev.com/398c105ea8391473126021104554d70fda08324b
Cr-Commit-Position: refs/heads/master@{#415643}
TBR=eroman@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2297263002
Cr-Commit-Position: refs/heads/master@{#415668}

It's a fairly thin wrapper on a HeapHashSet, and the two non-trivial functions
are each only called from a single place in ResourceFetcher. Inline them there.

BUG=

Review-Url: https://codereview.chromium.org/2296923002
Cr-Commit-Position: refs/heads/master@{#415667}

Changes include:
- Omitting trailing period and colons from labels/headers.
- Omitting "optional" text from labels and adding group subheading to indicate optional fields.
- Shorten some strings.

Used camelCase for new string per presubmit guidelines for i18n-content.

BUG=640604
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2293673002
Cr-Commit-Position: refs/heads/master@{#415666}

If the output is saved to a file properties.txt, you can generate a
visual representation using dot:

$ dot -Tsvg properties.txt > properties.svg

Sample output:

http://jsbin.com/jajuyuyixo/edit?output

R=pdr@chromium.org,wangxianzhu@chromium.org
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2252273006
Cr-Commit-Position: refs/heads/master@{#415665}

To be used by BrowsingDataRemover when the user chooses to delete data
for a particular site.

This is implemented as a new method HostCache::ClearForHosts() as opposed
to extending the existing HostCache::clear(), as clear() has a lot
of callsites and thus it seems to be useful to keep this more specific
version.

On the other hand, the fact that there are many callsites of clear()
also means that in many cases it's acceptable to clear the entire cache
even if clearing less would be sufficient. In that sense, this CL might
be unnecessary and it might be acceptable for BrowsingDataRemover to also
clear the entire cache even if the user only needs to delete data for one
site.

TBR=achuith@chromium.org
BUG=589586

Review-Url: https://codereview.chromium.org/2298173002
Cr-Commit-Position: refs/heads/master@{#415664}

This is happening due to a Refresh called from a task group
which process_id is zero.

I am not sure if calling Refresh when process_id is still
zero should be supported. Perhaps that is an issue in
TaskManagerImpl / TaskGroup code, I think
https://crbug.com/521197 might be related. For now the
quick fix is move the DCHECK a bit further in the code so
it doesn't get triggered in that case.

BUG=642482

Review-Url: https://codereview.chromium.org/2293293002
Cr-Commit-Position: refs/heads/master@{#415663}

BUG=632460

Review-Url: https://codereview.chromium.org/2206283003
Cr-Commit-Position: refs/heads/master@{#415662}

Use std::move and delete unnecessary functions.

BUG=None

Review-Url: https://codereview.chromium.org/2292203003
Cr-Commit-Position: refs/heads/master@{#415661}

Update code in net to use JavaRef when calling Java methods via JNI,
instead of passing bare jobject. Various function parameter types are
converted from jobject to JavaRef to enable calls to obj() higher up the
call chain to be removed.

BUG=506850

Review-Url: https://codereview.chromium.org/2301553002
Cr-Commit-Position: refs/heads/master@{#415660}

ExceptionStatePlaceholer was out-dated.  This CL updates it according
to the latest ExceptionState, adding throwRangeError and
rethrowV8Exception.

BUG=

Review-Url: https://codereview.chromium.org/2298753002
Cr-Commit-Position: refs/heads/master@{#415659}

No change, just re-ordering. Really this time.

TBR=chrishtr@chromium.org
BUG=636475

Review-Url: https://codereview.chromium.org/2295213002
Cr-Commit-Position: refs/heads/master@{#415658}