- 01 Jul, 2020 40 commits
-
-
Julian Kranz authored
This CL replaces commented fields by explicit field reservations in the NigoriSpecifics message. Change-Id: If7e32c7764c46acba555ecd931989a59691f347a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274630 Commit-Queue: Julian Kranz <kranzj@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#784429}
-
Greg Thompson authored
During startup, the mini_installer attempts to free up disk space left occupied by previous runs of the installer that may have failed to perform their own cleanup. Such freeing shouldn't cross junction points or links or other similar filesystem constructs, since such would not have been created by a previous run. This CL simply skips over any directories that have reparse points -- directories created by the installer should not have any. BUG=1100280 R=waffles@chromium.org Change-Id: I20d874db50bd11faeac8e03522d162abcae095b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276207 Commit-Queue: Greg Thompson <grt@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#784428}
-
Mirko Bonadei authored
For some reason the regex was only selecting symbols starting with one ? while there are some Abseil symbols that start with ??. This was discovered by crrev.com/c/2245897. Bug: 1046390 Change-Id: I79e453ef6d30017eb9c078a95aa16e3e949186fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275887 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#784427}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I1c69b0d303b6a87614072c4ca086fb5880c5a285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277614Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784426}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/43c639f0906a..f4025c1cd5c2 2020-07-01 xinghua.cao@intel.com Add interface for enabling 16-bit types (#1091) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: If4054f487413d792e96807d1fbe531b83ef347d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277620Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1593582825-995d8e78b6c8ff09ef0a8c1c9fd4830db0669287.profdata to chrome-mac-master-1593604378-7ad12f7ebd4d045f1c25dd8b02b7f9ffca2fcf89.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,jeffyoon@google.com Change-Id: Ie39bb5f5fba4894c3eb2607069a1ad87072ef32a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278004Reviewed-by:
-
François Beaufort authored
This CL removes a comment that is not necessary anymore with https://chromium-review.googlesource.com/c/chromium/src/+/2247820 Bug: 934063 Change-Id: I7aa733f18f399ab7036f083b37134a99b47a8107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274622 Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#784423}
-
Michael Ershov authored
Ignore certificates that return error when asked for certificate provisioning specific attribute. The error most likely just means that the certificate doesn't have a value for the attribute. This will be changed later when there is a way to distinguish unset attribute case and other errors. Bug: 1045895 Test: CertProvisioning* Change-Id: Ib4960916f53e50ed6d374085cbd165b8fdcd4c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275879 Commit-Queue: Michael Ershov <miersh@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#784422}
-
Jeremie Boulic authored
When the files-zip-no-nacl flag is enabled, the cros-disks zip handling is called via mountArchivesInternal_. Zip integration tests still work: browser_tests --gtest_filter=*zipFile* Test: Manually tested on DUT Bug: 912236 Change-Id: I4a5732161f19edd8a10ac5fc4ec280694a1c8415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239775Reviewed-by:
François Degros <fdegros@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#784421}
-
Eugene But authored
Please see crbug.com/1029907 for details. Bug: 1029907 Change-Id: I2dab884278ada0d2532bbb0adb4cf3d71fd7850e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277069 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#784420}
-
Sylvain Defresne authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I8060c8baea8424c9ee999a4db99159320268f0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277726 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#784419}
-
Sylvain Defresne authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: Ic845c9310296d8e6527df7d9d0afa104f526ef61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276262 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Omer Katz authored
Instead of processing ephemerons during each incremental step on the mutator thread, this CL establishes the following: * Epehemerons are fully processed during every concurrent marking step. * Incremental marking on the mutator thread flushes ephemeron pairs every few steps. These steps also performs a single iteration of ephemeron processing every few steps (lower frequency than flushing to allow concurrent markers to do most of the work). Fixed-point processing during these tasks is not considered cost-effective. * Marking during the atomic pause performs full fixed-point processing. Bug: 986235, 1099415 Change-Id: Id2980ef467b393b4062c5a1206ac1212233e6658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260015Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#784417}
-
Maxim Kolosovskiy authored
handled submission This will prevent confusing prompts when a script has already handled the submission. Bug: 1100330, 1063347 Change-Id: I60bfc326c8d32a478710d270bceba3837b668f37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270079 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#784416}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4cb7be407fb7..5843fee4e7c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC dullweber@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1100584 Tbr: dullweber@google.com Change-Id: I2e7b0ec747e90db05fde376af735c9f48796df94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277418Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784415}
-
Sreeja Kamishetty authored
Previously (https://crrev.com/c/2224981), we have blocklisted SpeechRecognizer in the renderer while initializing but this is very aggressive with BackForwardCache coverage. In this CL, we move the blocklist to the browser process when we call the SpeechRecognitionDispatcherHost::Start. Bug: 1101265 Change-Id: I991a75380149f3f5aab9da6de6a715d5b932ce24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277061 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#784414}
-
Sylvain Defresne authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: If9a4a40a991f09de8ca813f3e2e203933723465b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276201 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#784413}
-
Yuki Shiino authored
This patch allows the following branch. #if defined(USE_BLINK_V8_BINDING_NEW_IDL_INTERFACE) #else #endif Bug: 839389 Change-Id: I17249cf1a9c84bf11a52f31cfad41b3c1378431f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275287Reviewed-by:Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Omer Katz authored
Based on binary size, the branch in the macro wasn't optimized away on non-asan builds. This fix manually removes the branch when it's not needed. Bug: 1099412 Change-Id: I318f02fc7c254db0dc2b5098109734d170138b5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276279Reviewed-by:
-
Michele Mancina authored
Bug: b/159100700 Change-Id: Ie38363ba8a820c2d9663533cbf0f0a8cff19d91a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255464 Commit-Queue: Michele Mancina <micantox@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#784410}
-
Sylvain Defresne authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: Idb6c7d282e04ff7bf3dadc19767a78806be40499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276283 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#784409}
-
Matt Menke authored
It's not being used. Bug: None Change-Id: I527292e7c87e61443b38495ab7f117f391c11e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276249Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#784408}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ib0e92ed5095d52c131e513263bbe712f1553f429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277962Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784407}
-
Jimmy Gong authored
- Columns will now resize based on the app's window width thresholds. - Small widths with result in "Printing" being displayed instead of the full ongoing status. 600px <= width < 768px: https://screenshot.googleplex.com/Gt1NOywa0D8 768px <= width < 960px: https://screenshot.googleplex.com/m2ObTzxwk0S 960px <= width < 1280px: https://screenshot.googleplex.com/aCBRd5CBBYx <= 1280px: https://screenshot.googleplex.com/v1ucYjEi7Td Bug: 1053704, 1101174 Change-Id: I67eabbb37845e25391cfe984b40a66cae474f312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270107 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#784406}
-
Sylvain Defresne authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: Id20cfc5e36fc4566ca6a7a408a577affed09c4ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277725 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
Bug: 1090628 Change-Id: If9afa8ca3371e813bbdaf095f9cc8be11843e460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274607Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#784404}
-
Colin Blundell authored
This is possible now that WebLayer is using the componentized InfoBarContainerLayout.java. I forgot to add it in to that CL itself. Bug: 1099169 Change-Id: Ie836ae88a07975e17dcc33873d33175a9a763258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276254 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#784403}
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I88528b1983052c7668818f37431c116ed2a8b7af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277968 Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#784402}
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I54034bd08040e8aba6bd6d21e53a920fe42f3fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277965 Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#784401}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fc0dc3a9c734..fba90d6b0a23 2020-06-30 vasniktel@gmail.com spirv-fuzz: Add FuzzerPassAddCopyMemoryInstructions (#3391) 2020-06-30 vasniktel@gmail.com spirv-fuzz: Add one parameter at a time (#3469) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com Change-Id: Ia4a4fff6d50748759651eb952b6db1d6541f5763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277617Reviewed-by:
-
Leo Lai authored
This CL is part of plan that chromium talks to attestationd and bypass cryptohomed for attestation-related APIs. BUG=b:158955123 Change-Id: I7be67f3420fb114ab11203dd44e73bca4aa11574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249276 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#784399}
-
Sylvain Defresne authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I494e828033221636b70c618e46bca99ec9e5aa98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276415 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I4e61fe7c448d138c6a3592f8e04442e73e4ad6eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276416 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#784397}
-
Noel Gordon authored
Tests that dragging a file over a directory tree item that can accept a drop adds CSS class .accepts to that tree item. Also: check that the drag hover causes the file-list to navigate to the hovered tree item's directory. Bug: 1002394 Change-Id: I4def2bfd5621b9043d615c0706cc273fc9eb16ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275576 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#784396}
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: Ib5930991d138a7f53e605e9f21bfd944a4df1129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276663 Commit-Queue: Colin Blundell <blundell@chromium.org> Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#784395}
-
Leonard Grey authored
The tabstrip background calculation currently assumes that its origin is relative to the browser view. This is usually true, but its actual parent view is the top container, which can have a different origin in some cases. This change explicitly converts the origin to the browser view. Bug: 968415 Change-Id: Ice3243c275ffce2f2fcc043df6b142392f02db2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276520Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#784394}
-
chrome://versionEdward Trist authored
Currently, the Chrome logo on chrome://version lacks an alt attribute. This change uses the existing IDS_SHORT_PRODUCT_LOGO_ALT_TEXT string to get alt text for the current product logo (i.e. Chrome logo / Chromium logo). Bug: 1082511 Change-Id: Ib601ad747402a482bb13f80a65268855d9a3ba92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234513Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#784393}
-
Mansi Awasthi authored
This CL introduces a method PDFiumPage::PopulateButton() which reads button form fields (radio button, checkbox and push button) from the PDF document and stores relevant information in a vector within PDFiumPage. The CL also includes a new test file with sample radio buttons, checkbox and push button. A unit test is also added to validate the new method. Bug: 1030242 Change-Id: I1f5102f8c20027abe785fa1833c2ecc9cbce8734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249285 Commit-Queue: Mansi Awasthi <maawas@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#784392} -
Robert Sesek authored
This let the signing scripts work out-of-the-box with Chromium builds. The existing app-entitlements.plist file is split into two: in that file are all the entitlements that work with any signed build of the product, but the entitlements that are bound to the Google Chrome signing identity are moved into a new app-entitlements-chrome.plist. Bug: 1021255 Change-Id: I2aa04d5da1edcaaeeed50f3b70a86400e3aac516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276523Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#784391}
-
Marc Treib authored
While we're here, also remove "passwords-account-storage-saving-ui" which doesn't exist anymore. Bug: none Change-Id: I9f202b7c39f8cfaa619ee65f72c11bff2f5e41a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276203 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#784390}
-
