GitLab

Bug: 1057100
Change-Id: I1e69334805631fb697d35ef05d611921dc81854b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518138
Commit-Queue: Evan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823821}

This reverts commit 573667ec.

Reason for revert:
LocalSyncTest.ShouldStart is failing on Mac bots: https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/60761
https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/56727

Original change's description:
> Enable roaming profile support on mac and linux.
>
> Don't add a default roaming profile location, so this feature
> will only work when RoamingProfileLocation is set as well.
>
> BUG:1145172
>
> Change-Id: I0353e65127bdb84fc7185201d1908bb4b545db18
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507890
> Commit-Queue: Chris Sharp <csharp@chromium.org>
> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#823795}

TBR=pastarmovj@chromium.org,csharp@chromium.org,treib@chromium.org

Change-Id: I5cd261f409268e2318a27bfbe04e4091767afb6c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517345Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823820}

Document.hasTrustToken is a JS method only available in secure contexts.
Its implementation involves getting a Mojo interface from the browser
and sending an IPC. In the browser-side code, in RenderFrameHostImpl,
where we handle requests from the renderer for this Mojo interface, we
perform a security check to make sure we aren't receiving requests for
the interface from unexpected places, which could indicate a bad
renderer. The current check makes sure that the request is coming from a
frame with a potentially trustworthy origin. However, this is not
exactly the same thing as a secure context: in particular, allow-scripts
sandboxed iframes can be secure but not have potentially trustworthy
frame origins. This leads to false positives in the check and unwanted
renderer kills.

This CL removes the check.

R=dcheng

Bug: 1144057
Change-Id: I0e57669606effb15c672586297ef7dcf2711bc91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511882
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Commit-Queue: Charlie Reis <creis@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Auto-Submit: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823819}

The various GraphicsPipeline.* metrics are deprecated, replaced by the
newer CompositorLatency.* metrics, which have more breakdowns from cc
and blink.

BUG=884851, 1088832

Change-Id: Ice3cd0cf07db8def51263bb080bfacebbaf9aa35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120362
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823818}

With this CL, file:// URLs will no longer get an exemption to
keep using Web Components v0 features.

Bug: 1111843, 937746, 1025782
Change-Id: Ifbb8801b3d9eb02e124109c137e64dbbd8dafdf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514672
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Yu Han <yuzhehan@chromium.org>
Reviewed-by: Yu Han <yuzhehan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823817}

An instance of this class will be shared across all trigger scripts to
facilitate evaluating static trigger conditions.

Bug: b/171776026
Change-Id: I07bef617159ec61f44ef6c96d899d8f3d01b771a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514154
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Marian Fechete <marianfe@google.com>
Cr-Commit-Position: refs/heads/master@{#823816}

Change-Id: I8b65fa141781adc4016563bf54c6f621959ecc79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518323
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823815}

Updates imports in content/ to use the base/ CriteriaHelper

Bug: 1134178
Change-Id: I1993bf4128c1422491bf93ca36e328f51c5b78d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518037
Auto-Submit: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823814}

Updates imports in weblayer/ to use the base/ CriteriaHelper

Bug: 1134178
Change-Id: If0dcbaff1e01f02220f22388c05f25171d138c29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518793
Auto-Submit: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823813}

There is a memory leak in the cross thread copy
of MediaPlayerWatchTime. This converts it into
a unique_ptr which should prevent that.

BUG=1144736

Change-Id: I8e47948a65ace5c8f4b58897fc927cd4165ed27e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518096
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Auto-Submit: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823812}

Extracts the part of CPRService#onPaymentAppCreated that can be shared
with WebLayerPRService into PRService.

Bug: 1144527

Change-Id: I9d984e100a8ffa4935a0e4df6e174d0f91b55ced
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515049
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823811}

Change-Id: Id6ca93ae981f128896138524891f8d1b1615e6a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518713Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823810}

Change-Id: I984d54a50f7317de35f08261b76eeef65365e36e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518757
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823809}

Sheriff: Mark http/tests/devtools/sources/debugger-ui/continue-to-location-markers-in-top-level-function.js as flaky

Bug: 1144273
Change-Id: I471561caba1630c35a74f84927f64391e46b196f
Tbr: nhiroki@chromium.org
Notry: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518305Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823808}

This change lets the inner frame of the help app clear the search index.

Make the mock app add test data to the local search service similar to
the chrome branded build.

Bug: b/172018145
Change-Id: Ief94524c63b70a969500e94ece1b9e1aad811c15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513806
Commit-Queue: Zufeng Wang <zufeng@google.com>
Reviewed-by: Rachel Carpenter <carpenterr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823807}

Updates imports in chrome/android/javatests/ to use the base/ CriteriaHelper

Bug: 1134178
Change-Id: I7e919f3cb68f49a138bdb0513bea903769a07361
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518217
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Auto-Submit: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823806}

Bug: 1144773
Change-Id: I8cf714fa6923f99db29435b5c83917ac7fc9aa50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518094Reviewed-by: Lijin Shen <lazzzis@google.com>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#823805}

The Chrome OS exo Wayland server provides the zcr_cursor_shapes_v1
interface to allow clients to request server-side cursor shapes. Bind
the interface and wrap it in a WaylandZcrCursorShapes class.

Future CLs will use the interface for cursors for Lacros.

Bug: 1143790
Change-Id: Ib6224e6ef5945f9e2f7403b0afd38a53611a88c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518765Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823804}

This CL rearranges CPRService#invokePaymentApp and extracts the part
that can be shared with WebLayer into PRService#invokePaymentApp.

Bug: 1144527

Change-Id: I1a2a8a4983e58b9001da9b43b9ce901a56fea47b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515047
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823803}

Bug: 772945
Change-Id: I438b94516567877c93f1357db189826e72a71470
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515272
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823802}

On mac-arm64, allow the x86_64 Widevine content decryption module (CDM)
to run under Rosetta translation, even when running native arm64 Chrome.
This is necessary because there isn’t currently an arm64-native Widevine
CDM. It’s not necessary to run the rest of Chrome as x86_64 under
Rosetta translation. The isolated Widevine CDM runs in its own x86_64
utility process, and is IPC-compatible with the rest of Chrome. This
alleviates any performance impact on the rest of Chrome, and allows
crash reporting to work correctly for the rest of Chrome.

An ordinary build of Chrome for mac-arm64, even an official build, will
not include a bundled x86_64 Widevine CDM library (or, obviously, an
arm64 one, as it does not yet exist). The x86_64 Widevine library is
useless to an arm64 Chrome without an x86_64 process to host it.
However, if a universal build of Chrome is created by merging
same-version x86_64 and arm64 builds, the arm64 code will look for an
x86_64 Widevine CDM and, if found, launch an x86_64 helper process under
Rosetta translation to host it.
https://chromium-review.googlesource.com/c/2515521/ is a proposal for
creating such a universal build.

Implementation notes: if no Widevine CDM library is found in the arm64
platform-specific location, Chrome on mac-arm64 will look for one in the
x86_64 platform-specific location. This allows mac-arm64 Chrome to find
the x86_64-only bundled Widevine library. Separately, any Widevine
library found will be examined to determine its architecture. If it
contains x86_64 code and no arm64 code, an x86_64 helper will be
launched to host it. This is done because, although the Widevine library
bundled in Chrome is known to be x86_64-only and will only exist in the
x86_64 platform-specific location, it is expected that a future update
distributed by the component updater will support arm64 natively.
However, in the event that a component update is produced that supports
x86_64 but not yet arm64, it is likely that the x86_64 version
distributed to arm64 users as a component update will appear in the
arm64 platform-specific location, despite being x86_64 code. This means
that the platform-specific location path cannot be trusted to convey the
actual architecture of the library contained therein, and the
architecture must be determined by examining the library to be loaded.

No behavior change for non-mac-arm64 builds.

Bug: 1142017
Code-Word: calamity
CQ-Include-Trybots: luci.chromium.try:mac-arm64-rel
Change-Id: Ib3f4a654f89f41c0fbf9239f99010387ea242763
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493191
Commit-Queue: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Auto-Submit: Mark Mentovai <mark@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823801}

Updates imports in chrome/test/ to use the components/ CriteriaHelper

Bug: 1134178
Change-Id: Ia1165bf9cd9427a1d696897e77767d96b076afd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518892
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Auto-Submit: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823800}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Change-Id: I60955c98bcf71e0b62d48a7335bb00acb947e88a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518636Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#823799}

This is necessary for forwards compatibility with SDK changes and
consistent with most other clients.

Bug: fuchsia:63529
Change-Id: I5dca17d93d0563849c288780fd90317b0ed5f953
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518131
Auto-Submit: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823798}

Updates imports in chrome/test/ to use the base/ CriteriaHelper

Bug: 1134178
Change-Id: I6a0d12f41867d7f75361170ee4a562c3bdcd34fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518891
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Auto-Submit: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823797}

We want to enable autocorrect more widely, so enable it by default
unless the app explicitly disables autocorrect or spellcheck.

Bug: b/161490915
Change-Id: I4789906e65c325f4cb6c5687e1ce095eb2baa4cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516139
Auto-Submit: Darren Shen <shend@chromium.org>
Commit-Queue: My Nguyen <myy@chromium.org>
Reviewed-by: My Nguyen <myy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823796}

Don't add a default roaming profile location, so this feature
will only work when RoamingProfileLocation is set as well.

BUG:1145172

Change-Id: I0353e65127bdb84fc7185201d1908bb4b545db18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507890
Commit-Queue: Chris Sharp <csharp@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823795}

This CL runs PermissionsApiTest.OptionalPermission and
PermissionsApiTest.OptionalPermissionsAutoConfirm tests with service
worker based extensions.

Bug: 986416, 1093066
Test: Test only change
Change-Id: I9135147ca731f9d93ec723c989fe872275e7d3dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516392
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823794}

https://quiche.googlesource.com/quiche.git/+log/9c41f8ba2361..67e5f47e

$ git log 9c41f8ba2..2584df376 --date=short --no-merges --format='%ad %ae %s'
2020-11-03 fayang Add QUIC_EXPORT_PRIVATE for X509NameAttributeToString.
2020-11-03 fayang Remove unused one_rtt_keys_available_ from TlsServerHandshaker.
2020-11-03 bnc Add code count for quic_send_goaway_with_connection_close.
2020-11-03 haoyuewang Temporarily disable BbrSenderTest.InFlightAwareGainCycling test in chromium tests.
2020-11-03 bnc Add code count for quic_send_goaway_with_connection_close.
2020-11-02 nharper Refactor QUIC TlsHandshaker classes
2020-11-02 haoyuewang Fix flaky ReloadMappedListeners test by disabling blackhole detection as that code involves two interleaving QuicClients on the same thread and is thus unrealistically stringent.
2020-11-02 vasilvv Replace QuicheTextUtils::Split with absl::StrSplit.
2020-11-02 nharper Re-enable tests in Chrome.
2020-11-02 quiche-dev Use SSL_early_data_reason_string in EarlyDataReasonToString.
2020-11-02 vasilvv Use QUIC-internal subject parser instead of the platform one.
2020-11-02 dschinazi Verify gfe2_reloadable_flag_quic_disable_version_t050
2020-11-02 renjietang Internal QUICHE change
2020-10-30 vasilvv Implement Subject parsing in CertificateView.
2020-10-30 fayang Use ScopedEncryptionLevelContext to send data from QuicConnection and QuicSession.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

R=dschinazi@chromium.org

Change-Id: I00b3c3c980ba376e06480aafc0155a72d3e6370d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518203
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Auto-Submit: Fan Yang <fayang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823793}

Prerequisite for focus traversal into anchored DialogDelegates. There
are currently none of those as anchor functionality is in
BubbleDialogDelegate.

Bug: 1144829
Change-Id: I6dcfd11cdae4f74b79190ec6461437a05200ddc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514664
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823792}

This reverts commit f89a9f12.

Reason for revert: Whoops. I was wrong, and I think the src-internal roll *has* landed.

Original change's description:
> Revert "Roll GN from e002e68a..f5f465b5"
>
> This reverts commit 7ba203c1.
>
> Reason for revert: reverting since the src-internal roll hasn't landed yet.
>
> Original change's description:
> > Roll GN from e002e68a..f5f465b5
> >
> > Generated by //tools/gn/roll_gn.py
> >
> > https://gn.googlesource.com/gn/+log/e002e68a..f5f465b5
> >
> >     f5f465b5 Fix runtime_deps for elided targets
> >     3d165b90 Correct the `gn format --dump-tree=json ...` command to write to stdout instead of stderr.
> >     ad0a7ada Remove support for set_sources_assignment_filter function
> >     e1ac69b1 Add a command line to define/overwrite "root" in ".gn"
> >     7b2a04d5 VS: Use most recently installed Windows 10 SDK.
> >     132588e1 Revert "gn recipe: Link GN with rpmalloc to speed it up."
> >     3281c669 Add "framework_dirs" and "frameworks" to syntax highlighting rules
> >     4323e701 gn recipe: Link GN with rpmalloc to speed it up.
> >     c808630c Move runtime_deps file for phony targets to /obj
> >     8855c522 Update Clang and Xcode SDK to 12B5025f
> >     76f9b6ad Use fetch instead of cherry-pick for Gerrit changes
> >     a3d69e87 Don't return if package is up-to-date
> >     36ff17cb Switch back to the older Clang version
> >     7bcc0eb3 Revert "Update Xcode SDK to 12B5025f"
> >     e5f1f587 Update Xcode SDK to 12B5025f
> >     6453c5de Support cross-compiling GN for other targets
> >     42d6de6e Don't classify Rust static libraries as final
> >     a9eaeb80 Switch remaining stamp targets to phony targets
> >     ff45cf2a Show config.visibility in `gn desc`
> >     de5a8348 [rust project] removing obsolete std libraries
> >     4c684398 Fix "gn outputs" for bundle data.
> >     99f72f88 Switch source_set stamp targets to phony targets
> >     5233fa13 Remove extra * in gn output docs
> >
> > As of 99f72f88 and a9eaeb80, GN's usage of stamp files for intermediate
> > steps in the build graph have been replaced with phony aliases. As a
> > result, this CL also updates the MB tool to look for ".runtime_deps"
> > files instead of ".stamp.runtime_deps".
> >
> > This is a reland of 7f3e4855
> >
> > Change-Id: I5bf18f1529b0969b8c79d768e9b3f377b8dee8cb
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514460
> > Reviewed-by: Dirk Pranke <dpranke@google.com>
> > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > Cr-Commit-Position: refs/heads/master@{#823725}
>
> TBR=dpranke@google.com,rjascani@google.com
>
> Change-Id: Iebf4e78bd9e7550de3b025a997d4f792c3f80b1b
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518755
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Commit-Queue: Dirk Pranke <dpranke@google.com>
> Cr-Commit-Position: refs/heads/master@{#823727}

TBR=dpranke@google.com,rjascani@google.com

# Not skipping CQ checks because this is a reland.

Change-Id: I86d184461002eacaf42a96f1ea8901269ff7e856
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518093Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#823791}

Part 3 of the work to allow wpt to set timezone during the test.
This allow ChromeDriver to set the default host timezone in the test.

* Design Doc: https://docs.google.com/document/d/1QAMHl7qIfGyFmWxta8OpR2YwivwaVgX_ixG17QWAgd0/edit#
* API Spec of the SetTimezone WebDriver Extension:
https://docs.google.com/document/d/12vdPTH_Vlkt4pxwlWzR1CjKtLE6y2Z-Qs-GPi_hWXqc/edit#
* Design Doc of the "Chromium DevTools design doc: timezone emulation"
https://docs.google.com/document/d/1ZH2jw1uFWX5uKwiIwv9mgpyBBAdwv95nb8gIRuX4W3k/edit#heading=h.7nki9mck5t64



Bug: 1144403
Change-Id: Iae396a68fb79152a684f95a989c430f4e91c86f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512788Reviewed-by: Shengfa Lin <shengfa@google.com>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Shengfa Lin <shengfa@google.com>
Cr-Commit-Position: refs/heads/master@{#823790}

The CertVerifier implementations are moving out of the network
service and into the CertVerifierService for sandboxing reasons.

Creators of NetworkContexts need to provide a pipe to a
CertVerifierService in the NetworkContextParams. This CL does that
for some remaining ChromeOS unittests.

The CertVerifierService also requires an IO thread on ChromeOS,
so some unittests switch to using BrowserTaskEnvironment instead
of the other various test::TaskEnvironments.

Bug: 1015134, 1094483
Change-Id: I3fb3097492b3d3a9de7572fbabddd5a041580a0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515203Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823789}

This will still work after git "master" branch is renamed to "main",
and makes inclusive language dashboards easier to interpret right now.

R=khorimoto@chromium.org

Bug: none
Test: none
Change-Id: I7c4ab86938bf18cf6fb29673ba177b98a48efbcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518831Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Miriam Zimmerman <mutexlox@chromium.org>
Reviewed-by: Sonny Sasaka <sonnysasaka@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823788}

This CL was uploaded by git cl split.

R=nasko@chromium.org

Bug: 1142671
Change-Id: Iceb1065802ea3c66095b289cca615a6f21201e98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500486
Auto-Submit: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823787}

This CL adds consideration for a frame's visible_rect when creating an
image bitmap, instead of using only the coded_rect. This fixes rows of
pixels being repeated at the bottom of an image.

Bug: 1145244
Change-Id: I534a9e768203ceee889827c370d2acfd574c77fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518108Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823786}

With the default size, tests cannot be run multiple times without
amberctl gc. See fxbug.dev/60978.

Change-Id: Ifebe7c046ead1fd302a7f3b549ae28d0499f94a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516885
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823785}

R=asvitkine@chromium.org

Bug: 1127953
Change-Id: Iee900b43fc62f6e654fb9434033dd6a93fe12185
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510671
Auto-Submit: Gabriel Charette <gab@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823784}

crrev.com/i/3380959 allocates their machines, so this shouldn't land
until that does.

Bug: 1140727
Change-Id: Ieb61391caafbb70416bda879dbacbfd60a35b5db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518409Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823783}

This fixes a regression after [1].  The issue is that
GetKeySymsForUnicode() doesn't handle all characters.  This CL ports
the relevant part of XStringToKeysym() to match the behavior before the
regression.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2436787/5/remoting/host/linux/x11_keyboard_impl.cc#108

R=rkjnsn

Bug: 1144251
Change-Id: I91a3d42d0029e57c9e5a8cb8ee74b7bc76c00100
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518282Reviewed-by: Erik Jensen <rkjnsn@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823782}