GitLab

This papers over the asserts that are occurring on the trybots by
changing the failing DCHECKs to not fail the reason for the failure
was IOSurfaceIsInUse returning YES unexpectedly.

This lets the asserts stay (mostly, completely on non-Mac platforms) in
place, but un-breaks the tryservers.

BUG=577121
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1688953002

Cr-Commit-Position: refs/heads/master@{#374786}

https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/9cc4f2f79988..8eecac0feef4

$ git log 9cc4f2f79..8eecac0fe --date=short --no-merges --format='%ad %ae %s'
2016-02-09 davidben Remove use_system_libsrtp build knob.

BUG=501318

Review URL: https://codereview.chromium.org/1685283002

Cr-Commit-Position: refs/heads/master@{#374785}

These proxy LayoutSVGInline and LayoutSVGTextPath, respectively.
The LineLayoutSVGInline class currently has no proxied methods, but
it is an ancestor for LineLayoutSVGTextPath, which has two new
proxied methods, layoutPath() and calculateStartOffset(). Both
methods are called from SVGTextLayoutEngine.

There are no functional changes.

BUG=499321
TBR=leviw

Review URL: https://codereview.chromium.org/1665413003

Cr-Commit-Position: refs/heads/master@{#374784}

Custom frames on Win 10 are just like custom frames on <10.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1683873003

Cr-Commit-Position: refs/heads/master@{#374783}

This CL wraps the edit dictionary page in .settings-box
.block and indents the word list using .list-frame.

BUG=512479

Review URL: https://codereview.chromium.org/1687753002

Cr-Commit-Position: refs/heads/master@{#374782}

The bot was removed a while ago.

BUG=
TBR=martiniss@chromium.org,stip@chromium.org

Review URL: https://codereview.chromium.org/1691563002

Cr-Commit-Position: refs/heads/master@{#374781}

Chromecast code depends on media:: alsa code, so enable it by default.
use_pulseaudio will continue to be false when is_chromecast=true.

BUG= b/27105215
TEST= Builds on several Cast platforms.

Review URL: https://codereview.chromium.org/1678103007

Cr-Commit-Position: refs/heads/master@{#374780}

For provided file systems;
a) Directory tree only navigates open nodes.
b) Tree closes child nodes when parent closes.
c) Expander arrows are always added rather than traversing the children to determine if needed.
d) Expander arrows will disappear if expanded and there is no content.

BUG=584404

Review URL: https://codereview.chromium.org/1667163003

Cr-Commit-Position: refs/heads/master@{#374779}

This change removes the code to create a Mojo app containing device
services (currently only USB) and instead makes the Mojo bindings for
//device/usb part of that directory.

The Mojo service implementation is still in a separate //device/usb/mojo
target but this will eventually merge into its parent directory as the
Mojo interface becomes the only public interface for //device/usb.

BUG=None

Review URL: https://codereview.chromium.org/1682363002

Cr-Commit-Position: refs/heads/master@{#374778}

R=kbr@chromium.org
BUG=584872

Review URL: https://codereview.chromium.org/1684203002

Cr-Commit-Position: refs/heads/master@{#374777}

https://chromium.googlesource.com/chromium/src/+/0c7e2f7bc

BUG=581355
TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/1690803002 .

Cr-Commit-Position: refs/heads/master@{#374776}

https://chromium.googlesource.com/chromium/src/+/0c7e2f7bc

BUG=581355
TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/1687093005 .

Cr-Commit-Position: refs/heads/master@{#374775}

DataUse UI message strings shown in snackbars and interstitial dialogs,
should be changeable via Finch.

Since the UI string overrides in Finch are not accessible from java
localization API, a JNI wrapper is used to get the overrides from C++
to java.

BUG=485160

Review URL: https://codereview.chromium.org/1678943002

Cr-Commit-Position: refs/heads/master@{#374774}

BUG=514719

Review URL: https://codereview.chromium.org/1670753003

Cr-Commit-Position: refs/heads/master@{#374773}

TBR=oilpan-reviews
BUG=552289

Review URL: https://codereview.chromium.org/1689773002

Cr-Commit-Position: refs/heads/master@{#374772}

Revert of  Clean up public interface of AttachmentBrokerUnprivileged. (patchset #4 id:80001 of https://codereview.chromium.org/1679763002/ )

Reason for revert:
c:\b\build\slave\win\build\src\remoting\host\remoting_me2me_host.cc(937) : error C2065: 'attachment_broker_' : undeclared identifier

http://build.chromium.org/p/chromium/builders/Win/builds/40168

Original issue's description:
> Clean up public interface of AttachmentBrokerUnprivileged.
>
> In the old interface, a static factory method returns a scoped_ptr, and the
> caller had to manage the lifetime. Since this is a global object with minimal
> memory footprint, and is required to outlive every IPC::Channel, it's much
> easier for the global to never be destroyed. This also matches the interface for
> AttachmentBrokerPrivileged.
>
> BUG=584297

TBR=tsepez@chromium.org,avi@chromium.org,mseaborn@chromium.org,sergeyu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=584297

Review URL: https://codereview.chromium.org/1688433005

Cr-Commit-Position: refs/heads/master@{#374771}

All methods used for generating the underlying matrix in asMatrix
are in MatrixTransformComponent.cpp

Constructs each MatrixTransformComponent for use in
asMatrix methods manually, rather than using inbuilt
methods to avoid unnecessary matrix multiplication.
(With the exception of rotate and rotate3d, as they require
far more complex calculations.)

Note: asMatrix for a MatrixTransformComponent returns a clone.

BUG=545318

Review URL: https://codereview.chromium.org/1648853002

Cr-Commit-Position: refs/heads/master@{#374770}

improves performance ~11-22% depending on the device and whether the
image was lossless or lossily compressed.

BUG=416951

Review URL: https://codereview.chromium.org/1657113002

Cr-Commit-Position: refs/heads/master@{#374769}

Replace dependencies on SQLite's Pager and DbPage structures with local
wrappers, in preparation for rewriting those wrappers in terms of
sqlite3_file.  The primary substantive change is that RecoverPager is an
owned reference, while Pager was a reference shared with SQLite at
large.  DbPage already needed ref-counting so RecoverPage matches that.

BUG=584407

Review URL: https://codereview.chromium.org/1671043003

Cr-Commit-Position: refs/heads/master@{#374768}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/26c72b54..4e3834b0

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1685193002

Cr-Commit-Position: refs/heads/master@{#374767}

This change renames WebRtcLocalAudioRenderer to TrackAudioRenderer and
re-purposes it for rendering all local MediaStream audio tracks, and
non-PeerConnection/WebRTC-sourced remote audio tracks (e.g., Cast
Streaming).  In addition, a number of small functional changes were made
to fix audio glitching, especially surrounding Start/Stop/Mute
operations:

1. Improved accuracy of GetCurrentRenderTime(), based on audio sample
counts rather than using the system clock.

2. Removed the stopping of audio render on mute.  This would cause the
video player to freeze the video unintentionally.

3. Drop/re-create AudioShifter on any pause-then-play, audio format
change, or output device change.  The existing Flush() mechanic was
causing weird time-shifting effects when the audio data flow was
restarted due to retaining the old timing data history.

4. Corrected a timing calculation in the playout_time passed to
AudioShifter::Pull().  Since the playout_time is supposed to be "in the
future," the correct timestamp should be "now plus audio delay" and not
"now minus audio delay."

5. Removed legacy call to GetOptimalBufferSize() for the audio output
buffer size.  After reviewing the history on this code, I believe it
was probably just masked issues that were recently resolved by
AudioShifter.  Testing demonstrated the extra buffering was not
needed.

Other changes: Clarified and refreshed documentative code comments.  Code
clean-ups in media_stream_renderer_factory_impl.cc (e.g., removed output
argument in favor of a return value).

Testing:

1. Connected a chrome.tabCapture.capture() MediaStream to a local VIDEO
element and confirmed reliable playback with good AV sync.

2. Using https://webrtc.github.io/samples/src/content/peerconnection/pc1/
to confirm the WebRTC use case was not broken.

3. Cast Streaming loopback testing (using a simple test extension).

BUG=577881, 577874

Review URL: https://codereview.chromium.org/1633423002

Cr-Commit-Position: refs/heads/master@{#374766}

Review URL: https://codereview.chromium.org/1685233002

Cr-Commit-Position: refs/heads/master@{#374765}

chrome::GetTotalBrowserCount() and ChromeWebUsbPermissionBubble::Bind are not available on Android, and their invocation cause a link error on Android GN build.
The caller is also not used on Android, and seems to be GCed on GYP build.

This CL ifdefs out the problematic code to fix it.

Review URL: https://codereview.chromium.org/1684043002

Cr-Commit-Position: refs/heads/master@{#374764}

In order to make the code changes easier to reason about, this is now part 1
of a two-part commit. In this commit, the existing code is moved from
content/common and content/child into content/renderer (it isn't used anywhere
else). In part 2, the keys are moved out of content into the embedder.

Part 2: https://codereview.chromium.org/1653263005/

BUG=543220

Review URL: https://codereview.chromium.org/1680873002

Cr-Commit-Position: refs/heads/master@{#374763}

Just use v2 instead ;) (compiled_resources2.gyp)

R=maruel@chromium.org,cpu@chromium.org
BUG=585553

Review URL: https://codereview.chromium.org/1686663002

Cr-Commit-Position: refs/heads/master@{#374762}

Remove the Android, Linux, and Windows Perf bot entries.
These were abandoned in: https://codereview.chromium.org/1681033003/
FYI Waterfall: https://build.chromium.org/p/chromium.mojo/console

BUG=585610
TEST=FYI Waterfall no longer lists these unused bots.
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1684843003

Cr-Commit-Position: refs/heads/master@{#374761}

size_t is not sufficient when the browser is 32 bit and the renderers are 64 bits.

BUG=581409,585382

Review URL: https://codereview.chromium.org/1685883004

Cr-Commit-Position: refs/heads/master@{#374760}

In the old interface, a static factory method returns a scoped_ptr, and the
caller had to manage the lifetime. Since this is a global object with minimal
memory footprint, and is required to outlive every IPC::Channel, it's much
easier for the global to never be destroyed. This also matches the interface for
AttachmentBrokerPrivileged.

BUG=584297

Review URL: https://codereview.chromium.org/1679763002

Cr-Commit-Position: refs/heads/master@{#374759}

BUG=585268,568130

Review URL: https://codereview.chromium.org/1684953002

Cr-Commit-Position: refs/heads/master@{#374758}

Changes:
https://chromium.googlesource.com/chromiumos/platform/system_api/+log/d9ecb3bd..ac14fd16

ac14fd1 system_api: Add kGetKioskAppRequiredPlatforVersion for update_engine

BUG=577783

Review URL: https://codereview.chromium.org/1684213002

Cr-Commit-Position: refs/heads/master@{#374757}

- create application shortcuts dialog
- permissions bubble view

BUG=585254, 585014

Review URL: https://codereview.chromium.org/1673403002

Cr-Commit-Position: refs/heads/master@{#374756}

Also blacklist a few more bots in manage.py.

This mostly affects the Clang ToT and the clang/win FYI bots:

$  testing/buildbot/manage.py --convert content_unittests
Convert content_unittests to run exclusively on Swarming
4 used to run locally and were converted:
- chromium.fyi.json: ClangToTLinux tester
- chromium.fyi.json: ClangToTMac tester
- chromium.fyi.json: ClangToTMacASan tester
- chromium.fyi.json: CrWinClang64(dbg) tester

$  testing/buildbot/manage.py --convert components_unittests
Convert components_unittests to run exclusively on Swarming
18 used to run locally and were converted:
- chromium.fyi.json: Chromium Win 10
- chromium.fyi.json: ClangToTLinux tester
- chromium.fyi.json: ClangToTLinuxASan tester
- chromium.fyi.json: ClangToTMac tester
- chromium.fyi.json: ClangToTMacASan tester
- chromium.fyi.json: ClangToTWin tester
- chromium.fyi.json: ClangToTWin(dbg) tester
- chromium.fyi.json: ClangToTWin(dll) tester
- chromium.fyi.json: ClangToTWin64 tester
- chromium.fyi.json: ClangToTWin64(dbg) tester
- chromium.fyi.json: ClangToTWin64(dll) tester
- chromium.fyi.json: CrWinClang tester
- chromium.fyi.json: CrWinClang(dbg) tester
- chromium.fyi.json: CrWinClang(shared) tester
- chromium.fyi.json: CrWinClang64 tester
- chromium.fyi.json: CrWinClang64(dbg) tester
- chromium.fyi.json: CrWinClang64(dll) tester
- chromium.fyi.json: CrWinClangLLD tester

$  testing/buildbot/manage.py --convert content_browsertests
Convert content_browsertests to run exclusively on Swarming
2 used to run locally and were converted:
- chromium.fyi.json: ClangToTLinux tester
- chromium.fyi.json: CrWinClang64(dbg) tester

BUG=98637,82385

Review URL: https://codereview.chromium.org/1683253003

Cr-Commit-Position: refs/heads/master@{#374755}

Previously there were cases where MediaCodec#stop would be called while
the MediaCodec was in a broken state, which results in hitting a CHECK.
In AVDA we don't actually need to call stop() because it's always called
right before deleting the MediaCodec. This replaces those calls with
explicit deletion.

BUG=582275
TEST=Trying to play videos with unsupported profiles; no crashes

Review URL: https://codereview.chromium.org/1687143002

Cr-Commit-Position: refs/heads/master@{#374754}

When creating a WebGL canvas, and when allocating a 2D canvas backing,
the implementation was triggering an immediate style calculation
to evaluate the image-redering CSS property.  This CL gets rid of of
these calculations by relying on the fact that if the style is dirty,
it will be updated before the next paint, which will allow for the state
to be corrected after the fact, if necessary.

BUG=585135

Review URL: https://codereview.chromium.org/1674123003

Cr-Commit-Position: refs/heads/master@{#374753}

Missed this one first time around.

BUG=none

Review URL: https://codereview.chromium.org/1684193002

Cr-Commit-Position: refs/heads/master@{#374752}

This CL adds BluetoothRemoteGattServiceWin to BluetoothDeviceWin. The upcoming CL will implement BluetoothRemoteGattServiceWin.

BUG=579202

Review URL: https://codereview.chromium.org/1681853003

Cr-Commit-Position: refs/heads/master@{#374751}

Leftover from the previous cleanups.
Previously, when base did pretend to not know anything about allocator,
tc_set_new_mode was invoked by the content layer (in content_main).
But this required this base unittest to mimic the same content behavior.

These days, instead, tc_set_new_mode() is called by base's
EnableTerminationOnOutOfMemory(). This test is already invoking
EnableTerminationOnOutOfMemory() in its initialization, so there is
no need to perform a 2nd call to tc_set_new_mode.

Also this makes the code in this test conceptually cleaner and smaller.

BUG=564618
TEST=base_unittests

Review URL: https://codereview.chromium.org/1683153002

Cr-Commit-Position: refs/heads/master@{#374750}

We tried dropping this, but there are still uninitialized bytes
somewhere. Zero them again for now.

BUG=585804
TBR=amistry@chromium.org

Review URL: https://codereview.chromium.org/1684733004

Cr-Commit-Position: refs/heads/master@{#374749}

BUG=584828

Review URL: https://codereview.chromium.org/1691533002

Cr-Commit-Position: refs/heads/master@{#374748}

Now GetResponseHeaders won't check the navigation state, instead it will just return a nullptr if there are no response headers available.
In some cases the response headers are not available, but in the previous code there's no safe way to know that.
This removes the CHECK for the navigation state that was causing this problem.

BUG=526291
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1681703002

Cr-Commit-Position: refs/heads/master@{#374747}