- 31 Jan, 2018 40 commits
-
-
Joel Einbinder authored
Bug: 805837 Change-Id: Ib24d46b9ed98b1264c0ff009ac40846ce254c44f Reviewed-on: https://chromium-review.googlesource.com/887640Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#533205}
-
Darren Shen authored
We untentative CSSPositionValue tests. We also split happy and sad tests Spec: https://drafts.css-houdini.org/css-typed-om-1/#positionvalue-objects TBR=nainar@chromium.org Bug: 774887 Change-Id: I33052e0dc6400f5de693da9449d769012919dee3 Reviewed-on: https://chromium-review.googlesource.com/894748Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#533204}
-
Kunihiko Sakamoto authored
This adds MerkleIntegritySourceStream class which decodes and validates the "mi-sha256" content encoding [1]. This class will be used by WebPackageLoader to verify integrity of message body. [1] https://tools.ietf.org/html/draft-thomson-http-mice-02 Bug: 803774 Change-Id: I62353f594e30e90fa982a68374389267b39c21fe Reviewed-on: https://chromium-review.googlesource.com/892844 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#533203}
-
Aaron Leventhal authored
When screen readers traverse a <table role="presentation">, they need generic container objects in place of the cells, to help them understand and present formatted content. Specifically, this helps present the text without jamming it together, as well as providing line breaks. Bug: 787664 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I53b691f0ccae3f4090ca0f8ecfcbeb622bd3dfeb Reviewed-on: https://chromium-review.googlesource.com/887599 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#533202}
-
Patti authored
Since r522281, the Flash permission is always shown in the Page Info bubble. This was a temporary measure to increase its discoverability after all non-factory-default permissions were removed in r503089, but it isn't an ideal solution - for example, it might imply that the site is using Flash when it isn't. Replace this with a more permanent solution - if the user has changed Flash before on a particular site, always show Flash in that site's Page Info bubble. Bug: 791142 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5bd7ee74cffeee8fe87743b9c0d7336021c52da0 Reviewed-on: https://chromium-review.googlesource.com/858245 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#533201}
-
Kevin Marshall authored
Generates an alternative runner script for each test target, with a "_v2" suffix, e.g. run_base_unittests_v2. The old-style generated runner scripts will still be without the "_v2" suffix, but they will be deprecated and removed soon as part of a followup CL. The new scripts will bring up a new QEMU VM, a Zedboot physical device, or continue to use an existing device that is currently accepting SSH connections. Once connected, the scripts push the package bits onto the device, execute the package using SSH, extract the build logs and other artifacts from the device, and finally clean up the state. Other changes: * Add DeviceTarget impl for deployment. * Use relative paths in package archive manifests, for symbolization. * Add logging statements everywhere, and a -v switch to turn them on. * Add package cleanup teardown step, to avoid cluttering up long-running devices. * Refactor symbolization as a stream filter object. Bug: 799309 Change-Id: Iffaefd1d3a5ce919ba2dea4e29033987454c2eed Reviewed-on: https://chromium-review.googlesource.com/882441 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#533200}
-
Ilya Sherman authored
R=asvitkine@chromium.org Bug: 727984 Change-Id: I1ac800cce5cbfc7de67885ac6f9c3c6a715f25cb Reviewed-on: https://chromium-review.googlesource.com/892323 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#533199}
-
Kurt Horimoto authored
This CL adds a new animator, FullscreenForegroundAnimator that is sent to FullscreenControllerObservers upon receipt of an application foreground notification. This CL also updates FullscreenUIElements to show the toolbar using this animator. Bug: 806694 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9470602d5535964ea0a054c949ccaba0225e5ed3 Reviewed-on: https://chromium-review.googlesource.com/894355 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#533198}
-
Blake O'Hare authored
Currently, there is a field on KeyboardController for enqueuing a container type change. Eventually we want to support invoking a JS callback to notify the extension when a keyboard mode changes. This is the first step in that direction. Instead of persisting a single enum value for the enqueued container behavior, it tracks both the type and a callback handle. This QueuedContainerBehavior object will invoke the callback once it goes out of scope. Change-Id: Iea4e96259314a34d31661342024a23617a9f4b74 Bug: 806189 Reviewed-on: https://chromium-review.googlesource.com/888119 Commit-Queue: Blake O'Hare <blakeo@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#533197}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I6da287c075108f37858f4d7d5d0e2f79dfcb111d Reviewed-on: https://chromium-review.googlesource.com/894583Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#533196}
-
Peter Kasting authored
BUG=none TEST=none Change-Id: I310a3b6ba78a2eebdc87ffe9a35df05f707b1277 Reviewed-on: https://chromium-review.googlesource.com/894299Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#533195}
-
Takuto Ikuta authored
This is re-land of https://chromium-review.googlesource.com/891043 Changed not to increase link parallelism for chrome on chromeos. Bug: 807145 Change-Id: I11c49d215704556eaa709af08ffe7226c3df529d Reviewed-on: https://chromium-review.googlesource.com/892779 Commit-Queue: Takuto Ikuta <tikuta@google.com> Reviewed-by:
-
Zhiheng Vincent Li authored
Bug: b/72666690 Change-Id: Ia31ca2fd81d7fe2edb264da5b19ba899be1a3ce3 Reviewed-on: https://chromium-review.googlesource.com/892404Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com> Cr-Commit-Position: refs/heads/master@{#533193}
-
Wang Qing authored
Currently, tcmalloc is not supported on loongson, and the build failed with use tcmalloc. This CL adds support for tcmalloc on loongson, and resolves many compiler errors, bugs when test base_unittests on loongosn. Bug: 799810 R= wfh@chromium.org, thakis@chromium.org Change-Id: I68bea09334cb9af02d083a24a94654aaf6c884c8 Reviewed-on: https://chromium-review.googlesource.com/853695Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: 汪 清 <wangqing-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#533192}
-
Joel Einbinder authored
Change-Id: I922866e17652a3f202207a5e690e97d2da26065f Reviewed-on: https://chromium-review.googlesource.com/879065Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#533191}
-
Yuichiro Hanada authored
Bug: 750526 Change-Id: Id8a2dd90b835279e6dc39de493e174c563bf7493 Reviewed-on: https://chromium-review.googlesource.com/892682 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#533190}
-
Alexei Filippov authored
BUG=803276 Change-Id: I2076d974810c247ec79ac36897a54dc58e80c4a9 Reviewed-on: https://chromium-review.googlesource.com/894884Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#533189}
-
Maks Orlovich authored
Bug: 636400 Change-Id: Ic4a49a72dcae73f1bd2d909a0e86439f7c075061 Reviewed-on: https://chromium-review.googlesource.com/779742Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#533188}
-
Megumi Hattori authored
The reply button should be white when the textfield is not empty, and should be transparent white when the textfield is empty. However, when text is cut or pasted using mouse or finger and the textfield become empty or not, the reply button color does not change. This CL resolved this bug. Bug=803759 Change-Id: Ie307a924b41bddc88f60d9dc1b7ab230e639e0c7 Reviewed-on: https://chromium-review.googlesource.com/890843 Commit-Queue: Megumi Hattori <megumihattori@google.com> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#533187}
-
Xiaocheng Hu authored
This patch removes all call sites of DeprecatedDumpFrameTreeAsText, except the only one in ChromeRenderFrameObserver, which is improper. This is a preparation for fixing ChromeRenderFrameObserver without affecting other code paths. Bug: 803403 Change-Id: I1873f3759533873a3068b45cc55743b4bb9758d6 Reviewed-on: https://chromium-review.googlesource.com/891543Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#533186}
-
Hidehiko Abe authored
BUG=784732 TEST=Ran trybot. Change-Id: Icbb9c5596b045ca0c684cdad0343a2605d00dbb1 Reviewed-on: https://chromium-review.googlesource.com/856296Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#533185}
-
Joshua Bell authored
Issue reported by canary dogfooder: the promise returned by navigator.locks.query() would never resolve if no locks were held. In debug builds, this would DCHECK. The code would early-exit without running the callback in this case - a no-no. Added fix (return empty arrays) and test case. Bug: 807070 Change-Id: Ib4abd5d861c5ab259f7ea00355aebd006438508e Reviewed-on: https://chromium-review.googlesource.com/891584 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#533184}
-
Christopher Cameron authored
Add a mechanism for allowing an autoresize frame to resize the renderer's surface. When in auto-resize, make BrowserCompositorMac not update its size based on the NSView size. Bug: 805774 Change-Id: Ibc0b8b14ec7c1f4bdef30ac815d759f5894ab315 Reviewed-on: https://chromium-review.googlesource.com/892288 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#533183}
-
Dmitry Gozman authored
BigString uses BigBuffer internally to accomodate large strings. It maps to std::string and WTF::String and internally converts data to UTF8 similary to regular string. Bug: 776009 Change-Id: I05547f6f55f0a20dafd6a3d99e26b5cc2cbe2eed Reviewed-on: https://chromium-review.googlesource.com/891980 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#533182}
-
Wei Guan authored
BUG=803706 Change-Id: I5c1d7476d27e9ce35e9bd758351e6ebc22e43771 Reviewed-on: https://chromium-review.googlesource.com/884008Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Wei Guan <weigua@chromium.org> Cr-Commit-Position: refs/heads/master@{#533181}
-
Trent Apted authored
This reverts commit 02e508ce. Reason for revert: compile failure https://ci.chromium.org/buildbot/chromium.win/Win%20x64%20Builder%20(dbg)/62497 ../../ui/keyboard/keyboard_test_util.cc(99,17): error: 'keyboard::TestKeyboardUI::TestKeyboardUI' redeclared without 'dllimport' attribute: 'dllexport' attribute added [-Werror,-Winconsistent-dllimport] TestKeyboardUI::TestKeyboardUI(ui::InputMethod* input_method) Original change's description: > Use the centralized TestKeyboardUI instead of ash-test-specific ones > > This is mostly duplicate code. > > Bug: > Change-Id: Id152dc65ef53eac65d40ef38b6b9da3f962ae9ba > Reviewed-on: https://chromium-review.googlesource.com/832295 > Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Commit-Queue: Blake O'Hare <blakeo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533168} TBR=oshima@chromium.org,yhanada@chromium.org,blakeo@chromium.org Change-Id: I0e7fedec0f8d5de8eb069bb2cd85f86009a4d55e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/895084Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#533180}
-
Ovidio Henriquez authored
This change ensures that tests that are ready to be migrated into wpt/ will contain consistent formatting. This includes a test_desc constant describing the test and consistent indentation. BUG=509038 Change-Id: If04b5cdd796709b8080960550cf216297e8d38f6 Reviewed-on: https://chromium-review.googlesource.com/891989 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#533179}
-
Trent Apted authored
This reverts commit 58ab87ff. Reason for revert: suspected for lsan browser_tests and mus_browser_tests failures since https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/25937 - AppBannerManagerBrowserTest.CheckOnLoadWithSufficientEngagementCancelBannerAfterPromptInHandler - AppBannerManagerBrowserTest.ExperimentalFlowWebAppBannerReprompt - AppBannerManagerBrowserTest.ExperimentalFlowWebAppBannerPromptNeedsGesture (and others in later runs)> Possibly timeout related. Original change's description: > Consolidate app banner testing. > > This CL removes several different app banner testing files, and replaces > them by calling the necessary JavaScript setup code in one test file. > For instance, all tests will no longer have the "appinstalled" title > overwriting, as that will only be active when the appropriate setup > JavaScript is run. > > This allows future tests to be more easily added, and reduces collisions > when manipulating the page title. > > BUG=806923 > > Change-Id: Ia28837b8675a2e1fe329cb1df1be4798ddb03d02 > Reviewed-on: https://chromium-review.googlesource.com/892182 > Commit-Queue: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Matt Giuca <mgiuca@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532978} TBR=mgiuca@chromium.org,dominickn@chromium.org Change-Id: Ie030290324c689b3df616de9aa35b6e52e7584c5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 806923 Reviewed-on: https://chromium-review.googlesource.com/895024Reviewed-by:
-
Claudio Magni authored
Currently some locales cannot be selected by the user as display UI, but this leads to a confusing experience because there are UI locales that are very similar (i.e. 'English' cannot be selected, but 'English (USA) can). This change fixes that. We increase the set of locales that can be selected and store the user selection in the Translate Prefs. Every time we read the Pref, we convert locales to their corresponding fallback if applicable. Bug: 719435 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1e41cb7d3a39160fbfb05571a573c1ebed2a7f91 Reviewed-on: https://chromium-review.googlesource.com/838726 Commit-Queue: Claudio M <claudiomagni@chromium.org> Reviewed-by:
Michael Martis <martis@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Elliot Glaysher <erg@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@google.com> Cr-Commit-Position: refs/heads/master@{#533177}
-
Matt Mueller authored
Updates the test data to have the target cert be issued by a non-self-issued certificate so that it can catch this error. Change-Id: I2ea34a3c8c8864fe99a10b9931c8d022ca9de021 Reviewed-on: https://chromium-review.googlesource.com/894740Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#533176}
-
John Abd-El-Malek authored
This is a reland of e1c22cc3. The change didn't actually break the build, it was http://crbug.com/644525 Bug: 644525 Original change's description: > Move url_loader_unittest.cc and network_service_unittest.cc to services/network. > > Their content dependencies have been removed in previous changes. > > Bug: 753658 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: Ic632759ef35cfef4e707d29acdc361ae836e9b62 > Reviewed-on: https://chromium-review.googlesource.com/893651 > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533113} Bug: 753658 Change-Id: If780785790fb2b56aff1d91ddeb781bab2e127a3 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/894895Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#533175}
-
Xing Liu authored
Currently Mojo Android bot can compile but will timeout during StartInstrumentation. This CL increases hard timeout for the swarm to wait longer. Failed bot log is here: https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.android%2Fandroid_mojo%2F19%2F%2B%2Frecipes%2Fsteps%2Fnetwork_service_content_browsertests__with_patch__on_Android%2F0%2Fstdout Bug: 783374 Change-Id: I153fa452e579aa5d4b3247e779756c89b929a692 Reviewed-on: https://chromium-review.googlesource.com/893902Reviewed-by:
Benjamin Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#533174}
-
Matt Reynolds authored
The Switch Pro controller is usable when connected by USB or Bluetooth, but defaults to a Bluetooth-only mode. This CL adds methods for recognizing Switch Pro controllers, sending the vendor-specific packets used for USB initialization and haptics, and reading controller data reports. BUG=801717 Change-Id: I076b001c5eda3c9e4900cb2a0ab19b78ef94d0da Reviewed-on: https://chromium-review.googlesource.com/891621Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#533173}
-
Andrey Lushnikov authored
This patch: - migrates TestMapping to use generic Persistence methods addBinding/removeBinding instead of creating a custom mapping algorithm. - removes enabling/disabling of automapping; instead, the automapping gets disposed. Since the removal of DefaultMapping, Persistence doesn't need to support different mapping algorithm implementations. BUG=805740 R=dgozman Change-Id: I5be46e4a3991011ae2bc7496619e4a1c9dcfb700 Reviewed-on: https://chromium-review.googlesource.com/892481 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
-
Yoichi Osato authored
This patch marks LayoutSelection::LayoutSelectionStartEndForNG and FrameSelection::LayoutSelectionStartEndForNG const because of the function constness. Bug: 708452 Change-Id: I462fa178a9c656f184f43aac62eedff552290219 Reviewed-on: https://chromium-review.googlesource.com/892943Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533171}
-
David Bokan authored
This CL converts this test to use testharness.js assertions rather than js-test.js and a pixel test. The impetus for this is the pixel diff when root layer scrolling is turned on. The difference it not related to what this test is checking (and is actually correct when RLS is turned on). See the bug (comment #7) for more details. Bug: 781431 Change-Id: Ida7c287b616b4fd166b436e9957f28bf794098d4 Reviewed-on: https://chromium-review.googlesource.com/894365Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#533170}
-
Yoshifumi Inoue authored
This patch introduces |VisibleUnitsWordTest.EndOfWordBasic| unit test to record current behavior as a preparation of the patch[1]. [1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify word/paragraph selection Bug: 778507 Change-Id: Ic65a6a646806465c05b1a8fb7d5213beeb71e6e4 Reviewed-on: https://chromium-review.googlesource.com/892761Reviewed-by:
-
Blake O'Hare authored
This is mostly duplicate code. Bug: Change-Id: Id152dc65ef53eac65d40ef38b6b9da3f962ae9ba Reviewed-on: https://chromium-review.googlesource.com/832295Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#533168}
-
Kyle Horimoto authored
This UI is shown on the settings page when a phone tells the Chromebook that it does not have GmsCore notifications enabled. This CL: (1) Updates HostScannerOperation to accept an additional enum value indicating that GmsCore notifications are disabled. (2) Updates the settings page to show an extra step which is needed in some cases to enable notifications. Bug: 793936, 672263 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I65f34db384956189e6ea3c157a57f48bc4701fe4 Reviewed-on: https://chromium-review.googlesource.com/894729Reviewed-by: -
Daniele Castagna authored
With crrev.com/c/889863 we aligned SCANOUT{_CPU_READ_WRITE,} formats. This CL adds BGRX_1010102 to {_CPU_READ_WRITE,}. Additionally, it adds RGBA_8888 and BGRX_8888 to GPU_READ_CPU_READ_WRITE and GPU_READ_CPU_READ_WRITE_PERSISTENT, effectively aligning all the format lists for each allowed usage. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0b789b66e0380f23d6071351746fdf94a354871e Reviewed-on: https://chromium-review.googlesource.com/894150Reviewed-by:ccameron <ccameron@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
-
