- 27 Mar, 2019 40 commits
-
-
Rayan Kanso authored
BackgroundSync.OptionConditionsChanged was collected to figure out if the extra condition before dispatching a sync event was useful. Collected metrics show that it increases reliability, so the histogram is no longer needed. Bug: 945548 Change-Id: I2a704d6f5147be7c8b643fbaeba33dececb5c7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539587Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#644729}
-
Maksim Sisov authored
This change is a prerequisite for having buffer manager to handle frame callbacks. Also, each window will be backed with own buffer manager, which is needed to ease handling of the frame callbacks. Now, zwp_linux_dmabuf Wayland factory is wrapped around WaylandZwpLinuxDmabuf and receives requests to create buffers backed by dmabuf file descriptor. Returns a wl_buffer on success via a provided callback. If failed, nullptr is returned. Bug: 943096 Change-Id: I85cff3ad7a12e26a4380b87d2933af377c436e4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539700 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#644728}
-
Roman Sorokin authored
Bug:945302, 869834 Change-Id: I047f6c54a1a6b197ea0faa1c6fe45abb8c8a43e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539044 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#644727}
-
Alan Cutter authored
This CL updates the PWA window pop out behaviour to keep the main browser window alive if the last tab is being popped out. This is consistent with the chrome:apps page which avoids closing the main browser window on app launch. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=385858&signed_aid=Kq3yezOhRl5_xuD2yksHBg==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=385859&signed_aid=YuYvdp1PuUzC-Z1mmR0cjw==&inline=1 Bug: 918822 Change-Id: I43b1b1404e0e97b89eddf456ccb2af36ade752ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534910Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#644726}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/db55340a2b03..b5a48042d7f2 git log db55340a2b03..b5a48042d7f2 --date=short --no-merges --format='%ad %ae %s' 2019-03-27 ahassani@chromium.org build_dlc: Add flag --package Created with: gclient setdep -r src/third_party/chromite@b5a48042d7f2 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I778102ed43abeac9f26eb53973477fbd87e620f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540744Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644725}
-
arthursonzogni authored
Disable: - ParameterRestrictions.ptrace_getregs_allowed - ParameterRestrictions.ptrace_syscall_blocked They have been introduced recently by: https://chromium-review.googlesource.com/c/chromium/src/+/1487519 Unfortunately, they aren't working yet on Android version L and M. Tbr: rsesek@chromium.org Bug: 934930 Change-Id: I22a5034ad6638ca3be7c0231c7e25445bd9720ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539849Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#644724}
-
Leon Han authored
For a controllee document, the initial set of used features of its controller service worker are sent to the renderer process as part of ControllerServiceWorkerInfo via navigation commit IPC, however, after that the controller service worker may have used some other new features, which are also needed to be propagated to the document in the renderer process for setting UseCounter correctly. Previously, the provider host holds off doing this until it received the ServiceWorkerContainerHost::OnProviderCreated() Mojo call. This CL postpones doing that further until the ServiceWorkerContainerHost::OnExecutionReady() Mojo call came, which should have no bad effect, but help reduce the burden of ServiceWorkerProviderHost::OnProviderCreated() to make it easier for us to remove the ServiceWorkerContainerHost::OnProviderCreated() Mojo call completely later. BUG=931092 Change-Id: Iaf8505576064bad76335c07e806eba35aa9c5e05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531824Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#644723}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0ce04fb00267..77a7821c0b61 git log 0ce04fb00267..77a7821c0b61 --date=short --no-merges --format='%ad %ae %s' 2019-03-27 lalitm@google.com Merge "trace_processor: make more explicit the concept of full partition shadow slices" Created with: gclient setdep -r src/third_party/perfetto@77a7821c0b61 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I61a6fbb17daa5da62e3d1e2afd4af49e26665a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540745Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644722}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2547d2cf2b12..b9bb3718e3bf git log 2547d2cf2b12..b9bb3718e3bf --date=short --no-merges --format='%ad %ae %s' 2019-03-27 hta@webrtc.org Revert "Don't crash when a datachannel can't get an ID" 2019-03-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ff1de589..69e6e3c1 (644450:644573) 2019-03-26 hta@webrtc.org Don't crash when a datachannel can't get an ID Created with: gclient setdep -r src/third_party/webrtc@b9bb3718e3bf The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:945256,chromium:None,chromium:945256 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I97709821ca661ced6f75587984fd5aaf5892c4fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540743Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644721}
-
Gauthier Ambard authored
This CL moves the external file remover files to their own category. It also moves them out of ios/c/b/ui, to ios/c/b. Bug: 944008 Change-Id: I78cfa2fbf7916696fd39a576fa8029d497192b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538279 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#644720}
-
Staphany Park authored
This is a reland of 85b389ca Initialized CacheRecord::padding_size to 0. Original change's description: > AppCache: Add padding to cross-origin responses. > > Bug: 918293 > Change-Id: I4f16640f06feac009d6bbbb624951da6d2669f6c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1488059 > Commit-Queue: Staphany Park <staphany@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644624} Bug: 918293 Change-Id: Ie1d3f99c7e8a854d33255a4d66243da2ce16441c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539906Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#644719}
-
Alexander Hendrich authored
This CL removes the unused |editable| variable in the ip config and nameserver settings page. It was always set to true and probably left over from some refactoring in the past. Bug: 919066 Change-Id: I13a1305b1a2d87f413ced4400b5a337ba37952f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539660Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#644718}
-
Corentin Wallez authored
This will allow viewing shared images as Dawn textures, for example so they can be rendered to via WebGPU. This representation is implemented for IOSurface-backed shared images. Also adds a test to render an IOSurface backed shared image using Dawn, and reading it back with Skia. BUG=chromium:938895 Change-Id: If64ea4a67368687ff54326bdb20094f17902ad2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511419 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#644717}
-
Julie Jeongeun Kim authored
This CL moves broadcastchannel folder from public/platform/modules to public/mojom to gather mojom files to mojom folder and updates paths for broadcast_channel.mojom. Bug: 919393 Change-Id: I463aff6e57a945a88dcb4944ff42565a4ba5f8b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535677 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#644716}
-
Daniel Bratell authored
The generated api_registration files use a lot of headers in chrome/browser/extensions, creating a dependency cycle. I see no obvious way to break the cycle so this just makes it official. There were also a couple of files in chrome/browser/accessibility which were used from api registration, creating an unpleasant dependency. That was fixed by putting those files in extensions instead of in chrome/browser. The missing dependencies triggered a lot of gn errors with a gn fixed to look at generated files (gn:57). The list is about 60 reports like: ERROR at //out/Default/gen/chrome/browser/extensions/api/generated_api_registration.cc:7:11: Include not allowed. ^-------------------------------------------------------------------------------- It is not in any dependency of //chrome/browser/extensions/api:api_registration The include file is in the target(s): //chrome/browser/extensions:extensions which should somehow be reachable. Bug: 655123 Change-Id: Ifc7809de17c9a426d2a6abdb41ecc42996b0d01f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529095Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#644715}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d1c271bd39f0..003e9f14f665 git log d1c271bd39f0..003e9f14f665 --date=short --no-merges --format='%ad %ae %s' 2019-03-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e747b3c3c9d9..df5b28fdb45c (1 commits) Created with: gclient setdep -r src/third_party/skia@003e9f14f665 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I2abe56c43d4f9faebbeaf542f78264d3bd2aa015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540385Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644714}
-
Friedrich Horschig authored
Moving the AutofillKeyboardAccessoryBridge to keyboard_accessory/ should simplify making the keyboard accessory a separate feature. It also means to add fhorschig@ to the OWNERS of this class. Bug: 945314 Change-Id: Ib9f623ce32666f4e18e7010407dbc4bb542e367b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538288Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#644713}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cee580409fb0..f6bcae1ce308 Created with: gclient setdep -r src-internal@f6bcae1ce308 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=robertocn@chromium.org,noel@chromium.org,eirage@chromium.org Change-Id: I3427a153ac1e472510da08de993af08c6ff8e646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537830Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644712}
-
Meng-Huan Yu authored
In CL:1423979, we added UMA for counting the parallel requests. BUG=920850, b:124719803 Change-Id: If52c71c9b71e3b4da886cec3433f7d9da8204d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1488486Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Meng-Huan Yu <menghuan@chromium.org> Auto-Submit: Meng-Huan Yu <menghuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#644711}
-
David Roger authored
With Mirror and Dice, unknown accounts in the Gaia cookie are not actively removed, to prevent unnecessary calls to /LogOut. In Mice mode, we want the accounts in the cookie to exactly match the accounts in the system, and thus only accounts known to Android are allowed in the cookie. Bug: 944826 Change-Id: I6c80c6207679b7828a5716571e6b7bbdde12a1bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538405Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#644710}
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance using MakeGarbageCollected<Foo> in //third_party/blink/renderer/core/dom, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. This CL is the second clean up in core/css. Bug: 939691 Change-Id: I94f5b8a74d48a1a34c3a814eb05c21a2b6508f21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540959Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#644709}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e747b3c3c9d9..df5b28fdb45c git log e747b3c3c9d9..df5b28fdb45c --date=short --no-merges --format='%ad %ae %s' 2019-03-27 swiftshader.regress@gmail.com Regres: Update test lists @ e747b3c3 Created with: gclient setdep -r src/third_party/swiftshader@df5b28fdb45c The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I668ba6e83ad694326b0a92167250155b606a1941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540149Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644708}
-
Yutaka Hirano authored
- Use mojom::ConsoleMessageSource instead of defining another enum. - Use mojom::ConsoleMessageLevel instead of having three functions. - Merge ConsoleLoggerImplBase into ExecutionContext. Bug: 914739 Change-Id: I0cc305d21345b5db7b3e801350cb5b86d165755e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539491 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#644707}
-
Tomasz Moniuszko authored
While content::TestHostResolver simulates failure for non-local DNS queries, some tests explicitly allow external DNS lookup using net::RuleBasedHostResolverProc::AllowDirectLookup(). With kNetworkService feature enabled, appropriate host resolver rule must be propagated to network process. Change-Id: Icc6eb96a8ea346d408d04d23feb363789a1c5c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533954Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Cr-Commit-Position: refs/heads/master@{#644706}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/5efb004d5960..5125eb58dbb5 git log 5efb004d5960..5125eb58dbb5 --date=short --no-merges --format='%ad %ae %s' 2019-03-27 johnkslang@users.noreply.github.com Merge pull request #1741 from dgkoch/shader_subgroup Created with: gclient setdep -r src/third_party/glslang/src@5125eb58dbb5 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ie85e2839fa268c4ac38fa1d264daa57ebcfb87d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540742Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644705}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3a6175755f55..cee580409fb0 Created with: gclient setdep -r src-internal@cee580409fb0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=sahel@chromium.org,horo@chromium.org,pkasting@chromium.org,andruud@chromium.org Change-Id: Ie4604a7c2a193b33e33ada68fa1421f7516bd222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540584Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644704}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I97c74ab829af3da3913e3db411777582724b8587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540547Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644703}
-
Ben Wells authored
Auto top level navigations include things like command line navigations, in product help links, and other similar navigations. It is possible for these types of navigations to earn engagement if they meet other checks (e.g. have a valid scheme). The reason to change this is to allow command line navigations to earn engagement. Bug: 944396 Change-Id: I7846675fd7955a2473c0951df60251661eaa1f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535201 Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#644702}
-
Sam McNally authored
Sort the file names - the order of entries passed to onLaunched is not deterministic so expecting a particular order is incorrect. Bug: 946025 Change-Id: I7c3933f916e8411e6b8357a7555999fe1ad6efe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539494 Commit-Queue: Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#644701}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/022c8317d085..d1c271bd39f0 git log 022c8317d085..d1c271bd39f0 --date=short --no-merges --format='%ad %ae %s' 2019-03-27 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2019-03-27 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@d1c271bd39f0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I301cd62ff3ea465033d36bd9cf43727f75bf9d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540546Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644700}
-
Alexey Baskakov authored
Rename AppInfo to InstallOptions to avoid confusion with WebApplicationInfo. We will reuse InstallOptions as a parameter object in web_app::InstallManager. Bug: 916381 Change-Id: I7e4ea7ea7986ca537d9327b190443e72c2a16661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535306 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#644699}
-
Yashar Dabiran authored
The design doc for this change: https://docs.google.com/document/d/1Qog5qwZ-6Rfx10AKkJxN-LrwhCw_GJ1xdLoQSnpsT1Q/ Changes in this CL: - Add origin trial functions to RuntimeEnabledFeatures class. To access the ExecutionContext for OT checks, FeatureContext class (defined in "runtime_enabled_features.h") has been added which ExecutionContext inherits from. - Support runtime features depending on origin trial features. * All of the OT check functions in "origin_trials.h" will be removed once all of the function calls are directed to |RuntimeEnabledFeatures| in the upcoming CLs. Bug: 934451 Change-Id: Iee47370c9309ddfbc27c17df9a5319c4a30e54a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495798Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Yashar Dabiran <yashard@google.com> Cr-Commit-Position: refs/heads/master@{#644698}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f02277bf..135b6f21 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idec8814dce8aa02013dd97965cce47e0523b98a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540545Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644697}
-
Raul Tambre authored
The script still works with Python 2. There are no intended behaviour changes. Bug: 941669 Change-Id: I1556e3083ce4b858ea2753ffd10ef2caac36df67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537100Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#644696}
-
Wei Li authored
Calling layout code in StatusView's constructor would need to call its parent's virtual functions as well, which may not be ready in its constructor. This fix moves layout code into Layout() function to avoid such problem. BUG=945650 Change-Id: I93526fe84e92d1f601dbb5d08cbf45e1a88c6fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539031Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#644695}
-
Luciano Pacheco authored
Move Drive context menu tests related to directory tree to directory_tree_context_menu.js. Delete tests for removable that have been migrated to directory_tree_context_menu.js. For both set of tests (Drive and Removable) were checking only 1 menu item, the new tests checks for all menu items on those entries. Remove TODOs that aren't relevant anymore. Change-Id: I92db7ac5229cd588066f1b47410e2b160549a916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534912 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#644694}
-
Naoki Fukino authored
This implements write operations in Chrome OS file system backend. It enables Files app to perform following operations. * Delete file in documents providers. * Rename file in documents providers. * Create file in documents providers. * Copy files inside the same document provider. * Move files inside the same document provider. Design doc: go/files-dp-rw Android side change: ag/6550846 Bug: 895479 Test: Manually tested, and ran unit_tests. Change-Id: I14f623cd39dc039477f0b0251a50fc3260e24345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490361 Auto-Submit: Naoki Fukino <fukino@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Shuhei Takahashi <nya@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#644693}
-
Findit authored
This reverts commit 85b389ca. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 644624 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzg1YjM4OWNhYTdkNzI1Y2RkMzFmNTllOWEyYjc5ZmY1NDgwNGI3YjcM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29%2832%29/57482 Sample Failed Step: content_unittests Original change's description: > AppCache: Add padding to cross-origin responses. > > Bug: 918293 > Change-Id: I4f16640f06feac009d6bbbb624951da6d2669f6c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1488059 > Commit-Queue: Staphany Park <staphany@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644624} Change-Id: Iab68370e154f858ae05b9cebc0e07ce666e93a1f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 918293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540723 Cr-Commit-Position: refs/heads/master@{#644692}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/62c6a3871085..022c8317d085 git log 62c6a3871085..022c8317d085 --date=short --no-merges --format='%ad %ae %s' 2019-03-27 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version 2019-03-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 a47e2a23ab4c..518c679da109 (3 commits) Created with: gclient setdep -r src/third_party/skia@022c8317d085 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I8af2057a80cbc7b054bca5a4a209fd0afc322bfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540462Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644691}
-
Simon Que authored
This reverts commit 58e8d8c6. Reason for revert: Cannot combine mixins Original change's description: > infra: Add and use mixins for Goma RBE server settings > > R=tikuta@chromium.org, ukai@chromium.org, yyanagisawa@chromium.org > > Bug: 945701 > Change-Id: I98b2a8a2d644eccde84224171bbe7e9885041046 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539416 > Commit-Queue: Simon Que <sque@chromium.org> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644219} TBR=sque@chromium.org,ukai@chromium.org,yyanagisawa@chromium.org,tikuta@chromium.org Change-Id: Ife0174d62bec2bf99d75647b864fd6c7992fa30e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 945701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539490Reviewed-by:
Simon Que <sque@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#644690}
-