- 17 Aug, 2016 40 commits
-
-
iclelland authored
This is an interim step to handle FeaturePolicy-enabled features, before the three conditional feature flags (RuntimeEnabled, OriginTrialEnabled and FeaturePolicy) are eventually combined into a common 'Feature' attribute. BUG=638240 Review-Url: https://codereview.chromium.org/2247923004 Cr-Commit-Position: refs/heads/master@{#412524}
-
hbos authored
main-thread DCHECKs from their destructors. CreateSessionDescriptionRequest and SetSessionDescriptionRequest are reference counted and have callback methods that are invoked on the signaling thread. If invoked on a non-main thread a post occurs to the main thread, referencing the object until the callback has completed on the main thread. There was an incorrect assumption that the object would also be destroyed on the main thread. But because the callback may sometimes complete before the signaling thread has had an opportunity to dereference the object it can be destroyed on the signaling thread. This CL allows it to be destroyed on any thread. BUG=634342 Review-Url: https://codereview.chromium.org/2222553002 Cr-Commit-Position: refs/heads/master@{#412523}
-
j.isorce authored
Make GpuProcess.driver_bug_workarounds_upon_gl_renderer and GpuProcess.no_gpu_process work on Android. For other tests it does not make sense to run them on Android because there is either no entry in kSoftwareRenderingListJson to trigger or no multi gpu configuration. About GpuProcess.skip_gpu_process, I could not reproduce the failure on Nexus 4. BUG=611930 R=kbr@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --browser android-content-shell CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/a2c5030470e9cee3ae35dc849c680530c2acf06a Committed: https://crrev.com/b34180e4f1fb9d4813b1e88984d288bd50b05751 Review-Url: https://codereview.chromium.org/2227893005 Cr-Original-Original-Commit-Position: refs/heads/master@{#410998} Cr-Original-Commit-Position: refs/heads/master@{#411213} Cr-Commit-Position: refs/heads/master@{#412522}
-
srirama.m authored
BUG=588956 Review-Url: https://codereview.chromium.org/2235333005 Cr-Commit-Position: refs/heads/master@{#412521}
-
eseckler authored
This is a follow up to crrev.com/2175163005, which hides composited native scrollbars. BUG=617618 Review-Url: https://codereview.chromium.org/2239313002 Cr-Commit-Position: refs/heads/master@{#412520}
-
olivierrobin authored
BUG=633099 Review-Url: https://codereview.chromium.org/2254603003 Cr-Commit-Position: refs/heads/master@{#412519}
-
vollick authored
BUG=430155 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2254623002 Cr-Commit-Position: refs/heads/master@{#412518}
-
charliea authored
BUG=638367 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Review-Url: https://codereview.chromium.org/2256473002 Cr-Commit-Position: refs/heads/master@{#412517}
-
guidou authored
TBR=rsleevi@chromium.org BUG=638576 Review-Url: https://codereview.chromium.org/2255753002 Cr-Commit-Position: refs/heads/master@{#412516}
-
jonross authored
Convert the context menu of TaskManagerView to use the ASYNC menu runtype. TEST=manual testing, ran TaskManagerViewTests BUG=557136 Review-Url: https://codereview.chromium.org/2253683003 Cr-Commit-Position: refs/heads/master@{#412515}
-
lizeb authored
BUG=631966 Review-Url: https://codereview.chromium.org/2237453002 Cr-Commit-Position: refs/heads/master@{#412514}
-
kdsilva authored
BUG=635581 Review-Url: https://codereview.chromium.org/2222163005 Cr-Commit-Position: refs/heads/master@{#412513}
-
mlamouri authored
Otherwise, we end up autoplaying unmuted. BUG=627451 R=zqzhang@chromium.org Review-Url: https://codereview.chromium.org/2250393002 Cr-Commit-Position: refs/heads/master@{#412512}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d69d22b2..e5e6dcc8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2255643003 Cr-Commit-Position: refs/heads/master@{#412511}
-
lizeb authored
In Custom Tabs, an external application can "warm up" Chrome. This creates and initializes a spare renderer, and has been found to be a significant optimization for loading performance. This patch moves the spare renderer logic out of Custom Tabs, and makes it accessible and useful for regular navigations in Chrome. Note that this patch doesn't add new call sites for the spare renderer creation. BUG=633964 Review-Url: https://codereview.chromium.org/2199393002 Cr-Commit-Position: refs/heads/master@{#412510}
-
olivierrobin authored
BUG=623096 TEST=None Review-Url: https://codereview.chromium.org/2253613002 Cr-Commit-Position: refs/heads/master@{#412509}
-
olka authored
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/ecae934..3cf1448 $ git log ecae934..3cf1448 --date=short --no-merges --format=%ad %ae %s 2016-08-17 kwiberg@webrtc.org FileRecorderImpl and FilePlayerImpl don't need their own .h and .cc files 2016-08-17 ossu@webrtc.org WebRtcVoiceEngine: Use AudioDecoderFactory to generate recv codecs. 2016-08-17 stefan@webrtc.org Don't simulate probing based on rtc event logs since we don't have that info logged. 2016-08-17 philipel@webrtc.org CongestionController::SetBweBitrates may now trigger probing. TBR= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= Review-Url: https://codereview.chromium.org/2251023002 Cr-Commit-Position: refs/heads/master@{#412508}
-
ehmaldonado authored
that is failing. The idea is to recover some of the coverage that the other tests provide. BUG=625808 Review-Url: https://codereview.chromium.org/2241223002 Cr-Commit-Position: refs/heads/master@{#412507}
-
zqzhang authored
BUG=638532 Review-Url: https://codereview.chromium.org/2251013002 Cr-Commit-Position: refs/heads/master@{#412506}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e5312417..d69d22b2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2249183004 Cr-Commit-Position: refs/heads/master@{#412505}
-
xiaochengh authored
This patch removes parameter |node| from the above mentioned function because it can always be computed as the root editable element of |insertedRange|. This patch is a preparation for reducing the use of TextCheckingParagraph in spell checker, since TextCheckingParagraph was introduced for synchronous spell checking which no longer exists now. BUG=619452 Review-Url: https://codereview.chromium.org/2241293006 Cr-Commit-Position: refs/heads/master@{#412504}
-
raphael.kubo.da.costa authored
The dependency on glib is only present because we need to call g_type_init(), but commit 9d47fa16 ("Add calls to g_type_init") has moved the call to ProxyConfigServiceLinux, which is what actually uses it. R=pauljensen@chromium.org,mmenke@chromium.org,xunjieli@chromium.org Review-Url: https://codereview.chromium.org/2240793003 Cr-Commit-Position: refs/heads/master@{#412503}
-
srirama.m authored
Cleaning appcache video http tests to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Review-Url: https://codereview.chromium.org/2252663002 Cr-Commit-Position: refs/heads/master@{#412502}
-
siva.gunturi authored
1.Handle the test inside window.onload. 2.Change image src of same size. This triggers img.onload. 3.Check for no layout on src change. BUG=638288, 637859 Review-Url: https://codereview.chromium.org/2250323002 Cr-Commit-Position: refs/heads/master@{#412501}
-
keishi authored
BUG=591606 Review-Url: https://codereview.chromium.org/2210483002 Cr-Commit-Position: refs/heads/master@{#412500}
-
yhirano authored
BUG=587663 Review-Url: https://codereview.chromium.org/2250353002 Cr-Commit-Position: refs/heads/master@{#412499}
-
tommyt authored
This change enables the stopNotifications function for remote GATT characteristics on Android. In order to do so, two distinct refactorings have been done; 1) The session classes have been simplified so that platform specific versions are no longer required. All code that previously used BluetoothGattNotifySession[Mac|Win|BlueZ] now simply use the base BluetoothGattNotifySession class. 2) BluetoothRemoteGattCharacteristic::StartNotifySession and StopNotifySession have been rewritten so that all the code for keeping track of the different session objects and the notification state sits in the base class. Inheriting classes should no longer override these two functions, but instead override the much simpler SubscribeToNotifications and UnsubscribeFromNotifications. BUG=584370 Review-Url: https://codereview.chromium.org/2051333004 Cr-Commit-Position: refs/heads/master@{#412498}
-
ioanap authored
TBRing for trivial rename in: c/b/android/browsing_data/browsing_data_counter_bridge.cc c/b/android/preferences/pref_service_bridge.cc TBR=bauerb@chromium.org BUG=620317 Review-Url: https://codereview.chromium.org/2230243002 Cr-Commit-Position: refs/heads/master@{#412497}
-
lizeb authored
Content type mapping is done in two places: in ResourcePrefetchPredictor, and in ResourcePrefetchPredictorObserver. The first one is undesirable, since it overrides the resource type set at URL request time. Remove the duplication, and move the summary creation to ResourcePrefetchPredictor. This will make it easier to add tests as well. BUG=631966 Review-Url: https://codereview.chromium.org/2228003002 Cr-Commit-Position: refs/heads/master@{#412496}
-
svartmetal authored
C++ reference says: "Unless otherwise specified, all standard library objects that have been moved from are placed in a valid but unspecified state" (http://en.cppreference.com/w/cpp/utility/move). According to this, current CL fixes UB related to |LayerTreeHost::swap_promise_list_| and |LayerTreeImpl::swap_promise_list_| incorrect usage. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2245053002 Cr-Commit-Position: refs/heads/master@{#412495}
-
yhirano authored
Having both kinds of copyToVector is confusing, and no one uses this function. BUG=None Review-Url: https://codereview.chromium.org/2249393002 Cr-Commit-Position: refs/heads/master@{#412494}
-
tobiasjs authored
This gets in the way of generating minidumps in WebView, and also interacts badly with the DumpWithoutCrashingToFd implementation. BUG=633979 Review-Url: https://codereview.chromium.org/2245403002 Cr-Commit-Position: refs/heads/master@{#412493}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a289b68e..e5312417 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2255493003 Cr-Commit-Position: refs/heads/master@{#412492}
-
guidou authored
Original CL https://codereview.chromium.org/2249963002 didn't actually add the DISABLED_ prefix. BUG=635032 TBR=aboxhall@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2250363002 Cr-Commit-Position: refs/heads/master@{#412491}
-
yosin authored
This patch converts "editing/deleting/delete-3608462-fix.html" to use w3c test harness to simplify test script for improving readability., and renames to "delete_with_redundant_space.html" to provide hint about what this test script verifies. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2248033004 Cr-Commit-Position: refs/heads/master@{#412490}
-
mvanouwerkerk authored
Revert of [Android] Remove some dead code in CompositorViewHolder (patchset #1 id:1 of https://codereview.chromium.org/2248793003/ ) Reason for revert: See https://bugs.chromium.org/p/chromium/issues/detail?id=638535 This crashes due to: 08-17 10:49:47.072 15523 15523 W System.err: java.lang.ClassCastException: android.widget.FrameLayout$LayoutParams cannot be cast to android.support.design.widget.CoordinatorLayout$LayoutParams 08-17 10:49:47.073 15523 15523 W System.err: at org.chromium.chrome.browser.compositor.CompositorViewHolder.updateContentOverlayVisibility(CompositorViewHolder.java:808) Original issue's description: > [Android] Remove some dead code in CompositorViewHolder > > After https://codereview.chromium.org/2241643003, Tab#getView() will > only return the wrapper framelyout that wraps infobars, content view or > native page view. This work simplifies the logic in > CompositorViewHolder. > > BUG=635871 > > Committed: https://crrev.com/01dca5c74d54e47c725ae94d7714884bf51f21af > Cr-Commit-Position: refs/heads/master@{#412133} TBR=dfalcantara@chromium.org,ianwen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=635871 Review-Url: https://codereview.chromium.org/2250113003 Cr-Commit-Position: refs/heads/master@{#412489}
-
stkhapugin authored
Since find pasteboards are unavailable on iOS 10, this CL removes usage of UIFindPasteboard, replacing it with a simple static NSString variable BUG=630563 Review-Url: https://codereview.chromium.org/2250433003 Cr-Commit-Position: refs/heads/master@{#412488}
-
yosin authored
This patch converts "editing/style/relative-font-size-change-00[1-4].html" to use w3c test harness and integrates into "relative_font_size_change.html", since both test cases are very similar, to simplify test script for improving readability. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2250943002 Cr-Commit-Position: refs/heads/master@{#412487}
-
haraken authored
We stopped returning an empty handle from toV8(). Now we can remove the IsEmpty() check for the handle returned by toV8(). Also this CL removes ActiveDOMCallback::isScriptControllerTerminating. The check shouldn't have been necessary because if the ScriptController is terminating, ScriptState::contextIsValid() returns false and we won't reach the check in the first place. BUG=625512 Review-Url: https://codereview.chromium.org/2200263005 Cr-Commit-Position: refs/heads/master@{#412486}
-
eseckler authored
checks for an additional pixel to help triage in case this regresses again. BUG=430620,423583 Review-Url: https://codereview.chromium.org/2247313002 Cr-Commit-Position: refs/heads/master@{#412485}
-