- 30 May, 2019 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium ff2b2ced. With Chromium commits locally applied on WPT: e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" abf2ac5e "webrtc wpt: avoid race conditions" d9a6ec05 "[MediaStreamTrack] Remove tests and existing support for the 'volume' property." 0882bebe "Change ICE connection state on transceiver changes" 1bbbd106 "Add feature policy for client hints, used for third-party subresources." 2229f484 "Revert "Change ICE connection state on transceiver changes"" ab94a58b "Add the remaining Client Hints to Feature Policy." e1be827e "Reland "Use promise in wpt pointer event tests to finish the tests"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I58b1665ffc5a13aa6b7b7661ede501e0cef657ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637180Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664756}
-
David Bertoni authored
Bug: 954657 Change-Id: I3748b0f2f87c1ca22fd056f4002546300de66162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629427Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#664755}
-
Xiaohan Wang authored
-ddorwin, +jrummell or +xhwang Thank you so much for everything, ddorwin! Change-Id: I63c99617c4a123c424d8017be868ff7704d732b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635975Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#664754}
-
Ramin Halavati authored
UMA stats collection is added for the life time of incognito profile. Bug: 966747 Change-Id: Ic83f3f88589e9fb6088f140575b38cc1c0798bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628747 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#664753}
-
Michael Lippautz authored
Bug: 948807 Change-Id: I65133443b258ba4125d664df08383e3bf395abe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635524Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#664752}
-
Yoshifumi Inoue authored
This patch introduces |ShapeResult::RunInfo::GlyphDataCollection| to represent a collection of |HarfBuzzRunGlyphData| with optional offsets to reduce memory usage, because of glyph offsets are often zero, particularly Latin runs. This is done by following observations: - Most of |HarfBuzzRunGlyphData::offset| are zero == allocates collection of offset when there are non-zero offsets. - Collection of |HarfBuzzRunGlyphData::offset| is accessed per run == checks zero or non-zero collection before accessing collection Bug: 965564 Change-Id: I345260a4e6d752bec9abbe21d32a2e31b07966f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627274 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#664751}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8dbf318b35d1..0779824b4e7d Created with: gclient setdep -r src-internal@0779824b4e7d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: I9c73ebfee9b5120e2fa0636ab0bd816746f2897a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636928Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664750}
-
Mike Dougherty authored
TBR=mrefaat@chromium.org Bug: 968514 Change-Id: Iebf1d852deac28a8946c1529f5cdd537a427d5f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637405Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#664749}
-
Saman Sami authored
Bug: 960795 Change-Id: Icc8c8b8c17dda72966aa1fcad0d326764a768512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637400Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#664748}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f7446c38416a..e80772c3ee35 git log f7446c38416a..e80772c3ee35 --date=short --no-merges --format='%ad %ae %s' 2019-05-30 chiniforooshan@chromium.org Add a new total_rendering metric Created with: gclient setdep -r src/third_party/catapult@e80772c3ee35 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:964423 TBR=sadrul@google.com Change-Id: Ib1436ee84fce1b83eafc5945afcb7b229ebd3dcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636927Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664747}
-
Kevin McNee authored
RecentTabHelper::WebContentsWasHidden has several conditions for saving a snapshot. One of which is to not snapshot for custom tabs. We try to determine if a WebContents is a custom tab, but for inner WebContents, such as portals, we DCHECK as they are not directly associated with a tab. We now use the outermost WebContents to determine whether we are in a custom tab. Bug: 958825 Change-Id: Ia7e2ebe93e3a73741c5d0df467f20bc8bc9c38ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635969Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#664746}
-
Nico Weber authored
From what I can tell, it's not intentional that we keyed this off using_sanitizer instead of is_asan. As far as I know, the only sanitizer we currently use on mac and ios is asan, so this should be a no-op there. On Windows, we also have experimental CFI bots, and this might help the 32-bit CFI bots that now no longer build the asan runtime. (But presumably CFI needs some other runtime that we also no longer build -- but it'll hopefully move the error a bit further back, and copying the asan runtimes is needless work.) TBR=pcc Bug: 968434 Change-Id: I56528f2e82852d8c3145d657db77833321a6602c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637032Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#664745}
-
Bryan McQuade authored
This change plumbs navigation OT features out from webkit to content, through the content navigation flow via CommonNavigationParams, and from content into webkit for the document being navigated to. This end-to-end flow is tested via new tests in origin_trials_browsertest.cc See https://docs.google.com/document/d/1bPWScr35Wv-xPy85JQ3mf12AXJ7AqSFqen6MxxslSJM/edit for details. TBR=mkwst@chromium.org Regarding TBR, Mike advised that since he's familiar with the high level nature of this change, I should TBR him and he would look at the changes to content/common/frame_messages.h later. Change-Id: I46016e1e852dacc79f34a0e1d4d2d83f16dc386c Bug: 968493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601980Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#664744}
-
manuk authored
Bug: 950512 Change-Id: Icfcd010a8d245b36c6cde9260a41f6f5d7170342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632425Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#664743}
-
Michael Thiessen authored
See bug for details. Bug: 968332 Change-Id: Iae95aa03dbb5b8841e0daebcafa51ec183d87b2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636477Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#664742}
-
Danyao Wang authored
This patch removes the special casing code that converts card network payment methods to "basic-card" in the following files: - payment_request_data_util.cc - can_make_payment_query.cc With this patch, requests that use a card network as a supported payment method will be rejected as unsupported payment methods. Tests are updated to reflect this new expectation. This deprecation has been approved for M64, but was never implemented. Intent to deprecate: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/1udpnrlQK4Q/ot_E-htQAQAJ A Blink counter was added to count actual usage of card network as payment method in the wild. This is now practically 0. See "PaymentRequestNetworkNameInSupportedMethods" in the histogram: https://uma.googleplex.com/p/chrome/histograms?endDate=20190525&dayCount=7&histograms=Blink.UseCounter.Features&fixupData=true&showMax=true&filters=channel%2CEQ%2C4%2Cisofficial%2CEQ%2CTrue&implicitFilters=isofficial Bug: 719526 Change-Id: I959cbcaa7fbe0a4fe2c4e7b5f4899370599ac0bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631731Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#664741}
-
Koji Ishii authored
Following bot results are included. 20498 No deflake because of recent large rebaseline in r664729 (CL:1637026). TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I555ddbc38d94d1ea058283c708c23634148f0e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631239 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Mythri A authored
Bug: chromium:925957 Change-Id: I40627d2e0b26d608dba2e119b3f6de834594430a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635615Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#664739}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=proberge@chromium.org Change-Id: I011b02c5bd19d68ad0392cc5a008a8396e7f3e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635513Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: proberge <proberge@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#664738}
-
Leon Han authored
https://chromium-review.googlesource.com/c/chromium/src/+/1631124 already made WebServiceWorkerStreamHandle used only inside Blink, this CL removes it. BUG=922376,879019 Change-Id: Ia9cd4f3cef9354ba64e492d3372b25ae626b64d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634382Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#664737}
-
Saman Sami authored
The failure is fixed by: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32128 Bug: 960795,967824 Change-Id: I5ca2815aeee32051f187e6a7303e99bf101498ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635810 Commit-Queue: Jonathan Ross <jonross@chromium.org> Auto-Submit: Saman Sami <samans@chromium.org> Reviewed-by:
-
Xiyuan Xia authored
- Fix RlzValueStoreChromeOS::SetRlzPingSent that calls DebugDaemonClient::SetRlzPingSent in a worker thread; - Fix RlzLibTest failure because of missing TestTimeouts init; Bug: 966178 Change-Id: I8c12425d2bc66f7f97fe40e81e9b02e65b894232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635429Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#664735}
-
Mark Yacoub authored
This reverts commit b4fd0cc9. Reason for revert: The Squid app uses SingleOnTop for overlay without changing the resource_id. This revert will undo the fix for the other apps, but they're lower priority. Original change's description: > Skip promoting SingleOnTop Overlay when contents don't change > > If a candidate content has not changed for 3 frames, do not promote it as > Single On Top overlay as it can be just be flattened, allowing other > strategies to kick in if possible. > > Bug: 885180 > Test: SingleOverlayOnTopTest.DoNotPromoteIfPreviouslyPromoted > Change-Id: I516dab628c129fe9fae09c713e2783a6ce889c56 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521591 > Commit-Queue: Mark Yacoub <markyacoub@google.com> > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Cr-Commit-Position: refs/heads/master@{#645367} TBR=dcastagna@chromium.org,markyacoub@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 885180 Change-Id: I799bd22f06a56d86844a63d5ac346f41bcfb8707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635931Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#664734}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0996da26f23c..8dbf318b35d1 Created with: gclient setdep -r src-internal@8dbf318b35d1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: I4a8e89969cb656a8afd2314b9957a28eeb3e2033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636518Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d6021d92c292..f7446c38416a git log d6021d92c292..f7446c38416a --date=short --no-merges --format='%ad %ae %s' 2019-05-30 khokhlov@google.com Make py_trace_event interface more strict Created with: gclient setdep -r src/third_party/catapult@f7446c38416a The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:944418 TBR=sadrul@google.com Change-Id: Ibb19e6e934ebc1794784ddd1319e3f1c6a50a427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636520Reviewed-by:
-
Jeffrey Cohen authored
I hope this makes it easier to find out how to update the tree when sheriffs are in the "sheriffing loop" Change-Id: I8ad02b6286693480f89c4ff7b95e2ae2aab71f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635730 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#664731}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=kylechar@chromium.org Change-Id: I37b6144800fa6aa38d28f699a9810a08508dd963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635818Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#664730}
-
Koji Ishii authored
1px font differences are seen in 305 tests. It looks like there was a change that affects curved glyphs such as O, S, italic fonts, etc. Rebaseline is based on manual review of build 20492. https://test-results.appspot.com/data/layout_results/linux_layout_tests_layout_ng/20492/webkit_layout_tests%20%28retry%20shards%20with%20patch%29/layout-test-results/results.html There are 307 failures, 2 are real failures to be added to FlagExpectations. This CL rebaselines other 305. TBR=eae@chromium.org NOTRY=true Bug: 591099 Change-Id: Ibfa39f01626d93bb84b8d991a2b92237effd3a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637026 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Chris Hamilton authored
This will allow us to use a single observer interface rather than having public and private versions. BUG=910288 Change-Id: Icd6ace3d79a03de28e947765edd65ec21618e85f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635637Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Auto-Submit: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#664728}
-
jonross authored
conformance2/samplers/multi-context-sampler-test.html has become flaky, reporting and error in SharedImageStub with subsequent context loss. So far this has only been seen on the nvidia mac builds. So only suppressing there for now while the root cause it addressed. TBR=kbr@chromium.org Bug: 965209 Change-Id: I2c7d0ae78b83ee84a03de648e37fe00cb3ea4b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637288Reviewed-by:
-
Carlos Caballero authored
We will then selectively downgrade tasks to USER_VISIBLE. Eventually we want all task priorities to be either inherited or explicitly set, so no defaults will be used. Roots will need to explicitly set the priority (most likely USER_BLOCKING) thus that is a good default for now. Bug: 863341 Change-Id: I9872976bb944bc78dd43cbb6aff0cb5912043936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634702Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#664726}
-
Simon Que authored
These were migrated in: https://chromium-review.googlesource.com/c/chromium/src/+/1634109 This is generating some compile binary hash mismatch errors: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ARM/115824 The remedy will be to use ATS, but for now let's revert the change to these builders. R=bpastene@chromium.org, jbudorick@chromium.org, tikuta@chromium.org, ukai@chromium.org, yyanagisawa@chromium.org Bug: 950413 Change-Id: Iba3ea38f4247b1da15a6295a684087acf170d3f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637003 Auto-Submit: Simon Que <sque@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#664725}
-
Mohamed Amir Yosef authored
Before this patch: BookmarkModelTypeProcessor has one weak_ptr_facotry used for both the controller and the worker. This resulted in the worker having a processor ptr while the model error isn't yet propagated. After this patch: The BookmarkModelTypeProcessor has dedicated weak_ptr_factory for the worker such that in case of model error, it gets invalidated directly while leaving the other weak_ptr_factory for the controller intact. Bug: 516866 Change-Id: If0d9759e0cba7e5b00879646f9072522cbdb866f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635511 Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#664724}
-
Huanzhong Huang authored
This reverts commit 9223cbe0. Reason for revert: Not getting leadership-full approval before branch point; will rollout with Finch. Original change's description: > [iOS] Enable the new Clear Browsing Data UI flag > > This change is to enable the new-clear-browsing-data-ui flag. > > The new Clear Browsing Data dialog adds the time range selection functionality > and shows browsing data volume details for each data type. > Launch Bug: crbug/627147 > Screenshots: https://drive.google.com/open?id=1q1zJzB1abRsY1zCD4rLewvMxCnMr8WGf > > Bug: 627147 > Change-Id: If2e16f4697a7aac2308a430c48880eb2f0c58c19 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624906 > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Commit-Queue: Rohit Rao <rohitrao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#662278} TBR=rohitrao@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 627147 Change-Id: I26afad9076841353b0210f4537d8842aab9631e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635617Reviewed-by:
Huanzhong Huang <huanzhong@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#664723}
-
Tien Mai authored
desktop. Bug: 960774 Change-Id: I5fbacb88d28d9a2c3414409c82c832ad8e4b647d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625306 Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@google.com> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#664722}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d554c5fc. With Chromium commits locally applied on WPT: e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" abf2ac5e "webrtc wpt: avoid race conditions" d9a6ec05 "[MediaStreamTrack] Remove tests and existing support for the 'volume' property." 0882bebe "Change ICE connection state on transceiver changes" 1bbbd106 "Add feature policy for client hints, used for third-party subresources." 2229f484 "Revert "Change ICE connection state on transceiver changes"" ab94a58b "Add the remaining Client Hints to Feature Policy." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I2ecae78fed71acd1b439402a281fdd679a3ba419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637179Reviewed-by:
-
Lan Wei authored
Bug: 606367 Change-Id: If0f8cc5df6eed1c451451a1b53da2483343b6b0f TBR=nzolghadr@chromium.org Change-Id: If0f8cc5df6eed1c451451a1b53da2483343b6b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636309Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#664720}
-
Juan Antonio Navarro Perez authored
TBR=crouleau@chromium.org Bug: 967125 Change-Id: Ib4b4d10e80ca6a5c752523bd8b903396fd0c6578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635820Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#664719}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/87b2fa4bb58f..0996da26f23c Created with: gclient setdep -r src-internal@0996da26f23c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: Iba68057afcfbbe08600565ac8d506c24d668b1a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637302Reviewed-by:
-
Gabriel Charette authored
Incorrectly marked the new suffix as obsolete when introducing it in crrev.com/650997 (copy/paste error). TBR=fdoray@chromium.org, mpearson@chromium.org Bug: 951388 Change-Id: I4983d6b70748a34e63227d43565192d2f098fdde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635519Reviewed-by:
-
