- 27 Sep, 2018 40 commits
-
-
Patrick Monette authored
Remove the module load address parameter unused by the ModuleDatabase Change-Id: I80a41dba4c0f33c9acb0c4d4a03934ad3b19ca54 Reviewed-on: https://chromium-review.googlesource.com/1237215Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#594776}
-
Sadrul Habib Chowdhury authored
BUG=none Change-Id: Ia943e5bda6e3f5d3cecf9eac39e2271801295a49 Reviewed-on: https://chromium-review.googlesource.com/1249392Reviewed-by:
-
Moe Ahmadi authored
This reverts commit dc8f3c0a. Reason for revert: Casing failures https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel/2442 Original change's description: > Android: Allow proguard to strip unused native methods. > > This CL changes Monochrome APKs to allow proguard to strip out Java > native methods that aren't used. > > For APKs that use explicit JNI registration, this isn't possible since > RegisterNatives ends up trying to load classes that are unused and > removed by proguard. > > Bug: 688465 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester > Change-Id: I6816bd68ce47e59bfc9f75dace1b34ab3c200222 > Reviewed-on: https://chromium-review.googlesource.com/1244605 > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594743} TBR=pauljensen@chromium.org,agrieve@chromium.org,estevenson@chromium.org Change-Id: Ic8e1f808a63c9c0fd119ee36efa1cc2b1e9a0616 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 688465 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Reviewed-on: https://chromium-review.googlesource.com/1249825Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#594774}
-
Xiyuan Xia authored
Disabled due to flake: SyntheticKeyEventTest.KeyboardEventAck Bug: 889878 Change-Id: I3ced9177ffbc1edbcbb0381714b92b66b02b5b07 Reviewed-on: https://chromium-review.googlesource.com/1249821Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#594773}
-
liberato@chromium.org authored
Previously, MediaCodecVideoDecoder tests tried to flush the MCVD instance on TearDown. Unfortunately, it didn't handle the case where not flush was needed. ASAN got mad about this. This CL fixes the teardown sequence to call Reset if the test still has an MCVD insance, and to send an EOS output buffer only if MCVD actually started the flush without completing it. These changes don't affect MCVD, just the tests. Bug: 889001 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id04afc7bbab4e0b1cde26df924573e0fed047947 Reviewed-on: https://chromium-review.googlesource.com/1244105 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#594772}
-
Robert Ogden authored
Refactor this logic out of the InfobarDelegate so that it is easily accessible in Android Java without the use of the Infobar. This is needed so that the stale preview text can be displayed in the page info dialog for the new Previews UI. Also renames the related histogram pieces to generalize the naming. Bug: 888029 Change-Id: Iaf4c8c8059c45d5ccfb408d8b831b6a322802a08 Reviewed-on: https://chromium-review.googlesource.com/1239214Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#594771}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /ios/chrome/common/app_group. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=olivierrobin@chromium.org Bug: 874080 Change-Id: I74ae6a8f94ea54ee9738a67493dc545921dc99e9 Reviewed-on: https://chromium-review.googlesource.com/1191420 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594770}
-
Stephen Chenney authored
JS calls force layout when they require layout-dependent state. This happens outside of the document lifecycle, and is not captured by our existing metrics. Add a new ForcedLayout metric for UMA and UKM to track the amount of time we spend doing layouts outside of the document lifecycle. R=eae@chromium.org,vpmstr@chromium.org Bug: 869966 Change-Id: I3868e1483a32163666343453204c81b9c9bbd452 Reviewed-on: https://chromium-review.googlesource.com/1228855 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#594769}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/efb94d57eb88..56db013e24cf git log efb94d57eb88..56db013e24cf --date=short --no-merges --format='%ad %ae %s' 2018-09-27 buildbot@webrtc.org Roll chromium_revision 65b8a51a..f87ef787 (594582:594716) 2018-09-27 mbonadei@webrtc.org Remove usage of runtime_enabled_features in WebRTC. Created with: gclient setdep -r src/third_party/webrtc@56db013e24cf The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2f9829d7eabba9d9bd556313f7b4f991d551ec8e Reviewed-on: https://chromium-review.googlesource.com/1249629Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594768}
-
Dan Harrington authored
- replaced some pointer parameters with const reference - replaced some non-const reference parameters with pointers - replace unique_ptr<UpdateRequestsResult> with UpdateRequestsResult, and made UpdateRequestsResult move-only. - fixed potential crash in UpdateRequestTask::ValidateReadResult - use default copy constructor in SavePageRequest Change-Id: Id2e2c103330a292e273a6889de359607deecc187 Reviewed-on: https://chromium-review.googlesource.com/1246281Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#594767}
-
Albert J. Wong authored
This should be purely renames with no functionality changes. Bug: 545684 Change-Id: I6bffef6e07fdf6e787f60050447047854b961cc3 Reviewed-on: https://chromium-review.googlesource.com/1220709Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#594766}
-
Hans Wennborg authored
Bug: 888476 Change-Id: Iccb39603a10261d1bdf3fcb26b008bb02fc371e6 Reviewed-on: https://chromium-review.googlesource.com/1245465 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#594765}
-
Stefan Teodorescu authored
Add a new section in the chrome://management page to show force installed extensions with powerful capabilities (like ability to read and write all data on the page). Bug: 879146 Change-Id: Ie45368caec53952a4c18efb07f3d80c21d5540b2 Reviewed-on: https://chromium-review.googlesource.com/1235674Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Marton Hunyady <hunyadym@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Stefan Teodorescu <fane@google.com> Cr-Commit-Position: refs/heads/master@{#594764}
-
Kent Tamura authored
Replace content::FileChooserFileInfo usage with blink::mojom::FileChooserFileInfo. * Replace std::vector<content::FileChooserFileInfo> with std::vector<blink::mojom::FileChooserFileInfo*Ptr*> because it's the representation of array<fileChooserFileInfo> in mojom. * Because FileChooserFileInfoPtr is not copyable, we use std::move() to pass it over functions. * We temporarily transfer std::vector<blink::mojom::FileChooserFileInfoPtr> over legacy IPC. Add ParamTraits<blink::mojom::FileChooserFileInfoPtr> because FileChooserFileInfoPtr is not a simple struct for which we can use IPC_STRUCT_TRAITS_* macros. FYI: All-in-one CL: https://chromium-review.googlesource.com/1170454 Bug: 869257 Change-Id: I73d54b70d3e24c917a783d3eafa1f29c292dc2bc Reviewed-on: https://chromium-review.googlesource.com/1237798Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#594763}
-
dpapad authored
per Polymer 2 migration guide: - wrap <style is="custom-style"> with <custom-style> - move <custom-style> inside <body> Bug: 739532 Change-Id: I089208681d14e19e71251a41e80bd024c02d1b3a Reviewed-on: https://chromium-review.googlesource.com/1247530Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#594762}
-
Ioana Pandele authored
If there is no keyboard accessory, signaling that password generation is unavailable doesn't constitute a state update. The keyboard accessory should only be created and initialized if there is an action or data to display. Bug: 888932 Change-Id: I9dbf8bd1ce4ae620f9b50e4e4aadb7c3c2335733 Reviewed-on: https://chromium-review.googlesource.com/1249084Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#594761}
-
Vladimir Levin authored
This patch changes force_subtree_update bool into "reasons" that fall into one of two categories: - Isolation piercing, meaning that the update crosses and recurses into an isolation boundary. - Isolation blocking, meaning that the recursion may be blocked by isolation. R=chrishtr@chromium.org, pdr@chromium.org, wangxianzhu@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie5389a02b8cc529ca93bf0e50b225b0f343e2439 Reviewed-on: https://chromium-review.googlesource.com/1247201Reviewed-by:Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#594760}
-
Daniel Bratell authored
Some jumbo build configurations would not compile because of the unused field. The are not allowed by the build system but sometimes only jumbo builds notice such things since they have access to more source code. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I079412fc98e5812f709b6566d02de9d91a5a8706 Reviewed-on: https://chromium-review.googlesource.com/1249485Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#594759}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0d9930ffe556..f7f0def7921b git log 0d9930ffe556..f7f0def7921b --date=short --no-merges --format='%ad %ae %s' 2018-09-27 fmayer@google.com Move unix socket to base. 2018-09-27 fmayer@google.com profiling: Add missing pieces to heapprofd. Created with: gclient setdep -r src/third_party/perfetto@f7f0def7921b The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ide7d3b2ee71ae12939560cd7473f051537c5f610 Reviewed-on: https://chromium-review.googlesource.com/1249626Reviewed-by:
-
Tommy Martino authored
Currently, the password dropdown only uses a two-line style when disambiguation text (i.e., the subdomain on which the password was saved) is available. For the experiment, when a user is in the Two-Line group, we want to always use a two-line display, even when no such text is present. This CL puts the obscured password (e.g., *****) on the second line in such cases. Bug: 870342 Change-Id: I77deba680277bdbe9ed8e435205e8fc7f18f0ef4 Reviewed-on: https://chromium-review.googlesource.com/1247029Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#594757}
-
Antoine Labour authored
This is not used anywhere any more. Remove extension, entrypoints, bindings and tests. Bug: 889651 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If3e2c95f7531752f2690b1f3e4345620bf4efb2d Reviewed-on: https://chromium-review.googlesource.com/1247191Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594756}
-
Antoine Labour authored
This wires up SharedImageInterface all the way to cc, and uses it for OOP and GPU raster. This also adds memory accounting in SharedImageFactory/SharedImageStub. TBR=boliu@chromium.org,sadrul@chromium.org Bug: 870116 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7cb3837f2082c5a4d03a9bc71e91dc265cbd0e82 Reviewed-on: https://chromium-review.googlesource.com/1242080 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5d8c6f4f9d8f..a16c39ef89c4 Created with: gclient setdep -r src-internal@a16c39ef89c4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I557eee8fcb096f692c4fbf797f02cf3a95c7c7c6 Reviewed-on: https://chromium-review.googlesource.com/1249624Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594754}
-
Jérôme Lebel authored
Adding cell to a sync error if it exists. This cell disappears when the error is fixed. The asset is missing. https://docs.google.com/presentation/d/1cZfr5FGWGSy0PNaQ8uzik0alLAH-5glh1vsb030vha8/edit?ts=5aba5455#slide=id.g3e63bc1501_10_15 Screenshot (shared with chromium accounts): https://drive.google.com/open?id=1S8kzlFmUwErOTn3BFC-2rR7KBeOX-V9i Bug: 849754 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I69eeac598b5d1742528acb16d8c0cc672580b402 Reviewed-on: https://chromium-review.googlesource.com/1231333 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#594753}
-
Christian Biesinger authored
To avoid the previous regression (see analysis in bug), we force layout in the case where we otherwise would get an outdated result. Bug: 596743 Change-Id: I9cf47675f7fcd88f94b2fe76b46bceae17e36756 Reviewed-on: https://chromium-review.googlesource.com/1246730 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#594752}
-
Yves Arrouye authored
In some situations, Start() would be called from both the constructor and the observer notification method quickly, yielding to multiple concurrent flows. Prevent those. In addition, redo the tests so that they test both work from the observer notification method and from an existing policy. Also add a test that triggers the concurrency situation and verifies that there is only one flow running in that situation. BUG=chromium:887683 TEST=unit_tests --gtest_filter=*EnrollmentPolicyObserverTest* CQ-DEPEND=CL:1234373 Change-Id: Ice6b46e19bf77a837b4c4908f332e9af6c5189f5 Reviewed-on: https://chromium-review.googlesource.com/1237242 Commit-Queue: Yves Arrouye <drcrash@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#594751}
-
Jialiu Lin authored
We'd like to learn the distribution of users' browser window (content area) size to guide the vision-based phishing detection model training. This CL collects the contents area size for SBER users when PG pings ( both on focus ping and reuse ping) are sent. Server side proto change has already landed cl/214521992 Bug: 882942 Change-Id: Id7feb60372b59c36ec8fcfa435bd1b461e8ce735 Reviewed-on: https://chromium-review.googlesource.com/1246662Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#594750}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/shell_integration_win.cc. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=gab@chromium.org Bug: 874080 Change-Id: Ifa0f35aa3000ab99401647c45a131b3c457eeb8c Reviewed-on: https://chromium-review.googlesource.com/1191095 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:Patrick Monette <pmonette@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#594749}
-
Evan Stade authored
TBR=sky@chromium.org,dcheng@chromium.org Bug: none Change-Id: I0e6ee1377df56412d3b000808de5a7d5382c33b2 Reviewed-on: https://chromium-review.googlesource.com/1249532Reviewed-by:
-
Evan Stade authored
1. Implement Mojo api for snapping (FrameCaptionDelegate) 2. Move CustomFrameHeader to //chrome, rename to BrowserFrameHeaderAsh 3. Share more code between Mash and classic Ash in BrowserNonClientFrameViewAsh 4. Move FrameHeader to //ash/public, along with some utilities and vector icons 5. Delete some immersive-related code. The mash reveal widget and DetachedTitleAreaRenderer are no longer needed. 6. Remove some ash window properties that are no longer necessary TODO: 1. remove old browser theme related code, including BrowserImageRegistrar 2. add handling for double tap/double click on browser window caption (to maximize). Also enable the context menu. 3. add handling for browser window dragging Bug: 887051 Change-Id: Ibc05728f6f91c4b94673431a8b97b7c79116d0eb Reviewed-on: https://chromium-review.googlesource.com/1241833Reviewed-by:
-
Victor Miura authored
These tests run MotionMark with fixed complexity sufficient to saturate most mobile phones today. Excludes Canvas tests which are already included in other story sets. BUG=619680 Change-Id: Id199dc6d7c5d497941c33405a069de6a9fc26980 Reviewed-on: https://chromium-review.googlesource.com/1244544 Commit-Queue: Victor Miura <vmiura@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#594746}
-
Emilio Cobos Álvarez authored
Otherwise `:host div` is equally specific to `div`, which seems undesirable and doesn't match any spec. Bug: 857415 Change-Id: I0a012ada134acb022dab85c3912b33ac5d0bd1dd Reviewed-on: https://chromium-review.googlesource.com/1238445 Commit-Queue: Emilio Cobos Álvarez <emilio@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#594745}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d9fdc1f5b5de..cf257cec18f0 git log d9fdc1f5b5de..cf257cec18f0 --date=short --no-merges --format='%ad %ae %s' 2018-09-27 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@cf257cec18f0 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I7faa4ddb691109944380859d594e3316860af6e3 Reviewed-on: https://chromium-review.googlesource.com/1249625Reviewed-by:
-
Eric Stevenson authored
This CL changes Monochrome APKs to allow proguard to strip out Java native methods that aren't used. For APKs that use explicit JNI registration, this isn't possible since RegisterNatives ends up trying to load classes that are unused and removed by proguard. Bug: 688465 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Change-Id: I6816bd68ce47e59bfc9f75dace1b34ab3c200222 Reviewed-on: https://chromium-review.googlesource.com/1244605Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#594743}
-
Geoff Lang authored
GL_CHROMIUM_sync_query is currently implemented in ANGLE which requires that we implement it in each backend. The implemention in the command decoder is simple with a Fence and faster because fewer layers and validation are needed. BUG=angleproject:2721 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I80fde7fc466dfdd5adb579d56293f1bf3ea660f4 Reviewed-on: https://chromium-review.googlesource.com/1244366 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#594742}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/529d0d9795b8..efb94d57eb88 git log 529d0d9795b8..efb94d57eb88 --date=short --no-merges --format='%ad %ae %s' 2018-09-27 oprypin@webrtc.org Revert "Revert "Replace VideoDecoder with VideoDecoderFactory in VideoReceiveStream config."" 2018-09-27 nisse@webrtc.org Revert "Replace VideoDecoder with VideoDecoderFactory in VideoReceiveStream config." 2018-09-27 mbonadei@webrtc.org Fix global_constructors, exit_time_destructors in audio device pulse. 2018-09-27 srte@webrtc.org Adds scenario test framework. 2018-09-27 saza@webrtc.org Remove echo_cancellation() and echo_control_mobile() interface access outside APM 2018-09-27 nisse@webrtc.org Avoid overflow when parsing H.264 SPS. Created with: gclient setdep -r src/third_party/webrtc@efb94d57eb88 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:877843 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie0f958230b4d5565bebed96f68e31e4a67a8d20b Reviewed-on: https://chromium-review.googlesource.com/1249621Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a78fa0978d64..d3738be3476f git log a78fa0978d64..d3738be3476f --date=short --no-merges --format='%ad %ae %s' 2018-09-27 stevenperron@google.com Update CHANGES 2018-09-27 jaebaek@google.com Validator: Validate OpImageTexelPointer (#487) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@d3738be3476f The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I6f99885e9e8b53c720b6e7885b0be84003bced4b Reviewed-on: https://chromium-review.googlesource.com/1249622Reviewed-by:
-
Paul Jensen authored
Listening for LinkProperties changes is required so we can detect if private DNS is enabled. Register a default-network callback so NetworkChangeNotifierAutoDetect on Android can listen for these LinkProperties changes. Use this default-network callback in place of CONNECTIVITY_ACTION which is deprecated. Bug: 885291, 774497 Change-Id: I0e6457f9cb970f1e010171af6c030638b1a667e6 Reviewed-on: https://chromium-review.googlesource.com/1243343 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#594739}
-
Elly Fong-Jones authored
This change: 1) Adds support to MenuClosureAnimationMac for animating menu closure without animating selecting an item; 2) Has MenuController use MenuClosureAnimationMac to animate cancels caused by outside clicks Bug: 833856 Change-Id: I9743b396798e4b125c038b35decc9aceb083926d Reviewed-on: https://chromium-review.googlesource.com/1231837 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
David Benjamin authored
Cryptography is timing-sensitive. MACs should never be compared with usual string comparison functions, only constant-time checks. Use HMAC::Verify. Bug: none Change-Id: Ic1b164441396e4a4a853f1a50d91bc8f5c7fa18e Reviewed-on: https://chromium-review.googlesource.com/1246323Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#594737}
-
