GitLab

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/54fac8b..d1371a6

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/934823003

Cr-Commit-Position: refs/heads/master@{#316585}

snapshots_util is also moved from ui/ to snapshots/ as part of this CL.

NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/862693003

Cr-Commit-Position: refs/heads/master@{#316584}

Now that NaClValidationCache is declared in src/public/, we can use
that declaration from the Chromium side and remove a non-public
#include.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=2832
TEST=build

Review URL: https://codereview.chromium.org/929613002

Cr-Commit-Position: refs/heads/master@{#316583}

There was a typo where a '/' was used instead of a ':'.  components_unittests
is found in components/BUILD.gn.

Review URL: https://codereview.chromium.org/931653002

Cr-Commit-Position: refs/heads/master@{#316582}

Subscribe nektar@chromium.org and je_julie.kim@samsung.com, and simplify
the file paths to just catch any file that includes one of these keywords
in the path rather than trying to enumerate every path:

accessibility, braille, chromevox, iaccessible2, isimpledom, liblouis

Let me know if I missed any keywords! In particular, are there any
accessibility-related files in the code tree that don't contain one of these
keywords as a substring?  (This doesn't count Blink.)

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/927683002

Cr-Commit-Position: refs/heads/master@{#316581}

Run it on Android bots (depends on https://codereview.chromium.org/930233002).

BUG=459147, 422235
R=mnaganov@chromium.org

Review URL: https://codereview.chromium.org/929223002

Cr-Commit-Position: refs/heads/master@{#316580}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d4be2fd..87b7f9d

TBR=schenney@chromium.org,yhirano@chromium.org

Review URL: https://codereview.chromium.org/932853002

Cr-Commit-Position: refs/heads/master@{#316579}

BUG=https://code.google.com/p/nativeclient/issues/detail?id=2832
TEST=build

Review URL: https://codereview.chromium.org/933733003

Cr-Commit-Position: refs/heads/master@{#316578}

- Color the progress bar green.
- Use Material Design's expand icon to open/shrink progress panel.
- Show expand button slightly higher than the progress bar. (Cancel button should stay in the same level as progress bar.)

BUG=402344
TEST=manually checked

Review URL: https://codereview.chromium.org/931123002

Cr-Commit-Position: refs/heads/master@{#316577}

The current design is violating the coding style (public member
variables) and is breaking some implicit functions used by some
STL implementations.

BUG=443228

Review URL: https://codereview.chromium.org/931113003

Cr-Commit-Position: refs/heads/master@{#316576}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/066d1633..b85cd710

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/934783002

Cr-Commit-Position: refs/heads/master@{#316575}

BUG=452490

Review URL: https://codereview.chromium.org/927373002

Cr-Commit-Position: refs/heads/master@{#316574}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/db3909a..d4be2fd

TBR=schenney@chromium.org,yhirano@chromium.org

Review URL: https://codereview.chromium.org/927233004

Cr-Commit-Position: refs/heads/master@{#316573}

Android won't be able to support this reliably, and hasn't yet shipped this
feature, so this is the time to take it out.

This is part of a two-sided patch:
    [1] https://codereview.chromium.org/901843006
    [2] This patch.

BUG=441828

Review URL: https://codereview.chromium.org/920153002

Cr-Commit-Position: refs/heads/master@{#316572}

Cr-Commit-Position: refs/heads/master@{#316571}

Tests that don't enable auditing generate a confusing stack trace and
a setUp method that would call its base method by virtue of good practice
will not work.

BUG=458910

Review URL: https://codereview.chromium.org/927083003

Cr-Commit-Position: refs/heads/master@{#316570}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/01edaba..db3909a

TBR=schenney@chromium.org,yhirano@chromium.org

Review URL: https://codereview.chromium.org/933883002

Cr-Commit-Position: refs/heads/master@{#316569}

These settings were originally not manageable by extensions (or other means), and therefore had no such indicators.

Screenshots are attached to the linked bug.

BUG=459141

Review URL: https://codereview.chromium.org/928373002

Cr-Commit-Position: refs/heads/master@{#316568}

GetDeviceSessionStatus() now generates information about the current active
kiosk session (if any).

BUG=430908

Review URL: https://codereview.chromium.org/907323002

Cr-Commit-Position: refs/heads/master@{#316567}

Back out 'using' declarations added in 7d588399.  These break
builds where host_clang=0:

BUG=385553

Review URL: https://codereview.chromium.org/921683005

Cr-Commit-Position: refs/heads/master@{#316566}

We used to initialize the command line flags prior to setting the
application context in Android's BrowserStartupController.

When determining the command line flags for the renderer, certain flags
may be dependent on the Android SDK version being used. Getting this value
through base::android::BuildInfo requires the application context to be known.

This change makes sure that we initialize the application context prior to
calling the native SetCommandLineFlags function.

BUG=

Review URL: https://codereview.chromium.org/925423002

Cr-Commit-Position: refs/heads/master@{#316565}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/43902e2..01edaba

TBR=schenney@chromium.org,yhirano@chromium.org

Review URL: https://codereview.chromium.org/928403002

Cr-Commit-Position: refs/heads/master@{#316564}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e66d39a6..066d1633

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/933843002

Cr-Commit-Position: refs/heads/master@{#316563}

Move the Java-implementation of Device Motion/Orientation/Light APIs
to run on the UI thread. This is to avoid a blocking call from the
IO thread to the UI thread inside DeviceSensors.java. That call can
lead to deadlock and hence is removed in this patch.

BUG=455767

Review URL: https://codereview.chromium.org/917253002

Cr-Commit-Position: refs/heads/master@{#316562}

BUG=456016
TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/file_manager/foreground/js/compiled_resources.gyp && ninja -C out/Default

Review URL: https://codereview.chromium.org/927333002

Cr-Commit-Position: refs/heads/master@{#316561}

This fixes sandbox_linux_unittests on Android.

TBR=jln@chromium.org
BUG=459158

Review URL: https://codereview.chromium.org/929213002

Cr-Commit-Position: refs/heads/master@{#316560}

Revert of Add a presubmit check that warns about declaring Singleton<T> in header files (patchset #2 id:20001 of https://codereview.chromium.org/929043002/)

Reason for revert:
Reverting because of presubmit crashes:

Traceback (most recent call last):
  File "/usr/local/google/ssd/depot_tools/git_cl.py", line 2983, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/usr/local/google/ssd/depot_tools/git_cl.py", line 2969, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/usr/local/google/ssd/depot_tools/subcommand.py", line 245, in execute
    return command(parser, args[1:])
  File "/usr/local/google/ssd/depot_tools/git_cl.py", line 1614, in CMDpresubmit
    change=cl.GetChange(base_branch, None))
  File "/usr/local/google/ssd/depot_tools/git_cl.py", line 936, in RunHook
    rietveld_obj=self.RpcServer())
  File "/usr/local/google/ssd/depot_tools/presubmit_support.py", line 1396, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/usr/local/google/ssd/depot_tools/presubmit_support.py", line 1313, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 1727, in CheckChangeOnCommit
  File "<string>", line 1455, in _CommonChecks
  File "<string>", line 1322, in _CheckSingletonInHeaders
  File "/usr/local/google/ssd/depot_tools/presubmit_support.py", line 472, in ReadFile
    raise IOError('Access outside the repository root is denied.')
IOError: Access outside the repository root is denied.

Original issue's description:
> Add a presubmit check that warns about declaring Singleton<T> in header files
> (except for base/memory/singleton.h)
> This check is copied from presubmit_canned_checks.py in depot_tools/ with an
> added exception for base/memory/singleton.h.
> The corresponding code will be removed from presubmit_canned_checks.py afterwards.
>
> BUG=349861
> R=phajdan.jr@chromium.org,
>
> Committed: https://crrev.com/9b73d0393037452d13358f4e2766cb62adbdede8
> Cr-Commit-Position: refs/heads/master@{#316546}

TBR=phajdan.jr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=349861

Review URL: https://codereview.chromium.org/934723003

Cr-Commit-Position: refs/heads/master@{#316559}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ec53d7e..43902e2

TBR=schenney@chromium.org,yhirano@chromium.org

Review URL: https://codereview.chromium.org/931033004

Cr-Commit-Position: refs/heads/master@{#316558}

BUG=314221
TBR=jeremy@chromium.org

Review URL: https://codereview.chromium.org/927663004

Cr-Commit-Position: refs/heads/master@{#316557}

BUG=378158
TBR=erikchen@chromium.org

Review URL: https://codereview.chromium.org/921143004

Cr-Commit-Position: refs/heads/master@{#316556}

- Use pixel-perfect PNGs for icons on toolbar, instead of core-icons(SVG).
- Update hover/focus color to be visible on white and blue background.
- Change the shape of hover/focus background from square to circle.
- Some minor layout change to comply with the latest spec.

BUG=402344
TEST=manually compared with the mock.

Review URL: https://codereview.chromium.org/928353002

Cr-Commit-Position: refs/heads/master@{#316555}

Remove ygorshenin@ from OWNERS/TODOs, replace with
alemate/antrim/dpolukhin/bartfab

BUG=None
TBR=stevenjb@chromium.org,isherman@chromium.org

Review URL: https://codereview.chromium.org/925963002

Cr-Commit-Position: refs/heads/master@{#316554}

BUG=456016
TEST=Open a grid view and edit an image. Thumbnail should be updated with animation.

Review URL: https://codereview.chromium.org/931103002

Cr-Commit-Position: refs/heads/master@{#316553}

1. Support PPB_CameraCapabilities_Private.GetSupportedPreviewSizes()
2. Implement basic skeleton of image capture PPAPI

BUG=387547
TEST=Call the API from a trusted plugin and print all preview
sizes.

Review URL: https://codereview.chromium.org/848863002

Cr-Commit-Position: refs/heads/master@{#316552}

BUG=459010

Review URL: https://codereview.chromium.org/934603002

Cr-Commit-Position: refs/heads/master@{#316551}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bfafa58..ec53d7e

TBR=schenney@chromium.org,yhirano@chromium.org

Review URL: https://codereview.chromium.org/935543002

Cr-Commit-Position: refs/heads/master@{#316550}

ToT clang now supports building for arm64 so remove the exception forcing
using Xcode clang when targeting arm64 (or fat binaries) on iOS.

BUG=341453

Review URL: https://codereview.chromium.org/932673002

Cr-Commit-Position: refs/heads/master@{#316549}

Previously Files.app can run out of local storage by copying files to Downloads.

The CL let fileManagerPrivate API call FreeDiskSpace before starting copy so
that it can secure available space by removing drive caches.

If it cannot secure available space, the API returns QuotaExceededError.

BUG=230283
TEST=FileSystemTest.FreeDiskSpaceIfNeededFor

Review URL: https://codereview.chromium.org/935513002

Cr-Commit-Position: refs/heads/master@{#316548}

The goal is to get rid of states "I'm opening the bubble now" as it should be an implementation detail of ManagePasswordsUIController.
For bubbles, which can be opened both automatically and later on user interaction, there should be exactly one state (like PENDING_PASSWORD_STATE).
For one-time automatic bubble there are two states. One is while the bubble is visible (e.g. CONFIRMATION_STATE). The second one is after it was closed (e.g. MANAGE_STATE).

BUG=400674
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/928753003

Cr-Commit-Position: refs/heads/master@{#316547}

(except for base/memory/singleton.h)
This check is copied from presubmit_canned_checks.py in depot_tools/ with an
added exception for base/memory/singleton.h.
The corresponding code will be removed from presubmit_canned_checks.py afterwards.

BUG=349861
R=phajdan.jr@chromium.org,

Review URL: https://codereview.chromium.org/929043002

Cr-Commit-Position: refs/heads/master@{#316546}