- 17 Oct, 2019 40 commits
-
-
John Budorick authored
This reverts commit 2aa5da39. Reason for revert: reenabling given crrev.com/1864618 Original change's description: > Disable WelcomeScreenBrowserTest.WelcomeScreenNext. > > Bug: 1014952 > Change-Id: I1df1941c2a0a92d243cb4e4624ae920b150c7694 > Tbr: achuith@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865351 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706500} TBR=achuith@chromium.org,jbudorick@chromium.org Change-Id: I86cba6fe329f52b5bdcd7b07d04d1dfb40fa65cf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1014952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866407Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#706891}
-
John Budorick authored
This reverts commit 005483fe. Reason for revert: breaks compilation: https://ci.chromium.org/p/chromium/builders/ci/linux-archive-rel/11718 Original change's description: > [Trusted Types] Remove TrustedURL. > > The current Trusted Types spec no longer supports TrustedURL. This CL adapts > to the spec. > > Bug: 1002555 > Change-Id: I35c6d8a257046558f155b9f38289457b14dcb1d2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834142 > Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706886} TBR=vogelheim@chromium.org,mkwst@chromium.org Change-Id: I97a2e1e31947cf854ed52a5866166dbc894c61b8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1002555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866406Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/99d3067c6c30..42ac78d2d012 Created with: gclient setdep -r src-internal@42ac78d2d012 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I571c7283228c8daee497e6121da77b99b805053d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866611Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706889}
-
Alice Wang authored
Add more parameters to ProfileDataCacheRenderTests. Bug: 967770 Change-Id: Ia32abccdfd067391f685ceae6f269c8264b7a4ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859964 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#706888}
-
Lowell Manners authored
Bug: 1012707 Change-Id: Idd5551637b6a512f5123b24b917fde3a939f065b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856165 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#706887}
-
Daniel Vogelheim authored
The current Trusted Types spec no longer supports TrustedURL. This CL adapts to the spec. Bug: 1002555 Change-Id: I35c6d8a257046558f155b9f38289457b14dcb1d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834142 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#706886}
-
Oleg Davydov authored
ContentHash class was previously tested indirectly: in a more integration-like approach, for example, from ContentVerifyJobUnittest and slightly from ContentHashFetcherTest. This commit adds its own test for ContentHash. This will be used in https://crbug.com/958794 to test ContentHash work with unsigned hashes. Bug: 958794, 796395 Change-Id: Ica75dac2a48250f12d5729126ecf397a8168061e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844966 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706885}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9187f322d59f..df1de01ceff3 git log 9187f322d59f..df1de01ceff3 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 chinglinyu@chromium.org usergroup_baseline: Expect metrics in debugfs-access. Created with: gclient setdep -r src/third_party/chromite@df1de01ceff3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I37126d1b8dacb5832c36378ac081e2bb228cf24c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866609Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706884}
-
Huanzhong Huang authored
Bug: 967668 Change-Id: I7216c1c43bfd4a24bfcf69f14d0c15100eb5e456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865321Reviewed-by:
Florian Uunk <feuunk@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#706883}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/27c64dd97caf..572eb8c70fdc git log 27c64dd97caf..572eb8c70fdc --date=short --no-merges --format='%ad %ae %s' 2019-10-17 perezju@chromium.org Revert "devil: add support for adb push --sync behind a flag." Created with: gclient setdep -r src/third_party/catapult@572eb8c70fdc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:922145,chromium:1015280 Change-Id: I3cb42dc4941a8c394b403f73e13102d8abbae507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866610Reviewed-by:
-
Sylvain Defresne authored
Some observers of WebStateList are interested in grouping multiple mutations of the WebStateList as a single operation (e.g. "closing all tabs" or "restoring a session"). Add WillBeginBatchOperation() and BatchOperationEnded() methods to WebStateListObserver that can be used to detect those operations (and to avoid expensives UI events during the batch). Sending the notifications is managed by PerformBatchOperation that executes a callback surrounded by invoking the two methonds on the observers. Bug: 1014526 Change-Id: Ieb3ffa5ab349159b333dc651314aa594713ce94e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865161 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#706881}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLSlotElement> and DynamicTo<HTMLSlotElement> as new downcast helper 2. Use IsA<HTMLSlotElement>(element) in place of IsHTMLSlotElement(element) Bug: 891908 Change-Id: I981d12a3f481d7cac8af38416619fe87d7f79481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847700 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#706880}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/562a37f926dd..a6d7b028242c git log 562a37f926dd..a6d7b028242c --date=short --no-merges --format='%ad %ae %s' 2019-10-17 thomasanderson@chromium.org Avoid g_clear_object in pipewire 2019-10-17 nisse@webrtc.org Delete unused method PacedSender::QueueSizePackets 2019-10-17 sprang@webrtc.org Set StreamDataCountersCallback on construction of RTP modules 2019-10-17 nisse@webrtc.org Delete deprecated bytes_sent/bytes_rcvd stat values Created with: gclient setdep -r src/third_party/webrtc@a6d7b028242c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:1012850,chromium:1014947 Change-Id: I9dbc967757b362f6f3a824c8f5945231eb0523b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865725Reviewed-by:
-
arthursonzogni authored
After a navigation, if the old page do NOT enter the back-forward cache, it starts pending deletion. This is asynchronous, so tests shouldn't make the assumption it is deleted immediately. Bug: 1014799, 1013802 Change-Id: I446117f58970280ea5445b57469e6e6c7c37ea5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865343Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#706878}
-
Nico Weber authored
This was a workaround for a toolchain problem we no longer have -- lld-link has thin static libraries and this is a no-op for it for that reason already. Bug: 857060 Change-Id: Ib16c732e3f0a6a0973feff72c7fa4bd1154e2615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865420Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#706877}
-
Igor authored
Currently there's no log on the device to understand when the enrollment was completed. In the past there was "Wizard screen exit code: ENTERPRISE_ENROLLMENT_COMPLETED" message but at some point it was removed. Also added a log for the case when we restart Chrome, so that we still have information that enrollment was successful. We need this information when investigating enterprise enrolled issues. BUG=chromium:1011375 TEST=Manually enrolled the device and checked that we have the log Change-Id: I917641840c99a6e93dbea6ccc674841032edff48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864777Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Commit-Queue: Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#706876}
-
Friedrich Horschig authored
The Peeking state became customizable. With that, we can now show 1.5 suggestions initially and allow expanding the sheet. It is alsow prerequisite for the footer which we only show in FULL state. The flow of scrolling is now: 1) Keyboard opens in Peek state. 2) swipe up motion expands to Full state. 3) swipe up motion scrolls the list to the bottom. 4) swipe down motion scrolls the list to the top. 5) swipe down shrinks/dismisses the sheet. Btw: the minimum height of the sheet could be smarter: instead of using the fixed size of 340dp, the header size plus 1.5 suggestion heights fit better. This smartness should be added AFTER the issue 1012219 is resolved. Screenshots showing differences in states are in https://crbug.com/957532#c47. Bug: 1012219, 1013257, 957532 Change-Id: I74b7209e447b474815f21a4aafed8672fc57889a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857128 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
-
Lowell Manners authored
We only want to add pages to the cache if the initial fetch is expected to have had no side effects on the server (HTTP GET). Before this CL, we could cache pages that were the result of an HTTP POST. There are two main cases we need to handle: 1) The last commit's http method != GET (e.g. POST): We should not cache. 2) The last commit's http method == GET: We should cache the page, if it is otherwise eligible for caching. An HTTP POST may result in a redirect, or chain of redirects, however for caching purposes we only care about the last commit in the chain of redirects (if the last commit was a successful GET, we can cache the page. Otherwise, we cannot). TBR=clamy@chromium.org Change-Id: I475eb73bf5ac50f500d760df5a947b2a8e1f5e4a Bug: 1014901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864681Reviewed-by:
Lowell Manners <lowell@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
-
Robbie Gibson authored
The feature has been ramped to 100% and enabled by default for a few months, so now the flag can be removed. Bug: 932116 Change-Id: I97a1c9f8abf59bf1db2e969443b60a2c190bbd69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865225 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#706873}
-
Andreas Haas authored
It seems to me that the additional step of first creating a DataHandle was used to handle the case where allocation fails. However, this is also possible by creating an ArrayBufferContents directly. In addition I changed the allocation to avoid zero initialization, since the whole memory is overwritten immediately anyways. R=sammc@chromium.org Bug: chromium:1008840 Change-Id: I43750c462e4959b3bd2b993bc177dcf56593fec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864785Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#706872}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d7e14a2d69f2..99d3067c6c30 Created with: gclient setdep -r src-internal@99d3067c6c30 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ibbf64e0b8e4a211ffabacd3aabdc34f434481550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866550Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8df31ad1d9b8..27c64dd97caf git log 8df31ad1d9b8..27c64dd97caf --date=short --no-merges --format='%ad %ae %s' 2019-10-17 perezju@chromium.org [Telemetry] Remove json-test-results output format Created with: gclient setdep -r src/third_party/catapult@27c64dd97caf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:928275 Change-Id: Id281f78f860092435a16c46db2518999dce77b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866549Reviewed-by:
-
Roman Sorokin authored
CHECK should be used if the consequence of a failed assertion would be a security vulnerability. Which does not seem to be the case. TBR=antrim@chromium.org Bug: 984021 Change-Id: I8c2e0137881f1c3af4b48176683b587679c0998c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865348Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706869}
-
Jan Wilken Dörrie authored
Similarly to r662995 this change deprecates PasswordManager's AccountsPerSite metric and replaces it with AccountsPerSiteHiRes, which provides a finer granularity. Furthermore, it now also logs metrics to the "Overall" PasswordGenerated suffix and its affected histograms. Lastly this change performs some minor code clean-ups. Bug: 966041 Change-Id: I82ca338bc64aac53c099ae66237565e89ecc8ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863414 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#706868}
-
Himanshu Jaju authored
Adds a flag to enable SyncDeviceInfoInTransportMode feature which helps users sync DeviceInfo datatype in sign-in but not sync-ed mode. Bug: 1005651 Change-Id: I69aaec4388de7da5f9673ee282df22370039da5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865213 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#706867}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/31bde9585709..919812ed1c25 git log 31bde9585709..919812ed1c25 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 cwallez@chromium.org Use webgpu.h's bitmask type definitions. Created with: gclient setdep -r src/third_party/dawn@919812ed1c25 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I20821d893d94137c8326ca33ec31ffd0cd560671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866397Reviewed-by:
-
Alex Chau authored
- As DeviceInfo will sync for transport-only device in M79, send_tab_to_self should be disabled for transport-only devices as tabs is not yet syncing in transprot-only mode Bug: 1014705 Change-Id: I084e88a04f643ccdf6c000461b34da2399492d1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865248 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#706865}
-
Pavel Shmakov authored
getDataDir() should be replaced with getFileDir() This is a reland of 6cd69069 Original change's description: > Revert "Persist cookies for profiles with non-null path" > > This reverts commit 6cd69069. > > Reason for revert: broke weblayer instrumentation tests, see https://ci.chromium.org/p/chromium/builders/ci/Mojo%20Android/20184?blamelist=1#blamelist-tab > > Original change's description: > > Persist cookies for profiles with non-null path > > > > Currently the cookies are not persisted because the default > > implementation of ContentBrowserClient::CreateNetworkContext doesn't > > specify cookie_path parameter. In this CL CreateNetworkContext is > > overridden in WebLayer implementation. > > > > Bug: 1014048 > > Change-Id: I1b7a307a64cd836eb5c4a45817412b997b89f1f5 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862677 > > Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Bo <boliu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#706390} > > TBR=jam@chromium.org,boliu@chromium.org,pshmakov@chromium.org > > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1014048 > Change-Id: I7b302c7ea8618acd1c578b14ac9c8ed894744cca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865130 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706638} TBR=jam@chromium.org,boliu@chromium.org,pshmakov@chromium.org Change-Id: I4848f94a9531b2eda78c593f7cabeb5a68a05dae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1014048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865323 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#706864}
-
Mikhail Khokhlov authored
'number' is not a valid unit name, should use 'count' instead. Bug: 1015192 Change-Id: Ide4363f7faf8411bd27e68e186df19e9e6ee0f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865219Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#706863}
-
Clemens Backes authored
The account was renamed after a name change, thus also change all references in flags and histograms. R=jwd@chromium.org Change-Id: I7f386a3c53e0145baf4f29272de694b33d746d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848378Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#706862}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6e48505301f4..989bc351863d git log 6e48505301f4..989bc351863d --date=short --no-merges --format='%ad %ae %s' 2019-10-17 ehmaldonado@chromium.org Revert "depot_tools: Stop using oauth2client" 2019-10-17 ukai@chromium.org Revert "put goma client in depot_tools" Created with: gclient setdep -r src/third_party/depot_tools@989bc351863d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1001756,chromium:1015285,chromium:b/77663154 Change-Id: I1184131ac2502775bacdfdf43239b23a222f368e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866429Reviewed-by:
-
Jan Wilken Dörrie authored
This change introduces two Touch To Fill metrics and corresponding recording logic. The added metrics are "DismissalReason" and "CredentialIndex", each having a "PasswordManager.TouchToFill." prefix. "DismissalReason" gets recorded whenever a user dismisses the sheet, and is backed by the BottomSheet.StateChangeReason enum. "CredentialIndex" records a credential index, and is a count based histogram. In order to avoid recording trivial information, this is only recorded if the Touch To Fill sheet contained at least two credentials. Bug: 1013134 Change-Id: I689868bb5cdc15a00be4e53348a63248b58e8af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864687 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#706860}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/71a18f6f4b01..3787dee78156 git log 71a18f6f4b01..3787dee78156 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 tneda@google.com Merge "perfetto-ui: Changing message for heap profiles in heap profile panel" Created with: gclient setdep -r src/third_party/perfetto@3787dee78156 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I2042d7cbb0d7942fbdf626da9706eba093da8801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866264Reviewed-by:
-
Peter Kasting authored
Bug: 82078 Change-Id: I13e7bd190e628d85f3bacbaca5e33108f94337f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866266 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#706858}
-
Andreas Haas authored
When the DataHandle is created in ArrayBufferContents::CreateDataHandle, the provided {data} allocated with AllocateMemoryOrNull can be nullptr. If so, we don't want to store the length in the new DataHandle. To avoid an inconsistent state. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: Ia9bb106a82b5c2f884b8a4e09ebd4f6ca0be9152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865220Reviewed-by:Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#706857}
-
Fergal Daly authored
passing locally. Change-Id: I9b92a41da7aa590a000cb1cfa193e0bf338abbc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866102Reviewed-by:
-
Ricky Liang authored
We now have GpuMemoryBuffer support in fake and file video capture devices, so we can re-enable native input mode in RTCVideoEncoder without causing test regression. Bug: 1014209, 982201 Test: Verify that tast.webrtc.DecodeAccelUsedVP8 passes Change-Id: Ica0b61865aa97105f8dde6258f901bbf20d8aa9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864503 Commit-Queue: Ricky Liang <jcliang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#706855}
-
Maksim Ivanov authored
Temporarily remove the check of the AttestationEnabledForUser's pref/policy level from the chrome.enteprise.platformKeys implementation, since this check was not present before (until r701979), and since this isn't compatible with the current corp policies. This is a temporary workaround that will need to be reverted in the future, once the corp policies are fixed to have the AttestationEnabledForUser policy configured at the "mandatory", not "recommended", level. Bug: 1000589, b:142616571 Test: set the AttestationEnabledForUser to the recommended level, open corp cert enrollment extension's background page in DevTools, run "chromecert.Request.testOnly.getEuk("")", check that it doesn't fail with "Remote attestation is not enabled for your account." Change-Id: I0087364882728fdc63e84a789313e525c24a21d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865340 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#706854}
-
Jeonghee Ahn authored
Some web-sites may handle the arrow keys themselves for moving focus. Unfortunately some of them do not call preventDefault. In this case, the focus moves twice. (ex. Buttons of https://expedia.com (class="tabs cf col")) This patch prevents duplicate focus moving by checking that the current fucused element matches the event target element. Change-Id: If97fd4d81f3eabf7fc015aa464b6d121f30458fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859425 Commit-Queue: Jeonghee Ahn <jeonghee27.ahn@lge.com> Reviewed-by:
-
Andreas Haas authored
Instead we can allocate ArrayBufferContents directly. I also added a check if allocation failed. I also changed the allocation to not initialize the memory. It is overwritten immediately afterwards anyways. R=jbroman Bug: chromium:1008840 Change-Id: I046c30f499f67ff437e481c907efdd38fa0d0045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864788Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#706852}
-
