GitLab

This reverts commit c8f117ce.
This reverts commit c18cd561.

Reason for revert: causes rendering corruption in Android WebView

BUG=823232
TBR=piman@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I56df8c34b7bbf2e80eb818f8ca4595f220dbffd0
Reviewed-on: https://chromium-review.googlesource.com/974064
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544862}

This CL refactors TelemetryLogWriter to use the centralized token getter from
ChromotingClientRuntime. This change gets rid of special handling logic for
authorizing the log writer.

Change-Id: I9ce3481408759b20546801b1f96294f7223b3076
BUG: 780736
Reviewed-on: https://chromium-review.googlesource.com/967520
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544861}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a68d82cb2fde..b3065fb6a19f

$ git log a68d82cb2..b3065fb6a --date=short --no-merges --format='%ad %ae %s'
2018-03-21 tandrii bot_update: don't repack, don't gc in main repo of builder's checkout.

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:822437


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I51da70698709b41506098aa74e59301efe3a85a2
Reviewed-on: https://chromium-review.googlesource.com/974126
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544860}

This reverts commit 6f420a45.

Reason for revert: We need rails setting to make swipe left/right for navigation change gesture. User can still scroll to any direction, but more events would restrict to XY rails.

Original change's description:
> Allow any direction scroll on Windows Touchpad
> 
> In this patch, we remove the rails configuration on Direct Manipulation.
> The rails configuration would restrict scroll events on X or Y rails.
> After this changes, user able to scroll to any direction by touchpad as
> touch screen on Windows, Android and touchpad on Edge.
> 
> Bug: 779372
> Change-Id: Idf1da1eb85c2a73f432b78b0002fde28609a4cfe
> Reviewed-on: https://chromium-review.googlesource.com/963043
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543271}

TBR=sky@chromium.org,chaopeng@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 779372
Change-Id: I296a0a1ef3c1a30aaa4d66d5bf24a29932dac543
Reviewed-on: https://chromium-review.googlesource.com/973469Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544859}

The existing flow is not correct, where the decidePolicyForNavigationAction
uses shouldAllowLoadWithNavigationAction to check if it will reject the
request or not before the webstate policy decider, the reason is this
function in some cases return false and launches external applications
without consulting the webstate policyDecider.
the new order guarantees that if the webstate policyDecider rejected the
request, then no external application is going to launch.

Note: There is a todo to move the applaunching code out of that function

Bug: 623016
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I244a497d5c218ecbdd704989ebe5bdc201badcd5
Reviewed-on: https://chromium-review.googlesource.com/973983
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544858}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/6ea47f17c992..1d37d531d536

$ git log 6ea47f17c..1d37d531d --date=short --no-merges --format='%ad %ae %s'
2018-03-16 ayatane Fix moblabvm readme path

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:None


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I19952fda76ae15ed27d42415d1ab47d56ccf6b74
Reviewed-on: https://chromium-review.googlesource.com/974125
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544857}

BUG=823087
TEST=none yet

Change-Id: I5c3c57fb380b2d7ec863d43b2e317f634ed40e5b
Reviewed-on: https://chromium-review.googlesource.com/973899Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544856}

Increases the timeout of the VR instrumentation tests on the VR FYI bot,
as the current amount of time has started flakily timing out due to the
addition of the WebXR tests.

Change-Id: I717c4862782a9089e32944d6f9465f42b602bc9f
Reviewed-on: https://chromium-review.googlesource.com/972195Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544855}

Update the policy documentation and the pref's default value
accordingly.

BUG=511300

Change-Id: I1160474dbe48478d95bfdcdd17017e808b398492
Reviewed-on: https://chromium-review.googlesource.com/968523Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544854}

This test is flaky on the Linux_CFI bot.

TBR=imcheng

Bug: 822337
Change-Id: I65b5eb16c71e43a57dad248deba22b970784f603
Reviewed-on: https://chromium-review.googlesource.com/974162Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544853}

This change:
1) Adds an AppMenuTestApi interface, exposing utility functions for tests to
   use the app menu;
2) Adds implementations of that interface: AppMenuTestApiViews and
   AppMenuTestApiCocoa;
3) Changes the MediaRouterBrowserUITest suite to use AppMenuTestApi instead of
   assuming a Views browser window;
4) Disables MediaRouterUIBrowserTest.OpenDialogWithMediaRouterAction on Mac,
   since it seems to not work (it is already disabled on Win, Linux, and CrOS)

Bug: 817408
Change-Id: I2b977b0c8225a75f2b6298c17832b1b1423dff83
Reviewed-on: https://chromium-review.googlesource.com/968881
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544852}

handle->is_valid() will try to de-reference the handle. This CL changes
->is_valid() to .is_valid() so that the validity check is performed correctly.

Bug: 824144
Change-Id: Ie6f7a5cfa2a7568cdbaceb30e0667d990d1326e3
Reviewed-on: https://chromium-review.googlesource.com/973914Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544851}

This is preparation to move the orientation request protocol
to exo remote shell.

* ash's orientation logic was originally deisnged
for w3c spec, which doesn't have "current" orientation, so it was implemented in
ArcAppWindowLauncherController. I'm moving this to ash so that exo can
implement it without re-implementing it. It'll also make it easy to
test.

* This also moves the logic "apply orientation only in tablet mode" logic
 to ash. I believe this is correct even for html as
ScreenOrientationDelegateChromeos::ScreenOrientationProviderSupported()
returns true only in tablet mode.

* Updated ScreenOrientationControllerTest to switch to tablet mode to
 match the expectation above.

BUG=735078, 823634
TEST=Updated unit tests. See comment above.

Change-Id: Id26ca7e02fd8dcb5396ab05ce61a52c635f6eb54
Reviewed-on: https://chromium-review.googlesource.com/967684
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544850}

TBR=gklassen@chromium.org, jmadill@chromium.org
NOTRY=true

Bug: 824438
Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib92b27fe4a418cbb570a565cf3f1213375f35290
Reviewed-on: https://chromium-review.googlesource.com/974174
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544849}

Change-Id: I45bd5319c04220ea2bd9ceb5dbb5568ad9e1b241
Reviewed-on: https://chromium-review.googlesource.com/973896
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544848}

This change enables incognito tab spawning and closing of all incognito
tabs from the new overflow menu.

BUG=817614

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0d5348ad2cbf740259d8cbd77be4437d59c480c4
Reviewed-on: https://chromium-review.googlesource.com/972156
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544847}

Added a new class for handling actions on the feed and implemented
the action for opening url.

Bug: 803318
Change-Id: Icad663a3e83c4916497194d46f179a48e4f8c0e5
Reviewed-on: https://chromium-review.googlesource.com/971839
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544846}

Posting is still allowed in the SHUTDOWN phase in production (will no-op
when after the thread is torn down as usual) but it is again disallowed
after BrowserThreadImpl::ResetGlobalsForTesting (i.e. after
~TestBrowserThreadBundle).

content/browser/browser_thread_impl.cc :
 - Core change to deny PostTask to uninitialized BrowserThreads
   (shutdown is fine). In practice this prevents posting before
   BrowserMainLoop::CreateThreads in production and outside the scope of
   a TestBrowserThreadBundle in tests (and after
   ~TestBrowserThreadBundle() which fully uninitializes after shutdown).

chrome/browser/chrome_content_browser_client.cc :
 - ChromeContentBrowserClient::SetApplicationLocale can happen
   synchronously if IO thread is not yet initialized (change check to
   reflect proper thread).

content/browser/loader/url_loader_factory_impl_unittest.cc :
 - Make sure TestBrowserThreadBundle outlives members as well.

content/browser/media/capture/desktop_capture_device.cc
chrome/browser/media/router/discovery/dial/dial_url_fetcher.cc
content/browser/media/capture/desktop_capture_device_unittest.cc :
 - crbug.com/823869

content/browser/net/network_quality_observer_impl_unittest.cc :
 - NetworkQualityObserverImpl's constructor uses BrowserThreads, would
   previously no-op and not break the test but this change brings it
   closer to testing the same code as in production

content/browser/renderer_host/media/render_frame_audio_input_stream_factory_unittest.cc
chrome/browser/ssl/ssl_error_handler_unittest.cc
chrome/browser/chromeos/login/signin_partition_manager_unittest.cc
content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm :
 - See inline comments


chrome/browser/component_updater/subresource_filter_component_installer_unittest.cc
chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc :
 - Trivial upgrade from ScopedTaskEnvironment as some logic does use
   BrowserThreads.

Bug: 823797, 823869
Change-Id: Iab99220606714362959a00820ecd46334eae7c8a
Reviewed-on: https://chromium-review.googlesource.com/970861Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544845}

BUG=824071
TEST=covered by unit test

Change-Id: I7b74574b6513586e3bd489bc966cb9352fde5a9d
Reviewed-on: https://chromium-review.googlesource.com/972848
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544844}

This change moves logfont_win.mojom from //mojo/common to
//mojo/public/mojom/base and logfont_win.typemap to
//mojo/public/cpp/base, as well as text_direction.mojom and
corresponding files. Unit test for TextDirection was updated and moved
to mojo_unittests.

Bug: 799482
Change-Id: Ib3d8b09d7aa3b7e12d3f66b38dbcea294a28c035
Reviewed-on: https://chromium-review.googlesource.com/971263Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544843}

Using false for |by_user| for slide out breaks a lot of
NotificationDelegates. We'll have to find another fix.

Bug: 805208,822248
Change-Id: Ic56783427354b96f74ac393b7bcd07380eadfda5
Reviewed-on: https://chromium-review.googlesource.com/966891
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544842}

R=csharp

Bug: 802092
Change-Id: I9837aa806ed9a3f6a58465dbffe2dfd2b34d03ac
Reviewed-on: https://chromium-review.googlesource.com/967945
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544841}

This cl makes some chanes to Keyboard Shortcut Viewer (KSV):
1. Increases icon size to 16.
2. Increases the bubble height to make it circular when containing icon.
3. Updates background color.

Bug: 822351
Test: manual test.
Change-Id: Icbbbd26f6fb653ee7b0214259a1cc9b9610925a9
Reviewed-on: https://chromium-review.googlesource.com/971471Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544840}

Like the corresponding DOM and SVG idlharness tests, the (new)
WebAudio comprehensive IDLHarness test is just too slow on the MSAN
bots and times out. Since it's unlikely we'll fix it and we don't
want to slow down the builds, [Skip] it.

Bug: 824455
Change-Id: Ie8b5f34edeccfa87f4385de0b2797871c48db35f
Reviewed-on: https://chromium-review.googlesource.com/973985Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544839}

Bug: 824461
Change-Id: I5926edbc1263d5dbd8d46eee7123e21be484e20a
Reviewed-on: https://chromium-review.googlesource.com/974062Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544838}

Fixes on-screen keyboard becoming unresponsive when you tap on an
<input> element.

Bug: 824048
Change-Id: I28d58cfb2f8aa70461961a49c7ff80ce0a8c1074
Reviewed-on: https://chromium-review.googlesource.com/974082Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544837}

The incoming z_order represents the relative ordering of the planes
and is just used for sorting the list. Later we assign hw planes in
matching stacking order, so as to preserve the relative order. There's
nothing that prevents us from accepting negative z_order, so remove
this check. This makes the underlay strategy work for ozone.

Bug: 789288
Change-Id: I2961511de53b156042220edeccc4c93e4541d130
Reviewed-on: https://chromium-review.googlesource.com/969831Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544836}

This is a reland of b4c33049

Original change's description:
> Fuchsia: enable packaged runs on more test suites.
>
> Enable packaged runs for:
> * base_unittests
> * crypto_unittests
> * ipc_tests
> * media_unittests
> * mojo_unittests
>
> Bug: 798851
> Change-Id: Iab5a5decc6a85b00c89b975735ea961bdb94a6fe
> Reviewed-on: https://chromium-review.googlesource.com/969300
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#544248}

TBR=dpranke@chromium.org

Bug: 798851
Change-Id: Ic703fdb1c77e6aae3020d8ac8f74cbbea8703cf6
Reviewed-on: https://chromium-review.googlesource.com/972322
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544835}

There's a race in cc somewhere from commit to draw. I don't know exactly
how to repro the race yet even though I have a high probably fix. This
CL is intended to catch the race in the wild and produce a stack trace
in a crash log. Hopefully from there we can acertain repro steps.

Once repo steps are produced locally (either via user interaction or
unit test) then this CL will be reverted.

Bug: 672962
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I3bce066591e15d5c3aac7d4c8685dce411e284b7
Reviewed-on: https://chromium-review.googlesource.com/973987Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544834}

Since DEFINE_TYPE_CASTS now provide a To<type>OrNull, we can use that
instead of essentially open-coding the same thing.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I22113ff36a406d0afc17e5ecf37158e1dec1fe8e
Reviewed-on: https://chromium-review.googlesource.com/973376Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#544833}

This reverts commit c34306d8.

Reason for revert: Win10 driver version was fixed

Original change's description:
> Disable angle-stuck-depth-textures flaky test entirely
> 
> Bug: 820419
> Tbr: kbr@chromium.org
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: Ibd95ec218a700b7a9a6e34336f4ddee5442f8b02
> Reviewed-on: https://chromium-review.googlesource.com/956116
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Luc Ferron <lucferron@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542209}

TBR=jmadill@chromium.org,kbr@chromium.org,lucferron@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 820419
Change-Id: I3b86e2249440b195353583348b0c1fae010e3965
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/973981Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544832}

This bug has been archived with a message instructing people to report bugs to
https://bugs.llvm.org/.

BUG=695243

Change-Id: I5c6655d52797d41229435788632887908f7cb2af
Reviewed-on: https://chromium-review.googlesource.com/973441Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Rob Percival <robpercival@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544831}

The issue is that DisconnectFromHost() invalidates gestureInterpreter
before ClientGesture is destroyed (which is destroyed when the host view
is removed). If the user is interacting with the view after
gestureInterpreter is destroyed but before the view is removed then
ClientGesture will call gestureInterpreter's methods on null, which
crashes the app.

This CL fixes this by always checking _client and
_client.gestureInterpreter before using them.

Bug: 823983
Change-Id: I3889c95daf28b84bbf9aecd26f0024dcb15adbe4
Reviewed-on: https://chromium-review.googlesource.com/972631Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544830}

These tests fail in views-based login since OobeBaseTest has some hard
dependencies on webui login. Refactoring OobeBaseTest will likely take
some time.

Change-Id: Ic7cac68c1e9e0d6630deacfbfdad36a3651f5e6b
BUG: 784495
Reviewed-on: https://chromium-review.googlesource.com/957967Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544829}

Change-Id: I7a22315464ebef4b63069733e6adb0b41d6216af
Reviewed-on: https://chromium-review.googlesource.com/974102Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Nathan Parker <nparker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544828}

Enforce that all mojom::CompositorFrameSinks are destroyed before
FrameSinkManagerImpl is destroyed. Running with VizDisplayCompositor
this will ensure that no RootCompositorFrameSinkImpls exist that could
deadlock the compositor and GPU thread on destruction. For normal Chrome
this will only effect offscreen canvas. Fix offscreen canvas tests so
they destroy everything that is created.

Bug: 820437
Change-Id: I5bd71456ea86fb6b1d89347f4d39de75a72dd86a
Reviewed-on: https://chromium-review.googlesource.com/969590
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Olivia Lai <xlai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544827}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ba51bb3c1274..a68d82cb2fde

$ git log ba51bb3c1..a68d82cb2 --date=short --no-merges --format='%ad %ae %s'
2018-03-21 sergiyb Add progress indicator that prints a dot on nearly each RPCs request
2018-03-21 sergiyb Add ability to filter issues precisely by comment publication date

Created with:
  roll-dep src/third_party/depot_tools


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I9945137a93164f03056aa6d89760e22f7e6c77cb
Reviewed-on: https://chromium-review.googlesource.com/973760
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544826}

Using wpt-import in Chromium 2b021ec7.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/14307

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
msisov@igalia.com:
  external/wpt/webvtt

TBR=robertma

No-Export: true
Change-Id: I35380f44b913fda18833f5ea1318ace9b3a43e41
Reviewed-on: https://chromium-review.googlesource.com/973748
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544825}

Combine updating visibility and importance of a widget into a single
call on RenderProcessHost to update its priority. RPH keeps track of
the priority of each widget (client) and aggregates over them to
compute the effective priority of the process.

This CL is meant to be a pure refactor with no behavior changes.

There are few reasons for this design for future changes:
* New fields are going to be added, so combining them into a single
  struct will adding new fields easier.
* New fields will not be independent, but have meaning that depends on
  existing priority. Tracking fields independently will lead to
  incorrect result; see crbug.com/813232#c12. So they have to be
  updated together.
* Wording has been changed from "widget" to "client" so that workers
  can also contribute priority to RPH in the future.

Bug: 813232
Change-Id: Iaa6877af5010100562655be6b1aa2951219d67b5
Reviewed-on: https://chromium-review.googlesource.com/933224Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544824}

Group targets by isolate id.
Show live heap size for each isolate.

BUG=823874

Change-Id: Ifbc9c51c30a06670f85eea1113a5a24686966658
Reviewed-on: https://chromium-review.googlesource.com/972153
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544823}