- 23 Mar, 2018 40 commits
-
-
Zhenyao Mo authored
not only at GPU command buffer level (state tracking cache), but also at driver level. Otherwise since we might delay the actual call of glDeleteBuffers, then on the driver side, bindings are still active, and inconsistent with the expectation. Certain calls after that, for example, TexImage, or ReadPixels, will be incorrectly affected by such inconsistency. BUG=822976 TEST=gpu_unittests, test case from the bug R=kbr@chromium.org,piman@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I737a2dcfd35bec3b7a36a0971a8437ea4e046ef8 Reviewed-on: https://chromium-review.googlesource.com/974463Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#545476}
-
https://chromium.googlesource.com/angle/angle.git/+log/d779f6a98524..49cef9a52181 $ git log d779f6a98..49cef9a52 --date=short --no-merges --format='%ad %ae %s' 2018-03-21 lucferron Vulkan: Support of A8 textures Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I53758838e777a2812642c65016313cd34ce955c0 Reviewed-on: https://chromium-review.googlesource.com/977899 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545475}
-
https://pdfium.googlesource.com/pdfium.git/+log/aaed69853428..3ae75c2f2e57 $ git log aaed69853..3ae75c2f2 --date=short --no-merges --format='%ad %ae %s' 2018-03-23 thestig Fix IWYU errors in pdfium_test_write_helper.cc. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic91795d152fe209b5e2645db9bb5c35c9d1d0568 Reviewed-on: https://chromium-review.googlesource.com/977897 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545474}
-
Emily Hanley authored
TBR=ashleymarie@chromium.org NOTRY=true Bug: 825234 Change-Id: I655c56cd7d8b775005bff2d606da737fe6dbba80 Reviewed-on: https://chromium-review.googlesource.com/978376Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#545473}
-
Filip Gorski authored
* Adds a bridge for contextual suggestions with method signatures * Adds a cluster type that is going to be used to group contextual suggestions Bug: 824182 Change-Id: I0b8a44cd438b8e27b378d52a15e44b8fd3060044 Reviewed-on: https://chromium-review.googlesource.com/971306 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Patrick Noland <pnoland@google.com> Cr-Commit-Position: refs/heads/master@{#545472}
-
chrome://connection-helpCarlos IL authored
Change-Id: I68fc2bcebd93fe91cf06c0c9da1a94974c7a545b Reviewed-on: https://chromium-review.googlesource.com/976537Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#545471}
-
Alexander Timin authored
Allow (and recommend) using base::CreateSequencedTaskRunner for non-main thread computations in blink (e.g. in platform/blob). Support SequencedTaskRunner instead of SingleThreadTaskRunner in PostCrossThreadTask. R=gab@chromium.org,haraken@chromium.org CC=mek@chromium.org Change-Id: I371f2fa976ef0e9eb36a2b31ad016aa46dba57ed Reviewed-on: https://chromium-review.googlesource.com/977925Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545470}
-
https://webrtc.googlesource.com/src.git/+log/29e7bee3308d..06e363a6e608 $ git log 29e7bee33..06e363a6e --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:801925 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic393e84eccf47403f6854ff5fc5ad73538c1d504 Reviewed-on: https://chromium-review.googlesource.com/977890 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545469}
-
Andrew Grieve authored
Change-Id: Ib1b039c662f63378572468cb26bf75006c92ca79 Reviewed-on: https://chromium-review.googlesource.com/978367Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#545468}
-
Fredrik Söderquist authored
When an element has incoming references that are not in the layout tree (like an element animated by [multiple] SMIL elements), the overhead of the hash set insert/erase can be noticable (like for instance in balls_svg_animation.html.) Bug: 661598, 769774, 823473 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I8a5879186dabd5e071f708ac953b8f1e91b62847 Reviewed-on: https://chromium-review.googlesource.com/978213Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#545467}
-
Chandan Padhi authored
This CL provides support for these constraints in mediaDevices.getSupportedConstraints(). Bug: 823831 Change-Id: I17e251b5433ad6cb23e92655cfdaf114e9b23002 Reviewed-on: https://chromium-review.googlesource.com/977801Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Cr-Commit-Position: refs/heads/master@{#545466}
-
edchin authored
Previously, a crash was hiding the issue this CL fixes. After closing the last incognito tab, the incognito TabModel is destroyed and a new TabModel is set on the incognito TabGridMediator. When the user either taps on a tab or the "new tab" button, |-showActiveTab| is called. This method was previously using the old TabModel (which is nil), instead of the new one that is set on the incognito TabGridMediator. This CL makes sure that |self.incognitoModel| is always up-to-date with the latest model used in the incognito TabGridMediator. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I47f4dc08a3bb01d1b47865b7abd49853cf1973c2 Reviewed-on: https://chromium-review.googlesource.com/977301 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#545465}
-
Tibor Goldschwendt authored
Currently, the native UI does not align with the repositioned content quad and is visible when the exit prompt shows. This CL fixes that. Bug: 824812 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I12f546cb7c5fd4aba2d501443cd0205f59d714cd Reviewed-on: https://chromium-review.googlesource.com/976182 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#545464}
-
Lukasz Anforowicz authored
Planned modifications to SpareRenderProcessHostManager (see https://crrev.com/c/963405) require making sure that BrowserContext::NotifyWillBeDestroyed is called before destroying the context - otherwise some RenderProcessHost(s) (e.g. the spare one) can survive longer than a BrowserContext leading to UaF when the RenderProcessHost(s) are eventually destroyed later (potentially in a different unit test :-). This CL makes sure that NotifyWillBeDestroyed will be called from the destructor of TestBrowserContext (and from a few other subclasses of BrowserContext as appropriate). Destroying the BrowserContext expands the scope of the requirement to properly emulate browser threads in the tests by using TestBrowserThreadBundle in a few more places. Bug: 808114 Change-Id: I60b959e4969c39bededd6de7a3a51a8fdf12e387 Tbr: hidehiko@chromium.org Tbr: juliatuttle@chromium.org Tbr: rouslan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/964804 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#545463}
-
Francois Doray authored
A window with a hidden parent is not painted on the screen. Calling Hide() or Show() on it can't immediately affect occlusion and should therefore not cause occlusion states to be recomputed. This optimization is useful for when we hide a WebContentsViewAura. When we hide a WebContentsViewAura, Hide() is called on child RenderWidgetHostViewAura. There is no reason to recompute occlusion when that happens. Bug: 668690 Change-Id: Id02c195aa5e74313fdc790e365c19337615fcf2b Reviewed-on: https://chromium-review.googlesource.com/970848 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#545462}
-
Charlie Harrison authored
A previous patch updated the ActivationState in the AsyncDocumentSubresourceFilter, but neglected to forward this update to the internal DocumentSubresourceFilter for load state filtering. Bug: 809504 Change-Id: I53d637c35e6bcfc868d0941c1abadc3627c05749 Reviewed-on: https://chromium-review.googlesource.com/976529 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545461}
-
Michael Lippautz authored
The goal of this patch is to simplify handling of ephemeron callbacks and put the right abstraction on top of the uses. On ToT we deduplicate by storing a bit on HashTable and add two callbacks (iteration, done) to two CallbackStacks. This results in overhead of CallbackStack segments of (2048 entries, 2 words) 8KB of memory during GC with a fast check based on a bit in the datastructure. However, this version of a HashTable is only used very rarely with mostly DEFINE_STATIC_LOCAL, so always yields in singletons. Local benchmarking showed ~5-10 instances on major websites. Hence, the simplified design of - Deduplicate by using a hashmap - Store iteration callback in the hashmap to avoid 4KB of CallbackStack - Avoid iteration done callback completely - Use simple ephemeron iteration based on two data structures to avoid problems with iteration during insertion Bug: chromium:757440 Change-Id: I241c6f19fdc9a5f8dfbfdd7902608261744014eb Reviewed-on: https://chromium-review.googlesource.com/977827 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Philip Rogers authored
This patch removes a check for SPV175 that was added in [1]. It is not safe to call LayoutFlowThread::FragmentsBoundingBox if |column_sets_invalidated_|, regardless of SPV175/SPV2. column_sets_invalidated_ is a bit that tracks whether multi_column_set_list_ is up-to-date. In LayoutMultiColumnFlowThread::ColumnSetAtBlockOffset, multi_column_set_list_ is used (and there's a DCHECK that it's valid). FragmentsBoundingBox can call ColumnSetAtBlockOffset through the following: LayoutFlowThread::FragmentsBoundingBox -> LayoutMultiColumnSet::FragmentsBoundingBox -> MultiColumnFragmentainerGroup::FragmentsBoundingBox -> MultiColumnFragmentainerGroup::FlowThreadTranslationAtOffset -> LayoutMultiColumnFlowThread::FlowThreadTranslationAtOffset -> LayoutMultiColumnFlowThread::ColumnSetAtBlockOffset [1] https://codereview.chromium.org/1337233002 Bug: 823127 Change-Id: I2a6e848f4f8b449b2bf4f40cd5d70c4f801f10f6 Reviewed-on: https://chromium-review.googlesource.com/977024Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#545459}
-
Stephen Chenney authored
R=dcheng@chromium.org Bug: 790944,820163,793715,796804,799707,823345 Change-Id: I6daa6aedd8ccff792b99c228d85800dbd2dd3ec2 Reviewed-on: https://chromium-review.googlesource.com/973467Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#545458}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ce913b499c4c..31a3eb064ea3 $ git log ce913b499..31a3eb064 --date=short --no-merges --format='%ad %ae %s' 2018-03-22 achuith deploy_chrome: Finesse --board requirements. Created with: roll-dep src/third_party/chromite BUG=chromium:823996 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I769462f350386abdb114b740c59231cbfaf81da1 Reviewed-on: https://chromium-review.googlesource.com/977887 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545457}
-
Raphael Kubo da Costa authored
Commit ac1a8082 ("aura: changes when WindowPort::OnDidChangeTransform() is called") removed all uses of |old_transform| in the method above, but did not stop defining the variable itself. Change-Id: I4dc0fe3f113bfb0a4e3026216fdb363b2dd4d6e6 Reviewed-on: https://chromium-review.googlesource.com/978183Reviewed-by:
-
Sheriff-o-matic authored
On Win7 the test has been observed to also fail E.g. https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/67059 Change-Id: I1333d2f86def289561752ab31909422bc080d3b4 No-Try: True No-Presubmit: True Bug: 626703 Reviewed-on: https://chromium-review.googlesource.com/978365Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#545455}
-
Maks Orlovich authored
In PartialData::UpdateFromStoredHeaders, the data stream size in cache isn't a reliable notion of the total size of resource if we're still fetching it. Use Content-Length, if available, for that instead. Bug: 822413 Change-Id: I36f09b6d72336385755cd4a1ea22da345b541d67 Reviewed-on: https://chromium-review.googlesource.com/973918 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#545454}
-
Owen Min authored
BrowserDMTokenStorage is used to save/load DMToken for MachineLevelUserCloudPolicy. It's implemented on Windows only for now. Bug: 812641 Change-Id: I9537199356caa0442eb675da379df2e5805dcdaf Reviewed-on: https://chromium-review.googlesource.com/969754Reviewed-by:
Drew Wilson <atwilson@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545453}
-
Reilly Grant authored
This change fixes a leak of reference counts in libusb on Windows. When a device is re-enumerated some of its properties are re-populated. This includes the reference to its parent device. When this happens the reference count on the parent is increased, even if the parent has not changed. This leaks references to objects representing devices that are parents of other devices. This change adds a check that only modifies reference counts when the parent device is being changed. Bug: 819356 Change-Id: I88c28a160b61a278c9e00736be1dac1973b42f47 Reviewed-on: https://chromium-review.googlesource.com/976330Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#545452}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bad8076d..7eb272ed Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I9225757e59d8c5440ac4cec3d5872669cfda334c Reviewed-on: https://chromium-review.googlesource.com/977942Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#545451}
-
Patrik Höglund authored
This is a reland of 34a8f518 It is an error to set proprietary_codecs without ffmpeg_branding as 'Chrome', so this CL uses 'chrome_with_codecs' instead of proprietary_codecs. Original change's description: > Add proprietary_codecs to WebRTC win builders. > > This should get WebRTC H264 perf tests running again. > > Bug: webrtc:8675 > Change-Id: Ife68ff289b9caa02dab94e93f2b255d31f56215f > Reviewed-on: https://chromium-review.googlesource.com/975021 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Patrik Höglund <phoglund@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545100} Bug: webrtc:8675 Change-Id: I8cd3c2a5734b7e04669a6cd06acac02ea9a8ca0f Reviewed-on: https://chromium-review.googlesource.com/977982Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#545450}
-
edchin authored
The Done button logic was faulty in two ways: 1) Enabling/disabling logic was flawed. 2) Tapping Done would show incognito when it should show the regular tab. (And vice-versa). Done button should only disable after the original page (incognito or regular tabs) where the user entered the tab grid is depleted of tabs. This CL fixes this by bookkeeping the |originalPage| that the user entered the tab grid. This CL also modifies the TabPresentationDelegate's |-showActiveTab| so that the intended page is specified in the method. This allows the TabGridViewController to pass the |originalPage| for Done button taps, and the |currentPage| for new tab button taps or tab cell taps. Bug: 824921, 824912 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie81721a181f50b63a92722bf507986aa9596a4f5 Reviewed-on: https://chromium-review.googlesource.com/977561Reviewed-by:
-
Ovidio Henriquez authored
This change allows the removal of a descriptor to be simulated by the Bluetooth test interface. A generated test script was also converted to test the new interface. BUG=569709 Change-Id: Id4286a3e44cd04ee1b371938f1ef89f33458269c Reviewed-on: https://chromium-review.googlesource.com/972334Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#545448}
-
Devlin Cronin authored
Drag-and-dropping an extension should only work in developer mode. Don't display the drop overlay if developer mode is not enabled. Bug: 586247 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5f7306561c6bd6d0e707eabdb988180f4bd98f45 Reviewed-on: https://chromium-review.googlesource.com/976377Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545447}
-
Daniel Bratell authored
This is a jumbo compilation fix. A couple of hours ago a second StopLoadingInBackgroundEnabled() was added which in jumbo builds where *.cc files are compiled together caused a compilation failure. The function is small enough to be inlined so that is what this patch does here and at the original place it was copied from. Bug: 820634 Change-Id: I09d8fe48f4573d67b353eda563abad54c2325769 Reviewed-on: https://chromium-review.googlesource.com/978001Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#545446}
-
Devlin Cronin authored
In extension messaging, if the ID is omitted, we treat it as a message to the extension itself (e.g., from a content script to a background page). With JS bindings, we consider anything false-y to be an omitted ID, which is different than in the rest of the bindings system (where if an argument is supplied, it is used). Unfortunately, it seems there are some libraries relying on the current behavior. Allow '' to be treated as an extension messaging itself for backward compatibility. Do not extend this to all false-y values, others of which would be sufficiently more strange. Add unittests for the same. Bug: 823577 Change-Id: I8c0eaa66da39512af4a85ef11cb3e3979d8d6462 Reviewed-on: https://chromium-review.googlesource.com/973694 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
jonross authored
I landed a replacement for ScrollWaiter which also works in Viz, but forgot to re-enable the tests on viz configs. Doing that now. TBR=kylechar@chromium.org TEST=WebViewGuestScrollTouchTest.TestGuestGestureScrollsBubble Bug: 796336 Change-Id: Ifdee622aa2f8267623698c5f71b10a0b1da5bee8 Reviewed-on: https://chromium-review.googlesource.com/977893Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#545444}
-
Rune Lillesveen authored
This means we can also assume a null ComputedStyle on options means they are display:none. That is a pre-requisite for fixing issue 822581. Bug: 824754 Change-Id: Ia8a400ec8eed9ecb9a85d2c93c354841ad721492 Reviewed-on: https://chromium-review.googlesource.com/975604 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#545443}
-
Christos Froussios authored
Bug: 825209 No-Try: true No-Presubmit: true Change-Id: I9d77fd7fcc21285a8f5107908b9439985edbd29e Reviewed-on: https://chromium-review.googlesource.com/978220Reviewed-by:
-
https://chromium.googlesource.com/catapult.git/+log/734f737c6b57..c4e9b1332818 $ git log 734f737c6..c4e9b1332 --date=short --no-merges --format='%ad %ae %s' 2018-03-23 nednguyen Revert "Add --enable-automation flag in GetFromBrowserOptions()" 2018-03-22 dtu [pinpoint] Set auto_explore == True for "patch jobs". 2018-03-21 ynovikov Remove a note on android_optional_gpu_tests_rel from manual rolls doc. 2018-03-15 dproy Reland "More precise self time calculation" 2018-03-21 nednguyen Ignore fetchts file 2018-03-20 laszio [Telemetry] Support outputing json in benchmark_runner 2018-03-19 kjharland [Dashboard] Whitelist prod Fuchsia Garnet builder. 2018-03-20 benjhayden Fix sorting results.html 2018-03-19 horo Add --enable-automation flag in GetFromBrowserOptions() 2018-03-19 eakuefner [Dashboard] Avoid creating empty rows/histograms/tests if histograms are empty 2018-03-16 dtu [pinpoint] Infer "repository" parameter from configuration. 2018-03-19 chiniforooshan First set of thread times metrics in TBMv2 2018-03-16 erikchen Replace --enable-heap-profiling with --memlog equivalent. 2018-03-19 wangxianzhu Fix visual rect support for cc::DisplayItemList Created with: roll-dep src/third_party/catapult BUG=chromium:822258,chromium:786572,chromium:731979,chromium:821531,chromium:821521,chromium:819969,chromium:822258,chromium:627461,chromium:822843 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I8c0025df6198bf9b1662bb8d78e45741d66f6aff Reviewed-on: https://chromium-review.googlesource.com/977884 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545441}
-
Piotr Kalinowski authored
In case of failure to create a temporary image capture file, GetCameraIntentTask#onPostExecute will receive null Uri. For capture fields, this was already handled by aborting file selection. However, in remaining cases, it would result in an attempt to add this null Uri as EXTRA_OUTPUT and to convert it to ClipData. The latter results in NullPointerException. This change skips processing null Uri in remaining cases. Camera intent without an Uri can only return small version of the image directly as a bitmap, but that is unlikely what user can work with and the rest of the code is not prepared to handle it anyway. So, abort if mDirectToCamera == true, as there is no useful intent to show. Otherwise, proceed with null as a camera intent which will still enable other modes of file selection. This is also in line with the behavior before the introduction of GetCameraIntentTask. Bug: 821440 Change-Id: Ib4024c406bbcaf560e5cdde584c317f1ab6477d2 Reviewed-on: https://chromium-review.googlesource.com/960722 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#545440}
-
Christos Froussios authored
This reverts commit ecf455be. Reason for revert: Suspected of making BrowserCloseManagerWithDownloadsBrowserTest/BrowserClose anagerWithDownloadsBrowserTest.TestWithDownloadsFromDifferentProfiles/ flaky on Asan e.g. https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/26690 Original change's description: > Reland "Turn on native notifications by default for Chrome OS." > > This is a reland of 8ce1863f > > MSan fix was landed as 522e7d29 > > Original change's description: > > Turn on native notifications by default for Chrome OS. > > > > They're already on by default for Mash. This makes Chrome use the mojo > > ("native") interface for notifications even in non-Mash. > > > > Bug: 578868 > > Change-Id: If1ee85e2136dc0480ccee9a57835b0ffb9b47b8b > > Reviewed-on: https://chromium-review.googlesource.com/963518 > > Commit-Queue: Evan Stade <estade@chromium.org> > > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#544395} > > Bug: 578868 > Change-Id: Idac45274aaea709ef910d4bcb20b14f9a05a952c > Reviewed-on: https://chromium-review.googlesource.com/974201 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545113} TBR=stevenjb@chromium.org,sky@chromium.org,estade@chromium.org Change-Id: I8e0e903703cf2d3ca76fe69092bd3029ed0a16f4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 578868, 825141 Reviewed-on: https://chromium-review.googlesource.com/977908Reviewed-by:
-
Hans Wennborg authored
This reverts commit e5145cb7. Reason for revert: This broke browser_tests SettingsAccessibilityTest.EDIT_DICTIONARY_aria_valid_attr_value in Chrome-branded builds (see bug). Original change's description: > Chrome Cleaner UI: Enable user-initiated cleanups by default > > Bug: 800507 > Change-Id: I650e3289a9348a9e350cc5a071fd9fac87aa1e88 > Reviewed-on: https://chromium-review.googlesource.com/969581 > Reviewed-by: Joe Mason <joenotcharles@chromium.org> > Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544166} TBR=joenotcharles@chromium.org,ftirelo@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 800507, 824494 Change-Id: Id59344fc7ebf03c6d8d7370067b9fea10192ea3c Reviewed-on: https://chromium-review.googlesource.com/977907Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#545438}
-
Avi Drissman authored
This is a reland of d3711b44 Original change's description: > Switch MHTML generation to the new callbacks. > > BUG=714018 > > Change-Id: I33cd6842055c959af25e286b1962c6f902b35971 > Reviewed-on: https://chromium-review.googlesource.com/974284 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545087} TBR=avi@chromium.org,jam@chromium.org Bug: 714018 No-Try: true Change-Id: Ibc69a42603ddac0cb386905842659b84d60356a8 Reviewed-on: https://chromium-review.googlesource.com/978162Reviewed-by:
-
