Commits · 6103bb10e382c15dc17590b6b52101c00218358f · eriksson monteiro / tangled

06 Aug, 2020 40 commits

Roll ANGLE from e8789a53f539 to bedac4f06b5c (1 revision) · 6103bb10

chromium-autoroll authored Aug 06, 2020

https://chromium.googlesource.com/angle/angle.git/+log/e8789a53f539..bedac4f06b5c

2020-08-06 syoussefi@chromium.org Move EXT_external_objects validation to validationESEXT.cpp

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: geofflang@google.com
Change-Id: I4f201f293ffb03dd027eda3e9738062c9977a763
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340625Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#795371}

6103bb10

[Signin][Android] Replace boolean with enum states in web sign-in flow · 5f16f81a

Alice Wang authored Aug 06, 2020

This CL replaces the boolean flag IS_ACCOUNT_LIST_EXPANDED with enum
state class to represent different states of the account picker bottom
sheet. This refactoring will facilitate our future tasks of adding new
screens like |sign-in in progress| to the bottom sheet.

Bug: 1106442
Change-Id: I072693a393e14987c66888549956fdc49c386d36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311577Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795370}

5f16f81a

Revert "Allow termina to be installed via dlc" · b34ee645

Alexey Baskakov authored Aug 06, 2020

This reverts commit d539d683.

Reason for revert: Fails the bots
https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/40249

Original change's description:
> Allow termina to be installed via dlc
> 
> Also refactor the current installer code out of CrostiniManager
> 
> Bug: 953544
> Change-Id: Iad0850ffba616ac3f45adff63a5e21d57d3b5e7a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330111
> Commit-Queue: Fergus Dall <sidereal@google.com>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: David Munro <davidmunro@google.com>
> Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
> Reviewed-by: Nicholas Verne <nverne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#795336}

TBR=stevenjb@chromium.org,waffles@chromium.org,nverne@chromium.org,sidereal@google.com,kimjae@chromium.org,davidmunro@google.com,andrewlassalle@chromium.org

Change-Id: Ia6eb9c6318ba41426eab212746af7e3344e67ad2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 953544
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340926Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795369}

b34ee645

VulkanSwapChain: reuse VkSemaphores · 5c4158b6

Peng Huang authored Aug 06, 2020

This change simplified the semaphore logic in VulkanSwapChain by reusing
VkSemaphores. It also improved performance on Linux workstation
slightly, but it could improve more if vkCreateSemaphore() is heavy for
some other platforms.

Bug: 1004772
Change-Id: Ifa5c5255627b4824b946f62d6edfa8d3f0c2ecb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331000
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Auto-Submit: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795368}

5c4158b6

Revert "Start setting StartVmRequest.vm" · e5c346ca

Alexey Baskakov authored Aug 06, 2020

This reverts commit 6d67f881.

Reason for revert: Fails https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel

Original change's description:
> Start setting StartVmRequest.vm
> 
> This is currently ignored by concierge when starting termina, but
> since termina can now be installed in multiple different locations we
> need concierge to start taking the value that chrome sets.
> 
> Bug: 953544
> Change-Id: I51b1ea50a5ae056d6af6baa0743a3cb0c8f8f5e5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329126
> Commit-Queue: Fergus Dall <sidereal@google.com>
> Reviewed-by: Nicholas Verne <nverne@chromium.org>
> Reviewed-by: David Munro <davidmunro@google.com>
> Cr-Commit-Position: refs/heads/master@{#795346}

TBR=nverne@chromium.org,sidereal@google.com,davidmunro@google.com

Change-Id: I6635ec58a213c3f62a855a4487bc3cb96c9e4821
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 953544
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340942Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795367}

e5c346ca

Revert "Roll src/third_party/harfbuzz-ng/src/ e3af529e5..cdb7d2b9b (284 commits)" · 59aa69e6

Alexey Baskakov authored Aug 06, 2020

This reverts commit 1d21b497.

Reason for revert: A culprit that fails virtual/text-antialias/mac-system-ui-weight.html on Mac
https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Mac10.13%20%28retina%29/32138

Original change's description:
> Roll src/third_party/harfbuzz-ng/src/ e3af529e5..cdb7d2b9b (284 commits)
> 
> https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/e3af529e511c..cdb7d2b9bc0d
> 
> $ git log e3af529e5..cdb7d2b9b --date=short --no-merges --format='%ad %ae %s'
> 2020-08-02 ebrahim [docs] Update README.python.md with meson
> 2020-08-02 ebrahim [docs] Adopt CONFIG.md with meson
> 2020-08-02 ebrahim [docs] Remove packagers related part
> 2020-08-02 ebrahim [ci] Disable Travis CI
> 2020-08-02 ebrahim [meson] limit check-libstdc++ check to 0.55
> 2020-07-30 ebrahim [meson] Add darwin versions to library()
> 2020-07-31 grieger [ENOMEM] check vector status in cmap subsetting.
> 2020-07-31 grieger [ENOMEM] in GSUB ChainContext subsetting check maps for allocation errors.
> 2020-07-31 grieger [ENOMEM] Check result of vector resize in CBDT subsetting.
> 2020-07-31 ebrahim [ci] don't install rustc on linux-ci
> 2020-07-31 ebrahim [cff] Check for scalars array resize result
> 2020-07-30 grieger [ENOMEM] popragate packed/packed_map errors to the serializer. Will disable further modifications based on a bad state.
> 2020-07-30 grieger [ENOMEM] unchecked resize in CFF2.
> 2020-07-30 grieger [ENOMEM] Fix several instances of not checking resize in CFF.
> 2020-07-30 grieger [ENOMEM] check for unset current in serializer->length().
> 2020-07-30 ebrahim Copy parts of README.md to README
> 2020-07-30 ebrahim [meson] minor, use null_dep one more place
> 2020-07-30 ebrahim Remove cmake build files
> 2020-06-18 ebrahim Add comparison against ttf-parser
> 2020-07-30 ebrahim [docs] Update TESTING.md with meson
> 2020-07-29 grieger [ENOMEM] fix memory leak if allocation fails during pop_pack().
> 2020-07-29 grieger [ENOMEM] make serializer modification operations no-ops if it's in an error state.
> 2020-07-30 ebrahim [icu] Remove support for versions older than 49
> 2020-07-30 ebrahim [icu] Remove useless HB_UNUSED tags
> 2020-07-30 ebrahim [icu] Remove support of ICU versions before 42
> 2020-07-29 grieger [ENOMEM] Fix failure to check calloc return. Fixes https://oss-fuzz.com/testcase-detail/6246465148813312.
> 2020-07-29 grieger [ENOMEM] check resize() return. Fixes https://oss-fuzz.com/testcase-detail/5641892164009984.
> 2020-07-29 ebrahim [docs] Use untouched result of rsvg-convert for HarfBuzz.svg render
> 2020-07-29 ebrahim [ci] Install meson's master
> 2020-07-29 ebrahim minor spacing tweak
> 2020-07-29 ebrahim minor spacing tweak
> 2020-07-29 ebrahim minor spacing tweak
> 2020-07-29 ebrahim [ENOMEM] Fix buffer's content check logic
> 2020-07-14 ebrahim [fuzz] Implement failing allocator
> 2020-07-29 ebrahim [glib] Default to glib's script type handling
> 2020-07-28 grieger [subset] bail out of subsetting if plan allocation fails.
> 2020-07-27 ebrahim [tests] minor
> 2020-07-27 ebrahim [tests] Use TTFont of fonttools to avoid temp files
> 2020-07-26 hamidrezabayat76 Use fonttools's python package instead of cli
> 2020-07-25 ebrahim [ci] meson-gcc-mingw to crossbuild-win32
> 2020-07-25 ebrahim [releasing] unbreak the build
> 2020-07-25 ebrahim [releasing] Use release buildtype
> 2020-07-25 ebrahim 2.7.0
> 2020-07-23 razrfalcon Remove unused code from the Khmer shaper.
> 2020-07-22 ebrahim [meson] Rename 'gtk_doc' option to 'docs'
> 2020-07-22 ebrahim [ci] Don't run cov-analyze
> 2020-07-22 ebrahim minor
> 2020-07-22 ebrahim [fuzz] increase shape fuzzer timeout
> 2020-07-20 boboniboni [tests] fix PGO build testing
> 2020-07-20 ebrahim [ci] disable clang nightly installation
> (...)
> 2020-06-10 ebrahim [meson] Implement disabled state for cairo/freetype/icu
> 2020-06-09 nirbheek meson: Export symbols for a DLL when not building statically
> 2020-06-08 khaledhosny [coretext] Properly check for macOS 10.10
> 2020-06-06 ebrahim [meson] Remove with_libstdcxx build option
> 2020-06-05 behdad s/blacklist/blocklist/g
> 2020-06-05 ebrahim [meson] Add -Bsymbolic-functions
> 2020-06-02 ebrahim [meson] Make gobject and introspection features automatic
> 2020-06-05 ebrahim minor, improve the need for graphite comment
> 2020-06-03 reiter.christoph [meson] Only pass required dependencies to everything
> 2020-06-04 ebrahim [style] Hide behind HB_EXPERIMENTAL_API compile flag
> 2020-04-21 ebrahim [style] Adopt with meson
> 2020-02-08 ebrahim [style] give ptem value when asked for opsz
> 2019-08-04 ebrahim [style] New experimental API, hb_style_get_value
> 2020-06-04 ebrahim [meson] fix with_libstdcxx effect
> 2020-06-04 ebrahim [meson] Update subset tests list from autotools
> 2020-06-04 ebrahim [ci] fix meson-gcc-mingw bot
> 2020-06-04 ebrahim [ci] check workability of meson based dist
> 2020-06-04 ebrahim [ci] Deploy only when there is something to push
> 2020-06-04 ebrahim [meson] Fix gen-hb-version.py run
> 2020-06-04 ebrahim [meson] Remove amalgam build option
> 2020-06-04 ebrahim [ci] Move docs deployment from autotools to meson
> 2020-06-03 ebrahim [meson] fix gen script input
> 2020-06-03 ebrahim Use output names in update-unicode-tables.make
> 2020-06-03 ebrahim 2.6.7
> 2020-06-02 ebrahim Move unicode tables update script to its own make file
> 2020-06-02 ebrahim minor, fix hb-version.h generation for out-of-tree builds
> 2020-06-02 ebrahim minor fixes on src gen scripts
> 2020-06-01 ebrahim Build win32 artifacts using meson
> 2020-05-31 ebrahim [tests/aots] move the update script to update.py
> 2020-05-31 ebrahim [tests/test-rendering-tests] run git pull on correct dir
> 2020-05-31 ebrahim minor, fix extra dist list
> 2020-05-31 ebrahim [test/text-rendering-tests] Adopt the update script with meson
> 2020-05-31 ebrahim [test/text-rendering-tests] Update from upstream
> 2020-05-31 ebrahim [tests] Port text-rendering-tests update script to python
> 2020-05-30 ebrahim [meson] Categorize tests using `suite: [...]`
> 2020-05-30 ebrahim [ci] fix alpine build issue
> 2020-05-29 ebrahim [tests] Port check scripts to python
> 2020-05-29 ebrahim [meson] reflect chosen linker update
> 2020-05-29 ebrahim [meson] minor, find run-tests.py only once
> 2020-02-18 qxliu [subset] GDEF AttachList subsetting support
> 2020-05-29 ebrahim minor on python scripts
> 2020-05-29 ebrahim minor, use py3's open(encoding=)
> 2020-05-28 ebrahim minor, enable printing to stderr in run-tests.py
> 2020-05-28 ebrahim minor, use sys.exit print shorthand
> 2020-05-28 ebrahim minor, move scripts manuals to __doc__
> 2020-05-20 qxliu [subset] ChainContext subsetting fix: add lookup index remapping
> 2020-03-30 simon More strictly follow noun/verb/identifier format for GPOS/GSUB lookups
> 2020-03-30 simon Reformat kerx/morx instrumentation to 'verb noun identifier'
> 2020-03-30 simon Add table index to lookup messages
> 2020-03-30 simon Instrument entering GSUB/GPOS tables
> 
> Created with:
>   roll-dep src/third_party/harfbuzz-ng/src
> R=bashi@chromium.org,behdad@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org
> 
> Change-Id: I397e890f896e74221788acf630172fb18cdbe5f3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336089
> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Auto-Submit: Dominik Röttsches <drott@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#795347}

TBR=bashi@chromium.org,bungeman@chromium.org,eae@chromium.org,kojii@chromium.org,drott@chromium.org,jshin@chromium.org,behdad@chromium.org

Change-Id: I0bf6d810a021e3827a6106c6a7edaa566f318d2b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340862Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795366}

59aa69e6

Update non-navigation content/ tests to handle same-site BrowsingInstance swap · d3af5db9

Rakina Zata Amni authored Aug 06, 2020

With crrev.com/c/2121522, some main-frame same-site navigations will
result in a new BrowsingInstance, SiteInstance, RenderFrameHost,
RenderView, etc. This CL updates expectations of tests under contents/
that didn't expect a change of RenderFrameHosts etc. on same-site main
frame navigations.

This CL does not include:
- Updates for navigation-related content_browsertests and
content_unittests, which are handled in crrev.com/c/2195872 and
crrev.com/c/22100358.
- Updates for tests under chrome/, components/ and layout tests (fixed
in other CLs)
- Fix to ensure order of unload handlers on same-site cross-RFH
navigations (will be fixed on a future CL)
- Fix to ensure WebPreferences are carried over for cross-RFH same-site
navigations (will be fixed on a future CL)

For more details, see doc: https://docs.google.com/document/d/1lHdkKLUe8H6ZP6ALwj-dsus7oYcuc93HkSCHCcerItg/edit?usp=sharing

Bug: 977562
Change-Id: I1fc507538b48d7566be28a4bd2ef83ff3cacd843
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210174Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Sreeja Kamishetty <sreejakshetty@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795365}

d3af5db9

Enable browser_tests on lacros ci builder · 80734f12

Sven Zheng authored Aug 06, 2020

The filter list is based on the latest fyi bot runs:
https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-fyi-rel/209?
Only filter out the failing tests. Flaky tests will be run.

Bug: 1111979
Change-Id: Ieb722c2ad4b2a648c5eac9408427eaf03ad3d244
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340264
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795364}

80734f12

[Signin][Android] Add empty onDismiss method to AccountPickerDelegate · e7d6cad2

Alice Wang authored Aug 06, 2020

This CL adds an empty method onDismiss to AccountPickerDelegate so we
can release resources in this method later when working with
WebSigninBridge.

Bug: 1093741
Change-Id: Ibcea89c360431e102115faa3e7b34eb435253252
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339514Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795363}

e7d6cad2

Use ClassicScript in unit tests · 418d2506

Hiroshige Hayashizaki authored Aug 06, 2020

This CL doesn't change the behavior.

Bug: 1111134
Change-Id: I297685e02f1cb1a2184fef9248f0a34081aa0a81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331177Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795362}

418d2506

Roll Fuchsia SDK from 0.20200805.3.1 to 0.20200806.0.1 · 787d393a

chromium-autoroll authored Aug 06, 2020

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: Iaeb43375a78b212f92f4c296e1a7a70846fec86e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339053Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#795361}

787d393a

[Android] Update OWNERS information (announcement) · 5b476c1b

Fred Mello authored Aug 06, 2020

https://docs.google.com/document/d/1VGgqZjX4RCA7c5iKMeexJ-VU8PQ_vpbGM4mvT2mXKDY

Bug: 1112872
Change-Id: I8c8d0d57b60d39a24f34c31ebc03517ad60f4087
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337262
Auto-Submit: Fred Mello <fredmello@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795360}

5b476c1b

Use ClassicScript in document_xml_tree_viewer.cc · d7494a3c

Hiroshige Hayashizaki authored Aug 06, 2020

This CL doesn't change the behavior.

Bug: 1111134
Change-Id: I571b274c736224d5dbef9e9ac4ae4fb847733ffb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330878
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795359}

d7494a3c

Roll Depot Tools from b932a7fed903 to 8351dc1fb7c4 (1 revision) · f1bc6a4e

chromium-autoroll authored Aug 06, 2020

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b932a7fed903..8351dc1fb7c4

2020-08-06 bpastene@chromium.org Revert "[Fixed from older branch] Timing/RDB for lower-level checks"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1106943,chromium:1113506
Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com
Change-Id: I3e2a2fb65e87dc2615d67bdb61158183d592b86e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340762Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#795358}

f1bc6a4e

Update SiteSettingsHandlerTest::SetUp() · 080f9f3d

Kenichi Ishibashi authored Aug 06, 2020

AllowJavascript() seems to depend on CookieStoreManager, and
CookieStoreManager uses service workers. TSAN detected a data
race in SiteSettingsHandlerTests when service worker code base
is changed to replace a direct C++ method call with a mojo method
call (see the linked bug for details). This CL adds a run loop
in SetUp() to avoid the data race.

Before this CL, the data race could happen because:
* service worker tries to create leveldb_env::ChromiumEnv on a
  non-main thread.
* ChromiumEnv reads FeatureList.
* SiteSettingsHandlerTests use ScopedFeatureList and destruct it
  without waiting for ChromiumEnv creation on the main thread.

Bug: 1112825
Change-Id: I74793045aa865410c032e651ee407c417424ba68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340297
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com>
Cr-Commit-Position: refs/heads/master@{#795357}

080f9f3d

Add regression test for Media Session notification update bug. · 80ad7955

Evan Stade authored Aug 06, 2020

Bug: 1106641
Change-Id: I87570647e8b163f991c963eaa732a90b47c00bd4
Fixed: 1108038
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336017Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Auto-Submit: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795356}

80ad7955

Restrart collecting hyphenation histograms · 6944687c

Koji Ishii authored Aug 06, 2020

This reverts commit fd0f9b34.

This patch restarts collecting following histograms again,
as we try to enable them on Win/Linux/ChromeOS, and the
discussion restarted.

> Stop collecting hyphenation histograms
>
> This patch removes following histograms:
>   Hyphenation.Open
>   Hyphenation.Open.File
>
> These are added to learn how long it will take to open
> hyphenation dictionary. A concern was raised when I
> implemented hyphenation on Android as the open operation is
> synchronous.
>
> We do not see the data indicating needs to invest in
> asynchronous hyphenation at this moment, and the data is
> steady that further recording does not seem to be necessary.
>
> Bug: 975142
> Change-Id: I1d98eedf47a1afa5940f6e01b3c6fadcca4cbcdf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664092
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Reviewed-by: Stephen Chenney <schenney@chromium.org>
> Commit-Queue: Koji Ishii <kojii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#670299}

Bug: 975142
Change-Id: I72ed8a0a085b873abcab1db86c28a0ef0aa81a68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340065
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795355}

6944687c

Revert "Re-enable VTConfigUtil tests for BT.2020 HDR on 10.10" · 56f3a084

Alexey Baskakov authored Aug 06, 2020

This reverts commit 43a3abc8.

Reason for revert: Fails MacOS 10.11 and 10.12 bots
VTConfigUtil.GetImageBufferColorSpace_BT2020_*
https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/53189

Original change's description:
> Re-enable VTConfigUtil tests for BT.2020 HDR on 10.10
> 
> These should expect BT.709 when the proper color spaces are not
> supported by the OS version.
> 
> R=sandersd
> 
> Fixed: 1113153
> Change-Id: I86805fc80904236d5051ece61ce6612e3b64e74d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339538
> Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#795310}

TBR=dalecurtis@chromium.org,sandersd@chromium.org

Change-Id: I92432c0bf73d1487553f41190346f7d79ae8e0ef
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340627Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795354}

56f3a084

Remove V8Initializer::MessageHandlerInWorker() reentrant check · e4730205

Hiroshige Hayashizaki authored Aug 06, 2020

When an exception is thrown in workers,
ExecutionContext::DispatchErrorEvent() is called

[A] From V8Initializer::MessageHandlerInWorker() in some cases and
[B] Directly (without MessageHandlerInWorker()) in other cases,

which leads calling WorkerGlobalScope.onerror.

When an exception is thrown from the
WorkerGlobalScope.onerror handler,
MessageHandlerInWorker() is called

[A] reentrantly from MessageHandlerInWorker(), and
[B] not reentrantly.

Because MessageHandlerInWorker() contains a reentrant check,
a part of unhandled exception handling is skipped only in cases [A],
but not in [B].

This CL removes the reentrant check to always perform
the unhandled exception handling, thus fixing the
behavior of crbug/1112228.

Skipping the reentrant check leads calling
ExecutionContext::DispatchErrorEvent()
from outer ExecutionContext::DispatchErrorEvent(),
but DispatchErrorEvent() is already reentrantly called
in cases [B], and DispatchErrorEvent() contains
its own reentrant handling code.

Bug: 1112228, 1111134, 1111750
Change-Id: I87b12ddad3fe082bea3429f8801563d08fc0cd6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332091
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795353}

e4730205

Roll Skia from b72037527fd5 to d2f4008a5291 (1 revision) · c3ff36d9

chromium-autoroll authored Aug 06, 2020

https://skia.googlesource.com/skia.git/+log/b72037527fd5..d2f4008a5291

2020-08-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 076a4e58205d to fa4b74d479aa (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC herb@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: herb@google.com
Change-Id: I05034d85666284099d9404698f2c8af23f3a6611
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340663Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#795352}

c3ff36d9

Add kojii@ to harfbuzz OWNERS · f463fdc8

Kenichi Ishibashi authored Aug 06, 2020

Bug: N/A
Change-Id: Id8050ad419632332b564cf5eee8e0475ee6e120f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340783Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795351}

f463fdc8

Add test for GuestOsRegistryService terminal pref/app merge · 8f881f8c

Joel Hockey authored Aug 06, 2020

Bug introduced in crrev.com/c/2318945 / 86.0.4215.0
Fixed already in crrev.com/c/2326552 / 86.0.4218.0

This test verifies that even when Terminal has some pref values, it
correctly merges with app values and creates a valid registration.

Bug: 1113477
Change-Id: I3a51ae3713384284075677d2e531c28aa901e780
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340345Reviewed-by: David Munro <davidmunro@google.com>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Auto-Submit: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795350}

8f881f8c

Add CallbackList::AddUnsafe(). · 0fdb3281

Peter Kasting authored Aug 06, 2020

This is useful for callers who never want to cancel callbacks and can
guarantee the lifetime requirements.  For example, callbacks bound on
the same object that owns the CallbackList.

Bug: 1113007
Change-Id: I258d029360213a689bf888cca662ae56dec4cd74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337537
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795349}

0fdb3281

[WPT] Add more tests for exceptions in WorkerGlobalScope.onerror · 0b796d63

Hiroshige Hayashizaki authored Aug 06, 2020

Failing on Chromium and passing on Firefox and Safari.

third_party/blink/web_tests/fast/workers/worker-onerror-04.html
is removed because now it's covered by the WPT.

Bug: 1112228
Change-Id: If407eb1c96b29357bbc0468e1a6abb30d2891447
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331794
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795348}

0b796d63

Roll src/third_party/harfbuzz-ng/src/ e3af529e5..cdb7d2b9b (284 commits) · 1d21b497

Dominik Röttsches authored Aug 06, 2020

https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/e3af529e511c..cdb7d2b9bc0d

$ git log e3af529e5..cdb7d2b9b --date=short --no-merges --format='%ad %ae %s'
2020-08-02 ebrahim [docs] Update README.python.md with meson
2020-08-02 ebrahim [docs] Adopt CONFIG.md with meson
2020-08-02 ebrahim [docs] Remove packagers related part
2020-08-02 ebrahim [ci] Disable Travis CI
2020-08-02 ebrahim [meson] limit check-libstdc++ check to 0.55
2020-07-30 ebrahim [meson] Add darwin versions to library()
2020-07-31 grieger [ENOMEM] check vector status in cmap subsetting.
2020-07-31 grieger [ENOMEM] in GSUB ChainContext subsetting check maps for allocation errors.
2020-07-31 grieger [ENOMEM] Check result of vector resize in CBDT subsetting.
2020-07-31 ebrahim [ci] don't install rustc on linux-ci
2020-07-31 ebrahim [cff] Check for scalars array resize result
2020-07-30 grieger [ENOMEM] popragate packed/packed_map errors to the serializer. Will disable further modifications based on a bad state.
2020-07-30 grieger [ENOMEM] unchecked resize in CFF2.
2020-07-30 grieger [ENOMEM] Fix several instances of not checking resize in CFF.
2020-07-30 grieger [ENOMEM] check for unset current in serializer->length().
2020-07-30 ebrahim Copy parts of README.md to README
2020-07-30 ebrahim [meson] minor, use null_dep one more place
2020-07-30 ebrahim Remove cmake build files
2020-06-18 ebrahim Add comparison against ttf-parser
2020-07-30 ebrahim [docs] Update TESTING.md with meson
2020-07-29 grieger [ENOMEM] fix memory leak if allocation fails during pop_pack().
2020-07-29 grieger [ENOMEM] make serializer modification operations no-ops if it's in an error state.
2020-07-30 ebrahim [icu] Remove support for versions older than 49
2020-07-30 ebrahim [icu] Remove useless HB_UNUSED tags
2020-07-30 ebrahim [icu] Remove support of ICU versions before 42
2020-07-29 grieger [ENOMEM] Fix failure to check calloc return. Fixes https://oss-fuzz.com/testcase-detail/6246465148813312.
2020-07-29 grieger [ENOMEM] check resize() return. Fixes https://oss-fuzz.com/testcase-detail/5641892164009984.
2020-07-29 ebrahim [docs] Use untouched result of rsvg-convert for HarfBuzz.svg render
2020-07-29 ebrahim [ci] Install meson's master
2020-07-29 ebrahim minor spacing tweak
2020-07-29 ebrahim minor spacing tweak
2020-07-29 ebrahim minor spacing tweak
2020-07-29 ebrahim [ENOMEM] Fix buffer's content check logic
2020-07-14 ebrahim [fuzz] Implement failing allocator
2020-07-29 ebrahim [glib] Default to glib's script type handling
2020-07-28 grieger [subset] bail out of subsetting if plan allocation fails.
2020-07-27 ebrahim [tests] minor
2020-07-27 ebrahim [tests] Use TTFont of fonttools to avoid temp files
2020-07-26 hamidrezabayat76 Use fonttools's python package instead of cli
2020-07-25 ebrahim [ci] meson-gcc-mingw to crossbuild-win32
2020-07-25 ebrahim [releasing] unbreak the build
2020-07-25 ebrahim [releasing] Use release buildtype
2020-07-25 ebrahim 2.7.0
2020-07-23 razrfalcon Remove unused code from the Khmer shaper.
2020-07-22 ebrahim [meson] Rename 'gtk_doc' option to 'docs'
2020-07-22 ebrahim [ci] Don't run cov-analyze
2020-07-22 ebrahim minor
2020-07-22 ebrahim [fuzz] increase shape fuzzer timeout
2020-07-20 boboniboni [tests] fix PGO build testing
2020-07-20 ebrahim [ci] disable clang nightly installation
(...)
2020-06-10 ebrahim [meson] Implement disabled state for cairo/freetype/icu
2020-06-09 nirbheek meson: Export symbols for a DLL when not building statically
2020-06-08 khaledhosny [coretext] Properly check for macOS 10.10
2020-06-06 ebrahim [meson] Remove with_libstdcxx build option
2020-06-05 behdad s/blacklist/blocklist/g
2020-06-05 ebrahim [meson] Add -Bsymbolic-functions
2020-06-02 ebrahim [meson] Make gobject and introspection features automatic
2020-06-05 ebrahim minor, improve the need for graphite comment
2020-06-03 reiter.christoph [meson] Only pass required dependencies to everything
2020-06-04 ebrahim [style] Hide behind HB_EXPERIMENTAL_API compile flag
2020-04-21 ebrahim [style] Adopt with meson
2020-02-08 ebrahim [style] give ptem value when asked for opsz
2019-08-04 ebrahim [style] New experimental API, hb_style_get_value
2020-06-04 ebrahim [meson] fix with_libstdcxx effect
2020-06-04 ebrahim [meson] Update subset tests list from autotools
2020-06-04 ebrahim [ci] fix meson-gcc-mingw bot
2020-06-04 ebrahim [ci] check workability of meson based dist
2020-06-04 ebrahim [ci] Deploy only when there is something to push
2020-06-04 ebrahim [meson] Fix gen-hb-version.py run
2020-06-04 ebrahim [meson] Remove amalgam build option
2020-06-04 ebrahim [ci] Move docs deployment from autotools to meson
2020-06-03 ebrahim [meson] fix gen script input
2020-06-03 ebrahim Use output names in update-unicode-tables.make
2020-06-03 ebrahim 2.6.7
2020-06-02 ebrahim Move unicode tables update script to its own make file
2020-06-02 ebrahim minor, fix hb-version.h generation for out-of-tree builds
2020-06-02 ebrahim minor fixes on src gen scripts
2020-06-01 ebrahim Build win32 artifacts using meson
2020-05-31 ebrahim [tests/aots] move the update script to update.py
2020-05-31 ebrahim [tests/test-rendering-tests] run git pull on correct dir
2020-05-31 ebrahim minor, fix extra dist list
2020-05-31 ebrahim [test/text-rendering-tests] Adopt the update script with meson
2020-05-31 ebrahim [test/text-rendering-tests] Update from upstream
2020-05-31 ebrahim [tests] Port text-rendering-tests update script to python
2020-05-30 ebrahim [meson] Categorize tests using `suite: [...]`
2020-05-30 ebrahim [ci] fix alpine build issue
2020-05-29 ebrahim [tests] Port check scripts to python
2020-05-29 ebrahim [meson] reflect chosen linker update
2020-05-29 ebrahim [meson] minor, find run-tests.py only once
2020-02-18 qxliu [subset] GDEF AttachList subsetting support
2020-05-29 ebrahim minor on python scripts
2020-05-29 ebrahim minor, use py3's open(encoding=)
2020-05-28 ebrahim minor, enable printing to stderr in run-tests.py
2020-05-28 ebrahim minor, use sys.exit print shorthand
2020-05-28 ebrahim minor, move scripts manuals to __doc__
2020-05-20 qxliu [subset] ChainContext subsetting fix: add lookup index remapping
2020-03-30 simon More strictly follow noun/verb/identifier format for GPOS/GSUB lookups
2020-03-30 simon Reformat kerx/morx instrumentation to 'verb noun identifier'
2020-03-30 simon Add table index to lookup messages
2020-03-30 simon Instrument entering GSUB/GPOS tables

Created with:
roll-dep src/third_party/harfbuzz-ng/src
R=bashi@chromium.org,behdad@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org

Change-Id: I397e890f896e74221788acf630172fb18cdbe5f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336089
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Auto-Submit: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795347}

1d21b497

Start setting StartVmRequest.vm · 6d67f881

Fergus Dall authored Aug 06, 2020

This is currently ignored by concierge when starting termina, but
since termina can now be installed in multiple different locations we
need concierge to start taking the value that chrome sets.

Bug: 953544
Change-Id: I51b1ea50a5ae056d6af6baa0743a3cb0c8f8f5e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329126
Commit-Queue: Fergus Dall <sidereal@google.com>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: David Munro <davidmunro@google.com>
Cr-Commit-Position: refs/heads/master@{#795346}

6d67f881

Roll Perfetto Trace Processor Win from f52572f002a6 to dcb6f8084e45 · bf4855f6

chromium-autoroll authored Aug 06, 2020

https://android.googlesource.com/platform/external/perfetto.git/+log/f52572f002a6..dcb6f8084e45

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I6fac3870b889b705b164292b0719b4db16463d44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340448Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#795345}

bf4855f6

Roll DevTools Frontend from a4a8199cf1a3 to 9a4b91647e23 (1 revision) · ca7eedf3

chromium-autoroll authored Aug 06, 2020

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a4a8199cf1a3..9a4b91647e23

2020-08-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I74cf115aed254642abb7e0f54e043e507c75df5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339800Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#795344}

ca7eedf3

Roll src-internal from 9a19fe997b33 to f7f6b8b6f018 (5 revisions) · 401b8ca5

chromium-internal-autoroll authored Aug 06, 2020

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9a19fe997b33..f7f6b8b6f018

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC loyso@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: loyso@google.com
Change-Id: Iab96829eaea4fac926c3efb50d9e3c9376469c52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339413Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#795343}

401b8ca5

[FragmentItem] Add tests for NGFragmentItems-rooted cursors · 0f115ef6

Koji Ishii authored Aug 06, 2020

r795011 crrev.com/c/2313736 added tests for:
* Enumerate all fragments for a |LayoutObject| across
  fragmentainers.
* Enumerate all fragments for a |LayoutObject| within a
  specified item (line).
but did not cover the case:
* Enumerate all fragments for a |LayoutObject| within a
  specified fragmentainer (NGFragmentItems).

This patch extends the tests to cover the last case.

Bug: 1112657
Change-Id: Ia559421a09451c902c35f58346391666749da73e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340405Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795342}

0f115ef6

crostini: Increase default container size · 3c845ceb

David Munro authored Aug 06, 2020

At 5 GiB you don't have enough free space for some common developer apps
e.g. Android Studio, so bump the default up a little. Since our new
default doesn't divide nicely into 1GiB increments (which, if they have
enough free space, is the granularity we use) insert the default between
the two closest ticks if it's not an exact multiple.

Bug: chromium:1111869
Test: CQ, Manual
Change-Id: I05a5103d1683a2012ec6f5ca76ba02bf872c543e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332095
Auto-Submit: David Munro <davidmunro@google.com>
Reviewed-by: Fergus Dall <sidereal@google.com>
Commit-Queue: David Munro <davidmunro@google.com>
Cr-Commit-Position: refs/heads/master@{#795341}

3c845ceb

Change PostLayout to return |this| when valid · 4079ba19

Koji Ishii authored Aug 06, 2020

|PostLayout| was designed to
a) Return the current fragment set to |LayoutBox| if it is
   different from |this|, or
b) Return |nullptr|.

A case was found where there're no post-layout fragment
available. Because reading such fragments is not guaranteed
to be safe, this patch changes it to:
b) Return |nullptr| if there were no post-layout fragments.
a) Return the post-layout fragment if it is different.
c) Return |this|.

Also includes a few cleanups:
1. Support the new semantics in |PostLayoutChildLinkList|.
   It now skips fragments if there were no post-layout
   fragments.
2. Add |NGFragmentItem::PostLayoutBoxFragment|.
3. Remove |operator[]|, |front|, and |back| from
   |PostLayoutChildLinkList| because they are not used and
   do not support the post-layout concept.
4. Moved the implementation to |NGPhysicalBoxFragment|
   because it is only applicable to |NGPhysicalBoxFragment|.

Bug: 965639
Change-Id: Iaa012fc4a79204f08e00728064ea8e1b0926d6b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307770Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795340}

4079ba19

Add an optional boolean parameter in boundsForRange · 7d96ee5f

Lei Shi authored Aug 06, 2020

Current boundsForRange will clip the bounds to ancestors. This CL adds an
optional boolean parameter, clipped, to the boundsForRange method. The
default value of the parameter is true. When the clipped is set to false, the
bounds will not be clipped to the ancestors of the nodes.

This CL is a part of the fix for bug 775659.

Bug: 775659
Change-Id: I804637a2e6a8ec695dc176b88bd55d12fbc7f8a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335390
Commit-Queue: Lei Shi <leileilei@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795339}

7d96ee5f

Reland "Remove the old version of PolicyMap::Set" · f4832bba

Aya ElAttar authored Aug 06, 2020

This is a reland of 9b84489c
after fixing google_update_policy_fetcher_win.cc

Original change's description:
> Remove the old version of PolicyMap::Set
>
> 1. Removed the old version of PolicyMap::Set,
> which passes value as unique_ptr.
> 2. Changed all the remaining refs use the new
> version which passes value parameter as base::Value
> instead of unique_ptr.
>
> Bug: 1092469
> Change-Id: Ie45bb05b603cedcad8119a65134c4f5f008964dc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332191
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#795078}

Bug: 1092469
Change-Id: I4dfdf57753377ca49a6965b416e2a88c306f2ec7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339958Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Aya Elsayed <ayaelattar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795338}

f4832bba

Reland "Tab Search: Add chrome://flags entry for Tab Search" · dcf6cef1

Thomas Lukaszewicz authored Aug 06, 2020

This is a reland of 5da77d64

Original change's description:
> Tab Search: Add chrome://flags entry for Tab Search
> 
> This addition is necessary to allow users to disable the feature once
> the experiment is enabled.
> 
> Bug: 1099917
> Change-Id: I4e537a1fe92d1329c75ff8c190f92ce7f1cde8b7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336020
> Reviewed-by: Robert Liao <robliao@chromium.org>
> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#794867}

Bug: 1099917
Change-Id: I639aea54269a221d32049f98b715b4853c94f2bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339922Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795337}

dcf6cef1

Allow termina to be installed via dlc · d539d683

Fergus Dall authored Aug 06, 2020

Also refactor the current installer code out of CrostiniManager

Bug: 953544
Change-Id: Iad0850ffba616ac3f45adff63a5e21d57d3b5e7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330111
Commit-Queue: Fergus Dall <sidereal@google.com>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: David Munro <davidmunro@google.com>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795336}

d539d683

[iOS] Trigger infinite feed for Discover feed · 38b64b14

adamta authored Aug 06, 2020

When a user scrolls near the bottom of the NTP (with a variable offset),
the Discover provider function for loading the next feed's page is
called.

Bug: 1085419
Change-Id: I26c493bc588905e0018902261eb3d050291a83ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237717
Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795335}

38b64b14

Roll Perfetto Trace Processor Mac from f52572f002a6 to dcb6f8084e45 · 4807bfab

chromium-autoroll authored Aug 06, 2020

https://android.googlesource.com/platform/external/perfetto.git/+log/f52572f002a6..dcb6f8084e45

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I05710ba5140fbf4d8dda397f29c2972217e6d73c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339000Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#795334}

4807bfab

Send up supported key representations so we get host-keyed hints · 69b685d4

Sophie Chang authored Aug 06, 2020

Bug: 1110487
Change-Id: I78eab25150fd7424f06a3d9b6f244ad00e214b86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333821
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795333}

69b685d4

Roll src/third_party/libavif/src/ 01ee4caa5..50c5bbd8f (16 commits) · e5d9ec5b

Wan-Teh Chang authored Aug 06, 2020

https://chromium.googlesource.com/external/github.com/AOMediaCodec/libavif.git/+log/01ee4caa5ab5..50c5bbd8f04a

$ git log 01ee4caa5..50c5bbd8f --date=short --no-merges --format='%ad %ae %s'
2020-08-05 jdrago Minor changelog tweak
2020-08-05 jdrago Fix incorrect 16-to-8 monochrome YUV conversion
2020-08-03 kornel Make decoding optional
2020-08-03 linkmauve Add an ignoreAlpha field to avifRGBImage
2020-07-28 dnovomesky Save support in gdk-pixbuf component
2020-07-31 jdrago Update changelog
2020-07-31 jdrago Only ever create one iref box, filled with multiple cdsc boxes
2020-07-24 asn cmake: Include avif INTERFACE_INCLUDE_DIRECTORIES first
2020-07-22 asn cmake: Use correct include dir for apps/shared
2020-07-22 dnovomesky Fix a crash in the gdk-pixbuf loader, removed unnecessary asserts
2020-07-21 ccom CMake: Add -Wno-error=c11-extensions for dav1d
2020-07-19 ccom CMake: Set C standard to c99
2020-07-19 ccom CMake: Only enable CXX if using libgav1
2020-07-16 wtc Move ptrU8,ptrV8,ptrU16,ptrV16 out of i for loop
2020-07-17 linkmauve Fix a crash in the gdk-pixbuf loader when error is NULL
2020-07-19 jdrago Disable libgav1 until abseil-cpp stops using CMP0077 on newer CMake versions

Created with:
  roll-dep src/third_party/libavif/src
R=dalecurtis@chromium.org

Change-Id: I2b93528963d3a56802a40a8f788f6158e247b726
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340070
Commit-Queue: Wan-Teh Chang <wtc@google.com>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795332}

e5d9ec5b