GitLab

This virtual method is not needed.  The derived classes don't all
support this method, and indeed it is invalid for an
OfflineAudioContext because the offline context requires a time
argument.

Bug: 889694
Test: internal change
Change-Id: I9ee9aa6279693f90b4a91bfa34f3f584e5f3654d
Reviewed-on: https://chromium-review.googlesource.com/1247683Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594809}

Before this patch, the client and server protos differed in the
precondition field numbering. This resulted in fields being empty.

This patch fixes that.

After this patch, preconditions have properly populated fields after
parsing.

R=rouslan@chromium.org

Bug: 806868
Change-Id: Iec4dcfe6ad9668394a9b16b11719f185dd259e47
Reviewed-on: https://chromium-review.googlesource.com/1249208Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594808}

Using wpt-import in Chromium eea0489c.
With Chromium commits locally applied on WPT:
16f78349 "Move target-in-different-window.html into wpt/"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25392

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
mkwst@chromium.org, andypaicu@chromium.org:
  external/wpt/content-security-policy

NOAUTOREVERT=true
TBR=lukebjerring

No-Export: true
Change-Id: I774d9e8d0121856b060462ed10c7966746e395f5
Reviewed-on: https://chromium-review.googlesource.com/1249525
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594807}

Change-Id: Ia6b77632aab5df842c8878fba6fc96bf405a28de
Reviewed-on: https://chromium-review.googlesource.com/1249488Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594806}

Bug: 827288
Change-Id: Ic500608906e7c7c428e3042c5ffcf29f31899beb
Reviewed-on: https://chromium-review.googlesource.com/1207576
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594805}

This avoids a heap allocation per task run.

Change-Id: Id26fe463b29160887d29cb165426101142728550
Reviewed-on: https://chromium-review.googlesource.com/1249311
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594804}

We shouldn't DCHECK-fail for conditions that depend on external
data, which in this case involves a reply from the sync server.
Instead, let's just ignore those updates.

Bug: None
Change-Id: I4e73d5bc68685399b74eb026af6cab344e530b3e
Reviewed-on: https://chromium-review.googlesource.com/1248628Reviewed-by: Florian Uunk <feuunk@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594803}

By limiting Assistant UI size not to exceed the usable work area:

-Fix Assistant UI goes offscreen if there is not enough screen space
 left when soft keyboard is present or rotate/zoom in the display.
-Fix Assistant UI disappears off the screen to the top during resizing
 animation with soft keyboard shows.
-Fix Assistant UI container resizes to the wrong size when dismissing
 soft keyboard.

Test: local compile and manually test.
Bug: b:111444849, b:112927824
Change-Id: I4a0c641386309f857ffd8ddc2b5a73187cc807c5
Reviewed-on: https://chromium-review.googlesource.com/1226369
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594802}

The test fails because of checking browser's root window with
Shell's root window -- this is actually checking the display
for the browser window. This CL applies the same fix for
TabDragController.

BUG=883523
TEST=interactive_ui_tests --enable-features=SingleProcessMash

Change-Id: I8a53b15216c665c8c0f34ebfced0b22b97e93875
Reviewed-on: https://chromium-review.googlesource.com/1246064
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594801}

https://boringssl.googlesource.com/boringssl/+log/7f4f41fa81c03e0f8ef1ab5b3d1d566b5968f107..fb86b888ef1c1265719208fd6c27a53ceb4920f7

BUG=none

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I5f9f8df83c33c9eb3787e4385c20e0f68a0d8335
Reviewed-on: https://chromium-review.googlesource.com/1246406
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594800}

With ChromeVox enabled, queries containing cards after the first
would result in a crash during clean up of the previous response's
cards. This occurred due to failure to detach the card's NativeViewHost
before removing from the view hierarchy and destroying.

Bug: b:116173111
Change-Id: Icb115ab1d3a5afad23a897b1f5a4dae9734210ff
Reviewed-on: https://chromium-review.googlesource.com/1237973
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594799}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/99b1fae1..3ca11d72

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: If56f10f8a5e8a03c71dd5e6624f6631b865c9ad6
Reviewed-on: https://chromium-review.googlesource.com/1249526Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594798}

Add a new interface, content::mojom::NSViewBridgeFactory. This may be
used to create a content::mojo::RenderWidgetHostNSViewBridge in
another process, and initialize its client to a specified
content::mojo::RenderWidgetHostNSViewClient.
  * Note that the interface created by mojom::NSViewBridgeFactory is a
    stub interface, mojom::StubInterface, which is cast to a
    mojom::RenderWidgetHostNSViewBridge. This is because the latter
    has content-internal dependencies, and so cannot be included in
    any other module.

Add a content::NSViewBridgeFactoryHost class that will own such
a connection. There will exist one instance of this class for each
AppShimHost in the browser process.
  * Included in this a "host id". This will be set at initialization to
    match a views::BridgeFactoryHost.
  * When embedding web contents into a views::View, the
    views::BridgedNativeWidgetHostImpl will specify this id to the
    content::RenderWidgetHostViewMac, to ensure that all NSViews be
    created in the same process.

Add a content::NSViewBridgeFactoryImpl class that implements the
content::mojom::NSViewBridgeFactory interface. There will exist one
global instance of this class in each app shim process.

Add to content::RenderWidgetHostViewMac a MigrateNSViewBridge function,
which will move corresponding NSView to a different host.

Add to RenderWidgetHostNSViewBridgeLocal a constructor that takes
mojo interfaces. This constructor is called in the app shim process.
Clarify that the creator of the RenderWidgetHostNSViewBridgeLocal is
its owner, and is responsible for its destruction.

Note that all interfaces are associated. This is because call ordering
needs to be preserved amongst multiple NSViews (e.g, to add one as a
subview of another, but only once both have been put in an expected
state).

Bug: 859152
Change-Id: I69f64c57cf51189ca75e215346f3ef1cbab23094
Reviewed-on: https://chromium-review.googlesource.com/1239763Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594797}

Bug: 878390
Change-Id: I66e2329a2c94e3657b1685b6fb74f4bbc79d211e
Reviewed-on: https://chromium-review.googlesource.com/1222873
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594796}

This is consistent with how the frame rect is treated in other cases of
hit-testing (such as LayoutView::HitTestNoLifecycleUpdate). It also
eliminates the need for HitTestLocation::Intersects(const FloatRect&).
(The other "use" of this method is removed since it isn't used.)

Bug: 823796
Change-Id: I7532f0e685e9960d8afd16f9b41d699ae27bfd11
Reviewed-on: https://chromium-review.googlesource.com/1249142
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594795}

Bug: 847237
Change-Id: Ia95ec62d92a31bc5c71d53c355b6cb577acb4350
Reviewed-on: https://chromium-review.googlesource.com/1244099Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594794}

The account icon of the first sync promo account is now only
shown in the avatar toolbar when the profile is fully migrated to Dice.

Bug: 889325
Change-Id: I75dfbbc4cbf24d94e42d3b243dce15cb857066f0
Reviewed-on: https://chromium-review.googlesource.com/1249268
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594793}

Follows the spec in the PRD (linked in bug). IPH is anchored to the
security icon instead of the verbose status view for compatibility with
CCT.

I followed these instructions: //components/feature_engagement/README.md
and copied the DataSaverDetail IPH whenever possible.

Bug: 886949
Change-Id: Iff68c7d721adccc50c5a132519c9675b995a5053
Reviewed-on: https://chromium-review.googlesource.com/1234637Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594792}

Various GN conditions check target_cpu when deciding which compiler
flags to apply; they should be checking current_cpu instead so that
builds with more than one toolchain use the correct flags for each
toolchain. This was causing the DWARF version workaround for
crbug.com/744956 to not be applied on the 64-bit build when using the
32-bit toolchain.

Bug: 744956, 889937
Change-Id: Id2f4ecafd762e36ed3593fb45f6a6062bf8f6326
Reviewed-on: https://chromium-review.googlesource.com/1249393Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594791}

Bug: 889940
Change-Id: I282344fe5efa03933c86bb0a4f9d763521aebf67
Reviewed-on: https://chromium-review.googlesource.com/1249394Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Cr-Commit-Position: refs/heads/master@{#594790}

A small customization: in tablet mode, it doesn't make sense to display
a message related to a keyboard shortcut.

Bug: 887984
Change-Id: Ife9dbd11a0077b3c8001124b0224d50eac683b9c
Reviewed-on: https://chromium-review.googlesource.com/1242079Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594789}

https://pdfium.googlesource.com/pdfium.git/+log/072d829e2cd1..2b4d11c0f133


git log 072d829e2cd1..2b4d11c0f133 --date=short --no-merges --format='%ad %ae %s'
2018-09-27 thestig@chromium.org Shading functions should take const matrix pointers.


Created with:
  gclient setdep -r src/third_party/pdfium@2b4d11c0f133

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I251f92f5e74a433ad715727ca5552800c35b8a12
Reviewed-on: https://chromium-review.googlesource.com/1249327Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594788}

Switching to multi-window mode on Android and back is messing up the
Clear Browsing Data dialog on Android after the display order was changed
to move "Media Licenses" up from the bottom. Changing DialogOption to match
the order displayed.

BUG=888943
TEST=tested manually using steps in the bug

Change-Id: Iabae3c0bdaf3098a740b6709c8527b892be6aff3
Reviewed-on: https://chromium-review.googlesource.com/1246594Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594787}

Change-Id: I423a716e3716a552927676c3bc212141a10b6d20
Reviewed-on: https://chromium-review.googlesource.com/1247229Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594786}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a16c39ef89c4..74a2dc070e4e


Created with:
  gclient setdep -r src-internal@74a2dc070e4e

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I5f5b82bbc84b41dc9e8e77e73e8f887873af20bb
Reviewed-on: https://chromium-review.googlesource.com/1249328Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594785}

https://memegen.googleplex.com/5329863038205952

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I040c5f5986884cad2ca2b194a06366e8fd12255f
Reviewed-on: https://chromium-review.googlesource.com/1246420Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Commit-Queue: Nick Carter <nick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594784}

This migrates password_manager::AffiliationFetchThrottler from
NetworkChangeManager to NetworkConnectionTracker, which works with the
network service enabled.

Bug: 887058
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I04c2529e24ea0bf85ebb0646127ded2b594306c2
Reviewed-on: https://chromium-review.googlesource.com/1239359Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594783}

ScopedBlockingCall serves as a precise annotation of the scope that may/will
block for the scheduler. This CL moves ScopedBlockingCall from the call site
to the implementation of FilePathWatcher::Watch, which is more accurate.

Bug: 874080
Change-Id: I03cf5d28a2c4763c0c358699aff9f32d686b46b6
Reviewed-on: https://chromium-review.googlesource.com/1243366
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594782}

This CL removes the last-version-... pref check/update that causes
deletion of disused data to be run at most once per major version.
Instead, it will be attempted at each startup.

Bug: 881443
Change-Id: Ie6fbae3a9c29d67af28d842f02014a1274d10540
Reviewed-on: https://chromium-review.googlesource.com/1211086
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594781}

Replace the HTS Incognito Button with a toggle.

Bug: 851166
Change-Id: I5c431abb508930ee1a9a24792f2299ea08d944cf
Reviewed-on: https://chromium-review.googlesource.com/1246453Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594780}

When screen relative coordinates are passed in, do not alter
them, they are already correct.

Note: compare with results in "Better failing test" patchset 3.

Bug: 889491
Change-Id: I7618aab997f01cca20d6c712385e19beff331647
Reviewed-on: https://chromium-review.googlesource.com/1246321Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594779}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d3738be3476f..ad0232dee5f5


git log d3738be3476f..ad0232dee5f5 --date=short --no-merges --format='%ad %ae %s'
2018-09-27 33432579+alan-baker@users.noreply.github.com Unify memory instruction validation style (#1934)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@ad0232dee5f5

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I36a76977a0f6e2514f59c53d315d892313c7b454
Reviewed-on: https://chromium-review.googlesource.com/1249631Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594778}

Bug: None
Change-Id: Idc21640edb5cce41094bf564ae9e3383e202dc91
Reviewed-on: https://chromium-review.googlesource.com/1244545
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594777}

Remove the module load address parameter unused by the ModuleDatabase

Change-Id: I80a41dba4c0f33c9acb0c4d4a03934ad3b19ca54
Reviewed-on: https://chromium-review.googlesource.com/1237215Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594776}

BUG=none

Change-Id: Ia943e5bda6e3f5d3cecf9eac39e2271801295a49
Reviewed-on: https://chromium-review.googlesource.com/1249392Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594775}

This reverts commit dc8f3c0a.

Reason for revert: Casing failures
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel/2442

Original change's description:
> Android: Allow proguard to strip unused native methods.
> 
> This CL changes Monochrome APKs to allow proguard to strip out Java
> native methods that aren't used.
> 
> For APKs that use explicit JNI registration, this isn't possible since
> RegisterNatives ends up trying to load classes that are unused and
> removed by proguard.
> 
> Bug: 688465
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
> Change-Id: I6816bd68ce47e59bfc9f75dace1b34ab3c200222
> Reviewed-on: https://chromium-review.googlesource.com/1244605
> Reviewed-by: Paul Jensen <pauljensen@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Commit-Queue: Eric Stevenson <estevenson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594743}

TBR=pauljensen@chromium.org,agrieve@chromium.org,estevenson@chromium.org

Change-Id: Ic8e1f808a63c9c0fd119ee36efa1cc2b1e9a0616
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 688465
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
Reviewed-on: https://chromium-review.googlesource.com/1249825Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594774}

Disabled due to flake:
  SyntheticKeyEventTest.KeyboardEventAck

Bug: 889878
Change-Id: I3ced9177ffbc1edbcbb0381714b92b66b02b5b07
Reviewed-on: https://chromium-review.googlesource.com/1249821Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594773}

Previously, MediaCodecVideoDecoder tests tried to flush the MCVD
instance on TearDown.  Unfortunately, it didn't handle the case
where not flush was needed.  ASAN got mad about this.

This CL fixes the teardown sequence to call Reset if the test still
has an MCVD insance, and to send an EOS output buffer only if MCVD
actually started the flush without completing it.

These changes don't affect MCVD, just the tests.

Bug: 889001
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Id04afc7bbab4e0b1cde26df924573e0fed047947
Reviewed-on: https://chromium-review.googlesource.com/1244105
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594772}

Refactor this logic out of the InfobarDelegate so that it is easily
accessible in Android Java without the use of the Infobar.

This is needed so that the stale preview text can be displayed in the
page info dialog for the new Previews UI.

Also renames the related histogram pieces to generalize the naming.

Bug: 888029
Change-Id: Iaf4c8c8059c45d5ccfb408d8b831b6a322802a08
Reviewed-on: https://chromium-review.googlesource.com/1239214Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594771}

This CL uses ScopedBlockingCall to mark blocking calls in /ios/chrome/common/app_group.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=olivierrobin@chromium.org

Bug: 874080
Change-Id: I74ae6a8f94ea54ee9738a67493dc545921dc99e9
Reviewed-on: https://chromium-review.googlesource.com/1191420
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594770}