- 05 Nov, 2019 40 commits
-
-
Jinho Bang authored
The popErrorScope() was changed to reject with an OperationError if the GPUDevice is lost[1]. So, this patch matches up with the spec. Also, although the spec doesn't mention it yet, we should make it throw an OperationError for all cases where the device is lost. [1] https://github.com/gpuweb/gpuweb/pull/433 Bug: 852089 Change-Id: I3a80b5e741e1ea831fd92aa2eb3dcdafd6bc740e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898891Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#712587}
-
Kevin McNee authored
Evidenced by issue 1014385, extensions may be using the names of GuestViews for other purposes when a GuestView element is not available. In order to avoid name collisions with user code, we no longer define the error-providing elements in contexts where it is not possible to declare the necessary permission. Bug: 1014385 Change-Id: Icdf764c2bb19165cc173226e74e6f71eb7c99e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869399Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#712586}
-
Yang Guo authored
R=dgozman@chromium.org Change-Id: I4d298d596f9761cad1a19f4c0c69905df74322b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898649Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#712585}
-
Matt Menke authored
And pass the NIK to TransportConnectJob through its parameters, except when connecting to proxies. The SOCKS4 path does not yet pass in NIKs for resolving destination server hostnames, which I'll do in a followup. Bug: 997049 Change-Id: I13dae896cfbb4286c6e8107637a1b624dc800eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894469Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#712584}
-
Marc Treib authored
This can e.g. happen when credentials in the account storage become unavailable because the user signed out. This requires implementing InformNoSavedCredentials in ContentPasswordManagerDriver (previously, it was iOS-only). Bug: 1004777 Change-Id: I9f0486260f1790956e722e2b48c9593b828485f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811217 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#712583}
-
Laís Minchillo authored
Throw IllegalArgumentException from AwProxyController instead of throwing it in the support library glue. Update runBlockingFuture in WebViewChromiumRunQueue to handle ExecutionException. Bug: 1016285 Change-Id: Ic6a7903b2cfc6ca4f29e7a93ea1613434f5899da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872592 Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Auto-Submit: Laís Minchillo <laisminchillo@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#712582}
-
Mohamed Abdelhalim authored
This moves WILL_PROCESS_RESPONSE and WILL_FAIL_REQUEST states to NavigationRequest::NavigationState. Bug: 916537 Change-Id: If7c68b9edb0ca32167b73578f385e55abd939a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890054Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#712581}
-
Michael Lippautz authored
5956f2fe already stealth-fixed a problem with rehashed backing stores containing references to dead objects during Scavenge. Emitting a write barrier for such dead objects can corrupt V8's worklists. Not doing the optimization during an already running GC is the safest option. Avoiding write barriers or allocation would be other brittle options that may break in future. Bug: 1021171 Change-Id: Ib3e8b59759e13911a754830c1d20041d60b35cc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899457Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712580}
-
Vasiliy Telezhnikov authored
ThreadTicks::Now() is not available on some platforms and thus we can't measure GpuBlockedTime there. This CL skips measuring/reporting if not available to prevent DCHECK's and invalid data. Bug: 1021494 Change-Id: I8c7d7f8cdae478b0b5012a5267aa909d62da6408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899587Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#712579}
-
Andrew Grieve authored
This makes desugar put default interface methods into a base class when possible (e.g. when the implementing class does not already extend a class). It's still the case that default interface methods will sometimes be copied into every implementing class. Change-Id: Ia33ffa63d1a302f7604e9773ac44a8ca78058fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899006 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#712578}
-
Hans Wennborg authored
Bug: 1018293 Change-Id: I145996b599ea2c987e665cec5636e4aa31e5a419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898664 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#712577}
-
Saman Sami authored
Add CHECKS to the StructTraits of objects that are sent via SubmitCompositorFrame to get a better understanding of what is failing. These CHECKs are only there temporarily and will be reverted before M80's branch cut. Bug: 979564 Change-Id: I184830991ad2cfacd3f3ccb1d30e74f89f13a838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890000 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#712576}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d5a7838926b8..198345898168 git log d5a7838926b8..198345898168 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 peah@webrtc.org Revert "Reland "Correct AEC3 multichannel functionality activation"" 2019-11-05 mbonadei@webrtc.org Add 3 missing RTC_EXPORT. Created with: gclient setdep -r src/third_party/webrtc@198345898168 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Icc60a0357c7eff4a80abed6ed15ad14e4b7086e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899180Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712575}
-
Finnur Thorarinsson authored
Bring the contact, who is currently signed in, to the top. If no user is signed in, we can still synthesize a contact entry with the available information (best-effort). Note: This CL uses a blue star to mark the record that was moved/synthesized. This should be considered a placeholder. Will work with UX to flesh out how it should look like. BUG: 860467 Change-Id: I9c8a7509feac5bc38e8e60878cef9db8acb420e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876348 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#712574}
-
Mihai Sardarescu authored
This CL renames the SyncDisableObserver and its internals as UKM consent depends now on URLKeyedAnonymizedDataCollection. As this is a pure renaming CL, it does not bring any functional change. Bug: 1015805 Change-Id: I92f295dd82b54cdf66b3e8b1b073af8613a9109e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886671Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#712573}
-
Andy Paicu authored
This reverts commit 84fcf8bb. Reason for revert: This breaks the win-asan build (base_unittests) First failing build: https://ci.chromium.org/p/chromium/builders/ci/win-asan/8314 Original change's description: > Reland "[base] Introduce base::CheckedContiguousRange" > > This is a reland of 83ced150 > > Original change's description: > > [base] Introduce base::CheckedContiguousRange > > > > This change introduces base::CheckedContiguousRange, which similarly to > > base::span is a light-weight wrapper around a contiguous container > > performing bound CHECKs. > > > > However, in contrast to base::span this class keeps a pointer to the > > underlying container, and thus is able to respond to changes to data() > > and size(), which base::span can't do. > > > > Furthermore, this change provides a constexpr overload of base::data() > > for std::array and fixes a bug in CheckedContiguousIterator::operator-=. > > > > Bug: 990059 > > > > Change-Id: I3fef91c7ef7874bf495ac2ab6dbaf3a8b02dab35 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893858 > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > > Reviewed-by: Chris Palmer <palmer@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#712120} > > Bug: 990059 > Change-Id: If7cfd16ca526930643e9fac7567f58ba9ef60b1f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893069 > Reviewed-by: Chris Palmer <palmer@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712493} TBR=palmer@chromium.org,dcheng@chromium.org,jdoerrie@chromium.org Change-Id: I1ff98725f82a957067cd02ab82d3f96b2fdd3622 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 990059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899777Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712572}
-
Andreas Haas authored
With this CL we finally use v8::BackingStore as the backing store implementation of blink::ArrayBuffer. Changes: * Use v8::BackingStore as the backing store for ArrayBufferContents. * Remove ArraybufferContents::DataHolder and ArrayBufferContents::DataHandle. * Replace all uses of DataHolder in ArraybufferContents with uses of v8::BackingStore. * Replace the use of DataHandle in the V8 bindings. * Add an exception to the presubmit check to allow std::shared_ptr in ArrayBufferContents. It is contained there and does not escape. R=haraken@chromium.org, ulan@chromium.org Bug: chromium:1008840 Change-Id: Iffa31e889daf4ae54de96f55b4612833d096a884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886858 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#712571}
-
Mikel Astiz authored
This reverts commit 9d925716. Reason for revert: a deflaking attempt has landed prior to this patch, hoping that the test is no longer flaky. Original change's description: > Reland "Disable flaky ShouldKeepLocalDataOnTypeMismatch_E2ETest." > > This is a reland of c7dc2cd8 > > Original change's description: > > Disable flaky ShouldKeepLocalDataOnTypeMismatch_E2ETest. > > > > This TwoClientPreferencesSyncTestWithSelfNotifications test case is > > flaky. > > > > TBR=mastiz@chromium.org > > > > Bug: 1012688 > > Change-Id: I33f1956523be55f3f77db0560aac4c3de6721341 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859635 > > Reviewed-by: Lei Zhang <thestig@chromium.org> > > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > > Commit-Queue: Lei Zhang <thestig@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#705625} > > Bug: 1012688 > Change-Id: Idb70d277042bcb98a94130da3f2bab59ffaf0d20 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898651 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#712514} TBR=thestig@chromium.org,mastiz@chromium.org Change-Id: I9a7cd1cf5079a164285d7f6242c1ae310f7d13f3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1012688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899465Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712570}
-
Jack Davison authored
The NaCl build doesn't seem to accept the the clang flag -fdebug-info-profiling, so we need to make sure not to pass that flag to NaCl builds when clang_emit_debug_info_for_profiling = true Change-Id: Ib38f58c7a71939a9a8a124df5b6f2b798a93dab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890076Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Reviewed-by:
Johnny (Jianning) Ding <jnd@chromium.org> Commit-Queue: Jonathan Wright <jonathan.wright@arm.com> Cr-Commit-Position: refs/heads/master@{#712569}
-
Greg Thompson authored
BUG=546640 R=csharrison@chromium.org Change-Id: I8e06696bf0ccc29ab291c43528fc373d2ad18b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898656 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#712568}
-
Lei Zhang authored
On the Windows Deterministic bot, any ppapi/ changes will make this DLL non-deterministic. Suppress this for now so ppapi/ changes can land. Bug: 429358 Change-Id: I165a528a226402fb49e9126ddf221099b7cef029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899566 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#712567}
-
Christos Froussios authored
The current logging doesn't distinguish between a failed initialisation of the preferred backend and a system where there is no expected backend. Bug: 1018911 Change-Id: Id67a53261e16afa133409312745a6b97f82c9e4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897929 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#712566}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e8356ad35d3c..fb9146ffc7fc git log e8356ad35d3c..fb9146ffc7fc --date=short --no-merges --format='%ad %ae %s' 2019-11-05 mtklein@google.com merge key() and CanBuild() into CacheKey() Created with: gclient setdep -r src/third_party/skia@fb9146ffc7fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: I4a6b75c5c09650963339ef74080fd603603b265d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899181Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712565}
-
Francois Doray authored
We have observed ::GetThreadPriority returning 3 after the thread priority is set to NORMAL on Windows 7. This CL adds code to correctly map 3 to ThreadPriority::NORMAL in PlatformThread::GetCurrentThreadPriority(). From documentation, that should only happen in a REALTIME_PRIORITY_CLASS process, but since we can't get the thread and process priority atomically, we can hardly add a robust DCHECK for that. Bug: 1014659, 872820 Change-Id: If43b9d46fd766dd1d22e0efaeafe0b738ee57d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898209 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#712564}
-
Mikel Astiz authored
This includes: 1. Factoring out preference-specific logic away from the shared SyncTest class. 2. Improved failure messages for the case where engine initialization fails. 3. Rewrite the test to just test the intended behavior under test, which is about two clients having a mismatching preference type. Bug: 1012688 Change-Id: I7679a6c2b7963bdb181a35e2f327944320781896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898655 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#712563}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0262cc7eb2a2..3b1f341d0028 Created with: gclient setdep -r src-internal@3b1f341d0028 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ic614011bcc07db694d6523249918ee76ea96d518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899179Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712562}
-
Tanmoy Mollik authored
Bug: 959157 Change-Id: I8d46c9bb884ae4eb5986876cfbf290c63cd7899d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892958Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#712561}
-
Andy Paicu authored
This reverts commit 5fd0e6ed. Reason for revert: Breaks linux-chromeos-google-rel build First failing build: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/8657 Original change's description: > Fix browser test EulaTest.LoadOffline > > This commit improves the reliability of the EULA browser test > EulaTest.LoadOffline. This test was disabled due to its flakiness > in the past and is now enabled again. > > Tested locally. Ran 100 tests under stress without any errors. > > Bug: 1015948 > Change-Id: I59bc8612da9f5be526a2aa28d13ee70400dbb01e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892775 > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Commit-Queue: Renato Silva <rrsilva@google.com> > Cr-Commit-Position: refs/heads/master@{#712516} TBR=rsorokin@chromium.org,rrsilva@google.com Change-Id: I7ef72ddd859ba5689557a8b2157edd13527c0328 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1015948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899772Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712560}
-
Omer Katz authored
SameThreadCheckedMember is never used and just adds complexity to the codebase Bug: 986235 Change-Id: I3f7e870c6a6ebdfc9a312531636573c0042f4074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899620Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712559}
-
Andy Paicu authored
TBR=csharrison@chromium.org Bug: 1021511 Change-Id: Iba23b174a15abcf0dfe8c0f64431aea4a4b0e5f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899461Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712558}
-
David Roger authored
Fixed: 890321 Change-Id: I58a5f82adb70ceaf47edcc6b45c8ddd499dd357e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893258 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#712557}
-
Fredrik Söderquist authored
SVGListPropertyHelper::AdjustFromToListValues only need to know if the current animation mode is 'to' or not. Pass a bool with that information instead and avoid pulling in svg_animation_element.h. Bug: 1017723 Change-Id: Id9cfacd44b22eaf928d27ac8f1732dd9e7c43507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893205Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#712556}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=bashi@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I5a2520de651ab0f3786f4a25203ee62cc755fb0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895643 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#712555}
-
Yuki Shiino authored
Splits the contents of example.py into interface.py and several files. blink_v8_bridge.py will support Blink-V8 type and value conversions. codegen_utils.py is currently a collection of misc util functions, and should be better organized later. Bug: 839389 Change-Id: I609be076533106e4e98865add162f40f965398dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892974Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#712554}
-
Omer Katz authored
The concurrent marking tasks used to get an ids as an argument. With the new jobs api we can no longer pass the id that way. This CL updates to tasks to get an id from a collection of available ids. This way all tasks only need to get a pointer to the ThreadState (so tasks don't get unique arguments anymore). Bug: 986235 Change-Id: Ibd7146840c74297dc4531a1b4c6c1475c647464d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884850 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#712553}
-
Marc Treib authored
Before this CL, FindFormControlElementsByUniqueRendererId did many linear searches over its vector parameter |form_control_renderer_ids|, and accordingly had a DCHECK that the vector doesn't contain more than 10 elements. This CL changes the implementation to build and use a map instead for the lookups, thus avoiding the linear searches, and making FindFormControlElementsByUniqueRendererId appropriate for larger inputs. Bug: 1004777 Change-Id: I0699d87de7202f42269c3504ecf08356ee880601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899455Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#712552}
-
Omer Katz authored
Object size and mark bit reside in the same half word. Reading the size during marking causes data races. Specifically, the size is read from the write barrier and from Member's CheckPointer method. Adding an atomic version to accessing the size. This version is used by FindHeaderFromObject in the write barrier slow path and by CheckPointer in member methods other than allocation (members during allocation will not be traced yet so atomics are not needed there). Note that since the size never changed during marking (added a DCHECK to verify that incremental marking is off during size change), it is safe to read the size relaxed. Bug: 986235 Change-Id: I73019f9f9bfeb9562d4d1f29fc020a9b6f71866a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893202 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712551}
-
Fredrik Söderquist authored
SVGAnimateElement is the "most specific subclass" which uses this SVGPropertyBase interface. Bug: 1017723 Change-Id: I7537c7cfd8d07175b5aca91c98f6db2ac084ba47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893062Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#712550}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/30b5b3814199..d66586f24210 git log 30b5b3814199..d66586f24210 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 treehugger-gerrit@google.com Merge "Increase max buffer to 128mb size when uploading" Created with: gclient setdep -r src/third_party/perfetto@d66586f24210 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I6c3ca297780374995da4c222b00c9e453e9ed616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899155Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712549}
-
Andy Paicu authored
TBR=agawronska@chromium.org Bug: 1021505 Change-Id: I2138a2e645652a4fc0c1e1ff0bf2babba247b4b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899621Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712548}
-