- 27 Apr, 2018 40 commits
-
-
Siddhartha authored
Adds code to parse elf binary to get build id from .note.gnu.build-id section. The build ID is needed to symbolize heap dumps from the users. BUG=734705 Change-Id: If4365e232c060ba96071ba1e1c43618f9807e39c Reviewed-on: https://chromium-review.googlesource.com/1028995 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#554304}
-
https://skia.googlesource.com/skia.git/+log/a070ed7fccd8..414be9b332f7 $ git log a070ed7fc..414be9b33 --date=short --no-merges --format='%ad %ae %s' 2018-04-26 csmartdalton Blacklist filltypespersp on IntelHD405 vulkan 2018-04-26 benjaminwagner Revert "[recipes] Use named caches for git and workdirs" 2018-04-26 swiftshader-skia-autoroll Roll third_party/externals/swiftshader/ 840f47ea8..ce8eb945c (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: Ifc58219455e69cfc3ad537073bfa89b2c0298b54 Reviewed-on: https://chromium-review.googlesource.com/1031744Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554303}
-
Ramin Halavati authored
Traffic annotation in Feed Image Loader is updated and annotations.xml is updated based on that. Change-Id: I1a0d7a6ce1ba16a10ef2e3dd6cd72f0d47b2744f Reviewed-on: https://chromium-review.googlesource.com/1030194Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#554302}
-
Sara Kato authored
Bug: b/74415372 Test: Manually Tested Change-Id: I4e3e5a5b48054b6a7c59e2a02b38b0d200885fee Reviewed-on: https://chromium-review.googlesource.com/1009243Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#554301}
-
Jun Choi authored
Code clean-up and refactor for U2f{Request, Register, Sign} and its tests. More specifically, this CL - Moves all tests related to creating U2f{Register, Sign, BogusRegistration}Command to uf_command_constructor_unittest.cc - Moves all tests related to parsing/serializing responses to ctap_response_unittest.cc This refactoring is prepares for migration of U2f{Register, Sign} to U2f{Register, Sign}Operation. Bug: 798573 Change-Id: I24ab0a2c5796571b9ff06fe062e5823ed779c725 Reviewed-on: https://chromium-review.googlesource.com/1024868 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#554300}
-
braveyao authored
In a recent CL, https://chromium-review.googlesource.com/c/chromium/src/+/681850, MesasgePumpDefault is used for MessageLoop::TYPE_DEFAULT on OSX. This requests the desktopCaptureThread to be adjusted to run as a UI thread, otherwise the CFRunLoop won't run again after display resolution changes. Bug: 836978 Change-Id: Ifb460f19dca4741359d93bb73e280404d62c5a05 Reviewed-on: https://chromium-review.googlesource.com/1029113Reviewed-by:
Zijie He <zijiehe@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#554299}
-
Yoshifumi Inoue authored
This patch makes |{Start,End}{Offset,Position}InCurrentContainer()| in |TextIteratorInFlatTree| to work correctly with non-text nodes, e.g. image alt text, leading whitespace, etc., by computing parent and child index in |TextIteratorAlgorithm<Stargety>| instead of |TextIteratorTextState|. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/1029393 Make TextIteratorTextState to represent relative position explicitly Change-Id: Ibf87419a0bc06b987ee4f3aafee1b2e5151fac52 Reviewed-on: https://chromium-review.googlesource.com/1029561 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#554298}
-
Aaron Leventhal authored
When the accessibility object for a View is ignored, it is not getting ignored by NVDA's virtual buffer. It is not enough to give it a role of client and make it invisible -- it also need to be nameless. Bug: 820350 Change-Id: I388b19ae65f1f5bf02ed6135936f0b75e2a153f8 Reviewed-on: https://chromium-review.googlesource.com/1031130 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#554297}
-
Timothy Loh authored
This reverts commit 90d40910. Reason for revert: Landed at the same time as https://chromium-review.googlesource.com/c/chromium/src/+/1013824 which used the old function. Original change's description: > Avoid creating Crostini UI objects on guest and ephemeral profiles > > As Crostini is not supported on guest and ephemeral profiles, we change > IsExperimentalCrostiniUIEnabled() into IsCrostiniUIAllowedForProfile() > so we can avoid creating the various controllers and builders. This > makes us less likely to assume a CrostiniRegistryService exists when > one actually doesn't. > > Bug: 836187 > Change-Id: I5a65ad250edcb16daf381dfd77d7a5df0a1de98f > Reviewed-on: https://chromium-review.googlesource.com/1029934 > Commit-Queue: Timothy Loh <timloh@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554294} TBR=xiyuan@chromium.org,timloh@chromium.org Change-Id: I76a977c63aaffdf4de5cc54c8cb02d9a345f2e43 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836187 Reviewed-on: https://chromium-review.googlesource.com/1031993Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#554296}
-
Victor Costan authored
Bug: 829893 Change-Id: I757a4a7f6d633f530e95de9d4d7a36c3e27ea14d Reviewed-on: https://chromium-review.googlesource.com/999747Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#554295}
-
Timothy Loh authored
As Crostini is not supported on guest and ephemeral profiles, we change IsExperimentalCrostiniUIEnabled() into IsCrostiniUIAllowedForProfile() so we can avoid creating the various controllers and builders. This makes us less likely to assume a CrostiniRegistryService exists when one actually doesn't. Bug: 836187 Change-Id: I5a65ad250edcb16daf381dfd77d7a5df0a1de98f Reviewed-on: https://chromium-review.googlesource.com/1029934 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#554294}
-
Sam McNally authored
This reverts commit 50b44e68. Reason for revert: Breaks NaCl on win7 32 bit: https://ci.chromium.org/buildbot/chromium.win/Win7%20%2832%29%20Tests/32881 Original change's description: > Reland "win: Link with lld instead of MSVC's link.exe by default" > > This is a reland of be8138a4 > > The issues with the first attempt were addressed in the latest > Clang roll (#553415). ASan is excluded from using lld until > the fix for crbug.com/837090 is rolled into Chromium. > > Original change's description: > > win: Link with lld instead of MSVC's link.exe by default > > > > lld is LLVM's linker. It produces PE/COFF and PDB files just like > > link.exe, but it's significantly faster and it can also handle LLVM's > > internal representation, which will enable us to do link-time > > optimization and control-flow integraty checks with Clang. > > > > While lld is much faster at linking, it doesn't support incremental > > links, meaning builds that only touch a few files and re-link a large > > executable may become slower. > > > > This is the first attempt at switching everything over, with the > > purpose of gathering data and finding unknown unknowns. It's likely > > temporary until something breaks. > > > > is_win_fastlink is implicitly ignored when using lld, as lld without > > fastlink is faster than link.exe with it. > > > > Also switch the CrWinClangLLD bots on chromium.clang to use MSVC's > > link.exe to make sure that configuration keeps working. > > > > Bug: 792131 > > Change-Id: I0f115a78c33d69eadbd480f75c2a5d636e86483d > > Reviewed-on: https://chromium-review.googlesource.com/983632 > > Commit-Queue: Nico Weber <thakis@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#551367} > > Bug: 792131 > Change-Id: I85ad51904884734156a4e06859fd1ba08e519a3b > Reviewed-on: https://chromium-review.googlesource.com/1031330 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554239} TBR=thakis@chromium.org,hans@chromium.org Change-Id: I1e873015f928603909b744e857efa1f5a44c2ba0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 792131 Reviewed-on: https://chromium-review.googlesource.com/1032010Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#554293}
-
Renee Wright authored
Adds a SettingsPageUIHandler subclass called CrostiniHandler which - launches the CrostiniInstallerView when requested by settings - destroys a Crostini VM/Container when requested by settings This code doesn't really do anything yet, because it relies on Settings UI to send requests. Settings UI section for Crostini is added in the next CL. Bug: 833125 Change-Id: I556077e50979d39a887629d9d5f5aa748166f193 Reviewed-on: https://chromium-review.googlesource.com/1013824 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#554292}
-
Takuto Ikuta authored
I applied modernize-use-override in blink http://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html Bug: 428099 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If7c2dd539d1c0920310c357dd1014a2c6758ffd1 Reviewed-on: https://chromium-review.googlesource.com/1029592Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#554291}
-
John Budorick authored
Bug: 731436,805257 Change-Id: I9fe022c27489a82a306eccb7359f9af30553cbbb Reviewed-on: https://chromium-review.googlesource.com/1031891Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#554290}
-
https://chromium.googlesource.com/catapult.git/+log/846cec5c4d22..82069c8b6ea2 $ git log 846cec5c4..82069c8b6 --date=short --no-merges --format='%ad %ae %s' 2018-04-26 dtu [dashboard] Make api_auth.Authorize() not a decorator. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ie72a8c8523a99ebc5b456bf54fddfd98a346b396 Reviewed-on: https://chromium-review.googlesource.com/1031748 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554289}
-
danakj authored
Replace them with gfx geometry types. Add a FloatPoint -> gfx::PointF conversion operator to assist with this. Also add an IntSize -> gfx::Vector2d conversion operator, and make both it and the gfx::Size conversions explicit, so that users must be cognizant they are making a choice. DCHECK in the gfx::Size conversion that the values are not negative for now (we may want to just clamp silently in the future once we have a use case for it?). R=pdr@chromium.org Bug: 738465 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I9daee692287744780878fcc294f8e054dc222a5a Reviewed-on: https://chromium-review.googlesource.com/1031205 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#554288}
-
Kent Tamura authored
We added their replacements to third_party/blink/tools, and we have no code refers to them in third_party/WebKit. Bug: 829697 Change-Id: I096512bc323cb5f16d771a1319c7581a22732e2a Reviewed-on: https://chromium-review.googlesource.com/1029566Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#554287}
-
Fergal Daly authored
Bug: 805271 Change-Id: I09e58d9368e02e8fd41c139440381722def67509 Reviewed-on: https://chromium-review.googlesource.com/1031750Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#554286}
-
Eric Seckler authored
When setting the bounds of a WebContents, we shouldn't also change the browser window size to the size of the WebContents. This can lead to the bounds of the WebContents lying outside the browser's window, in which case screenshots will hang. Instead, make sure that all WebContents are contained within the browser window size. Bug: 832138 Change-Id: Iaeb8b36b4edceedfdf2fdd1d54c3765587c79ea7 Reviewed-on: https://chromium-review.googlesource.com/1031655Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#554285}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I0b31cdad969298c0670967616359dd617b495e3a Reviewed-on: https://chromium-review.googlesource.com/1031930Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#554284}
-
https://pdfium.googlesource.com/pdfium.git/+log/52ab95aa3edb..575f238334d1 $ git log 52ab95aa3..575f23833 --date=short --no-merges --format='%ad %ae %s' 2018-04-27 thestig Roll DEPS for ICU to e4194dc7 2018-04-27 thestig Roll DEPS for build and buildtools. 2018-04-27 thestig Roll DEPS for Clang to abe5e4f9. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I660bb977218555c30ffab32c41235e497b6919ab Reviewed-on: https://chromium-review.googlesource.com/1031782 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554283}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 244bd88b. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" 7c13f644 "Subtract scrollbar in PerpendicularContainingBlockLogicalHeight" a8385691 "Make web font timeouts work for preloaded fonts" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16282 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=foolip No-Export: true Change-Id: If5c54f1f79e8b3ffa920fe424b3f00ae4fa0a308 Reviewed-on: https://chromium-review.googlesource.com/1031400 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#554282}
-
Xianzhu Wang authored
We use ScopedPaintChunkProperties anywhere when there might be a property change, but don't expect new chunks if the properties are the same as the current. Previously we created new chunks if the id changes which added many chunks with the same properties which unnecessarily increased the load of CompositedLayerRasterInvalidator and PaintChunksToCcLayer. https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20180425154628/html/index.html shows great results: - painter_memory_usage: -16.5% - record_time_subsequence_caching_disabled: -4% - record_time: -1.2% Drawbacks: It combines some previously separated paint chunks together, so full chunk invalidations are now issued on the combined chunk, and the bounds may cover more area than the previously separated chunks. Another drawback is about appeared or disappeared chunks that now may also occur on bigger chunks. Consider the big benefits, it's a good trace-off for the drawbacks (shown in about 10 layout tests). Bug: 803867 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iba541b24bb4ad92c112acf980d96a6ef4d186880 Reviewed-on: https://chromium-review.googlesource.com/1027209 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
This is a preparation CL for the off-main-thread WebSocket. After this CL, DedicatedWorkerHost is created from RenderFrameHostImpl, not from RendererInterfaceBinders, so that DedicatedWorkerHost can get its parent frame's id. This may not work for nested workers, but probably we can add an interface for creating DedicatedWorkerHost to DedicatedWorkerHost for that case. <Motivation> DedicatedWorkerHost needs to know the parent frame id in order to share a user decision on the SSL certificate warning interstitial among the parent document and dedicated workers. When the off-main-thread WebSocket is disabled, the decision is naturally shared among them because the dedicated workers depend on their parent document's loader. Once the off-main-thread WebSocket is enabled, the dedicated workers need to annotate requests as permitted using their parent frame's id. <Notes> This CL renames private WebSocketManager::CreateWebSocket() overloaded by public CreateWebSocket() to DoCreateWebSocketInternal() because the overload makes base::BindRepeating() confused. Bug: 825740 Change-Id: I9c2b07bea60cce315b94a4776b1d163e4330a208 Reviewed-on: https://chromium-review.googlesource.com/1025497Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#554280}
-
Daniel Cheng authored
Previously, the plugin completely skipped virtual specifier checks on Gmock objects since it wasn't smart enough to filter out warnings caused by Gmock macros. In preparation for making the plugin smarter, this CL fixes existing virtual specifier warnings in //cc. R=enne@chromium.org Bug: 837148 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If5a2518598d97444695e70bfd7b2777ffbd838b1 Reviewed-on: https://chromium-review.googlesource.com/1030960Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#554279}
-
Luciano Pacheco authored
This enforces the exact text that will be read by Chromevox, before this patch it was reading the whole text content from the element which was getting duplicated text. The attribute aria-labelledby is a list of ids of elements whose whose content is used as label by screen reader/Chromevox. For list view it adds the |id| of 3 columns: entry-name, size and modified date. For grid view it only adds the |id| of entry-name. See crbug.com/762748 for screenshots of this change. Bug: 762748 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I58414b4d3115e9854e7599a74da70a5e56060aa4 Reviewed-on: https://chromium-review.googlesource.com/1023501Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#554278}
-
Daniel Cheng authored
Previously, the plugin completely skipped virtual specifier checks on Gmock objects since it wasn't smart enough to filter out warnings caused by Gmock macros. In preparation for making the plugin smarter, this CL fixes existing virtual specifier warnings in //gpu. R=piman@chromium.org Bug: 837148 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ica08fb44c7c548c3467d96b13888b4ce87956350 Reviewed-on: https://chromium-review.googlesource.com/1031191Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#554277}
-
Xu Xing authored
BUG=644851 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I0b8e91c23d022c54121c656b37abec1732a7765b Reviewed-on: https://chromium-review.googlesource.com/1023790Reviewed-by:
-
Jinsuk Kim authored
The two classes below are used by WebView only and don't have to be in content layer. Bug: 617324 Change-Id: I6962bb81dd67953711017d3ebabd74996693cb21 Reviewed-on: https://chromium-review.googlesource.com/1029756Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#554275}
-
Daniel Cheng authored
Previously, the plugin completely skipped virtual specifier checks on Gmock objects since it wasn't smart enough to filter out warnings caused by Gmock macros. In preparation for making the plugin smarter, this CL fixes existing virtual specifier warnings in //jingle. This CL was uploaded by git cl split. R=zea@chromium.org Bug: 837148 Change-Id: I0e7f4a597b80536b61e094fcf3c30b4003c69a9c Reviewed-on: https://chromium-review.googlesource.com/1031187Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#554274}
-
Patti authored
Features provide more flexibility by having a default state, so switch to using a feature for launching via waterfall when Site settings / All sites is complete. Bug: 835712 Change-Id: I9c21477f791420582ea896ccb89eae2c04e24a9c Reviewed-on: https://chromium-review.googlesource.com/1023076 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#554273}
-
Yutaka Hirano authored
We're considering removing some WebRequest API functionalities from WebSocket to support Network Service. This CL adds histograms to measure whether such features are actually used. Bug: 721400 Change-Id: If59ee6b0a0103a06a3a4dc70c57ba756c4a2c751 Reviewed-on: https://chromium-review.googlesource.com/1027670Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#554272}
-
Fergal Daly authored
Change ApplyMap to just queue mappings and only actually apply them if Contains is called. Bug: 805271 Change-Id: I4fd9b0463e125f985c8ba95aa46773711a0013f0 Reviewed-on: https://chromium-review.googlesource.com/1029550 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#554271}
-
Joel Einbinder authored
Previously properties were shown from every prototype of the object, regardless of whether or not they were overridden by a higher properity prototype. This could be confusing with for example '[].leng' which showed length twice. Change-Id: I7cee5b18a62d542bbf4562510c4c461afc59da60 Reviewed-on: https://chromium-review.googlesource.com/1026698 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#554270}
-
Jeffrey Kardatzke authored
This covers the case for the examples of xterm & uxterm where their window_app_id was org.chromium.termain.wmclass.[U]XTerm but the desktop file is debian-[u]xterm.desktop and the unlocalized name is [U]XTerm. Bug: 819444 Test: Unit tests pass, verified xterm & uxterm show up on shelf Change-Id: I3c86d82085450a769f36617b21df7fe73ca27a2a Reviewed-on: https://chromium-review.googlesource.com/1031527Reviewed-by:
-
Dave Schuyler authored
This CL copies code from omnibox_result_view.* to respective omnibox_match_cell_view.* files. Along the way, OmniboxSuggestionView is renamed as OmniboxMatchCellView. Also, the unused functions OmniboxResultView::AddOmniboxImageView and OmniboxResultView::AddOmniboxTextView were removed. There's no functional changes in this CL. It's a code-health change. Bug: None Change-Id: I1ca94747126cdd36e0f1c5de726178807e7697e2 Reviewed-on: https://chromium-review.googlesource.com/1029411 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#554268}
-
Lei Zhang authored
This reverts commit d2ca40e5. Reason for revert: Broke the build. https://ci.chromium.org/buildbot/chromium/Linux%20x64/63245 Original change's description: > Prevent implicit cast from 0 to StructPtr<T>. > > Change-Id: Ibe9f789de8af9717b7d9a8d1f82f024acb04d504 > Reviewed-on: https://chromium-review.googlesource.com/935753 > Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554262} TBR=dcheng@chromium.org,thakis@chromium.org,rockot@chromium.org,lukasza@chromium.org Change-Id: I10463286039ad52b501c7b7a2399d956792ccf0a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1031254Reviewed-by:
-
Daniel Cheng authored
Previously, the plugin completely skipped virtual specifier checks on Gmock objects since it wasn't smart enough to filter out warnings caused by Gmock macros. In preparation for making the plugin smarter, this CL fixes existing virtual specifier warnings in //content. R=kinuko@chromium.org Bug: 837148 Change-Id: Ic509a56551e78539f0c46daddad3509ef9cea908 Reviewed-on: https://chromium-review.googlesource.com/1030959Reviewed-by:
-
Daniel Cheng authored
Previously, the plugin completely skipped virtual specifier checks on Gmock objects since it wasn't smart enough to filter out warnings caused by Gmock macros. In preparation for making the plugin smarter, this CL fixes existing virtual specifier warnings in //dbus. This CL was uploaded by git cl split. R=stevenjb@chromium.org Bug: 837148 Change-Id: I2af67226ab01879be81437c2bcf6a2e5e6002987 Reviewed-on: https://chromium-review.googlesource.com/1031184Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#554265}
-
