GitLab

BUG=123244

Review URL: https://chromiumcodereview.appspot.com/10082025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132302 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sail@chromium.org
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10083017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132301 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10007039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132300 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:29052
TEST=GDataFileSystemTest.ChangeFeed_*

Review URL: https://chromiumcodereview.appspot.com/10006023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132299 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123311
TEST=sadrul@chromium.org


Review URL: http://codereview.chromium.org/10082008

TBR=oshima@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132298 0039d316-1c4b-4281-b951-d872f2087c98

Some notification clients expect URLs while others expect URLRows but in some cases the URLRows were not being provided. Eliminated the duplication of data structures by removing the set of URLs and relying only on the vector of URLRows.

tim@ for OWNERS review of sync/...

BUG=122740
TEST=Added unit test.
TBR=tim@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10031028

TBR=mrossetti@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10086021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132297 0039d316-1c4b-4281-b951-d872f2087c98

Docked panels can be resized from all edges except the bottom.
Jianli will create a separate patch for Windows docked Panels.

This patch depends on http://codereview.chromium.org/10020057/ landing first.

BUG=None
TEST=Updated plus manual verification of resizing docked panels.

Review URL: http://codereview.chromium.org/10066032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132296 0039d316-1c4b-4281-b951-d872f2087c98

Don't register more than one 'connect' event handler per HostTableEntry. Don't create more than one HostTableEntry for the daemon UI.

BUG=121509
TEST=Manual

Review URL: https://chromiumcodereview.appspot.com/10081027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132295 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123311
TEST=sadrul@chromium.org


Review URL: http://codereview.chromium.org/10082008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132294 0039d316-1c4b-4281-b951-d872f2087c98

I forgot to make that change in my in-progress CL r131178 after migrating the
CookieTreeModel to use weak ptrs in r130767.

BUG=123393
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10073022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132293 0039d316-1c4b-4281-b951-d872f2087c98

The AppLauncherHandler class is not used on Android and has several
dependencies to the Browser object which is also not available on Android.
So excluding them on Android.

BUG=None
TEST=unit_tests on Android should not report AppLaucherHandler symbols missing
     when compiled.


Review URL: http://codereview.chromium.org/10031052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132292 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123205
TEST=This is a test


Review URL: http://codereview.chromium.org/10038027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132291 0039d316-1c4b-4281-b951-d872f2087c98

Remove a dcheck I just added since I apparently don't understand the various circumstances that result in this function being called.

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10084027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132290 0039d316-1c4b-4281-b951-d872f2087c98

Make sure the Extension copies in the renderers have the active permissions and not just those defined in the manifest.

BUG=123250
TEST=ExtensionApiTest.ContentScriptPermissionsApi


Review URL: http://codereview.chromium.org/10073011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132289 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132288 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r8250: (jvoung) Also make unsandboxed translator not link in pepper shims for SPEC.
r8251: (bradchen) Partially support running 32-bit glibc tests.
r8252: (jvoung) Remove workaround for __LITTLE_ENDIAN__ now that clang defines it for le32.
r8253: (ncbray) Remove experimental approach for supporting ChromeOS builds.
r8254: (mseaborn) dyncode: Remove some uncalled functions in dynamic_modify_test.c
r8255: (bbudge) Update Chrome revision in NaCl DEPS.
r8257: (mseaborn) Remove tools/modular-build, since it is not used any more
r8258: (jvoung) Update perf expectations for 252.eon transfer size.
r8259: (thakis) Delete run_sigpipe_test.
r8260: (thakis) Fix a typo in validator_x86_32.gyp
r8261: (dschuff) emit testsuite failure results in a format understood by buildbot error extension
r8262: (bradchen) Add a test for sincos and sincosf.
*r8263: (mseaborn) Move the Windows Cygwin x86-32 binutils assembler into deps/third_party
r8264: (mseaborn) NaClAppThread: Remove misleading comment

* This involves adding gnu_binutils to DEPS, since it's not longer under native_client.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=2704
TEST=nacl_integration

Review URL: https://chromiumcodereview.appspot.com/10086013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132286 0039d316-1c4b-4281-b951-d872f2087c98

This also adds some cleanup in the Pepper API to provide typedefs for the three PPP_* functions. I removed some ad-hoc typedefes we had floating around and replaced them with these more "official" ones.

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10069035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132285 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132284 0039d316-1c4b-4281-b951-d872f2087c98

There was a crash when disconnecting from a machine via Windows RDP.  RDP injects client machine printers into the host machine.  GetPrinterCapsAndDefaults blocks on these printers.  When the user disconnects, the printer is deleted and then GetPrinterCapsAndDefaults returns.  The failure handler fires and attempts to access the now-freed PrinterJobHandler that was passed with the callback resulting in a crash.

The solution is to pass a WeakPtr to the callback so that if the PrinterJobHandler is destroyed the
callback wont fire.

BUG=122996
TEST=Verify bug.


Review URL: http://codereview.chromium.org/10079017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132283 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10053019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132282 0039d316-1c4b-4281-b951-d872f2087c98

- Ability for WebContents to be replaced.
- Various focus/destruction observers.
- Hook up to BrowserView, replacing TabContentsContainer.

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10073014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132281 0039d316-1c4b-4281-b951-d872f2087c98

Eliminate three instances of them, and DCHECK on the condition for the future.

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10003005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132280 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10079021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132279 0039d316-1c4b-4281-b951-d872f2087c98

used by this test for sections and import dlls, needed to be changed. These values
are different for X86 and X64.

BUG=123096
R=cpu
Review URL: https://chromiumcodereview.appspot.com/10083011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132278 0039d316-1c4b-4281-b951-d872f2087c98

Show actual results for accessibility dump render tree tests as well. Showing a * in front of incorrect expected lines is not enough. We need to see what the actual results were as well.


BUG=120934
TEST=This is a fix for tests


Review URL: http://codereview.chromium.org/10008081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132277 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123402

Review URL: https://chromiumcodereview.appspot.com/10073021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132276 0039d316-1c4b-4281-b951-d872f2087c98

wrench_menu_model. Chromeos no longer diverges that much from current.

BUG=123233
TEST=make sure menu layout is right.
R=saintlou@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10038033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132275 0039d316-1c4b-4281-b951-d872f2087c98

This archive contains all the files that need to be signed or are
required to build the Me2Me host installer.

Currently only setup for Mac. Other platforms either don't need this (Linux)
or are much simpler (Windows).

BUG=122228
Test=None
Review URL: https://chromiumcodereview.appspot.com/10071027

TBR=garykac@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10083012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132273 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132272 0039d316-1c4b-4281-b951-d872f2087c98

TBR=toyoshim@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10086010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132271 0039d316-1c4b-4281-b951-d872f2087c98

This archive contains all the files that need to be signed or are
required to build the Me2Me host installer.

Currently only setup for Mac. Other platforms either don't need this (Linux)
or are much simpler (Windows).

BUG=122228
Test=None
Review URL: https://chromiumcodereview.appspot.com/10071027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132270 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/9960083

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132269 0039d316-1c4b-4281-b951-d872f2087c98

Some notification clients expect URLs while others expect URLRows but in some cases the URLRows were not being provided. Eliminated the duplication of data structures by removing the set of URLs and relying only on the vector of URLRows.

tim@ for OWNERS review of sync/...

BUG=122740
TEST=Added unit test.
TBR=tim@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10031028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132268 0039d316-1c4b-4281-b951-d872f2087c98

This refactors the triggering of accessibility mode from a boolean state and
command-line flag to an AccessibilityMode enum that's passed directly
when a new RenderView is created, which is also more readable and avoids the
extra command-line flag.

Adds a new mode that only syncs editable text nodes, and enables this on
Windows 8 so that we can support showing the virtual keyboard when an
editable text field gets focus.

BUG=122061,118641
TEST=Adds new test


Review URL: http://codereview.chromium.org/9939011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132267 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10051022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132266 0039d316-1c4b-4281-b951-d872f2087c98

the margin leaves space so that the menu isn't abutting the edge of the viewport, and is more aligned with the arrow on the button below

BUG=112486
TEST=none


Review URL: http://codereview.chromium.org/10037022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132265 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122187
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10079006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132262 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122933
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10086005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132261 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122450
TEST=Verify fix for issue 122450.


Review URL: http://codereview.chromium.org/10071026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132260 0039d316-1c4b-4281-b951-d872f2087c98

The search tab of chrome://sync would previously perform a string search
of a select set of fields.  This change modifies the search behaviour to
instead perform a regex match against a serialized version of the node.

Part of this change is to move the searching function out of C++ and
into JavaScript.  When a search is performed, all nodes are loaded from
the database, marshalled, and sent over the fence to the JavaScript side
of things.  This comes with a significant performance cost, but it's not
much worse than a search matching all nodes would have been under the
old system.

While there was no such thing as an invalid search string under the
old system, it is possible to enter an invalid regex.  This change adds
some logic to alert the user if their search query is not a valid regex
(ie. if it ends with a backslash).

In order to make it easier to formulate queries, the way we display
results has been changed.  The right pane will now display the
serialization of the raw node (which exactly reflects the text that was
searched) rather than the "details" used in the old system.  This new
format is a subset of the old, and corresponds to the dictionary value
found under "entry" in the old display.

Finally, this change removes support for some JavaScript calls that are
no longer used.

This change fixes JavaScript style-checker issues in the files that it
touches.

BUG=104574, 122021
TEST=

Review URL: http://codereview.chromium.org/9836100

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132259 0039d316-1c4b-4281-b951-d872f2087c98