GitLab

NOTRY=true  # tests are covered by PRESUBMIT only

Bug: 825181
Change-Id: I59ee1dc37b86d5100881c11789bbef2076b113ad
Reviewed-on: https://chromium-review.googlesource.com/995578Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#548062}

KeyboardCommandsTestCase:
- Updates the recent tabs test now that recent tabs is always presented
  and never contained.
- Updates the recent tabs test because the a11y ID of the "Done" button
  is different when the UIRefresh flag is enabled.

RecentTabsTableTestCase:
- Properly nils out the mediator after it is disconnected.  This
  prevents a crash when launching recent tabs a second time.

BUG=825431

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib97c1536083fae82dcc523c8ea2787c74f92469b
Reviewed-on: https://chromium-review.googlesource.com/995617Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548061}

This was discovered in
https://chromium-review.googlesource.com/c/chromium/src/+/980757 by
letting assert_throws also check that the message matches. That change
itself isn't a good idea, but it's still just as well to use plain
TypeErrors here to not make it seems like more is being tested than in
fact is.

Change-Id: I8f964e9b25cc94942cb86f3ee0017530f230e04a
Reviewed-on: https://chromium-review.googlesource.com/995192Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548060}

SIGSYS is grabbed by the system seccomp filter trap, and SIGSEGV is
grabbed by libsigchain. Both of these need to have their default signal
actions so that the sandbox test framework can interpret process death
accurately.

Cq-Include-Trybots: master.tryserver.chromium.android:android_arm64_dbg_recipe;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg
Change-Id: I3879f83bd16d1a71df389fe25d52bb68baacf596
Reviewed-on: https://chromium-review.googlesource.com/984516Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548059}

https://chromium.googlesource.com/catapult.git/+log/e13394ffef36..23d04ac91acd

$ git log e13394ffe..23d04ac91 --date=short --no-merges --format='%ad %ae %s'
2018-04-04 eyaich Updating artifact paths to cloud storage paths.

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:772208


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I1c69b0313e48b5156a93b78e3e562cf4ecddbeec
Reviewed-on: https://chromium-review.googlesource.com/995579Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#548058}

It passes locally and flakiness dashboard shows it's been passing for as
far as the results go.

Bug: 711529
TBR: kinuko
Change-Id: Ia9c75b49639c752d9d92ccbf0ee10c4cf0b3c37a
Reviewed-on: https://chromium-review.googlesource.com/995752Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548057}

The statement copied from the original code would be

size_t size = size();

but that does not compile since size now refers to the variable size_t size.

I mistakenly replaced size() with data_->size() forgetting that data_ could be nullptr.

The correct fix was to use this->size() which includes a check for nullptr.

Add a test that would have caught this.

Bug: 828740
Change-Id: I57a396d968a1a8e947bb9fdb0b7d232494c6d5d5
Reviewed-on: https://chromium-review.googlesource.com/995592Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548056}

Turns out downstream sdk tools is too old and doesn't have the tool.

Change-Id: I4a08d1658854647f473923263137530c7910deba
Reviewed-on: https://chromium-review.googlesource.com/995583Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548055}

A new switch is add to traffic annotation auditor's call to clang tool,
to ignore uknown switches and do not stop on them. This is done as a
quick fix to reactivate traffic annotation auditor's tests and will be
updated to a more presistant approach after discussing with clang team.

Bug: 690323
Change-Id: If350a83b2d70003a2600f9ad84d774a049a9f532
Reviewed-on: https://chromium-review.googlesource.com/995132Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548054}

This reverts commit 523c07e8.

Reason for revert: SettingsAccessibilityTest.MANAGE_ACCESSIBILITY_aria_valid_attr_value is Flaky.

Original change's description:
> Add tests for accessibility pages in Chrome / Chrome OS settings.
> 
> Bug: 823359
> Change-Id: I62707b079f9ee899feb7c624a498c5f16f6fe061
> Reviewed-on: https://chromium-review.googlesource.com/988226
> Reviewed-by: Hector Carmona <hcarmona@chromium.org>
> Commit-Queue: Katie Dektar <katie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#547747}

TBR=hcarmona@chromium.org,katie@chromium.org

Change-Id: I4c26092b8c2be2ee2a041a5ac420b57fe5b72a60
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 823359
Reviewed-on: https://chromium-review.googlesource.com/995553Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548053}

This reverts commit 755a9214.

Reason for revert: Mid-flight collision with 162e9dda47d694596620b69c5fb23cc7f0f87126 - will update and reland.

Original change's description:
> Serialize 'oblique' computed values for 'font-style'
> 
> Handling of 'oblique' values were missing in
> ComputedStyleUtils::ValueForFontStyle - serialize as 'oblique <angle>'.
> Because of this the return value needs to be widened to CSSValue.
> 
> Bug: 809935, 809938
> Change-Id: I1de846595ed955455d57ab9f6ea45326e502a65b
> Reviewed-on: https://chromium-review.googlesource.com/995273
> Reviewed-by: Dominik Röttsches <drott@chromium.org>
> Commit-Queue: Fredrik Söderquist <fs@opera.com>
> Cr-Commit-Position: refs/heads/master@{#548044}

TBR=fs@opera.com,drott@chromium.org,futhark@chromium.org

Change-Id: I379a152245f16fc792c8bfc55a2d8b127ba30820
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 809935, 809938
Reviewed-on: https://chromium-review.googlesource.com/995695Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#548052}

Add an EnabledStateMonitor to monitor changes to contextualsuggestions
enabled state. Currently the only monitored state is whether sync
upload to Google is active.

Also updates the FeatureUtilities check to account for the search engine
promo.

BUG=823987

Change-Id: I9b4ae44ae94e73ef5c7e43cbfe6aebf657f4ada0
Reviewed-on: https://chromium-review.googlesource.com/988343Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548051}

Change-Id: Iaa6b4ef193e738164b71de06125e8befa0e0d13d
Reviewed-on: https://chromium-review.googlesource.com/995456Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548050}

The convention is to use ASSERTs for preconditions to the actual test,
so let's do that.

Bug: none
Change-Id: I8580438b70669adda6507192f226e96231a1ccf7
Reviewed-on: https://chromium-review.googlesource.com/995436Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548049}

This CL converts callbacks in AsyncFileUtil, and updates its implementation
for that.

Change-Id: I23add041947af91d31a7d65d96654a3884581ad8
Reviewed-on: https://chromium-review.googlesource.com/985343Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548048}

Short term solution to long term problem of pulling the NTP out of native content.
For now, convince //ios/web to show the NTP native content as full screen (including
under the status bar) by sending a negative offset to web when calculating the frame
of the native content.

Bug: 819460
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia4d2417aafad0afbc5dd62ffbcd35156deb3f8ad
Reviewed-on: https://chromium-review.googlesource.com/981233Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548047}

The snapshots get very tiny if many resizes happen during tracing so
turn off auto throttling.

Bug: 813929
Change-Id: Iceb5f66a7c951bc5e02b2e29b7cb43cccd80bc10
Reviewed-on: https://chromium-review.googlesource.com/980584Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548046}

The presubmit check _CheckUniquePtr guards against calling
std::unique_ptr constructor directly, instead directing code authors to
use std::make_unique.

This check currently fails to match multiline expressions. While it
catches
bar = std::unique_ptr<T>(foo);
it does not catch
bar =
    std::unique_ptr<T>(foo);
nor does it catch
bar = std::unique_ptr<T>(
    foo);

This CL fixes it by extending the match pattern to catch all lines with
the substring "std::unique_ptr<T>(". (But not those with
"std::unique_ptr<T>()", which should be handled by the "nullptr-check".)

Bug: 827961
Change-Id: I376b5e9811418205e294e97de0b6b7bcbf6891d2
Reviewed-on: https://chromium-review.googlesource.com/989735
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548045}

Handling of 'oblique' values were missing in
ComputedStyleUtils::ValueForFontStyle - serialize as 'oblique <angle>'.
Because of this the return value needs to be widened to CSSValue.

Bug: 809935, 809938
Change-Id: I1de846595ed955455d57ab9f6ea45326e502a65b
Reviewed-on: https://chromium-review.googlesource.com/995273Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#548044}

Using wpt-import in Chromium e82b3aa4.
With Chromium commits locally applied on WPT:
a0c4bd61 "[css-typed-om] Support animation and transition properties."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15347

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
drott@chromium.org, kojii@chromium.org:
  external/wpt/css/css-fonts
foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org:
  external/wpt/infrastructure
jsbell@chromium.org:
  external/wpt/resources

TBR=foolip

No-Export: true
Change-Id: Id9ba0196f6749c5d3a2926819418a410149109ce
Reviewed-on: https://chromium-review.googlesource.com/995552
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548043}

This reverts commit c6e9dffe.

Reason for revert: Test WindowSelectorTest.DraggingWithTwoFingers is flaky on linux-chromeos-rel.

Original change's description:
> overview: Fix how multi touch works for overview drag.
> 
> Using two fingers was not restricted which brought a bunch of other bugs.
> Only allow one item to be dragged at a time. Still allows switching of
> fingers midway, so we just check the item which requests drag events is
> the same as the current drag item, instead of checking the gesture
> finger id.
> 
> Test: ash_unittests WindowSelectorTest.DraggingWithTwoFingers
> Bug: 827435
> Change-Id: I2c897b1b3c483b5df7a98a658f575a6ebd706acd
> Reviewed-on: https://chromium-review.googlesource.com/988294
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#547932}

TBR=oshima@chromium.org,sammiequon@chromium.org

Change-Id: I64783ce57b6773d3ea799597f66f644f0bba7a50
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 827435
Reviewed-on: https://chromium-review.googlesource.com/995732Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548042}

When audio stream do not support GetMaxVolume(), it will be spam to
query and update normalized volume every second, especially making
unsupported GetMaxVolume() print out warning msg. In this change, if the
first try to get |max_volume_| fails, |normalized_volume_| won't be set
and timer will not be started. This CL assumes that if GetMaxVolume()
doesn't work at first, it will not work all the time during the stream;
and user may StartAgc() again once the GetMaxVolume() start to work
after a while. Other behavior should have no difference.

Google Home, no longer have spamming warning msg, and work well.

Bug: NONE
Test: Build on desktop and test on appr.tc, no crash; built and run on
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic4af961df08cb4f1940604c44108ca08e80190c8
Reviewed-on: https://chromium-review.googlesource.com/954584Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548041}

Previously the SSID was used to identify networks, this poses several
problems however:
1. It's not precise enough as different networks can have the same SSID.
2. Accessing the SSID can be hinged on having location permission.
Instead this CL changes network identification to use the Network
objects for Android Marshmallow and later releases.  It might be
possible to use Network objects in Android Lollipop as well, but
Android Marshmallow added an efficient API for getting the default
Network.

Bug: 825939
Change-Id: Iff8c89a84c548693d7a8b0366003676720dfe1d0
Reviewed-on: https://chromium-review.googlesource.com/980967
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548040}

The flag was originally added to suppress messages from popping up if
the Windows shell failed to open the specified item.

Specifically, the ui::base::win::OpenAnyViaShell() function handles the
case where ShellExecute() returns ERROR_NO_ASSOCIATION when invoked with
the "open" verb by attempting to invoke the same using the "openas"
verb. Thus an intervening error message would not have been useful.
However the SEE_MASK_FLAG_NO_UI flag may suppress other error messages
and may also have side-effects beyond the display of failure messages.
See bug for details.

Bug: 819809
Change-Id: I8def155aa11b14f9a57a8f66add193dc281971cb
Reviewed-on: https://chromium-review.googlesource.com/966963
Commit-Queue: Asanka Herath <asanka@chromium.org>
Reviewed-by: Eric Lawrence <elawrence@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548039}

This enum was supposedly deprecated years ago and replaced by
GetUpdatesOrigin, but it was still used in many places. This removes
some of them.
It also introduces a new NudgeTracker::GetOrigin method, which is a
vastly simplified version of the existing GetLegacySource.

This is a partial reland of https://crrev.com/c/911628: It removes all
the uses of the deprecated enum within Chromium, but it does still send
it to the server (which still depends on it).

Bug: 510165
Change-Id: I21b7da89804b05fa67da625a04fba4abb859416f
Reviewed-on: https://chromium-review.googlesource.com/986376
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548038}

https://webrtc.googlesource.com/src.git/+log/644fde40a9c3..8058fbbd6bc0

$ git log 644fde40a..8058fbbd6 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:b/73741487,chromium:cl/186656928,chromium:b/77547687,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:none


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I98dbe4b99fbacf857b68e8269472ff2ab41e6233
Reviewed-on: https://chromium-review.googlesource.com/995173Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#548037}

This patch removes explicit delete and raw pointers and makes
ownership more clear by having WebSharedWorkerClient own
WebSharedWorker.

Change-Id: Ifd352b3effd9f2b46c9e61e792237ed3b6c2024a
Reviewed-on: https://chromium-review.googlesource.com/994893
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548036}

On CL Password Manager metrics were fixed. This CL implements proper
test for it. The idea of this test, is to reproduce exact call to
PasswordManager, namely:

OnPasswordFormsParsed
OnPasswordFormSubmitted
OnPasswordFormsParsed
ShowManualFallbackForSaving  <- here before fix, provisional_save_manager_ was dropped
OnPasswordFormsParsed

Bug: 827110
Change-Id: I4f7c850ba20078b1182d4eebf1701b39f113f74e
Reviewed-on: https://chromium-review.googlesource.com/995193Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548035}

Before, there was always a leak when the RunTaskAndPostReply callback
posted by PostTaskAndReplyImpl::PostTaskAndReply didn't run.

With this CL, the "task" is never leaked and the "reply" is only
leaked if the execution environment is shutdown before the deletion
happens (e.g. MessageLoop deleted, TaskScheduler shutdown).

Bug: 807013
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I05205d1b0250811abe61e2204ba32919d16c16c0
Reviewed-on: https://chromium-review.googlesource.com/902191Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548034}

Add a general counter for threads that are currently in incremental
marking.

This guard can be checked as first reason for bailing out in any write
barrier as it only requires a single load and does not need to go
through TLS or page lookups.

Bug: chromium:757440
Change-Id: Ida63e560bb52ccd66da739139c0510229b05a550
Reviewed-on: https://chromium-review.googlesource.com/995272
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548033}

The issue has been fixed in https://chromium-review.googlesource.com/982622.

R=machenbach@chromium.org

Bug: chromium:825741
Change-Id: I012a43e9b569600934ed29b269ee2f99805f6f12
Reviewed-on: https://chromium-review.googlesource.com/995277Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548032}

TemplateURLSet should be small enougth to use flat_set.
When implementing flat_sets, we specificly desided to provide a different
solution for Librayr Working Group issue: #2059, which allows to just
remove the const_cast.

Here is a test for it:
https://cs.chromium.org/chromium/src/base/containers/flat_tree_unittest.cc?sq=package:chromium&l=962

Change-Id: I4dfd5f3a5510c11ca4ef325dd0cb1e74fc7735f4
Reviewed-on: https://chromium-review.googlesource.com/995279Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Denis Yaroshevskiy <dyaroshev@yandex-team.ru>
Cr-Commit-Position: refs/heads/master@{#548031}

This tells the compiler to not look in various env vars (e.g. %INCLUDE%)
which makes the build slightly more hermetic.

(MSVC still uses the env files to get at %INCLUDE% so we can't pass /X to cl,
but clang-cl gets all system include dirs passed as -imsvc flags instead.)

Also move /utf-8 from the warnings config to the compiler config as it's
not a warning flag.

Bug: 691286
Change-Id: I5306d33bbfacd03a267b9d1c082297a26aadf9b8
Reviewed-on: https://chromium-review.googlesource.com/993552Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548030}

A second WrappedTestingCertVerifier and
g_cert_verifier_for_testing just arrived and in some
extreme (non standard) jumbo build configurations those
ended up in the same translation unit. Since translation units
only have one common anonymous namespace, there was a symbol clash.

This patch renames the global variables to
g_cert_verifier_for_io_thread_testing and
g_cert_verifier_for_profile_io_data_testing and renames the classes
to WrappedCertVerifierForIoThreadTesting and
WrappedCertVerifierForProfileIoDataTesting.

Change-Id: I41549bc81943864f64ce304220e20ab00d91c889
Reviewed-on: https://chromium-review.googlesource.com/992494Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#548029}

Replace usage of a bool by a counter to control whether or not the
parser is allowed to read new data or not.

Since WebDocumentLoader::BlockParser() is public, they may be several
components trying to pause the parser at the same time. Using a counter
make it possible to wait for all of them to call
WebDocumentLoader::ResumeParser().

This is a follow up for:
https://chromium-review.googlesource.com/982059

Bug: 822650
Change-Id: Id6d42f911f4b6e69ca942d8bf19acd296327d419
Reviewed-on: https://chromium-review.googlesource.com/992033Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548028}

The CredentialsContainer already declares [SecureContext] extended
attribute at the WebIDL. It makes the interface members exposed to only
secure context in binding level. Therefore, the manual check is
unnecesary because it is always true.

Bug: none
Change-Id: I58afb18a5be83d77d27ff513ef05f2cdaa1bf91a
Reviewed-on: https://chromium-review.googlesource.com/989644Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#548027}

The 'Emoji' item is added to the context menu for web content and
textfields. This menu item is hidden behind the kEnableEmojiContextMenu
flag. The flag definition, originally defined in crrev.com/c/988683, is
moved from chrome_features to ui_base_features, so it can be used in
both chrome/browser/ui/ and ui/views/controls/.

For more details, see http://go/chrome-emojisertion.

Change-Id: If8e558c24162be75f21053b1cd66906327fe124b
Reviewed-on: https://chromium-review.googlesource.com/988270Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Sarah Chan <spqchan@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548026}

testing config.

Bug: 814376
Change-Id: Ic164c023e6da9bb462807c6177d0a63ba4cf454a
Reviewed-on: https://chromium-review.googlesource.com/993132
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548025}

This CL adds the number of unread items in the ReadingList to the badge
associated with the ReadingList entry in the tools menu.

Bug: 826304
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id806406c1e1452793092afdefeb6937051e9bdaf
Reviewed-on: https://chromium-review.googlesource.com/992233
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548024}

No behavior change.

Bug: 776656
Change-Id: Ib5b7d88edd3752828f83d13b1e7a026cbd5a9aa9
Reviewed-on: https://chromium-review.googlesource.com/989525
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548023}