- 28 Jan, 2010 40 commits
-
-
dglazkov@chromium.org authored
No review, rolling out r54012. http://trac.webkit.org/changeset/54012 https://bugs.webkit.org/show_bug.cgi?id=34266 Introduced 33 crashes in V8 traversal/ tests. * bindings/js/ScriptController.cpp: (WebCore::ScriptController::mainWorldScriptState): * bindings/js/ScriptController.h: * bindings/js/ScriptState.cpp: * bindings/js/ScriptState.h: * bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack): * bindings/v8/ScriptController.cpp: (WebCore::ScriptController::mainWorldScriptState): (WebCore::ScriptController::currentScriptState): (WebCore::ScriptController::clearWindowShell): * bindings/v8/ScriptController.h: * bindings/v8/ScriptScope.cpp: (WebCore::ScriptScope::ScriptScope): (WebCore::ScriptScope::success): * bindings/v8/ScriptScope.h: * bindings/v8/ScriptState.cpp: (WebCore::ScriptState::ScriptState): (WebCore::scriptStateFromPage): * bindings/v8/ScriptState.h: (WebCore::ScriptState::ScriptState): (WebCore::ScriptState::frame): * bindings/v8/V8HiddenPropertyName.h: * bindings/v8/V8IsolatedContext.cpp: (WebCore::V8IsolatedContext::scriptState): * bindings/v8/V8IsolatedContext.h: * bindings/v8/V8Utilities.cpp: (WebCore::getScriptExecutionContext): (WebCore::reportException): * bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::V8NodeIterator::nextNodeCallback): (WebCore::V8NodeIterator::previousNodeCallback): * bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::V8TreeWalker::parentNodeCallback): (WebCore::V8TreeWalker::firstChildCallback): (WebCore::V8TreeWalker::lastChildCallback): (WebCore::V8TreeWalker::nextNodeCallback): (WebCore::V8TreeWalker::previousNodeCallback): (WebCore::V8TreeWalker::nextSiblingCallback): (WebCore::V8TreeWalker::previousSiblingCallback): * inspector/InspectorController.cpp: (WebCore::InspectorController::injectedScriptForNodeId): git-svn-id: svn://svn.chromium.org/blink/trunk@54016 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aa@chromium.org authored
to send the full URL of the requesting context, as well as a pointer to the document if that context was a document. git-svn-id: svn://svn.chromium.org/blink/trunk@54015 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Adam Barth. Fix missing forward-declarations and includes in V8 bindings https://bugs.webkit.org/show_bug.cgi?id=34272 No new tests, build fix only. * bindings/v8/ScriptController.h: Modified. Forward-declare NPObject * bindings/v8/V8DOMWindowShell.cpp: Modified. Include CString.h and PlatformBridge.h * bindings/v8/V8DOMWrapper.h: Modified. Forward-declare V8Proxy git-svn-id: svn://svn.chromium.org/blink/trunk@54014 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dglazkov@chromium.org authored
Unreviewed, trivial baseline update. Update baseline for "Animated scaling of background-image is too slow" https://bugs.webkit.org/show_bug.cgi?id=33808 * platform/mac/fast/backgrounds/size/backgroundSize16-expected.checksum: * platform/mac/fast/backgrounds/size/backgroundSize16-expected.png: git-svn-id: svn://svn.chromium.org/blink/trunk@54013 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yurys@chromium.org authored
Reviewed by Adam Barth. Remove ScriptState::frame which is only used for reporting exceptions in some cases in a way that diverges from the regular exception reporting in v8 bindings. Cache ScriptState directly on v8::Context instead of providing implementations specific for isolated worlds and ScriptController. https://bugs.webkit.org/show_bug.cgi?id=34266 * bindings/js/ScriptController.cpp: * bindings/js/ScriptController.h: * bindings/js/ScriptState.cpp: (WebCore::mainWorldScriptState): * bindings/js/ScriptState.h: * bindings/v8/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack): * bindings/v8/ScriptController.cpp: (WebCore::ScriptController::clearWindowShell): * bindings/v8/ScriptController.h: * bindings/v8/ScriptScope.cpp: (WebCore::ScriptScope::ScriptScope): (WebCore::ScriptScope::success): * bindings/v8/ScriptScope.h: * bindings/v8/ScriptState.cpp: (WebCore::ScriptState::ScriptState): (WebCore::ScriptState::forContext): (WebCore::ScriptState::current): (WebCore::ScriptState::empty): (WebCore::ScriptState::weakReferenceCallback): (WebCore::mainWorldScriptState): (WebCore::scriptStateFromPage): * bindings/v8/ScriptState.h: * bindings/v8/V8HiddenPropertyName.h: * bindings/v8/V8IsolatedContext.cpp: * bindings/v8/V8IsolatedContext.h: * bindings/v8/V8Utilities.cpp: (WebCore::getScriptExecutionContext): (WebCore::reportException): * bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::V8NodeIterator::nextNodeCallback): (WebCore::V8NodeIterator::previousNodeCallback): * bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::V8TreeWalker::parentNodeCallback): (WebCore::V8TreeWalker::firstChildCallback): (WebCore::V8TreeWalker::lastChildCallback): (WebCore::V8TreeWalker::nextNodeCallback): (WebCore::V8TreeWalker::previousNodeCallback): (WebCore::V8TreeWalker::nextSiblingCallback): (WebCore::V8TreeWalker::previousSiblingCallback): * inspector/InspectorController.cpp: (WebCore::InspectorController::injectedScriptForNodeId): git-svn-id: svn://svn.chromium.org/blink/trunk@54012 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aa@chromium.org authored
git-svn-id: svn://svn.chromium.org/blink/trunk@54011 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
abarth@webkit.org authored
Reviewed by David Levin. Remove XSSAuditor false positive for Google Translate https://bugs.webkit.org/show_bug.cgi?id=34242 Add a test that we allow attackers to inject directly into the href property of the base tag. * http/tests/security/xssAuditor/base-href-direct-expected.txt: Added. * http/tests/security/xssAuditor/base-href-direct.html: Added. * http/tests/security/xssAuditor/resources/echo-head-base-href-direct.pl: Added. 2010-01-28 Adam Barth <abarth@webkit.org> Reviewed by David Levin. Remove XSSAuditor false positive for Google Translate https://bugs.webkit.org/show_bug.cgi?id=34242 Google translate takes a base URL as a parameter, causing a false positive in the XSS filter. This patch removes the false positive by allowing direct injections into the href property of the base tag. Test: http/tests/security/xssAuditor/base-href-direct.html * page/XSSAuditor.cpp: (WebCore::XSSAuditor::canSetBaseElementURL): git-svn-id: svn://svn.chromium.org/blink/trunk@54010 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
zimmermann@webkit.org authored
Reviewed by Dirk Schulze. Save additional memory in SVG*Element classes, by introducing SVGElementRareData https://bugs.webkit.org/show_bug.cgi?id=34268 Introduce SVGElementRareData, to remove the need to store any members in SVGElement/SVGStyledElement. This saves some additional MB for the svg-node-count-vs-scroll.xhtml testcase. SVGElementRareData works just like NodeRareData. Unlike ElementRareData, we're not inheriting from NodeRareData in SVG, as we don't need all the rare data stored there, unlike Element. * GNUmakefile.am: Add SVGElementRareData.h to build. * WebCore.gypi: Ditto. * WebCore.pro: Ditto. * WebCore.vcproj/WebCore.vcproj: Ditto. * WebCore.xcodeproj/project.pbxproj: Ditto. * dom/Node.cpp: Use Nodes bitfield to keep track wheter a SVGElement has a SVGElementRareData object associated. (WebCore::Node::Node): * dom/Node.h: Add m_hasRareSVGData flag, merged with the existing bitfield, 10 bits remaining now. (WebCore::Node::hasRareSVGData): * svg/SVGAnimateMotionElement.cpp: SVGElement::instancesForElement() now returns a const-reference to the HashMap instead of copying. (WebCore::SVGAnimateMotionElement::applyResultsToTarget): * svg/SVGAnimateTransformElement.cpp: Ditto. (WebCore::SVGAnimateTransformElement::applyResultsToTarget): * svg/SVGAnimationElement.cpp: Ditto. (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue): * svg/SVGElement.cpp: Move the element instances HashSet and two cursor-related pointers into SVGElementRareData. (WebCore::SVGElement::SVGElement): (WebCore::SVGElement::~SVGElement): (WebCore::SVGElement::rareSVGData): Modelled just like Node::rareData(). (WebCore::SVGElement::ensureRareSVGData): Dito. (WebCore::SVGElement::accessDocumentSVGExtensions): (WebCore::SVGElement::mapInstanceToElement): Route call through SVGElementRareData. (WebCore::SVGElement::removeInstanceMapping): Ditto. (WebCore::SVGElement::instancesForElement): Ditto. (WebCore::SVGElement::setCursorElement): Ditto. (WebCore::SVGElement::setCursorImageValue): Ditto. * svg/SVGElement.h: * svg/SVGElementInstance.cpp: Ditto. (WebCore::SVGElementInstance::invalidateAllInstancesOfElement): * svg/SVGElementRareData.h: Added. Based on NodeRareData - works exactly the same. (WebCore::SVGElementRareData::SVGElementRareData): (WebCore::SVGElementRareData::rareDataMap): (WebCore::SVGElementRareData::rareDataFromMap): (WebCore::SVGElementRareData::elementInstances): (WebCore::SVGElementRareData::instanceUpdatesBlocked): (WebCore::SVGElementRareData::setInstanceUpdatesBlocked): (WebCore::SVGElementRareData::cursorElement): (WebCore::SVGElementRareData::setCursorElement): (WebCore::SVGElementRareData::cursorImageValue): (WebCore::SVGElementRareData::setCursorImageValue): * svg/SVGStyledElement.cpp: Move m_instancesUpdatesBlocked into SVGElementRareData. (WebCore::SVGStyledElement::SVGStyledElement): (WebCore::SVGStyledElement::instanceUpdatesBlocked): (WebCore::SVGStyledElement::setInstanceUpdatesBlocked): * svg/SVGStyledElement.h: * svg/SVGUseElement.cpp: Adapt to element instances changes, now passed as const-reference. (WebCore::dumpInstanceTree): git-svn-id: svn://svn.chromium.org/blink/trunk@54009 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aa@chromium.org authored
Reviewed by Darin Adler. Expand the NotificationPresenter::checkPermission() interface to send the full URL of the requesting context, as well as a pointer to the document if that context was a document. https://bugs.webkit.org/show_bug.cgi?id=34238 * notifications/Notification.cpp: (WebCore::Notification::Notification): * notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::NotificationCenter): (WebCore::NotificationCenter::checkPermission): Pass the full URL and document from the requesting context when calling NotificationPresenter::checkPermission(). * notifications/NotificationPresenter.h: (WebCore::NotificationPresenter::): Expand interface. 2010-01-27 Aaron Boodman <aa@chromium.org> Reviewed by Darin Adler. Send full URL and application id of requesting context to Chromium when checking notification permissions. https://bugs.webkit.org/show_bug.cgi?id=34238 * public/WebDocument.h: * src/WebDocument.cpp: (WebKit::WebDocument::applicationID): Implement applicationID() method. * public/WebNotificationPresenter.h: * src/NotificationPresenterImpl.cpp: (WebKit::NotificationPresenterImpl::checkPermission): * src/NotificationPresenterImpl.h: Send applicationID and full URL through to Chromium. 2010-01-27 Aaron Boodman <aa@chromium.org> Expand NotificationCenter::checkPermission() interface. It now passes the full URL instead of just the origin. https://bugs.webkit.org/show_bug.cgi?id=34238 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp: (WebDesktopNotificationsDelegate::checkPermission): * WebCoreSupport/WebDesktopNotificationsDelegate.h: git-svn-id: svn://svn.chromium.org/blink/trunk@54008 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jam@chromium.org authored
git-svn-id: svn://svn.chromium.org/blink/trunk@54007 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
simon.fraser@apple.com authored
Reviewed by Dan Bernstein. Video can overlap position:fixed element when scrolling https://bugs.webkit.org/show_bug.cgi?id=32180 When the scroll position changes, and we're using overlap to decide what gets composited, then we need to re-evaluate what gets compositing when scrolling in case fixed postion elements overlap composited elements (e.g. video). Test: compositing/geometry/video-fixed-scrolling.html * page/FrameView.cpp: (WebCore::FrameView::updateCompositingLayers): (WebCore::FrameView::scrollPositionChanged): Annotate the calls to updateCompositingLayers() with the type of change that occurred. * rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateCompositingAndLayerListsIfNeeded): Ditto. * rendering/RenderLayerCompositor.h: * rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateCompositingLayers): For scroll changes, check for hierarchy update if m_compositingConsultsOverlap is true, and do a geometry update. For other changes, always check for hierarchy updates. git-svn-id: svn://svn.chromium.org/blink/trunk@54006 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hyatt@apple.com authored
Fix for user stylesheet bugs where they get parsed using the wrong compatibility mode. This was a regression caused from Safari 3 -> 4 by the Acid3 fixes to create a real DOCTYPE in the DOM. Reviewed by Darin Adler. This patch makes style selector creation lazy, so that the selector isn't built unless someone asks for it. In order to avoid creating the style selector before the compatibility mode has been determined, document style is now created without having a dependence on an instantiated style selector. The creation of the style is now done as a static method on CSSStyleSelector called styleForDocument, and a couple of font-related functions have been made static as well so that they can be used by this method. m_styleSelector on Document is now an OwnPtr. Added userscripts/mixed-case-stylesheet.html * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForDocument): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::checkForGenericFamilyChange): (WebCore::CSSStyleSelector::setFontSize): (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize): (WebCore::CSSStyleSelector::fontSizeForKeyword): * css/CSSStyleSelector.h: * dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): (WebCore::Document::recalcStyle): (WebCore::Document::createStyleSelector): (WebCore::Document::attach): (WebCore::Document::setVisuallyOrdered): (WebCore::Document::recalcStyleSelector): * dom/Document.h: (WebCore::Document::styleSelector): (WebCore::Document::visuallyOrdered): * html/HTMLDocument.cpp: (WebCore::HTMLDocument::determineParseMode): * loader/PlaceholderDocument.cpp: (WebCore::PlaceholderDocument::attach): git-svn-id: svn://svn.chromium.org/blink/trunk@54005 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Alexey Proskuryakov. Add layout tests to verify assignment to items of NodeList https://bugs.webkit.org/show_bug.cgi?id=34213 * fast/dom/NodeList/nodelist-item-assignment-expected.txt: Added. * fast/dom/NodeList/nodelist-item-assignment.html: Added. git-svn-id: svn://svn.chromium.org/blink/trunk@54004 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Darin Adler. Rename ISODateTime.{cpp,h} to DateComponents.{cpp,h} https://bugs.webkit.org/show_bug.cgi?id=34245 No functional changes. * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * html/DateComponents.cpp: Copied from WebCore/html/ISODateTime.cpp. (WebCore::DateComponents::maxWeekNumberInYear): (WebCore::DateComponents::parseYear): (WebCore::DateComponents::addDay): (WebCore::DateComponents::addMinute): (WebCore::DateComponents::parseTimeZone): (WebCore::DateComponents::parseMonth): (WebCore::DateComponents::parseDate): (WebCore::DateComponents::parseWeek): (WebCore::DateComponents::parseTime): (WebCore::DateComponents::parseDateTimeLocal): (WebCore::DateComponents::parseDateTime): (WebCore::DateComponents::setMillisecondsSinceMidnightInternal): (WebCore::DateComponents::setMillisecondsSinceEpochForDateInternal): (WebCore::DateComponents::setMillisecondsSinceEpochForDate): (WebCore::DateComponents::setMillisecondsSinceEpochForDateTime): (WebCore::DateComponents::setMillisecondsSinceEpochForDateTimeLocal): (WebCore::DateComponents::setMillisecondsSinceEpochForMonth): (WebCore::DateComponents::setMillisecondsSinceMidnight): (WebCore::DateComponents::setMillisecondsSinceEpochForWeek): (WebCore::DateComponents::millisecondsSinceEpochForTime): (WebCore::DateComponents::millisecondsSinceEpoch): (WebCore::DateComponents::toStringForTime): (WebCore::DateComponents::toString): * html/DateComponents.h: Copied from WebCore/html/ISODateTime.h. (WebCore::DateComponents::DateComponents): * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseToDouble): (WebCore::HTMLInputElement::valueAsDate): (WebCore::HTMLInputElement::setValueAsDate): (WebCore::HTMLInputElement::setValueAsNumber): (WebCore::HTMLInputElement::formStringToDateComponents): * html/HTMLInputElement.h: * html/ISODateTime.cpp: Removed. * html/ISODateTime.h: Removed. * html/ValidityState.cpp: (WebCore::ValidityState::typeMismatch): git-svn-id: svn://svn.chromium.org/blink/trunk@54003 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ossy@webkit.org authored
* DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): * DumpRenderTree/qt/DumpRenderTreeQt.h: * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): * DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::display): git-svn-id: svn://svn.chromium.org/blink/trunk@54002 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Pavel Feldman. Use platform-specific monospace fonts in the Web Inspector Move the OS version detection code into the frontend, add custom CSS monospace styles for known platforms. https://bugs.webkit.org/show_bug.cgi?id=34040 * inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::platform): * inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement): * inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView): * inspector/front-end/InspectorBackendStub.js: (.WebInspector.InspectorBackendStub.prototype.releaseWrapperObjectGroup): (.WebInspector.InspectorBackendStub.prototype.setInjectedScriptSource): * inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createConditionElement): * inspector/front-end/inspector.css: * inspector/front-end/inspector.html: * inspector/front-end/inspector.js: (WebInspector.URLRegExp.i.get platform): (WebInspector._detectPlatform): git-svn-id: svn://svn.chromium.org/blink/trunk@54001 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] Implement the display() method of the layout test controller https://bugs.webkit.org/show_bug.cgi?id=34258 * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::showPage): (WebCore::DumpRenderTree::hidePage): * DumpRenderTree/qt/DumpRenderTreeQt.h: * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::display): * DumpRenderTree/qt/LayoutTestControllerQt.h: git-svn-id: svn://svn.chromium.org/blink/trunk@54000 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kenneth@webkit.org authored
default instead. Reviewed by Simon Hausmann. * WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::populate): git-svn-id: svn://svn.chromium.org/blink/trunk@53999 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
cjerdonek@webkit.org authored
check-webkit-style's cpp.py where it is no longer used. Reviewed by Shinichiro Hamaji. https://bugs.webkit.org/show_bug.cgi?id=34249 * Scripts/webkitpy/style/processors/cpp.py: - Reduced number of occurrences of "filename" variable from approximately 200 to 120. * Scripts/webkitpy/style/processors/cpp_unittest.py: - Refactored unit tests as necessary to accommodate changes to cpp.py. - Fixed bug in CppStyleTestBase.perform_include_what_you_use() where the incorrect file extension was getting passed to cpp_style.check_language(). git-svn-id: svn://svn.chromium.org/blink/trunk@53998 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
hausmann@webkit.org authored
Patch by Trond Kjernåsen <trond@trolltech.com> on 2010-01-28 Reviewed by Simon Hausmann. * Api/qwebframe.cpp: (QWebFrame::print): git-svn-id: svn://svn.chromium.org/blink/trunk@53997 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Timothy Hatcher. Simplify views logic in Profiler panel, and fix the problem described in the issue. Remove image from Welcome view. Preserve border on status bar-like buttons in Welcome view on window deactivation. https://bugs.webkit.org/show_bug.cgi?id=34201 * inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.show): (WebInspector.ProfilesPanel.prototype.reset): (WebInspector.ProfilesPanel.prototype.addProfileHeader): (WebInspector.ProfilesPanel.prototype.showView): (WebInspector.ProfilesPanel.prototype._updateInterface): * inspector/front-end/WelcomeView.js: (WebInspector.WelcomeView): * inspector/front-end/inspector.css: git-svn-id: svn://svn.chromium.org/blink/trunk@53996 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
zecke@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=33873 The WebCore::String::utf8 method will use the generic WebCore::TextCodec and then call the encode method on it. In QtWebKit this class is implemented around the QTextCodec class. Instead of going the generic codec way we treat the WebCore::String as a QString (no copying) and then use the built-in QString::toUtf8 to do the conversion. git-svn-id: svn://svn.chromium.org/blink/trunk@53995 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
benm@google.com authored
https://bugs.webkit.org/show_bug.cgi?id=34162 Reviewed by Simon Hausmann. WebCore: The pageX/pageY co-ordinates of a touch event should be relative to the containing frame, not the main frame. This change implements that and also updates the existing touch-inside-iframe test to also examine the page co-ordinates. * dom/Touch.cpp: (WebCore::Touch::Touch): Remove dead code. * dom/Touch.h: Remove dead code. * page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent): Rename framePoint to pagePoint, as it seems a clearer name. Also adjust the pagePoint to be relative to the touch target element's containing frame rather than the main frame. * platform/PlatformTouchEvent.h: Rename Android specific constructor parameter to better reflect it's contents. * platform/PlatformTouchPoint.h: Ditto. * platform/android/PlatformTouchEventAndroid.cpp: Ditto. * platform/android/PlatformTouchPointAndroid.cpp: Ditto. LayoutTests: Update the existing iframe touch event test to also examine the page co-ordinates of the touch that is received. * fast/events/touch/resources/touch-inside-iframe2.html: * fast/events/touch/touch-inside-iframe-expected.txt: * fast/events/touch/touch-inside-iframe.html: git-svn-id: svn://svn.chromium.org/blink/trunk@53994 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Pavel Feldman. Simplify isActivation method. https://bugs.webkit.org/show_bug.cgi?id=34161 Test: WebCore/manual-tests/inspector/debugger-scopes-inspection.html * bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::isActivation): git-svn-id: svn://svn.chromium.org/blink/trunk@53993 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
xan@webkit.org authored
[GTK] Can DnD files to our filechooser widget (<input type="file">) https://bugs.webkit.org/show_bug.cgi?id=34246 Skip failing test because of this missing feature. * platform/gtk/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@53992 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tkent@chromium.org authored
Reviewed by Darin Fisher. Remove tests for dates later than 275760-09-13T00:00Z. https://bugs.webkit.org/show_bug.cgi?id=34240 Date.UTC() of V8 doesn't support such dates though Date.UTC() of JavaScriptCore does. * fast/forms/input-valueasnumber-date-expected.txt: * fast/forms/input-valueasnumber-datetime-expected.txt: * fast/forms/input-valueasnumber-datetimelocal-expected.txt: * fast/forms/input-valueasnumber-month-expected.txt: * fast/forms/script-tests/input-valueasnumber-date.js: * fast/forms/script-tests/input-valueasnumber-datetime.js: * fast/forms/script-tests/input-valueasnumber-datetimelocal.js: * fast/forms/script-tests/input-valueasnumber-month.js: * platform/win/fast/forms/input-valueasnumber-datetime-expected.txt: Removed. git-svn-id: svn://svn.chromium.org/blink/trunk@53991 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Shinichiro Hamaji. In check-webkit-style, eliminated the dependency of processors/cpp_unittest.py on checker.py. https://bugs.webkit.org/show_bug.cgi?id=34205 * Scripts/webkitpy/style/checker.py: - Addressed FIXME by removing STYLE_CATEGORIES data. - Added style_categories(). * Scripts/webkitpy/style/checker_unittest.py: - Minor changes. * Scripts/webkitpy/style/processors/cpp.py: - Added categories attribute to CppProcessor class (data was originally checker.STYLE_CATEGORIES). * Scripts/webkitpy/style/processors/cpp_unittest.py: - Addressed FIXME by eliminating "import" from checker.py. git-svn-id: svn://svn.chromium.org/blink/trunk@53990 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Shinichiro Hamaji. Improve treatment of conditions and rest of the line for if, else, switch and alikes https://bugs.webkit.org/show_bug.cgi?id=34173 * Scripts/webkitpy/style/cpp_style.py: * Scripts/webkitpy/style/cpp_style_unittest.py: git-svn-id: svn://svn.chromium.org/blink/trunk@53989 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Adam Barth. Limit login retries to 5 https://bugs.webkit.org/show_bug.cgi?id=34193 * Scripts/webkitpy/bugzilla.py: git-svn-id: svn://svn.chromium.org/blink/trunk@53976 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tkent@chromium.org authored
Reviewed by Darin Adler. rangeOverflow/rangeUnderflow support for type=date https://bugs.webkit.org/show_bug.cgi?id=34209 * fast/forms/ValidityState-rangeOverflow-date-expected.txt: Added. * fast/forms/ValidityState-rangeOverflow-date.html: Added. * fast/forms/ValidityState-rangeUnderflow-date-expected.txt: Added. * fast/forms/ValidityState-rangeUnderflow-date.html: Added. * fast/forms/script-tests/ValidityState-rangeOverflow-date.js: Added. * fast/forms/script-tests/ValidityState-rangeUnderflow-date.js: Added. 2010-01-27 Kent Tamura <tkent@chromium.org> Reviewed by Darin Adler. rangeOverflow/rangeUnderflow support for type=date https://bugs.webkit.org/show_bug.cgi?id=34209 Add DATE type support to rangeUnderflow(), rangeOverflow(), minimum(), and maximum() of HTMLInputElement. In order to unify parsing code for value, min, and max strings, introduce parseToDouble() function and it is called by valueAsDate() and valueAsNumber() too. Tests: fast/forms/ValidityState-rangeOverflow-date.html fast/forms/ValidityState-rangeUnderflow-date.html * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::rangeUnderflow): Support DATE type, and use parseToDouble(). (WebCore::HTMLInputElement::rangeOverflow): ditto. (WebCore::HTMLInputElement::minimum): ditto. (WebCore::HTMLInputElement::maximum): ditto. (WebCore::HTMLInputElement::doubleValueFor): Added. (WebCore::HTMLInputElement::valueAsDate): Use parseToDouble(). (WebCore::HTMLInputElement::valueAsNumber): Use parseToDouble(). * html/HTMLInputElement.h: Declare parseToDouble(). git-svn-id: svn://svn.chromium.org/blink/trunk@53975 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
darin@chromium.org authored
Fix chromium build bustage (take 2). * bindings/scripts/CodeGeneratorV8.pm: Really treat V8CustomGetter like CustomGetter in all cases. git-svn-id: svn://svn.chromium.org/blink/trunk@53974 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ossy@webkit.org authored
* platform/qt/Skipped: fast/dom/Window/window-postmessage-clone-frames.html skipped. git-svn-id: svn://svn.chromium.org/blink/trunk@53973 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
darin@chromium.org authored
Fix chromium build bustage. * bindings/scripts/CodeGeneratorV8.pm: Treat V8CustomGetter like CustomGetter in all cases. git-svn-id: svn://svn.chromium.org/blink/trunk@53972 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
darin@chromium.org authored
Reviewed by Pavel Feldman. Expose HistoryItem::documentSequenceNumber https://bugs.webkit.org/show_bug.cgi?id=34243 * public/WebHistoryItem.h: * src/WebHistoryItem.cpp: (WebKit::WebHistoryItem::documentSequenceNumber): (WebKit::WebHistoryItem::setDocumentSequenceNumber): git-svn-id: svn://svn.chromium.org/blink/trunk@53971 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
oliver@apple.com authored
git-svn-id: svn://svn.chromium.org/blink/trunk@53970 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
oliver@apple.com authored
Reviewed by Maciej Stachowiak. MessageEvent.data should deserialize in the context of the MessageEvent's global object https://bugs.webkit.org/show_bug.cgi?id=34227 Add logic to allow us to create an Object, Array, or Date instance so we can create them in the context of a specific global object, rather than just using the current lexical global object. * JavaScriptCore.exp: * runtime/DateInstance.cpp: (JSC::DateInstance::DateInstance): * runtime/DateInstance.h: * runtime/JSGlobalObject.h: (JSC::constructEmptyObject): (JSC::constructEmptyArray): 2010-01-27 Oliver Hunt <oliver@apple.com> Reviewed by Maciej Stachowiak. MessageEvent.data should deserialize in the context of the MessageEvent's global object https://bugs.webkit.org/show_bug.cgi?id=34227 Test that the object returned from postMessage.data is created in the correct context * fast/dom/Window/resources/window-postmessage-clone-frames-frame.html: Added. * fast/dom/Window/window-postmessage-clone-frames-expected.txt: Added. * fast/dom/Window/window-postmessage-clone-frames.html: Added. 2010-01-27 Oliver Hunt <oliver@apple.com> Reviewed by Maciej Stachowiak. MessageEvent.data should deserialize in the context of the MessageEvent's global object https://bugs.webkit.org/show_bug.cgi?id=34227 Make ScriptValue deserialisation support the provision of a specific global object to use when creating new objects. This then allows us to make MessageEvent.data and PopStateEvent.state deserialize in the correct context. Test: fast/dom/Window/window-postmessage-clone-frames.html * bindings/js/JSPopStateEventCustom.cpp: Remove custom implementation of state getter * bindings/js/SerializedScriptValue.cpp: (WebCore::DeserializingTreeWalker::DeserializingTreeWalker): (WebCore::DeserializingTreeWalker::createOutputArray): (WebCore::DeserializingTreeWalker::createOutputObject): (WebCore::DeserializingTreeWalker::convertIfTerminal): (WebCore::SerializedScriptValueData::deserialize): (WebCore::SerializedScriptValue::deserialize): * bindings/js/SerializedScriptValue.h: (WebCore::SerializedScriptValue::deserialize): * bindings/scripts/CodeGeneratorJS.pm: Update bindings generation to pass the correct global object, and to treat "any" as synonymous with SerializedValue. * dom/PopStateEvent.idl: git-svn-id: svn://svn.chromium.org/blink/trunk@53969 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mrobinson@webkit.org authored
* Scripts/webkitpy/committers.py: git-svn-id: svn://svn.chromium.org/blink/trunk@53968 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Gustavo Noronha Silva. [GTK] Expose the IM context via the API https://bugs.webkit.org/show_bug.cgi?id=33327 Expose the GtkIMMultiContext as a property of WebKitWebView. This will allow embedders to generate the input method context menu entries and make testing certain IM context behavior possible. * webkit/webkitwebview.cpp: (webkit_web_view_get_property): (DNDContentsRequest::webkit_web_view_get_im_context): (DNDContentsRequest::webkit_web_view_class_init): git-svn-id: svn://svn.chromium.org/blink/trunk@53967 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Eric Carlson. Make media controls fade in/out transition duration configurable on a theme level. https://bugs.webkit.org/show_bug.cgi?id=34196 No new tests needed (I hope). * rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia): Removed constant from contructor - the initial value is meaningless. (WebCore::RenderMedia::updateControlVisibility): Get fade in/out duration from theme. * rendering/RenderTheme.h: (WebCore::RenderTheme::mediaControlsFadeInDuration): New virtual method. (WebCore::RenderTheme::mediaControlsFadeOutDuration): New virtual method. git-svn-id: svn://svn.chromium.org/blink/trunk@53966 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eric@webkit.org authored
Reviewed by Dimitri Glazkov. Tests that when a page removes an iframe that sleeps in its unload handler and terminates its JS execution, the outer page's JS continues running. https://bugs.webkit.org/show_bug.cgi?id=34226 * fast/dom/Window/slow-unload-handler-expected.txt: Copied from LayoutTests/fast/dom/Window/slow_unload_handler-expected.txt. * fast/dom/Window/slow-unload-handler-only-frame-is-stopped.html: Added. * fast/dom/Window/slow-unload-handler-only-frame-is-stopped-expected.txt: Added. * fast/dom/Window/slow-unload-handler.html: Copied from LayoutTests/fast/dom/Window/slow_unload_handler.html. * fast/dom/Window/slow_unload_handler-expected.txt: Removed. * fast/dom/Window/slow_unload_handler.html: Removed. * platform/gtk/Skipped: * platform/mac/Skipped: * platform/qt/Skipped: * platform/win/Skipped: 2010-01-27 John Abd-El-Malek <jam@chromium.org> Reviewed by Dimitri Glazkov. Tests that when a page removes an iframe that sleeps in its unload handler and terminates its JS execution, the outer page's JS continues running. https://bugs.webkit.org/show_bug.cgi?id=34226 Tests: fast/dom/Window/slow-unload-handler-only-frame-is-stopped.html fast/dom/Window/slow-unload-handler.html * bindings/v8/DateExtension.cpp: (WebCore::DateExtension::OnSleepDetected): git-svn-id: svn://svn.chromium.org/blink/trunk@53965 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-