- 17 Dec, 2019 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dd699690d0ec..f11fd1f6e72d git log dd699690d0ec..f11fd1f6e72d --date=short --first-parent --format='%ad %ae %s' 2019-12-17 fmalita@chromium.org Python3 tweaks Created with: gclient setdep -r src/third_party/skia@f11fd1f6e72d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I975e7278dd36a7743bdf864a89f83639a9daa47b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971781Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#725617}
-
Kyle Milka authored
Add more button to the bottom row that opens the system share sheet when pressed. Refactor the logic into the coordinator to seperate the top and bottom rows of the sharing hub. screenshot: http://screen/Rr6LdXLb9W6.png Bug: 1009124 Change-Id: I4208871ca049bdb722ca238de344737fe75dbc09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951653 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#725616}
-
Joe Mason authored
* List more build targets in README. * Add security.md describing sandbox setup. R=proberge Change-Id: I4f9668b44427cebe7879545e212504e49d61aee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960528 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#725615}
-
Olivier Li authored
The feature will soon be flipped to ENABLED_BY_DEFAULT. This will make HistoryServiceBackend's task runner dispatch to the ThreadPool instead of a dedicated base::Thread. The tests need to be prepared to stay functional when that happens. This is done as the last mile of the chrome-wide effort to coalesce as much work as possible to the ThreadPool. Bug: 661143 Change-Id: Ia8cbe38a5155a947de5cd04a41fb0d9134379050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965151 Auto-Submit: Oliver Li <olivierli@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#725614}
-
Dan Harrington authored
Various fixes for the feed library tests that were just imported. Now all tests should be running. Bug: 1024945 Change-Id: Id0184faabc21e77ee0bb2677dbf55b3091249aa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953570Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#725613}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ba4699fef545..115b7179356c git log ba4699fef545..115b7179356c --date=short --first-parent --format='%ad %ae %s' 2019-12-17 pkasting@chromium.org Escape forward slash to avoid undesired path conversion in Git 2.24.1(2). Created with: gclient setdep -r src/third_party/depot_tools@115b7179356c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I9a862e9e8778455572849873a940f065eec32278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971851Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6fd58b338859..768c5f438cad git log 6fd58b338859..768c5f438cad --date=short --first-parent --format='%ad %ae %s' 2019-12-17 yvesg@webrtc.org Roll chromium_revision faed30b4..98124fd6 (724977:725465) Created with: gclient setdep -r src/third_party/webrtc@768c5f438cad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I46497605989bff0cc34991f759a1c05b96b1e5b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971779Reviewed-by:
-
Dana Fried authored
This leverages some new built-in functionality in FlexLayout and AnimatingLayoutManager to make the icon container behave the way we want it to in most (hopefully all!) cases. Bug: 995448 Change-Id: I349f1e3dd57669848f936e9b531797bc087bad50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968244Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#725610}
-
Ian Prest authored
On the Windows+UIA platform, Narrator was not announcing recently deleted characters in an <input type="text"> field when 'backspacing' over them. Comparing the UIA implementation in Chromium & EdgeHTML, we found that we should fire a TextChanged event in addition to the ValueChanged event in this scenario. Bug: 1034729 Change-Id: Ib7423bd22cd709ac4813cfb3c0813911c704430e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970765Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Ian Prest <iapres@microsoft.com> Cr-Commit-Position: refs/heads/master@{#725609}
-
Robert Liao authored
--fetch will default to update.CLANG_REVISION if specified without an argument BUG= Change-Id: I2f5f5b7c9c446c92d9983d1f5a6ea01aee7f927c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970769Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#725608}
-
Francois Doray authored
The observer interface provides a way to observe when a PageNode is created for a WebContents on the main thread. This can be used by code that maintains a PageNode decorator using main thread data, to know when there there is a new PageNode for which the decorator should be maintained. There is no method to observe when a PageNode is destroyed. This is because code can use WebContentsObserver::WebContentsDestroyed() to know that a PageNode is destroyed as a result of WebContents destruction, or use a custom hook prior to PerformanceManagerRegistry destruction to know that all PageNodes are destroyed as a result of PerformanceManagerRegistry destruction. Bug: 1030399 Change-Id: I998de0055ea6d64fdddf4a144673ea5b47dccd9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967434Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#725607}
-
Wez authored
Bug: fuchsia:42135 Change-Id: I8ddb0af3287e62e6f9bd5d5c3524e6deed14b25e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959928 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#725606}
-
Sammie Quon authored
Requested from UX. Test: manual Change-Id: I8f647885215e1cd3a06396e1481f748e2f1421e6 Fixed: 1024319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970710Reviewed-by:
Min Chen <minch@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#725605}
-
Tom Anderson authored
This CL adds the initial wrapping functions that make use of dlsym(). In a followup, the get_gbm_* family of functions can be used to test feature support. BUG=1031269 R=msisov CC=spang Change-Id: Iab2d66eb702921b0c4d4d294fc3a98330c1f41c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970570 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#725604}
-
Elly Fong-Jones authored
On old mac kernels (at least through 10.12), if a send() is waiting in the kernel when a socket is closed, that send() can return EPROTOTYPE. This test doesn't expect this. Bug: 1034991 Change-Id: I6af067072860eaf4ed9c802b4d47f9e8c171875e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969074 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#725603}
-
Elly Fong-Jones authored
This test seems to flakily alternate between passing, timing out, and failing altogether on the Mac 10.13 bot. Bug: 1034789 Change-Id: Iae771725726f77cf8a3d84bd81887bf18161590c Tbr: rdevlin.cronin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969075Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#725602}
-
Yun Liu authored
This is related to: https://chromium-review.googlesource.com/c/chromium/tools/build/+/1969264 Can change tryjob name to "android-code-coverage-native" if preferred. Bug: 985574 Change-Id: I5b9bae9728a626dc9f34ab76c7ea207235cfa009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970332Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#725601}
-
Henrique Nakashima authored
This should be bypassable since any modification in the file triggers it, not only new usages. Bug: 1022108 Change-Id: I16fd61b04c9893b7f3b86d8e4e4498894719d523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970840Reviewed-by:
-
Francois Doray authored
The goal is to allow the public PerformanceManager to access the PerformanceManagerRegistryImpl to add observers. See https://chromium-review.googlesource.com/c/chromium/src/+/1967434 Bug: 1030399 Change-Id: I21fab4f33d18df1bb08f359239d2a4a775fac53b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970233Reviewed-by:
-
Elly Fong-Jones authored
As of r686131 DownloadItemView has a transparent button (class TransparentButton) as its first child view. This view, as a button, handles tooltip requests, but it doesn't have any tooltip text of its own. This change makes it return the parent DownloadItemView's tooltip text. Bug: 1031898 Change-Id: Iec82cd92fb3600fd0278b3e7682f3db657fe7114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967413Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#725598}
-
Etienne Bergeron authored
OnTextColorChanged is no longer used. This was useful before we collapsed the two pass in layout_text_ into a single pass. Bug: 1025561 Change-Id: I59406fdd7529e9bed94282fa4c3fac45100b019f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967205 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#725597}
-
Nodir Turakulov authored
Make the code more readable. R=agable@chromium.org, jbudorick@chromium.org Bug: 1033761 Change-Id: I71570c5fa7f70b9035cbc758a72fbe6f279b3465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971631 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
-
chrome://settingsDemetrios Papadopoulos authored
Specifically removing the following booleans showAndroidApps_ showCrostini_ showParentalControls_ showPluginVm_ havePlayStoreApp_ from settings-ui, settings-main, settings-menu and settings-basic-page. Bug: 1026455 Change-Id: I260e6acaf400062e053d3d760fbaa1a5765ea504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968752Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#725595}
-
Natalie Chouinard authored
This version of gn now automatically sorts all lists with variable names ending in the suffix "sources" or "deps". Bug: 1033668 Change-Id: I02d52745e3b3cc8fa4980f801f95bbc55a313e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970732Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#725594}
-
Kramer Ge authored
To finch Vulkan Skia-Adapter Layer on Linux, libvulkan1 needs to be installed. Bug: 1034606 Change-Id: I937a317bc87f1d174c96ccbda3e034fc6574cda9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970745Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#725593}
-
Tarun Bansal authored
This is no longer needed since NoStatePrefetch does not run JavaScript and it's not possible for webpage to call window.print during NoStatePrefetch. Change-Id: I28e26bf24c9c54334ec1eb5ba5bcdf7717c13617 Bug: 755936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961580Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#725592}
-
Shivani Sharma authored
Since the origins in NIK could be overwritten by etld+1 if the feature is enabled, this CL does the following: - Changes the getters to return original origins as that's what the consumers are dependent on. - Tests updated/added accordingly. Bug: 1030792, 1032081 Change-Id: I2718755a2fb03a8533728fde81ba62951ab39b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951550Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#725591}
-
Elly Fong-Jones authored
Bug: 1029778 Change-Id: Iec65c594897ddd45b8d8be06adb8b1d2e71ac4f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971970Reviewed-by:
-
Daniel Clark authored
This CL addresses a bug where form control popups do not respond to keyboard input on Mac when they are inside a cross-domain iframe. The keyboard input gets applied instead to the page (in the iframe) containing the control. This applies to the date/datetime-local <input> when FormControlsRefresh is disabled, and to both date/datetime-local <input> and the color <input> when FormControlsRefresh is enabled. For the top-level page and for same-domain (which is to say, in-proc) iframes, when a key event is received while a popup is open, the event is routed from the RenderWidgetInputHandler to the WebViewFrameWidget shim, which hands it to the WebView. WebViewImpl::HandleKeyEvent has code to check for an open popup and hand the key event off to it if one exists. For the cross-domain (and cross-proc) iframe case, the RenderWidgetInputHandler hands the event to a WebFrameWidgetImpl. WebFrameWidgetImpl::HandleKeyEvent lacks the code to check for and hand off to an open popup, so the event goes to the page containing the popup. This code addresses the issue by making WebFrameWidgetImpl::HandleKeyEvent handle the popup case in the same way that it's done in WebViewImpl::HandleKeyEvent. Windows was not affected by this issue. That seems to be because in Windows the RenderWidgetInputHandler passes the event directly to the WebPagePopupImpl for the popup, so the redirection in WebViewImpl::HandleKeyEvent / WebFrameWidgetImpl::HandleKeyEvent aren't needed. Bug: 980310 Change-Id: I0ecdb12dcc758ab9d36f84002306e83259b1b341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960510Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#725589}
-
Philipp Hancke authored
This change makes webrtc-internals convert any bytesSent/Received values into bitsSent/Received as bitrate is a much more common way to measure transfer for audio and video streams BUG=974143 Change-Id: Id5fc30646946264e4f5cb990cdd966a045b7302c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960347 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#725588}
-
Maksim Sisov authored
ozone_platform_gbm is compiled by default now. However, when we use Ozone/Wayland, we typically want to use Linux libgbm instead of minigbm, which has some additional defines and apis that Linux libgbm does not have. Even though, we have previously made minigbm apis correspond to upstream libgbm, there are still defines we cannot fix. Thus, mask out the defines if MINIGBM is not defined (look at minigbm's gbm.h file), and let the compilation go normally. This reduces the number of gn args developers have to play with and just fixes the compilation with ozone_platform_gbm=true(default) and use_system_minigbm=true. However, ozone/gbm is not usable with Linux platforms and this patch does not have an intention to make it work. Bug: 1033490 Change-Id: I506ed7dcbe4cae4d3dc283589839bb6532a5a5d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1964370Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6120ddc42548..c18669643541 git log 6120ddc42548..c18669643541 --date=short --first-parent --format='%ad %ae %s' 2019-12-17 eseckler@google.com Merge "processor: Support TracePacket/TrackEventDefaults" Created with: gclient setdep -r src/third_party/perfetto@c18669643541 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I253dee56d037e73b61d7e31843146b2a54ba415f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971776Reviewed-by:
-
Bailey Berro authored
- Continued from crrev.com/c/1929579 - Updates all OS Settings radio groups to remove extra navigation stops while preserving proper arrow key behavior and adding proper tabbing behavior. - Removed unnecessary link handling on the sync page radio button (clicking the Learn more link does not activate the button-row) Bug: 1015901 Change-Id: I4cb9c7d217cdeb58a7634e2a5b01c253490813b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948234 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#725585}
-
Sammie Quon authored
Test: added test Fixed: 1026962 Change-Id: I89e51a92bd8596e50099b755e48b355060fdd557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970434 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#725584}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6bad705d9b6c..dd699690d0ec git log 6bad705d9b6c..dd699690d0ec --date=short --first-parent --format='%ad %ae %s' 2019-12-17 robertphillips@google.com Update SKP version (take 2) 2019-12-17 halcanary@google.com skottie_ios_app: fix tap logic Created with: gclient setdep -r src/third_party/skia@dd699690d0ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: Ib7f02904fb554c3c3030d56e8af153c28b6b2fcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971774Reviewed-by:
-
Aaron Colwell authored
Change signin code to use a helper function that returns the signin StoragePartition directly instead of exposing details about the use of site URLs to get a storage partition. This hides implementation details from code that doesn't need to know about them and will make it easier to change these details without having to update callers. No behavior changes are introduced by this change. - Changed code to use WebViewGuest::GetSiteForGuestPartitionConfig() to create the partition site URL. This is intended to explicitly keep <webview> and signin code in sync instead of relying on implicit coordination. - Replaced GetSigninPartitionURL() with GetSigninPartition() and updated all callers. Bug: 1030932 Change-Id: Ie863643fa46e8b546bc4be889e093a09544f6dfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960680Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I7dffb09423da18e33fa1c49ad5964017323e6be8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971775Reviewed-by:
-
Anton Bikineev authored
This CL augments 69488b17 for data structures based on HashTable. It reorders resetting backing store pointer and moving of elements on backing reallocation. There is no reason to call write barrier or eagerly trace elements being just moved, since the newly allocated backing is white. Bug: 1021889 Change-Id: I553c95f59e92fd6654d8b666ade0938f4f34cd27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954464 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#725580}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-foundation/material-roboto-font-loader-ios/+log/4aa51e906e56..bc63eabbbd1e git log 4aa51e906e56..bc63eabbbd1e --date=short --first-parent --format='%ad %ae %s' 2019-04-10 rsmoore@google.com Revert "Remove unneeded fonts and unhint others. (#17)" (#19) 2019-04-10 rsmoore@google.com Revert "Remove extra `self = [super init]`. (#15)" (#18) 2019-04-10 dmaclach@gmail.com Remove unneeded fonts and unhint others. (#17) 2019-04-10 ccrazy88@users.noreply.github.com Remove extra `self = [super init]`. (#15) Created with: gclient setdep -r src/ios/third_party/material_roboto_font_loader_ios/src@bc63eabbbd1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/material-roboto-font-loader-ios-chromium Please CC bling-p10-rolls@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:ios-internal-mdc Bug: None Tbr: bling-p10-rolls@google.com Change-Id: I8d88136d7f3233cc17d0f5237b73cd9a0a4c8595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971459Reviewed-by:
-
sandromaggi authored
This adds a comment with our plan on how to move this font. Bug: b/144149405 Change-Id: I3cd08e8d025e80917ff89ab2925926cbdf08e3ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971918Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#725578}
-
