GitLab

Logs to chrome://media-internals when the container's keyframe metadata
for a frame mismatches the contents of that frame (if the latter was
determined by the respective bitstream converter's Analyze()
implementation, of whom only AVC currently does any keyframe analysis).

BUG=860420,584384
TEST=Repro crbug 860420 shows logs, new MP4StreamParserTest.AVC_Key* and media

Change-Id: Ic87eab8726ad76b36b569df08ab2212b267008c2
Reviewed-on: https://chromium-review.googlesource.com/1149153Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577751}

RenderTextHarfBuzzTest.MoveLeftRightByWordInChineseText doesn't
work on Android because of ICU issues. Use Thai instead to
compensate the testing coverage.

Bug: 865527
Change-Id: I39fb148bc8842716f8f93978bc7cdc0ab7af0f5c
Reviewed-on: https://chromium-review.googlesource.com/1147860
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577750}

Bug: 842908
Change-Id: I0487199b47488c741ca360f5c462ac46fcb8b487
Reviewed-on: https://chromium-review.googlesource.com/1149067Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577749}

This will eventually take the place of
GattClientManager::GetNumConnected. This moves bluetooth closer to being
fully async

Bug: 76155468
Test: chromecast/device/bluetooth/le/gatt_client_manager_impl_test.cc
Change-Id: I53d7eb0b2d5743165c1df5fe64903b86012a0346
Reviewed-on: https://chromium-review.googlesource.com/1147879Reviewed-by: Bailey Forrest <bcf@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Eli Ribble <eliribble@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577748}

The test is introduced and started flaking in https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/38257.
Suspecting https://chromium-review.googlesource.com/1146764.

TBR=xidachen

Bug: 867181
Change-Id: I5a772c76e9b68fe6e1aaa7a0feb34cd03a57aa31
Reviewed-on: https://chromium-review.googlesource.com/1149156Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577747}

Bug: 790547
Change-Id: Iee8b9a2dd00ed3b80dda8e34d3bfe15d3581bec1
Reviewed-on: https://chromium-review.googlesource.com/1149182Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577746}

When the close button is tapped for a GridCell while a reorder operation
is in-progress, cancel the reorder to avoid inconsistency exceptions
due to mismatched index paths.  Additionally, use the item identifier
supplied to the GridCell, as UICollectionView continuously updates the
index paths of the GridCells during the reorder gesture.  However, the
|-collectionView:moveItemAtIndexPath:toIndexPath:| callback is only
received at the end of the move operation.  This means that using the
index path supplied by the UICollectionView is out of sync with the
index of the GridItems.

Bug: 845889
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6099a1004c99b2f4ec94df81fbd0c70d362b833f
Reviewed-on: https://chromium-review.googlesource.com/1144277Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577745}

Currently the NotStreamingReason histogram is only recorded if we try to
start streaming a script, and is not updated for various situations where
we cancel streaming a script (e.g., we have a code-cache for the script).

This CL updates the tracking such that we record the reason script streaming
wasn't started, or was suppressed, and then record this in the histogram
when calling GetSource() on the ClassicPendingScript.

As part of this change, the logic for recording these histograms is moved
from ScriptStreamer to ClassicPendingScript. The ScriptStreamer::Type enum is
also moved to PendingScript and renamed ExecutionType, since it is no longer
used by the ScriptStreamer class.

BUG=865098

Change-Id: I20979352c6976e489d051a8432bbc51c39f428b0
Reviewed-on: https://chromium-review.googlesource.com/1142158
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577744}

Bug: 867023
Change-Id: Iacb0e3a1a5083d6f35564f4b0e3c6c9590c576d1
Reviewed-on: https://chromium-review.googlesource.com/1145775Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577743}

This improves the speed when loading the preview for the second time
from 170 to 60 ms for ~400 destinations and from 450 to 55 ms for ~3000
destinations. It also roughly halves the time to render highlights for
a search query with most destinations matching the query for the 3000
destination case (from 800 to 400ms) and reduces the time needed to
update after receiving new destinations from 400ms to 100ms for a 400
destination update and from 2000ms to 200ms for a ~2500 destination
update.

Bug: None
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: If96331d22708e0e3040cddf6adcd0462d281592e
Reviewed-on: https://chromium-review.googlesource.com/1143125Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577742}

Prior to this CL each replaced element type implemented its own clipping.
This CL refactors it so that a clip node will be applied in the common
path, ReplacedPainter::Paint(), so the specialized
XyzPainter::PaintReplaced() won't need to apply their own clips.

Note that ImagePainter still mutates its internal painting for changed
clip rect. This behavior should be changed in a follow-up CL, and
changing only the content box of a replaced element should only result
in incremental invalidation.

BUG=730284

Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia5c1412b1bd3182a22849d0b3196f3e72d52248a
Reviewed-on: https://chromium-review.googlesource.com/1147617
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577741}

Change-Id: Ie522ccac26eb0abd53be89a84901ea2ebf6cc276
Reviewed-on: https://chromium-review.googlesource.com/1148611
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577740}

This call isn't needed with the network service, since we pass the TransferrableURLLoader Mojo struct instead of stream URLs. When the PDF closes the main document load, the renderer will reset its Mojo pipe which will tell the network service to close the connection.

Bug: 705114, 856161
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I1c87753f7820f6b1ce80bf06ace5aab899d1b903
Reviewed-on: https://chromium-review.googlesource.com/1148590Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577739}

Because both Dictation and SelectToSpeak buttons are no longer behind a
flag in the trunk, it is no longer necessary to set the flag before
testing their behavior.

Bug: None
Change-Id: I2873149938070c8fc187fcfce515e6de5d879cd3
Reviewed-on: https://chromium-review.googlesource.com/1147203Reviewed-by: Katie Dektar <katie@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577738}

The ClientDiscardableManager may recycle handles internally if they are
deleted on the service without the caller's knowledge. So the caller
may try to lock an entry we are no longer tracking.

R=ericrk@chromium.org

Bug: 866434
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I5ea0b7fbb383fa5faee2464766e5d8bcd11f326e
Reviewed-on: https://chromium-review.googlesource.com/1148981Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577737}

Previously, it was possible that in the middle of closing a tab and
shutting down the main frame's process, we could call
ResetForNewProcess() to clear the main frame's children, but
destroying a child's RenderFrameHostImpl could reenter
TabStripModel::CloseWebContentses if the main frame was also waiting
for that child's beforeunload ACK.  This could result in freeing state
such as the WebContents or main frame's RFHM and RFHI, and then later
unwinding the stack to proceed with the first CloseWebContentses and
running into crashes when trying to dereference pointers which were
already freed or nulled out.

To prevent this reentrancy, schedule the beforeunload ACK in the cases
where it's used for tab close.  This is similar to a fix for issue
851400, but addresses a new way to get the reentrant calls that became
possible after r575133.

Bug: 866382, 866365
Change-Id: Id20068cb24f457f1fae1005050d46441dac78d9a
Reviewed-on: https://chromium-review.googlesource.com/1148775Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577736}

Fixes an issue where VideoTrackRecorder when used in combination with
VEAEncoder and very short recording durations (just 1 frame) would
occasionally hold on to video frames forever, causing frame buffers
from the buffer pool to become permanently blocked, eventually leading
to video capture freezing.

The cause was a circular ownership that would happen if only 1 frame
is recorded.

This CL additionally fixes a crash that could happen on initialization
of VEAEncoder. This issue was revealed during testing of the above fix.
Since it is not 100% if this crash was masked by the other issue, and
would only start occurring with the above fix, I am making a fix for that
part of this CL as well.

The cause for the crash issue was that class VEAEncoder, which uses
RefCountedThreadSafe<>, would post an asynchronous task from its
constructor. If this task would finish executing before the newly
constructed instance was assigned to a scoped_refptr<> by however
called the constructor, the instance would destroy itself, because
of the AddRef() and subsequent Release() done by the posting and
running of the asynchronous task.

The fix for this is to use a new method Initialize() instead of
posting a task from the constructor.

Bug: 859610
Change-Id: I6645aebfaa7659ab0ced0a20fae57eedfb9d84ab
Reviewed-on: https://chromium-review.googlesource.com/1145877
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577735}

This CL adds a feature flag for Mirroring Service and also notifies the
component extension whether Mirroring Service should be used for
tab/desktop mirroring.

The change in component extension side will come in a later CL. Before
then, there is no behavior change when enabling/disabling the flag.

Bug: 734672
Change-Id: I388cb193894c690e761169771531452afba09805
Reviewed-on: https://chromium-review.googlesource.com/1145622Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577734}

Change-Id: I563444233454e6713fd48218322bda5b58ff6ec3
Reviewed-on: https://chromium-review.googlesource.com/1148816Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577733}

This CL adds a small origin text slide animation for Windows
hosted app titlebars. This brings Windows closer to UI parity
with ChromeOS.

This change is hidden behind the DesktopPWAWindowing feature flag.

Screencast:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=348231&signed_aid=gIhJQdNaKHk_-6Ujfl2XxA==&inline=1

Bug: 854479
Change-Id: I848cab575dc4efa3001e5101b4d4795818a8369f
Reviewed-on: https://chromium-review.googlesource.com/1136270
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577732}

https://webrtc.googlesource.com/src.git/+log/d4c16b131f68..715cc238d24b


git log d4c16b131f68..715cc238d24b --date=short --no-merges --format='%ad %ae %s'
2018-07-24 emircan@webrtc.org Refactor VP9 decoder color space code
2018-07-24 emircan@webrtc.org Extract color space from Vp8 decoder


Created with:
  gclient setdep -r src/third_party/webrtc@715cc238d24b

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I0d176fe3311509778c26d19c2dec8e6625b64e1e
Reviewed-on: https://chromium-review.googlesource.com/1148613Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577731}

It started flaking on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/70474

TBR=fsamuel

Bug: 823043
Change-Id: I23a000160c81ed75a277331a6739095958ff6e77
Reviewed-on: https://chromium-review.googlesource.com/1149097Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577730}

Right now `checkIfAccessoryViewIsAvailableForForm` always return YES in the block. This
CL actually checks with the providers, and returns NO, if none has suggestions. This means
That no accessory will be provided by the form suggestion if no suggestion exists.
Gated to the AutofillManualFallback feature flag.

Bug: 845472
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id36c0e8280555dc87829b78e7b1d6a9ed6df88b7
Reviewed-on: https://chromium-review.googlesource.com/1136550
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577729}

TBR=mattm@chromium.org

Bug: 796230, 867174
Change-Id: I4ece7e608e597c9455bac468f828bdee91233c16
Reviewed-on: https://chromium-review.googlesource.com/1149197Reviewed-by: Nick Harper <nharper@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577728}

Bug: 846424
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I13dc5826152a1b3f8157342a7f1d644f333a89e2
Reviewed-on: https://chromium-review.googlesource.com/1144230
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577727}

https://chromium.googlesource.com/angle/angle.git/+log/ddd6e8746851..21edf3db5e33


git log ddd6e8746851..21edf3db5e33 --date=short --no-merges --format='%ad %ae %s'
2018-07-24 ynovikov@chromium.org Fix stencil mask check in Framebuffer::partialClearNeedsInit


Created with:
  gclient setdep -r src/third_party/angle@21edf3db5e33

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I207f8b26c7e21d06ab3900b2d5e2875c931522f7
Reviewed-on: https://chromium-review.googlesource.com/1148615Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577726}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ca7d881540e3..01ce05914f99


git log ca7d881540e3..01ce05914f99 --date=short --no-merges --format='%ad %ae %s'
2018-07-24 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@01ce05914f99

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I2ae0b7db67272beb622af6140f5152b02f73f0b9
Reviewed-on: https://chromium-review.googlesource.com/1148741Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577725}

This interface is *only* exposed in tests. It's to be used for tests that
want to generate events and ensure they are processed.

My plan is remove the existing interface
(services/ui/public/interfaces/event_injector.mojom) soonish.

BUG=852439
TEST=covered by tests

Change-Id: I2df1e5d428564f78b7280087a4f5453ce76b55b7
Reviewed-on: https://chromium-review.googlesource.com/1144472
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577724}

Also add a glFlush before calling GLFence::Create, as it should be
sufficient to trigger the crash.

Bug: 863817
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I589ba525d771895d00cf4aebfea57ce62f8add3f
Reviewed-on: https://chromium-review.googlesource.com/1148682
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577723}

This change takes the drop-down-search-box from the "Add Cups Printer"
dialog and makes it a cr-element so that it can be used elsewhere.

- Updates cups_add_printers_dialog to use cr-searchable-drop-down

Bug: 866146
Test: browser_tests
Change-Id: Ib0d953c3dbb1f51dad94a73451eb924d12d1b39e
Reviewed-on: https://chromium-review.googlesource.com/1145774
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577722}

Using the state produced some E2E tests to fail, because the button down
and button up events happen in the same frame.

Reason for TBR: fix failing tests on CI.

TBR: asimjour
Bug: 867016
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Icbc657838d80bf28d60ab2114625936aa4826883
Reviewed-on: https://chromium-review.googlesource.com/1148964
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577721}

https://chromium.googlesource.com/catapult.git/+log/e0ae2989b096..bd499d73987d


git log e0ae2989b096..bd499d73987d --date=short --no-merges --format='%ad %ae %s'
2018-07-24 dtu@chromium.org [pinpoint] Move bug template from GitHub to Monorail.
2018-07-24 simonhatch@chromium.org cloud_storage - Use default env if SWARMING_HEADLESS is set


Created with:
  gclient setdep -r src/third_party/catapult@bd499d73987d

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ib57f3a4061ba9a03f9805a371d14e203586761fe
Reviewed-on: https://chromium-review.googlesource.com/1148902Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577720}

Summary and description of an issue may contain non-ASCII characters, so
we need to use `unicode(issue)` instead of `str(issue)` to stringify an
issue.

Bug: 866873
Change-Id: I8d9a59c9c3864ccc21138b777dcf4e59637caf42
Reviewed-on: https://chromium-review.googlesource.com/1149010Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577719}

There are a large number of crashes dereferencing a null
ExtensionThrottleEntry. Temporarily adding a check for null
to eliminate crashes and allow time for further investigation.

TBR=rdevlin.cronin@chromium.org

Bug: 866798
Change-Id: I785c7b907d5377ea42b1452af45d73306b87bd1e
Reviewed-on: https://chromium-review.googlesource.com/1149064Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577718}

In preparation for logging when there appears to be a mismatch between
MSE MP4 keyframe metadata and the encoded video bitstream's keyframe
metadata, this change incorporates basic analysis of the latter as part
of the existing Annex-B bitstream validation for MSE MP4 video.

Note that mp4::BitstreamConverter::AnalysisResult contains
base::Optional<bool> for each of conformance and keyframe-ness fields.
If a field doesn't have a value, that portion of the result was not
analyzed.

Note that keyframe analysis is implemented only for AVC currently, but
even that is skipped if the frame is detected as non-conformant before
enough indications of whether or not it is a keyframe are detected.
Neither AVC-DV nor HEVC AnnexB analyses do any actual keyframe analysis,
since such was either skipped or not yet implemented previously,
respectively.

A subsequent CL will use the newly reported MSE MP4 video bitstream
converter's keyframe analysis results, if that analysis was done, in
reporting to chrome://media-internals when the bitstream keyframe-ness
mismatches that of the mp4 container for a coded frame.

BUG=860420,584384

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I169c7774070ad232c86658bcd7803160323993ad
Reviewed-on: https://chromium-review.googlesource.com/1144456
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577717}

This test was timing out with network service enabled, due to the
difference in behavior of the web request API in the network service.
With network service enabled, when the first web request rule or
listener is added, we reset all current URLLoaderFactories so they will
be proxied through WebRequestAPI. They are then rebound when the
connection error handler runs. This can lead to a situation where
messages are dropped, due to the error message arriving asynchronously.
For example:

(1) First web request listener added, URLLoaderFactory bindings cleared
(2) CreateLoaderAndStart is called on an existing URLLoaderFactory
(3) Error message reaches existing URLLoaderFactories, and they are reset

Due to the way mojo pipes work, the message from (2) will be dropped.
This change makes that much less likely by clearing the URLLoaderFactory
in the storage partition directly instead of waiting for the error
handler to be called.

Bug: 721414
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I633e3ea933f9170767371fde697bc9de2a5258af
Reviewed-on: https://chromium-review.googlesource.com/1147072Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577716}

[css-logical] Replace uses of webkit-prefixed logical properties with standard ones in styleguide, and add check to avoid future uses

Bug 850000 added standard logical properties and aliased prefixed ones
to them. The prefixed properties are still used in various places, but
the standard ones should be used instead. This patch updates the style
guide so that it refers to the standard properties, and adds a new CSS
presubmit check to ensure that the prefixed properties are not added
back anywhere.

Spec: https://drafts.csswg.org/css-logical/#box

BUG=862141

Change-Id: I50166e5bf13259302eb02aaa16ec299c9b2a4b0a
Reviewed-on: https://chromium-review.googlesource.com/1147524Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#577715}

1. Add rounded cap and join for the arrow.
2. Change from Point to PointF.

Bug: 861845
Change-Id: Id0019af3eb3f43136dcf13ebe5349ab6e309732b
Reviewed-on: https://chromium-review.googlesource.com/1148987Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577714}

This cl creates a mojo service for assistant audio decoder. The decoder
is running in utility process. This is a temporary solution until
MediaService for Chrome OS is implemented.

Bug: b/80315134
Test: manual tested can create the audio decoder for assistant.
Change-Id: Ib4d1a8d3e6d38b0cbb436e20e6d12033d74ed7cf
Reviewed-on: https://chromium-review.googlesource.com/1137020Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577713}

PrintingPdfContent() uses URLs to figure out if the content to be
printed is PDF or not. This does not work when printing Flash content.
Go back to checking PrintSettings::is_modifiable(), which already works
correctly on Mac. On Windows and Linux, the "is modifiable" setting
needs to be preserved when getting settings from the user in the native
print dialog.

BUG=859481

Change-Id: I674cf3c0f38b87c17fb6d2ca30ebae842c260d8c
Reviewed-on: https://chromium-review.googlesource.com/1146024Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577712}