- 26 Jul, 2018 40 commits
-
-
Amy Qiu authored
Create new recordings for pages in pathological mobile sites to ensure current sites are used for the rendering benchmark. Update URL for espn and add login for linkedin. Bug: 852530 Change-Id: I3f30d1b4daf7c4a850f8f759129f27be01a1751a Reviewed-on: https://chromium-review.googlesource.com/1148949Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Amy Qiu <amyqiu@google.com> Cr-Commit-Position: refs/heads/master@{#578315}
-
Amy Qiu authored
Now that it's been a week since pages in top_real_world_desktop were refreshed, remove the old pages. Also delete expectations for replaced pages. Bug: 852530 Change-Id: I3a702e877a56fe94a47add8b2254774d9c93fa28 Reviewed-on: https://chromium-review.googlesource.com/1150680Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Amy Qiu <amyqiu@google.com> Cr-Commit-Position: refs/heads/master@{#578314}
-
Elodie Banel authored
Displaying favicons with clear background, shrinking down to 16pt, and changing default icon. Bug: 860245 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I75e75d0bb21784441561e79a623002fdc2c95ae8 Reviewed-on: https://chromium-review.googlesource.com/1151111 Commit-Queue: Elodie Banel <lod@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#578313}
-
Marc Treib authored
This replaces most remaining ThreadTaskRunnerHandle/SingleThreadTaskRunner by SequencedTaskRunnerHandler/SequencedTaskRunner. There are some places that actually need thread-affinity (e.g. network stuff), or where it makes sense (UIModelWorker which is specifically for running on the UI thread). One remaining place I'm not sure about is WeakHandle. Bug: 846238 Change-Id: I704406fbf2c462537971eda0102c40626503b793 Reviewed-on: https://chromium-review.googlesource.com/1151296Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#578312}
-
Francois Doray authored
It is no longer necessary to invoke the DEFINE_WEB_CONTENTS_USER_DATA_KEY macro to define the global variable from which the key of a WebContentsUserData is derived. The key is now derived from a static local variable in WebContentsUserData::UserDataKey(). See https://chromium-review.googlesource.com/c/chromium/src/+/1093015 This CL was uploaded by git cl split. R=sky@chromium.org Bug: 589840 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie374511b52899d367e12c89f8f78e7717b4d6b6f Reviewed-on: https://chromium-review.googlesource.com/1150219Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#578311}
-
Francois Doray authored
It is no longer to invoke the DEFINE_WEB_CONTENTS_USER_DATA_KEY macro to define a global variable from which the key of a WebContentsUserData is derived. The key is now derived from a static local variable. This CL was uploaded by git cl split. R=sdefresne@chromium.org Bug: 589840 Change-Id: I7c899d2cfdb3a5c38f6d9a136b474c19f6370c71 Reviewed-on: https://chromium-review.googlesource.com/1150287Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#578310}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6031e69d34ff..17aff35e1dea git log 6031e69d34ff..17aff35e1dea --date=short --no-merges --format='%ad %ae %s' 2018-07-26 mbonadei@webrtc.org Enable clang::find_bad_constructs for sdk/ (part 1). 2018-07-26 nisse@webrtc.org Add missing include of stdint.h in MIPS code. 2018-07-26 hta@webrtc.org Add API to report "interesting" usage patterns to PC client Created with: gclient setdep -r src/third_party/webrtc@17aff35e1dea The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:866792 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iea50bc810d2af73a791ecb4ce508258083db91a4 Reviewed-on: https://chromium-review.googlesource.com/1151249Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578309}
-
Mounir Lamouri authored
This reverts commit dab9cc04. Reason for revert: <INSERT REASONING HERE> Original change's description: > Picture-in-Picture: show buttons when the mouse is hovering. > > This is fixing a Windows specific bug where the ENTER event isn't fired. > > Bug: 867646 > Change-Id: I79daf4679bdfaff00aadcf087bc89c27995fe0d9 > Reviewed-on: https://chromium-review.googlesource.com/1150892 > Reviewed-by: apacible <apacible@chromium.org> > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578212} TBR=mlamouri@chromium.org,apacible@chromium.org Change-Id: Ied59d027a5fb261ac3c436dacf2ba074e05dc773 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 867646 Reviewed-on: https://chromium-review.googlesource.com/1150703Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#578308}
-
Fady Samuel authored
Prior to this CL, SurfaceDependencyTracker read activation_dependencies from the pending CompositorFrame's CompositorFrameMetadata. This meant that it had to look up already resolved dependencies. It's more efficient to use the remaining dependencies set tracked in Surface directly. The code is also more compact and easier to read. In the first attempt to land, the CL iterated over activation_dependencies as they were changing. This resulted in a crash. The solution is to copy over the set before iteration. Bug: 672962 Change-Id: I3264f75b3fc71d7cd0368a63fcd38f7afcaf1cb0 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1148226Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1150675 Cr-Commit-Position: refs/heads/master@{#578307}
-
Ramya Nagarajan authored
Bug: 867719 Change-Id: I8f1368e86194c1732a7b7abb232cb137ea4ccf96 Reviewed-on: https://chromium-review.googlesource.com/1150978Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#578306}
-
Oscar Johansson authored
Building //media takes around 23 CPU minutes. A experimental branch showed that this could be reduced, by using jumbo, to around 9 CPU minutes. media/base is the second largest part of media and takes around 3.1 CPU minutes to compile without jumbo. This commit enables jumbo for media/base. Bug: 867350 Change-Id: Ie2dae0a65bfc596b30339712a39cab321e293f48 Reviewed-on: https://chromium-review.googlesource.com/1150037Reviewed-by:
Chrome Cunningham (In Paris) <chcunningham@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#578305}
-
Olivier Robin authored
Change-Id: Icb90e3167166a33d4c4214c306bc1faea86f31ae Reviewed-on: https://chromium-review.googlesource.com/1151201 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#578304}
-
Robert Kroeger authored
Ozone/drm/mojo assumes when running in single-process mode on one thread that the UI portion will be initialized before the GPU portion. CHECK this only in the single thread case instead of (wrongly) checking it in the single-process case as well. BUG=866263 TEST=by-hand with wait insertion with and without check change. Change-Id: I0029ac81f23c11153d8e2e027f7003f7f616af11 Reviewed-on: https://chromium-review.googlesource.com/1150845 Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#578303}
-
sebsg authored
This CL implements GetStorageKey() and GetClientTag() functions of the autofill wallet USS bridge. The implementation is compatible with the previous syncable service code. Bug: 853688 Change-Id: If86916ef6486b104685e615c68010ac9da281b61 Reviewed-on: https://chromium-review.googlesource.com/1148962 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#578302}
-
Xida Chen authored
In this previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/1149456 When projecting a touch-action rect to a graphics layer's space, the offset with regards to the layout object is accounted for. What we really need is the offset with regards to its transform node. The correctness can be proved by passing an existing test. Bug: 853912 Change-Id: I534bd2aa52552bc2ac12a0eec259d47c9cb73574 Reviewed-on: https://chromium-review.googlesource.com/1150928Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#578301}
-
Moe Ahmadi authored
Bug: 866922 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I37c634cc378214a10861b0a1fc3f8b3f8b97a2a3 Reviewed-on: https://chromium-review.googlesource.com/1149119Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#578300}
-
Stephen McGruer authored
Test is flaking consistently on the CQ: https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJwsSBUZsYWtlIhxCcm93c2VyVGVzdC5XaW5kb3dPcGVuQ2xvc2UyDA TBR=fsamuel@chromium.org Bug: 823043 Change-Id: I6103eb9fcb95e9e3afc77ab9da1740391fe5d211 Reviewed-on: https://chromium-review.googlesource.com/1151387Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#578299}
-
Joshua Peraza authored
93b1271e1b8d package.h: Update PACKAGE_COPYRIGHT_YEAR to 2018 20294e79cc09 android: Rename crashpad_handler_module target Change-Id: I1bfb07c0478ff050fab8e54ab2073e9c79a159f0 Reviewed-on: https://chromium-review.googlesource.com/1150975Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#578298}
-
Francois Doray authored
It is no longer necessary to invoke the DEFINE_WEB_CONTENTS_USER_DATA_KEY macro to define the global variable from which the key of a WebContentsUserData is derived. The key is now derived from a static local variable in WebContentsUserData::UserDataKey(). See https://chromium-review.googlesource.com/c/chromium/src/+/1093015 This CL was uploaded by git cl split. R=sadrul@chromium.org Bug: 589840 Change-Id: I26d9d7478b46c88bde21ec9ee095cebb26c0e520 Reviewed-on: https://chromium-review.googlesource.com/1150288 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#578297}
-
Francois Doray authored
It is no longer necessary to invoke the DEFINE_WEB_CONTENTS_USER_DATA_KEY macro to define the global variable from which the key of a WebContentsUserData is derived. The key is now derived from a static local variable in WebContentsUserData::UserDataKey(). See https://chromium-review.googlesource.com/c/chromium/src/+/1093015 This CL was uploaded by git cl split. R=rdevlin.cronin@chromium.org Bug: 589840 Change-Id: I8e7bbadce2f45929143f65aa54957a703432ed76 Reviewed-on: https://chromium-review.googlesource.com/1150286 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#578296}
-
Noel Gordon authored
Add tests cases for zipping a file: test Downloads, Drive, and USB, to get the "create-a-zip-file" integration test ball rolling. Test: browser_tests --gtest_filter="ZipFiles/FilesApp*zipCreate*" Bug: 864256,865197,867738 Change-Id: I28c2da7bd5662ef944659c11529d963cf81d48ed Reviewed-on: https://chromium-review.googlesource.com/1151068 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#578295}
-
Francois Doray authored
It is no longer necessary to invoke the DEFINE_WEB_CONTENTS_USER_DATA_KEY macro to define the global variable from which the key of a WebContentsUserData is derived. The key is now derived from a static local variable in WebContentsUserData::UserDataKey(). See https://chromium-review.googlesource.com/c/chromium/src/+/1093015 This CL was uploaded by git cl split. R=torne@chromium.org Bug: 589840 Change-Id: I4fbd69c788fc06549d32b4d12199309bbd1bbe1f Reviewed-on: https://chromium-review.googlesource.com/1150283 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#578294}
-
Francois Doray authored
On Windows, chrome.dll and chrome_child.dll are expected to be found in a versioned sub-directory for proper installs and in the executable's directory for dev builds. When chrome.exe is launched, it is preferable to look in the versioned directory first, because this is where the DLLs will be found for real users. Also, this will ensure proper execution when external programs put non-official DLLs in the executable's directory. Bug: 778958 Change-Id: I89d3904da6987ef7659c2daa2012cf2d3a8dab3b Reviewed-on: https://chromium-review.googlesource.com/1150201Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#578293}
-
Anita Woodruff authored
- Previously, MediaNotificationManagerServiceLifecycleTest had a test which failed when run individually, despite passing when all of the tests in that class were run, presumably due to the custom shadow observer picking up on notifications shown by other tests. - The only way I could get the test to always pass while still using the custom shadow observer was to reset the observer at the start of the test, and change the production code to notify via the non-compat NotificationManager. - However, turns out we can simply query Robolectric's built-in shadow of the notification manager, which has a convenient accessor method for the number of notifications it has shown, works for notifications posted to NotificationManagerCompat, and doesn't appear to need manual resetting. - Hence deleting the inferior MediaNotificationTestShadowNotificationManager Bug: 867879 Change-Id: I14639648c8c1f3e0740da4bb1877b9aa21424e33 Reviewed-on: https://chromium-review.googlesource.com/1151304Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#578292}
-
Aldo Culquicondor authored
PlatformController button types and GVR button types where being intermixed, causing the gesture detector to introduce events for the wrong button. Bug: 867016 Change-Id: I4efc4ba6d856a39b2e32f19629e5bc7b07c9a9a1 Reviewed-on: https://chromium-review.googlesource.com/1150722Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#578291}
-
James Hawkins authored
This change removes unused X11 includes, which fixes the ui/base:ui_base_unittests target on the cros chrome-sdk shell build. R=yhanada@chromium.org Bug: 867013 Test: none Change-Id: I42f1d1e72f9cbe35ca585764db19353e8721bfbc Reviewed-on: https://chromium-review.googlesource.com/1150507Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#578290}
-
Kim Paulhamus authored
This is a reland of 06d88933 Original change's description: > Disable flaky LifecycleTest (Exe_TerminateProcess) on Fuchsia > > TBR: jam@chromium.org > Bug: 863166 > Change-Id: I9e31154c0ba8cdc5fff7af5130c8a06029a4bdaa > Reviewed-on: https://chromium-review.googlesource.com/1136029 > Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> > Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574942} TBR: jam Bug: 863166 Change-Id: Ie5c02a954b9d51f6ec24c99de38af8f2a0216dfa Reviewed-on: https://chromium-review.googlesource.com/1151310 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#578289}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/42016a47fa2b..f07f60ef0baa git log 42016a47fa2b..f07f60ef0baa --date=short --no-merges --format='%ad %ae %s' 2018-07-26 kraynov@chromium.org Drop Scheduler and FrameScheduler prefixes to save space. Created with: gclient setdep -r src/third_party/catapult@f07f60ef0baa The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866875 TBR=sullivan@chromium.org Change-Id: Iaa63dd52d566926c5503ba449314f18d3e0a13c6 Reviewed-on: https://chromium-review.googlesource.com/1151208Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578288}
-
stkhapugin@chromium.org authored
Minor improvements to the location bar layout. Bug: 865379 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5a7bfbc397cda4fdb607166dd7d5f0c3dfc468e1 Reviewed-on: https://chromium-review.googlesource.com/1151196Reviewed-by:
Elodie Banel <lod@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#578287}
-
kylechar authored
This reverts commit 1ff7430b. Reason for revert: Revert didn't fix the problem. Original change's description: > Revert "Remove unnecessary Flush() in ~GLInProcessContext()." > > This reverts commit d6ce677a. > > Reason for revert: > > It looks like this caused Asan bot failures: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28394 > > See the details at crbug.com/867786 > > Original change's description: > > Remove unnecessary Flush() in ~GLInProcessContext(). > > > > ~GLES2Implementation() already calls Finish(), so remove the redundant > > Flush(). This should avoid allocating memory just to send the flush > > command with OOP-D. > > > > Bug: 866486 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > > Change-Id: Ia8513920e2f0d65e89b0213310e6477d732ca08a > > Reviewed-on: https://chromium-review.googlesource.com/1150662 > > Commit-Queue: kylechar <kylechar@chromium.org> > > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#578078} > > TBR=sunnyps@chromium.org,kylechar@chromium.org > > Change-Id: Iceeec3fc7e1807363583fb80df89642c99907a4d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 866486 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Reviewed-on: https://chromium-review.googlesource.com/1150062 > Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> > Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578227} TBR=hajimehoshi@chromium.org,sunnyps@chromium.org,kylechar@chromium.org Change-Id: Ib0a8a8caf06b97088cf9e7781f941a9ba181d2c5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 866486 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1150543Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#578286}
-
Greg Kraynov authored
First step in splitting TaskQueue and SingleThreadTaskRunner impl. Blink's TaskQueueWithTaskType got removed along the way. Design doc: https://docs.google.com/document/d/1vJXk2HAd7P0_sAjRWwl5jjEq027zG-CQN6mV3l7lWJs TBR=gab@chromium.org Bug: 865411 Change-Id: Ibc465034a15d48abcf5125358efb0d3ee755728e Reviewed-on: https://chromium-review.googlesource.com/1143402 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#578285}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e99f57f96ba3..3190ae3f2fd3 git log e99f57f96ba3..3190ae3f2fd3 --date=short --no-merges --format='%ad %ae %s' 2018-07-26 maybelle@chromium.org Add new password-viewers group. Created with: gclient setdep -r src/third_party/chromite@3190ae3f2fd3 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ieab3b9cb81faffa5497ee0f7d9753cb00d9aef18 Reviewed-on: https://chromium-review.googlesource.com/1151207Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578284}
-
Mythri Alle authored
We to store the code generated for javascript resources in a separate cache [1]. This cl just creates a code cache, one instance per each storage partition. I will follow it up with other cls that actually start using this cache. This feature is behind a flag. [1] docs.google.com/document/d/1O_PVZPn37Ev3_DWJjQLX-gid__OKxnXP1UsE8g_YkRY Bug: chromium:812168 Change-Id: I610f640faec1fc331936e6388344c2975d268b4a Reviewed-on: https://chromium-review.googlesource.com/1120179Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#578283}
-
Mohamed Amir Yosef authored
Bug: 516866 Change-Id: Ib4468657fdc16f60216acd3375cd45bbfd0121e3 Reviewed-on: https://chromium-review.googlesource.com/1148727 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#578282}
-
Kent Tamura authored
<input>: INPUT element with unknown type attribute value should be rendered same as <input type=text>. Non-macOS and macOS have different default padding for text-field <input>. html.css specifies padding for macOS, and themeWin.css specified padding for non-macOS only for specific input types, and unknown input types, which are fell back to type=text, were not covered by themeWin.css. Bug: 747752 Change-Id: I2165380868acf54eeb42dfa3109a989418a62c83 Reviewed-on: https://chromium-review.googlesource.com/1150940 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#578281}
-
Mohamed Amir Yosef authored
This CL makes sure the bookmark model is updated properly upon receving a remote bookmark node move under the same parent or under another parent. Bug: 516866 Change-Id: I84dd7d28db47d52d94504f93ae30928203addcf1 Reviewed-on: https://chromium-review.googlesource.com/1146192 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#578280}
-
Ned Nguyen authored
This depends on https://chrome-internal-review.googlesource.com/c/infradata/config/+/655985 NOTRY=true # CQ flake Bug: 863767 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I4dd1a3c71ffa03cb4eb4fccbe9660b5f972c2094 Reviewed-on: https://chromium-review.googlesource.com/1150898 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#578279}
-
Stephen McGruer authored
Using the Web Animations getAnimations() API, it is possible to set the effect of a CSS animation to null. Doing so previously caused a crash when processing updated animations - this CL fixes that. Bug: 866833 Change-Id: I3689b6d2b69cf9ccfca82010fa0d0d55ee931314 Reviewed-on: https://chromium-review.googlesource.com/1150404Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#578278}
-
Christian Dullweber authored
Value::Set() is deprecated and Value::SetKey/Path() should be used instead. base::ValueConversions returns unique_ptr<base::Value> which is hard to use with the new SetKey/Path methods because they expect a Value. This CL converts CreateFilePathValue, CreateTimeDeltaValue and CreateUnguessableTokenValue to return a Value instead of a unique_ptr. Tbr: benwells@chromium.org, bauerb@chromium.org, pfeldman@chromium.org, qinmin@chromium.org, xhwang@chromium.org Change-Id: Ia464bce2cdd74e0e1b51b57050cac3c0176893f8 Reviewed-on: https://chromium-review.googlesource.com/1150036 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#578277}
-
Alexander Timin authored
Create a component to unify renderer process and browser process metrics, including EQT. R=jochen@chromium.org CC=alexclarke@chromium.org,eseckler@chromium.org,skyostil@chromium.org,gab@chromium.org,fdoray@chromium.org,npm@chromium.org,tdresser@chromium.org Change-Id: I8a356206f6beeebba7de0c0d597a1cc60607dd8b Reviewed-on: https://chromium-review.googlesource.com/1135133 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#578276}
-